* RE: [RFC 2/2] ethtool: Add support for DMA Coalescing feature config to ethtool.
From: Ben Hutchings @ 2011-06-16 23:53 UTC (permalink / raw)
To: Wyborny, Carolyn; +Cc: netdev@vger.kernel.org
In-Reply-To: <EDC0E76513226749BFBC9C3FB031318F016C7DEB5B@orsmsx508.amr.corp.intel.com>
On Tue, 2011-06-14 at 13:19 -0700, Wyborny, Carolyn wrote:
[...]
> Ok, will send up update with the suggested changes and an
> implementation as an example. I have one, but will wait to synch it
> with the updated patch. Do you want another RFC or a regular patch
> submission?
That's really for you to decide.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [PATCH 05/14] SIWv2: User interface: siw_verbs.h, siw_verbs.c, siw_user.h, siw_ae.c
From: Andi Kleen @ 2011-06-17 0:14 UTC (permalink / raw)
To: Bernard Metzler
Cc: public-netdev-u79uwXL29TY76Z2rM5mHXA,
public-linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1308228127-22634-1-git-send-email-bmt@zurich.ibm.com>
Bernard Metzler <bmt-OA+xvbQnYDHMbYB6QlFGEg@public.gmane.org> writes:
> +
> +/*
> + * siw_async_ev()
> + *
> + * Report Asynchonous event to user.
> + */
> +void siw_async_ev(struct siw_qp *qp, struct siw_cq *cq,
> + enum ib_event_type etype)
> +{
> + static struct ib_event event;
Static? That looks scary, especially without a lock.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
^ permalink raw reply
* Re: [PATCH] iptables: document IPv6 TOS mangling bug in old Linux kernels
From: Fernando Luis Vázquez Cao @ 2011-06-17 1:11 UTC (permalink / raw)
To: Patrick McHardy
Cc: Jan Engelhardt, Maciej, Pablo Neira Aysuo,
Netfilter Developer Mailing List,
Linux Networking Developer Mailing List
In-Reply-To: <4DFA1DFC.3000804@trash.net>
Hi Jan, Patrick,
On Thu, 2011-06-16 at 17:15 +0200, Patrick McHardy wrote:
> On 16.06.2011 17:06, Jan Engelhardt wrote:
> > I feel this should be listed in the TOS page, to avoid duplication.
>
> I agree with Jan, just the TOS man page seems fine.
I will be replying to this email with the update patch.
Thanks,
Fernando
^ permalink raw reply
* [PATCH] iptables: document IPv6 TOS mangling bug in old Linux kernels
From: Fernando Luis Vázquez Cao @ 2011-06-17 1:14 UTC (permalink / raw)
To: Patrick McHardy, Jan Engelhardt
Cc: Maciej, Pablo Neira Aysuo, Netfilter Developer Mailing List,
Linux Networking Developer Mailing List
In-Reply-To: <1308273097.8612.1.camel@nexus.oss.ntt.co.jp>
In Linux kernels up to and including 2.6.38, with the exception of longterm
releases 2.6.32.42 (or later) and 2.6.33.15 (or later), there is a bug (*) whereby
IPv6 TOS mangling does not behave as documented and differs from the IPv4
version. The TOS mask indicates the bits one wants to zero out, so it needs to
be inverted before applying it to the original TOS field. However, the
aformentioned kernels forgo the inversion which breaks --set-tos and its
mnemonics.
(*) Fixed by upstream commit:
1ed2f73d90fb49bcf5704aee7e9084adb882bfc5 (netfilter: IPv6: fix DSCP mangle code)
Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
---
diff -urNp iptables-1.4.11.1-orig/extensions/libxt_TOS.man iptables-1.4.11.1/extensions/libxt_TOS.man
--- iptables-1.4.11.1-orig/extensions/libxt_TOS.man 2011-06-08 22:26:17.000000000 +0900
+++ iptables-1.4.11.1/extensions/libxt_TOS.man 2011-06-17 10:07:58.873127519 +0900
@@ -4,24 +4,33 @@ shares the same bits as DSCP and ECN. Th
\fBmangle\fP table.
.TP
\fB\-\-set\-tos\fP \fIvalue\fP[\fB/\fP\fImask\fP]
-Zeroes out the bits given by \fImask\fP and XORs \fIvalue\fP into the
-TOS/Priority field. If \fImask\fP is omitted, 0xFF is assumed.
+Zeroes out the bits given by \fImask\fP (see NOTE below) and XORs \fIvalue\fP
+into the TOS/Priority field. If \fImask\fP is omitted, 0xFF is assumed.
.TP
\fB\-\-set\-tos\fP \fIsymbol\fP
You can specify a symbolic name when using the TOS target for IPv4. It implies
-a mask of 0xFF. The list of recognized TOS names can be obtained by calling
-iptables with \fB\-j TOS \-h\fP.
+a mask of 0xFF (see NOTE below). The list of recognized TOS names can be
+obtained by calling iptables with \fB\-j TOS \-h\fP.
.PP
The following mnemonics are available:
.TP
\fB\-\-and\-tos\fP \fIbits\fP
Binary AND the TOS value with \fIbits\fP. (Mnemonic for \fB\-\-set\-tos
-0/\fP\fIinvbits\fP, where \fIinvbits\fP is the binary negation of \fIbits\fP.)
+0/\fP\fIinvbits\fP, where \fIinvbits\fP is the binary negation of \fIbits\fP.
+See NOTE below.)
.TP
\fB\-\-or\-tos\fP \fIbits\fP
Binary OR the TOS value with \fIbits\fP. (Mnemonic for \fB\-\-set\-tos\fP
-\fIbits\fP\fB/\fP\fIbits\fP.)
+\fIbits\fP\fB/\fP\fIbits\fP. See NOTE below.)
.TP
\fB\-\-xor\-tos\fP \fIbits\fP
Binary XOR the TOS value with \fIbits\fP. (Mnemonic for \fB\-\-set\-tos\fP
-\fIbits\fP\fB/0\fP.)
+\fIbits\fP\fB/0\fP. See NOTE below.)
+.PP
+NOTE: In Linux kernels up to and including 2.6.38, with the exception of
+longterm releases 2.6.32.42 (or later) and 2.6.33.15 (or later), there is a bug
+whereby IPv6 TOS mangling does not behave as documented and differs from the
+IPv4 version. The TOS mask indicates the bits one wants to zero out, so it needs
+to be inverted before applying it to the original TOS field. However, the
+aformentioned kernels forgo the inversion which breaks --set-tos and its
+mnemonics.
^ permalink raw reply
* Re: [PATCH 0/8] netfilter: netfilter fixes for -rc1
From: David Miller @ 2011-06-17 1:43 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel, netdev
In-Reply-To: <1308253301-29894-1-git-send-email-kaber@trash.net>
From: kaber@trash.net
Date: Thu, 16 Jun 2011 21:41:35 +0200
> Please apply or pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-2.6.git master
Pulled, thanks Patrick.
^ permalink raw reply
* Re: [PATCH 00/20] netfilter: netfilter update
From: David Miller @ 2011-06-17 1:54 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel, netdev
In-Reply-To: <1308253640-29942-1-git-send-email-kaber@trash.net>
From: kaber@trash.net
Date: Thu, 16 Jun 2011 21:47:00 +0200
> Hi Dave,
>
> following is a netfilter update for nf-next-2.6.git, containing
>
> - IPVS cleanups from Hans
>
> - a big ipset update from Jozsef
>
> - support for more FTP PASV responses in the IPVS FTP helper, from Julian
>
>
> Please apply or pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git master
Pulled, thanks!
^ permalink raw reply
* Re: [PATCH] net/usb: Add Samsung Kalmia driver for Samsung GT-B3730
From: David Miller @ 2011-06-17 2:01 UTC (permalink / raw)
To: marius.kotsbak; +Cc: netdev, linux-usb, marius
In-Reply-To: <1307882102-31659-1-git-send-email-marius@kotsbak.com>
From: "Marius B. Kotsbak" <marius.kotsbak@gmail.com>
Date: Sun, 12 Jun 2011 14:35:02 +0200
> Introducing driver for the network port of Samsung Kalmia based USB LTE modems.
> It has also an ACM interface that previous patches associates with the "option"
> module. To access those interfaces, the modem must first be switched from modem
> mode using a tool like usb_modeswitch.
>
> As the proprietary protocol has been discovered by watching the MS Windows driver
> behavior, there might be errors in the protocol handling, but stable and fast
> connection has been established for hours with Norwegian operator NetCom that
> distributes this modem with their LTE/4G subscription.
>
> More and updated information about how to use this driver is available here:
>
> http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?t=465
> https://github.com/mkotsbak/Samsung-GT-B3730-linux-driver
>
> Signed-off-by: Marius B. Kotsbak <marius@kotsbak.com>
Applied, thanks.
^ permalink raw reply
* (unknown),
From: Mr. Vincent Cheng @ 2011-06-17 2:18 UTC (permalink / raw)
Good Day,
I am Mr. Vincent Cheng Hoi Chuen, GBS, JP Chairman of the Hong Kong and
Shanghai Banking Corporation Limited.i have a business proposal of Twenty
Two million Five Hundred Thousand United State Dollars only for you to
transact with me from my bank to your country.
All confirmable documents to back up the claims will be made available to
you prior to your acceptance and as soon as I receive your return mail and
I will let you know what is required of you.
Your earliest response to this letter will be appreciated.
Best Regards,
Mr. Vincent Cheng
^ permalink raw reply
* Re: [PATCH] macvtap: remove wrong sock_put() in macvtap_put_queue()
From: David Miller @ 2011-06-17 2:58 UTC (permalink / raw)
To: jasowang; +Cc: arnd, netdev, linux-kernel
In-Reply-To: <1307934919-4189-1-git-send-email-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Mon, 13 Jun 2011 11:15:19 +0800
> The calling of sock_put() should be delayed after synchronize_rcu(),
> otherwise inconsist data may be seen during packets transmitting.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
You're leaking sockets now.
This function has to release the socket twice if there is
a non-NULL vlan assigned to the queue.
Now you're only doing it once in that situation.
Which probably fixes your crash, but adds a socket leak.
^ permalink raw reply
* Re: [PATCH net-next-2.6] be2net: support multiple TX queues
From: David Miller @ 2011-06-17 3:02 UTC (permalink / raw)
To: sathya.perla; +Cc: netdev
In-Reply-To: <f67e2aac-b763-404d-8e45-5c5f52c56d18@exht1.ad.emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Mon, 13 Jun 2011 11:31:58 +0530
> This patch provides support for multiple TX queues.
>
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] be2net: fix netdev_stats_update()
From: David Miller @ 2011-06-17 3:06 UTC (permalink / raw)
To: Sathya.Perla; +Cc: eric.dumazet, netdev
In-Reply-To: <3367B80B08154D42A3B2BC708B5D41F63F18593D4F@EXMAIL.ad.emulex.com>
From: <Sathya.Perla@Emulex.Com>
Date: Mon, 13 Jun 2011 00:09:38 -0700
> Dave, I would prefer to send a separate patch fixing the netdev
> stats issue after you apply this multiple TXQ patch. Are you OK with
> that?
Sure.
^ permalink raw reply
* Re: [PATCH] net: sh_eth: tidyup compile warrning
From: David Miller @ 2011-06-17 3:08 UTC (permalink / raw)
To: morimoto.kuninori; +Cc: netdev, yoshihiro.shimoda.uh
In-Reply-To: <w3p62oa6t8a.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Date: Mon, 13 Jun 2011 17:17:09 +0900
> This patch tidyup below warrning
>
> ${LINUX}/drivers/net/sh_eth.c:1773: warning:
> 'mdp' may be used uninitialized in this function
>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Please just move the mdp assignment right after alloc_netdev()
succeeds.
^ permalink raw reply
* Re: [PATCH] sky2: avoid using uninitialized variable
From: David Miller @ 2011-06-17 3:10 UTC (permalink / raw)
To: shemminger; +Cc: gthelen, shemminger, netdev, linux-kernel
In-Reply-To: <20110614000230.4166a1ae@s6510.ftrdhcpuser.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 14 Jun 2011 00:02:30 -0400
> In my experience if phy reads once successfully, it is going
> to read every time. If there is a problem it only happens on
> the first access (powered off, bad timing, etc).
It also happens when the PHY can't get a response for a certain
register, for whatever reason, before internal hw timeouts trigger.
Please, check all MII accesses. That's what I do in every driver
I've written.
^ permalink raw reply
* Re: [PATCH 1/2] IGMP snooping: set mrouters_only flag for IPv4 traffic properly
From: David Miller @ 2011-06-17 3:14 UTC (permalink / raw)
To: fernando; +Cc: herbert, shemminger, netdev, kakuta.hayato
In-Reply-To: <1308013483.3896.9.camel@nexus.oss.ntt.co.jp>
From: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
Date: Tue, 14 Jun 2011 10:04:43 +0900
> Upon reception of a IGMP/IGMPv2 membership report the kernel sets the
> mrouters_only flag in a skb that may be a clone of the original skb, which
> means that sometimes the bridge loses track of membership report packets (cb
> buffers are tied to a specific skb and not shared) and it ends up forwading
> join requests to the bridge interface.
>
> This can cause unexpected membership timeouts and intermitent/permanent loss
> of connectivity as described in RFC 4541 [2.1.1. IGMP Forwarding Rules]:
>
> A snooping switch should forward IGMP Membership Reports only to
> those ports where multicast routers are attached.
> [...]
> Sending membership reports to other hosts can result, for IGMPv1
> and IGMPv2, in unintentionally preventing a host from joining a
> specific multicast group.
>
>
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> Tested-by: Hayato Kakuta <kakuta.hayato@oss.ntt.co.jp>
Applied.
^ permalink raw reply
* Re: [PATCH 2/2] IGMP snooping: set mrouters_only flag for IPv6 traffic properly
From: David Miller @ 2011-06-17 3:14 UTC (permalink / raw)
To: fernando; +Cc: herbert, shemminger, netdev, yoshfuji
In-Reply-To: <1308013618.3896.11.camel@nexus.oss.ntt.co.jp>
From: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
Date: Tue, 14 Jun 2011 10:06:58 +0900
> Upon reception of a MGM report packet the kernel sets the mrouters_only flag
> in a skb that is a clone of the original skb, which means that the bridge
> loses track of MGM packets (cb buffers are tied to a specific skb and not
> shared) and it ends up forwading join requests to the bridge interface.
>
> This can cause unexpected membership timeouts and intermitent/permanent loss
> of connectivity as described in RFC 4541 [2.1.1. IGMP Forwarding Rules]:
>
> A snooping switch should forward IGMP Membership Reports only to
> those ports where multicast routers are attached.
> [...]
> Sending membership reports to other hosts can result, for IGMPv1
> and IGMPv2, in unintentionally preventing a host from joining a
> specific multicast group.
>
>
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: remove mm.h inclusion from netdevice.h
From: Stephen Rothwell @ 2011-06-17 3:19 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: davem, netdev, linux-kernel, fujita.tomonori, linux-arch
In-Reply-To: <20110616210134.GA18026@p183.telecom.by>
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
Hi Alexy,
On Fri, 17 Jun 2011 00:01:34 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> Remove linux/mm.h inclusion from netdevice.h -- it's unused (I've checked manually).
Have you tried building this with STAGING enabled? The fallout for
STAGING from the removal of linux/interrupt.h is still not sorted out.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: [PATCH net-next 1/2] net: Remove casts of void *
From: David Miller @ 2011-06-17 3:23 UTC (permalink / raw)
To: joe
Cc: netdev, kaber, sage, samuel, paul.moore, vladislav.yasevich, sri,
linux-kernel, ceph-devel, linux-decnet-user, linux-sctp
In-Reply-To: <d010144f11f9165670ac0c9e3559bf5e3191ff28.1308017857.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 13 Jun 2011 19:21:26 -0700
> Unnecessary casts of void * clutter the code.
>
> These are the remainder casts after several specific
> patches to remove netdev_priv and dev_priv.
>
> Done via coccinelle script:
>
> $ cat cast_void_pointer.cocci
> @@
> type T;
> T *pt;
> void *pv;
> @@
>
> - pt = (T *)pv;
> + pt = pv;
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* RE: [PATCH v2] net/r8169: update the new parser for the new firmware
From: hayeswang @ 2011-06-17 3:25 UTC (permalink / raw)
To: 'Francois Romieu'; +Cc: netdev, linux-kernel
In-Reply-To: <20110616225904.GA2064@electric-eye.fr.zoreil.com>
> -----Original Message-----
> From: Francois Romieu [mailto:romieu@fr.zoreil.com]
> Sent: Friday, June 17, 2011 6:59 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] net/r8169: update the new parser for
> the new firmware
>
> Hayes Wang <hayeswang@realtek.com> :
> > Update the parser for the new firmware which is embedded
> some information.
>
> I have modified several things :
> - s/u32/__le32/ in fw_info
> - fix unsigned (size_t) comparisons
> - more size checks before dereferencing fw_info
>
Thanks. They are fine.
> The new firmware format should be the same. The old
> r8168d-1.fw firmware proved usable when prefixed with :
>
> 0000000: 0000 0000 3031 0000 0000 0000 0000 0000 ....01..........
> 0000010: 0000 0000 0000 0000 0000 0000 0000 0000 ................
> 0000020: 0000 0000 3000 0000 7501 0000 a000 0000 ....0...u.......
>
> I realized after testing that netif_err could be abused with
> non-string fw_info.version. :o/
>
Excuse me. I don't understand what you want to express. Do you mean the
situation of the old paser with the new firmware for checking the firmware? For
the normal situation, the old paser would not use the new firmware. And I put
zero in front of the new firmware to prevent the old paser from running it. That
is all I do.
If you don't mean that, I could promise the new firmware I release would contain
the valid string unless someone modifies it.
> Comments ?
>
Best Regards,
Hayes
^ permalink raw reply
* Re: [PATCH] gianfar v3: implement nfc
From: David Miller @ 2011-06-17 3:31 UTC (permalink / raw)
To: sebastian.belden; +Cc: netdev, bhutchings, sebastian.poehn
In-Reply-To: <1308064750.13416.15.camel@DENEC1DT0191>
From: "Sebastian Pöhn" <sebastian.belden@googlemail.com>
Date: Tue, 14 Jun 2011 17:19:10 +0200
> + list_for_each_entry(comp, &priv->rx_list.list, list)
> + {
Please put the openning brace at the end of the previous line.
You did this in several locations of the patch.
^ permalink raw reply
* Re: [RFC 1/2] ethtool: Add DMA Coalescing adapter feature to ethtool.
From: David Miller @ 2011-06-17 3:32 UTC (permalink / raw)
To: carolyn.wyborny; +Cc: netdev, bhutchings
In-Reply-To: <1308071556-6271-1-git-send-email-carolyn.wyborny@intel.com>
From: Carolyn Wyborny <carolyn.wyborny@intel.com>
Date: Tue, 14 Jun 2011 10:12:36 -0700
> This RFC patch adds support for DMA Coalescing device feature
> configuration via ethtool.
>
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
...
> static struct cmdline_info cmdline_offload[] = {
> - { "rx", CMDL_BOOL, &off_csum_rx_wanted, NULL },
> - { "tx", CMDL_BOOL, &off_csum_tx_wanted, NULL },
> - { "sg", CMDL_BOOL, &off_sg_wanted, NULL },
Can you please not destroy the existing formatting of every single
table and piece of code you are modifying?
^ permalink raw reply
* Re: [RFC 2/2] ethtool: Add support for DMA Coalescing feature config to ethtool.
From: David Miller @ 2011-06-17 3:33 UTC (permalink / raw)
To: carolyn.wyborny; +Cc: netdev, bhutchings
In-Reply-To: <1308071606-6333-1-git-send-email-carolyn.wyborny@intel.com>
From: Carolyn Wyborny <carolyn.wyborny@intel.com>
Date: Tue, 14 Jun 2011 10:13:26 -0700
> This RFC patch adds functions to get and set DMA Coalescing feature
> configuration.
>
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
What in the world is "DMA Coalescing feature", what does it do?
Might it want parameters and not just want to be turned on or off?
This change, at a minimum, needs a more descriptive commit log entry.
So that other driver authors can understand what exactly the feature
is and therefore whether they might like to add support for it to
their drivers.
^ permalink raw reply
* Re: [PATCH] gianfar: Use pr_<level>, netdev_<level> and netif_<level>
From: David Miller @ 2011-06-17 3:35 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, sebastian.belden, netdev
In-Reply-To: <1f8bdbed8f110b214daaff8350ae9bde68c9cc12.1308076047.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Tue, 14 Jun 2011 11:57:47 -0700
> Use the current logging styles.
>
> Add #define DEBUG to get same output for <foo>_dbg messages.
> Convert a few bare printks to pr_err.
>
> Fix a likely copy/paste defect where a test was done with RX values:
> if (num_rx_qs > MAX_RX_QS) {
> but TX limits were emitted:
> printk(KERN_ERR "num_rx_qs(=%d) greater than MAX_RX_QS(=%d)\n",
> num_tx_qs, MAX_TX_QS);
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: rfs: enable RFS before first data packet is received
From: David Miller @ 2011-06-17 3:38 UTC (permalink / raw)
To: bhutchings; +Cc: eric.dumazet, therbert, netdev, hadi
In-Reply-To: <1308268246.2925.37.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 17 Jun 2011 00:50:46 +0100
> On Wed, 2011-06-15 at 04:15 +0200, Eric Dumazet wrote:
>> @@ -1594,6 +1594,7 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
>> goto discard;
>>
>> if (nsk != sk) {
>> + sock_rps_save_rxhash(nsk, skb->rxhash);
>> if (tcp_child_process(sk, nsk, skb)) {
>> rsk = nsk;
>> goto reset;
>>
>
> I haven't tried this, but it looks reasonable to me.
>
> What about IPv6? The logic in tcp_v6_do_rcv() looks very similar.
Indeed ipv6 side needs the same fix.
Eric please add that part and resubmit. And in fact I might stick
this into net-2.6 instead of net-next-2.6
Thanks!
^ permalink raw reply
* Re: [PATCH] ppp: use PPP_TRANS instead of the magic number 0x20
From: David Miller @ 2011-06-17 3:44 UTC (permalink / raw)
To: xiaosuo; +Cc: paulus, linux-ppp, netdev
In-Reply-To: <1308124693-6600-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Wed, 15 Jun 2011 15:58:13 +0800
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] phylib: Allow BCM63XX PHY to be selected only on BCM63XX.
From: David Miller @ 2011-06-17 3:45 UTC (permalink / raw)
To: ralf; +Cc: netdev, linux-mips, ffainelli
In-Reply-To: <20110615080758.GA3226@linux-mips.org>
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 15 Jun 2011 09:07:58 +0100
> This PHY is available integrated into BCM63xx series SOCs only.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Applied, thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox