* linux-next: manual merge of the staging tree with the net-next tree
From: Stephen Rothwell @ 2011-10-25 8:26 UTC (permalink / raw)
To: Greg KH
Cc: linux-next, linux-kernel, Jiri Pirko, Ian Campbell, David Miller,
netdev, Mark Einon
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
Hi Greg,
Today's linux-next merge of the staging tree got a conflict in
drivers/staging/et131x/et1310_tx.c drivers/staging/et131x/et131x_netdev.c
between commits afc4b13df143 ("net: remove use of ndo_set_multicast_list
in drivers"), bf3f1a6081aa ("et131x: convert to SKB paged frag API") and
5d6bcdfe38ce ("net: use DMA_x_DEVICE and dma_mapping_error with
skb_frag_dma_map") from the net-next tree and commit d2796743cba2
("staging: et131x: Put all .c files into one big file") from the staging
tree.
The latter removed these files, so I did that but more fixup is proably
needed.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH V2 2/4] MIPS: Add board support for Loongson1B
From: Giuseppe CAVALLARO @ 2011-10-25 8:20 UTC (permalink / raw)
To: Kelvin Cheung
Cc: Wu Zhangjin, linux-mips, linux-kernel, ralf, r0bertz, netdev
In-Reply-To: <4EA660C0.1020901@st.com>
[-- Attachment #1: Type: text/plain, Size: 3770 bytes --]
On 10/25/2011 9:09 AM, Giuseppe CAVALLARO wrote:
> On 10/25/2011 4:12 AM, Kelvin Cheung wrote:
>> 2011/10/24, Giuseppe CAVALLARO <peppe.cavallaro@st.com>:
>>> On 10/24/2011 4:05 PM, Kelvin Cheung wrote:
>>>> 2011/10/24, Giuseppe CAVALLARO <peppe.cavallaro@st.com>:
>>>>> Hello Kelvin.
>>>>>
>>>>> On 10/24/2011 12:36 PM, Kelvin Cheung wrote:
>>>>>
>>>>> [snip]
>>>>>
>>>>>> According to datasheet of Loongson 1B, the buffer size in RX/TX
>>>>>> descriptor is only 2KB. So the Loongson1B's GMAC could not handle
>>>>>> jumbo frames. And the second buffer is useless in this case. Am I
>>>>>> right? Is there a better way than ifdef CONFIG_MACH_LOONGSON1 to
>>>>>> avoid duplicate code?
>>>>>
>>>>> Sorry for my misunderstanding.
>>>>>
>>>>> I think you have to use the normal descriptor and remove the enh_desc
>>>>> from the platform w/o modifying the driver at all.
>>>>>
>>>>> The driver will be able to select/configure all automatically (also
>>>>> jumbo).
>>>>>
>>>>> Let me know.
>>>>
>>>> That's the problem.
>>>> The bitfield definition of Loongson1B is also different from normal
>>>> descriptor.
>>>
>>> The problem is not in the Loongson1B gmac.
>>
>> I found that the bit checksum_insertion is not existed in normal descriptor.
>>
>>> The normal descriptor fields in the stmmac refer to an old synopsys
>>> databook.
>>
>> Could you send me the new databook of Synopsys GMAC?
>>
>>> New chips have the same structure you have added; so we should fix this
>>> in the driver w/o breaking the compatibility for old chips.
>>
>> Agree.
>>
>>> I kindly ask you to confirm if the currently normal descriptor structure
>>> (w/o your changes) doesn't work on your platform.
>>> Did you test it?
>>
>> Well, the normal descriptor works on my platform except TX checksum offload.
>
> ok! I suspected that.
>
>
>>>> Moreover, I want to enable the TX checksum offload function which is
>>>> not supported in normal descriptor.
>>>> Any suggestions?
>>>
>>> It is supported but you have to pass from the platform: tx_coe = 1.
>>
>> I noticed that the flag csum_insertion is passed to
>> ndesc_prepare_tx_desc() in stmmac_xmit(). But ndesc_prepare_tx_desc()
>> just ignores it.
>> In other words, the TX checksum offload function is disabled in normal
>> descriptor currently.
>>
>> Should we fix this problem for normal descriptor?
>
> Yes, we should. If you agree, I'll update the normal descriptor
> structure to yours. This is the normal descriptor used in newer GMAC.
> Tx csum will be done for normal descriptors in case of these GMAC
> devices and not for old MAC10/100. For the MAC10/100 some bits for
> normal descriptors are reserved and won't be used at all.
>
> I'll also verify that the patch doesn't break the back-compatibility
> with old MAC10/100. I have the HW where doing the tests.
>
> After that, I'll prepare the patch for net-next and for your kernel.
Hello Kelvin
attached the patch tested on my development kernel.
It runs fine on old and new mac devices.
Can you try it on your side? Hmm, it is likely it won't apply fine on
your tree but you know the changes ;-).
If ok, I'll rework it for net-next and send it to the mailing list.
Thanks
Peppe
>
>>
>>> Peppe
>>>>
>>>>> Note:
>>>>> IIRC, there is a bit difference in case of normal descriptors for
>>>>> Synopsys databook newer than the 1.91 (I used for testing this mode).
>>>>> In any case, I remember that, on some platforms, the normal descriptors
>>>>> have been used w/o problems also on these new chip generations.
>>>>>
>>>>> Peppe
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[-- Attachment #2: 0002-stmmac-update-normal-descriptor-structure.patch --]
[-- Type: text/x-patch, Size: 7086 bytes --]
>From 85da9c92eace0b56148e9eedad1061ed72271409 Mon Sep 17 00:00:00 2001
From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Date: Tue, 25 Oct 2011 09:46:41 +0200
Subject: [PATCH (sh-2.6.32.y) 2/2] stmmac: update normal descriptor structure
This patch updates the normal descriptor structure
to work fine on new GMAC Synopsys chips.
Normal descriptors were designed on the old MAC10/100
databook 1.91 where some bits were reserved: for example
the tx checksum insertion.
The patch maintains the back-compatibility with old
MAC devices (tested on STx7109 MAC10/100) and adds new
fields that actually new GMAC devices can use.
For example, STx7109 will pass from the platform
tx_coe = 0, enh_desc = 0, has_gmac = 0.
A platform like Loongson1B (Mips) will pass:
tx_coe = 1, enh_desc = 0, has_gmac = 1.
Thanks to Kelvin, he enhanced the normal descriptors for
GMAC on Loongson1B.
Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
---
drivers/net/stmmac/common.h | 8 ++++----
drivers/net/stmmac/descs.h | 31 ++++++++++++++++++-------------
drivers/net/stmmac/norm_desc.c | 34 ++++++++++++++++++++--------------
drivers/net/stmmac/stmmac_ethtool.c | 8 ++++----
4 files changed, 46 insertions(+), 35 deletions(-)
diff --git a/drivers/net/stmmac/common.h b/drivers/net/stmmac/common.h
index 9100c10..2cc1192 100644
--- a/drivers/net/stmmac/common.h
+++ b/drivers/net/stmmac/common.h
@@ -49,7 +49,7 @@ struct stmmac_extra_stats {
unsigned long tx_underflow ____cacheline_aligned;
unsigned long tx_carrier;
unsigned long tx_losscarrier;
- unsigned long tx_heartbeat;
+ unsigned long vlan_tag;
unsigned long tx_deferred;
unsigned long tx_vlan;
unsigned long tx_jabber;
@@ -58,9 +58,9 @@ struct stmmac_extra_stats {
unsigned long tx_ip_header_error;
/* Receive errors */
unsigned long rx_desc;
- unsigned long rx_partial;
- unsigned long rx_runt;
- unsigned long rx_toolong;
+ unsigned long sa_filter_fail;
+ unsigned long overflow_error;
+ unsigned long ipc_csum_error;
unsigned long rx_collision;
unsigned long rx_crc;
unsigned long rx_length;
diff --git a/drivers/net/stmmac/descs.h b/drivers/net/stmmac/descs.h
index 63a03e2..9820ec8 100644
--- a/drivers/net/stmmac/descs.h
+++ b/drivers/net/stmmac/descs.h
@@ -25,33 +25,34 @@ struct dma_desc {
union {
struct {
/* RDES0 */
- u32 reserved1:1;
+ u32 payload_csum_error:1;
u32 crc_error:1;
u32 dribbling:1;
u32 mii_error:1;
u32 receive_watchdog:1;
u32 frame_type:1;
u32 collision:1;
- u32 frame_too_long:1;
+ u32 ipc_csum_error:1;
u32 last_descriptor:1;
u32 first_descriptor:1;
- u32 multicast_frame:1;
- u32 run_frame:1;
+ u32 vlan_tag:1;
+ u32 overflow_error:1;
u32 length_error:1;
- u32 partial_frame_error:1;
+ u32 sa_filter_fail:1;
u32 descriptor_error:1;
u32 error_summary:1;
u32 frame_length:14;
- u32 filtering_fail:1;
+ u32 da_filter_fail:1;
u32 own:1;
/* RDES1 */
u32 buffer1_size:11;
u32 buffer2_size:11;
- u32 reserved2:2;
+ u32 reserved1:2;
u32 second_address_chained:1;
u32 end_ring:1;
- u32 reserved3:5;
+ u32 reserved2:5;
u32 disable_ic:1;
+
} rx;
struct {
/* RDES0 */
@@ -91,24 +92,28 @@ struct dma_desc {
u32 underflow_error:1;
u32 excessive_deferral:1;
u32 collision_count:4;
- u32 heartbeat_fail:1;
+ u32 vlan_frame:1;
u32 excessive_collisions:1;
u32 late_collision:1;
u32 no_carrier:1;
u32 loss_carrier:1;
- u32 reserved1:3;
+ u32 payload_error:1;
+ u32 frame_flushed:1;
+ u32 jabber_timeout:1;
u32 error_summary:1;
- u32 reserved2:15;
+ u32 ip_header_error:1;
+ u32 time_stamp_status:1;
+ u32 reserved1:13;
u32 own:1;
/* TDES1 */
u32 buffer1_size:11;
u32 buffer2_size:11;
- u32 reserved3:1;
+ u32 time_stamp_enable:1;
u32 disable_padding:1;
u32 second_address_chained:1;
u32 end_ring:1;
u32 crc_disable:1;
- u32 reserved4:2;
+ u32 checksum_insertion:2;
u32 first_segment:1;
u32 last_segment:1;
u32 interrupt:1;
diff --git a/drivers/net/stmmac/norm_desc.c b/drivers/net/stmmac/norm_desc.c
index f7e8ba7..c7c1522 100644
--- a/drivers/net/stmmac/norm_desc.c
+++ b/drivers/net/stmmac/norm_desc.c
@@ -50,11 +50,12 @@ static int ndesc_get_tx_status(void *data, struct stmmac_extra_stats *x,
stats->collisions += p->des01.tx.collision_count;
ret = -1;
}
- if (unlikely(p->des01.tx.heartbeat_fail)) {
- x->tx_heartbeat++;
- stats->tx_heartbeat_errors++;
- ret = -1;
- }
+
+ if (p->des01.etx.vlan_frame) {
+ CHIP_DBG(KERN_INFO "GMAC TX status: VLAN frame\n");
+ x->tx_vlan++;
+ }
+
if (unlikely(p->des01.tx.deferred))
x->tx_deferred++;
@@ -86,12 +87,12 @@ static int ndesc_get_rx_status(void *data, struct stmmac_extra_stats *x,
if (unlikely(p->des01.rx.error_summary)) {
if (unlikely(p->des01.rx.descriptor_error))
x->rx_desc++;
- if (unlikely(p->des01.rx.partial_frame_error))
- x->rx_partial++;
- if (unlikely(p->des01.rx.run_frame))
- x->rx_runt++;
- if (unlikely(p->des01.rx.frame_too_long))
- x->rx_toolong++;
+ if (unlikely(p->des01.rx.sa_filter_fail))
+ x->sa_filter_fail++;
+ if (unlikely(p->des01.rx.overflow_error))
+ x->overflow_error++;
+ if (unlikely(p->des01.rx.ipc_csum_error))
+ x->ipc_csum_error++;
if (unlikely(p->des01.rx.collision)) {
x->rx_collision++;
stats->collisions++;
@@ -113,10 +114,12 @@ static int ndesc_get_rx_status(void *data, struct stmmac_extra_stats *x,
x->rx_mii++;
ret = discard_frame;
}
- if (p->des01.rx.multicast_frame) {
- x->rx_multicast++;
- stats->multicast++;
+#ifdef STMMAC_VLAN_TAG_USED
+ if (p->des01.rx.vlan_tag) {
+ x->vlan_tag++;
+ stats->vlan_tag++;
}
+#endif
return ret;
}
@@ -184,6 +187,9 @@ static void ndesc_prepare_tx_desc(struct dma_desc *p, int is_fs, int len,
{
p->des01.tx.first_segment = is_fs;
norm_set_tx_desc_len(p, len);
+
+ if (likely(csum_flag))
+ p->des01.tx.checksum_insertion = cic_full;
}
static void ndesc_clear_tx_ic(struct dma_desc *p)
diff --git a/drivers/net/stmmac/stmmac_ethtool.c b/drivers/net/stmmac/stmmac_ethtool.c
index d81cf20..6831cf2 100644
--- a/drivers/net/stmmac/stmmac_ethtool.c
+++ b/drivers/net/stmmac/stmmac_ethtool.c
@@ -48,7 +48,7 @@ static const struct stmmac_stats stmmac_gstrings_stats[] = {
STMMAC_STAT(tx_underflow),
STMMAC_STAT(tx_carrier),
STMMAC_STAT(tx_losscarrier),
- STMMAC_STAT(tx_heartbeat),
+ STMMAC_STAT(vlan_tag),
STMMAC_STAT(tx_deferred),
STMMAC_STAT(tx_vlan),
STMMAC_STAT(rx_vlan),
@@ -57,9 +57,9 @@ static const struct stmmac_stats stmmac_gstrings_stats[] = {
STMMAC_STAT(tx_payload_error),
STMMAC_STAT(tx_ip_header_error),
STMMAC_STAT(rx_desc),
- STMMAC_STAT(rx_partial),
- STMMAC_STAT(rx_runt),
- STMMAC_STAT(rx_toolong),
+ STMMAC_STAT(sa_filter_fail),
+ STMMAC_STAT(overflow_error),
+ STMMAC_STAT(ipc_csum_error),
STMMAC_STAT(rx_collision),
STMMAC_STAT(rx_crc),
STMMAC_STAT(rx_length),
--
1.7.4.4
^ permalink raw reply related
* Re: [PATCH] smsc911x: Enable flow control advertisement
From: Kazunori Kobayashi @ 2011-10-25 8:20 UTC (permalink / raw)
To: Ben Hutchings; +Cc: netdev, steve.glendinning, dhobsong
In-Reply-To: <1319027199.23980.47.camel@deadeye>
> This should be controllable through ethtool; I assume phy_ethtool_sset()
> already covers that.
I found that the flow control could be enabled by changing the
kernel configuration.
I just set CONFIG_SMSC_PHY in "PHY Device support and infrastructure".
Please ignore this patch.
(2011/10/19 21:26), Ben Hutchings wrote:
> On Wed, 2011-10-19 at 18:21 +0900, Kazunori Kobayashi wrote:
>> Enable the advertisement of both symmetric pause and asymmetric pause
>> flow control capability.
>>
>> Signed-off-by: Kazunori Kobayashi <kkobayas@igel.co.jp>
>> ---
>> drivers/net/smsc911x.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
>> index b9016a3..60c3bc2 100644
>> --- a/drivers/net/smsc911x.c
>> +++ b/drivers/net/smsc911x.c
>
> This file has been moved.
>
>> @@ -800,8 +800,13 @@ static void smsc911x_phy_update_flowcontrol(struct smsc911x_data *pdata)
>> struct phy_device *phy_dev = pdata->phy_dev;
>> u32 afc = smsc911x_reg_read(pdata, AFC_CFG);
>> u32 flow;
>> + u16 miiadv = smsc911x_mii_read(phy_dev->bus, phy_dev->addr,
>> + MII_ADVERTISE);
>> unsigned long flags;
>>
>> + miiadv |= (ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM);
>> + smsc911x_mii_write(phy_dev->bus, phy_dev->addr, MII_ADVERTISE, miiadv);
>
> This should be controllable through ethtool; I assume phy_ethtool_sset()
> already covers that.
>
> Further, it's far too late to change advertising when you're just about
> to resolve what was negotiated. It has to be done before (re)starting
> autoneg.
>
> Ben.
>
>> if (phy_dev->duplex == DUPLEX_FULL) {
>> u16 lcladv = phy_read(phy_dev, MII_ADVERTISE);
>> u16 rmtadv = phy_read(phy_dev, MII_LPA);
>
--
---------------------------------
IGEL Co.,Ltd. Kazunori Kobayashi
kkobayas@igel.co.jp
http://www.igel.co.jp/
^ permalink raw reply
* linux-next: manual merge of the driver-core tree with the net-next tree
From: Stephen Rothwell @ 2011-10-25 8:07 UTC (permalink / raw)
To: Greg KH
Cc: linux-next, linux-kernel, Eric W. Biederman, David Miller, netdev,
Mikulas Patocka
[-- Attachment #1: Type: text/plain, Size: 3516 bytes --]
Hi Greg,
Today's linux-next merge of the driver-core tree got a conflict in
fs/sysfs/dir.c between commit 23396180a977 ("sysfs: Remove support for
tagged directories with untagged members") from the net-next tree and
commits 4f72c0cab405 ("sysfs: use rb-tree for name lookups") and
a406f75840e1 ("sysfs: use rb-tree for inode number lookup") from the
driver-core tree.
I fixed it up (I think - see below) and can carry the fix as necessary.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc fs/sysfs/dir.c
index 26f370a,83bb9d1..0000000
--- a/fs/sysfs/dir.c
+++ b/fs/sysfs/dir.c
@@@ -547,22 -558,36 +565,43 @@@ struct sysfs_dirent *sysfs_find_dirent(
const void *ns,
const unsigned char *name)
{
- struct sysfs_dirent *sd;
+ struct rb_node *p = parent_sd->s_dir.name_tree.rb_node;
+ struct sysfs_dirent *found = NULL;
+ if (!!sysfs_ns_type(parent_sd) != !!ns) {
+ WARN(1, KERN_WARNING "sysfs: ns %s in '%s' for '%s'\n",
+ sysfs_ns_type(parent_sd)? "required": "invalid",
+ parent_sd->s_name, name);
+ return NULL;
+ }
+
- for (sd = parent_sd->s_dir.children; sd; sd = sd->s_sibling) {
- if (sd->s_ns != ns)
- continue;
- if (!strcmp(sd->s_name, name))
- return sd;
+ while (p) {
+ int c;
+ #define node rb_entry(p, struct sysfs_dirent, name_node)
+ c = strcmp(name, node->s_name);
+ if (c < 0) {
+ p = node->name_node.rb_left;
+ } else if (c > 0) {
+ p = node->name_node.rb_right;
+ } else {
+ found = node;
+ p = node->name_node.rb_left;
+ }
+ #undef node
}
- return NULL;
+
+ if (found && ns) {
+ while (found->s_ns && found->s_ns != ns) {
+ p = rb_next(&found->name_node);
+ if (!p)
+ return NULL;
+ found = rb_entry(p, struct sysfs_dirent, name_node);
+ if (strcmp(name, found->s_name))
+ return NULL;
+ }
+ }
+
+ return found;
}
/**
@@@ -895,12 -918,28 +932,28 @@@ static struct sysfs_dirent *sysfs_dir_p
pos = NULL;
}
if (!pos && (ino > 1) && (ino < INT_MAX)) {
- pos = parent_sd->s_dir.children;
- while (pos && (ino > pos->s_ino))
- pos = pos->s_sibling;
+ struct rb_node *p = parent_sd->s_dir.inode_tree.rb_node;
+ while (p) {
+ #define node rb_entry(p, struct sysfs_dirent, inode_node)
+ if (ino < node->s_ino) {
+ pos = node;
+ p = node->inode_node.rb_left;
+ } else if (ino > node->s_ino) {
+ p = node->inode_node.rb_right;
+ } else {
+ pos = node;
+ break;
+ }
+ #undef node
+ }
+ }
- while (pos && pos->s_ns && pos->s_ns != ns) {
++ while (pos && pos->s_ns != ns) {
+ struct rb_node *p = rb_next(&pos->inode_node);
+ if (!p)
+ pos = NULL;
+ else
+ pos = rb_entry(p, struct sysfs_dirent, inode_node);
}
- while (pos && pos->s_ns != ns)
- pos = pos->s_sibling;
return pos;
}
@@@ -908,10 -947,13 +961,13 @@@ static struct sysfs_dirent *sysfs_dir_n
struct sysfs_dirent *parent_sd, ino_t ino, struct sysfs_dirent *pos)
{
pos = sysfs_dir_pos(ns, parent_sd, ino, pos);
- if (pos)
- pos = pos->s_sibling;
- while (pos && pos->s_ns != ns)
- pos = pos->s_sibling;
+ if (pos) do {
+ struct rb_node *p = rb_next(&pos->inode_node);
+ if (!p)
+ pos = NULL;
+ else
+ pos = rb_entry(p, struct sysfs_dirent, inode_node);
- } while (pos && pos->s_ns && pos->s_ns != ns);
++ } while (pos && pos->s_ns != ns);
return pos;
}
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [RFD] Network configuration data in sysfs
From: Kay Sievers @ 2011-10-25 7:57 UTC (permalink / raw)
To: Alexey Gladkov
Cc: David Miller, kirill, netdev, kuznet, jmorris, yoshfuji, kaber,
gregkh
In-Reply-To: <4EA5FA9B.5050908@gmail.com>
On Tue, Oct 25, 2011 at 01:54, Alexey Gladkov <gladkov.alexey@gmail.com> wrote:
> 24.10.2011 16:46, Kay Sievers wrote:
>> Kirill, what exactly is the use case? And why what does udev support
>> mean in that context?
>>
>> I doubt that "not having /sbin/ip installed" should be a reason to add
>> and expose complex interfaces in /sys, while we already have a
>> perfectly working native way to do it.
>
> Adding NETLINK_ROUTE in udev is a way to perform some actions in case
> of network events without polling. Now there are only a few specific
> daemons (NM, connman etc) that are listen to the netlink socket and
> setup the network his own way.
I'm not really convinced that udev should be in charge of network
config changes, it's a really complex area. Udev is a generic kernel
device manager, not a network setup manager.
Our point of view is, that all services depending on network state
changes should listen to netlink themselves, and not be worked around
with tools like udev to execute stuff and notify them.
But again, what's the use-case for that you have in mind?
Kay
^ permalink raw reply
* Dear Account User.
From: Microsoft maintenance center @ 2011-10-25 7:44 UTC (permalink / raw)
THIS Email is from Microsoft maintenance center.Customer Care and we are sending it to every Email User Accounts Owner for safety. we are having congestions due to the anonymous registration of Microsoft maintenance center. so we are shutting down some accounts user and your account was among those to be deleted.We are sending you this email so that you can verify and let us know if you still want to use this account.If you are still interested please confirm your account and removal of all unused Accounts, would be shutting down all unused Accounts, You will have to confirm your E-mail by filling out your Login Information below after clicking the reply button, or your account will be suspended within 24 hours for security reasons.
* Email Username:
* Password:
* Date of Birth:
* Country Or Territory:
After following the instructions in the sheet, your account will not be interrupted and will continue as normal. Thanks for your attention to this request. We apologize for any inconveniences. Warning!!! Account owner that refuses to update his/her account after two weeks of receiving this warning will lose his or her account permanently
Yours Faithfully,
Customer Care
Case Number: 5268689
Property: Account Security
^ permalink raw reply
* RE: [RFC PATCH 08/17] drivers/net/bfin_mac: Don't unnecessarily reset the PHY
From: Zhang, Sonic @ 2011-10-25 7:26 UTC (permalink / raw)
To: Kyle Moffett, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Cc: David S. Miller, Mike Frysinger, Tobias Klauser,
uclinux-dist-devel@blackfin.uclinux.org
In-Reply-To: <1319144425-15547-9-git-send-email-Kyle.D.Moffett@boeing.com>
Acked-by: Sonic Zhang <sonic.zhang@analog.com>
Sonic
>-----Original Message-----
>From: Kyle Moffett [mailto:Kyle.D.Moffett@boeing.com]
>Sent: Friday, October 21, 2011 5:00 AM
>To: linux-kernel@vger.kernel.org; netdev@vger.kernel.org
>Cc: Kyle Moffett; David S. Miller; Mike Frysinger; Zhang,
>Sonic; Tobias Klauser; uclinux-dist-devel@blackfin.uclinux.org
>Subject: [RFC PATCH 08/17] drivers/net/bfin_mac: Don't
>unnecessarily reset the PHY
>
>The PHY is already reset during driver probing, and this
>manual reset afterwards will wipe out board-specific PHY
>fixups and driver-specific
>phy->drv->config_init() register tweaks.
>
>Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
>---
> drivers/net/bfin_mac.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
>index 6c019e1..1427ec3 100644
>--- a/drivers/net/bfin_mac.c
>+++ b/drivers/net/bfin_mac.c
>@@ -1402,7 +1402,6 @@ static int bfin_mac_open(struct net_device *dev)
> return ret;
>
> phy_start(lp->phydev);
>- phy_write(lp->phydev, MII_BMCR, BMCR_RESET);
> setup_system_regs(dev);
> setup_mac_addr(dev->dev_addr);
>
>--
>1.7.2.5
>
>
>
^ permalink raw reply
* [PATCH] Fix caif BUG() with network namespaces
From: David Woodhouse @ 2011-10-25 7:25 UTC (permalink / raw)
To: David Miller; +Cc: sjurbren, netdev
In-Reply-To: <20111024.182831.489446218871753789.davem@davemloft.net>
The caif code will register its own pernet_operations, and then register
a netdevice_notifier. Each time the netdevice_notifier is triggered,
it'll do some stuff... including a lookup of its own pernet stuff with
net_generic().
If the net_generic() call ever returns NULL, the caif code will BUG().
That doesn't seem *so* unreasonable, I suppose — it does seem like it
should never happen.
However, it *does* happen. When we clone a network namespace,
setup_net() runs through all the pernet_operations one at a time. It
gets to loopback before it gets to caif. And loopback_net_init()
registers a netdevice... while caif hasn't been initialised. So the caif
netdevice notifier triggers, and immediately goes BUG().
We could imagine a complex and overengineered solution to this generic
class of problems, but this patch takes the simple approach. It just
makes caif_device_notify() *not* go looking for its pernet data
structures if the device it's being notified about isn't a caif device
in the first place.
Cc: stable@kernel.org
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
---
On Mon, 2011-10-24 at 18:28 -0400, David Miller wrote:
> David W., the copy that ended up in patchwork was using DOS newlines:
> http://patchwork.ozlabs.org/patch/121250/
> Click on Download "mbox" to see what I mean.
> Can you get your email configuration straightened out before
> resubmitting this patch a third time?
Sorry about that. It's not a configuration thing; just me being stupid
and using the wrong account to send. I *know* Exchange is not an email
server, and that signing emails causes QP encoding. This one should be
fine.
Having said that... in fact, email is *supposed* to have DOS newlines.
The SMTP protocol requires it. When receiving on *nix boxes, we tend to
convert CRLF to LF.
I played a little with applying the emails I sent with 'git am', and it
actually copes fine with the original Quoted-Printable email, as it
should. It *almost* copes with the base64 email, but it forgets to do
the CRLF to LF conversion. I'll look at fixing it (in the spirit of 'be
liberal in what you accept)... but of course we should also be
conservative in what we *send*, so here is (hopefully) an unencoded
version. Apologies again for the inconvenience.
/me double-checks that the signature is turned off, and the sending
account is not the Exchange one... <send>
net/caif/caif_dev.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
index 7f9ac07..47fc8f3 100644
--- a/net/caif/caif_dev.c
+++ b/net/caif/caif_dev.c
@@ -212,8 +212,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
enum cfcnfg_phy_preference pref;
enum cfcnfg_phy_type phy_type;
struct cfcnfg *cfg;
- struct caif_device_entry_list *caifdevs =
- caif_device_list(dev_net(dev));
+ struct caif_device_entry_list *caifdevs;
if (dev->type != ARPHRD_CAIF)
return 0;
@@ -222,6 +221,8 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
if (cfg == NULL)
return 0;
+ caifdevs = caif_device_list(dev_net(dev));
+
switch (what) {
case NETDEV_REGISTER:
caifd = caif_device_alloc(dev);
--
1.7.6.4
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
^ permalink raw reply related
* Re: Linux 3.1-rc9
From: Linus Torvalds @ 2011-10-25 7:13 UTC (permalink / raw)
To: Simon Kirby, Network Development
Cc: Thomas Gleixner, David Miller, Peter Zijlstra,
Linux Kernel Mailing List, Dave Jones, Martin Schwidefsky,
Ingo Molnar
In-Reply-To: <20111024190203.GA24410@hostway.ca>
Added netdev, because this seems to be a generic networking bug (ABBA
between sk_lock and icsk_retransmit_timer if my quick scan looks
correct).
Davem?
Linus
On Mon, Oct 24, 2011 at 9:02 PM, Simon Kirby <sim@hostway.ca> wrote:
>
> Ok, hit the hang about 4 more times, but only this morning on a box with
> a serial cable attached. Yay!
>
> Simon-
>
> [216695.579770] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216695.589435]
> [216695.589437] =======================================================
> [216695.593380] [ INFO: possible circular locking dependency detected ]
> [216695.593380] 3.1.0-rc10-hw-lockdep+ #51
> [216695.593380] -------------------------------------------------------
> [216695.593380] kworker/0:1/0 is trying to acquire lock:
> [216695.593380] (&icsk->icsk_retransmit_timer){+.-.-.}, at: [<ffffffff8106cc88>] run_timer_softirq+0x198/0x410
> [216695.593380]
> [216695.593380] but task is already holding lock:
> [216695.593380] (slock-AF_INET){+.-.-.}, at: [<ffffffff81604540>] sk_clone+0x120/0x420
> [216695.593380]
> [216695.593380] which lock already depends on the new lock.
> [216695.593380]
> [216695.593380]
> [216695.593380] the existing dependency chain (in reverse order) is:
> [216695.593380]
> [216695.593380] -> #1 (slock-AF_INET){+.-.-.}:
> [216695.593380] [<ffffffff8109a7b9>] lock_acquire+0x109/0x140
> [216695.593380] [<ffffffff816f55fc>] _raw_spin_lock+0x3c/0x50
> [216695.593380] [<ffffffff81661cc3>] tcp_write_timer+0x23/0x230
> [216695.682901] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [216695.682901] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [216695.682901] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [216695.682901] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [216695.682901] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [216695.682901] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [216695.682901] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [216695.682901] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [216695.682901] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [216695.682901]
> [216695.682901] -> #0 (&icsk->icsk_retransmit_timer){+.-.-.}:
> [216695.682901] [<ffffffff8109a000>] __lock_acquire+0x2040/0x2180
> [216695.682901] [<ffffffff8109a7b9>] lock_acquire+0x109/0x140
> [216695.682901] [<ffffffff8106cd09>] run_timer_softirq+0x219/0x410
> [216695.682901] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [216695.682901] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [216695.682901] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [216695.682901] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [216695.682901] [<ffffffff81014b74>] do_IRQ+0x64/0xe0
> [216695.682901] [<ffffffff816f6273>] ret_from_intr+0x0/0x1a
> [216695.682901] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [216695.682901] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [216695.682901]
> [216695.682901] other info that might help us debug this:
> [216695.682901]
> [216695.682901] Possible unsafe locking scenario:
> [216695.682901]
> [216695.682901] CPU0 CPU1
> [216695.682901] ---- ----
> [216695.682901] lock(slock-AF_INET);
> [216695.682901] lock(&icsk->icsk_retransmit_timer);
> [216695.682901] lock(slock-AF_INET);
> [216695.682901] lock(&icsk->icsk_retransmit_timer);
> [216695.682901]
> [216695.682901] *** DEADLOCK ***
> [216695.682901]
> [216695.682901] 1 lock held by kworker/0:1/0:
> [216695.682901] #0: (slock-AF_INET){+.-.-.}, at: [<ffffffff81604540>] sk_clone+0x120/0x420
> [216695.682901]
> [216695.682901] stack backtrace:
> [216695.682901] Pid: 0, comm: kworker/0:1 Not tainted 3.1.0-rc10-hw-lockdep+ #51
> [216695.682901] Call Trace:
> [216695.682901] <IRQ> [<ffffffff81097eab>] print_circular_bug+0x21b/0x330
> [216695.682901] [<ffffffff8109a000>] __lock_acquire+0x2040/0x2180
> [216695.682901] [<ffffffffa001d6e2>] ? nf_conntrack_free+0x42/0x50 [nf_conntrack]
> [216695.682901] [<ffffffffa001d6e2>] ? nf_conntrack_free+0x42/0x50 [nf_conntrack]
> [216695.682901] [<ffffffff8109a7b9>] lock_acquire+0x109/0x140
> [216695.682901] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [216695.682901] [<ffffffff81096b4c>] ? trace_hardirqs_on_caller+0x7c/0x1c0
> [216695.682901] [<ffffffff8106cd09>] run_timer_softirq+0x219/0x410
> [216695.682901] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [216695.682901] [<ffffffff816f16c1>] ? printk+0x67/0x69
> [216695.682901] [<ffffffff81661ca0>] ? tcp_delack_timer+0x230/0x230
> [216695.682901] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [216695.682901] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [216695.682901] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [216695.682901] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [216695.682901] [<ffffffff81014b74>] do_IRQ+0x64/0xe0
> [216695.682901] [<ffffffff816f6273>] common_interrupt+0x73/0x73
> [216695.682901] <EOI> [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [216695.682901] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [216695.682901] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [216695.682901] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [216696.019296] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000105?
> [216697.762956] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216698.597297] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216701.489681] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216701.667999] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216704.580592] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [216709.468971] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [216712.845904] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216716.588502] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [216725.072958] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [216725.603879] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216725.828374] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216727.588978] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216735.513864] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216740.581530] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [216756.278571] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [218855.312903] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [218855.323133] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [218858.293355] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [218864.301938] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [218876.333821] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [218885.332651] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [218900.313590] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [220821.012017] TCP: Peer 32.176.160.153:49226/80 unexpectedly shrunk window 665256753:665268993 (repaired)
> [221075.224300] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221075.234579] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221075.277593] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221075.780515] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221075.780713] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221077.349279] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221077.905587] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [221077.915567] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [221081.498430] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221081.703277] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [221082.088513] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221082.167985] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221089.772578] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221090.487927] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [221090.686394] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221094.587131] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221105.255699] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000101, exited with 00000102?
> [221105.280699] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221105.291634] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221106.325794] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221107.286029] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221107.622736] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221107.734471] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [221120.381643] huh, entered softirq 3 NET_RX ffffffff81613740 preempt_count 00000102, exited with 00000103?
> [223936.264020] BUG: soft lockup - CPU#0 stuck for 22s! [swapper:0]
> [223936.268002] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223936.268002] irq event stamp: 2595159887
> [223936.268002] hardirqs last enabled at (2595159887): [<ffffffff8101b805>] mwait_idle+0x145/0x170
> [223936.268002] hardirqs last disabled at (2595159886): [<ffffffff81013139>] cpu_idle+0x79/0xf0
> [223936.268002] softirqs last enabled at (2595159878): [<ffffffff81064176>] __do_softirq+0x1f6/0x250
> [223936.268002] softirqs last disabled at (2595159873): [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.268002] CPU 0
> [223936.268002] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223936.268002]
> [223936.268002] Pid: 0, comm: swapper Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223936.268002] RIP: 0010:[<ffffffff813a4ee3>] [<ffffffff813a4ee3>] delay_tsc+0x73/0xd0
> [223936.268002] RSP: 0018:ffff88022fc03cf0 EFLAGS: 00000202
> [223936.268002] RAX: 00017b5d5932dd02 RBX: ffffffff816f6334 RCX: 000000005932dd02
> [223936.372028] BUG: soft lockup - CPU#1 stuck for 22s! [kworker/0:0:0]
> [223936.372031] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223936.372042] irq event stamp: 2598787699
> [223936.372044] hardirqs last enabled at (2598787699): [<ffffffff8101b805>] mwait_idle+0x145/0x170
> [223936.372054] hardirqs last disabled at (2598787698): [<ffffffff81013139>] cpu_idle+0x79/0xf0
> [223936.372058] softirqs last enabled at (2598787696): [<ffffffff81064176>] __do_softirq+0x1f6/0x250
> [223936.372063] softirqs last disabled at (2598787681): [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.372069] CPU 1
> [223936.372070] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223936.372079]
> [223936.372081] Pid: 0, comm: kworker/0:0 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223936.372086] RIP: 0010:[<ffffffff8101afab>] [<ffffffff8101afab>] native_read_tsc+0xb/0x20
> [223936.372091] RSP: 0018:ffff88022fc43ce0 EFLAGS: 00000202
> [223936.372093] RAX: 0000000000017b5d RBX: ffffffff816f6334 RCX: 00000000652f810e
> [223936.372096] RDX: 0000000000017b5d RSI: 0000000000000000 RDI: 0000000000000001
> [223936.372098] RBP: ffff88022fc43ce0 R08: 00000000652f80c8 R09: 0000000000000000
> [223936.372101] R10: ffff88022690dd60 R11: 0000000000000000 R12: ffff88022fc43c58
> [223936.372103] R13: ffffffff816feb33 R14: ffff88022fc43ce0 R15: 00000000180bbeb8
> [223936.372106] FS: 0000000000000000(0000) GS:ffff88022fc40000(0000) knlGS:0000000000000000
> [223936.372108] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223936.372111] CR2: 00007f472ba6a6fc CR3: 0000000126bb7000 CR4: 00000000000006e0
> [223936.372113] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223936.372116] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223936.372119] Process kworker/0:0 (pid: 0, threadinfo ffff880226928000, task ffff88022690dd60)
> [223936.372121] Stack:
> [223936.372123] ffff88022fc43d30 ffffffff813a4eaf ffff880226928000 00000000652f8090
> [223936.372128] 000000012fc43d18 ffff88002e90e348 00000000180bbeb8 000000006efcdc62
> [223936.372132] 0000000000000001 ffff88022690dd60 ffff88022fc43d40 ffffffff813a4f6a
> [223936.372136] Call Trace:
> [223936.372139] <IRQ>
> [223936.372144] [<ffffffff813a4eaf>] delay_tsc+0x3f/0xd0
> [223936.372148] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223936.372153] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223936.372159] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223936.372164] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223936.372168] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223936.372174] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223936.372178] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223936.372182] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223936.372186] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223936.372190] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.372194] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223936.372198] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223936.372203] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223936.372208] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223936.372210] <EOI>
> [223936.372214] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.372218] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223936.372222] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.372226] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223936.372230] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223936.372233] Code: a1 00 48 c7 43 08 00 00 00 00 48 89 03 48 83 c4 08 5b c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 0f 31 89 c1 48 89 d0
> [223936.372253] c1 e0 20 89 ca 48 09 d0 c9 c3 66 2e 0f 1f 84 00 00 00 00 00
> [223936.372262] Call Trace:
> [223936.372264] <IRQ> [<ffffffff813a4eaf>] delay_tsc+0x3f/0xd0
> [223936.372269] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223936.372272] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223936.372276] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223936.372280] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223936.372283] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223936.372286] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223936.372289] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223936.372293] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223936.372297] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223936.372300] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.372303] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223936.372307] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223936.372310] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223936.372313] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223936.372315] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.372321] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223936.372324] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.372327] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223936.372331] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223936.476032] BUG: soft lockup - CPU#2 stuck for 23s! [kworker/0:1:0]
> [223936.476034] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223936.476043] irq event stamp: 2613824057
> [223936.476045] hardirqs last enabled at (2613824057): [<ffffffff8101b805>] mwait_idle+0x145/0x170
> [223936.476050] hardirqs last disabled at (2613824056): [<ffffffff81013139>] cpu_idle+0x79/0xf0
> [223936.476054] softirqs last enabled at (2613824048): [<ffffffff81064176>] __do_softirq+0x1f6/0x250
> [223936.476058] softirqs last disabled at (2613824031): [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.476062] CPU 2
> [223936.476063] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223936.476071]
> [223936.476073] Pid: 0, comm: kworker/0:1 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223936.476077] RIP: 0010:[<ffffffff8101afa6>] [<ffffffff8101afa6>] native_read_tsc+0x6/0x20
> [223936.476082] RSP: 0018:ffff88022fc83ce0 EFLAGS: 00000202
> [223936.476084] RAX: 0000000070ba7dfc RBX: ffffffff813a60ae RCX: 0000000070ba7dc4
> [223936.476086] RDX: 0000000000017b5d RSI: 0000000000000000 RDI: 0000000000000001
> [223936.476089] RBP: ffff88022fc83ce0 R08: 0000000070ba7d7e R09: 0000000000000000
> [223936.476091] R10: ffff880226948000 R11: 0000000000000000 R12: ffff88022fc83c58
> [223936.476093] R13: ffffffff816feb33 R14: ffff88022fc83ce0 R15: 00000000182285f9
> [223936.476096] FS: 0000000000000000(0000) GS:ffff88022fc80000(0000) knlGS:0000000000000000
> [223936.476099] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223936.476101] CR2: 00007f25e7874d7f CR3: 0000000124c0d000 CR4: 00000000000006e0
> [223936.476104] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223936.476106] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223936.476109] Process kworker/0:1 (pid: 0, threadinfo ffff88022693e000, task ffff880226948000)
> [223936.476111] Stack:
> [223936.476113] ffff88022fc83d30 ffffffff813a4ee8 ffff88022693e000 0000000070ba7dc4
> [223936.476117] 00000002ffffff10 ffff88006afd8948 00000000182285f9 000000006efcdc62
> [223936.476121] 0000000000000001 ffff880226948000 ffff88022fc83d40 ffffffff813a4f6a
> [223936.476126] Call Trace:
> [223936.476128] <IRQ>
> [223936.476132] [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223936.476136] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223936.476141] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223936.476147] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223936.476153] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223936.476157] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223936.476163] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223936.476167] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223936.476171] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223936.476176] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223936.476180] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.476184] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223936.476187] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223936.476193] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223936.476197] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223936.476199] <EOI>
> [223936.476203] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.476207] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223936.476211] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.476215] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223936.476219] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223936.476222] Code: 08 ff 15 46 5c a1 00 48 c7 43 08 00 00 00 00 48 89 03 48 83 c4 08 5b c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 0f 31
> [223936.476241] c1 48 89 d0 48 c1 e0 20 89 ca 48 09 d0 c9 c3 66 2e 0f 1f 84
> [223936.476251] Call Trace:
> [223936.476252] <IRQ> [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223936.476257] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223936.476261] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223936.476265] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223936.476268] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223936.476272] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223936.476275] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223936.476278] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223936.476282] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223936.476286] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223936.476289] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.476292] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223936.476295] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223936.476299] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223936.476302] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223936.476304] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.476310] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223936.476313] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.476316] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223936.476320] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223936.580039] BUG: soft lockup - CPU#3 stuck for 23s! [kworker/0:1:0]
> [223936.580041] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223936.580050] irq event stamp: 2615464042
> [223936.580052] hardirqs last enabled at (2615464042): [<ffffffff816f5edb>] _raw_spin_unlock_irq+0x2b/0x50
> [223936.580057] hardirqs last disabled at (2615464041): [<ffffffff816f56a8>] _raw_spin_lock_irq+0x18/0x60
> [223936.580061] softirqs last enabled at (2615463964): [<ffffffff81063cce>] _local_bh_enable+0xe/0x10
> [223936.580065] softirqs last disabled at (2615463965): [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.580069] CPU 3
> [223936.580070] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223936.580078]
> [223936.580080] Pid: 0, comm: kworker/0:1 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223936.580085] RIP: 0010:[<ffffffff8101afa6>] [<ffffffff8101afa6>] native_read_tsc+0x6/0x20
> [223936.580090] RSP: 0018:ffff88022fcc3ce0 EFLAGS: 00000202
> [223936.580092] RAX: 000000007c457b06 RBX: ffffffff816f6334 RCX: 000000007c457ad5
> [223936.580094] RDX: 0000000000017b5d RSI: ffffffff818f9896 RDI: 0000000000000001
> [223936.580097] RBP: ffff88022fcc3ce0 R08: 000000007c457a88 R09: 0000000000000000
> [223936.580099] R10: ffff880226981f20 R11: 0000000000000000 R12: ffff88022fcc3c58
> [223936.580101] R13: ffffffff816feb33 R14: ffff88022fcc3ce0 R15: 00000000183a1380
> [223936.580104] FS: 0000000000000000(0000) GS:ffff88022fcc0000(0000) knlGS:0000000000000000
> [223936.580107] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223936.580109] CR2: 0000000000f38820 CR3: 0000000104b52000 CR4: 00000000000006e0
> [223936.580112] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223936.580114] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223936.580117] Process kworker/0:1 (pid: 0, threadinfo ffff880226988000, task ffff880226981f20)
> [223936.580119] Stack:
> [223936.580120] ffff88022fcc3d30 ffffffff813a4ee8 ffff880226988000 000000007c457ad5
> [223936.580125] 00000003ffffff10 ffff880031438948 00000000183a1380 000000006efcdc62
> [223936.580129] 0000000000000001 ffff880226981f20 ffff88022fcc3d40 ffffffff813a4f6a
> [223936.580133] Call Trace:
> [223936.580135] <IRQ>
> [223936.580138] [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223936.580142] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223936.580147] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223936.580151] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223936.580156] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223936.580160] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223936.580164] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223936.580168] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223936.580172] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223936.580176] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223936.580181] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.580185] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223936.580188] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223936.580192] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223936.580196] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223936.580199] <EOI>
> [223936.580202] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.580206] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223936.580211] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.580214] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223936.580218] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223936.580221] Code: 08 ff 15 46 5c a1 00 48 c7 43 08 00 00 00 00 48 89 03 48 83 c4 08 5b c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 0f 31
> [223936.580240] c1 48 89 d0 48 c1 e0 20 89 ca 48 09 d0 c9 c3 66 2e 0f 1f 84
> [223936.580250] Call Trace:
> [223936.580251] <IRQ> [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223936.580256] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223936.580260] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223936.580264] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223936.580267] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223936.580270] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223936.580274] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223936.580277] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223936.580280] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223936.580284] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223936.580288] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.580291] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223936.580294] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223936.580297] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223936.580300] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223936.580302] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.580308] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223936.580312] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.580315] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223936.580318] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223936.268002] RDX: 000000005932dd02 RSI: ffffffff818f9896 RDI: 0000000000000001
> [223936.268002] RBP: ffff88022fc03d30 R08: 000000005932dcb5 R09: 0000000000000000
> [223936.268002] R10: ffffffff81a2b020 R11: 0000000000000000 R12: ffff88022fc03c68
> [223936.268002] R13: ffffffff816feb33 R14: ffff88022fc03d30 R15: 0000000017f328cd
> [223936.268002] FS: 0000000000000000(0000) GS:ffff88022fc00000(0000) knlGS:0000000000000000
> [223936.268002] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223936.268002] CR2: 00007f25e7bc13a0 CR3: 00000001426fc000 CR4: 00000000000006f0
> [223936.268002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223936.268002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223936.268002] Process swapper (pid: 0, threadinfo ffffffff819a6000, task ffffffff81a2b020)
> [223936.268002] Stack:
> [223936.268002] ffffffff819a6000 000000005932dd02 000000002fc03d18 ffff8801f6c22448
> [223936.268002] 0000000017f328cd 000000006efcdc62 0000000000000001 ffffffff81a2b020
> [223936.268002] ffff88022fc03d40 ffffffff813a4f6a ffff88022fc03d80 ffffffff813ac2ab
> [223936.268002] Call Trace:
> [223936.268002] <IRQ>
> [223936.268002] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223936.268002] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223936.268002] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223936.268002] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223936.268002] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223936.268002] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223936.268002] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223936.268002] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223936.268002] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223936.268002] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.268002] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223936.268002] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223936.268002] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223936.268002] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223936.268002] <EOI>
> [223936.268002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.268002] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223936.268002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.268002] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223936.268002] [<ffffffff816ca491>] rest_init+0xd1/0xe0
> [223936.268002] [<ffffffff816ca3c0>] ? csum_partial_copy_generic+0x170/0x170
> [223936.268002] [<ffffffff81adcc55>] start_kernel+0x360/0x3ac
> [223936.268002] [<ffffffff81adc2a2>] x86_64_start_reservations+0x82/0x89
> [223936.268002] [<ffffffff81adc3b8>] x86_64_start_kernel+0x10f/0x12a
> [223936.268002] [<ffffffff81adc140>] ? early_idt_handlers+0x140/0x140
> [223936.268002] Code: 4c 89 7d c8 eb 1f 66 90 48 8b 45 c0 83 68 1c 01 f3 90 83 40 1c 01 65 44 8b 3c 25 50 d3 00 00 44 3b 7d d4 75 3b 66 66 90 0f ae e8 <e8> b8 60 c7 ff 66 90 4c 63 c0 4c 89 c0 48 2b 45 c8 48 39 d8 72
> [223936.268002] Call Trace:
> [223936.268002] <IRQ> [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223936.268002] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223936.268002] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223936.268002] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223936.268002] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223936.268002] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223936.268002] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223936.268002] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223936.268002] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223936.268002] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223936.268002] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223936.268002] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223936.268002] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223936.268002] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223936.268002] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.268002] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223936.268002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223936.268002] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223936.268002] [<ffffffff816ca491>] rest_init+0xd1/0xe0
> [223936.268002] [<ffffffff816ca3c0>] ? csum_partial_copy_generic+0x170/0x170
> [223936.268002] [<ffffffff81adcc55>] start_kernel+0x360/0x3ac
> [223936.268002] [<ffffffff81adc2a2>] x86_64_start_reservations+0x82/0x89
> [223936.268002] [<ffffffff81adc3b8>] x86_64_start_kernel+0x10f/0x12a
> [223936.268002] [<ffffffff81adc140>] ? early_idt_handlers+0x140/0x140
> [223964.264018] BUG: soft lockup - CPU#0 stuck for 22s! [swapper:0]
> [223964.268002] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223964.268002] irq event stamp: 2595159887
> [223964.268002] hardirqs last enabled at (2595159887): [<ffffffff8101b805>] mwait_idle+0x145/0x170
> [223964.268002] hardirqs last disabled at (2595159886): [<ffffffff81013139>] cpu_idle+0x79/0xf0
> [223964.268002] softirqs last enabled at (2595159878): [<ffffffff81064176>] __do_softirq+0x1f6/0x250
> [223964.268002] softirqs last disabled at (2595159873): [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.268002] CPU 0
> [223964.268002] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223964.268002]
> [223964.268002] Pid: 0, comm: swapper Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223964.268002] RIP: 0010:[<ffffffff8101afa6>] [<ffffffff8101afa6>] native_read_tsc+0x6/0x20
> [223964.268002] RSP: 0018:ffff88022fc03ce0 EFLAGS: 00000202
> [223964.268002] RAX: 000000007cb6c61b RBX: ffffffff816f6334 RCX: 000000007cb6c5e3
> [223964.372025] BUG: soft lockup - CPU#1 stuck for 23s! [kworker/0:0:0]
> [223964.372027] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223964.372036] irq event stamp: 2598787699
> [223964.372037] hardirqs last enabled at (2598787699): [<ffffffff8101b805>] mwait_idle+0x145/0x170
> [223964.372042] hardirqs last disabled at (2598787698): [<ffffffff81013139>] cpu_idle+0x79/0xf0
> [223964.372045] softirqs last enabled at (2598787696): [<ffffffff81064176>] __do_softirq+0x1f6/0x250
> [223964.372049] softirqs last disabled at (2598787681): [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.372052] CPU 1
> [223964.372053] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223964.372061]
> [223964.372063] Pid: 0, comm: kworker/0:0 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223964.372067] RIP: 0010:[<ffffffff8101afa0>] [<ffffffff8101afa0>] read_persistent_clock+0x30/0x30
> [223964.372072] RSP: 0018:ffff88022fc43ce8 EFLAGS: 00000202
> [223964.372074] RAX: 0000000000000001 RBX: ffff88022fc43c68 RCX: 0000000088b369fd
> [223964.372076] RDX: 0000000000000200 RSI: 0000000000000000 RDI: 0000000000000001
> [223964.372078] RBP: ffff88022fc43d30 R08: ffffffff88b369fd R09: 0000000000000000
> [223964.372081] R10: ffff88022690dd60 R11: 0000000000000000 R12: ffff88022fc43c58
> [223964.372083] R13: ffffffff816feb33 R14: ffff88022fc43d30 R15: 00000000307e58b4
> [223964.372086] FS: 0000000000000000(0000) GS:ffff88022fc40000(0000) knlGS:0000000000000000
> [223964.372089] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223964.372091] CR2: 00007f472ba6a6fc CR3: 0000000126bb7000 CR4: 00000000000006e0
> [223964.372093] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223964.372096] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223964.372098] Process kworker/0:0 (pid: 0, threadinfo ffff880226928000, task ffff88022690dd60)
> [223964.372100] Stack:
> [223964.372102] ffffffff813a4eaf ffff880226928000 ffffffff88b369c5 000000012fc43d18
> [223964.372106] ffff88002e90e348 00000000307e58b4 000000006efcdc62 0000000000000001
> [223964.372111] ffff88022690dd60 ffff88022fc43d40 ffffffff813a4f6a ffff88022fc43d80
> [223964.372115] Call Trace:
> [223964.372116] <IRQ>
> [223964.372119] [<ffffffff813a4eaf>] ? delay_tsc+0x3f/0xd0
> [223964.372123] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223964.372127] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223964.372132] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223964.372136] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223964.372140] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223964.372144] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223964.372148] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223964.372153] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223964.372158] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223964.372162] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.372166] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223964.372170] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223964.372174] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223964.372178] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223964.372180] <EOI>
> [223964.372184] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.372188] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223964.372192] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.372196] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223964.372200] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223964.372203] Code: 48 89 fb 48 83 ec 08 ff 15 46 5c a1 00 48 c7 43 08 00 00 00 00 48 89 03 48 83 c4 08 5b c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00
> [223964.372221] 48 89 e5 0f 31 89 c1 48 89 d0 48 c1 e0 20 89 ca 48 09 d0 c9
> [223964.372231] Call Trace:
> [223964.372232] <IRQ> [<ffffffff813a4eaf>] ? delay_tsc+0x3f/0xd0
> [223964.372237] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223964.372241] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223964.372245] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223964.372248] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223964.372251] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223964.372255] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223964.372258] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223964.372261] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223964.372265] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223964.372268] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.372271] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223964.372275] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223964.372278] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223964.372281] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223964.372282] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.372288] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223964.372292] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.372295] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223964.372298] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223964.476031] BUG: soft lockup - CPU#2 stuck for 23s! [kworker/0:1:0]
> [223964.476033] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223964.476042] irq event stamp: 2613824057
> [223964.476043] hardirqs last enabled at (2613824057): [<ffffffff8101b805>] mwait_idle+0x145/0x170
> [223964.476048] hardirqs last disabled at (2613824056): [<ffffffff81013139>] cpu_idle+0x79/0xf0
> [223964.476051] softirqs last enabled at (2613824048): [<ffffffff81064176>] __do_softirq+0x1f6/0x250
> [223964.476055] softirqs last disabled at (2613824031): [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.476059] CPU 2
> [223964.476060] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223964.476067]
> [223964.476070] Pid: 0, comm: kworker/0:1 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223964.476074] RIP: 0010:[<ffffffff8101afa6>] [<ffffffff8101afa6>] native_read_tsc+0x6/0x20
> [223964.476078] RSP: 0018:ffff88022fc83ce0 EFLAGS: 00000206
> [223964.476080] RAX: 00000000943e6715 RBX: ffffffff816f6334 RCX: 00000000943e66dd
> [223964.476083] RDX: 0000000000017b69 RSI: 0000000000000000 RDI: 0000000000000001
> [223964.476085] RBP: ffff88022fc83ce0 R08: ffffffff943e6697 R09: 0000000000000000
> [223964.476087] R10: ffff880226948000 R11: 0000000000000000 R12: ffff88022fc83c58
> [223964.476090] R13: ffffffff816feb33 R14: ffff88022fc83ce0 R15: 000000003094ad30
> [223964.476092] FS: 0000000000000000(0000) GS:ffff88022fc80000(0000) knlGS:0000000000000000
> [223964.476095] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223964.476097] CR2: 00007f25e7874d7f CR3: 0000000124c0d000 CR4: 00000000000006e0
> [223964.476100] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223964.476102] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223964.476105] Process kworker/0:1 (pid: 0, threadinfo ffff88022693e000, task ffff880226948000)
> [223964.476107] Stack:
> [223964.476108] ffff88022fc83d30 ffffffff813a4ee8 ffff88022693e000 ffffffff943e66dd
> [223964.476113] 00000002ffffff10 ffff88006afd8948 000000003094ad30 000000006efcdc62
> [223964.476117] 0000000000000001 ffff880226948000 ffff88022fc83d40 ffffffff813a4f6a
> [223964.476121] Call Trace:
> [223964.476123] <IRQ>
> [223964.476126] [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223964.476130] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223964.476134] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223964.476139] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223964.476143] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223964.476147] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223964.476151] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223964.476155] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223964.476159] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223964.476164] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223964.476168] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.476172] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223964.476176] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223964.476180] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223964.476184] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223964.476186] <EOI>
> [223964.476190] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.476194] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223964.476198] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.476202] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223964.476206] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223964.476208] Code: 08 ff 15 46 5c a1 00 48 c7 43 08 00 00 00 00 48 89 03 48 83 c4 08 5b c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 0f 31
> [223964.476227] c1 48 89 d0 48 c1 e0 20 89 ca 48 09 d0 c9 c3 66 2e 0f 1f 84
> [223964.476236] Call Trace:
> [223964.476238] <IRQ> [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223964.476243] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223964.476246] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223964.476250] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223964.476254] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223964.476257] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223964.476260] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223964.476264] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223964.476267] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223964.476271] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223964.476274] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.476277] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223964.476281] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223964.476284] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223964.476287] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223964.476289] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.476295] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223964.476298] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.476301] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223964.476304] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223964.580038] BUG: soft lockup - CPU#3 stuck for 23s! [kworker/0:1:0]
> [223964.580040] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223964.580049] irq event stamp: 2615464042
> [223964.580050] hardirqs last enabled at (2615464042): [<ffffffff816f5edb>] _raw_spin_unlock_irq+0x2b/0x50
> [223964.580054] hardirqs last disabled at (2615464041): [<ffffffff816f56a8>] _raw_spin_lock_irq+0x18/0x60
> [223964.580058] softirqs last enabled at (2615463964): [<ffffffff81063cce>] _local_bh_enable+0xe/0x10
> [223964.580062] softirqs last disabled at (2615463965): [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.580066] CPU 3
> [223964.580067] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223964.580075]
> [223964.580077] Pid: 0, comm: kworker/0:1 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223964.580081] RIP: 0010:[<ffffffff8101afa6>] [<ffffffff8101afa6>] native_read_tsc+0x6/0x20
> [223964.580086] RSP: 0018:ffff88022fcc3ce0 EFLAGS: 00000206
> [223964.580088] RAX: 000000009fc963af RBX: ffffffff816f6334 RCX: 000000009fc96377
> [223964.580090] RDX: 0000000000017b69 RSI: ffffffff818f9896 RDI: 0000000000000001
> [223964.580093] RBP: ffff88022fcc3ce0 R08: ffffffff9fc96331 R09: 0000000000000000
> [223964.580095] R10: ffff880226981f20 R11: 0000000000000000 R12: ffff88022fcc3c58
> [223964.580097] R13: ffffffff816feb33 R14: ffff88022fcc3ce0 R15: 0000000030ac88b0
> [223964.580100] FS: 0000000000000000(0000) GS:ffff88022fcc0000(0000) knlGS:0000000000000000
> [223964.580103] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223964.580105] CR2: 0000000000f38820 CR3: 0000000104b52000 CR4: 00000000000006e0
> [223964.580107] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223964.580110] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223964.580112] Process kworker/0:1 (pid: 0, threadinfo ffff880226988000, task ffff880226981f20)
> [223964.580114] Stack:
> [223964.580116] ffff88022fcc3d30 ffffffff813a4ee8 ffff880226988000 ffffffff9fc96377
> [223964.580120] 000000039c3b34d8 ffff880031438948 0000000030ac88b0 000000006efcdc62
> [223964.580124] 0000000000000001 ffff880226981f20 ffff88022fcc3d40 ffffffff813a4f6a
> [223964.580128] Call Trace:
> [223964.580130] <IRQ>
> [223964.580133] [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223964.580137] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223964.580141] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223964.580146] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223964.580150] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223964.580154] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223964.580158] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223964.580162] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223964.580167] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223964.580171] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223964.580176] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.580180] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223964.580184] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223964.580188] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223964.580192] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223964.580194] <EOI>
> [223964.580198] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.580202] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223964.580206] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.580210] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223964.580214] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223964.580217] Code: 08 ff 15 46 5c a1 00 48 c7 43 08 00 00 00 00 48 89 03 48 83 c4 08 5b c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 0f 31
> [223964.580235] c1 48 89 d0 48 c1 e0 20 89 ca 48 09 d0 c9 c3 66 2e 0f 1f 84
> [223964.580245] Call Trace:
> [223964.580246] <IRQ> [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223964.580252] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223964.580255] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223964.580259] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223964.580262] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223964.580265] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223964.580269] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223964.580272] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223964.580276] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223964.580279] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223964.580283] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.580286] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223964.580289] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223964.580292] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223964.580295] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223964.580297] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.580303] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223964.580307] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.580310] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223964.580313] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223964.268002] RDX: 0000000000017b69 RSI: ffffffff818f9896 RDI: 0000000000000001
> [223964.268002] RBP: ffff88022fc03ce0 R08: 000000007cb6c596 R09: 0000000000000000
> [223964.268002] R10: ffffffff81a2b020 R11: 0000000000000000 R12: ffff88022fc03c58
> [223964.268002] R13: ffffffff816feb33 R14: ffff88022fc03ce0 R15: 000000002eb85d38
> [223964.268002] FS: 0000000000000000(0000) GS:ffff88022fc00000(0000) knlGS:0000000000000000
> [223964.268002] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223964.268002] CR2: 00007f25e7bc13a0 CR3: 00000001426fc000 CR4: 00000000000006f0
> [223964.268002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223964.268002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223964.268002] Process swapper (pid: 0, threadinfo ffffffff819a6000, task ffffffff81a2b020)
> [223964.268002] Stack:
> [223964.268002] ffff88022fc03d30 ffffffff813a4ee8 ffffffff819a6000 000000007cb6c5e3
> [223964.268002] 000000007c44ac9c ffff8801f6c22448 000000002eb85d38 000000006efcdc62
> [223964.268002] 0000000000000001 ffffffff81a2b020 ffff88022fc03d40 ffffffff813a4f6a
> [223964.268002] Call Trace:
> [223964.268002] <IRQ>
> [223964.268002] [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223964.268002] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223964.268002] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223964.268002] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223964.268002] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223964.268002] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223964.268002] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223964.268002] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223964.268002] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223964.268002] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223964.268002] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.268002] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223964.268002] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223964.268002] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223964.268002] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223964.268002] <EOI>
> [223964.268002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.268002] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223964.268002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.268002] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223964.268002] [<ffffffff816ca491>] rest_init+0xd1/0xe0
> [223964.268002] [<ffffffff816ca3c0>] ? csum_partial_copy_generic+0x170/0x170
> [223964.268002] [<ffffffff81adcc55>] start_kernel+0x360/0x3ac
> [223964.268002] [<ffffffff81adc2a2>] x86_64_start_reservations+0x82/0x89
> [223964.268002] [<ffffffff81adc3b8>] x86_64_start_kernel+0x10f/0x12a
> [223964.268002] [<ffffffff81adc140>] ? early_idt_handlers+0x140/0x140
> [223964.268002] Code: 08 ff 15 46 5c a1 00 48 c7 43 08 00 00 00 00 48 89 03 48 83 c4 08 5b c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 0f 31
> [223964.268002] c1 48 89 d0 48 c1 e0 20 89 ca 48 09 d0 c9 c3 66 2e 0f 1f 84
> [223964.268002] Call Trace:
> [223964.268002] <IRQ> [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223964.268002] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223964.268002] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223964.268002] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223964.268002] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223964.268002] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223964.268002] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223964.268002] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223964.268002] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223964.268002] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223964.268002] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223964.268002] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223964.268002] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223964.268002] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223964.268002] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223964.268002] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.268002] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223964.268002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223964.268002] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223964.268002] [<ffffffff816ca491>] rest_init+0xd1/0xe0
> [223964.268002] [<ffffffff816ca3c0>] ? csum_partial_copy_generic+0x170/0x170
> [223964.268002] [<ffffffff81adcc55>] start_kernel+0x360/0x3ac
> [223964.268002] [<ffffffff81adc2a2>] x86_64_start_reservations+0x82/0x89
> [223964.268002] [<ffffffff81adc3b8>] x86_64_start_kernel+0x10f/0x12a
> [223964.268002] [<ffffffff81adc140>] ? early_idt_handlers+0x140/0x140
> [223968.815995] INFO: rcu_sched_state detected stall on CPU 1 (t=15000 jiffies)
> [223968.819995] INFO: rcu_sched_state detected stalls on CPUs/tasks: { 1} (detected by 3, t=15002 jiffies)
> [223968.820000] sending NMI to all CPUs:
> [223968.820002] NMI backtrace for cpu 3
> [223968.820002] CPU 3
> [223968.820002] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223968.820002]
> [223968.820002] Pid: 0, comm: kworker/0:1 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223968.820002] RIP: 0010:[<ffffffff813a4f86>] [<ffffffff813a4f86>] __const_udelay+0x16/0x40
> [223968.820002] RSP: 0018:ffff88022fcc3a90 EFLAGS: 00000002
> [223968.820002] RAX: 0000000000e34d8a RBX: 0000000000000001 RCX: 0000000001062560
> [223968.820002] RDX: 000000000071a6c5 RSI: 0000000000000002 RDI: 0000000000418958
> [223968.820002] RBP: ffff88022fcc3ab0 R08: 0000000000000002 R09: 0000000000000000
> [223968.820002] R10: 0000000000000006 R11: 000000000000000a R12: ffffffff81a40d80
> [223968.820002] R13: 0000000000000010 R14: ffffffff81a40e40 R15: ffffffff81a40fc0
> [223968.820002] FS: 0000000000000000(0000) GS:ffff88022fcc0000(0000) knlGS:0000000000000000
> [223968.820002] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223968.820002] CR2: 0000000000f38820 CR3: 0000000104b52000 CR4: 00000000000006e0
> [223968.820002] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223968.820002] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223968.820002] Process kworker/0:1 (pid: 0, threadinfo ffff880226988000, task ffff880226981f20)
> [223968.820002] Stack:
> [223968.820002] ffff88022fcc3ab0 ffffffff81031695 ffff88022fccdfa0 ffff88022fccdfa0
> [223968.820002] ffff88022fcc3af0 ffffffff810bb9d2 ffffffff81a40fc0 0000000000000003
> [223968.820002] 0000000000000003 ffff880226981f20 ffffffff810921f0 ffff88022fcc3be0
> [223968.820002] Call Trace:
> [223968.820002] <IRQ>
> [223968.820002] [<ffffffff81031695>] ? arch_trigger_all_cpu_backtrace+0x65/0x90
> [223968.820002] [<ffffffff810bb9d2>] __rcu_pending+0x382/0x3b0
> [223968.820002] [<ffffffff810921f0>] ? tick_nohz_handler+0x100/0x100
> [223968.820002] [<ffffffff810bba67>] rcu_check_callbacks+0x67/0x130
> [223968.820002] [<ffffffff8106d861>] update_process_times+0x41/0x80
> [223968.820002] [<ffffffff81092256>] tick_sched_timer+0x66/0xc0
> [223968.820002] [<ffffffff810845ee>] __run_hrtimer+0xfe/0x1e0
> [223968.820002] [<ffffffff8108491d>] hrtimer_interrupt+0xcd/0x1f0
> [223968.820002] [<ffffffff810310c4>] smp_apic_timer_interrupt+0x64/0xa0
> [223968.820002] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.820002] [<ffffffff816f6334>] ? retint_restore_args+0x13/0x13
> [223968.820002] [<ffffffff8101afa6>] ? native_read_tsc+0x6/0x20
> [223968.820002] [<ffffffff813a4eaf>] delay_tsc+0x3f/0xd0
> [223968.820002] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223968.820002] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223968.820002] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223968.820002] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223968.820002] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223968.820002] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223968.820002] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223968.820002] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223968.820002] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223968.820002] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223968.820002] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223968.820002] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223968.820002] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223968.820002] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.820002] <EOI>
> [223968.820002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820002] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223968.820002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820002] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223968.820002] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223968.820002] Code: 00 00 00 00 00 55 48 89 e5 ff 15 8e a5 6c 00 c9 c3 0f 1f 40 00 55 48 8d 0c bd 00 00 00 00 65 48 8b 14 25 58 2d 01 00 48 8d 04 12
> [223968.820002] c1 e2 06 48 89 e5 48 29 c2 48 89 c8 f7 e2 48 8d 7a 01 ff 15
> [223968.820002] Call Trace:
> [223968.820002] <IRQ> [<ffffffff81031695>] ? arch_trigger_all_cpu_backtrace+0x65/0x90
> [223968.820002] [<ffffffff810bb9d2>] __rcu_pending+0x382/0x3b0
> [223968.820002] [<ffffffff810921f0>] ? tick_nohz_handler+0x100/0x100
> [223968.820002] [<ffffffff810bba67>] rcu_check_callbacks+0x67/0x130
> [223968.820002] [<ffffffff8106d861>] update_process_times+0x41/0x80
> [223968.820002] [<ffffffff81092256>] tick_sched_timer+0x66/0xc0
> [223968.820002] [<ffffffff810845ee>] __run_hrtimer+0xfe/0x1e0
> [223968.820002] [<ffffffff8108491d>] hrtimer_interrupt+0xcd/0x1f0
> [223968.820002] [<ffffffff810310c4>] smp_apic_timer_interrupt+0x64/0xa0
> [223968.820002] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.820002] [<ffffffff816f6334>] ? retint_restore_args+0x13/0x13
> [223968.820002] [<ffffffff8101afa6>] ? native_read_tsc+0x6/0x20
> [223968.820002] [<ffffffff813a4eaf>] delay_tsc+0x3f/0xd0
> [223968.820002] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223968.820002] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223968.820002] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223968.820002] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223968.820002] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223968.820002] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223968.820002] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223968.820002] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223968.820002] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223968.820002] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223968.820002] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223968.820002] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223968.820002] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223968.820002] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.820002] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820002] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223968.820002] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820002] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223968.820002] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223968.820335] NMI backtrace for cpu 0
> [223968.820337] CPU 0
> [223968.820338] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223968.820347]
> [223968.820349] Pid: 0, comm: swapper Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223968.820353] RIP: 0010:[<ffffffff813a4ef0>] [<ffffffff813a4ef0>] delay_tsc+0x80/0xd0
> [223968.820358] RSP: 0018:ffff88022fc03cf0 EFLAGS: 00000206
> [223968.820360] RAX: 000000007659b10f RBX: 0000000000000001 RCX: 000000007659b10f
> [223968.820363] RDX: 000000007659b10f RSI: ffffffff818f9896 RDI: 0000000000000001
> [223968.820365] RBP: ffff88022fc03d30 R08: 000000007659b10f R09: 0000000000000000
> [223968.820367] R10: ffffffff81a2b020 R11: 0000000000000000 R12: 0000000031026962
> [223968.820370] R13: 000000006efcdc62 R14: ffffffff819a6000 R15: 000000007659b0de
> [223968.820373] FS: 0000000000000000(0000) GS:ffff88022fc00000(0000) knlGS:0000000000000000
> [223968.820375] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223968.820377] CR2: 00007f25e7bc13a0 CR3: 00000001426fc000 CR4: 00000000000006f0
> [223968.820380] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223968.820382] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223968.820385] Process swapper (pid: 0, threadinfo ffffffff819a6000, task ffffffff81a2b020)
> [223968.820387] Stack:
> [223968.820388] ffffffff819a6000 000000007659b0de 00000000818f9896 ffff8801f6c22448
> [223968.820393] 0000000031026962 000000006efcdc62 0000000000000001 ffffffff81a2b020
> [223968.820397] ffff88022fc03d40 ffffffff813a4f6a ffff88022fc03d80 ffffffff813ac2ab
> [223968.820401] Call Trace:
> [223968.820402] <IRQ>
> [223968.820406] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223968.820410] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223968.820414] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223968.820417] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223968.820420] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223968.820424] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223968.820427] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223968.820430] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223968.820434] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223968.820437] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223968.820441] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223968.820444] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223968.820447] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223968.820450] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.820452] <EOI>
> [223968.820455] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820459] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223968.820462] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820465] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223968.820468] [<ffffffff816ca491>] rest_init+0xd1/0xe0
> [223968.820471] [<ffffffff816ca3c0>] ? csum_partial_copy_generic+0x170/0x170
> [223968.820475] [<ffffffff81adcc55>] start_kernel+0x360/0x3ac
> [223968.820478] [<ffffffff81adc2a2>] x86_64_start_reservations+0x82/0x89
> [223968.820481] [<ffffffff81adc3b8>] x86_64_start_kernel+0x10f/0x12a
> [223968.820484] [<ffffffff81adc140>] ? early_idt_handlers+0x140/0x140
> [223968.820486] Code: 68 1c 01 f3 90 83 40 1c 01 65 44 8b 3c 25 50 d3 00 00 44 3b 7d d4 75 3b 66 66 90 0f ae e8 e8 b8 60 c7 ff 66 90 4c 63 c0 4c 89 c0
> [223968.820504] 2b 45 c8 48 39 d8 72 c7 65 48 8b 04 25 08 c4 00 00 83 a8 44
> [223968.820514] Call Trace:
> [223968.820515] <IRQ> [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223968.820521] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223968.820525] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223968.820528] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223968.820532] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223968.820535] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223968.820538] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223968.820542] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223968.820546] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223968.820549] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223968.820552] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223968.820556] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223968.820559] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223968.820562] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.820564] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820570] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223968.820573] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820576] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223968.820579] [<ffffffff816ca491>] rest_init+0xd1/0xe0
> [223968.820583] [<ffffffff816ca3c0>] ? csum_partial_copy_generic+0x170/0x170
> [223968.820586] [<ffffffff81adcc55>] start_kernel+0x360/0x3ac
> [223968.820589] [<ffffffff81adc2a2>] x86_64_start_reservations+0x82/0x89
> [223968.820593] [<ffffffff81adc3b8>] x86_64_start_kernel+0x10f/0x12a
> [223968.820596] [<ffffffff81adc140>] ? early_idt_handlers+0x140/0x140
> [223968.820599] NMI backtrace for cpu 2
> [223968.820600] CPU 2
> [223968.820602] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223968.820610]
> [223968.820612] Pid: 0, comm: kworker/0:1 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223968.820616] RIP: 0010:[<ffffffff8101afa6>] [<ffffffff8101afa6>] native_read_tsc+0x6/0x20
> [223968.820621] RSP: 0018:ffff88022fc83ce0 EFLAGS: 00000202
> [223968.820623] RAX: 000000007659b116 RBX: 0000000000000001 RCX: 000000007659b0e5
> [223968.820625] RDX: 0000000000017b6b RSI: 0000000000000000 RDI: 0000000000000001
> [223968.820628] RBP: ffff88022fc83ce0 R08: 000000007659b098 R09: 0000000000000000
> [223968.820630] R10: ffff880226948000 R11: 0000000000000000 R12: 00000000345f87d7
> [223968.820632] R13: 000000006efcdc62 R14: ffff88022693e000 R15: 000000007659b0e5
> [223968.820635] FS: 0000000000000000(0000) GS:ffff88022fc80000(0000) knlGS:0000000000000000
> [223968.820638] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223968.820640] CR2: 00007f25e7874d7f CR3: 0000000124c0d000 CR4: 00000000000006e0
> [223968.820642] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223968.820645] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223968.820647] Process kworker/0:1 (pid: 0, threadinfo ffff88022693e000, task ffff880226948000)
> [223968.820649] Stack:
> [223968.820651] ffff88022fc83d30 ffffffff813a4ee8 ffff88022693e000 000000007659b0e5
> [223968.820655] 000000026b4044c5 ffff88006afd8948 00000000345f87d7 000000006efcdc62
> [223968.820659] 0000000000000001 ffff880226948000 ffff88022fc83d40 ffffffff813a4f6a
> [223968.820663] Call Trace:
> [223968.820665] <IRQ>
> [223968.820668] [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223968.820671] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223968.820674] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223968.820678] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223968.820682] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223968.820685] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223968.820688] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223968.820691] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223968.820695] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223968.820699] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223968.820702] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223968.820705] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223968.820708] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223968.820712] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223968.820715] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.820717] <EOI>
> [223968.820720] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820723] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223968.820727] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820730] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223968.820733] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223968.820735] Code: 08 ff 15 46 5c a1 00 48 c7 43 08 00 00 00 00 48 89 03 48 83 c4 08 5b c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 0f 31
> [223968.820753] c1 48 89 d0 48 c1 e0 20 89 ca 48 09 d0 c9 c3 66 2e 0f 1f 84
> [223968.820763] Call Trace:
> [223968.820764] <IRQ> [<ffffffff813a4ee8>] delay_tsc+0x78/0xd0
> [223968.820769] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223968.820773] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223968.820777] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223968.820780] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223968.820783] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223968.820787] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223968.820790] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223968.820793] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223968.820797] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223968.820801] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223968.820804] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223968.820807] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223968.820810] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223968.820813] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.820815] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820821] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223968.820824] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.820827] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223968.820831] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223968.816001] NMI backtrace for cpu 1
> [223968.816001] CPU 1
> [223968.816001] Modules linked in: ipmi_devintf ipmi_si ipmi_msghandler xt_recent nf_conntrack_ftp xt_state xt_owner nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 bnx2
> [223968.816001]
> [223968.816001] Pid: 0, comm: kworker/0:0 Not tainted 3.1.0-rc10-hw-lockdep+ #51 Dell Inc. PowerEdge 1950/0M788G
> [223968.816001] RIP: 0010:[<ffffffff81440955>] [<ffffffff81440955>] io_serial_out+0x15/0x20
> [223968.816001] RSP: 0018:ffff88022fc437f0 EFLAGS: 00000002
> [223968.816001] RAX: 0000000000000073 RBX: ffffffff8243eec0 RCX: 0000000000000000
> [223968.816001] RDX: 00000000000003f8 RSI: 00000000000003f8 RDI: ffffffff8243eec0
> [223968.816001] RBP: ffff88022fc437f0 R08: 000000007659a435 R09: 0000000000000000
> [223968.816001] R10: 0000000000000001 R11: 000000000000000a R12: 0000000000000073
> [223968.816001] R13: ffffffff81bc648d R14: 0000000000000050 R15: ffffffff8243eec0
> [223968.816001] FS: 0000000000000000(0000) GS:ffff88022fc40000(0000) knlGS:0000000000000000
> [223968.816001] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [223968.816001] CR2: 00007f472ba6a6fc CR3: 0000000126bb7000 CR4: 00000000000006e0
> [223968.816001] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [223968.816001] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [223968.816001] Process kworker/0:0 (pid: 0, threadinfo ffff880226928000, task ffff88022690dd60)
> [223968.816001] Stack:
> [223968.816001] ffff88022fc43810 ffffffff814410dc 0000000000000030 ffffffff814410b0
> [223968.816001] ffff88022fc43850 ffffffff8143cdb5 0000000000000087 0000000000000000
> [223968.816001] ffffffff8243eec0 0000000000000001 0000000000000087 000000000000000d
> [223968.816001] Call Trace:
> [223968.816001] <IRQ>
> [223968.816001] [<ffffffff814410dc>] serial8250_console_putchar+0x2c/0x40
> [223968.816001] [<ffffffff814410b0>] ? wait_for_xmitr+0xa0/0xa0
> [223968.816001] [<ffffffff8143cdb5>] uart_console_write+0x35/0x70
> [223968.816001] [<ffffffff814417be>] serial8250_console_write+0xbe/0x1a0
> [223968.816001] [<ffffffff8105c78e>] __call_console_drivers+0x8e/0xb0
> [223968.816001] [<ffffffff8105c7f5>] _call_console_drivers+0x45/0x70
> [223968.816001] [<ffffffff8105d02f>] console_unlock+0x17f/0x2b0
> [223968.816001] [<ffffffff8105d64d>] vprintk+0x1fd/0x520
> [223968.816001] [<ffffffff816f16c1>] printk+0x67/0x69
> [223968.816001] [<ffffffff816f5fa6>] ? _raw_spin_unlock+0x26/0x40
> [223968.816001] [<ffffffff8105388b>] ? account_system_time+0xab/0x190
> [223968.816001] [<ffffffff810bb7e4>] __rcu_pending+0x194/0x3b0
> [223968.816001] [<ffffffff810921f0>] ? tick_nohz_handler+0x100/0x100
> [223968.816001] [<ffffffff810bba67>] rcu_check_callbacks+0x67/0x130
> [223968.816001] [<ffffffff8106d861>] update_process_times+0x41/0x80
> [223968.816001] [<ffffffff81092256>] tick_sched_timer+0x66/0xc0
> [223968.816001] [<ffffffff810845ee>] __run_hrtimer+0xfe/0x1e0
> [223968.816001] [<ffffffff8108491d>] hrtimer_interrupt+0xcd/0x1f0
> [223968.816001] [<ffffffff810310c4>] smp_apic_timer_interrupt+0x64/0xa0
> [223968.816001] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.816001] [<ffffffff816f6334>] ? retint_restore_args+0x13/0x13
> [223968.816001] [<ffffffff8101afa6>] ? native_read_tsc+0x6/0x20
> [223968.816001] [<ffffffff813a4eaf>] delay_tsc+0x3f/0xd0
> [223968.816001] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223968.816001] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223968.816001] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223968.816001] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223968.816001] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223968.816001] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223968.816001] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223968.816001] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223968.816001] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223968.816001] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223968.816001] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223968.816001] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223968.816001] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223968.816001] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.816001] <EOI>
> [223968.816001] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.816001] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223968.816001] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.816001] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223968.816001] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
> [223968.816001] Code: 48 89 e5 d3 e2 03 57 38 ec 0f b6 c0 c9 c3 0f 1f 84 00 00 00 00 00 0f b6 8f 81 00 00 00 55 89 d0 48 89 e5 d3 e6 03 77 38 89 f2 ee <c9> c3 66 0f 1f 84 00 00 00 00 00 55 80 bf 82 00 00 00 08 48 89
> [223968.816001] Call Trace:
> [223968.816001] <IRQ> [<ffffffff814410dc>] serial8250_console_putchar+0x2c/0x40
> [223968.816001] [<ffffffff814410b0>] ? wait_for_xmitr+0xa0/0xa0
> [223968.816001] [<ffffffff8143cdb5>] uart_console_write+0x35/0x70
> [223968.816001] [<ffffffff814417be>] serial8250_console_write+0xbe/0x1a0
> [223968.816001] [<ffffffff8105c78e>] __call_console_drivers+0x8e/0xb0
> [223968.816001] [<ffffffff8105c7f5>] _call_console_drivers+0x45/0x70
> [223968.816001] [<ffffffff8105d02f>] console_unlock+0x17f/0x2b0
> [223968.816001] [<ffffffff8105d64d>] vprintk+0x1fd/0x520
> [223968.816001] [<ffffffff816f16c1>] printk+0x67/0x69
> [223968.816001] [<ffffffff816f5fa6>] ? _raw_spin_unlock+0x26/0x40
> [223968.816001] [<ffffffff8105388b>] ? account_system_time+0xab/0x190
> [223968.816001] [<ffffffff810bb7e4>] __rcu_pending+0x194/0x3b0
> [223968.816001] [<ffffffff810921f0>] ? tick_nohz_handler+0x100/0x100
> [223968.816001] [<ffffffff810bba67>] rcu_check_callbacks+0x67/0x130
> [223968.816001] [<ffffffff8106d861>] update_process_times+0x41/0x80
> [223968.816001] [<ffffffff81092256>] tick_sched_timer+0x66/0xc0
> [223968.816001] [<ffffffff810845ee>] __run_hrtimer+0xfe/0x1e0
> [223968.816001] [<ffffffff8108491d>] hrtimer_interrupt+0xcd/0x1f0
> [223968.816001] [<ffffffff810310c4>] smp_apic_timer_interrupt+0x64/0xa0
> [223968.816001] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.816001] [<ffffffff816f6334>] ? retint_restore_args+0x13/0x13
> [223968.816001] [<ffffffff8101afa6>] ? native_read_tsc+0x6/0x20
> [223968.816001] [<ffffffff813a4eaf>] delay_tsc+0x3f/0xd0
> [223968.816001] [<ffffffff813a4f6a>] __delay+0xa/0x10
> [223968.816001] [<ffffffff813ac2ab>] do_raw_spin_lock+0x13b/0x180
> [223968.816001] [<ffffffff816f5604>] _raw_spin_lock+0x44/0x50
> [223968.816001] [<ffffffff81661823>] ? tcp_keepalive_timer+0x23/0x270
> [223968.816001] [<ffffffff81661823>] tcp_keepalive_timer+0x23/0x270
> [223968.816001] [<ffffffff8106cd5d>] run_timer_softirq+0x26d/0x410
> [223968.816001] [<ffffffff8106cc88>] ? run_timer_softirq+0x198/0x410
> [223968.816001] [<ffffffff81661800>] ? tcp_init_xmit_timers+0x20/0x20
> [223968.816001] [<ffffffff810640b8>] __do_softirq+0x138/0x250
> [223968.816001] [<ffffffff817002bc>] call_softirq+0x1c/0x30
> [223968.816001] [<ffffffff810153c5>] do_softirq+0x95/0xd0
> [223968.816001] [<ffffffff81063c8d>] irq_exit+0xdd/0x110
> [223968.816001] [<ffffffff810310c9>] smp_apic_timer_interrupt+0x69/0xa0
> [223968.816001] [<ffffffff816feb33>] apic_timer_interrupt+0x73/0x80
> [223968.816001] <EOI> [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.816001] [<ffffffff8101b80e>] ? mwait_idle+0x14e/0x170
> [223968.816001] [<ffffffff8101b805>] ? mwait_idle+0x145/0x170
> [223968.816001] [<ffffffff81013156>] cpu_idle+0x96/0xf0
> [223968.816001] [<ffffffff816ec4bb>] start_secondary+0x1ca/0x1ff
>
> [ goes on for another ~300kB, trimmed ]
>
^ permalink raw reply
* [PATCH net-next] ipv4: use IS_ENABLED() macro to cleanup code
From: Eric Dumazet @ 2011-10-25 7:12 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Remove some ugly #ifdef, using IS_ENABLED(CONFIG_xxx) macro
IS_ENABLED(CONFIG_xxx) evaluates to 1 if CONFIG_xxx is set to 'y' or 'm'
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/ipv4/inet_diag.c | 65 +++++++++++++++----------------------
net/ipv4/ip_gre.c | 21 ++++-------
net/ipv4/ip_sockglue.c | 12 ++----
net/ipv4/tcp_input.c | 6 +--
net/ipv4/tcp_minisocks.c | 49 ++++++++++++++-------------
net/ipv4/tcp_timer.c | 6 +--
net/ipv4/tunnel4.c | 11 ++----
net/ipv4/xfrm4_tunnel.c | 12 +++---
8 files changed, 80 insertions(+), 102 deletions(-)
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
index f5e2bda..7f42cc3 100644
--- a/net/ipv4/inet_diag.c
+++ b/net/ipv4/inet_diag.c
@@ -125,8 +125,8 @@ static int inet_csk_diag_fill(struct sock *sk,
r->id.idiag_src[0] = inet->inet_rcv_saddr;
r->id.idiag_dst[0] = inet->inet_daddr;
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
- if (r->idiag_family == AF_INET6) {
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ r->idiag_family == AF_INET6) {
const struct ipv6_pinfo *np = inet6_sk(sk);
ipv6_addr_copy((struct in6_addr *)r->id.idiag_src,
@@ -136,7 +136,6 @@ static int inet_csk_diag_fill(struct sock *sk,
if (ext & (1 << (INET_DIAG_TOS - 1)))
RTA_PUT_U8(skb, INET_DIAG_TOS, np->tclass);
}
-#endif
#define EXPIRES_IN_MS(tmo) DIV_ROUND_UP((tmo - jiffies) * 1000, HZ)
@@ -219,8 +218,9 @@ static int inet_twsk_diag_fill(struct inet_timewait_sock *tw,
r->idiag_wqueue = 0;
r->idiag_uid = 0;
r->idiag_inode = 0;
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
- if (tw->tw_family == AF_INET6) {
+
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ tw->tw_family == AF_INET6) {
const struct inet6_timewait_sock *tw6 =
inet6_twsk((struct sock *)tw);
@@ -229,7 +229,6 @@ static int inet_twsk_diag_fill(struct inet_timewait_sock *tw,
ipv6_addr_copy((struct in6_addr *)r->id.idiag_dst,
&tw6->tw_v6_daddr);
}
-#endif
nlh->nlmsg_len = skb_tail_pointer(skb) - previous_tail;
return skb->len;
nlmsg_failure:
@@ -271,18 +270,15 @@ static int inet_diag_get_exact(struct sk_buff *in_skb,
sk = inet_lookup(&init_net, hashinfo, req->id.idiag_dst[0],
req->id.idiag_dport, req->id.idiag_src[0],
req->id.idiag_sport, req->id.idiag_if);
- }
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
- else if (req->idiag_family == AF_INET6) {
+ } else if (IS_ENABLED(CONFIG_IPV6) &&
+ req->idiag_family == AF_INET6) {
sk = inet6_lookup(&init_net, hashinfo,
(struct in6_addr *)req->id.idiag_dst,
req->id.idiag_dport,
(struct in6_addr *)req->id.idiag_src,
req->id.idiag_sport,
req->id.idiag_if);
- }
-#endif
- else {
+ } else {
goto unlock;
}
@@ -501,15 +497,14 @@ static int inet_csk_diag_dump(struct sock *sk,
struct inet_sock *inet = inet_sk(sk);
entry.family = sk->sk_family;
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
- if (entry.family == AF_INET6) {
+
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ entry.family == AF_INET6) {
struct ipv6_pinfo *np = inet6_sk(sk);
entry.saddr = np->rcv_saddr.s6_addr32;
entry.daddr = np->daddr.s6_addr32;
- } else
-#endif
- {
+ } else {
entry.saddr = &inet->inet_rcv_saddr;
entry.daddr = &inet->inet_daddr;
}
@@ -539,15 +534,13 @@ static int inet_twsk_diag_dump(struct inet_timewait_sock *tw,
INET_DIAG_REQ_BYTECODE);
entry.family = tw->tw_family;
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
- if (tw->tw_family == AF_INET6) {
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ tw->tw_family == AF_INET6) {
struct inet6_timewait_sock *tw6 =
inet6_twsk((struct sock *)tw);
entry.saddr = tw6->tw_v6_rcv_saddr.s6_addr32;
entry.daddr = tw6->tw_v6_daddr.s6_addr32;
- } else
-#endif
- {
+ } else {
entry.saddr = &tw->tw_rcv_saddr;
entry.daddr = &tw->tw_daddr;
}
@@ -601,14 +594,14 @@ static int inet_diag_fill_req(struct sk_buff *skb, struct sock *sk,
r->idiag_wqueue = 0;
r->idiag_uid = sock_i_uid(sk);
r->idiag_inode = 0;
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
- if (r->idiag_family == AF_INET6) {
+
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ r->idiag_family == AF_INET6) {
ipv6_addr_copy((struct in6_addr *)r->id.idiag_src,
&inet6_rsk(req)->loc_addr);
ipv6_addr_copy((struct in6_addr *)r->id.idiag_dst,
&inet6_rsk(req)->rmt_addr);
}
-#endif
nlh->nlmsg_len = skb_tail_pointer(skb) - b;
return skb->len;
@@ -626,7 +619,7 @@ static int inet_diag_dump_reqs(struct sk_buff *skb, struct sock *sk,
struct inet_connection_sock *icsk = inet_csk(sk);
struct listen_sock *lopt;
const struct nlattr *bc = NULL;
- struct inet_sock *inet = inet_sk(sk);
+ const struct inet_sock *inet = inet_sk(sk);
int j, s_j;
int reqnum, s_reqnum;
int err = 0;
@@ -666,18 +659,14 @@ static int inet_diag_dump_reqs(struct sk_buff *skb, struct sock *sk,
continue;
if (bc) {
- entry.saddr =
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
- (entry.family == AF_INET6) ?
- inet6_rsk(req)->loc_addr.s6_addr32 :
-#endif
- &ireq->loc_addr;
- entry.daddr =
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
- (entry.family == AF_INET6) ?
- inet6_rsk(req)->rmt_addr.s6_addr32 :
-#endif
- &ireq->rmt_addr;
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ entry.family == AF_INET6) {
+ entry.saddr = inet6_rsk(req)->loc_addr.s6_addr32;
+ entry.daddr = inet6_rsk(req)->rmt_addr.s6_addr32;
+ } else {
+ entry.saddr = &ireq->loc_addr;
+ entry.daddr = &ireq->rmt_addr;
+ }
entry.dport = ntohs(ireq->rmt_port);
if (!inet_diag_bc_run(nla_data(bc),
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index d55110e..06bf1b7 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -728,9 +728,8 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
rt = skb_rtable(skb);
if ((dst = rt->rt_gateway) == 0)
goto tx_error_icmp;
- }
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- else if (skb->protocol == htons(ETH_P_IPV6)) {
+ } else if (IS_ENABLED(CONFIG_IPV6) &&
+ skb->protocol == htons(ETH_P_IPV6)) {
struct neighbour *neigh = dst_get_neighbour(skb_dst(skb));
const struct in6_addr *addr6;
int addr_type;
@@ -750,10 +749,9 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
goto tx_error_icmp;
dst = addr6->s6_addr32[3];
- }
-#endif
- else
+ } else {
goto tx_error;
+ }
}
tos = tiph->tos;
@@ -798,9 +796,8 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
ip_rt_put(rt);
goto tx_error;
}
- }
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- else if (skb->protocol == htons(ETH_P_IPV6)) {
+ } else if (IS_ENABLED(CONFIG_IPV6) &&
+ skb->protocol == htons(ETH_P_IPV6)) {
struct rt6_info *rt6 = (struct rt6_info *)skb_dst(skb);
if (rt6 && mtu < dst_mtu(skb_dst(skb)) && mtu >= IPV6_MIN_MTU) {
@@ -818,7 +815,6 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
goto tx_error;
}
}
-#endif
if (tunnel->err_count > 0) {
if (time_before(jiffies,
@@ -873,10 +869,9 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
if ((iph->ttl = tiph->ttl) == 0) {
if (skb->protocol == htons(ETH_P_IP))
iph->ttl = old_iph->ttl;
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- else if (skb->protocol == htons(ETH_P_IPV6))
+ else if (IS_ENABLED(CONFIG_IPV6) &&
+ skb->protocol == htons(ETH_P_IPV6))
iph->ttl = ((const struct ipv6hdr *)old_iph)->hop_limit;
-#endif
else
iph->ttl = ip4_dst_hoplimit(&rt->dst);
}
diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
index 09ff51b..03f614e 100644
--- a/net/ipv4/ip_sockglue.c
+++ b/net/ipv4/ip_sockglue.c
@@ -515,20 +515,18 @@ static int do_ip_setsockopt(struct sock *sk, int level,
sock_owned_by_user(sk));
if (inet->is_icsk) {
struct inet_connection_sock *icsk = inet_csk(sk);
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- if (sk->sk_family == PF_INET ||
- (!((1 << sk->sk_state) &
+
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ (sk->sk_family == PF_INET ||
+ (!((1 << sk->sk_state) &
(TCPF_LISTEN | TCPF_CLOSE)) &&
- inet->inet_daddr != LOOPBACK4_IPV6)) {
-#endif
+ inet->inet_daddr != LOOPBACK4_IPV6))) {
if (old)
icsk->icsk_ext_hdr_len -= old->opt.optlen;
if (opt)
icsk->icsk_ext_hdr_len += opt->opt.optlen;
icsk->icsk_sync_mss(sk, icsk->icsk_pmtu_cookie);
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
}
-#endif
}
rcu_assign_pointer(inet->inet_opt, opt);
if (old)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 52b5c2d..0635f27 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -2662,9 +2662,8 @@ static void DBGUNDO(struct sock *sk, const char *msg)
tp->snd_cwnd, tcp_left_out(tp),
tp->snd_ssthresh, tp->prior_ssthresh,
tp->packets_out);
- }
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- else if (sk->sk_family == AF_INET6) {
+ } else if (IS_ENABLED(CONFIG_IPV6) &&
+ sk->sk_family == AF_INET6) {
struct ipv6_pinfo *np = inet6_sk(sk);
printk(KERN_DEBUG "Undo %s %pI6/%u c%u l%u ss%u/%u p%u\n",
msg,
@@ -2673,7 +2672,6 @@ static void DBGUNDO(struct sock *sk, const char *msg)
tp->snd_ssthresh, tp->prior_ssthresh,
tp->packets_out);
}
-#endif
}
#else
#define DBGUNDO(x...) do { } while (0)
diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
index 85a2fbe..ca07a0e 100644
--- a/net/ipv4/tcp_minisocks.c
+++ b/net/ipv4/tcp_minisocks.c
@@ -336,8 +336,8 @@ void tcp_time_wait(struct sock *sk, int state, int timeo)
tcptw->tw_ts_recent = tp->rx_opt.ts_recent;
tcptw->tw_ts_recent_stamp = tp->rx_opt.ts_recent_stamp;
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- if (tw->tw_family == PF_INET6) {
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ tw->tw_family == PF_INET6) {
struct ipv6_pinfo *np = inet6_sk(sk);
struct inet6_timewait_sock *tw6;
@@ -347,17 +347,16 @@ void tcp_time_wait(struct sock *sk, int state, int timeo)
ipv6_addr_copy(&tw6->tw_v6_rcv_saddr, &np->rcv_saddr);
tw->tw_ipv6only = np->ipv6only;
}
-#endif
-#ifdef CONFIG_TCP_MD5SIG
- /*
- * The timewait bucket does not have the key DB from the
- * sock structure. We just make a quick copy of the
- * md5 key being used (if indeed we are using one)
- * so the timewait ack generating code has the key.
- */
- do {
+ if (IS_ENABLED(CONFIG_TCP_MD5SIG)) {
+ /*
+ * The timewait bucket does not have the key DB from the
+ * sock structure. We just make a quick copy of the
+ * md5 key being used (if indeed we are using one)
+ * so the timewait ack generating code has the key.
+ */
struct tcp_md5sig_key *key;
+
memset(tcptw->tw_md5_key, 0, sizeof(tcptw->tw_md5_key));
tcptw->tw_md5_keylen = 0;
key = tp->af_specific->md5_lookup(sk, sk);
@@ -367,8 +366,7 @@ void tcp_time_wait(struct sock *sk, int state, int timeo)
if (tcp_alloc_md5sig_pool(sk) == NULL)
BUG();
}
- } while (0);
-#endif
+ }
/* Linkage updates. */
__inet_twsk_hashdance(tw, sk, &tcp_hashinfo);
@@ -402,16 +400,17 @@ void tcp_time_wait(struct sock *sk, int state, int timeo)
void tcp_twsk_destructor(struct sock *sk)
{
-#ifdef CONFIG_TCP_MD5SIG
- struct tcp_timewait_sock *twsk = tcp_twsk(sk);
- if (twsk->tw_md5_keylen)
- tcp_free_md5sig_pool();
-#endif
+ if (IS_ENABLED(CONFIG_TCP_MD5SIG)) {
+ const struct tcp_timewait_sock *twsk = tcp_twsk(sk);
+
+ if (twsk->tw_md5_keylen)
+ tcp_free_md5sig_pool();
+ }
}
EXPORT_SYMBOL_GPL(tcp_twsk_destructor);
static inline void TCP_ECN_openreq_child(struct tcp_sock *tp,
- struct request_sock *req)
+ const struct request_sock *req)
{
tp->ecn_flags = inet_rsk(req)->ecn_ok ? TCP_ECN_OK : 0;
}
@@ -541,11 +540,13 @@ struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req,
newtp->rx_opt.ts_recent_stamp = 0;
newtp->tcp_header_len = sizeof(struct tcphdr);
}
-#ifdef CONFIG_TCP_MD5SIG
- newtp->md5sig_info = NULL; /*XXX*/
- if (newtp->af_specific->md5_lookup(sk, newsk))
- newtp->tcp_header_len += TCPOLEN_MD5SIG_ALIGNED;
-#endif
+
+ if (IS_ENABLED(CONFIG_TCP_MD5SIG)) {
+ newtp->md5sig_info = NULL; /*XXX*/
+ if (newtp->af_specific->md5_lookup(sk, newsk))
+ newtp->tcp_header_len += TCPOLEN_MD5SIG_ALIGNED;
+ }
+
if (skb->len >= TCP_MSS_DEFAULT + newtp->tcp_header_len)
newicsk->icsk_ack.last_seg_size = skb->len - newtp->tcp_header_len;
newtp->rx_opt.mss_clamp = req->mss;
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c
index 2e0f0af..9d8705c 100644
--- a/net/ipv4/tcp_timer.c
+++ b/net/ipv4/tcp_timer.c
@@ -339,15 +339,13 @@ void tcp_retransmit_timer(struct sock *sk)
LIMIT_NETDEBUG(KERN_DEBUG "TCP: Peer %pI4:%u/%u unexpectedly shrunk window %u:%u (repaired)\n",
&inet->inet_daddr, ntohs(inet->inet_dport),
inet->inet_num, tp->snd_una, tp->snd_nxt);
- }
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- else if (sk->sk_family == AF_INET6) {
+ } else if (IS_ENABLED(CONFIG_IPV6) &&
+ sk->sk_family == AF_INET6) {
struct ipv6_pinfo *np = inet6_sk(sk);
LIMIT_NETDEBUG(KERN_DEBUG "TCP: Peer %pI6:%u/%u unexpectedly shrunk window %u:%u (repaired)\n",
&np->daddr, ntohs(inet->inet_dport),
inet->inet_num, tp->snd_una, tp->snd_nxt);
}
-#endif
if (tcp_time_stamp - tp->rcv_tstamp > TCP_RTO_MAX) {
tcp_write_err(sk);
goto out;
diff --git a/net/ipv4/tunnel4.c b/net/ipv4/tunnel4.c
index ac3b3ee..e860b17 100644
--- a/net/ipv4/tunnel4.c
+++ b/net/ipv4/tunnel4.c
@@ -167,22 +167,21 @@ static int __init tunnel4_init(void)
printk(KERN_ERR "tunnel4 init: can't add protocol\n");
return -EAGAIN;
}
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- if (inet_add_protocol(&tunnel64_protocol, IPPROTO_IPV6)) {
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ inet_add_protocol(&tunnel64_protocol, IPPROTO_IPV6)) {
printk(KERN_ERR "tunnel64 init: can't add protocol\n");
inet_del_protocol(&tunnel4_protocol, IPPROTO_IPIP);
return -EAGAIN;
}
-#endif
return 0;
}
static void __exit tunnel4_fini(void)
{
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- if (inet_del_protocol(&tunnel64_protocol, IPPROTO_IPV6))
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ inet_del_protocol(&tunnel64_protocol, IPPROTO_IPV6))
printk(KERN_ERR "tunnel64 close: can't remove protocol\n");
-#endif
+
if (inet_del_protocol(&tunnel4_protocol, IPPROTO_IPIP))
printk(KERN_ERR "tunnel4 close: can't remove protocol\n");
}
diff --git a/net/ipv4/xfrm4_tunnel.c b/net/ipv4/xfrm4_tunnel.c
index 8280645..b6de688 100644
--- a/net/ipv4/xfrm4_tunnel.c
+++ b/net/ipv4/xfrm4_tunnel.c
@@ -84,25 +84,25 @@ static int __init ipip_init(void)
xfrm_unregister_type(&ipip_type, AF_INET);
return -EAGAIN;
}
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- if (xfrm4_tunnel_register(&xfrm64_tunnel_handler, AF_INET6)) {
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ xfrm4_tunnel_register(&xfrm64_tunnel_handler, AF_INET6)) {
printk(KERN_INFO "ipip init: can't add xfrm handler for AF_INET6\n");
xfrm4_tunnel_deregister(&xfrm_tunnel_handler, AF_INET);
xfrm_unregister_type(&ipip_type, AF_INET);
return -EAGAIN;
}
-#endif
return 0;
}
static void __exit ipip_fini(void)
{
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
- if (xfrm4_tunnel_deregister(&xfrm64_tunnel_handler, AF_INET6))
+ if (IS_ENABLED(CONFIG_IPV6) &&
+ xfrm4_tunnel_deregister(&xfrm64_tunnel_handler, AF_INET6))
printk(KERN_INFO "ipip close: can't remove xfrm handler for AF_INET6\n");
-#endif
+
if (xfrm4_tunnel_deregister(&xfrm_tunnel_handler, AF_INET))
printk(KERN_INFO "ipip close: can't remove xfrm handler for AF_INET\n");
+
if (xfrm_unregister_type(&ipip_type, AF_INET) < 0)
printk(KERN_INFO "ipip close: can't remove xfrm type\n");
}
^ permalink raw reply related
* Re: [PATCH V2 2/4] MIPS: Add board support for Loongson1B
From: Giuseppe CAVALLARO @ 2011-10-25 7:09 UTC (permalink / raw)
To: Kelvin Cheung
Cc: Wu Zhangjin, linux-mips, linux-kernel, ralf, r0bertz, netdev
In-Reply-To: <CAJhJPsVu7hahhmUvPQ=s=AqvXGhU-05x=GqQ29Mo6PZ8cTtefA@mail.gmail.com>
On 10/25/2011 4:12 AM, Kelvin Cheung wrote:
> 2011/10/24, Giuseppe CAVALLARO <peppe.cavallaro@st.com>:
>> On 10/24/2011 4:05 PM, Kelvin Cheung wrote:
>>> 2011/10/24, Giuseppe CAVALLARO <peppe.cavallaro@st.com>:
>>>> Hello Kelvin.
>>>>
>>>> On 10/24/2011 12:36 PM, Kelvin Cheung wrote:
>>>>
>>>> [snip]
>>>>
>>>>> According to datasheet of Loongson 1B, the buffer size in RX/TX
>>>>> descriptor is only 2KB. So the Loongson1B's GMAC could not handle
>>>>> jumbo frames. And the second buffer is useless in this case. Am I
>>>>> right? Is there a better way than ifdef CONFIG_MACH_LOONGSON1 to
>>>>> avoid duplicate code?
>>>>
>>>> Sorry for my misunderstanding.
>>>>
>>>> I think you have to use the normal descriptor and remove the enh_desc
>>>> from the platform w/o modifying the driver at all.
>>>>
>>>> The driver will be able to select/configure all automatically (also
>>>> jumbo).
>>>>
>>>> Let me know.
>>>
>>> That's the problem.
>>> The bitfield definition of Loongson1B is also different from normal
>>> descriptor.
>>
>> The problem is not in the Loongson1B gmac.
>
> I found that the bit checksum_insertion is not existed in normal descriptor.
>
>> The normal descriptor fields in the stmmac refer to an old synopsys
>> databook.
>
> Could you send me the new databook of Synopsys GMAC?
>
>> New chips have the same structure you have added; so we should fix this
>> in the driver w/o breaking the compatibility for old chips.
>
> Agree.
>
>> I kindly ask you to confirm if the currently normal descriptor structure
>> (w/o your changes) doesn't work on your platform.
>> Did you test it?
>
> Well, the normal descriptor works on my platform except TX checksum offload.
ok! I suspected that.
>>> Moreover, I want to enable the TX checksum offload function which is
>>> not supported in normal descriptor.
>>> Any suggestions?
>>
>> It is supported but you have to pass from the platform: tx_coe = 1.
>
> I noticed that the flag csum_insertion is passed to
> ndesc_prepare_tx_desc() in stmmac_xmit(). But ndesc_prepare_tx_desc()
> just ignores it.
> In other words, the TX checksum offload function is disabled in normal
> descriptor currently.
>
> Should we fix this problem for normal descriptor?
Yes, we should. If you agree, I'll update the normal descriptor
structure to yours. This is the normal descriptor used in newer GMAC.
Tx csum will be done for normal descriptors in case of these GMAC
devices and not for old MAC10/100. For the MAC10/100 some bits for
normal descriptors are reserved and won't be used at all.
I'll also verify that the patch doesn't break the back-compatibility
with old MAC10/100. I have the HW where doing the tests.
After that, I'll prepare the patch for net-next and for your kernel.
>
>> Peppe
>>>
>>>> Note:
>>>> IIRC, there is a bit difference in case of normal descriptors for
>>>> Synopsys databook newer than the 1.91 (I used for testing this mode).
>>>> In any case, I remember that, on some platforms, the normal descriptors
>>>> have been used w/o problems also on these new chip generations.
>>>>
>>>> Peppe
>>>>
>>>>
>>>
>>>
>>
>>
>
>
^ permalink raw reply
* Re: [RFC PATCH 05/17] phy_driver: Make .read_status()/.config_aneg() optional
From: Mike Frysinger @ 2011-10-25 7:06 UTC (permalink / raw)
To: Kyle Moffett
Cc: Kyle Moffett, linux-kernel, netdev, Randy Dunlap,
Stephen Hemminger, David S. Miller, Greg Dietsche,
Giuseppe Cavallaro, David Daney, Arnaud Patard, Grant Likely,
Baruch Siach, Thorsten Schubert, David Decotigny, Andrew Morton,
Lucas De Marchi, Marc Kleine-Budde, linux-doc
In-Reply-To: <CAGZ=bqJNRCiiT6KvQBkZ5fs6b=RQG92xtmf1cGe1s9mdcbcDFA@mail.gmail.com>
On Fri, Oct 21, 2011 at 01:13, Kyle Moffett wrote:
> On Thu, Oct 20, 2011 at 17:14, Mike Frysinger wrote:
>> On Thursday 20 October 2011 17:10:12 Mike Frysinger wrote:
>>> On Thursday 20 October 2011 17:00:12 Kyle Moffett wrote:
>>> > Approximately 90% of the PHY drivers follow the PHY layer docs and
>>> > simply use &genphy_read_status and &genphy_config_aneg. There would
>>> > seem to be little point in requiring them all to manually specify those
>>> > functions.
>>>
>>> well, it does make sense if you think about the compile vs build time
>>> overhead. yes, your patch does make things much nicer to read, and a
>>> little easier to maintain the source. however, it adds runtime overhead
>>> (checking the func pointers) while the func pointer storage is unchanged
>>> (it's now a NULL pointer instead of pointing to the genphy funcs).
>>> personally, i think the savings in runtime and smaller compiled code is
>>> more important. so i'm going to NAK this. sorry.
>>
>> ah, sorry, i was thinking this was u-boot since we were just having
>> conversations there.
>>
>> since this is Linux, and i don't have real standing in the general netdev
>> community, i can't really NAK here. but i think my comment still stands in
>> that this patch makes things much worse than the minor code style improvement.
>
> I would argue that the PHY layer itself is not remotely a hot-path,
> especially not to the level of caring about an extra if statement. A
> single phy_read() is a sleeping call which goes over a slow serial
> bus, so code maintainability is much more important.
i disagree. ignoring that, what you ultimately desire can be
accomplished without bloating the kernel.
option 1: this can be done in the registration func just like the mtd
layer. if (!func_pointer) func_pointer = default;
option 2: introduce a new macro in the common phy header similar to:
#define PHY_DRIVER_DEFAULT_FUNCS \
.config_aneg = genphy_config_aneg, \
.read_status = genphy_read_status
and then use that in the phy_driver init structs:
struct phy_driver bcm5411_driver = {
PHY_DRIVER_DEFAULT_FUNCS,
.config_aneg = bcm5411_config_aneg,
...
however, imo, these func pointer arrays really should be in the
.rodata section with proper const markers. this would require
breaking out into a new phy_driver_opts struct since the phy_driver
struct has read/write fields (like the list structure). option 2
should allow this to work.
-mike
^ permalink raw reply
* Re: [patch net-next V4] net: introduce ethernet teaming device
From: Jiri Pirko @ 2011-10-25 7:02 UTC (permalink / raw)
To: Michał Mirosław
Cc: netdev, davem, eric.dumazet, bhutchings, shemminger, fubar, andy,
tgraf, ebiederm, kaber, greearb, jesse, fbl, benjamin.poirier,
jzupka
In-Reply-To: <CAHXqBFLzuxaCW-q5X066zM3E_t9KHO1uTF6WD3Je2u0EifaSSw@mail.gmail.com>
Mon, Oct 24, 2011 at 07:22:36PM CEST, mirqus@gmail.com wrote:
>2011/10/24 Jiri Pirko <jpirko@redhat.com>:
>> This patch introduces new network device called team. It supposes to be
>> very fast, simple, userspace-driven alternative to existing bonding
>> driver.
>[...]
>> drivers/net/team/team.c | 1573 +++++++++++++++++++++++++++++
>> drivers/net/team/team_mode_activebackup.c | 152 +++
>> drivers/net/team/team_mode_roundrobin.c | 107 ++
>
>I think this mode-modularity is overkill. One mode will compile to at
>most a few hundred bytes of code+data, but will use at least 10 times
>that to get loaded and tracked properly. How often/how many more modes
>you anticipate to be introduced? You could just keep the modular
>design but drop the kernel module separation and maybe have modes
>conditionally compiled (for those from the embedded world squeezing
>every byte).
~3-4 modes are coming in at least. I presume it would be possible to
squeeze "bacic modes" like roundrobin and activebackup directly into
team.c (or into team_basic_modes.c compiled in team.ko). But I would
leave that to future follow up patch.
>
>Best Regards,
>Michał Mirosław
^ permalink raw reply
* Re: [RFC PATCH 08/17] drivers/net/bfin_mac: Don't unnecessarily reset the PHY
From: Mike Frysinger @ 2011-10-25 6:59 UTC (permalink / raw)
To: Kyle Moffett
Cc: linux-kernel, netdev, David S. Miller, Sonic Zhang,
Tobias Klauser, uclinux-dist-devel
In-Reply-To: <1319144425-15547-9-git-send-email-Kyle.D.Moffett@boeing.com>
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
^ permalink raw reply
* Re: [patch net-next V4] net: introduce ethernet teaming device
From: Jiri Pirko @ 2011-10-25 6:42 UTC (permalink / raw)
To: Andy Gospodarek
Cc: netdev, davem, eric.dumazet, bhutchings, shemminger, fubar, tgraf,
ebiederm, mirqus, kaber, greearb, jesse, fbl, benjamin.poirier,
jzupka
In-Reply-To: <20111025000232.GC20605@gospo.rdu.redhat.com>
Tue, Oct 25, 2011 at 02:02:33AM CEST, andy@greyhouse.net wrote:
>On Mon, Oct 24, 2011 at 10:13:25AM +0200, Jiri Pirko wrote:
>> This patch introduces new network device called team. It supposes to be
>> very fast, simple, userspace-driven alternative to existing bonding
>> driver.
>>
>> Userspace library called libteam with couple of demo apps is available
>> here:
>> https://github.com/jpirko/libteam
>> Note it's still in its dipers atm.
>>
>> team<->libteam use generic netlink for communication. That and rtnl
>> suppose to be the only way to configure team device, no sysfs etc.
>>
>> Python binding basis for libteam was recently introduced (some need
>> still need to be done on it though). Daemon providing arpmon/miimon
>> active-backup functionality will be introduced shortly.
>> All what's necessary is already implemented in kernel team driver.
>>
>> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>>
>> v3->v4:
>> - remove redundant synchronize_rcu from __team_change_mode()
>> - revert "set and clear of mode_ops happens per pointer, not per
>> byte"
>> - extend comment of function __team_change_mode()
>>
>> v2->v3:
>> - team_change_mtu() user rcu version of list traversal to unwind
>> - set and clear of mode_ops happens per pointer, not per byte
>> - port hashlist changed to be embedded into team structure
>> - error branch in team_port_enter() does cleanup now
>> - fixed rtln->rtnl
>>
>> v1->v2:
>> - modes are made as modules. Makes team more modular and
>> extendable.
>> - several commenters' nitpicks found on v1 were fixed
>> - several other bugs were fixed.
>> - note I ignored Eric's comment about roundrobin port selector
>> as Eric's way may be easily implemented as another mode (mode
>> "random") in future.
>
>Jiri,
>
>I've been following this work closely since your first post and now to
>wonder if you could create a 'team' tree somewhere. It would be nice if
>there was a repo that we could clone for testing and a base for others
>to help with the development and provide patches.
>
>It also might avoid so much of this back and forth, so that you are not
>on v37 by the time the code meets everyones needs. :-)
>
>Once the code goes mainline and Dave pulls your tree, you could then
>remove it.
I believe v5 will be the one :)
Jirka
>
>-andy
>
^ permalink raw reply
* Re: [PATCH] net: allow CAP_NET_RAW to setsockopt SO_PRIORITY
From: Maciej Żenczykowski @ 2011-10-25 6:30 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20111025.022546.1784159727449615100.davem@davemloft.net>
> SO_PRIORITY can control prioritizations that are not influenced
> by packet contents.
>
> There is a huge difference.
I do agree that it can do that, but I'm not sure the difference is
huge as you so put it.
In the vast majority of cases prioritization is desired based on some
meaningful aspect
of a packet that can also be observed later on in the network - hence
vlan tags, tos/tclass marks,
protocol, port numbers and the like.
I guess to me, in the real world (or at least the portion of it I'm
aware of), the difference is minor at best.
Being able to select xmit queues, is kind of like being able to select
output device.
You give a CAP_NET_RAW process raw access to the wire - prioritization seems
just one more aspect of this. Especially since this isn't permanently
reconfiguring anything.
Anyway, enough discussion ;-)
Cheers,
Maciej
^ permalink raw reply
* Re: [PATCH] net: allow CAP_NET_RAW to setsockopt SO_PRIORITY
From: David Miller @ 2011-10-25 6:25 UTC (permalink / raw)
To: zenczykowski; +Cc: netdev
In-Reply-To: <CANP3RGfdimCqGL=kdVQdYY0KHqVuVL3CL6arRh3EhdNhyrv9cw@mail.gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Mon, 24 Oct 2011 22:07:20 -0700
> A raw socket can already spew traffic, ie. packets, with any content.
> This includes VLAN tags and IPv4 TOS field, and IPv6 TCLASS field.
> These are the fields used for packet prioritization at switches and in
> the rest of network fabric.
SO_PRIORITY can control prioritizations that are not influenced
by packet contents.
There is a huge difference.
^ permalink raw reply
* linux-next: manual merge of the bluetooth tree with Linus' tree
From: Stephen Rothwell @ 2011-10-25 6:25 UTC (permalink / raw)
To: Gustavo F. Padovan
Cc: linux-next, linux-kernel, Paul Moore, David Miller, netdev,
Andrei Emeltchenko
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
Hi Gustavo,
Today's linux-next merge of the bluetooth tree got a conflict in
net/bluetooth/l2cap_sock.c between commit 6230c9b4f895 ("bluetooth:
Properly clone LSM attributes to newly created child connections") from
Linus' tree and commit 15770b1ab974 ("Bluetooth: convert force_active
variable to flag in l2cap chan") from the bluetooth tree.
I fixed it up (see below) and can carry the fix as necessary.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc net/bluetooth/l2cap_sock.c
index e829236,836d12e..0000000
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@@ -931,12 -944,7 +946,9 @@@ static void l2cap_sock_init(struct soc
chan->max_tx = pchan->max_tx;
chan->tx_win = pchan->tx_win;
chan->sec_level = pchan->sec_level;
- chan->role_switch = pchan->role_switch;
- chan->force_reliable = pchan->force_reliable;
- chan->flushable = pchan->flushable;
- chan->force_active = pchan->force_active;
+ chan->flags = pchan->flags;
+
+ security_sk_clone(parent, sk);
} else {
switch (sk->sk_type) {
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [RFC PATCH 06/17] phy_driver: Add and use phy_driver_[un]register_multiple()
From: Mike Frysinger @ 2011-10-25 5:41 UTC (permalink / raw)
To: Grant Likely
Cc: Kyle Moffett, linux-kernel, netdev, David S. Miller,
Greg Dietsche, Giuseppe Cavallaro, David Daney, Arnaud Patard,
Baruch Siach, Stephen Hemminger, Lucas De Marchi,
Marc Kleine-Budde, Andrew Morton
In-Reply-To: <20111025050003.GC798@ponder.secretlab.ca>
On Tue, Oct 25, 2011 at 01:00, Grant Likely wrote:
> On Thu, Oct 20, 2011 at 05:15:54PM -0400, Mike Frysinger wrote:
>> On Thursday 20 October 2011 17:00:13 Kyle Moffett wrote:
>> > + return phy_driver_register_multiple(bcm63xx_drivers,
>> > + ARRAY_SIZE(bcm63xx_drivers));
>>
>> if only the arm ARRAY_AND_SIZE() macro could gain traction in the wider tree:
>> return phy_driver_register_multiple(ARRAY_AND_SIZE(bcm63xx_drivers));
>
> Propose a patch to move it from arch/arm to include/linux/kernel.h.
> This is the first I've heard of this macro, but I would probably use
> it.
i thought last time rmk suggested it, things got shot down. but maybe
i remember wrong ... it has been a while since i proposed something
that generated bike shedding, so i'll try again.
-mike
^ permalink raw reply
* Re: [PATCH] net: allow CAP_NET_RAW to setsockopt SO_PRIORITY
From: Maciej Żenczykowski @ 2011-10-25 5:07 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20111025.005819.456617923859129015.davem@davemloft.net>
> SO_PRIORITY influences the packet scheduler and internal
> queueing policies, not just the packet contents that hit
> the wire.
>
> Thus CAP_NET_ADMIN is the appropriate capability check.
I can certainly see why you would think that, but:
A raw socket can already spew traffic, ie. packets, with any content.
This includes VLAN tags and IPv4 TOS field, and IPv6 TCLASS field.
These are the fields used for packet prioritization at switches and in
the rest of network fabric.
AFAICT, it makes no sense to allow a raw socket to prioritize traffic
outside of the host, but
not allow it to prioritize traffic in the host.
- Maciej
^ permalink raw reply
* [PATCH] net: make bonding slaves honour master's skb->priority
From: Maciej Żenczykowski @ 2011-10-25 5:04 UTC (permalink / raw)
To: Maciej Żenczykowski; +Cc: netdev, Maciej Żenczykowski
In-Reply-To: <1319517660-22085-1-git-send-email-zenczykowski@gmail.com>
From: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
drivers/net/bonding/bond_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 41430ba..2cbc2f8 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb,
struct net_device *slave_dev)
{
skb->dev = slave_dev;
- skb->priority = 1;
skb->queue_mapping = bond_queue_mapping(skb);
--
1.7.3.1
^ permalink raw reply related
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
From: Maciej Żenczykowski @ 2011-10-25 5:02 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20111025.005859.101223081342927863.davem@davemloft.net>
These are Gerrit (code review system) commit headers, normally I drop
them, I missed that here (they get added automatically by git hooks).
I'll send it again.
Sorry.
- Maciej
^ permalink raw reply
* Re: [RFC PATCH 06/17] phy_driver: Add and use phy_driver_[un]register_multiple()
From: Grant Likely @ 2011-10-25 5:00 UTC (permalink / raw)
To: Mike Frysinger
Cc: Kyle Moffett, linux-kernel, netdev, David S. Miller,
Greg Dietsche, Giuseppe Cavallaro, David Daney, Arnaud Patard,
Baruch Siach, Stephen Hemminger, Lucas De Marchi,
Marc Kleine-Budde, Andrew Morton
In-Reply-To: <201110201715.58441.vapier@gentoo.org>
On Thu, Oct 20, 2011 at 05:15:54PM -0400, Mike Frysinger wrote:
> On Thursday 20 October 2011 17:00:13 Kyle Moffett wrote:
> > + return phy_driver_register_multiple(bcm63xx_drivers,
> > + ARRAY_SIZE(bcm63xx_drivers));
>
> if only the arm ARRAY_AND_SIZE() macro could gain traction in the wider tree:
> return phy_driver_register_multiple(ARRAY_AND_SIZE(bcm63xx_drivers));
Propose a patch to move it from arch/arm to include/linux/kernel.h.
This is the first I've heard of this macro, but I would probably use
it.
> ignoring that, this patch looks cool
>
> Acked-by: Mike Frysinger <vapier@gentoo.org>
Indeed, I like the diffstat. :-)
Acked-by: Grant Likely <grant.likely@secretlab.ca>
^ permalink raw reply
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
From: David Miller @ 2011-10-25 4:58 UTC (permalink / raw)
To: zenczykowski; +Cc: maze, netdev
In-Reply-To: <1319517660-22085-1-git-send-email-zenczykowski@gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Mon, 24 Oct 2011 21:41:00 -0700
> From: Maciej Żenczykowski <maze@google.com>
>
> Change-Id: Ieea6ff9aacacb1eb8c52308c8bfe091acbfc09b2
What are these Change-Id tags? Please don't put these in
your commit message.
I'm dropping this patch, you'll need to resubmit it without
this thing.
^ permalink raw reply
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
From: Jay Vosburgh @ 2011-10-25 4:58 UTC (permalink / raw)
To: Maciej Żenczykowski; +Cc: Maciej Żenczykowski, netdev
In-Reply-To: <1319517660-22085-1-git-send-email-zenczykowski@gmail.com>
Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
>From: Maciej Żenczykowski <maze@google.com>
>
>Change-Id: Ieea6ff9aacacb1eb8c52308c8bfe091acbfc09b2
The code change itself is ok, but I'm not sure what this
Change-Id is. With a regular log message, this should be fine to apply.
-J
>Signed-off-by: Maciej Żenczykowski <maze@google.com>
>---
> drivers/net/bonding/bond_main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 41430ba..2cbc2f8 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb,
> struct net_device *slave_dev)
> {
> skb->dev = slave_dev;
>- skb->priority = 1;
>
> skb->queue_mapping = bond_queue_mapping(skb);
>
>--
>1.7.3.1
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox