Netdev List
 help / color / mirror / Atom feed
* [PATCH 1/2] net: Remove unused neighbour layer ops.
From: David Miller @ 2011-12-13 22:38 UTC (permalink / raw)
  To: netdev


It's simpler to just keep these things out until there is a real user
of them, so we can see what the needs actually are, rather than keep
these things around as useless overhead.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/linux/netdevice.h |    1 -
 include/net/neighbour.h   |    1 -
 net/core/neighbour.c      |   10 ----------
 3 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 6037308..6b9d4ed 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -974,7 +974,6 @@ struct net_device_ops {
 	int			(*ndo_set_features)(struct net_device *dev,
 						    netdev_features_t features);
 	int			(*ndo_neigh_construct)(struct neighbour *n);
-	void			(*ndo_neigh_destroy)(struct neighbour *n);
 };
 
 /*
diff --git a/include/net/neighbour.h b/include/net/neighbour.h
index e31f0a8..6814c4d 100644
--- a/include/net/neighbour.h
+++ b/include/net/neighbour.h
@@ -43,7 +43,6 @@ struct neigh_parms {
 #endif
 	struct net_device *dev;
 	struct neigh_parms *next;
-	int	(*neigh_setup)(struct neighbour *);
 	void	(*neigh_cleanup)(struct neighbour *);
 	struct neigh_table *tbl;
 
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 4af151e..d57a40a 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -497,13 +497,6 @@ struct neighbour *neigh_create(struct neigh_table *tbl, const void *pkey,
 		}
 	}
 
-	/* Device specific setup. */
-	if (n->parms->neigh_setup &&
-	    (error = n->parms->neigh_setup(n)) < 0) {
-		rc = ERR_PTR(error);
-		goto out_neigh_release;
-	}
-
 	n->confirmed = jiffies - (n->parms->base_reachable_time << 1);
 
 	write_lock_bh(&tbl->lock);
@@ -717,9 +710,6 @@ void neigh_destroy(struct neighbour *neigh)
 	skb_queue_purge(&neigh->arp_queue);
 	neigh->arp_queue_len_bytes = 0;
 
-	if (dev->netdev_ops->ndo_neigh_destroy)
-		dev->netdev_ops->ndo_neigh_destroy(neigh);
-
 	dev_put(dev);
 	neigh_parms_put(neigh->parms);
 
-- 
1.7.7.4

^ permalink raw reply related

* [PATCH] ipv6: Check dest prefix length on original route not copied one in rt6_alloc_cow().
From: David Miller @ 2011-12-13 22:35 UTC (permalink / raw)
  To: netdev; +Cc: zheng.z.yan


After commit 8e2ec639173f325977818c45011ee176ef2b11f6 ("ipv6: don't
use inetpeer to store metrics for routes.") the test in rt6_alloc_cow()
for setting the ANYCAST flag is now wrong.

'rt' will always now have a plen of 128, because it is set explicitly
to 128 by ip6_rt_copy.

So to restore the semantics of the test, check the destination prefix
length of 'ort'.

Signed-off-by: David S. Miller <davem@davemloft.net>
---

Committed to 'net'.

 net/ipv6/route.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 3399dd3..b582a0a 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -728,7 +728,7 @@ static struct rt6_info *rt6_alloc_cow(const struct rt6_info *ort,
 		int attempts = !in_softirq();
 
 		if (!(rt->rt6i_flags&RTF_GATEWAY)) {
-			if (rt->rt6i_dst.plen != 128 &&
+			if (ort->rt6i_dst.plen != 128 &&
 			    ipv6_addr_equal(&ort->rt6i_dst.addr, daddr))
 				rt->rt6i_flags |= RTF_ANYCAST;
 			ipv6_addr_copy(&rt->rt6i_gateway, daddr);
-- 
1.7.7.4

^ permalink raw reply related

* Re: [PATCH RESEND] sctp: fix incorrect overflow check on autoclose
From: Vladislav Yasevich @ 2011-12-13 22:15 UTC (permalink / raw)
  To: Xi Wang
  Cc: netdev, linux-sctp, Andrew Morton, Andrei Pelinescu-Onciul,
	David S. Miller
In-Reply-To: <702540E4-9FD3-4B71-B53A-FE5D4323A898@gmail.com>

On 12/13/2011 05:00 PM, Xi Wang wrote:
> On Dec 12, 2011, at 5:18 PM, Vladislav Yasevich wrote:
>> Hm..  this is a bit strange.  This makes it so that on 32 bit platforms
>> we have one upper bound for autoclose and on 64 we have another even though
>> the type is platform dependent.  This could be considered a regression by
>> applications.
> 
> Either looks good to me.  Timeout limit is essentially different on 32/64
> platforms.

I don't think it really should be different.  Notice that our rto values
remain consistent.  I really thing that this should be consistent from
the user's point of view.

> 
> Another (probably uglier) option is to limit the value on 32-bit platform
> only, like sock_setsockopt() in net/core/sock.c.
> 
> #if (BITS_PER_LONG == 32)
> 	if (sp->autoclose > MAX_SCHEDULE_TIMEOUT / HZ)
> 		sp->autoclose = MAX_SCHEDULE_TIMEOUT / HZ;
> #endif

I agree, this is ugly.  It might make more sense to define a max autoclose
value and expose it through /sys.  That way the values remains consistent.

-vlad

> 
>> In addition this would result in confusion to user since the values
>> between setsockopt() and getsockopt() for autoclose would be different.
> 
> Are you suggesting to reject the value and return -EINVAL, rather than
> silently limiting the autoclose value?
> 
> - xi
> 

^ permalink raw reply

* Re: iwlagn regression in v3.1.5
From: Udo Steinberg @ 2011-12-13 22:04 UTC (permalink / raw)
  To: Andrej Gelenberg
  Cc: wwguy, Intel Linux Wireless, John W. Linville,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
In-Reply-To: <4EE7BEC1.1060506@udo.edu>

Hi,

Glad to hear it works for you now. In the patch, the following piece of code

+				if ((iwl_is_associated_ctx(ctx) &&
+						!ctx->ht.is_40mhz) ||
+						!iwl_is_associated_ctx(ctx))

can be simplified to:

	if (!iwl_is_associated_ctx(ctx) || !ctx->ht.is_40mhz)

Cheers,

	- Udo

On Tue, 13 Dec 2011 22:08:17 +0100 Andrej Gelenberg (AG) wrote:

AG> Hi,
AG> 
AG> work now for me.
AG> 
AG> Regards,
AG> Andrej Gelenberg
AG> 
AG> On 12/13/2011 09:15 PM, wwguy wrote:
AG> > Hi Andrej,
AG> >
AG> > Could you try this patch and see any differences.
AG> >
AG> > please still use the same debug flag I ask you last time.
AG> >
AG> > Thanks
AG> > Wey

^ permalink raw reply

* Re: [PATCH RESEND] sctp: fix incorrect overflow check on autoclose
From: Xi Wang @ 2011-12-13 22:00 UTC (permalink / raw)
  To: Vladislav Yasevich
  Cc: netdev, linux-sctp, Andrew Morton, Andrei Pelinescu-Onciul,
	David S. Miller
In-Reply-To: <4EE67DC6.3000500@hp.com>

On Dec 12, 2011, at 5:18 PM, Vladislav Yasevich wrote:
> Hm..  this is a bit strange.  This makes it so that on 32 bit platforms
> we have one upper bound for autoclose and on 64 we have another even though
> the type is platform dependent.  This could be considered a regression by
> applications.

Either looks good to me.  Timeout limit is essentially different on 32/64
platforms.

Another (probably uglier) option is to limit the value on 32-bit platform
only, like sock_setsockopt() in net/core/sock.c.

#if (BITS_PER_LONG == 32)
	if (sp->autoclose > MAX_SCHEDULE_TIMEOUT / HZ)
		sp->autoclose = MAX_SCHEDULE_TIMEOUT / HZ;
#endif

> In addition this would result in confusion to user since the values
> between setsockopt() and getsockopt() for autoclose would be different.

Are you suggesting to reject the value and return -EINVAL, rather than
silently limiting the autoclose value?

- xi

^ permalink raw reply

* Re: [PATCH] net: do not pass vlan pkts to real dev pkt handler also
From: Jiri Pirko @ 2011-12-13 21:45 UTC (permalink / raw)
  To: Vasu Dev; +Cc: Vasu Dev, netdev, devel, eric.dumazet
In-Reply-To: <1323796263.8333.20.camel@vi>

Tue, Dec 13, 2011 at 06:11:03PM CET, vasu.dev@linux.intel.com wrote:
>On Tue, 2011-12-13 at 15:21 +0100, Jiri Pirko wrote:
>> Tue, Dec 13, 2011 at 02:08:52AM CET, vasu.dev@linux.intel.com wrote:
>> >On Mon, 2011-12-12 at 23:56 +0100, Jiri Pirko wrote: 
>> >> Mon, Dec 12, 2011 at 11:19:23PM CET, vasu.dev@intel.com wrote:
>> >> >The orig_dev has to be updated before going another round
>> >> >for vlan pkts, otherwise currently unmodified real orig_dev
>> >> >causes vlan pkt delivered to real orig_dev also.
>> >> >
>> >> >The fcoe stack doesn't expects its vlan pkts on real dev
>> >> >and it causes crash in fcoe stack.
>> >> 
>> >> Could you please provide more info on where exactly it would crash and
>> >> why?
>> >
>> >Its in fcoe stack due to its fip rx skb list getting corrupt as same skb
>> >instance getting queued twice without being cloned, though list was well
>> >protected by its spin lock, it was queued on its two fcoe instances, one
>> >on real dev and other on its vlan.
>> >
>> >I could also handle this gracefully in fcoe stack by cloning but any
>> >case netdev should not forward vlan pkt to its read dev pkt handler also
>> >and that is getting fixed with this patch, so patch will restore
>> >orig_dev uses for *only* vlan pkts as it was with recursive
>> >__netif_receive_skb calling prior to commit 0dfe178.
>> 
>> 
>> I do not see into fcoe code, but wouldn't it be good to do skb
>> skb_share_check in fcoe_ctlr_recv? I suppose that would solve your
>> problem and looks legal to me.
>> 
>
>Yes that will fix along with dropping vlan pkts on real dev, so some
>additional checking for dropping also. In fact that is what I meant in
>my last response by "I could also handle this gracefully in fcoe stack
>by cloning" as skb_share_check() does that conditionally.  
>
>But as far as this patch goes, are you okay with the fix to not forward
>vlan pkt on real dev pkt handler ? I think this is required regardless
>of fcoe stack fixing for shared skb since otherwise all upper layers of
>real dev pkt handler has to handle with un-expected vlan pkts also.

I think that's what orig_dev is destined for. To provide a possiblility
to do this. I would like to leave that as it is.

>
>Thanks for your review.
>Vasu
>
>
>> 
>> >
>> >Here is the detailed crash log:
>> >
>> >[  340.679591] BUG: unable to handle kernel NULL pointer dereference at
>> >0000000000000008
>> >[  340.680112] IP: [<ffffffff815088a5>] skb_dequeue+0x55/0x90
>> >[  340.680112] PGD 0
>> >[  340.680112] Oops: 0002 [#1] SMP
>> >[  340.680112] CPU 3
>> >[  340.680112] Modules linked in: fcoe libfcoe libfc scsi_transport_fc
>> >8021q e1000 virtio_balloon ixgbe mdio virtio_blk virtio_pci virtio_ring
>> >virtio [last unloaded: scsi_wait_scan]
>> >[  340.680112]
>> >[  340.680112] Pid: 442, comm: kworker/3:1 Not tainted 3.2.0-rc4+ #53
>> >Bochs Bochs
>> >[  340.680112] RIP: 0010:[<ffffffff815088a5>]  [<ffffffff815088a5>]
>> >skb_dequeue+0x55/0x90
>> >[  340.680112] RSP: 0018:ffff88007c963c80  EFLAGS: 00010097
>> >[  340.680112] RAX: 0000000000000282 RBX: ffff88007baee9b4 RCX:
>> >0000000000000000
>> >[  340.680112] RDX: 0000000000000000 RSI: 0000000000000286 RDI:
>> >ffff88007baee9b4
>> >[  340.680112] RBP: ffff88007c963ca0 R08: ffff88007c35ddc0 R09:
>> >0000000000000001
>> >[  340.680112] R10: 0000000000000006 R11: 0000000000000001 R12:
>> >ffff88007bedca00
>> >[  340.680112] R13: ffff88007baee9a0 R14: ffff88007c963d80 R15:
>> >ffff88007baeea00
>> >[  340.680112] FS:  0000000000000000(0000) GS:ffff88007fd80000(0000)
>> >knlGS:0000000000000000
>> >[  340.680112] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
>> >[  340.680112] CR2: 0000000000000008 CR3: 0000000001c05000 CR4:
>> >00000000000006e0
>> >[  340.680112] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>> >0000000000000000
>> >[  340.680112] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7:
>> >0000000000000400
>> >[  340.680112] Process kworker/3:1 (pid: 442, threadinfo
>> >ffff88007c962000, task ffff88007c9f60b0)
>> >[  340.680112] Stack:
>> >[  340.680112]  ffff88007baee9a0 ffff88007baee8c0 ffff88007baee9a0
>> >ffff88007bedca00
>> >[  340.680112]  ffff88007c963df0 ffffffffa00af7a7 ffff88007baad4d4
>> >ffffffff81060dee
>> >[  340.680112]  0000000000000001 ffff88007c35ddc0 ffff88007c963fd8
>> >0000000000000000
>> >[  340.680112] Call Trace:
>> >[  340.680112]  [<ffffffffa00af7a7>] fcoe_ctlr_recv_work+0x147/0x1870
>> >[libfcoe]
>> >[  340.680112]  [<ffffffff81060dee>] ? queue_delayed_work_on+0x9e/0x170
>> >[  340.680112]  [<ffffffffa00af660>] ? fcoe_ctlr_vn_recv+0x9a0/0x9a0
>> >[libfcoe]
>> >[  340.680112]  [<ffffffff810612de>] process_one_work+0x11e/0x460
>> >[  340.680112]  [<ffffffff81063af8>] worker_thread+0x178/0x400
>> >[  340.680112]  [<ffffffff81063980>] ? manage_workers+0x210/0x210
>> >[  340.680112]  [<ffffffff81068576>] kthread+0x96/0xa0
>> >[  340.680112]  [<ffffffff81663c74>] kernel_thread_helper+0x4/0x10
>> >[  340.680112]  [<ffffffff810684e0>] ? kthread_worker_fn+0x1a0/0x1a0
>> >[  340.680112]  [<ffffffff81663c70>] ? gs_change+0xb/0xb
>> >[  340.680112] Code: 65 00 4d 39 e5 74 4f 4d 85 e4 74 26 41 83 6d 10 01
>> >49 8b 0c 24 49 8b 54 24 08 49 c7 04 24 00 00 00 00 49 c7 44 24 08 00 00
>> >00 00
>> >[  340.680112]  89 51 08 48 89 0a 48 89 c6 48 89 df e8 39 1b 15 00 4c 89
>> >e0
>> >[  340.680112] RIP  [<ffffffff815088a5>] skb_dequeue+0x55/0x90
>> >[  340.680112]  RSP <ffff88007c963c80>
>> >[  340.680112] CR2: 0000000000000008
>> >
>> >
>> >
>> >Thanks
>> >Vasu
>> >
>> >> 
>> >> Thanks.
>> >> 
>> >> Jirka
>> >> 
>> >> >
>> >> >This wasn't issue untill __netif_receive_skb recursive calling
>> >> >was removed with this commit 0dfe178, so this patch restores
>> >> >orig_dev uses as it was prior to that commit but still w/o
>> >> >recursive calling to __netif_receive_skb.
>> >> >
>> >> >Signed-off-by: Vasu Dev <vasu.dev@intel.com>
>> >> >---
>> >> >
>> >> > net/core/dev.c |    5 +++--
>> >> > 1 files changed, 3 insertions(+), 2 deletions(-)
>> >> >
>> >> >diff --git a/net/core/dev.c b/net/core/dev.c
>> >> >index f494675..adbcd7a 100644
>> >> >--- a/net/core/dev.c
>> >> >+++ b/net/core/dev.c
>> >> >@@ -3222,9 +3222,10 @@ ncls:
>> >> > 			ret = deliver_skb(skb, pt_prev, orig_dev);
>> >> > 			pt_prev = NULL;
>> >> > 		}
>> >> >-		if (vlan_do_receive(&skb, !rx_handler))
>> >> >+		if (vlan_do_receive(&skb, !rx_handler)) {
>> >> >+			orig_dev = skb->dev;
>> >> > 			goto another_round;
>> >> >-		else if (unlikely(!skb))
>> >> >+		} else if (unlikely(!skb))
>> >> > 			goto out;
>> >> > 	}
>> >> > 
>> >> >
>> >> --
>> >> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> >> the body of a message to majordomo@vger.kernel.org
>> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> >
>> >
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

^ permalink raw reply

* [PATCH net-next] rtnetlink: rtnl_link_register() sanity test
From: Eric Dumazet @ 2011-12-13 21:38 UTC (permalink / raw)
  To: David Miller; +Cc: alex.bluesman.smirnov, netdev
In-Reply-To: <20111213.160810.785264274549847462.davem@davemloft.net>

Before adding a struct rtnl_link_ops into link_ops list, check it doesnt
clash with a prior one.

Based on a previous patch from Alexander Smirnov

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
---
 net/core/rtnetlink.c |   25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 9083e82..dbf2dda 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -273,6 +273,17 @@ EXPORT_SYMBOL_GPL(rtnl_unregister_all);
 
 static LIST_HEAD(link_ops);
 
+static const struct rtnl_link_ops *rtnl_link_ops_get(const char *kind)
+{
+	const struct rtnl_link_ops *ops;
+
+	list_for_each_entry(ops, &link_ops, list) {
+		if (!strcmp(ops->kind, kind))
+			return ops;
+	}
+	return NULL;
+}
+
 /**
  * __rtnl_link_register - Register rtnl_link_ops with rtnetlink.
  * @ops: struct rtnl_link_ops * to register
@@ -285,6 +296,9 @@ static LIST_HEAD(link_ops);
  */
 int __rtnl_link_register(struct rtnl_link_ops *ops)
 {
+	if (rtnl_link_ops_get(ops->kind))
+		return -EEXIST;
+
 	if (!ops->dellink)
 		ops->dellink = unregister_netdevice_queue;
 
@@ -351,17 +365,6 @@ void rtnl_link_unregister(struct rtnl_link_ops *ops)
 }
 EXPORT_SYMBOL_GPL(rtnl_link_unregister);
 
-static const struct rtnl_link_ops *rtnl_link_ops_get(const char *kind)
-{
-	const struct rtnl_link_ops *ops;
-
-	list_for_each_entry(ops, &link_ops, list) {
-		if (!strcmp(ops->kind, kind))
-			return ops;
-	}
-	return NULL;
-}
-
 static size_t rtnl_link_get_size(const struct net_device *dev)
 {
 	const struct rtnl_link_ops *ops = dev->rtnl_link_ops;

^ permalink raw reply related

* Re: bayom_epp patch
From: David Miller @ 2011-12-13 21:11 UTC (permalink / raw)
  To: sailer; +Cc: netdev
In-Reply-To: <1323802208.12740.5.camel@xbox360.hq.axsem.com>

From: Thomas Sailer <sailer@sailer.dynip.lugs.ch>
Date: Tue, 13 Dec 2011 19:50:08 +0100

> baycom_epp: Improve parport handling, fix multi-core support

This is a really sloppily coded patch, there is tons of
trailing whitespace and damaged initial tabs mixed with
space characters:

+ git apply --check --whitespace=error-all diff
diff:428: space before tab in indent.
 	spin_unlock_bh(&bc->lock);
diff:436: trailing whitespace.
	
diff:439: trailing whitespace.
		
diff:487: trailing whitespace.
	/* prepare EPP mode; we aren't using interrupts */		
diff:539: trailing whitespace.
	spin_unlock_bh(&bc->lock);	
diff:779: trailing whitespace.
		
Please fix this up and freshly resubmit.

^ permalink raw reply

* Re: [PATCH] rtnetlink: rtnl_link_register always returns zero
From: David Miller @ 2011-12-13 21:08 UTC (permalink / raw)
  To: alex.bluesman.smirnov; +Cc: netdev
In-Reply-To: <1323808281-9967-1-git-send-email-alex.bluesman.smirnov@gmail.com>

From: alex.bluesman.smirnov@gmail.com
Date: Wed, 14 Dec 2011 00:31:21 +0400

> From: Alexander Smirnov <alexander@Lenovo.(none)>
> 
> Both functions 'rtnl_link_register' and '__rtnl_link_register' always
> return zero. So handling return status has no sense in several drivers.
> 
> Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>

This is never acceptable.

As long as those routines do return a value we SHOULD NOT ignore
it.

If you ignore it, then if we do have to start returning an error
then all of these call sites have to be reverted back, which is
a waste of time.

^ permalink raw reply

* Re: iwlagn regression in v3.1.5
From: Andrej Gelenberg @ 2011-12-13 21:08 UTC (permalink / raw)
  To: wwguy
  Cc: Udo Steinberg, Intel Linux Wireless, John W. Linville,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
In-Reply-To: <1323807327.7144.6.camel@wwguy-ubuntu>

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

Hi,

work now for me.

Regards,
Andrej Gelenberg

On 12/13/2011 09:15 PM, wwguy wrote:
> Hi Andrej,
>
> Could you try this patch and see any differences.
>
> please still use the same debug flag I ask you last time.
>
> Thanks
> Wey

[-- Attachment #2: messages --]
[-- Type: text/plain, Size: 53423 bytes --]

2011-12-13T21:51:25.066903+01:00 localhost kernel: [  370.655241] Intel(R) Wireless WiFi Link AGN driver for Linux, in-tree:d
2011-12-13T21:51:25.066924+01:00 localhost kernel: [  370.655245] Copyright(c) 2003-2011 Intel Corporation
2011-12-13T21:51:25.066927+01:00 localhost kernel: [  370.655302] iwlwifi 0000:03:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17
2011-12-13T21:51:25.066932+01:00 localhost kernel: [  370.655350] iwlwifi 0000:03:00.0: pci_resource_len = 0x00002000
2011-12-13T21:51:25.066941+01:00 localhost kernel: [  370.655353] iwlwifi 0000:03:00.0: pci_resource_base = ffffc900100a4000
2011-12-13T21:51:25.066945+01:00 localhost kernel: [  370.655355] iwlwifi 0000:03:00.0: HW Revision ID = 0x35
2011-12-13T21:51:25.066949+01:00 localhost kernel: [  370.655466] iwlwifi 0000:03:00.0: Detected Intel(R) Centrino(R) Ultimate-N 6300 AGN, REV=0x74
2011-12-13T21:51:25.066952+01:00 localhost kernel: [  370.655529] iwlwifi 0000:03:00.0: L1 Disabled; Enabling L0S
2011-12-13T21:51:25.083607+01:00 localhost kernel: [  370.671643] iwlwifi 0000:03:00.0: device EEPROM VER=0x436, CALIB=0x6
2011-12-13T21:51:25.083619+01:00 localhost kernel: [  370.671647] iwlwifi 0000:03:00.0: Device SKU: 0X1f0
2011-12-13T21:51:25.083620+01:00 localhost kernel: [  370.671649] iwlwifi 0000:03:00.0: Valid Tx ant: 0X7, Valid Rx ant: 0X7
2011-12-13T21:51:25.083622+01:00 localhost kernel: [  370.671654] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:25.083623+01:00 localhost kernel: [  370.671671] iwlwifi 0000:03:00.0: Tunable channels: 13 802.11bg, 24 802.11a channels
2011-12-13T21:51:25.083624+01:00 localhost kernel: [  370.671904] iwlwifi 0000:03:00.0: loaded firmware version 9.221.4.1 build 25532
2011-12-13T21:51:33.711523+01:00 localhost kernel: [  379.273463] iwlwifi 0000:03:00.0: U iwlagn_mac_start enter
2011-12-13T21:51:33.711542+01:00 localhost kernel: [  379.273468] iwlwifi 0000:03:00.0: U iwl_prep_station Add STA to driver ID 15: ff:ff:ff:ff:ff:ff
2011-12-13T21:51:33.711544+01:00 localhost kernel: [  379.273503] iwlwifi 0000:03:00.0: L1 Disabled; Enabling L0S
2011-12-13T21:51:33.711545+01:00 localhost kernel: [  379.280382] iwlwifi 0000:03:00.0: Radio type=0x0-0x3-0x1
2011-12-13T21:51:33.956780+01:00 localhost kernel: [  379.518120] iwlwifi 0000:03:00.0: L1 Disabled; Enabling L0S
2011-12-13T21:51:33.956812+01:00 localhost kernel: [  379.525051] iwlwifi 0000:03:00.0: Radio type=0x0-0x3-0x1
2011-12-13T21:51:34.026973+01:00 localhost kernel: [  379.593832] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.026995+01:00 localhost kernel: [  379.593841] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:34.027009+01:00 localhost kernel: [  379.593862] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x1
2011-12-13T21:51:34.027012+01:00 localhost kernel: [  379.593866] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T21:51:34.027014+01:00 localhost kernel: [  379.593871] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000000
2011-12-13T21:51:34.027016+01:00 localhost kernel: [  379.593918] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:34.027018+01:00 localhost kernel: [  379.593923] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0xff
2011-12-13T21:51:34.027021+01:00 localhost kernel: [  379.593928] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x0f
2011-12-13T21:51:34.027023+01:00 localhost kernel: [  379.593933] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:00:00:00:00:00
2011-12-13T21:51:34.027026+01:00 localhost kernel: [  379.593939] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T21:51:34.027028+01:00 localhost kernel: [  379.593945] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T21:51:34.030248+01:00 localhost kernel: [  379.596694] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:34.030260+01:00 localhost kernel: [  379.596701] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:34.057128+01:00 localhost kernel: [  379.623045] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:34.057149+01:00 localhost kernel: [  379.623351] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.057152+01:00 localhost kernel: [  379.623360] iwlwifi 0000:03:00.0: U iwlagn_mac_start leave
2011-12-13T21:51:34.057155+01:00 localhost kernel: [  379.623369] iwlwifi 0000:03:00.0: U iwlagn_mac_add_interface enter: type 2, addr 00:24:d7:4b:77:98
2011-12-13T21:51:34.057158+01:00 localhost kernel: [  379.623409] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.057160+01:00 localhost kernel: [  379.623414] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:34.057172+01:00 localhost kernel: [  379.623434] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x1
2011-12-13T21:51:34.057175+01:00 localhost kernel: [  379.623438] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T21:51:34.057177+01:00 localhost kernel: [  379.623442] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000004
2011-12-13T21:51:34.057179+01:00 localhost kernel: [  379.623446] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:34.057181+01:00 localhost kernel: [  379.623449] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0xff
2011-12-13T21:51:34.057184+01:00 localhost kernel: [  379.623453] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x0f
2011-12-13T21:51:34.057188+01:00 localhost kernel: [  379.623457] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T21:51:34.057204+01:00 localhost kernel: [  379.623461] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T21:51:34.057211+01:00 localhost kernel: [  379.623465] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T21:51:34.057215+01:00 localhost kernel: [  379.623727] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:34.057218+01:00 localhost kernel: [  379.623733] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:34.057220+01:00 localhost kernel: [  379.623835] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:34.057223+01:00 localhost kernel: [  379.623933] iwlwifi 0000:03:00.0: U iwlagn_mac_add_interface leave
2011-12-13T21:51:34.057225+01:00 localhost kernel: [  379.623940] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.057228+01:00 localhost kernel: [  379.623951] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.057230+01:00 localhost kernel: [  379.623956] iwlwifi 0000:03:00.0: U iwlagn_mac_flush enter
2011-12-13T21:51:34.057232+01:00 localhost kernel: [  379.623959] iwlwifi 0000:03:00.0: U iwlagn_mac_flush wait transmit/flush all frames
2011-12-13T21:51:34.057234+01:00 localhost kernel: [  379.623963] iwlwifi 0000:03:00.0: U iwlagn_mac_flush leave
2011-12-13T21:51:34.057237+01:00 localhost kernel: [  379.623968] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0xffffffff
2011-12-13T21:51:34.057239+01:00 localhost kernel: [  379.623972] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.057241+01:00 localhost kernel: [  379.624029] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.057243+01:00 localhost kernel: [  379.624035] iwlwifi 0000:03:00.0: U iwlagn_mac_config TX Power old=15 new=15
2011-12-13T21:51:34.057246+01:00 localhost kernel: [  379.624040] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:34.057258+01:00 localhost kernel: [  379.624060] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x1
2011-12-13T21:51:34.057260+01:00 localhost kernel: [  379.624064] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T21:51:34.057262+01:00 localhost kernel: [  379.624067] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000004
2011-12-13T21:51:34.057265+01:00 localhost kernel: [  379.624071] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:34.057267+01:00 localhost kernel: [  379.624075] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T21:51:34.057270+01:00 localhost kernel: [  379.624079] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T21:51:34.057272+01:00 localhost kernel: [  379.624083] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T21:51:34.057286+01:00 localhost kernel: [  379.624087] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T21:51:34.057289+01:00 localhost kernel: [  379.624091] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T21:51:34.060243+01:00 localhost kernel: [  379.627289] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:34.060256+01:00 localhost kernel: [  379.627295] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:34.060261+01:00 localhost kernel: [  379.627377] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:34.063579+01:00 localhost kernel: [  379.630429] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T21:51:34.063589+01:00 localhost kernel: [  379.630435] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T21:51:34.063592+01:00 localhost kernel: [  379.630438] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T21:51:34.063594+01:00 localhost kernel: [  379.630441] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T21:51:34.063596+01:00 localhost kernel: [  379.630444] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T21:51:34.063598+01:00 localhost kernel: [  379.630447] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T21:51:34.063600+01:00 localhost kernel: [  379.630450] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T21:51:34.063603+01:00 localhost kernel: [  379.630453] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T21:51:34.063605+01:00 localhost kernel: [  379.630456] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T21:51:34.066897+01:00 localhost kernel: [  379.633723] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.066910+01:00 localhost kernel: [  379.633774] iwlwifi 0000:03:00.0: U iwlagn_configure_filter Enter: changed: 0x0, total: 0x80000000
2011-12-13T21:51:34.070211+01:00 localhost kernel: [  379.635054] ADDRCONF(NETDEV_UP): wlan0: link is not ready
2011-12-13T21:51:34.196959+01:00 localhost kernel: [  379.761581] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34+01:00 localhost dhcpcd[9299]: version 5.2.12 starting
2011-12-13T21:51:34.206930+01:00 localhost kernel: [  379.761589] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0x100
2011-12-13T21:51:34.206948+01:00 localhost kernel: [  379.771695] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:34.206952+01:00 localhost kernel: [  379.771702] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T21:51:34.206958+01:00 localhost kernel: [  379.771708] iwlwifi 0000:03:00.0: U iwlagn_mac_hw_scan enter
2011-12-13T21:51:34.206961+01:00 localhost kernel: [  379.771925] iwlwifi 0000:03:00.0: U iwlagn_mac_hw_scan leave
2011-12-13T21:51:34+01:00 localhost dhcpcd[9299]: wlan0: waiting for carrier
2011-12-13T21:51:34.616890+01:00 localhost kernel: [  380.181152] iwlwifi 0000:03:00.0: U iwlagn_mac_hw_scan enter
2011-12-13T21:51:34.616912+01:00 localhost kernel: [  380.183410] iwlwifi 0000:03:00.0: U iwlagn_mac_hw_scan leave
2011-12-13T21:51:37.383589+01:00 localhost kernel: [  382.942972] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0x40
2011-12-13T21:51:37.383614+01:00 localhost kernel: [  382.942980] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:37.383616+01:00 localhost kernel: [  382.942989] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T21:51:37.383620+01:00 localhost kernel: [  382.942995] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:37.383622+01:00 localhost kernel: [  382.943000] iwlwifi 0000:03:00.0: U iwlagn_mac_flush enter
2011-12-13T21:51:37.383624+01:00 localhost kernel: [  382.943004] iwlwifi 0000:03:00.0: U iwlagn_mac_flush wait transmit/flush all frames
2011-12-13T21:51:37.383626+01:00 localhost kernel: [  382.943008] iwlwifi 0000:03:00.0: U iwlagn_mac_flush leave
2011-12-13T21:51:37.383629+01:00 localhost kernel: [  382.943012] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0x100
2011-12-13T21:51:37.383631+01:00 localhost kernel: [  382.943102] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:37.383633+01:00 localhost kernel: [  382.943109] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T21:51:37.386977+01:00 localhost kernel: [  382.943433] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0x40
2011-12-13T21:51:37.386990+01:00 localhost kernel: [  382.943439] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:37.386993+01:00 localhost kernel: [  382.943447] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:37.387054+01:00 localhost kernel: [  382.943468] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T21:51:37.387070+01:00 localhost kernel: [  382.943472] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T21:51:37.387077+01:00 localhost kernel: [  382.943476] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000004
2011-12-13T21:51:37.387079+01:00 localhost kernel: [  382.943479] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:37.387082+01:00 localhost kernel: [  382.943483] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T21:51:37.387084+01:00 localhost kernel: [  382.943487] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T21:51:37.387087+01:00 localhost kernel: [  382.943491] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T21:51:37.387090+01:00 localhost kernel: [  382.943495] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T21:51:37.387092+01:00 localhost kernel: [  382.943499] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T21:51:37.396917+01:00 localhost kernel: [  382.956352] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:37.396939+01:00 localhost kernel: [  382.956359] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:37.423561+01:00 localhost kernel: [  382.982649] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:37.423573+01:00 localhost kernel: [  382.982796] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T21:51:37.423578+01:00 localhost kernel: [  382.982850] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:37.433633+01:00 localhost kernel: [  382.982860] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0x100
2011-12-13T21:51:37.433652+01:00 localhost kernel: [  382.993001] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:37.433654+01:00 localhost kernel: [  382.993006] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T21:51:37.433657+01:00 localhost kernel: [  382.993011] iwlwifi 0000:03:00.0: U iwlagn_mac_tx_sync enter
2011-12-13T21:51:37.433660+01:00 localhost kernel: [  382.993014] iwlwifi 0000:03:00.0: U iwl_prep_station Add STA to driver ID 0: 11:99:12:34:77:43
2011-12-13T21:51:37.433663+01:00 localhost kernel: [  382.993057] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T21:51:37.433665+01:00 localhost kernel: [  382.993068] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:37.433677+01:00 localhost kernel: [  382.993077] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T21:51:37.433680+01:00 localhost kernel: [  382.993078] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T21:51:37.433682+01:00 localhost kernel: [  382.993080] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000004
2011-12-13T21:51:37.433684+01:00 localhost kernel: [  382.993081] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:37.433686+01:00 localhost kernel: [  382.993083] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T21:51:37.433689+01:00 localhost kernel: [  382.993084] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T21:51:37.433691+01:00 localhost kernel: [  382.993086] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T21:51:37.433694+01:00 localhost kernel: [  382.993087] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 11:99:12:34:77:43
2011-12-13T21:51:37.433696+01:00 localhost kernel: [  382.993101] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T21:51:37.436941+01:00 localhost kernel: [  382.993304] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:37.436951+01:00 localhost kernel: [  382.993311] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta 11:99:12:34:77:43
2011-12-13T21:51:37.436954+01:00 localhost kernel: [  382.993316] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:37.436957+01:00 localhost kernel: [  382.993380] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T21:51:37.436960+01:00 localhost kernel: [  382.993557] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:37.436962+01:00 localhost kernel: [  382.993643] iwlwifi 0000:03:00.0: U iwlagn_mac_tx_sync leave
2011-12-13T21:51:37.436968+01:00 localhost kernel: [  382.996198] iwlwifi 0000:03:00.0: U iwlagn_mac_finish_tx_sync enter
2011-12-13T21:51:37.436971+01:00 localhost kernel: [  382.996203] iwlwifi 0000:03:00.0: U iwl_remove_station Removing STA from driver:0  11:99:12:34:77:43
2011-12-13T21:51:37.436973+01:00 localhost kernel: [  382.996347] iwlwifi 0000:03:00.0: U iwl_sta_ucode_deactivate Removed STA 0
2011-12-13T21:51:37.436976+01:00 localhost kernel: [  382.996351] iwlwifi 0000:03:00.0: U iwl_send_remove_station REPLY_REMOVE_STA PASSED
2011-12-13T21:51:37.436978+01:00 localhost kernel: [  382.996356] iwlwifi 0000:03:00.0: U iwlagn_mac_finish_tx_sync leave
2011-12-13T21:51:37.530367+01:00 localhost kernel: [  383.086284] iwlwifi 0000:03:00.0: U iwlagn_mac_tx_sync enter
2011-12-13T21:51:37.530387+01:00 localhost kernel: [  383.086292] iwlwifi 0000:03:00.0: U iwl_prep_station Add STA to driver ID 0: 11:99:12:34:77:43
2011-12-13T21:51:37.530391+01:00 localhost kernel: [  383.086378] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T21:51:37.530394+01:00 localhost kernel: [  383.086394] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:37.530406+01:00 localhost kernel: [  383.086415] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T21:51:37.530409+01:00 localhost kernel: [  383.086419] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T21:51:37.530411+01:00 localhost kernel: [  383.086423] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000004
2011-12-13T21:51:37.530413+01:00 localhost kernel: [  383.086426] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:37.530415+01:00 localhost kernel: [  383.086430] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T21:51:37.530418+01:00 localhost kernel: [  383.086434] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T21:51:37.530420+01:00 localhost kernel: [  383.086438] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T21:51:37.530423+01:00 localhost kernel: [  383.086442] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 11:99:12:34:77:43
2011-12-13T21:51:37.530425+01:00 localhost kernel: [  383.086446] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T21:51:37.530428+01:00 localhost kernel: [  383.087821] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:37.530430+01:00 localhost kernel: [  383.087826] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta 11:99:12:34:77:43
2011-12-13T21:51:37.530433+01:00 localhost kernel: [  383.087830] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:37.530435+01:00 localhost kernel: [  383.087954] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T21:51:37.530438+01:00 localhost kernel: [  383.088046] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:37.530441+01:00 localhost kernel: [  383.088147] iwlwifi 0000:03:00.0: U iwlagn_mac_tx_sync leave
2011-12-13T21:51:37.536967+01:00 localhost kernel: [  383.094297] iwlwifi 0000:03:00.0: U iwlagn_mac_finish_tx_sync enter
2011-12-13T21:51:37.536970+01:00 localhost kernel: [  383.094301] iwlwifi 0000:03:00.0: U iwl_remove_station Removing STA from driver:0  11:99:12:34:77:43
2011-12-13T21:51:37.536973+01:00 localhost kernel: [  383.095013] iwlwifi 0000:03:00.0: U iwl_sta_ucode_deactivate Removed STA 0
2011-12-13T21:51:37.536975+01:00 localhost kernel: [  383.095018] iwlwifi 0000:03:00.0: U iwl_send_remove_station REPLY_REMOVE_STA PASSED
2011-12-13T21:51:37.536977+01:00 localhost kernel: [  383.095024] iwlwifi 0000:03:00.0: U iwlagn_mac_finish_tx_sync leave
2011-12-13T21:51:37.536980+01:00 localhost kernel: [  383.095033] iwlwifi 0000:03:00.0: U iwlagn_mac_sta_add received request to add station 11:99:12:34:77:43
2011-12-13T21:51:37.536983+01:00 localhost kernel: [  383.095038] iwlwifi 0000:03:00.0: U iwl_prep_station Add STA to driver ID 0: 11:99:12:34:77:43
2011-12-13T21:51:37.536986+01:00 localhost kernel: [  383.095042] iwlwifi 0000:03:00.0: U iwl_set_ht_add_station spatial multiplexing power save mode: disabled
2011-12-13T21:51:37.536988+01:00 localhost kernel: [  383.095778] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T21:51:37.540357+01:00 localhost kernel: [  383.096483] iwlwifi 0000:03:00.0: U iwlagn_mac_sta_add leave
2011-12-13T21:51:37.540368+01:00 localhost kernel: [  383.096495] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T21:51:37.540371+01:00 localhost kernel: [  383.096501] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T21:51:37.540373+01:00 localhost kernel: [  383.096507] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T21:51:37.540375+01:00 localhost kernel: [  383.096512] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T21:51:37.540377+01:00 localhost kernel: [  383.096516] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T21:51:37.540379+01:00 localhost kernel: [  383.096520] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T21:51:37.540381+01:00 localhost kernel: [  383.096525] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T21:51:37.540383+01:00 localhost kernel: [  383.096529] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T21:51:37.540385+01:00 localhost kernel: [  383.096600] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T21:51:37.540387+01:00 localhost kernel: [  383.096607] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:37.540399+01:00 localhost kernel: [  383.096635] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T21:51:37.540418+01:00 localhost kernel: [  383.096640] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T21:51:37.540421+01:00 localhost kernel: [  383.096646] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000004
2011-12-13T21:51:37.540423+01:00 localhost kernel: [  383.096652] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:37.540425+01:00 localhost kernel: [  383.096658] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T21:51:37.540428+01:00 localhost kernel: [  383.096664] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T21:51:37.540430+01:00 localhost kernel: [  383.096670] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T21:51:37.540433+01:00 localhost kernel: [  383.096676] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T21:51:37.540435+01:00 localhost kernel: [  383.096683] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T21:51:37.540438+01:00 localhost kernel: [  383.098689] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:37.540441+01:00 localhost kernel: [  383.098695] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta 11:99:12:34:77:43
2011-12-13T21:51:37.540443+01:00 localhost kernel: [  383.098699] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:37.540446+01:00 localhost kernel: [  383.099329] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T21:51:37.543664+01:00 localhost kernel: [  383.100817] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:37.543678+01:00 localhost kernel: [  383.101543] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0x42
2011-12-13T21:51:37.543683+01:00 localhost kernel: [  383.101552] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x7C0E active=3 idle=3
2011-12-13T21:51:37.543687+01:00 localhost kernel: [  383.101561] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x7C0E active=3 idle=3
2011-12-13T21:51:37.543692+01:00 localhost kernel: [  383.101569] iwlwifi 0000:03:00.0: U _iwl_set_rxon_ht rxon flags 0x4408005 operation mode :0x0 extension channel offset 0x3
2011-12-13T21:51:37.543696+01:00 localhost kernel: [  383.101578] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:37.543718+01:00 localhost kernel: [  383.101610] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T21:51:37.543722+01:00 localhost kernel: [  383.101616] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x04408005
2011-12-13T21:51:37.543726+01:00 localhost kernel: [  383.101623] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000004
2011-12-13T21:51:37.543730+01:00 localhost kernel: [  383.101629] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:37.543734+01:00 localhost kernel: [  383.101635] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T21:51:37.543738+01:00 localhost kernel: [  383.101641] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T21:51:37.543745+01:00 localhost kernel: [  383.101648] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T21:51:37.543750+01:00 localhost kernel: [  383.101654] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T21:51:37.543754+01:00 localhost kernel: [  383.101661] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T21:51:37.547140+01:00 localhost kernel: [  383.104360] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:37.547151+01:00 localhost kernel: [  383.104367] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta 11:99:12:34:77:43
2011-12-13T21:51:37.547154+01:00 localhost kernel: [  383.104371] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:37.547157+01:00 localhost kernel: [  383.105059] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T21:51:37.547160+01:00 localhost kernel: [  383.105236] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:37.547162+01:00 localhost kernel: [  383.105333] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T21:51:37.547165+01:00 localhost kernel: [  383.105342] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T21:51:37.547185+01:00 localhost kernel: [  383.105347] iwlwifi 0000:03:00.0: U _iwl_set_rxon_ht rxon flags 0x4C08025 operation mode :0x1 extension channel offset 0x3
2011-12-13T21:51:37.547188+01:00 localhost kernel: [  383.105352] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T21:51:37.547190+01:00 localhost kernel: [  383.105356] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T21:51:37.547202+01:00 localhost kernel: [  383.105376] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T21:51:37.547205+01:00 localhost kernel: [  383.105380] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x04C08035
2011-12-13T21:51:37.547207+01:00 localhost kernel: [  383.105384] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000024
2011-12-13T21:51:37.547230+01:00 localhost kernel: [  383.105388] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T21:51:37.547234+01:00 localhost kernel: [  383.105391] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T21:51:37.547237+01:00 localhost kernel: [  383.105395] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T21:51:37.547239+01:00 localhost kernel: [  383.105399] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T21:51:37.547242+01:00 localhost kernel: [  383.105403] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 11:99:12:34:77:43
2011-12-13T21:51:37.547244+01:00 localhost kernel: [  383.105407] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x1
2011-12-13T21:51:37.547247+01:00 localhost kernel: [  383.106277] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T21:51:37.547250+01:00 localhost kernel: [  383.106285] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta 11:99:12:34:77:43
2011-12-13T21:51:37.547253+01:00 localhost kernel: [  383.106294] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T21:51:37.547255+01:00 localhost kernel: [  383.106362] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T21:51:37.547267+01:00 localhost kernel: [  383.106511] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T21:51:37.550239+01:00 localhost kernel: [  383.107204] iwlwifi 0000:03:00.0: U iwl_send_rxon_timing beacon interval 100 beacon timer 230 beacon tim 0
2011-12-13T21:51:37.550256+01:00 localhost kernel: [  383.108587] iwlwifi 0000:03:00.0: U iwl_send_remove_station REPLY_REMOVE_STA PASSED
2011-12-13T21:51:37.553576+01:00 localhost kernel: [  383.109609] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T21:51:37.553595+01:00 localhost kernel: [  383.110578] iwlwifi 0000:03:00.0: U iwlagn_mac_finish_tx_sync enter
2011-12-13T21:51:37.553598+01:00 localhost kernel: [  383.110583] iwlwifi 0000:03:00.0: U iwlagn_mac_finish_tx_sync leave
2011-12-13T21:51:37.553601+01:00 localhost kernel: [  383.111800] ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
2011-12-13T21:51:37.553604+01:00 localhost kernel: [  383.111961] iwlwifi 0000:03:00.0: U iwlagn_configure_filter Enter: changed: 0x0, total: 0x80000000
2011-12-13T21:51:37.820222+01:00 localhost kernel: [  383.378738] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key enter
2011-12-13T21:51:37.823615+01:00 localhost kernel: [  383.379413] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T21:51:37.823630+01:00 localhost kernel: [  383.379487] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key enable hwcrypto key
2011-12-13T21:51:37.823635+01:00 localhost kernel: [  383.379493] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key leave
2011-12-13T21:51:37.823639+01:00 localhost kernel: [  383.379500] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action enter
2011-12-13T21:51:37.823644+01:00 localhost kernel: [  383.381147] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T21:51:37.823647+01:00 localhost kernel: [  383.381173] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action leave
2011-12-13T21:51:37.823650+01:00 localhost kernel: [  383.381218] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key enter
2011-12-13T21:51:37.823655+01:00 localhost kernel: [  383.382138] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T21:51:37.823658+01:00 localhost kernel: [  383.382162] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key enable hwcrypto key
2011-12-13T21:51:37.823661+01:00 localhost kernel: [  383.382168] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key leave
2011-12-13T21:51:37+01:00 localhost dhcpcd[9299]: wlan0: carrier acquired
2011-12-13T21:51:37+01:00 localhost dhcpcd[9299]: wlan0: rebinding lease of 192.168.57.12
2011-12-13T21:51:38+01:00 localhost dhcpcd[9299]: wlan0: acknowledged 192.168.57.12 from 192.168.57.1
2011-12-13T21:51:38+01:00 localhost dhcpcd[9299]: wlan0: checking for 192.168.57.12
2011-12-13T21:51:39.136901+01:00 localhost kernel: [  384.690910] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T21:51:42+01:00 localhost dhcpcd[9299]: wlan0: leased 192.168.57.12 for 86400 seconds
2011-12-13T21:51:42.956928+01:00 localhost kernel: [  388.499635] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T21:51:42.956943+01:00 localhost kernel: [  388.499642] iwlwifi 0000:03:00.0: U _iwl_set_rxon_ht rxon flags 0x4C08035 operation mode :0x1 extension channel offset 0x3
2011-12-13T21:51:42.956947+01:00 localhost kernel: [  388.499658] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T21:51:42+01:00 localhost dhcpcd[9299]: forked to background, child pid 9343
2011-12-13T21:52:10.080227+01:00 localhost kernel: [  415.555790] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action enter
2011-12-13T21:52:10.080249+01:00 localhost kernel: [  415.555906] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T21:52:10.080253+01:00 localhost kernel: [  415.555928] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action leave
2011-12-13T21:52:13.676915+01:00 localhost kernel: [  419.142482] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action enter
2011-12-13T21:52:13.676941+01:00 localhost kernel: [  419.142563] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T21:52:13.676944+01:00 localhost kernel: [  419.142584] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action leave
2011-12-13T21:52:13.686887+01:00 localhost kernel: [  419.154219] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action enter
2011-12-13T21:52:13.686905+01:00 localhost kernel: [  419.154364] iwlwifi 0000:03:00.0: Tx aggregation enabled on ra = 11:99:12:34:77:43 tid = 0
2011-12-13T21:52:13.686908+01:00 localhost kernel: [  419.154368] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action leave
2011-12-13T22:00:43+01:00 localhost dhcpcd[9517]: sending signal 1 to pid 9343
2011-12-13T22:00:43+01:00 localhost dhcpcd[9343]: received SIGHUP, releasing
2011-12-13T22:00:43+01:00 localhost dhcpcd[9343]: wlan0: releasing lease of 192.168.57.12
2011-12-13T22:00:43+01:00 localhost dhcpcd[9517]: waiting for pid 9343 to exit
2011-12-13T22:00:43.360179+01:00 localhost kernel: [  927.535573] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T22:00:43.360202+01:00 localhost kernel: [  927.535579] iwlwifi 0000:03:00.0: U _iwl_set_rxon_ht rxon flags 0x4C08035 operation mode :0x1 extension channel offset 0x3
2011-12-13T22:00:43.360207+01:00 localhost kernel: [  927.535583] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T22:00:43+01:00 localhost dhcpcd[9343]: wlan0: removing interface
2011-12-13T22:00:51.803641+01:00 localhost kernel: [  935.952809] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action enter
2011-12-13T22:00:51.803655+01:00 localhost kernel: [  935.952904] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action leave
2011-12-13T22:00:51.803659+01:00 localhost kernel: [  935.952907] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action enter
2011-12-13T22:00:51.803665+01:00 localhost kernel: [  935.952975] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T22:00:51.803669+01:00 localhost kernel: [  935.952985] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action leave
2011-12-13T22:00:51.803672+01:00 localhost kernel: [  935.953001] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action enter
2011-12-13T22:00:51.803677+01:00 localhost kernel: [  935.953876] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T22:00:51.803680+01:00 localhost kernel: [  935.953884] iwlwifi 0000:03:00.0: U iwlagn_mac_ampdu_action leave
2011-12-13T22:00:51.803684+01:00 localhost kernel: [  935.953892] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T22:00:51.803687+01:00 localhost kernel: [  935.953894] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T22:00:51.803690+01:00 localhost kernel: [  935.953895] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T22:00:51.803693+01:00 localhost kernel: [  935.953896] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T22:00:51.803697+01:00 localhost kernel: [  935.953897] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T22:00:51.803700+01:00 localhost kernel: [  935.953898] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T22:00:51.803727+01:00 localhost kernel: [  935.953900] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx enter
2011-12-13T22:00:51.803732+01:00 localhost kernel: [  935.953901] iwlwifi 0000:03:00.0: U iwlagn_mac_conf_tx leave
2011-12-13T22:00:51.803736+01:00 localhost kernel: [  935.954759] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T22:00:51.803740+01:00 localhost kernel: [  935.954765] iwlwifi 0000:03:00.0: U _iwl_set_rxon_ht rxon flags 0x4C08015 operation mode :0x1 extension channel offset 0x3
2011-12-13T22:00:51.803744+01:00 localhost kernel: [  935.954770] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x280E active=2 idle=2
2011-12-13T22:00:51.803747+01:00 localhost kernel: [  935.954774] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T22:00:51.803769+01:00 localhost kernel: [  935.954795] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T22:00:51.803772+01:00 localhost kernel: [  935.954799] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x04C08005
2011-12-13T22:00:51.804260+01:00 localhost kernel: [  935.954803] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000024
2011-12-13T22:00:51.804267+01:00 localhost kernel: [  935.954806] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T22:00:51.804271+01:00 localhost kernel: [  935.954810] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T22:00:51.804275+01:00 localhost kernel: [  935.954814] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T22:00:51.804279+01:00 localhost kernel: [  935.954818] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T22:00:51.804283+01:00 localhost kernel: [  935.954822] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T22:00:51.804287+01:00 localhost kernel: [  935.954826] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x1
2011-12-13T22:00:51.804363+01:00 localhost kernel: [  935.955857] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T22:00:51.804629+01:00 localhost kernel: [  935.955863] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta 11:99:12:34:77:43
2011-12-13T22:00:51.804639+01:00 localhost kernel: [  935.955868] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T22:00:51.804644+01:00 localhost kernel: [  935.955921] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T22:00:51.804648+01:00 localhost kernel: [  935.956054] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T22:00:51.804652+01:00 localhost kernel: [  935.956145] iwlwifi 0000:03:00.0: U iwl_send_rxon_timing beacon interval 100 beacon timer 230 beacon tim 0
2011-12-13T22:00:51.806973+01:00 localhost kernel: [  935.956580] iwlwifi 0000:03:00.0: U iwl_send_remove_station REPLY_REMOVE_STA PASSED
2011-12-13T22:00:51.806986+01:00 localhost kernel: [  935.956727] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T22:00:51.806990+01:00 localhost kernel: [  935.957659] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0x40
2011-12-13T22:00:51.806993+01:00 localhost kernel: [  935.957665] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T22:00:51.806995+01:00 localhost kernel: [  935.957672] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T22:00:51.807009+01:00 localhost kernel: [  935.957691] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T22:00:51.807011+01:00 localhost kernel: [  935.957695] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T22:00:51.807013+01:00 localhost kernel: [  935.957699] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000024
2011-12-13T22:00:51.807016+01:00 localhost kernel: [  935.957703] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T22:00:51.807018+01:00 localhost kernel: [  935.957706] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T22:00:51.807020+01:00 localhost kernel: [  935.957710] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T22:00:51.807023+01:00 localhost kernel: [  935.957714] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T22:00:51.807025+01:00 localhost kernel: [  935.957718] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T22:00:51.807028+01:00 localhost kernel: [  935.957722] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x1
2011-12-13T22:00:51.810304+01:00 localhost kernel: [  935.959007] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T22:00:51.810316+01:00 localhost kernel: [  935.959016] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T22:00:51.810319+01:00 localhost kernel: [  935.959023] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T22:00:51.810321+01:00 localhost kernel: [  935.959028] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T22:00:51.810333+01:00 localhost kernel: [  935.959060] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T22:00:51.810335+01:00 localhost kernel: [  935.959065] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T22:00:51.810338+01:00 localhost kernel: [  935.959071] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000004
2011-12-13T22:00:51.810342+01:00 localhost kernel: [  935.959077] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T22:00:51.810344+01:00 localhost kernel: [  935.959083] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0x15
2011-12-13T22:00:51.810347+01:00 localhost kernel: [  935.959089] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x03
2011-12-13T22:00:51.810349+01:00 localhost kernel: [  935.959094] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:24:d7:4b:77:98
2011-12-13T22:00:51.810352+01:00 localhost kernel: [  935.959100] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T22:00:51.810354+01:00 localhost kernel: [  935.959106] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x1
2011-12-13T22:00:51.810357+01:00 localhost kernel: [  935.959326] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T22:00:51.810359+01:00 localhost kernel: [  935.959332] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta 11:99:12:34:77:43
2011-12-13T22:00:51.810362+01:00 localhost kernel: [  935.959336] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T22:00:51.810364+01:00 localhost kernel: [  935.959413] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 0 addr 11:99:12:34:77:43 to uCode
2011-12-13T22:00:51.810367+01:00 localhost kernel: [  935.959490] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T22:00:51.866839+01:00 localhost kernel: [  936.015181] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key enter
2011-12-13T22:00:51.866854+01:00 localhost kernel: [  936.015275] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T22:00:51.866857+01:00 localhost kernel: [  936.015289] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key disable hwcrypto key
2011-12-13T22:00:51.866859+01:00 localhost kernel: [  936.015293] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key leave
2011-12-13T22:00:51.920270+01:00 localhost kernel: [  936.068330] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key enter
2011-12-13T22:00:51.920281+01:00 localhost kernel: [  936.068419] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate STA id 0 addr 11:99:12:34:77:43 already present in uCode (according to driver)
2011-12-13T22:00:51.920284+01:00 localhost kernel: [  936.068438] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key disable hwcrypto key
2011-12-13T22:00:51.920286+01:00 localhost kernel: [  936.068442] iwlwifi 0000:03:00.0: U iwlagn_mac_set_key leave
2011-12-13T22:00:51.920288+01:00 localhost kernel: [  936.068449] iwlwifi 0000:03:00.0: U iwlagn_mac_sta_remove enter: received request to remove station 11:99:12:34:77:43
2011-12-13T22:00:51.920291+01:00 localhost kernel: [  936.068454] iwlwifi 0000:03:00.0: U iwl_remove_station Removing STA from driver:0  11:99:12:34:77:43
2011-12-13T22:00:51.920293+01:00 localhost kernel: [  936.068559] iwlwifi 0000:03:00.0: U iwl_sta_ucode_deactivate Removed STA 0
2011-12-13T22:00:51.920295+01:00 localhost kernel: [  936.068564] iwlwifi 0000:03:00.0: U iwl_send_remove_station REPLY_REMOVE_STA PASSED
2011-12-13T22:00:51.920296+01:00 localhost kernel: [  936.068569] iwlwifi 0000:03:00.0: U iwlagn_mac_sta_remove leave
2011-12-13T22:00:51.950237+01:00 localhost kernel: [  936.098336] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T22:00:51.950259+01:00 localhost kernel: [  936.098348] iwlwifi 0000:03:00.0: U iwlagn_mac_flush enter
2011-12-13T22:00:51.950264+01:00 localhost kernel: [  936.098351] iwlwifi 0000:03:00.0: U iwlagn_mac_flush wait transmit/flush all frames
2011-12-13T22:00:51.950270+01:00 localhost kernel: [  936.098355] iwlwifi 0000:03:00.0: U iwlagn_mac_flush leave
2011-12-13T22:00:51.950273+01:00 localhost kernel: [  936.098359] iwlwifi 0000:03:00.0: U iwlagn_mac_config enter: changed 0x100
2011-12-13T22:00:51.950277+01:00 localhost kernel: [  936.098462] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T22:00:51.950280+01:00 localhost kernel: [  936.098467] iwlwifi 0000:03:00.0: U iwlagn_mac_config leave
2011-12-13T22:00:51.950283+01:00 localhost kernel: [  936.098482] cfg80211: Calling CRDA for country: FR
2011-12-13T22:00:52.030202+01:00 localhost kernel: [  936.178645] iwlwifi 0000:03:00.0: U iwlagn_configure_filter Enter: changed: 0x0, total: 0x80000000
2011-12-13T22:00:52.030218+01:00 localhost kernel: [  936.178698] iwlwifi 0000:03:00.0: U iwlagn_configure_filter Enter: changed: 0x0, total: 0x80000000
2011-12-13T22:00:52.076968+01:00 localhost kernel: [  936.224565] iwlwifi 0000:03:00.0: U iwlagn_mac_remove_interface enter
2011-12-13T22:00:52.076980+01:00 localhost kernel: [  936.224574] iwlwifi 0000:03:00.0: U iwlagn_set_rxon_chain rx_chain=0x240E active=2 idle=1
2011-12-13T22:00:52.076984+01:00 localhost kernel: [  936.224579] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd RX CONFIG:
2011-12-13T22:00:52.076997+01:00 localhost kernel: [  936.224600] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 channel: 0x6
2011-12-13T22:00:52.076999+01:00 localhost kernel: [  936.224604] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 flags: 0x00008005
2011-12-13T22:00:52.077003+01:00 localhost kernel: [  936.224608] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u32 filter_flags: 0x00000000
2011-12-13T22:00:52.077006+01:00 localhost kernel: [  936.224612] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 dev_type: 0x3
2011-12-13T22:00:52.077008+01:00 localhost kernel: [  936.224632] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 ofdm_basic_rates: 0xff
2011-12-13T22:00:52.077011+01:00 localhost kernel: [  936.224636] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8 cck_basic_rates: 0x0f
2011-12-13T22:00:52.077013+01:00 localhost kernel: [  936.224640] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] node_addr: 00:00:00:00:00:00
2011-12-13T22:00:52.077016+01:00 localhost kernel: [  936.224644] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u8[6] bssid_addr: 00:00:00:00:00:00
2011-12-13T22:00:52.077018+01:00 localhost kernel: [  936.224648] iwlwifi 0000:03:00.0: U iwl_print_rx_config_cmd u16 assoc_id: 0x0
2011-12-13T22:00:52.086871+01:00 localhost kernel: [  936.235635] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring all known stations ... start.
2011-12-13T22:00:52.086885+01:00 localhost kernel: [  936.235641] iwlwifi 0000:03:00.0: U iwl_restore_stations Restoring sta ff:ff:ff:ff:ff:ff
2011-12-13T22:00:52.090195+01:00 localhost kernel: [  936.238953] iwlwifi 0000:03:00.0: I iwl_sta_ucode_activate Added STA id 15 addr ff:ff:ff:ff:ff:ff to uCode
2011-12-13T22:00:52.107184+01:00 localhost kernel: [  936.250984] iwlwifi 0000:03:00.0: U iwlagn_mac_remove_interface leave
2011-12-13T22:00:52.107197+01:00 localhost kernel: [  936.250993] iwlwifi 0000:03:00.0: U iwlagn_mac_stop enter
2011-12-13T22:00:52.110173+01:00 localhost kernel: [  936.258177] iwlwifi 0000:03:00.0: U iwlagn_mac_stop leave
2011-12-13T22:00:54.953529+01:00 localhost kernel: [  939.092907] iwlwifi 0000:03:00.0: PCI INT A disabled

^ permalink raw reply

* [PATCH] rtnetlink: rtnl_link_register always returns zero
From: alex.bluesman.smirnov @ 2011-12-13 20:31 UTC (permalink / raw)
  To: netdev; +Cc: davem, Alexander Smirnov

From: Alexander Smirnov <alexander@Lenovo.(none)>

Both functions 'rtnl_link_register' and '__rtnl_link_register' always
return zero. So handling return status has no sense in several drivers.

Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
---
 drivers/net/bonding/bond_main.c |    6 +-----
 drivers/net/can/dev.c           |    8 +-------
 drivers/net/tun.c               |    8 ++------
 3 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 25a44d9..f79bb97 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4921,9 +4921,7 @@ static int __init bonding_init(void)
 	if (res)
 		goto out;
 
-	res = rtnl_link_register(&bond_link_ops);
-	if (res)
-		goto err_link;
+	rtnl_link_register(&bond_link_ops);
 
 	bond_create_debugfs();
 
@@ -4939,10 +4937,8 @@ out:
 	return res;
 err:
 	rtnl_link_unregister(&bond_link_ops);
-err_link:
 	unregister_pernet_subsys(&bond_net_ops);
 	goto out;
-
 }
 
 static void __exit bonding_exit(void)
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index 120f1ab..e5b5daf 100644
--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -756,13 +756,7 @@ EXPORT_SYMBOL_GPL(unregister_candev);
 
 static __init int can_dev_init(void)
 {
-	int err;
-
-	err = rtnl_link_register(&can_link_ops);
-	if (!err)
-		printk(KERN_INFO MOD_DESC "\n");
-
-	return err;
+	return rtnl_link_register(&can_link_ops);
 }
 module_init(can_dev_init);
 
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 93c5d72..bb034b1 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1632,16 +1632,12 @@ static const struct ethtool_ops tun_ethtool_ops = {
 
 static int __init tun_init(void)
 {
-	int ret = 0;
+	int ret;
 
 	pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION);
 	pr_info("%s\n", DRV_COPYRIGHT);
 
-	ret = rtnl_link_register(&tun_link_ops);
-	if (ret) {
-		pr_err("Can't register link_ops\n");
-		goto err_linkops;
-	}
+	rtnl_link_register(&tun_link_ops);
 
 	ret = misc_register(&tun_miscdev);
 	if (ret) {
-- 
1.7.0.4

^ permalink raw reply related

* Re: Driver for embedded switch Micrel KS8995MA
From: Gabor Juhos @ 2011-12-13 20:15 UTC (permalink / raw)
  To: Frederic LAMBERT; +Cc: Florian Fainelli, netdev
In-Reply-To: <CAMVnO+n38nMTYc7nRfbywidNRM_OYPW8nT1SNAKZyxmhCBb3AA@mail.gmail.com>

2011.12.13. 20:58 keltezéssel, Frederic LAMBERT írta:
> Wow, the list is safer than direct email !:-). 

Yes, especially if you don't forget to reply to all recipients. ;)

> Thanks to Florian and you for the answer.
> 
> Your driver helped me a lot because, due to an ambiguity of the
> datasheet, I could'nt understand why the switch wouldn't want to
> switch... until I add your driver in my kernel, and your xxx_start()
> write 0x0001 into reg#1!
> 
> Anyway, I think the driver can help others as it did for me, so I want
> to submit it (with the small update on read() and write() functions).
> 
> Is this list the best place to do that?

Yes, I think so.

-Gabor

^ permalink raw reply

* Re: iwlagn regression in v3.1.5
From: wwguy @ 2011-12-13 20:15 UTC (permalink / raw)
  To: Andrej Gelenberg
  Cc: Udo Steinberg, Intel Linux Wireless, John W. Linville,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
In-Reply-To: <4EE636B9.1020305@udo.edu>

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi Andrej,

Could you try this patch and see any differences.

please still use the same debug flag I ask you last time.

Thanks
Wey

n Mon, 2011-12-12 at 09:15 -0800, Andrej Gelenberg wrote:
> Hi,
> 
> there are broken wlan log and working wlan log and an diff of them.
> 
> Regards,
> Andrej Gelenberg
> 
> On 12/12/2011 02:35 AM, wwguy wrote:
> > Hi Andjej,
> >
> >
> > Could you please load the module with debug=0x1082 and send me the log.
> >
> > $sudo modprobe iwlagn debug=0x1082
> >
> > Thanks
> > Wey


[-- Attachment #2: 0001-iwlwifi-allow-to-switch-to-HT40-if-not-associated-ye.patch --]
[-- Type: text/x-patch, Size: 1094 bytes --]

>From 92e10223b4acf832121f0aa5b4a8d35ebb176f9e Mon Sep 17 00:00:00 2001
From: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Date: Tue, 13 Dec 2011 12:13:05 -0800
Subject: [PATCH 1/1] iwlwifi: allow to switch to HT40 if not associated yet

Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
---
 drivers/net/wireless/iwlwifi/iwl-agn-rxon.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
index 36932aa..23548ac 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
@@ -610,8 +610,9 @@ int iwlagn_mac_config(struct ieee80211_hw *hw, u32 changed)
 			if (ctx->ht.enabled) {
 				/* if HT40 is used, it should not change
 				 * after associated except channel switch */
-				if (iwl_is_associated_ctx(ctx) &&
-				     !ctx->ht.is_40mhz)
+				if ((iwl_is_associated_ctx(ctx) &&
+						!ctx->ht.is_40mhz) ||
+						!iwl_is_associated_ctx(ctx))
 					iwlagn_config_ht40(conf, ctx);
 			} else
 				ctx->ht.is_40mhz = false;
-- 
1.7.0.4


^ permalink raw reply related

* Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls
From: Glauber Costa @ 2011-12-13 20:11 UTC (permalink / raw)
  To: Eric Dumazet
  Cc: christoph.paasch, David Miller, linux-kernel, paul, lizf,
	kamezawa.hiroyu, ebiederm, gthelen, netdev, linux-mm, kirill,
	avagin, devel, cgroups
In-Reply-To: <1323784748.2950.4.camel@edumazet-laptop>

On 12/13/2011 05:59 PM, Eric Dumazet wrote:
> Le mardi 13 décembre 2011 à 14:49 +0100, Christoph Paasch a écrit :
>
>> now there are plenty of compiler-warnings when CONFIG_CGROUPS is not set:
>>
>> In file included from include/linux/tcp.h:211:0,
>>                   from include/linux/ipv6.h:221,
>>                   from include/net/ip_vs.h:23,
>>                   from kernel/sysctl_binary.c:6:
>> include/net/sock.h:67:57: warning: ‘struct cgroup_subsys’ declared
>> inside parameter list [enabled by default]
>> include/net/sock.h:67:57: warning: its scope is only this definition or
>> declaration, which is probably not what you want [enabled by default]
>> include/net/sock.h:67:57: warning: ‘struct cgroup’ declared inside
>> parameter list [enabled by default]
>> include/net/sock.h:68:61: warning: ‘struct cgroup_subsys’ declared
>> inside parameter list [enabled by default]
>> include/net/sock.h:68:61: warning: ‘struct cgroup’ declared inside
>> parameter list [enabled by default]
>>
>>
>> Because struct cgroup is only declared if CONFIG_CGROUPS is enabled.
>> (cfr. linux/cgroup.h)
>>
>
> Yes, we probably need forward reference like this :
>
> Thanks !
>
> [PATCH net-next] net: fix build error if CONFIG_CGROUPS=n
>
> Reported-by: Christoph Paasch<christoph.paasch@uclouvain.be>
> Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com>
I am deeply sorry about that.
I was pretty sure I tested this case. But now that I looked into it, it 
occurs to me that I may have tested it only with the Memory Cgroup 
disabled, not with the master flag off.

Thanks for spotting this

^ permalink raw reply

* Re: Driver for embedded switch Micrel KS8995MA
From: Gabor Juhos @ 2011-12-13 19:49 UTC (permalink / raw)
  To: Florian Fainelli; +Cc: Frederic LAMBERT, netdev
In-Reply-To: <4EE79B78.1040807@openwrt.org>

Hi,

> On 12/13/11 19:33, Frederic LAMBERT wrote:
>> I found an quite old driver on the net for the 5-ports 10/100 embedded
>> switch Micrel KS8995MA.
>> It had to be updated a little bit because a parameter was missing to
>> the ks8995_registers_read()&  write() functions.
>>
>> I haven't been able to contact its original author, Gabor Juhos, who
>> wrote it in 2008 under GPL v2.

Sorry, I did not see your e-mail. It has been marked as spam by one of my mail
filters.

> Gabor is responding pretty quickly in general. You are talking about this
> particular driver?
> 
> https://dev.openwrt.org/browser/trunk/package/spi-ks8995/src/spi_ks8995.c
> 
>>
>> Is it possible to submit this driver as a patch to be included in the
>> distribution?

The driver was used for an IXP4xx based board originally. I have bricked my
board a long time ago, so I can't test the driver anymore. If you can use the
driver for anything, feel free to send that upstream.

-Gabor

^ permalink raw reply

* RE: [PATCH net-next V2 00/21] net/mlx4: SRIOV support
From: Yevgeny Petrilin @ 2011-12-13 19:16 UTC (permalink / raw)
  To: David Miller
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org, Liran Liss,
	jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org
In-Reply-To: <20111213.141413.1872427395829102426.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

> > This is V2 of a patch set that adds SRIOV support for ConnectX2 and
> > ConnectX3 HW for Ethernet Link layer.  Infiniband and RoCE SRIOV
> > support will be added at later stage
> 
> Applied.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply

* Re: [PATCH net-next V2 00/21] net/mlx4: SRIOV support
From: David Miller @ 2011-12-13 19:14 UTC (permalink / raw)
  To: yevgenyp-VPRAkNaXOzVS1MOuV/RT9w
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	roland-BHEL68pLQRGGvPXPguhicg, liranl-VPRAkNaXOzVS1MOuV/RT9w,
	jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb
In-Reply-To: <4EE75CD1.7070900-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>

From: Yevgeny Petrilin <yevgenyp-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Date: Tue, 13 Dec 2011 16:10:25 +0200

> This is V2 of a patch set that adds SRIOV support for ConnectX2 and
> ConnectX3 HW for Ethernet Link layer.  Infiniband and RoCE SRIOV
> support will be added at later stage

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply

* Re: kernel 3.1.1 message:  <IRQ> warn_alloc_failed
From: Ben Hutchings @ 2011-12-13 19:09 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: Rajesh Borundia, starlight@binnacle.cx, Sony Chacko, linux-kernel,
	netdev
In-Reply-To: <20111213104152.14c01911@nehalam.linuxnetplumber.net>

On Tue, 2011-12-13 at 10:41 -0800, Stephen Hemminger wrote:
> On Tue, 13 Dec 2011 11:42:13 -0600
> Rajesh Borundia <rajesh.borundia@qlogic.com> wrote:
> 
> > Hi All,
> > 
> > Sorry for late reply.
> > 
> > Stephan,
> > Thanks for analyzing.
> > 
> > Yes, the netxen adapter does not support fragmented page memory.
> > They are not harmful messages. At that instant of time it may fail allocating
> > memory for some buffers in the ring but after enough memory is available
> > it will try to allocate memory for unallocated buffers in ring.
> > 
> > Or the other option could be to turn LRO off.
[...]
> The driver should be changed to call allocation with __GFP_NOWARN.
> Change dev_alloc_skb(size) to
>   __dev_alloc_skb(size, GFP_ATOMIC|__GFP_NOWARN)
> 
> Or better yet, switch to using netdev_alloc variant like
>   __netdev_alloc_skb_ip_align(dev, length, GFP_ATOMIC|__GFP_NOWARN)

Why should this be done only in specific drivers?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply

* Re: bayom_epp patch
From: Thomas Sailer @ 2011-12-13 18:50 UTC (permalink / raw)
  To: netdev
In-Reply-To: <4EE748BA.5080807@suse.cz>

baycom_epp: Improve parport handling, fix multi-core support

Parallel port settings no longer require an IO address value,
because addresses are automatically assigned by the PCI BIOS
nowadays and may change rather frequently.
Instead, the parport number is used (e.g. modprobe baycom_epp parport=0)

EPP transfers now utilize block IO transfers, thus significantly
reducing CPU load. Furthermore, EPP RX data transfer handling of the
conventional EPP modem (without FPGA) has been improved to assure
a minimum block transfer size increasing the effective data rate.

Spin-locks have been introduced for better multi-core compatibility.
The x86_64 exclusion has been removed from Kconfig because no problems
where observed on several test systems. To achieve this, several x86
architecture specific debug statements had to be removed.

Signed-off-by: Thomas Sailer <sailer@ife.ee.ethz.ch>
Signed-off-by: Steffen Koehler <steffen.koehler@tu-dresden.de>

diff --git a/drivers/net/hamradio/Kconfig b/drivers/net/hamradio/Kconfig
index 95dbcfd..9a736f0 100644
--- a/drivers/net/hamradio/Kconfig
+++ b/drivers/net/hamradio/Kconfig
@@ -166,7 +166,7 @@ config BAYCOM_PAR
 
 config BAYCOM_EPP
 	tristate "BAYCOM epp driver for AX.25"
-	depends on PARPORT && AX25 && !64BIT
+	depends on PARPORT && AX25
 	select CRC_CCITT
 	---help---
 	  This is a driver for Baycom style simple amateur radio modems that
diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
index 9537aaa..6e1019b 100644
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -3,8 +3,9 @@
 /*
  *	baycom_epp.c  -- baycom epp radio modem driver.
  *
- *	Copyright (C) 1998-2000
+ *	Copyright (C) 1998-2000, 2010
  *          Thomas Sailer (sailer@ife.ee.ethz.ch)
+ *          Steffen Koehler (steffen.koehler@tu-dresden.de)
  *
  *	This program is free software; you can redistribute it and/or modify
  *	it under the terms of the GNU General Public License as published by
@@ -33,8 +34,12 @@
  *   0.4  26.07.1999  Adapted to new lowlevel parport driver interface
  *   0.5  03.08.1999  adapt to Linus' new __setup/__initcall
  *                    removed some pre-2.2 kernel compatibility cruft
- *   0.6  10.08.1999  Check if parport can do SPP and is safe to access during interrupt contexts
+ *   0.6  10.08.1999  Check if parport can do SPP and is safe to access during
+ *                    interrupt contexts
  *   0.7  12.02.2000  adapted to softnet driver interface
+ *   0.8  12.01.2010  added spinlocks for multi-cpu safety, changed interface
+ *                    enumeration according to the parport number, some minor
+ *                    bug fixes
  *
  */
 
@@ -59,7 +64,6 @@
 
 /* --------------------------------------------------------------------- */
 
-#define BAYCOM_DEBUG
 #define BAYCOM_MAGIC 19730510
 
 /* --------------------------------------------------------------------- */
@@ -68,8 +72,8 @@ static const char paranoia_str[] = KERN_ERR
 	"baycom_epp: bad magic number for hdlcdrv_state struct in routine %s\n";
 
 static const char bc_drvname[] = "baycom_epp";
-static const char bc_drvinfo[] = KERN_INFO "baycom_epp: (C) 1998-2000 Thomas Sailer, HB9JNX/AE4WA\n"
-"baycom_epp: version 0.7\n";
+static const char bc_drvinfo[] = KERN_INFO "baycom_epp: (C) 1998-2010 Thomas Sailer, HB9JNX/AE4WA\n"
+"baycom_epp: version 0.8\n";
 
 /* --------------------------------------------------------------------- */
 
@@ -94,72 +98,13 @@ static struct net_device *baycom_device[NR_PORTS];
 #define EPP_RX_FIFO_ENABLE 0x08
 #define EPP_MODEM_ENABLE   0x20
 #define EPP_LEDS           0xC0
-#define EPP_IRQ_ENABLE     0x10
-
-/* LPT registers */
-#define LPTREG_ECONTROL       0x402
-#define LPTREG_CONFIGB        0x401
-#define LPTREG_CONFIGA        0x400
-#define LPTREG_EPPDATA        0x004
-#define LPTREG_EPPADDR        0x003
-#define LPTREG_CONTROL        0x002
-#define LPTREG_STATUS         0x001
-#define LPTREG_DATA           0x000
-
-/* LPT control register */
-#define LPTCTRL_PROGRAM       0x04   /* 0 to reprogram */
-#define LPTCTRL_WRITE         0x01
-#define LPTCTRL_ADDRSTB       0x08
-#define LPTCTRL_DATASTB       0x02
-#define LPTCTRL_INTEN         0x10
-
-/* LPT status register */
-#define LPTSTAT_SHIFT_NINTR   6
-#define LPTSTAT_WAIT          0x80
-#define LPTSTAT_NINTR         (1<<LPTSTAT_SHIFT_NINTR)
-#define LPTSTAT_PE            0x20
-#define LPTSTAT_DONE          0x10
-#define LPTSTAT_NERROR        0x08
-#define LPTSTAT_EPPTIMEOUT    0x01
-
-/* LPT data register */
-#define LPTDATA_SHIFT_TDI     0
-#define LPTDATA_SHIFT_TMS     2
-#define LPTDATA_TDI           (1<<LPTDATA_SHIFT_TDI)
-#define LPTDATA_TCK           0x02
-#define LPTDATA_TMS           (1<<LPTDATA_SHIFT_TMS)
-#define LPTDATA_INITBIAS      0x80
-
-
-/* EPP modem config/status bits */
-#define EPP_DCDBIT            0x80
-#define EPP_PTTBIT            0x08
-#define EPP_RXEBIT            0x01
-#define EPP_RXAEBIT           0x02
-#define EPP_RXHFULL           0x04
-
-#define EPP_NTHF              0x20
-#define EPP_NTAEF             0x10
-#define EPP_NTEF              EPP_PTTBIT
-
-#define EPP_TX_FIFO_ENABLE    0x10
-#define EPP_RX_FIFO_ENABLE    0x08
-#define EPP_MODEM_ENABLE      0x20
-#define EPP_LEDS              0xC0
-#define EPP_IRQ_ENABLE        0x10
-
-/* Xilinx 4k JTAG instructions */
-#define XC4K_IRLENGTH   3
-#define XC4K_EXTEST     0
-#define XC4K_PRELOAD    1
-#define XC4K_CONFIGURE  5
-#define XC4K_BYPASS     7
 
 #define EPP_CONVENTIONAL  0
 #define EPP_FPGA          1
-#define EPP_FPGAEXTSTATUS 2
 
-#define TXBUFFER_SIZE     ((HDLCDRV_MAXFLEN*6/5)+8)
+#define EPP_XFER_FLAGS	PARPORT_EPP_FAST
+
+#define TXBUFFER_SIZE	((HDLCDRV_MAXFLEN*6/5)+8)
 
 /* ---------------------------------------------------------------------- */
 /*
@@ -171,7 +116,6 @@ struct baycom_state {
 
         struct pardevice *pdev;
 	struct net_device *dev;
-	unsigned int work_running;
 	struct delayed_work run_work;
 	unsigned int modem;
 	unsigned int bitrate;
@@ -186,6 +130,7 @@ struct baycom_state {
 	} cfg;
 
         struct hdlcdrv_channel_params ch_params;
+	enum { rx_idle = 0, rx_receive, rx_flush } rx_state;
 
         struct {
 		unsigned int bitbuf, bitstream, numbits, state;
@@ -206,18 +151,7 @@ struct baycom_state {
 
 	unsigned int ptt_keyed;
 	struct sk_buff *skb;  /* next transmit packet  */
-
-#ifdef BAYCOM_DEBUG
-	struct debug_vals {
-		unsigned long last_jiffies;
-		unsigned cur_intcnt;
-		unsigned last_intcnt;
-		int cur_pllcorr;
-		int last_pllcorr;
-		unsigned int mod_cycles;
-		unsigned int demod_cycles;
-	} debug_vals;
-#endif /* BAYCOM_DEBUG */
+	spinlock_t lock;
 };
 
 /* --------------------------------------------------------------------- */
@@ -243,21 +177,6 @@ struct baycom_state {
 
 /*---------------------------------------------------------------------------*/
 
-#if 0
-static inline void append_crc_ccitt(unsigned char *buffer, int len)
-{
- 	unsigned int crc = 0xffff;
-
-	for (;len>0;len--)
-		crc = (crc >> 8) ^ crc_ccitt_table[(crc ^ *buffer++) & 0xff];
-	crc ^= 0xffff;
-	*buffer++ = crc;
-	*buffer++ = crc >> 8;
-}
-#endif
-
-/*---------------------------------------------------------------------------*/
-
 static inline int check_crc_ccitt(const unsigned char *buf, int cnt)
 {
 	return (crc_ccitt(0xffff, buf, cnt) & 0xffff) == 0xf0b8;
@@ -274,26 +193,6 @@ static inline int calc_crc_ccitt(const unsigned char *buf, int cnt)
 
 #define tenms_to_flags(bc,tenms) ((tenms * bc->bitrate) / 800)
 
-/* --------------------------------------------------------------------- */
-
-static inline void baycom_int_freq(struct baycom_state *bc)
-{
-#ifdef BAYCOM_DEBUG
-	unsigned long cur_jiffies = jiffies;
-	/*
-	 * measure the interrupt frequency
-	 */
-	bc->debug_vals.cur_intcnt++;
-	if (time_after_eq(cur_jiffies, bc->debug_vals.last_jiffies + HZ)) {
-		bc->debug_vals.last_jiffies = cur_jiffies;
-		bc->debug_vals.last_intcnt = bc->debug_vals.cur_intcnt;
-		bc->debug_vals.cur_intcnt = 0;
-		bc->debug_vals.last_pllcorr = bc->debug_vals.cur_pllcorr;
-		bc->debug_vals.cur_pllcorr = 0;
-	}
-#endif /* BAYCOM_DEBUG */
-}
-
 /* ---------------------------------------------------------------------- */
 /*
  *    eppconfig_path should be setable  via /proc/sys.
@@ -337,6 +236,7 @@ static inline void do_kiss_params(struct baycom_state *bc,
 
 	if (len < 2)
 		return;
+	spin_lock_bh(&bc->lock);
 	switch(data[0]) {
 	case PARAM_TXDELAY:
 		bc->ch_params.tx_delay = data[1];
@@ -361,6 +261,7 @@ static inline void do_kiss_params(struct baycom_state *bc,
 	default:
 		break;
 	}
+	spin_unlock_bh(&bc->lock);
 #undef PKP
 }
 
@@ -442,7 +343,7 @@ static int transmit(struct baycom_state *bc, int cnt, unsigned char stat)
 		if (bc->hdlctx.bufcnt <= 0)
 			return 0;
 		if (!bc->ch_params.fulldup) {
-			if (!(stat & EPP_DCDBIT)) {
+			if (!(stat & EPP_DCDBIT) || (bc->rx_state != rx_idle)) {
 				bc->hdlctx.slotcnt = bc->ch_params.slottime;
 				return 0;
 			}
@@ -469,7 +370,7 @@ static int transmit(struct baycom_state *bc, int cnt, unsigned char stat)
 			memset(tmp, 0x7e, sizeof(tmp));
 			while (i > 0) {
 				j = (i > sizeof(tmp)) ? sizeof(tmp) : i;
-				if (j != pp->ops->epp_write_data(pp, tmp, j, 0))
+				if (j != pp->ops->epp_write_data(pp, tmp, j, EPP_XFER_FLAGS))
 					return -1;
 				i -= j;
 			}
@@ -487,7 +388,7 @@ static int transmit(struct baycom_state *bc, int cnt, unsigned char stat)
 			i = min_t(int, cnt, bc->hdlctx.bufcnt);
 			bc->hdlctx.bufcnt -= i;
 			cnt -= i;
-			if (i != pp->ops->epp_write_data(pp, bc->hdlctx.bufptr, i, 0))
+			if (i != pp->ops->epp_write_data(pp, bc->hdlctx.bufptr, i, EPP_XFER_FLAGS))
 					return -1;
 			bc->hdlctx.bufptr += i;
 			break;
@@ -505,7 +406,7 @@ static int transmit(struct baycom_state *bc, int cnt, unsigned char stat)
 				memset(tmp, 0x7e, sizeof(tmp));
 				while (i > 0) {
 					j = (i > sizeof(tmp)) ? sizeof(tmp) : i;
-					if (j != pp->ops->epp_write_data(pp, tmp, j, 0))
+					if (j != pp->ops->epp_write_data(pp, tmp, j, EPP_XFER_FLAGS))
 						return -1;
 					i -= j;
 				}
@@ -521,7 +422,7 @@ static int transmit(struct baycom_state *bc, int cnt, unsigned char stat)
 			memset(tmp, 0, sizeof(tmp));
 			while (i > 0) {
 				j = (i > sizeof(tmp)) ? sizeof(tmp) : i;
-				if (j != pp->ops->epp_write_data(pp, tmp, j, 0))
+				if (j != pp->ops->epp_write_data(pp, tmp, j, EPP_XFER_FLAGS))
 					return -1;
 				i -= j;
 			}
@@ -575,7 +476,7 @@ static int receive(struct net_device *dev, int cnt)
 	while (cnt > 0) {
 		cnt2 = (cnt > sizeof(tmp)) ? sizeof(tmp) : cnt;
 		cnt -= cnt2;
-		if (cnt2 != pp->ops->epp_read_data(pp, tmp, cnt2, 0)) {
+		if (cnt2 != pp->ops->epp_read_data(pp, tmp, cnt2, EPP_XFER_FLAGS)) {
 			ret = -1;
 			break;
 		}
@@ -633,17 +534,6 @@ static int receive(struct net_device *dev, int cnt)
 
 /* --------------------------------------------------------------------- */
 
-#ifdef __i386__
-#include <asm/msr.h>
-#define GETTICK(x)                                                \
-({                                                                \
-	if (cpu_has_tsc)                                          \
-		rdtscl(x);                                        \
-})
-#else /* __i386__ */
-#define GETTICK(x)
-#endif /* __i386__ */
-
 static void epp_bh(struct work_struct *work)
 {
 	struct net_device *dev;
@@ -651,22 +541,17 @@ static void epp_bh(struct work_struct *work)
 	struct parport *pp;
 	unsigned char stat;
 	unsigned char tmp[2];
-	unsigned int time1 = 0, time2 = 0, time3 = 0;
 	int cnt, cnt2;
 
 	bc = container_of(work, struct baycom_state, run_work.work);
+	spin_lock_bh(&bc->lock);
 	dev = bc->dev;
-	if (!bc->work_running)
-		return;
-	baycom_int_freq(bc);
 	pp = bc->pdev->port;
 	/* update status */
 	if (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)
 		goto epptimeout;
 	bc->stat = stat;
-	bc->debug_vals.last_pllcorr = stat;
-	GETTICK(time1);
-	if (bc->modem == EPP_FPGAEXTSTATUS) {
+	if (bc->modem == EPP_FPGA) {
 		/* get input count */
 		tmp[0] = EPP_TX_FIFO_ENABLE|EPP_RX_FIFO_ENABLE|EPP_MODEM_ENABLE|1;
 		if (pp->ops->epp_write_addr(pp, tmp, 1, 0) != 1)
@@ -689,36 +574,52 @@ static void epp_bh(struct work_struct *work)
 			goto epptimeout;
 		if (transmit(bc, cnt2, stat))
 			goto epptimeout;
-		GETTICK(time2);
 		if (receive(dev, cnt))
 			goto epptimeout;
-		if (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)
-			goto epptimeout;
-		bc->stat = stat;
 	} else {
-		/* try to tx */
+		/* try to TX */
 		switch (stat & (EPP_NTAEF|EPP_NTHF)) {
 		case EPP_NTHF:
 			cnt = 2048 - 256;
 			break;
-		
+
 		case EPP_NTAEF:
 			cnt = 2048 - 1793;
 			break;
-		
+
 		case 0:
 			cnt = 0;
 			break;
-		
+
 		default:
 			cnt = 2048 - 1025;
 			break;
 		}
 		if (transmit(bc, cnt, stat))
 			goto epptimeout;
-		GETTICK(time2);
 		/* do receiver */
 		while ((stat & (EPP_NRAEF|EPP_NRHF)) != EPP_NRHF) {
+			/* FIFO fill state accuracy work-around: */
+			/* When the channel is free, we further read */
+			/* one block to assure that the last frame has */
+			/* been completely flushed before we tell the */
+			/* TX that the channel is free */
+			if (stat & EPP_DCDBIT) {
+				switch (bc->rx_state) {
+				case rx_receive:
+					bc->rx_state = rx_flush;
+					break;
+
+				case rx_flush:
+					bc->rx_state = rx_idle;
+					break;
+
+				case rx_idle:
+					break;
+				}
+			} else
+				bc->rx_state = rx_receive;
+			/* guess RX block size */
 			switch (stat & (EPP_NRAEF|EPP_NRHF)) {
 			case EPP_NRAEF:
 				cnt = 1025;
@@ -737,29 +638,15 @@ static void epp_bh(struct work_struct *work)
 			if (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)
 				goto epptimeout;
 		}
-		cnt = 0;
-		if (bc->bitrate < 50000)
-			cnt = 256;
-		else if (bc->bitrate < 100000)
-			cnt = 128;
-		while (cnt > 0 && stat & EPP_NREF) {
-			if (receive(dev, 1))
-				goto epptimeout;
-			cnt--;
-			if (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)
-				goto epptimeout;
-		}
 	}
-	GETTICK(time3);
-#ifdef BAYCOM_DEBUG
-	bc->debug_vals.mod_cycles = time2 - time1;
-	bc->debug_vals.demod_cycles = time3 - time2;
-#endif /* BAYCOM_DEBUG */
-	schedule_delayed_work(&bc->run_work, 1);
 	if (!bc->skb)
 		netif_wake_queue(dev);
+	schedule_delayed_work(&bc->run_work, 1);
+	spin_unlock_bh(&bc->lock);
 	return;
+
  epptimeout:
+ 	spin_unlock_bh(&bc->lock);
 	printk(KERN_ERR "%s: EPP timeout!\n", bc_drvname);
 }
 
@@ -777,15 +664,19 @@ static int baycom_send_packet(struct sk_buff *skb, struct net_device *dev)
 		dev_kfree_skb(skb);
 		return NETDEV_TX_OK;
 	}
+	
 	if (bc->skb)
 		return NETDEV_TX_LOCKED;
+		
 	/* strip KISS byte */
 	if (skb->len >= HDLCDRV_MAXFLEN+1 || skb->len < 3) {
 		dev_kfree_skb(skb);
 		return NETDEV_TX_OK;
 	}
+	spin_lock_bh(&bc->lock);
 	netif_stop_queue(dev);
 	bc->skb = skb;
+	spin_unlock_bh(&bc->lock);
 	return NETDEV_TX_OK;
 }
 
@@ -836,20 +727,12 @@ static int epp_open(struct net_device *dev)
                 printk(KERN_ERR "%s: parport at 0x%lx unknown\n", bc_drvname, dev->base_addr);
                 return -ENXIO;
         }
-#if 0
-        if (pp->irq < 0) {
-                printk(KERN_ERR "%s: parport at 0x%lx has no irq\n", bc_drvname, pp->base);
-		parport_put_port(pp);
-                return -ENXIO;
-        }
-#endif
 	if ((~pp->modes) & (PARPORT_MODE_TRISTATE | PARPORT_MODE_PCSPP | PARPORT_MODE_SAFEININT)) {
                 printk(KERN_ERR "%s: parport at 0x%lx cannot be used\n",
 		       bc_drvname, pp->base);
 		parport_put_port(pp);
                 return -EIO;
 	}
-	memset(&bc->modem, 0, sizeof(bc->modem));
         bc->pdev = parport_register_device(pp, dev->name, NULL, epp_wakeup, 
 					   NULL, PARPORT_DEV_EXCL, dev);
 	parport_put_port(pp);
@@ -862,15 +745,13 @@ static int epp_open(struct net_device *dev)
                 parport_unregister_device(bc->pdev);
                 return -EBUSY;
         }
-        dev->irq = /*pp->irq*/ 0;
-	INIT_DELAYED_WORK(&bc->run_work, epp_bh);
-	bc->work_running = 1;
 	bc->modem = EPP_CONVENTIONAL;
 	if (eppconfig(bc))
 		printk(KERN_INFO "%s: no FPGA detected, assuming conventional EPP modem\n", bc_drvname);
 	else
-		bc->modem = /*EPP_FPGA*/ EPP_FPGAEXTSTATUS;
-	parport_write_control(pp, LPTCTRL_PROGRAM); /* prepare EPP mode; we aren't using interrupts */
+		bc->modem = EPP_FPGA;
+	/* prepare EPP mode; we aren't using interrupts */		
+	parport_write_control(pp, PARPORT_CONTROL_INIT);
 	/* reset the modem */
 	tmp[0] = 0;
 	tmp[1] = EPP_TX_FIFO_ENABLE|EPP_RX_FIFO_ENABLE|EPP_MODEM_ENABLE;
@@ -886,9 +767,9 @@ static int epp_open(struct net_device *dev)
 			schedule();
 			continue;
 		}
-		if (pp->ops->epp_read_data(pp, tmp, 128, 0) != 128)
+		if (pp->ops->epp_read_data(pp, tmp, 128, EPP_XFER_FLAGS) != 128)
 			goto epptimeout;
-		if (pp->ops->epp_read_data(pp, tmp, 128, 0) != 128)
+		if (pp->ops->epp_read_data(pp, tmp, 128, EPP_XFER_FLAGS) != 128)
 			goto epptimeout;
 		i += 256;
 	}
@@ -914,9 +795,9 @@ static int epp_open(struct net_device *dev)
 	tmp[0] = EPP_TX_FIFO_ENABLE|EPP_RX_FIFO_ENABLE|EPP_MODEM_ENABLE/*|j*/;
 	if (pp->ops->epp_write_addr(pp, tmp, 1, 0) != 1)
 		goto epptimeout;
-	/*
-	 * initialise hdlc variables
-	 */
+        /* reset RX buffer handling */
+        bc->rx_state = rx_idle;
+	/* initialise hdlc variables */
 	bc->hdlcrx.state = 0;
 	bc->hdlcrx.numbits = 0;
 	bc->hdlctx.state = tx_idle;
@@ -924,8 +805,9 @@ static int epp_open(struct net_device *dev)
 	bc->hdlctx.slotcnt = bc->ch_params.slottime;
 	bc->hdlctx.calibrate = 0;
 	/* start the bottom half stuff */
-	schedule_delayed_work(&bc->run_work, 1);
 	netif_start_queue(dev);
+	INIT_DELAYED_WORK(&bc->run_work, epp_bh);
+	schedule_delayed_work(&bc->run_work, 1);
 	return 0;
 
  epptimeout:
@@ -944,19 +826,20 @@ static int epp_close(struct net_device *dev)
 	struct parport *pp = bc->pdev->port;
 	unsigned char tmp[1];
 
-	bc->work_running = 0;
+	spin_lock_bh(&bc->lock);
 	cancel_delayed_work_sync(&bc->run_work);
+	if (bc->skb)
+		dev_kfree_skb(bc->skb);
+	bc->skb = NULL;
 	bc->stat = EPP_DCDBIT;
+	spin_unlock_bh(&bc->lock);	
 	tmp[0] = 0;
 	pp->ops->epp_write_addr(pp, tmp, 1, 0);
 	parport_write_control(pp, 0); /* reset the adapter */
         parport_release(bc->pdev);
         parport_unregister_device(bc->pdev);
-	if (bc->skb)
-		dev_kfree_skb(bc->skb);
-	bc->skb = NULL;
-	printk(KERN_INFO "%s: close epp at iobase 0x%lx irq %u\n",
-	       bc_drvname, dev->base_addr, dev->irq);
+	printk(KERN_INFO "%s: close parport at 0x%lx\n",
+	       bc_drvname, dev->base_addr);
 	return 0;
 }
 
@@ -966,6 +849,7 @@ static int baycom_setmode(struct baycom_state *bc, const char *modestr)
 {
 	const char *cp;
 
+	spin_lock_bh(&bc->lock);
 	if (strstr(modestr,"intclk"))
 		bc->cfg.intclk = 1;
 	if (strstr(modestr,"extclk"))
@@ -992,6 +876,7 @@ static int baycom_setmode(struct baycom_state *bc, const char *modestr)
 		if (bc->cfg.bps > 1500000)
 			bc->cfg.bps = 1500000;
 	}
+	spin_unlock_bh(&bc->lock);
 	return 0;
 }
 
@@ -1012,28 +897,32 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 		return -ENOIOCTLCMD;
 
 	case HDLCDRVCTL_GETCHANNELPAR:
+		spin_lock_bh(&bc->lock);
 		hi.data.cp.tx_delay = bc->ch_params.tx_delay;
 		hi.data.cp.tx_tail = bc->ch_params.tx_tail;
 		hi.data.cp.slottime = bc->ch_params.slottime;
 		hi.data.cp.ppersist = bc->ch_params.ppersist;
 		hi.data.cp.fulldup = bc->ch_params.fulldup;
+		spin_unlock_bh(&bc->lock);
 		break;
 
 	case HDLCDRVCTL_SETCHANNELPAR:
 		if (!capable(CAP_NET_ADMIN))
 			return -EACCES;
+		spin_lock_bh(&bc->lock);
 		bc->ch_params.tx_delay = hi.data.cp.tx_delay;
 		bc->ch_params.tx_tail = hi.data.cp.tx_tail;
 		bc->ch_params.slottime = hi.data.cp.slottime;
 		bc->ch_params.ppersist = hi.data.cp.ppersist;
 		bc->ch_params.fulldup = hi.data.cp.fulldup;
 		bc->hdlctx.slotcnt = 1;
+		spin_unlock_bh(&bc->lock);
 		return 0;
 		
 	case HDLCDRVCTL_GETMODEMPAR:
 		hi.data.mp.iobase = dev->base_addr;
-		hi.data.mp.irq = dev->irq;
-		hi.data.mp.dma = dev->dma;
+		hi.data.mp.irq = 0;
+		hi.data.mp.dma = 0;
 		hi.data.mp.dma2 = 0;
 		hi.data.mp.seriobase = 0;
 		hi.data.mp.pariobase = 0;
@@ -1041,14 +930,12 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 		break;
 
 	case HDLCDRVCTL_SETMODEMPAR:
-		if ((!capable(CAP_SYS_RAWIO)) || netif_running(dev))
+		if (!capable(CAP_SYS_RAWIO))
 			return -EACCES;
-		dev->base_addr = hi.data.mp.iobase;
-		dev->irq = /*hi.data.mp.irq*/0;
-		dev->dma = /*hi.data.mp.dma*/0;
 		return 0;	
 		
 	case HDLCDRVCTL_GETSTAT:
+		spin_lock_bh(&bc->lock);
 		hi.data.cs.ptt = !!(bc->stat & EPP_PTTBIT);
 		hi.data.cs.dcd = !(bc->stat & EPP_DCDBIT);
 		hi.data.cs.ptt_keyed = bc->ptt_keyed;
@@ -1056,18 +943,23 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 		hi.data.cs.tx_errors = dev->stats.tx_errors;
 		hi.data.cs.rx_packets = dev->stats.rx_packets;
 		hi.data.cs.rx_errors = dev->stats.rx_errors;
+		spin_unlock_bh(&bc->lock);
 		break;		
 
 	case HDLCDRVCTL_OLDGETSTAT:
+		spin_lock_bh(&bc->lock);
 		hi.data.ocs.ptt = !!(bc->stat & EPP_PTTBIT);
 		hi.data.ocs.dcd = !(bc->stat & EPP_DCDBIT);
 		hi.data.ocs.ptt_keyed = bc->ptt_keyed;
+		spin_unlock_bh(&bc->lock);
 		break;		
 
 	case HDLCDRVCTL_CALIBRATE:
 		if (!capable(CAP_SYS_RAWIO))
 			return -EACCES;
+		spin_lock_bh(&bc->lock);
 		bc->hdlctx.calibrate = hi.data.calibrate * bc->bitrate / 8;
+		spin_unlock_bh(&bc->lock);
 		return 0;
 
 	case HDLCDRVCTL_DRIVERNAME:
@@ -1104,46 +996,59 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 /* --------------------------------------------------------------------- */
 
 static const struct net_device_ops baycom_netdev_ops = {
-	.ndo_open	     = epp_open,
-	.ndo_stop	     = epp_close,
-	.ndo_do_ioctl	     = baycom_ioctl,
+	.ndo_open            = epp_open,
+	.ndo_stop            = epp_close,
+	.ndo_do_ioctl        = baycom_ioctl,
 	.ndo_start_xmit      = baycom_send_packet,
 	.ndo_set_mac_address = baycom_set_mac_address,
 };
 
+/* --------------------------------------------------------------------- */
+
 /*
- * Check for a network adaptor of this type, and return '0' if one exists.
- * If dev->base_addr == 0, probe all likely locations.
- * If dev->base_addr == 1, always return failure.
- * If dev->base_addr == 2, allocate space for the device and return success
- * (detachable devices only).
+ * command line settable parameters
  */
-static void baycom_probe(struct net_device *dev)
+static const char *mode[NR_PORTS] = { "", "", "", "", };
+static int parport[NR_PORTS] = { 0, 1, 2, 3, };
+
+module_param_array(mode, charp, NULL, 0);
+MODULE_PARM_DESC(mode, "baycom operating mode");
+module_param_array(parport, int, NULL, 0);
+MODULE_PARM_DESC(parport, "baycom parport number");
+
+MODULE_AUTHOR("Thomas M. Sailer, sailer@ife.ee.ethz.ch");
+MODULE_DESCRIPTION("Baycom epp amateur radio modem driver");
+MODULE_LICENSE("GPL");
+
+/* --------------------------------------------------------------------- */
+
+static void __init baycom_epp_dev_setup(struct net_device *dev)
 {
 	const struct hdlcdrv_channel_params dflt_ch_params = { 
 		20, 2, 10, 40, 0 
 	};
-	struct baycom_state *bc;
+	struct baycom_state *bc = netdev_priv(dev);
 
 	/*
-	 * not a real probe! only initialize data structures
-	 */
-	bc = netdev_priv(dev);
-	/*
-	 * initialize the baycom_state struct
+	 * initialize part of the baycom_state struct
 	 */
+	bc->dev = dev;
+	bc->magic = BAYCOM_MAGIC;
+	bc->cfg.fclk = 19666600;
+	bc->cfg.bps = 9600;
 	bc->ch_params = dflt_ch_params;
 	bc->ptt_keyed = 0;
 
 	/*
 	 * initialize the device struct
 	 */
+	spin_lock_init(&bc->lock);
 
 	/* Fill in the fields of the device structure */
 	bc->skb = NULL;
 	
-	dev->netdev_ops = &baycom_netdev_ops;
 	dev->header_ops = &ax25_header_ops;
+	dev->netdev_ops = &baycom_netdev_ops;
 	
 	dev->type = ARPHRD_AX25;           /* AF_AX25 device */
 	dev->hard_header_len = AX25_MAX_HEADER_LEN + AX25_BPQ_HEADER_LEN;
@@ -1157,42 +1062,6 @@ static void baycom_probe(struct net_device *dev)
 	dev->flags = 0;
 }
 
-/* --------------------------------------------------------------------- */
-
-/*
- * command line settable parameters
- */
-static const char *mode[NR_PORTS] = { "", };
-static int iobase[NR_PORTS] = { 0x378, };
-
-module_param_array(mode, charp, NULL, 0);
-MODULE_PARM_DESC(mode, "baycom operating mode");
-module_param_array(iobase, int, NULL, 0);
-MODULE_PARM_DESC(iobase, "baycom io base address");
-
-MODULE_AUTHOR("Thomas M. Sailer, sailer@ife.ee.ethz.ch, hb9jnx@hb9w.che.eu");
-MODULE_DESCRIPTION("Baycom epp amateur radio modem driver");
-MODULE_LICENSE("GPL");
-
-/* --------------------------------------------------------------------- */
-
-static void __init baycom_epp_dev_setup(struct net_device *dev)
-{
-	struct baycom_state *bc = netdev_priv(dev);
-
-	/*
-	 * initialize part of the baycom_state struct
-	 */
-	bc->dev = dev;
-	bc->magic = BAYCOM_MAGIC;
-	bc->cfg.fclk = 19666600;
-	bc->cfg.bps = 9600;
-	/*
-	 * initialize part of the device struct
-	 */
-	baycom_probe(dev);
-}
-
 static int __init init_baycomepp(void)
 {
 	int i, found = 0;
@@ -1203,6 +1072,7 @@ static int __init init_baycomepp(void)
 	 * register net devices
 	 */
 	for (i = 0; i < NR_PORTS; i++) {
+		struct parport *pp = parport_find_number(parport[i]);
 		struct net_device *dev;
 		
 		dev = alloc_netdev(sizeof(struct baycom_state), "bce%d",
@@ -1212,14 +1082,12 @@ static int __init init_baycomepp(void)
 			printk(KERN_WARNING "bce%d : out of memory\n", i);
 			return found ? 0 : -ENOMEM;
 		}
-			
+		
 		sprintf(dev->name, "bce%d", i);
-		dev->base_addr = iobase[i];
+		dev->base_addr = pp ? pp->base : 0;
 
-		if (!mode[i])
+		if (!pp || !mode[i])
 			set_hw = 0;
-		if (!set_hw)
-			iobase[i] = 0;
 
 		if (register_netdev(dev)) {
 			printk(KERN_WARNING "%s: cannot register net device %s\n", bc_drvname, dev->name);
@@ -1261,7 +1129,7 @@ module_exit(cleanup_baycomepp);
 #ifndef MODULE
 
 /*
- * format: baycom_epp=io,mode
+ * format: baycom_epp=parport,mode
  * mode: fpga config options
  */
 
@@ -1272,11 +1140,11 @@ static int __init baycom_epp_setup(char *str)
 
         if (nr_dev >= NR_PORTS)
                 return 0;
-	str = get_options(str, 2, ints);
+	str = get_options(str, ARRAY_SIZE(ints), ints);
 	if (ints[0] < 1)
 		return 0;
 	mode[nr_dev] = str;
-	iobase[nr_dev] = ints[1];
+	parport[nr_dev] = ints[1];
 	nr_dev++;
 	return 1;
 }

^ permalink raw reply related

* Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls
From: David Miller @ 2011-12-13 18:45 UTC (permalink / raw)
  To: eric.dumazet
  Cc: christoph.paasch, glommer, linux-kernel, paul, lizf,
	kamezawa.hiroyu, ebiederm, gthelen, netdev, linux-mm, kirill,
	avagin, devel, cgroups
In-Reply-To: <1323784748.2950.4.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 13 Dec 2011 14:59:08 +0100

> [PATCH net-next] net: fix build error if CONFIG_CGROUPS=n
> 
> Reported-by: Christoph Paasch <christoph.paasch@uclouvain.be>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied, thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply

* Re: kernel 3.1.1 message:  <IRQ> warn_alloc_failed
From: Stephen Hemminger @ 2011-12-13 18:41 UTC (permalink / raw)
  To: Rajesh Borundia; +Cc: starlight@binnacle.cx, Sony Chacko, linux-kernel, netdev
In-Reply-To: <13A253B3F9BEFE43B93C09CF75F63CAA8162593365@MNEXMB1.qlogic.org>

On Tue, 13 Dec 2011 11:42:13 -0600
Rajesh Borundia <rajesh.borundia@qlogic.com> wrote:

> Hi All,
> 
> Sorry for late reply.
> 
> Stephan,
> Thanks for analyzing.
> 
> Yes, the netxen adapter does not support fragmented page memory.
> They are not harmful messages. At that instant of time it may fail allocating
> memory for some buffers in the ring but after enough memory is available
> it will try to allocate memory for unallocated buffers in ring.
> 
> Or the other option could be to turn LRO off.
> 
> Rajesh  
> 
> ________________________________________
> From: starlight@binnacle.cx [starlight@binnacle.cx]
> Sent: Friday, December 09, 2011 11:33 PM
> To: Stephen Hemminger; Sony Chacko; Rajesh Borundia
> Cc: linux-kernel; netdev
> Subject: Re: kernel 3.1.1 message:  <IRQ> warn_alloc_failed
> 
> At 09:50 AM 12/9/2011 -0800, Stephen Hemminger wrote:
> >On Thu, 08 Dec 2011 21:10:02 -0500 starlight@binnacle.cx wrote:
> >
> >You are seeing memory allocation failures because device
> >is allocating a 16K (order 2) size socket buffer. You are using
> >netxen device, and it looks like the problem.
> >
> >From reading the netxen driver source. The LRO buffers
> >in this device are very large (8060+skb overhead).
> >Until the driver is fixed to use fragmented page size memory,
> >I recommend turning off LRO.
> 
> Thank you for the analysis.  As an alternative
> would it make sense to double or quadruple
> 
>     /proc/sys/vm/min_free_kbytes
> 
> or perhaps do the same for
> 
>     /proc/slabinfo(size-16384)
> 

The driver should be changed to call allocation with __GFP_NOWARN.
Change dev_alloc_skb(size) to
  __dev_alloc_skb(size, GFP_ATOMIC|__GFP_NOWARN)

Or better yet, switch to using netdev_alloc variant like
  __netdev_alloc_skb_ip_align(dev, length, GFP_ATOMIC|__GFP_NOWARN)

^ permalink raw reply

* Re: Driver for embedded switch Micrel KS8995MA
From: Florian Fainelli @ 2011-12-13 18:37 UTC (permalink / raw)
  To: Frederic LAMBERT; +Cc: netdev, juhosg
In-Reply-To: <CAMVnO+nbtJjyjKXVnQz__A+91cUb6P7VSpkd=f67L1G=rP-dag@mail.gmail.com>

Hello,

On 12/13/11 19:33, Frederic LAMBERT wrote:
> I found an quite old driver on the net for the 5-ports 10/100 embedded
> switch Micrel KS8995MA.
> It had to be updated a little bit because a parameter was missing to
> the ks8995_registers_read()&  write() functions.
>
> I haven't been able to contact its original author, Gabor Juhos, who
> wrote it in 2008 under GPL v2.

Gabor is responding pretty quickly in general. You are talking about 
this particular driver?

https://dev.openwrt.org/browser/trunk/package/spi-ks8995/src/spi_ks8995.c

>
> Is it possible to submit this driver as a patch to be included in the
> distribution?
> If yes, what would be the best place? driver/net/phy? driver/net/ethernet?

drivers/net/phy is the most appropriate place since it's a switch driver 
but you certainly want to get in touch with Gabor to deal with this 
driver inclusion first.
--
Florian

^ permalink raw reply

* Re: kenel level packet capturing
From: David Miller @ 2011-12-13 18:36 UTC (permalink / raw)
  To: raviraj.j1991; +Cc: netdev, netfilter-devel, netfilter
In-Reply-To: <CAKj1SsOra7u21u8Zq9rDLzv_Bhx8sPsah+SHByMYQbVc_j6LQA@mail.gmail.com>

From: raviraj joshi <raviraj.j1991@gmail.com>
Date: Tue, 13 Dec 2011 17:34:22 +0530

> We have decided to use PF_RING(a kernel module to capture packets) for
> the same due to the number of advantages.

What "advantages"?  The AF_PACKET socket layer already upstream in the
kernel supports every relevant performance feature PF_RING does, and
then some.

^ permalink raw reply

* Re: [PATCH net-next 2/2] be2net: refactor/cleanup vf configuration code
From: David Miller @ 2011-12-13 18:34 UTC (permalink / raw)
  To: sathya.perla; +Cc: netdev
In-Reply-To: <1323773930-6617-2-git-send-email-sathya.perla@emulex.com>

From: Sathya Perla <sathya.perla@emulex.com>
Date: Tue, 13 Dec 2011 16:28:50 +0530

> - use adapter->num_vfs (and not the module param) to store the actual
> number of vfs created. Use the same variable to reflect SRIOV
> enable/disable state. So, drop the adapter->sriov_enabled field.
> 
> - use for_all_vfs() macro in VF configuration code
> 
> - drop the "vf_" prefix for the fields of be_vf_cfg; the prefix is
> redundant and removing it helps reduce line wrap
> 
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>

Applied.

^ permalink raw reply

* Re: [PATCH net-next 1/2] be2net: fix ethtool ringparam reporting
From: David Miller @ 2011-12-13 18:34 UTC (permalink / raw)
  To: sathya.perla; +Cc: netdev
In-Reply-To: <1323773930-6617-1-git-send-email-sathya.perla@emulex.com>

From: Sathya Perla <sathya.perla@emulex.com>
Date: Tue, 13 Dec 2011 16:28:49 +0530

> The ethtool "-g" option is supposed to report the max queue length and
> user modified queue length for RX and TX queues.  be2net doesn't support
> user modification of queue lengths. So, the correct values for these
> would be the max numbers.
> be2net incorrectly reports the queue used values for these fields.
> 
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>

Applied.

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox