* Re: [PATCH] tg3: Make the RSS indir tbl admin configurable
From: Ben Hutchings @ 2011-12-16 19:43 UTC (permalink / raw)
To: Matt Carlson; +Cc: davem@davemloft.net, netdev@vger.kernel.org, Michael Chan
In-Reply-To: <20111216191927.GA9054@mcarlson.broadcom.com>
On Fri, 2011-12-16 at 11:19 -0800, Matt Carlson wrote:
> On Thu, Dec 15, 2011 at 07:04:34PM -0800, Ben Hutchings wrote:
> > On Thu, 2011-12-15 at 16:47 -0800, Matt Carlson wrote:
> > > This patch adds the ethtool callbacks necessary to change the rss
> > > indirection table from userspace. When setting the indirection table
> > > through set_rxfh_indir, an indirection table size of zero is
> > > interpreted to mean that the admin wants to relinquish control of the
> > > table to the driver. Should the number of interrupts change (e.g.
> > > across a close / open call, or through a reset), any indirection table
> > > values that exceed the number of RSS queues or interrupt vectors will
> > > be automatically scaled back to values within range.
> > >
> > > Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> > > Signed-off-by: Michael Chan <mchan@broadcom.com>
> > > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> >
> > No I didn't!
> >
> > Ben.
>
> Sorry. This part of procedure I'm unsure about. I didn't want to lose
> the ack of your contributions to this patch. The SOB does imply that
> you are O.K. with it as-is though, which you may or may not be aligned
> with. I apologize if I was putting words in your mouth.
>
> What should I have done instead? Would Dave put the SOB on your behalf
> as he accepts it?
[...]
If you really want to credit me for the tiny change I suggested, just
put that in free-form. But I'm afraid you'll have to respin this
completely, as David applied my changes to centralise validation and the
default policy. I think instead of adding the USER_INDIR_TBL flag you
could reasonably reset the table to default whenever the interface is
brought up and you fail to get the wanted number of IRQs.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: twice past the taps, thence out to net?
From: Eric Dumazet @ 2011-12-16 19:44 UTC (permalink / raw)
To: Rick Jones
Cc: Stephen Hemminger, Vijay Subramanian, tcpdump-workers, netdev,
Matthew Vick, Jeff Kirsher
In-Reply-To: <4EEB9D64.5080901@hp.com>
Le vendredi 16 décembre 2011 à 11:35 -0800, Rick Jones a écrit :
> I would *love* to. All my accessible igb-driven hardware is in an
> environment locked to the kernels already there :( Not that it makes it
> more possible for me to do it, but I suspect it does not require 30
> receivers to reproduce the dups with netperf TCP_STREAM. Particularly
> if the tx queue len is at 256 it may only take 6 or 8. In fact let me
> try that now...
>
> Yep, with just 8 destinations/concurrent TCP_STREAM tests from the one
> system one can still see the duplicates in the packet trace taken on the
> sender.
>
> Perhaps we can trouble the Intel guys to try to reproduce what I've seen?
>
I do have an igb card somewhere (in fact two dual ports), I'll do the
test myself !
Thanks
^ permalink raw reply
* Re: [PATCH net-next v1 5/6] tg3: implementation of a non-NAPI mode
From: Eric Dumazet @ 2011-12-16 19:50 UTC (permalink / raw)
To: David Decotigny
Cc: Matt Carlson, Michael Chan, netdev, linux-kernel,
Javier Martinez Canillas, Robin Getz, Matt Mackall, Tom Herbert
In-Reply-To: <6d55ce25f5f237a4538f6a2fcd2609b877669297.1324059527.git.decot@googlers.com>
Le vendredi 16 décembre 2011 à 10:19 -0800, David Decotigny a écrit :
> From: Tom Herbert <therbert@google.com>
>
> The tg3 NIC has a hard limit of 511 descriptors for the receive ring.
> Under heavy load of small packets, this device receive queue may not
> be serviced fast enough to prevent packets drops. This could be due
> to a variety of reasons such as lengthy processing delays of packets
> in the stack, softirqs being disabled too long, etc. If the driver is
> run in non-NAPI mode, the RX queue is serviced in the device
> interrupt, which is much less likely to be deferred for a substantial
> period of time.
>
> There are some effects in not using NAPI that need to be considered.
> It does increase the chance of live-lock in interrupt handler,
> although since the tg3 does interrupt coalescing this is very unlikely
> to occur. Also, more code is being run with interrupts disabled
> potentially deferring other hardware interrupts. The amount of time
> spent in the interrupt handler should be minimized by dequeuing
> packets of the device queue and queuing them to a host queue as
> quickly as possible.
>
> The default mode of operation remains NAPI and its performances are
> kept unchanged (code unchanged). Non-NAPI mode is enabled by
> commenting-out CONFIG_TIGON3_NAPI Kconfig parameter.
>
>
Oh well, thats ugly :(
I suspect this was only used with RPS/RFS ?
Or interrupts stick on a given cpu ?
Because with a default setup, and IRQ serviced by multiple cpus, you
endup with possible packet reorderings.
Packet1,2,3,4 handled by CPU0 : queued on netif_rx() queue.
EndOfInterrupt
Packet4,5,6,7 handled by CPU1 : queued on netif_rx() queue.
EndOfInterrupt
CPU0/CPU1 happily merge packets...
^ permalink raw reply
* [PATCH] batman-adv: Fix merge error.
From: David Miller @ 2011-12-16 20:09 UTC (permalink / raw)
To: netdev
I didn't resolve the merge properly during the last pull of the net
tree into net-next.
The code in the final resolution should set flags to TT_CLIENT_ROAM
not TT_CLIENT_PENDING.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/batman-adv/translation-table.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index 46a2b37..ab8dea8 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -244,7 +244,7 @@ void tt_local_add(struct net_device *soft_iface, const uint8_t *addr,
tt_global_entry->orig_node->tt_poss_change = true;
/* The global entry has to be marked as ROAMING and has to be
* kept for consistency purpose */
- tt_global_entry->common.flags |= TT_CLIENT_PENDING;
+ tt_global_entry->common.flags |= TT_CLIENT_ROAM;
tt_global_entry->roam_at = jiffies;
send_roam_adv(bat_priv, tt_global_entry->common.addr,
tt_global_entry->orig_node);
--
1.7.7.4
^ permalink raw reply related
* pull request: sfc-next 2011-12-16
From: Ben Hutchings @ 2011-12-16 20:10 UTC (permalink / raw)
To: David Miller; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
The following changes since commit de93cb2eaffd6d3e44bc738babfac35769d79720:
vlan: static functions (2011-12-14 02:39:30 -0500)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/bwh/sfc-next.git for-davem
(commit 70350b0685a370164ed8912835bd7109927c8781)
Ben Hutchings (3):
MAINTAINERS: Update sfc maintainers
sfc: Remove device ID macros only used once
sfc: Use skb_fill_page_desc() to simplify passing of page buffers to GRO
MAINTAINERS | 1 -
drivers/net/ethernet/sfc/efx.c | 4 ++--
drivers/net/ethernet/sfc/efx.h | 4 ----
drivers/net/ethernet/sfc/rx.c | 7 ++-----
4 files changed, 4 insertions(+), 12 deletions(-)
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* [PATCH net-next 1/3] MAINTAINERS: Update sfc maintainers
From: Ben Hutchings @ 2011-12-16 20:12 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers
In-Reply-To: <1324066213.2798.19.camel@bwh-desktop>
Steve Hodgson has moved on from Solarflare.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
MAINTAINERS | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 209ad06..860a4ce 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5910,7 +5910,6 @@ F: drivers/net/ethernet/emulex/benet/
SFC NETWORK DRIVER
M: Solarflare linux maintainers <linux-net-drivers@solarflare.com>
-M: Steve Hodgson <shodgson@solarflare.com>
M: Ben Hutchings <bhutchings@solarflare.com>
L: netdev@vger.kernel.org
S: Supported
--
1.7.4.4
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [PATCH net-next 2/3] sfc: Remove device ID macros only used once
From: Ben Hutchings @ 2011-12-16 20:12 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers
In-Reply-To: <1324066213.2798.19.camel@bwh-desktop>
The SFC9020/SFL9021 device IDs are only used in the device ID table,
where we can just as well use comments.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/ethernet/sfc/efx.c | 4 ++--
drivers/net/ethernet/sfc/efx.h | 4 ----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 14e134d..9cf3eab 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2235,9 +2235,9 @@ static DEFINE_PCI_DEVICE_TABLE(efx_pci_table) = {
{PCI_DEVICE(PCI_VENDOR_ID_SOLARFLARE,
PCI_DEVICE_ID_SOLARFLARE_SFC4000B),
.driver_data = (unsigned long) &falcon_b0_nic_type},
- {PCI_DEVICE(PCI_VENDOR_ID_SOLARFLARE, BETHPAGE_A_P_DEVID),
+ {PCI_DEVICE(PCI_VENDOR_ID_SOLARFLARE, 0x0803), /* SFC9020 */
.driver_data = (unsigned long) &siena_a0_nic_type},
- {PCI_DEVICE(PCI_VENDOR_ID_SOLARFLARE, SIENA_A_P_DEVID),
+ {PCI_DEVICE(PCI_VENDOR_ID_SOLARFLARE, 0x0813), /* SFL9021 */
.driver_data = (unsigned long) &siena_a0_nic_type},
{0} /* end of list */
};
diff --git a/drivers/net/ethernet/sfc/efx.h b/drivers/net/ethernet/sfc/efx.h
index 4764793..8a5336d 100644
--- a/drivers/net/ethernet/sfc/efx.h
+++ b/drivers/net/ethernet/sfc/efx.h
@@ -14,10 +14,6 @@
#include "net_driver.h"
#include "filter.h"
-/* PCI IDs */
-#define BETHPAGE_A_P_DEVID 0x0803
-#define SIENA_A_P_DEVID 0x0813
-
/* Solarstorm controllers use BAR 0 for I/O space and BAR 2(&3) for memory */
#define EFX_MEM_BAR 2
--
1.7.4.4
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [PATCH net-next 3/3] sfc: Use skb_fill_page_desc() to simplify passing of page buffers to GRO
From: Ben Hutchings @ 2011-12-16 20:12 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers
In-Reply-To: <1324066213.2798.19.camel@bwh-desktop>
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/ethernet/sfc/rx.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c
index 955b149..aca3498 100644
--- a/drivers/net/ethernet/sfc/rx.c
+++ b/drivers/net/ethernet/sfc/rx.c
@@ -479,11 +479,8 @@ static void efx_rx_packet_gro(struct efx_channel *channel,
if (efx->net_dev->features & NETIF_F_RXHASH)
skb->rxhash = efx_rx_buf_hash(eh);
- skb_frag_set_page(skb, 0, page);
- skb_shinfo(skb)->frags[0].page_offset =
- efx_rx_buf_offset(efx, rx_buf);
- skb_frag_size_set(&skb_shinfo(skb)->frags[0], rx_buf->len);
- skb_shinfo(skb)->nr_frags = 1;
+ skb_fill_page_desc(skb, 0, page,
+ efx_rx_buf_offset(efx, rx_buf), rx_buf->len);
skb->len = rx_buf->len;
skb->data_len = rx_buf->len;
--
1.7.4.4
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [GIT] Networking
From: David Miller @ 2011-12-16 20:15 UTC (permalink / raw)
To: torvalds; +Cc: akpm, netdev, linux-kernel
1) IPv6 code checks prefix length of destination address on wrong route, so
anycast handling is never performed.
2) Device name handling in ipip/sit regressed, copy the name into the device
parms after register_netdevice() to fix it. From Ted Feng.
3) Add device ID to btmrvl bluetooth driver, from Bing Zhao.
4) Fix module refcounting in bluetooth cmtp and bnep modules, from
David Herrmann.
5) Leak fix in btusb_send_frame(), from Cong Wang.
6) hci_setup() checks the wrong version field in device structure, fix from
Andrei Emeltchenko.
7) Roaming clients fixes in batman-adv from Antonio Quartulli.
8) Fix regression on single-stream ath9k wireless chips by properly testing
for antenna diversity support, from Felix Fietkau.
9) pptp module double releases socket in bind() error path, from Djalal Harouni.
10) Fix races in wireless TX aggregation start, from Jahannes Berg.
11) Fix SSB bus initialization regression causing data bus errors, from
Hauke Mehrtens.
12) IPV6 erroneously adds a multicast route on the loopback device when it
is brought up, this can cause multicast communication failures depending
upon the order in which devices are brought up. From Li Wei.
13) Use GFP_ATOMIC while holding lock in GRED packet scheduler, fix from Eric
Dumazet.
Please pull, thanks a lot!
The following changes since commit 2cfab8d74ebfbe06ce2947117945c4f45a5915ec:
Merge branch 'drm-intel-fixes' of git://people.freedesktop.org/~keithp/linux (2011-12-16 11:27:56 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
Andrei Emeltchenko (1):
Bluetooth: Correct version check in hci_setup
Andy Fleming (1):
fsl_pq_mdio: Clean up tbi address configuration
Antonio Quartulli (2):
batman-adv: in case of roaming mark the client with TT_CLIENT_ROAM
batman-adv: delete global entry in case of roaming
Bing Zhao (1):
Bluetooth: btmrvl: support Marvell Bluetooth device SD8797
Cong Wang (1):
btusb: fix a memory leak in btusb_send_frame()
David Herrmann (2):
Bluetooth: cmtp: Fix module reference
Bluetooth: bnep: Fix module reference
David S. Miller (2):
Merge branch 'batman-adv/maint' of git://git.open-mesh.org/linux-merge
ipv6: Check dest prefix length on original route not copied one in rt6_alloc_cow().
Djalal Harouni (1):
ppp: fix pptp double release_sock in pptp_bind()
Eric Dumazet (1):
sch_gred: should not use GFP_KERNEL while holding a spinlock
Felix Fietkau (1):
ath9k: fix check for antenna diversity support
Hauke Mehrtens (1):
ssb: fix init regression with SoCs
Johannes Berg (1):
mac80211: fix another race in aggregation start
John W. Linville (2):
Merge branch 'master' of git://git.kernel.org/.../padovan/bluetooth
Merge branch 'master' of git://git.kernel.org/.../linville/wireless into for-davem
Li Wei (1):
ipv6: Fix for adding multicast route for loopback device automatically.
Philipp Dreimann (1):
rtl8192{ce,cu,de,se}: avoid problems because of possible ERFOFF -> ERFSLEEP transition
Shawn Guo (1):
net/fec: fix the use of pdev->id
Ted Feng (1):
ipip, sit: copy parms.name after register_netdevice
drivers/bluetooth/Kconfig | 6 +-
drivers/bluetooth/btmrvl_sdio.c | 15 ++++-
drivers/bluetooth/btusb.c | 3 +-
drivers/net/ethernet/freescale/fec.c | 11 ++-
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 53 +++-------------
drivers/net/ppp/pptp.c | 4 +-
drivers/net/wireless/ath/ath9k/main.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192ce/phy.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192cu/phy.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192de/phy.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192se/phy.c | 2 +-
drivers/ssb/driver_pcicore.c | 8 ++-
net/batman-adv/translation-table.c | 27 +++++++--
net/bluetooth/bnep/core.c | 8 +--
net/bluetooth/cmtp/core.c | 5 +-
net/bluetooth/hci_event.c | 2 +-
net/ipv4/ipip.c | 7 ++-
net/ipv6/addrconf.c | 3 +-
net/ipv6/route.c | 2 +-
net/ipv6/sit.c | 7 ++-
net/mac80211/agg-tx.c | 86 ++++++++++++-------------
net/sched/sch_gred.c | 2 +-
22 files changed, 130 insertions(+), 129 deletions(-)
^ permalink raw reply
* Re: pull request: sfc-next 2011-12-16
From: David Miller @ 2011-12-16 20:24 UTC (permalink / raw)
To: bhutchings; +Cc: netdev
In-Reply-To: <1324066213.2798.19.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 16 Dec 2011 20:10:13 +0000
> The following changes since commit de93cb2eaffd6d3e44bc738babfac35769d79720:
>
> vlan: static functions (2011-12-14 02:39:30 -0500)
>
> are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/bwh/sfc-next.git for-davem
>
> (commit 70350b0685a370164ed8912835bd7109927c8781)
>
> Ben Hutchings (3):
> MAINTAINERS: Update sfc maintainers
> sfc: Remove device ID macros only used once
> sfc: Use skb_fill_page_desc() to simplify passing of page buffers to GRO
Pulled, thanks!
^ permalink raw reply
* re: NFC: Initial LLCP support
From: Dan Carpenter @ 2011-12-16 20:26 UTC (permalink / raw)
To: sameo-VuQAYsv1563Yd54FQh9/CA
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA
Hello Samuel Ortiz,
This is a semi-automatic email about new static checker warnings.
The patch d646960f7986: "NFC: Initial LLCP support" from Dec 14,
2011, leads to the following Smatch complaint:
net/nfc/llcp/sock.c +47 llcp_sock_bind()
warn: variable dereferenced before check 'addr' (see line 45)
net/nfc/llcp/sock.c
44
45 pr_debug("sk %p addr %p family %d\n", sk, addr, addr->sa_family);
^^^^^^^^^^^^^^^
New dereference.
46
47 if (!addr || addr->sa_family != AF_NFC)
^^^^
New check.
48 return -EINVAL;
49
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH] mlx4: Fix compile error when driver is comiled-in
From: David Miller @ 2011-12-16 20:27 UTC (permalink / raw)
To: joerg.roedel; +Cc: yevgenyp, netdev, linux-kernel, sfr
In-Reply-To: <20111215164837.GE2112@amd.com>
From: Joerg Roedel <joerg.roedel@amd.com>
Date: Thu, 15 Dec 2011 17:48:37 +0100
> Testing my iommu-configs against linux-next found a compile error for
> allyesconfig. It only happens when the mlx4 driver is compiled into the
> kernel and not as a module because these two static functions are also
> used in another file. The attached patch fixes it.
>
>>From b993c4448c2ce5447fd24e7d4fce02e633d3222e Mon Sep 17 00:00:00 2001
> From: Joerg Roedel <joerg.roedel@amd.com>
> Date: Thu, 15 Dec 2011 17:30:33 +0100
> Subject: [PATCH 1/2] mlx4: Fix compile error when driver is comiled-in
>
> This patch fixes a compile error that occurs when the driver
> is compile into the kernel and not as a module.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
I wish we detected "exporting symbol marked static" properly.
I'll apply this, thanks!
^ permalink raw reply
* Re: [PATCH] phylib: update mdiobus_alloc() to allocate extra private space
From: David Miller @ 2011-12-16 20:31 UTC (permalink / raw)
To: timur; +Cc: afleming, netdev, linuxppc-dev
In-Reply-To: <1323967895-5205-1-git-send-email-timur@freescale.com>
From: Timur Tabi <timur@freescale.com>
Date: Thu, 15 Dec 2011 10:51:35 -0600
> Augment mdiobus_alloc() to take a parameter indicating the number of extra
> bytes to allocate for private data. Almost all callers of mdiobus_alloc()
> separately allocate a private data structure. By allowing mdiobus_alloc()
> to allocate extra memory, the two allocations can be merged into one.
>
> This patch does not change any of the callers to actually take advantage
> of this feature, however. That change can be made by the individual
> maintainers at their leisure. For now, all callers ask for zero additional
> bytes, which mimics the previous behavior.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Come on...
Not one driver even uses the new facility, and on top of it you edit
all of these drivers for no reason at all.
You could edit only two source files instead of more than 30 by simply
doing:
struct mii_bus *mdiobus_alloc_size(size_t size);
static inline struct mii_bus *mdiobus_alloc(void)
{
return mdiobus_alloc_size(0):
}
^ permalink raw reply
* Re: [PATCH] phylib: update mdiobus_alloc() to allocate extra private space
From: David Miller @ 2011-12-16 20:32 UTC (permalink / raw)
To: timur; +Cc: afleming, netdev, linuxppc-dev
In-Reply-To: <4EEA2A61.8050302@freescale.com>
From: Timur Tabi <timur@freescale.com>
Date: Thu, 15 Dec 2011 11:12:01 -0600
> Andy Fleming wrote:
>> Why? Doesn't this just obfuscate things a little, while providing no immediate benefit?
>
> I see code like this frequently:
>
> bus = mdiobus_alloc();
> if (bus == NULL)
> return -ENOMEM;
> priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> if (priv == NULL) {
> err = -ENOMEM;
> goto out_free;
> }
> bus->priv = priv;
Where "frequently", all of the mdiobus_alloc() call sites in your patch just
get translated to pass "0" for the private size.
Make the change how I suggested, where mdiobus_alloc() retains it's current
function signature and semantics. Then you can edit drivers as needed rather
than from the beginning.
^ permalink raw reply
* Re: [PATCH 1/2] net: fix sleeping while atomic problem in sock mem_cgroup.
From: David Miller @ 2011-12-16 20:35 UTC (permalink / raw)
To: glommer-bzQdu9zFT3WakBO8gow8eQ
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A,
netdev-u79uwXL29TY76Z2rM5mHXA,
eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w,
cgroups-u79uwXL29TY76Z2rM5mHXA, sfr-3FnU+UHB4dNDw9hX6IcOSA,
rdunlap-/UHa2rfvQTnk1uMJSBkQmQ
In-Reply-To: <1324032720-13752-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Date: Fri, 16 Dec 2011 14:51:59 +0400
> We can't scan the proto_list to initialize sock cgroups, as it
> holds a rwlock, and we also want to keep the code generic enough to
> avoid calling the initialization functions of protocols directly,
>
> Convert proto_list_lock into a mutex, so we can sleep and do the
> necessary allocations. This lock is seldom taken, so there shouldn't
> be any performance penalties associated with that
>
> Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH] phylib: update mdiobus_alloc() to allocate extra private space
From: Timur Tabi @ 2011-12-16 20:37 UTC (permalink / raw)
To: David Miller; +Cc: afleming, netdev, linuxppc-dev
In-Reply-To: <20111216.153254.1998330487051662169.davem@davemloft.net>
David Miller wrote:
> Make the change how I suggested, where mdiobus_alloc() retains it's current
> function signature and semantics. Then you can edit drivers as needed rather
> than from the beginning.
Yes, your approach makes much more sense. I should have thought of it.
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply
* Re: [PATCH 2/2] net: fix compilation with !CONFIG_NET
From: David Miller @ 2011-12-16 20:35 UTC (permalink / raw)
To: glommer; +Cc: linux-kernel, kamezawa.hiroyu, netdev, eric.dumazet, cgroups, sfr
In-Reply-To: <1324032720-13752-2-git-send-email-glommer@parallels.com>
From: Glauber Costa <glommer@parallels.com>
Date: Fri, 16 Dec 2011 14:52:00 +0400
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] sch_gred: prefer GFP_KERNEL allocations
From: David Miller @ 2011-12-16 20:41 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1324022985.2562.39.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 16 Dec 2011 09:09:45 +0100
> In control path, its better to use GFP_KERNEL allocations where
> possible.
>
> Before taking qdisc spinlock, we preallocate memory just in case we'll
> need it in gred_change_vq()
>
> This is a followup to commit 3f1e6d3fd37b (sch_gred: should not use
> GFP_KERNEL while holding a spinlock)
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next] be2net: Add support for Skyhawk cards
From: David Miller @ 2011-12-16 20:46 UTC (permalink / raw)
To: ajit.khaparde; +Cc: netdev
In-Reply-To: <20111215163138.GA5786@akhaparde-VBox>
From: Ajit Khaparde <ajit.khaparde@Emulex.Com>
Date: Thu, 15 Dec 2011 10:31:38 -0600
> Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 1/4 net-next] net:core: use IS_ENABLED
From: David Miller @ 2011-12-16 20:50 UTC (permalink / raw)
To: igorm; +Cc: netdev
In-Reply-To: <1323694705-2793-1-git-send-email-igorm@etf.rs>
From: igorm@etf.rs
Date: Mon, 12 Dec 2011 04:58:22 -0800
> From: Igor Maravić <igorm@etf.rs>
>
> Use IS_ENABLED(CONFIG_FOO)
> instead of defined(CONFIG_FOO) || defined (CONFIG_FOO_MODULE)
>
> Signed-off-by: Igor Maravić <igorm@etf.rs>
Applied.
^ permalink raw reply
* Re: [PATCH 2/4 net-next] net:x25: use IS_ENABLED
From: David Miller @ 2011-12-16 20:50 UTC (permalink / raw)
To: igorm; +Cc: netdev
In-Reply-To: <1323694705-2793-2-git-send-email-igorm@etf.rs>
From: igorm@etf.rs
Date: Mon, 12 Dec 2011 04:58:23 -0800
> From: Igor Maravić <igorm@etf.rs>
>
> Use IS_ENABLED(CONFIG_FOO)
> instead of defined(CONFIG_FOO) || defined (CONFIG_FOO_MODULE)
>
> Signed-off-by: Igor Maravić <igorm@etf.rs>
Applied.
^ permalink raw reply
* Re: [PATCH 3/4 net-next] net:netfilter: use IS_ENABLED
From: David Miller @ 2011-12-16 20:50 UTC (permalink / raw)
To: igorm; +Cc: netdev
In-Reply-To: <1323694705-2793-3-git-send-email-igorm@etf.rs>
From: igorm@etf.rs
Date: Mon, 12 Dec 2011 04:58:24 -0800
> From: Igor Maravić <igorm@etf.rs>
>
> Use IS_ENABLED(CONFIG_FOO)
> instead of defined(CONFIG_FOO) || defined (CONFIG_FOO_MODULE)
>
> Signed-off-by: Igor Maravić <igorm@etf.rs>
Applied.
^ permalink raw reply
* Re: [PATCH 4/4 net-next] net:bridge: use IS_ENABLED
From: David Miller @ 2011-12-16 20:50 UTC (permalink / raw)
To: igorm; +Cc: netdev
In-Reply-To: <1323694705-2793-4-git-send-email-igorm@etf.rs>
From: igorm@etf.rs
Date: Mon, 12 Dec 2011 04:58:25 -0800
> From: Igor Maravić <igorm@etf.rs>
>
> Use IS_ENABLED(CONFIG_FOO)
> instead of defined(CONFIG_FOO) || defined (CONFIG_FOO_MODULE)
>
> Signed-off-by: Igor Maravić <igorm@etf.rs>
Applied.
^ permalink raw reply
* Re: bayom_epp patch
From: David Miller @ 2011-12-16 20:53 UTC (permalink / raw)
To: t.sailer; +Cc: netdev
In-Reply-To: <1323815399.2558.2.camel@unreal.home.sailer.dynip.lugs.ch>
From: Thomas Sailer <t.sailer@alumni.ethz.ch>
Date: Tue, 13 Dec 2011 23:29:59 +0100
> Whitespace has been fixed.
Your email client corrupted the patch, breaking up long lines etc.
Email this thing to yourself and try to apply it, and do not resubmit
this until it works for you.
It is also not properly formed, you are putting the commit header line
for the patch in the email body, it belongs in the Subject.
You should go:
--------------------
Subject: [PATCH] baycom_epp: Improve parport handling, fix multi-core support
Parallel port settings no longer require an IO address value,
because addresses are automatically assigned by the PCI BIOS
...
Signed-off-by: Thomas Sailer <sailer@ife.ee.ethz.ch>
Signed-off-by: Steffen Koehler <steffen.koehler@tu-dresden.de>
--------------------
^ permalink raw reply
* Re: the linux-can-next tree
From: David Miller @ 2011-12-16 21:14 UTC (permalink / raw)
To: mkl; +Cc: socketcan, wg, netdev, linux-can, urs
In-Reply-To: <4EE5C5D0.5030805@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Mon, 12 Dec 2011 10:13:52 +0100
> Hello David,
>
> On 12/01/2011 09:04 PM, Marc Kleine-Budde wrote:
>>> I said I want one person. One person who periodically send me GIT pull requests
>>> or a patch series for "CAN updates" of all kinds.
>>
>> We're currently discussing the problem and we understood the one person
>> contact policy.
>
> We decided that I should be this person. Our can tree is located on
> gitorious:
>
> https://gitorious.org/linux-can/linux-can-next
Let me know when you formally want me to pull from this. Typically this is
done by posting a "N patch" series to netdev, one for each change, CC:'d
to me.
The first posting should be with a subject like "[PATCH 0/N] CAN updates"
and contain the pull request as well as the top-level diffstate et al.
of the pull, usually generated using "git request-pull"
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox