* RE: [PATCH net-next 2/5] r8169: add csi_opt
From: hayeswang @ 2012-03-28 2:52 UTC (permalink / raw)
To: 'Francois Romieu'; +Cc: netdev, linux-kernel
In-Reply-To: <20120327225437.GC22177@electric-eye.fr.zoreil.com>
Francois Romieu [mailto:romieu@fr.zoreil.com]
[...]
> > -static void rtl_csi_access_enable_2(void __iomem *ioaddr)
> > +static void __devinit rtl_init_csi_ops(struct rtl8169_private *tp)
> > {
> > - rtl_csi_access_enable(ioaddr, 0x27000000);
> > + struct csi_ops *ops = &tp->csi_ops;
> > +
> > + switch (tp->mac_version) {
> > + default:
> > + ops->write = r8169_csi_write;
> > + ops->read = r8169_csi_read;
> > + break;
> > + }
> > }
> >
> > struct ephy_info {
> [...]
> > @@ -6199,6 +6267,7 @@ rtl_init_one(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> > rtl_init_mdio_ops(tp);
> > rtl_init_pll_power_ops(tp);
> > rtl_init_jumbo_ops(tp);
> > + rtl_init_csi_ops(tp);
> >
> > rtl8169_print_mac_version(tp);
>
> It will enable the CSI read/write functions where they
> previously weren't.
>
> Is it really supposed to behave this way ?
>
> Thanks.
>
It seems to be fine, but I would modify them. Thanks.
Best Regards,
Hayes
^ permalink raw reply
* RE: [PATCH net-next 5/5] r8169: support RTL8411
From: hayeswang @ 2012-03-28 2:52 UTC (permalink / raw)
To: 'Francois Romieu'; +Cc: netdev, linux-kernel
In-Reply-To: <20120327225453.GD22177@electric-eye.fr.zoreil.com>
Francois Romieu [mailto:romieu@fr.zoreil.com]
[...]
> > @@ -250,6 +252,9 @@ static const struct {
> >
> JUMBO_9K, false),
> > [RTL_GIGA_MAC_VER_37] =
> > _R("RTL8402", RTL_TD_1, FIRMWARE_8402_1,
> > + JUMBO_1K, true),
> > + [RTL_GIGA_MAC_VER_38] =
> > + _R("RTL8411", RTL_TD_1, FIRMWARE_8411_1,
> > JUMBO_1K, true)
>
> Realtek's product page documents this chipset as a gigabit
> one. It seems
> strange to configure it as a jumbo packet unable one.
>
It is my mistake. I would fix it.
[...]
> "The RTL8411 supports Receive Side Scaling (RSS) to hash incoming TCP
> connections and load-balance received data processing across
> multiple CPUs.
> RSS improves the number of transactions per second and number
> of connections
> per second, for increased network throughput. Header Data
> Split (HDS) support
> enables faster processing of TCP/IP networking protocols for
> improved network
> performance.
>
> Virtual Machine Queue (VMQ) is a hardware virtualization
> technology for the
> efficient transfer of network traffic to a virtualized host
> OS. VMQ uses
> hardware packets filtering to deliver packet data from an
> external virtual
> machine network directly to virtual machines, which reduces
> the overhead of
> routing packets and copying them from the management
> operating system to the
> virtual machine.
>
> Note: RTL8411 Virtual Machine Queue (VMQ) is only functional
> in computers
> running Windows Server 2008 R2 with the Hyper-V server role
> installed."
>
> Will Realtek consider helping make those being available on Linux ?
>
I don't have the documents about these. I need more information from the other
engineers, and I have to discuss with my leader. Maybe I could research the
possibility when I have more time.
Best Regards,
Hayes
^ permalink raw reply
* RE: [PATCH net-next 1/5] r8169: modify pll power function
From: hayeswang @ 2012-03-28 2:52 UTC (permalink / raw)
To: 'Francois Romieu'; +Cc: netdev, linux-kernel
In-Reply-To: <20120327225407.GB22177@electric-eye.fr.zoreil.com>
Francois Romieu [mailto:romieu@fr.zoreil.com]
> Sent: Wednesday, March 28, 2012 6:54 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 1/5] r8169: modify pll power function
>
> Hayes Wang <hayeswang@realtek.com> :
> > Adjust r810x_pll_power_down, r810x_pll_power_up, and
> r8168_pll_power_up.
> > Always power up device during rtl_open.
> > For r810x, turn off more power when the WOL is disabled.
>
> Would the "Always power up" part qualify as a "fix something" change ?
>
I don't see any issue about this yet. It seems to be reasonable to make suer the
device would work when the open is called no matter the power is turned off
before or not.
Best Regards,
Hayes
^ permalink raw reply
* Re: [PATCH] f_phonet: fix skb truesize underestimation
From: David Miller @ 2012-03-28 2:51 UTC (permalink / raw)
To: eric.dumazet; +Cc: gregkh, linux-usb, netdev, balbi, remi.denis-courmont
In-Reply-To: <1332853442.3248.15.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 27 Mar 2012 06:04:02 -0700
> Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
> properly account truesize of each fragment : a full page.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] cdc-phonet: fix skb truesize underestimation
From: David Miller @ 2012-03-28 2:51 UTC (permalink / raw)
To: eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
balbi-l0cyMroinI0, remi.denis-courmont-xNZwKgViW5gAvxtiuMwx3w
In-Reply-To: <1332854246.3248.18.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Tue, 27 Mar 2012 06:17:26 -0700
> Now skb_add_rx_frag() has a truesize parameter, we can fix cdc-phonet to
> properly account truesize of each fragment : a full page.
>
> Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH] rose_dev: fix memcpy-bug in rose_set_mac_address
From: David Miller @ 2012-03-28 2:49 UTC (permalink / raw)
To: danborkmann; +Cc: ralf, netdev
In-Reply-To: <4F71C05C.4040300@iogearbox.net>
From: Daniel Borkmann <danborkmann@iogearbox.net>
Date: Tue, 27 Mar 2012 15:27:56 +0200
> This patch fixes a small bug in rose_set_mac_address. If the current and new
> MAC addresses match, then nothing needs to be done. However memcpy was used
> instead of memcmp for comparison.
>
> The patch is against the latest net-tree.
>
> Signed-off-by: Daniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
You're breaking this code, not fixing it.
If you don't keep the memcpy, then the calls right below which setup
the loopback node will use the previous device address not the new
one being configured.
^ permalink raw reply
* Re: [PATCH] eql: dont rely on HZ=100
From: David Miller @ 2012-03-28 2:47 UTC (permalink / raw)
To: eric.dumazet; +Cc: dwmw2, netdev
In-Reply-To: <1332838320.3248.6.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 27 Mar 2012 01:52:00 -0700
> [PATCH] eql: dont rely on HZ=100
>
> HZ is more likely to be 1000 these days.
>
> timer handlers are run from softirq, no need to disable bh
>
> skb priority 1 is TC_PRIO_FILLER
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
Strange we export this EQL_DEFAULT_RESCHED_IVAL to userspace, where
HZ will take on a different value I think, something akin to USER_HZ.
Anyways, that's a different unrelated problem to the bug you're
fixing.
^ permalink raw reply
* Re: [patch] mISDN: array underflow in open_bchannel()
From: David Miller @ 2012-03-28 2:42 UTC (permalink / raw)
To: dan.carpenter; +Cc: isdn, adobriyan, netdev, kernel-janitors
In-Reply-To: <20120327072048.GC19008@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 27 Mar 2012 10:20:48 +0300
> There are two channels here. User space starts counting channels at one
> but in the kernel we start at zero. If the user passes in a zero
> channel that's invalid and could lead to memory corruption.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply
* Re: [PATCH net] bnx2x: fix vector traveling while looking for an empty entry
From: David Miller @ 2012-03-28 2:41 UTC (permalink / raw)
To: dmitry; +Cc: netdev, eilong, zenczykowski
In-Reply-To: <1332832135-22054-1-git-send-email-dmitry@broadcom.com>
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Tue, 27 Mar 2012 09:08:55 +0200
> Fixes the bug that may prevent from mac to be configured,
> while there is an empty slot for it.
>
> Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
Applied.
^ permalink raw reply
* Re: [net PATCH] bnx2x: previous driver unload revised
From: David Miller @ 2012-03-28 2:41 UTC (permalink / raw)
To: yuvalmin; +Cc: netdev, dmitry, eilong
In-Reply-To: <1332830827-18253-1-git-send-email-yuvalmin@broadcom.com>
From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Tue, 27 Mar 2012 08:47:07 +0200
> The flow in which the bnx2x driver starts after a previous driver
> has been terminated in an 'unclean' manner has several bugs and
> FW risks, which makes it possible for the driver to fail after
> boot-from-SAN or kdump.
> This patch contains a revised flow which performs a safer
> initialization, solving the possible crash scenarios.
> Notice this patch contains lines with over 80 characters, as it
> keeps print-strings in a single line.
>
> Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH] USB: Add Motorola Rokr E6 Id to the USBNet driver "zaurus"
From: David Miller @ 2012-03-28 2:40 UTC (permalink / raw)
To: guanx.bac; +Cc: linux-kernel, netdev, davej
In-Reply-To: <CANeMGR5PECuVb=p7orzwHgcsa9GSW=-gMyqWo7RYm_NpmLm4Ug@mail.gmail.com>
From: Guan Xin <guanx.bac@gmail.com>
Date: Mon, 26 Mar 2012 16:11:46 +0200
> From: Guan Xin <guanx.bac@gmail.com>
>
> Added Vendor/Device Id of Motorola Rokr E6 (22b8:6027) so it can be
> recognized by the "zaurus" USBNet driver.
> Applies to Linux 3.2.13 and 2.6.39.4.
> Signed-off-by: Guan Xin <guanx.bac@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH v3] net: sh_eth: Add support SH7734
From: David Miller @ 2012-03-28 2:38 UTC (permalink / raw)
To: nobuhiro.iwamatsu.yj; +Cc: netdev
In-Reply-To: <1332737991-7862-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Date: Mon, 26 Mar 2012 13:59:51 +0900
> Add define of SH7734 register and sh_eth_reset_hw_crc function.
>
> V3: Rebase net/HEAD.
> V2: Do not split line of #if defined.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Applied.
^ permalink raw reply
* Re: [PATCH v4] Ethernet driver for the WIZnet W5300 chip
From: David Miller @ 2012-03-28 2:35 UTC (permalink / raw)
To: msink; +Cc: netdev, linux-kernel, joe, eric.dumazet
In-Reply-To: <1332752876-1650-1-git-send-email-msink@permonline.ru>
From: Mike Sinkovsky <msink@permonline.ru>
Date: Mon, 26 Mar 2012 15:07:56 +0600
> +/*
> + * Frame size is hardwired to 1514 bytes (including header),
> + * => MTU for 802.1Q frames must be set to 1500-4 = 1496
> + */
> +#define W5300_HARD_MTU 1500
I've told you that you must set the VLAN challenged feature flag
(NETIF_F_VLAN_CHALLENGED) for devices which have this restriction.
Just set that, and remove this comment, since the feature bit setting
documents this restriction fully and perfectly.
^ permalink raw reply
* Re: [V5 PATCH] virtio-net: send gratuitous packets when needed
From: Jason Wang @ 2012-03-28 2:35 UTC (permalink / raw)
To: David Miller; +Cc: netdev, mst, linux-kernel, virtualization
In-Reply-To: <20120327.223112.2032989102915830685.davem@davemloft.net>
On 03/28/2012 10:31 AM, David Miller wrote:
> From: Jason Wang<jasowang@redhat.com>
> Date: Fri, 16 Mar 2012 17:01:01 +0800
>
>> > As hypervior does not have the knowledge of guest network configuration, it's
>> > better to ask guest to send gratuitous packets when needed.
>> >
>> > Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it
>> > is set, a workqueue is scheduled to send gratuitous packet through
>> > NETDEV_NOTIFY_PEERS. This feature is negotiated through bit
>> > VIRTIO_NET_F_GUEST_ANNOUNCE.
>> >
>> > Changes from v4:
>> > - typos
>> > - handle workqueue unconditionally
>> > - move VIRTIO_NET_S_ANNOUNCE to bit 8 to separate rw bits from ro bits
>> >
>> > Changes from v3:
>> > - cancel the workqueue during freeze
>> >
>> > Changes from v2:
>> > - fix the race between unregister_dev() and workqueue
>> >
>> > Signed-off-by: Jason Wang<jasowang@redhat.com>
> What's happening with this patch?
Hi David:
I'm working on a new version of this patch as there's some changes in
virtio-spec, I would post it soon.
Thanks
^ permalink raw reply
* Re: [PATCH] net: reference the ipv4 sysctl table header
From: Eric W. Biederman @ 2012-03-28 2:35 UTC (permalink / raw)
To: Djalal Harouni; +Cc: David S. Miller, Al Viro, netdev
In-Reply-To: <20120326232123.GB29626@dztty>
Djalal Harouni <tixxdz@opendz.org> writes:
> On Mon, Mar 26, 2012 at 03:50:30PM -0700, Eric W. Biederman wrote:
>> Djalal Harouni <tixxdz@opendz.org> writes:
>>
>> > I've been analysing some kmemleak reports of an internal module, and
>> > found that there are false positive reports of unreferenced objects.
>> >
>> > The following patch is just a clean up for one of those false positives,
>> > this is for the /proc/sys/net/ipv4 sysctl table.
>> > As I've said there are other reports but don't know if it is worth to
>> > write patches for them.
>>
>> So the problem here is that you register a sysctl and don't keep a
>> pointer to the returned sysctl_header? So kmemleak complains?
> Right.
>
>> I would expect the other sysctl data structures to have such a pointer,
>> so I don't know why kmemleak would complain.
>>
>> Does my recent sysctl rewrite affect when this kmemleak is reported?
> Actually yes, after a recent pull (which includes your recent sysctl work),
> some of these false positive reports started to appear.
>
>
> Anyway they seem false positive ones, since keeping a reference to
> sysctl_header as in my previous (ugly) patch will quiet the last two
> ones.
Ok thanks. If that is what it is. Then clean way to quite this will
ultimately be converting these table to be compatible with my brand
new register_sysctl() and using that to register them.
In fact I am pretty certain we can just do:
register_sysctl("net/ipv4/route", ipv4_route_table);
register_sysctl("net/ipv4/neigh", empty);
instead of:
register_sysctl_paths(ipv4_path, ipv4_skeleton);
And kill ipv4_skeleton and ipv4_path as they are now unused.
There was a tremendous cleanup and speed up that came with not allowing
sysctl tables to support .child entries in the core, and the older
registration routines break apart the tables and return a compatilibty
sysctl_table_header if we do that, and I believe we are just
leaking that compatibility sysctl_table_header.
Eric
^ permalink raw reply
* Re: [V5 PATCH] virtio-net: send gratuitous packets when needed
From: David Miller @ 2012-03-28 2:31 UTC (permalink / raw)
To: jasowang; +Cc: netdev, mst, linux-kernel, virtualization
In-Reply-To: <20120316090100.5223.50783.stgit@amd-6168-8-1.englab.nay.redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Fri, 16 Mar 2012 17:01:01 +0800
> As hypervior does not have the knowledge of guest network configuration, it's
> better to ask guest to send gratuitous packets when needed.
>
> Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it
> is set, a workqueue is scheduled to send gratuitous packet through
> NETDEV_NOTIFY_PEERS. This feature is negotiated through bit
> VIRTIO_NET_F_GUEST_ANNOUNCE.
>
> Changes from v4:
> - typos
> - handle workqueue unconditionally
> - move VIRTIO_NET_S_ANNOUNCE to bit 8 to separate rw bits from ro bits
>
> Changes from v3:
> - cancel the workqueue during freeze
>
> Changes from v2:
> - fix the race between unregister_dev() and workqueue
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
What's happening with this patch?
^ permalink raw reply
* Re: [PATCH 2/2] wimax: i2400m-usb - use a private struct ethtool_ops
From: David Miller @ 2012-03-28 2:30 UTC (permalink / raw)
To: phil.sutter; +Cc: netdev, inaky.perez-gonzalez
In-Reply-To: <1332761036-8913-2-git-send-email-phil.sutter@viprinet.com>
From: Phil Sutter <phil.sutter@viprinet.com>
Date: Mon, 26 Mar 2012 13:23:56 +0200
> This way the USB variant of the driver uses usb_make_path in order to
> provide bus-info compatible to other USB drivers (like e.g. asix.c).
>
> Signed-off-by: Phil Sutter <phil.sutter@viprinet.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/2] wimax: i2400m - prevent a possible kernel bug due to missing fw_name string
From: David Miller @ 2012-03-28 2:30 UTC (permalink / raw)
To: phil.sutter; +Cc: netdev, inaky.perez-gonzalez
In-Reply-To: <1332761036-8913-1-git-send-email-phil.sutter@viprinet.com>
From: Phil Sutter <phil.sutter@viprinet.com>
Date: Mon, 26 Mar 2012 13:23:55 +0200
> This happened on a machine with a custom hotplug script calling nameif,
> probably due to slow firmware loading. At the time nameif uses ethtool
> to gather interface information, i2400m->fw_name is zero and so a null
> pointer dereference occurs from within i2400m_get_drvinfo().
>
> Signed-off-by: Phil Sutter <phil.sutter@viprinet.com>
Applied.
^ permalink raw reply
* [PATCH v3 2/2] net/core: dev_forward_skb() should clear skb_iif
From: Benjamin LaHaise @ 2012-03-28 1:55 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
While investigating another bug, I found that the code on the incoming path
in __netif_receive_skb will only set skb->skb_iif if it is already 0. When
dev_forward_skb() is used in the case of interfaces like veth, skb_iif may
already have been set. Making dev_forward_skb() cause the packet to look
like a newly received packet would seem to the the correct behaviour here,
as otherwise the wrong incoming interface can be reported for such a packet.
Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
---
net/core/dev.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 452db70..723a406 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1597,6 +1597,7 @@ int dev_forward_skb(struct net_device *dev, struct sk_buff *skb)
kfree_skb(skb);
return NET_RX_DROP;
}
+ skb->skb_iif = 0;
skb_set_dev(skb, dev);
skb->tstamp.tv64 = 0;
skb->pkt_type = PACKET_HOST;
--
1.7.4.1
--
"Thought is the essence of where you are now."
^ permalink raw reply related
* [PATCH v3 1/2] net/ipv4: fix IPv4 multicast over network namespaces
From: Benjamin LaHaise @ 2012-03-28 1:55 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
When using multicast over a local bridge feeding a number of LXC guests
using veth, the LXC guests are unable to get a response from other guests
when pinging 224.0.0.1. Multicast packets did not appear to be getting
delivered to the network namespaces of the guest hosts, and further
inspection showed that the incoming route was pointing to the loopback
device of the host, not the guest. This lead to the wrong network namespace
being picked up by sockets (like ICMP). Fix this by using the correct
network namespace when creating the inbound route entry.
Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
---
net/ipv4/route.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 12ccf88..3b110a4 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2042,7 +2042,7 @@ static int ip_route_input_mc(struct sk_buff *skb, __be32 daddr, __be32 saddr,
if (err < 0)
goto e_err;
}
- rth = rt_dst_alloc(init_net.loopback_dev,
+ rth = rt_dst_alloc(dev_net(dev)->loopback_dev,
IN_DEV_CONF_GET(in_dev, NOPOLICY), false);
if (!rth)
goto e_nobufs;
--
1.7.4.1
--
"Thought is the essence of where you are now."
^ permalink raw reply related
* Re: [PATCH 10/13] smsc911x: Use lockdep_assert_held instead of home grown buggy construct
From: David Miller @ 2012-03-28 1:32 UTC (permalink / raw)
To: andi; +Cc: akpm, linux-kernel, ak, netdev
In-Reply-To: <1332895637-32572-11-git-send-email-andi@firstfloor.org>
From: Andi Kleen <andi@firstfloor.org>
Date: Tue, 27 Mar 2012 17:47:14 -0700
> From: Andi Kleen <ak@linux.intel.com>
>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 08/13] irda: remove spin_is_locked
From: David Miller @ 2012-03-28 1:32 UTC (permalink / raw)
To: andi; +Cc: akpm, linux-kernel, ak, netdev, samuel
In-Reply-To: <1332895637-32572-9-git-send-email-andi@firstfloor.org>
From: Andi Kleen <andi@firstfloor.org>
Date: Tue, 27 Mar 2012 17:47:12 -0700
> From: Andi Kleen <ak@linux.intel.com>
>
> It's hard to imagine how this spin_is_locked debugging check is not
> totally racy. Remove it.
>
> Cc: netdev@vger.kernel.org
> Cc: samuel@sortiz.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH] net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()
From: David Miller @ 2012-03-28 1:27 UTC (permalink / raw)
To: john.r.fastabend; +Cc: eric.dumazet, greearb, netdev, gregkh, paulmck, davej
In-Reply-To: <4F72612A.4020305@intel.com>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Tue, 27 Mar 2012 17:54:02 -0700
> I can clean up the ./net/dcb/ code if it will save you some time?
Thanks for offering John, but I can take care of this all myself.
^ permalink raw reply
* Re: [PATCH] net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()
From: John Fastabend @ 2012-03-28 0:54 UTC (permalink / raw)
To: David Miller; +Cc: eric.dumazet, greearb, netdev, gregkh, paulmck, davej
In-Reply-To: <20120327.182208.806353341087563847.davem@davemloft.net>
On 3/27/2012 3:22 PM, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 27 Mar 2012 21:53:52 +0200
>
>> Commit f2c31e32b378 (net: fix NULL dereferences in check_peer_redir() )
>> added a regression in rt6_fill_node(), leading to rcu_read_lock()
>> imbalance.
>>
>> Thats because NLA_PUT() can make a jump to nla_put_failure label.
>>
>> Fix this by using nla_put()
>>
>> Many thanks to Ben Greear for his help
>>
>> Reported-by: Ben Greear <greearb@candelatech.com>
>> Reported-by: Dave Jones <davej@redhat.com>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Great work everyone.
>
> I'll apply this and queue it up for stable soon.
>
> In other news, I think the days of hidden gotos from the NLA macros
> should be over. I'll work in net-next to redo this so that the
> gotos must be explicitly coded and therefore be visible when people
> audit these routines.
>
> Thanks!
> --
I can clean up the ./net/dcb/ code if it will save you some time?
.John
^ permalink raw reply
* Re: [PATCH ipv4 multicast] Fix IPv4 multicast over network namespaces
From: Benjamin LaHaise @ 2012-03-28 0:49 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20120327.173541.1721499825104013533.davem@davemloft.net>
On Tue, Mar 27, 2012 at 05:35:41PM -0400, David Miller wrote:
> No signoff.
My apologies. Doing this manually clearly isn't working, so I've switched
to a script to try to catch this.
> No proper subsystem prefix in Subject line (should be "ipv4: " here)
I'm trying to get this right, and it looks like I botched this again, for
that I am truely sorry.
-ben
> And third you've been warned about this repeatedly in your previous
> patch postings.
>
> Therefore I'm not applying this.
--
"Thought is the essence of where you are now."
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox