* Re: [PATCH] gianfar: add support for wake-on-packet
From: David Miller @ 2012-07-20 18:22 UTC (permalink / raw)
To: chenhui.zhao; +Cc: netdev, scottwood, linux-kernel, leoli
In-Reply-To: <1342788723-27703-1-git-send-email-chenhui.zhao@freescale.com>
From: Zhao Chenhui <chenhui.zhao@freescale.com>
Date: Fri, 20 Jul 2012 20:52:03 +0800
> Note: The local ip/mac address is the ethernet primary IP/MAC address of
> the station. Do not support multiple IP/MAC addresses.
I'm not applying this.
There is no such concept of "primary IP address" for interfaces,
just picking the first interface address you find is completel
bogus.
Someone might add 100 IP addresses, then the one that's "primary",
and vice versa.
^ permalink raw reply
* Re: [patch iproute2] iplink: add support for num[tr]xqueues
From: Jiri Pirko @ 2012-07-20 18:22 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Miller, netdev, edumazet, shemminger
In-Reply-To: <s6ijrlvetpfdqgjl8x20788e.1342807975041@email.android.com>
Fri, Jul 20, 2012 at 08:12:55PM CEST, stephen.hemminger@vyatta.com wrote:
>
>Or use matches("numtxqueues") rather than strcmp
Okay - I will repost with "matches"
^ permalink raw reply
* Re: [PATCH] ipv4: show pmtu in route list
From: David Miller @ 2012-07-20 18:16 UTC (permalink / raw)
To: ja; +Cc: netdev
In-Reply-To: <1342774928-29301-1-git-send-email-ja@ssi.bg>
From: Julian Anastasov <ja@ssi.bg>
Date: Fri, 20 Jul 2012 12:02:08 +0300
> Is this patch still useful if routing cache is removed?
It is, since this function still gets used for rtnetlink route
queries. So I'll apply this, thanks Julian!
Which reminds me that we don't have way to inspect the new TCP metrics
cache. Would someone like to work on that?
^ permalink raw reply
* Re: [net-next 0/9][pull request] Intel Wired LAN Driver Updates
From: David Miller @ 2012-07-20 18:13 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann
In-Reply-To: <1342747446-16132-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 19 Jul 2012 18:23:57 -0700
> This series contains updates to ixgbe.
>
> The following are changes since commit 769162e38b91e1d300752e666260fa6c7b203fbc:
> Merge branch 'net' of git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile
> and are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
Pulled, thanks Jeff.
^ permalink raw reply
* Re: [PATCH v2 net-next] tcp: fix ABC in tcp_slow_start()
From: Neal Cardwell @ 2012-07-20 18:13 UTC (permalink / raw)
To: David Miller
Cc: stephen.hemminger, ycheng, eric.dumazet, netdev, therbert,
shemminger, johnwheffner, nanditad
In-Reply-To: <20120720.110234.810125972347182800.davem@davemloft.net>
On Fri, Jul 20, 2012 at 11:02 AM, David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <stephen.hemminger@vyatta.com>
> Date: Fri, 20 Jul 2012 11:01:43 -0700
>
>> TCP ABC was an experiment that failed. It solves a problem that does
>> not exist on Linux. I did the implementation mostly to prove that.
>>
>> Perhaps it abc should just be removed?
>
> This is my impression as well.
Removing ABC sounds good to me as well.
neal
^ permalink raw reply
* Re: [patch iproute2] iplink: add support for num[tr]xqueues
From: Stephen Hemminger @ 2012-07-20 18:12 UTC (permalink / raw)
To: David Miller; +Cc: jiri, netdev, edumazet, shemminger
Or use matches("numtxqueues") rather than strcmp
^ permalink raw reply
* Re: [GIT] net has been merged into net-next
From: David Miller @ 2012-07-20 18:11 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev
In-Reply-To: <1342744598.2616.15.camel@jtkirshe-mobl>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 19 Jul 2012 17:36:38 -0700
> On Thu, 2012-07-19 at 11:31 -0700, David Miller wrote:
>> Jeff, please double check my merge work on the ixgbevf driver, and send
>> me any necessary fixups.
>>
>> Thanks!
>
> Your conflict resolution was correct, so no fix-ups needed. Thanks
> Dave.
Thanks a lot Jeff.
^ permalink raw reply
* Re: [patch iproute2] iplink: add support for num[tr]xqueues
From: David Miller @ 2012-07-20 18:10 UTC (permalink / raw)
To: jiri; +Cc: stephen.hemminger, netdev, edumazet, shemminger
In-Reply-To: <20120720180813.GA1560@minipsycho.orion>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 20 Jul 2012 20:08:13 +0200
> Fri, Jul 20, 2012 at 05:52:18PM CEST, stephen.hemminger@vyatta.com wrote:
>>I like the option, but numtxqueue is too verbose for the syntax model
>>of iproute. Why not use txq and rxq?
>
> There is "txqueuelen" present already in iplink. I tried to be uniform here.
> Isn't "txq" and "rxq" rather too short? And afterall, these parameters
> are not supposed to be used on daily basis by anyone :)
Perhaps a good compromise is numtxq and numrxq?
^ permalink raw reply
* Re: [patch net-next 5/6] bond_sysfs: use ream_num_tx_queues rather than params.tx_queue
From: Jiri Pirko @ 2012-07-20 18:09 UTC (permalink / raw)
To: David Miller; +Cc: bhutchings, netdev, edumazet, shemminger, fubar, andy
In-Reply-To: <20120720.110453.200101053484551575.davem@davemloft.net>
Fri, Jul 20, 2012 at 08:04:53PM CEST, davem@davemloft.net wrote:
>From: Ben Hutchings <bhutchings@solarflare.com>
>Date: Fri, 20 Jul 2012 16:03:00 +0100
>
>> Typo in the subject line. :-)
Doh!
>
>I'll fix this up when I apply it :-)
Thanks Dave :) I will use clipboard next time...
^ permalink raw reply
* Re: [RFC PATCH] net: Add support for virtual machine device queues (VMDQ)
From: Ben Hutchings @ 2012-07-20 18:09 UTC (permalink / raw)
To: John Fastabend
Cc: or.gerlitz, davem, roland, netdev, ali, sean.hefty, shlomop
In-Reply-To: <20120718220544.22619.97136.stgit@i40e.jf1>
On Wed, 2012-07-18 at 18:05 -0400, John Fastabend wrote:
> This adds support to allow virtual net devices to be created. These
> devices can be managed independtly of the physical function but
> use the same physical link.
>
> This is analagous to an offloaded macvlan device. The primary
> advantage to VMDQ net devices over virtual functions is they can
> be added and removed dynamically as needed.
Is VMDQ intended to become a generic name?
> Sending this for Or Gerlitz to take a peak at and see if this
> could be used for his ipoib bits. Its not pretty as is and
> likely needs some work its just an idea at this point use at
> your own risk I believe it compiles.
[...]
> +static int vmdq_newlink(struct net *src_net, struct net_device *dev,
> + struct nlattr *tb[], struct nlattr *data[])
> +{
> + struct net_device *lowerdev;
> + int err = -EOPNOTSUPP;
> +
> + if (!tb[IFLA_LINK])
> + return -EINVAL;
> +
> + lowerdev = __dev_get_by_index(src_net, nla_get_u32(tb[IFLA_LINK]));
> + if (!lowerdev)
> + return -ENODEV;
> +
> + if (!tb[IFLA_MTU])
> + dev->mtu = lowerdev->mtu;
> + else if (dev->mtu > lowerdev->mtu)
> + return -EINVAL;
> +
> + if (lowerdev->netdev_ops->ndo_add_vmdq)
> + err = lowerdev->netdev_ops->ndo_add_vmdq(lowerdev, dev);
Why isn't the device allocation left to the lower device driver? It
seems like this would simplify things quite a bit.
[...]
> +int vmdq_get_tx_queues(struct net *net, struct nlattr *tb[])
> +{
> + struct net_device *lowerdev;
> +
> + if (!tb[IFLA_LINK])
> + return -EINVAL;
> +
> + lowerdev = __dev_get_by_index(net, nla_get_u32(tb[IFLA_LINK]));
> + if (!lowerdev)
> + return -ENODEV;
> +
> + return lowerdev->num_tx_queues;
> +}
[...]
Why should this match the lower device? Is the assumption that it will
share the lower device's TX queues and only have its own RX queue(s)?
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [patch net-next 0/6] net: add team multiqueue support and do comple of thing on the way
From: David Miller @ 2012-07-20 18:08 UTC (permalink / raw)
To: jiri; +Cc: netdev, edumazet, shemminger, fubar, andy
In-Reply-To: <1342787331-1866-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 20 Jul 2012 14:28:45 +0200
> This patchset represents the way I walked when I was adding multiqueue support for
> team driver.
>
> Jiri Pirko (6):
> net: honour netif_set_real_num_tx_queues() retval
> rtnl: allow to specify different num for rx and tx queue count
> rtnl: allow to specify number of rx and tx queues on device creation
> net: rename bond_queue_mapping to slave_dev_queue_mapping
> bond_sysfs: use ream_num_tx_queues rather than params.tx_queue
> team: add multiqueue support
All applied, thanks Jiri.
^ permalink raw reply
* Re: [patch iproute2] iplink: add support for num[tr]xqueues
From: Jiri Pirko @ 2012-07-20 18:08 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, David Miller, edumazet, shemminger
In-Reply-To: <lh9v01i5y1bg7t9j24kof0f8.1342799538355@email.android.com>
Fri, Jul 20, 2012 at 05:52:18PM CEST, stephen.hemminger@vyatta.com wrote:
>I like the option, but numtxqueue is too verbose for the syntax model
>of iproute. Why not use txq and rxq?
There is "txqueuelen" present already in iplink. I tried to be uniform here.
Isn't "txq" and "rxq" rather too short? And afterall, these parameters
are not supposed to be used on daily basis by anyone :)
Jirka
>
>Sent from my ASUS Pad
>
>Jiri Pirko <jiri@resnulli.us> wrote:
>
>>Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>>---
>> include/linux/if_link.h | 2 ++
>> ip/iplink.c | 20 ++++++++++++++++++++
>> man/man8/ip-link.8.in | 13 +++++++++++++
>> 3 files changed, 35 insertions(+)
>>
>>diff --git a/include/linux/if_link.h b/include/linux/if_link.h
>>index 00e5868..46f03db 100644
>>--- a/include/linux/if_link.h
>>+++ b/include/linux/if_link.h
>>@@ -140,6 +140,8 @@ enum {
>> IFLA_EXT_MASK, /* Extended info mask, VFs, etc */
>> IFLA_PROMISCUITY, /* Promiscuity count: > 0 means acts PROMISC */
>> #define IFLA_PROMISCUITY IFLA_PROMISCUITY
>>+ IFLA_NUM_TX_QUEUES,
>>+ IFLA_NUM_RX_QUEUES,
>> __IFLA_MAX
>> };
>>
>>diff --git a/ip/iplink.c b/ip/iplink.c
>>index 679091e..0baa128 100644
>>--- a/ip/iplink.c
>>+++ b/ip/iplink.c
>>@@ -48,6 +48,8 @@ void iplink_usage(void)
>> fprintf(stderr, " [ address LLADDR ]\n");
>> fprintf(stderr, " [ broadcast LLADDR ]\n");
>> fprintf(stderr, " [ mtu MTU ]\n");
>>+ fprintf(stderr, " [ numtxqueues QUEUE_COUNT ]\n");
>>+ fprintf(stderr, " [ numrxqueues QUEUE_COUNT ]\n");
>> fprintf(stderr, " type TYPE [ ARGS ]\n");
>> fprintf(stderr, " ip link delete DEV type TYPE [ ARGS ]\n");
>> fprintf(stderr, "\n");
>>@@ -279,6 +281,8 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req,
>> int mtu = -1;
>> int netns = -1;
>> int vf = -1;
>>+ int numtxqueues = -1;
>>+ int numrxqueues = -1;
>>
>> *group = -1;
>> ret = argc;
>>@@ -445,6 +449,22 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req,
>> invarg("Invalid operstate\n", *argv);
>>
>> addattr8(&req->n, sizeof(*req), IFLA_OPERSTATE, state);
>>+ } else if (strcmp(*argv, "numtxqueues") == 0) {
>>+ NEXT_ARG();
>>+ if (numtxqueues != -1)
>>+ duparg("numtxqueues", *argv);
>>+ if (get_integer(&numtxqueues, *argv, 0))
>>+ invarg("Invalid \"numtxqueues\" value\n", *argv);
>>+ addattr_l(&req->n, sizeof(*req), IFLA_NUM_TX_QUEUES,
>>+ &numtxqueues, 4);
>>+ } else if (strcmp(*argv, "numrxqueues") == 0) {
>>+ NEXT_ARG();
>>+ if (numrxqueues != -1)
>>+ duparg("numrxqueues", *argv);
>>+ if (get_integer(&numrxqueues, *argv, 0))
>>+ invarg("Invalid \"numrxqueues\" value\n", *argv);
>>+ addattr_l(&req->n, sizeof(*req), IFLA_NUM_RX_QUEUES,
>>+ &numrxqueues, 4);
>> } else {
>> if (strcmp(*argv, "dev") == 0) {
>> NEXT_ARG();
>>diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
>>index 9386cc6..8a24e51 100644
>>--- a/man/man8/ip-link.8.in
>>+++ b/man/man8/ip-link.8.in
>>@@ -40,6 +40,11 @@ ip-link \- network device configuration
>> .RB "[ " mtu
>> .IR MTU " ]"
>> .br
>>+.RB "[ " numtxqueues
>>+.IR QUEUE_COUNT " ]"
>>+.RB "[ " numrxqueues
>>+.IR QUEUE_COUNT " ]"
>>+.br
>> .BR type " TYPE"
>> .RI "[ " ARGS " ]"
>>
>>@@ -156,6 +161,14 @@ Link types:
>> - Ethernet Bridge device
>> .in -8
>>
>>+.TP
>>+.BI numtxqueues " QUEUE_COUNT "
>>+specifies the number of transmit queues for new device.
>>+
>>+.TP
>>+.BI numrxqueues " QUEUE_COUNT "
>>+specifies the number of receive queues for new device.
>>+
>> .SS ip link delete - delete virtual link
>> .I DEVICE
>> specifies the virtual device to act operate on.
>>--
>>1.7.10.4
>>
^ permalink raw reply
* Re: [patch net-next 5/6] bond_sysfs: use ream_num_tx_queues rather than params.tx_queue
From: David Miller @ 2012-07-20 18:04 UTC (permalink / raw)
To: bhutchings; +Cc: jiri, netdev, edumazet, shemminger, fubar, andy
In-Reply-To: <1342796580.2678.10.camel@bwh-desktop.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 20 Jul 2012 16:03:00 +0100
> Typo in the subject line. :-)
I'll fix this up when I apply it :-)
^ permalink raw reply
* Re: [PATCH v2 net-next] tcp: fix ABC in tcp_slow_start()
From: David Miller @ 2012-07-20 18:02 UTC (permalink / raw)
To: stephen.hemminger
Cc: ncardwell, ycheng, eric.dumazet, netdev, therbert, shemminger,
johnwheffner, nanditad
In-Reply-To: <wwxik81fhb83pkj3alus6j68.1342807303829@email.android.com>
From: Stephen Hemminger <stephen.hemminger@vyatta.com>
Date: Fri, 20 Jul 2012 11:01:43 -0700
> TCP ABC was an experiment that failed. It solves a problem that does
> not exist on Linux. I did the implementation mostly to prove that.
>
> Perhaps it abc should just be removed?
This is my impression as well.
^ permalink raw reply
* Re: pull-request: can-next 2012-07-20
From: David Miller @ 2012-07-20 18:02 UTC (permalink / raw)
To: mkl; +Cc: netdev, linux-can
In-Reply-To: <50098706.2080509@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Fri, 20 Jul 2012 18:27:50 +0200
> Hello David,
>
> the fifth pull request for upcoming v3.6 net-next cleans up and
> improves the janz-ican3 driver (6 patches by Ira W. Snyder, one by me).
> A patch by Steffen Trumtrar adds imx53 support to the flexcan driver.
> And another patch by me, which marks the bit timing constant in the CAN
> drivers as "const".
Pulled, thanks Marc.
^ permalink raw reply
* Re: pull request: wireless-next 2012-07-20
From: David Miller @ 2012-07-20 18:02 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, netdev
In-Reply-To: <20120720172014.GB23254@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Fri, 20 Jul 2012 13:20:15 -0400
> commit 90b90f60c4f8e3a8525dfeb4aec46a9c7a29c857
>
> Dave,
>
> Here is what I hope to be the last non-fix pull request for wireless
> bits going into 3.6. It's mostly normal stuff, including driver
> updates to ath9k, mwifiex, libertas, iwlwifi, and a few other bits.
>
> Also included is a bluetooth pull. Gustavo says:
>
> "This is my last pull towards 3.6, the biggest thing here is
> the new 3-wire UART Bluetooth driver by Johan Hedberg. The
> rest is just fixes and clean ups."
>
> Finally, there is a pull of the wireless tree to pick-up a few minor
> fixes I had queued that were not really worthy for this late in the
> 3.5 cycle.
>
> Please let me know if there are problems!
Pulled, thanks John.
^ permalink raw reply
* Re: [PATCH v2 net-next] tcp: fix ABC in tcp_slow_start()
From: David Miller @ 2012-07-20 18:01 UTC (permalink / raw)
To: ncardwell
Cc: ycheng, eric.dumazet, netdev, therbert, shemminger, johnwheffner,
nanditad
In-Reply-To: <CADVnQymoWQmdtTEv_KOvHbQvC6oC0EsJvhda5oAf7CVithS3Pg@mail.gmail.com>
From: Neal Cardwell <ncardwell@google.com>
Date: Fri, 20 Jul 2012 10:58:27 -0700
> On Fri, Jul 20, 2012 at 8:07 AM, Yuchung Cheng <ycheng@google.com> wrote:
>> On Fri, Jul 20, 2012 at 8:02 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>> From: Eric Dumazet <edumazet@google.com>
>>>
>>> When/if sysctl_tcp_abc > 1, we expect to increase cwnd by 2 if the
>>> received ACK acknowledges more than 2*MSS bytes, in tcp_slow_start()
>>>
>>> Problem is this RFC 3465 statement is not correctly coded, as
>>> the while () loop increases snd_cwnd one by one.
>>>
>>> Add a new variable to avoid this off-by one error.
>>>
>>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Acked-by: Yuchung Cheng <ycheng@google.com>
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH v2 net-next] tcp: fix ABC in tcp_slow_start()
From: Stephen Hemminger @ 2012-07-20 18:01 UTC (permalink / raw)
To: Neal Cardwell
Cc: Yuchung Cheng, Eric Dumazet, David Miller, netdev, Tom Herbert,
Stephen Hemminger, John Heffner, Nandita Dukkipati
TCP ABC was an experiment that failed. It solves a problem that does not exist on Linux. I did the implementation mostly to prove that.
Perhaps it abc should just be removed?
^ permalink raw reply
* Re: [PATCH net-next] tcp: improve latencies of timer triggered events
From: David Miller @ 2012-07-20 18:01 UTC (permalink / raw)
To: eric.dumazet
Cc: netdev, therbert, ycheng, ncardwell, nanditad, johnwheffner,
hkchu
In-Reply-To: <1342799150.2626.7574.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 20 Jul 2012 17:45:50 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> Modern TCP stack highly depends on tcp_write_timer() having a small
> latency, but current implementation doesn't exactly meet the
> expectations.
>
> When a timer fires but finds the socket is owned by the user, it rearms
> itself for an additional delay hoping next run will be more
> successful.
>
> tcp_write_timer() for example uses a 50ms delay for next try, and it
> defeats many attempts to get predictable TCP behavior in term of
> latencies.
>
> Use the recently introduced tcp_release_cb(), so that the user owning
> the socket will call various handlers right before socket release.
>
> This will permit us to post a followup patch to address the
> tcp_tso_should_defer() syndrome (some deferred packets have to wait
> RTO timer to be transmitted, while cwnd should allow us to send them
> sooner)
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
I like this a lot, applied, thanks Eric.
^ permalink raw reply
* Re: [RFC PATCH] net: Add support for virtual machine device queues (VMDQ)
From: Ben Hutchings @ 2012-07-20 18:01 UTC (permalink / raw)
To: John Fastabend
Cc: Jiri Pirko, or.gerlitz, davem, roland, netdev, ali, sean.hefty,
shlomop, Ronciak, John
In-Reply-To: <500987B7.2030705@intel.com>
On Fri, 2012-07-20 at 09:30 -0700, John Fastabend wrote:
> On 7/18/2012 11:42 PM, Jiri Pirko wrote:
> > Thu, Jul 19, 2012 at 12:05:44AM CEST, john.r.fastabend@intel.com wrote:
> >> This adds support to allow virtual net devices to be created. These
> >> devices can be managed independtly of the physical function but
> >> use the same physical link.
>
> [...]
>
> >> +
> >> +size_t vmdq_getpriv_size(struct net *src_net, struct nlattr *tb[])
> >> +{
> >> + struct net_device *lowerdev;
> >> +
> >> + if (!tb[IFLA_LINK])
> >> + return -EINVAL;
> >> +
> >> + lowerdev = __dev_get_by_index(src_net, nla_get_u32(tb[IFLA_LINK]));
> >> + if (!lowerdev)
> >> + return -ENODEV;
> >> +
> >> + return sizeof(netdev_priv(lowerdev));
> >> +}
> >
> > Why exactly do you need to have the priv of same size as lowerdev? I do
> > not see you use that anywhere...
> >
>
> When we add a child device the hardware/sw may have some private data
> it needs to manage this device.
>
> I made an assumption here that the priv space for child devices is the
> same as the lowerdev but this might be a bad assumption.
The code assumes that it is the size of a single pointer...
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [PATCH net-next] tcp: use hash_32() in tcp_metrics
From: David Miller @ 2012-07-20 18:00 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1342774954.2626.6290.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 20 Jul 2012 11:02:34 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> Fix a missing roundup_pow_of_two(), since tcpmhash_entries is not
> guaranteed to be a power of two.
>
> Uses hash_32() instead of custom hash.
>
> tcpmhash_entries should be an unsigned int.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] tcp: Return bool instead of int where appropriate
From: David Miller @ 2012-07-20 18:00 UTC (permalink / raw)
To: eric.dumazet; +Cc: subramanian.vijay, netdev
In-Reply-To: <1342771377.2626.6102.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 20 Jul 2012 10:02:57 +0200
> On Fri, 2012-07-20 at 00:32 -0700, Vijay Subramanian wrote:
>> Applied to a set of static inline functions in tcp_input.c
>>
>> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
>> ---
>> net/ipv4/tcp_input.c | 16 ++++++++--------
>> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [trivial PATCH resend 2/2] ixgbe: use PCI_VENDOR_ID_INTEL
From: David Miller @ 2012-07-20 18:00 UTC (permalink / raw)
To: jeffrey.t.kirsher
Cc: jdmason, trivial, netdev, linux-kernel, jesse.brandeburg,
bruce.w.allan, carolyn.wyborny, donald.c.skidmore, gregory.v.rose,
peter.p.waskiewicz.jr, alexander.h.duyck, john.ronciak
In-Reply-To: <1342768629.2616.27.camel@jtkirshe-mobl>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 20 Jul 2012 00:17:09 -0700
> On Fri, 2012-07-20 at 00:02 -0700, Jon Mason wrote:
>> Use PCI_VENDOR_ID_INTEL from pci_ids.h instead of creating its own
>> vendor ID #define.
>>
>> Signed-off-by: Jon Mason <jdmason@kudzu.us>
...
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [trivial PATCH resend 1/2] ixgb: use PCI_VENDOR_ID_INTEL
From: David Miller @ 2012-07-20 18:00 UTC (permalink / raw)
To: jeffrey.t.kirsher
Cc: jdmason, trivial, netdev, linux-kernel, jesse.brandeburg,
bruce.w.allan, carolyn.wyborny, donald.c.skidmore, gregory.v.rose,
peter.p.waskiewicz.jr, alexander.h.duyck, john.ronciak
In-Reply-To: <1342768277.2616.22.camel@jtkirshe-mobl>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 20 Jul 2012 00:11:17 -0700
> On Fri, 2012-07-20 at 00:02 -0700, Jon Mason wrote:
>> Use PCI_VENDOR_ID_INTEL from pci_ids.h instead of creating its own
>> vendor ID #define.
>>
>> Signed-off-by: Jon Mason <jdmason@kudzu.us>
...
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH] myri10ge: update MAINTAINERS
From: David Miller @ 2012-07-20 17:59 UTC (permalink / raw)
To: jdmason; +Cc: netdev
In-Reply-To: <1342764673-16671-1-git-send-email-jdmason@kudzu.us>
From: Jon Mason <jdmason@kudzu.us>
Date: Thu, 19 Jul 2012 23:11:13 -0700
> Remove myself from myri10ge MAINTAINERS list
>
> Signed-off-by: Jon Mason <jdmason@kudzu.us>
Applied to net-next
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox