* Re: [PATCH 09/18] netfilter: ipv6: add IPv6 NAT support
From: Jan Engelhardt @ 2012-08-20 9:03 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netfilter-devel, netdev
In-Reply-To: <1345434006-16549-10-git-send-email-kaber@trash.net>
On Monday 2012-08-20 05:39, Patrick McHardy wrote:
>+static struct nf_hook_ops nf_nat_ipv6_ops[] __read_mostly = {
>+ /* Before packet filtering, change destination */
>+ {
>+ .hook = nf_nat_ipv6_in,
>+ .owner = THIS_MODULE,
>+ .pf = NFPROTO_IPV6,
>+ .hooknum = NF_INET_PRE_ROUTING,
>+ .priority = NF_IP_PRI_NAT_DST,
NF_IP6_PRI_NAT_DST
>+ .hook = nf_nat_ipv6_out,
>+ .owner = THIS_MODULE,
>+ .pf = NFPROTO_IPV6,
>+ .hooknum = NF_INET_POST_ROUTING,
>+ .priority = NF_IP_PRI_NAT_SRC,
IP6 too... (2 more occurrences)
>+static void nf_nat_ipv6_csum_recalc(struct sk_buff *skb,
>+ u8 proto, void *data, __sum16 *check,
>+ int datalen, int oldlen)
>+{
>+ const struct ipv6hdr *ipv6h = ipv6_hdr(skb);
>+ struct rt6_info *rt = (struct rt6_info *)skb_dst(skb);
>+
>+ if (skb->ip_summed != CHECKSUM_PARTIAL) {
Maybe invert to == CHECKSUM_PARTIAL like in p06/18.
^ permalink raw reply
* Re: regression with poll(2)
From: Mel Gorman @ 2012-08-20 9:04 UTC (permalink / raw)
To: Sage Weil
Cc: davem, netdev, linux-kernel, ceph-devel, neilb, a.p.zijlstra,
michaelc, emunson, eric.dumazet, sebastian, cl, akpm, torvalds
In-Reply-To: <alpine.DEB.2.00.1208191051150.15570@cobra.newdream.net>
On Sun, Aug 19, 2012 at 11:49:31AM -0700, Sage Weil wrote:
> I've bisected and identified this commit:
>
> netvm: propagate page->pfmemalloc to skb
>
> The skb->pfmemalloc flag gets set to true iff during the slab allocation
> of data in __alloc_skb that the the PFMEMALLOC reserves were used. If the
> packet is fragmented, it is possible that pages will be allocated from the
> PFMEMALLOC reserve without propagating this information to the skb. This
> patch propagates page->pfmemalloc from pages allocated for fragments to
> the skb.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: David S. Miller <davem@davemloft.net>
> Cc: Neil Brown <neilb@suse.de>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Mike Christie <michaelc@cs.wisc.edu>
> Cc: Eric B Munson <emunson@mgebm.net>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Christoph Lameter <cl@linux.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
Ok, thanks.
> I've retested several times and confirmed that this change leads to the
> breakage, and also confirmed that reverting it on top of -rc1 also fixes
> the problem.
>
> I've also added some additional instrumentation to my code and confirmed
> that the process is blocking on poll(2) while netstat is reporting
> data available on the socket.
>
> What can I do to help track this down?
>
Can the following patch be tested please? It is reported to fix an fio
regression that may be similar to what you are experiencing but has not
been picked up yet.
---8<---
From: Alex Shi <alex.shi@intel.com>
Subject: [PATCH] mm: correct page->pfmemalloc to fix deactivate_slab regression
commit cfd19c5a9ec (mm: only set page->pfmemalloc when
ALLOC_NO_WATERMARKS was used) try to narrow down page->pfmemalloc
setting, but it missed some places the pfmemalloc should be set.
So, in __slab_alloc, the unalignment pfmemalloc and ALLOC_NO_WATERMARKS
cause incorrect deactivate_slab() on our core2 server:
64.73% fio [kernel.kallsyms] [k] _raw_spin_lock
|
--- _raw_spin_lock
|
|---0.34%-- deactivate_slab
| __slab_alloc
| kmem_cache_alloc
| |
That causes our fio sync write performance has 40% regression.
This patch move the checking in get_page_from_freelist, that resolved
this issue.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
mm/page_alloc.c | 21 +++++++++++----------
1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 009ac28..07f1924 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1928,6 +1928,17 @@ this_zone_full:
zlc_active = 0;
goto zonelist_scan;
}
+
+ if (page)
+ /*
+ * page->pfmemalloc is set when ALLOC_NO_WATERMARKS was
+ * necessary to allocate the page. The expectation is
+ * that the caller is taking steps that will free more
+ * memory. The caller should avoid the page being used
+ * for !PFMEMALLOC purposes.
+ */
+ page->pfmemalloc = !!(alloc_flags & ALLOC_NO_WATERMARKS);
+
return page;
}
@@ -2389,14 +2400,6 @@ rebalance:
zonelist, high_zoneidx, nodemask,
preferred_zone, migratetype);
if (page) {
- /*
- * page->pfmemalloc is set when ALLOC_NO_WATERMARKS was
- * necessary to allocate the page. The expectation is
- * that the caller is taking steps that will free more
- * memory. The caller should avoid the page being used
- * for !PFMEMALLOC purposes.
- */
- page->pfmemalloc = true;
goto got_pg;
}
}
@@ -2569,8 +2572,6 @@ retry_cpuset:
page = __alloc_pages_slowpath(gfp_mask, order,
zonelist, high_zoneidx, nodemask,
preferred_zone, migratetype);
- else
- page->pfmemalloc = false;
trace_mm_page_alloc(page, order, gfp_mask, migratetype);
--
1.7.5.4
^ permalink raw reply related
* Re: [RFC Patch net-next] ipv6: unify conntrack reassembly expire code with standard one
From: Cong Wang @ 2012-08-20 9:06 UTC (permalink / raw)
To: Michal Kubeček
Cc: netdev, Herbert Xu, David S. Miller, Hideaki YOSHIFUJI,
Patrick McHardy, Shan Wei, Pablo Neira Ayuso, netfilter-devel
In-Reply-To: <1826853.rak2U42CMU@alaris>
Hi, Michal!
On Fri, 2012-08-17 at 19:05 +0200, Michal Kubeček wrote:
> On Friday 17 of August 2012 16:02EN, Cong Wang wrote:
> > Two years ago, Shan Wei tried to fix this:
> > http://patchwork.ozlabs.org/patch/43905/
> >
> ...
> >
> > As Herbert suggested, we could actually use the standard IPv6
> > reassembly code which follows RFC2460.
>
> I tested the patch and I ran into a problem in this place in
> ip6_expire_frag_queue():
>
> > net = container_of(fq->q.net, struct net, ipv6.frags);
>
> For frag queues coming from IPv6 conntrack, fq->q.net points to
> nf_init_frags which is not embedded into struct net so that the
> following device lookup leads to reading from an invalid address.
> The same problem has been discussed on the page linked above.
>
> I didn't test with current net-next source but as far as I can tell,
> this hasn't changed. Did I miss something?
>
No, you don't miss anything. I missed that piece of code, you are right
that nf_init_frags is not actually embedded, so that container_of()
doesn't work. I think we probably can save the struct net pointer in
struct netns_frags during inet_frags_init_net(), so that container_of()
can be eliminated.
Thanks for testing! I tried to test it too, but seems I can't trigger a
defragment. Any hints?
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 1/2] dt: introduce for_each_available_child_of_node, of_get_next_available_child
From: David Miller @ 2012-08-20 9:16 UTC (permalink / raw)
To: timur; +Cc: grant.likely, david.daney, netdev, devicetree-discuss
In-Reply-To: <1344986424-14360-1-git-send-email-timur@freescale.com>
From: Timur Tabi <timur@freescale.com>
Date: Tue, 14 Aug 2012 18:20:23 -0500
> Macro for_each_child_of_node() makes it easy to iterate over all of the
> children for a given device tree node, including those nodes that are
> marked as unavailable (i.e. status = "disabled").
>
> Introduce for_each_available_child_of_node(), which is like
> for_each_child_of_node(), but it automatically skips unavailable nodes.
> This also requires the introduction of helper function
> of_get_next_available_child(), which returns the next available child
> node.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/2] [v2] netdev/phy: skip disabled mdio-mux nodes
From: David Miller @ 2012-08-20 9:16 UTC (permalink / raw)
To: timur; +Cc: grant.likely, david.daney, netdev, devicetree-discuss
In-Reply-To: <1344986424-14360-2-git-send-email-timur@freescale.com>
From: Timur Tabi <timur@freescale.com>
Date: Tue, 14 Aug 2012 18:20:24 -0500
> The mdio-mux driver scans all child mdio nodes, without regard to whether
> the node is actually used. Some device trees include all possible
> mdio-mux nodes and rely on the boot loader to disable those that are not
> present, based on some run-time configuration. Those nodes need to be
> skipped.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: sh_eth: Add eth support for R8A7779 device
From: David Miller @ 2012-08-20 9:17 UTC (permalink / raw)
To: phil.edworthy
Cc: netdev, linux-sh, kuninori.morimoto.gx, yoshihiro.shimoda.uh
In-Reply-To: <1345012409-12915-1-git-send-email-phil.edworthy@renesas.com>
From: Phil Edworthy <phil.edworthy@renesas.com>
Date: Wed, 15 Aug 2012 07:33:29 +0100
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net] net: qmi_wwan: new devices: UML290 and K5006-Z
From: David Miller @ 2012-08-20 9:17 UTC (permalink / raw)
To: bjorn-yOkvZcmFvRU
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
dcbw-H+wXaHxf7aLQT0dZR+AlfA, tschaefer-zqRNUXuvxA0b1SvskN2V4Q
In-Reply-To: <1345038177-29189-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
From: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
Date: Wed, 15 Aug 2012 15:42:57 +0200
> Newer firmware versions for the Pantech UML290 use a different
> subclass ID. The Windows driver match on both IDs, so we do
> that as well.
>
> The ZTE (Vodafone) K5006-Z is a new device.
>
> Cc: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: Thomas Schäfer <tschaefer-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org>
> Signed-off-by: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 001/001] smsc95xx: Fix hard_header_len
From: David Miller @ 2012-08-20 9:19 UTC (permalink / raw)
To: steve; +Cc: bhutchings, jimbob.betts, netdev
In-Reply-To: <CAKh2mn6fr8WjT-2h_A3zmKv3xs26AamXcpJgtK5wFPQ1BXuheg@mail.gmail.com>
From: Steve Glendinning <steve@shawell.net>
Date: Fri, 17 Aug 2012 09:35:04 +0100
>> hard_header_len is set to ETH_HLEN by alloc_etherdev() (in the
>> ether_setup() callback). Any extra headroom you want before the
>> Ethernet header should indeed be specified in needed_headroom.
>
> Thanks Ben, looks like this patch is doing it the right way then.
>
> Acked-By: Steve Glendinning <steve.glendinning@shawell.net>
This patch needs to be submitted with a proper signoff.
^ permalink raw reply
* Re: [PATCH] smsc75xx: add missing entry to MAINTAINERS
From: David Miller @ 2012-08-20 9:20 UTC (permalink / raw)
To: steve.glendinning; +Cc: linux-kernel, netdev, trivial
In-Reply-To: <1345103618-22753-1-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Thu, 16 Aug 2012 08:53:38 +0100
> Signed-off-by: Steve Glendinning <steve.glendinning@shawell.net>
Applied.
^ permalink raw reply
* Re: [patch] gre: information leak in ip6_tnl_ioctl()
From: David Miller @ 2012-08-20 9:21 UTC (permalink / raw)
To: dan.carpenter
Cc: xeb, kuznet, jmorris, yoshfuji, kaber, netdev, kernel-janitors
In-Reply-To: <20120816131404.GA23188@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 16 Aug 2012 16:14:04 +0300
> There is a one byte hole between p->hop_limit and p->flowinfo where
> stack memory is leaked to the user. This was introduced in c12b395a46
> "gre: Support GRE over IPv6".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply
* Re: [PATCH 0/2] packet: Report fanout and rings via diag
From: David Miller @ 2012-08-20 9:23 UTC (permalink / raw)
To: xemul; +Cc: netdev
In-Reply-To: <502D125A.40701@parallels.com>
From: Pavel Emelyanov <xemul@parallels.com>
Date: Thu, 16 Aug 2012 19:31:38 +0400
> After this the packet diag module reports everything that can be
> configured on a packet socket via AF_PACKET-specific API.
>
> Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Applied to net-next, thanks.
^ permalink raw reply
* Re: [RFC PATCH net-next 0/9] tipc: misc updates for 3.7
From: David Miller @ 2012-08-20 9:27 UTC (permalink / raw)
To: paul.gortmaker; +Cc: netdev, jon.maloy, ying.xue
In-Reply-To: <1345154954-12526-1-git-send-email-paul.gortmaker@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Thu, 16 Aug 2012 18:09:05 -0400
> This series gets some more largely trivial things out of
> the way. Most interesting are:
>
> 1) fix lockdep splat from bearer init by pushing the setup
> off to schedule_work.
>
> 2) simplification of configuration by removal of a couple of
> tuning knobs which used to have low default values.
>
> The remainder are largely innocuous, I think. I did wonder
> if there was an alternate/better way to handle the splat though.
>
> I've done my own local testing of this series on today's net-next
> commit 2ea214929d601 ("Merge branch 'for-davem' ... wireless-next")
>
> I'll wait a couple of days to allow for any possible feedback and
> change requests, and then send a pull request after that.
All applied, thanks Paul.
It's less useful for you to build the GIT tree "later", at least for
me.
If the patches are good and there is no feedback asking for changes,
I want to be able to just pull them into my tree immediately as I
did here.
Thanks.
^ permalink raw reply
* Re: regression with poll(2)
From: Eric Dumazet @ 2012-08-20 9:30 UTC (permalink / raw)
To: Mel Gorman
Cc: Sage Weil, davem, netdev, linux-kernel, ceph-devel, neilb,
a.p.zijlstra, michaelc, emunson, sebastian, cl, akpm, torvalds
In-Reply-To: <20120820090443.GA3275@suse.de>
On Mon, 2012-08-20 at 10:04 +0100, Mel Gorman wrote:
> Can the following patch be tested please? It is reported to fix an fio
> regression that may be similar to what you are experiencing but has not
> been picked up yet.
>
> -
This seems to help here.
Boot your machine with "mem=768M" or a bit less depending on your setup,
and try a netperf.
-> before patch :
# netperf
MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to
localhost.localdomain () port 0 AF_INET
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
87380 16384 16384 14.00 6.05
-> after patch :
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
87380 16384 16384 10.00 18509.73
^ permalink raw reply
* Re: [net-next 0/9][pull request] Intel Wired LAN Driver Updates
From: David Miller @ 2012-08-20 9:31 UTC (permalink / raw)
To: peter.p.waskiewicz.jr; +Cc: netdev, gospo, sassmann
In-Reply-To: <1345157318-23731-1-git-send-email-peter.p.waskiewicz.jr@intel.com>
From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Date: Thu, 16 Aug 2012 15:48:29 -0700
> This series contains multiple updates to the ixgbe driver.
>
> The following are changes since commit 02644a17457414f38e29f32d5c640b06d08fa092:
> sctp: fix bogus if statement in sctp_auth_recv_cid()
>
> and are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/ppwaskie/net-next master
Pulled, thanks a lot PJ.
^ permalink raw reply
* Re: [PATCH 0/3] fix error return code
From: David Miller @ 2012-08-20 9:33 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux-kernel
In-Reply-To: <1345189618-13758-1-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Fri, 17 Aug 2012 09:46:55 +0200
> These patches fix cases where the return code appears to be unintentially
> nonnegative.
All applied, thanks Julia.
^ permalink raw reply
* Re: [PATCH v1.1] af_packet: don't emit packet on orig fanout group
From: David Miller @ 2012-08-20 9:37 UTC (permalink / raw)
To: eric; +Cc: netdev
In-Reply-To: <1345190578-28722-1-git-send-email-eric@regit.org>
From: Eric Leblond <eric@regit.org>
Date: Fri, 17 Aug 2012 10:02:58 +0200
> If a packet is emitted on one socket in one group of fanout sockets,
> it is transmitted again. It is thus read again on one of the sockets
> of the fanout group. This result in a loop for software which
> generate packets when receiving one.
> This retransmission is not the intended behavior: a fanout group
> must behave like a single socket. The packet should not be
> transmitted on a socket if it originates from a socket belonging
> to the same fanout group.
>
> This patch fixes the issue by changing the transmission check to
> take fanout group info account.
>
> Reported-by: Aleksandr Kotov <a1k@mail.ru>
> Signed-off-by: Eric Leblond <eric@regit.org>
Applied, thanks a lot Eric.
^ permalink raw reply
* Re: [patch net-next] team: add support for non-ethernet devices
From: David Miller @ 2012-08-20 9:42 UTC (permalink / raw)
To: jiri; +Cc: netdev
In-Reply-To: <1345212048-1378-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 17 Aug 2012 16:00:48 +0200
> This is resolved by two things:
> 1) allow dev_addr of different length than ETH_ALEN
> 2) during port add, check for dev->type and change it if necessary
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Looks good, applied, thanks Jiri.
^ permalink raw reply
* Re: [PATCH 0/5] netfilter fixes for 3.6-rc
From: David Miller @ 2012-08-20 9:45 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
In-Reply-To: <1345212573-3076-1-git-send-email-pablo@netfilter.org>
From: pablo@netfilter.org
Date: Fri, 17 Aug 2012 16:09:28 +0200
> The following five patches contain fixes for 3.6-rc, they are:
>
> * Two fixes for message parsing in the SIP conntrack helper, from
> Patrick McHardy.
>
> * One fix for the SIP helper introduced in the user-space cthelper
> infrastructure, from Patrick McHardy.
>
> * fix missing appropriate locking while modifying one conntrack entry
> from the nfqueue integration code, from myself.
>
> * fix possible access to uninitiliazed timer in the nf_conntrack
> expectation infrastructure, from myself.
>
> You can pull these changes from:
>
> git://1984.lsi.us.es/nf
Pulled, thanks Pablo.
^ permalink raw reply
* Re: [PATCH] caif: Do not dereference NULL in chnl_recv_cb()
From: David Miller @ 2012-08-20 9:48 UTC (permalink / raw)
To: sjur.brandeland; +Cc: jj, linux-kernel, netdev, daniel.martensson
In-Reply-To: <81C3A93C17462B4BBD7E272753C1057923B924D522@EXDCVYMBSTM005.EQ1STM.local>
From: Sjur BRENDELAND <sjur.brandeland@stericsson.com>
Date: Mon, 20 Aug 2012 08:33:35 +0200
>> In net/caif/chnl_net.c::chnl_recv_cb() we call skb_header_pointer()
>> which may return NULL, but we do not check for a NULL pointer before
>> dereferencing it.
>> This patch adds such a NULL check and properly free's allocated memory
>> and return an error (-EINVAL) on failure - much better than crashing..
>>
>> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
>
> Thank you for fixing this, the patch looks good to me.
> Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] ipv4: Use netinet->inet_opt in inet_csk_route_child_sock()
From: David Miller @ 2012-08-20 9:51 UTC (permalink / raw)
To: christoph.paasch; +Cc: netdev
In-Reply-To: <1345239312-19266-1-git-send-email-christoph.paasch@uclouvain.be>
From: Christoph Paasch <christoph.paasch@uclouvain.be>
Date: Fri, 17 Aug 2012 23:35:12 +0200
> @@ -404,7 +404,7 @@ struct dst_entry *inet_csk_route_child_sock(struct sock *sk,
> {
> const struct inet_request_sock *ireq = inet_rsk(req);
> struct inet_sock *newinet = inet_sk(newsk);
> - struct ip_options_rcu *opt = ireq->opt;
> + struct ip_options_rcu *opt = rcu_dereference(newinet->inet_opt);
> struct net *net = sock_net(sk);
We're not inside of a rcu_read_lock() protected section, so this access
is not legitimate. If you enabled RCU lock debugging, you would have
triggered a warning in the kernel log.
^ permalink raw reply
* Re: [PATCH] net/stmmac: fix issue of clk_get for Loongson1B.
From: David Miller @ 2012-08-20 9:52 UTC (permalink / raw)
To: keguang.zhang; +Cc: netdev, linux-kernel, peppe.cavallaro
In-Reply-To: <1345284983-12610-1-git-send-email-keguang.zhang@gmail.com>
From: Kelvin Cheung <keguang.zhang@gmail.com>
Date: Sat, 18 Aug 2012 18:16:23 +0800
> When getting clock, give a chance to the CPUs without DT support,
> which use Common Clock Framework, such as Loongson1B.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH]: net: ipv6: fix oops in inet_putpeer()
From: David Miller @ 2012-08-20 9:58 UTC (permalink / raw)
To: kaber; +Cc: netdev
In-Reply-To: <Pine.GSO.4.63.1208181729020.7404@stinky-local.trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Sat, 18 Aug 2012 17:32:31 +0200 (MEST)
> The attached patch fixes an oops in inet_putpeer(). Please see the
> changelog entry for details.
>
> An alternative fix would be to check whether rt6_peer_ptr() returns
> NULL before invoking inet_putpeer(), but properly initializing the
> peer looks cleaner to me.
This is fine for now, applied, thanks Patrick.
There was a built-in assumption that xfrm_fill_dst() would run to
completion before we'd try to release these things, because there in
xfrm6_policy.c's xfrm6_fill_dst, we'd do the rt6_transfer_peer().
But that's obviously not the case if errors happen meanwhile.
^ permalink raw reply
* Re: [Patch] netconsole: remove a redundant netconsole_target_put()
From: David Miller @ 2012-08-20 10:00 UTC (permalink / raw)
To: amwang; +Cc: netdev, stable
In-Reply-To: <1345309340-15499-1-git-send-email-amwang@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Sun, 19 Aug 2012 01:02:20 +0800
> This netconsole_target_put() is obviously redundant, and it
> causes a kernel segfault when removing a bridge device which has
> netconsole running on it.
>
> This is caused by:
>
> commit 8d8fc29d02a33e4bd5f4fa47823c1fd386346093
> Author: Amerigo Wang <amwang@redhat.com>
> Date: Thu May 19 21:39:10 2011 +0000
>
> netpoll: disable netpoll when enslave a device
>
> Cc: David Miller <davem@davemloft.net>
> (for all 3.x stable releases)
> Cc: stable@vger.kernel.org
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] net/core/dev.c: fix kernel-doc warning
From: David Miller @ 2012-08-20 10:01 UTC (permalink / raw)
To: rdunlap; +Cc: netdev
In-Reply-To: <5030351C.8080000@xenotime.net>
From: Randy Dunlap <rdunlap@xenotime.net>
Date: Sat, 18 Aug 2012 17:36:44 -0700
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix kernel-doc warning:
>
> Warning(net/core/dev.c:5745): No description found for parameter 'dev'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net v2] net: tcp: move sk_rx_dst_set call after tcp_create_openreq_child()
From: David Miller @ 2012-08-20 10:04 UTC (permalink / raw)
To: eric.dumazet; +Cc: ncardwell, netdev, edumazet
In-Reply-To: <1345383675.5158.202.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 19 Aug 2012 15:41:15 +0200
> On Sun, 2012-08-19 at 09:30 -0400, Neal Cardwell wrote:
>> This commit removes the sk_rx_dst_set calls from
>> tcp_create_openreq_child(), because at that point the icsk_af_ops
>> field of ipv6_mapped TCP sockets has not been set to its proper final
>> value.
>>
>> Instead, to make sure we get the right sk_rx_dst_set variant
>> appropriate for the address family of the new connection, we have
>> tcp_v{4,6}_syn_recv_sock() directly call the appropriate function
>> shortly after the call to tcp_create_openreq_child() returns.
>>
>> This also moves inet6_sk_rx_dst_set() to avoid a forward declaration
>> with the new approach.
>>
>> Signed-off-by: Neal Cardwell <ncardwell@google.com>
>> Reported-by: Artem Savkov <artem.savkov@gmail.com>
>> Cc: Eric Dumazet <edumazet@google.com>
>> ---
>> net/ipv4/tcp_ipv4.c | 1 +
>> net/ipv4/tcp_minisocks.c | 2 --
>> net/ipv6/tcp_ipv6.c | 25 +++++++++++++------------
>> 3 files changed, 14 insertions(+), 14 deletions(-)
>
> Thanks Neal !
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied, thanks everyone.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox