Netdev List
 help / color / mirror / Atom feed
* [PATCH 070/493] isdn: remove use of __devexit_p
From: Bill Pemberton @ 2012-11-19 18:20 UTC (permalink / raw)
  To: gregkh; +Cc: Karsten Keil, Armin Schindler, netdev
In-Reply-To: <1353349642-3677-1-git-send-email-wfp5p@virginia.edu>

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Karsten Keil <isdn@linux-pingi.de> 
Cc: Armin Schindler <mac@melware.de> 
Cc: netdev@vger.kernel.org 
---
 drivers/isdn/hardware/avm/b1pci.c           | 2 +-
 drivers/isdn/hardware/eicon/divasmain.c     | 2 +-
 drivers/isdn/hardware/mISDN/avmfritz.c      | 2 +-
 drivers/isdn/hardware/mISDN/hfcmulti.c      | 2 +-
 drivers/isdn/hardware/mISDN/hfcpci.c        | 2 +-
 drivers/isdn/hardware/mISDN/mISDNinfineon.c | 2 +-
 drivers/isdn/hardware/mISDN/netjet.c        | 2 +-
 drivers/isdn/hardware/mISDN/speedfax.c      | 2 +-
 drivers/isdn/hardware/mISDN/w6692.c         | 2 +-
 drivers/isdn/hisax/avma1_cs.c               | 2 +-
 drivers/isdn/hisax/elsa_cs.c                | 2 +-
 drivers/isdn/hisax/hfc4s8s_l1.c             | 2 +-
 drivers/isdn/hisax/hisax_fcpcipnp.c         | 4 ++--
 drivers/isdn/hisax/sedlbauer_cs.c           | 2 +-
 drivers/isdn/hisax/teles_cs.c               | 2 +-
 drivers/isdn/hysdn/hysdn_init.c             | 2 +-
 16 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/drivers/isdn/hardware/avm/b1pci.c b/drivers/isdn/hardware/avm/b1pci.c
index b305e6b..cc1b671 100644
--- a/drivers/isdn/hardware/avm/b1pci.c
+++ b/drivers/isdn/hardware/avm/b1pci.c
@@ -362,7 +362,7 @@ static struct pci_driver b1pci_pci_driver = {
 	.name		= "b1pci",
 	.id_table	= b1pci_pci_tbl,
 	.probe		= b1pci_pci_probe,
-	.remove		= __devexit_p(b1pci_pci_remove),
+	.remove		= b1pci_pci_remove,
 };
 
 static struct capi_driver capi_driver_b1pci = {
diff --git a/drivers/isdn/hardware/eicon/divasmain.c b/drivers/isdn/hardware/eicon/divasmain.c
index ca6d276..3dfe2bb 100644
--- a/drivers/isdn/hardware/eicon/divasmain.c
+++ b/drivers/isdn/hardware/eicon/divasmain.c
@@ -155,7 +155,7 @@ static void __devexit divas_remove_one(struct pci_dev *pdev);
 static struct pci_driver diva_pci_driver = {
 	.name     = "divas",
 	.probe    = divas_init_one,
-	.remove   = __devexit_p(divas_remove_one),
+	.remove   = divas_remove_one,
 	.id_table = divas_pci_tbl,
 };
 
diff --git a/drivers/isdn/hardware/mISDN/avmfritz.c b/drivers/isdn/hardware/mISDN/avmfritz.c
index dceaec8..922f29f 100644
--- a/drivers/isdn/hardware/mISDN/avmfritz.c
+++ b/drivers/isdn/hardware/mISDN/avmfritz.c
@@ -1154,7 +1154,7 @@ MODULE_DEVICE_TABLE(pci, fcpci_ids);
 static struct pci_driver fcpci_driver = {
 	.name = "fcpci",
 	.probe = fritzpci_probe,
-	.remove = __devexit_p(fritz_remove_pci),
+	.remove = fritz_remove_pci,
 	.id_table = fcpci_ids,
 };
 
diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
index f027942..ad6cf8e 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -5472,7 +5472,7 @@ hfcmulti_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 static struct pci_driver hfcmultipci_driver = {
 	.name		= "hfc_multi",
 	.probe		= hfcmulti_probe,
-	.remove		= __devexit_p(hfc_remove_pci),
+	.remove		= hfc_remove_pci,
 	.id_table	= hfmultipci_ids,
 };
 
diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 6e99d73..580e629 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -2263,7 +2263,7 @@ hfc_remove_pci(struct pci_dev *pdev)
 static struct pci_driver hfc_driver = {
 	.name = "hfcpci",
 	.probe = hfc_probe,
-	.remove = __devexit_p(hfc_remove_pci),
+	.remove = hfc_remove_pci,
 	.id_table = hfc_ids,
 };
 
diff --git a/drivers/isdn/hardware/mISDN/mISDNinfineon.c b/drivers/isdn/hardware/mISDN/mISDNinfineon.c
index 631eb3f..a43fddf 100644
--- a/drivers/isdn/hardware/mISDN/mISDNinfineon.c
+++ b/drivers/isdn/hardware/mISDN/mISDNinfineon.c
@@ -1149,7 +1149,7 @@ inf_remove(struct pci_dev *pdev)
 static struct pci_driver infineon_driver = {
 	.name = "ISDN Infineon pci",
 	.probe = inf_probe,
-	.remove = __devexit_p(inf_remove),
+	.remove = inf_remove,
 	.id_table = infineon_ids,
 };
 
diff --git a/drivers/isdn/hardware/mISDN/netjet.c b/drivers/isdn/hardware/mISDN/netjet.c
index 9bcade5..2cfed9f 100644
--- a/drivers/isdn/hardware/mISDN/netjet.c
+++ b/drivers/isdn/hardware/mISDN/netjet.c
@@ -1147,7 +1147,7 @@ MODULE_DEVICE_TABLE(pci, nj_pci_ids);
 static struct pci_driver nj_driver = {
 	.name = "netjet",
 	.probe = nj_probe,
-	.remove = __devexit_p(nj_remove),
+	.remove = nj_remove,
 	.id_table = nj_pci_ids,
 };
 
diff --git a/drivers/isdn/hardware/mISDN/speedfax.c b/drivers/isdn/hardware/mISDN/speedfax.c
index 93f344d..92c6059 100644
--- a/drivers/isdn/hardware/mISDN/speedfax.c
+++ b/drivers/isdn/hardware/mISDN/speedfax.c
@@ -507,7 +507,7 @@ MODULE_DEVICE_TABLE(pci, sfaxpci_ids);
 static struct pci_driver sfaxpci_driver = {
 	.name = "speedfax+ pci",
 	.probe = sfaxpci_probe,
-	.remove = __devexit_p(sfax_remove_pci),
+	.remove = sfax_remove_pci,
 	.id_table = sfaxpci_ids,
 };
 
diff --git a/drivers/isdn/hardware/mISDN/w6692.c b/drivers/isdn/hardware/mISDN/w6692.c
index 335fe64..34be200 100644
--- a/drivers/isdn/hardware/mISDN/w6692.c
+++ b/drivers/isdn/hardware/mISDN/w6692.c
@@ -1414,7 +1414,7 @@ MODULE_DEVICE_TABLE(pci, w6692_ids);
 static struct pci_driver w6692_driver = {
 	.name =  "w6692",
 	.probe = w6692_probe,
-	.remove = __devexit_p(w6692_remove_pci),
+	.remove = w6692_remove_pci,
 	.id_table = w6692_ids,
 };
 
diff --git a/drivers/isdn/hisax/avma1_cs.c b/drivers/isdn/hisax/avma1_cs.c
index c644557..7f5d8b6 100644
--- a/drivers/isdn/hisax/avma1_cs.c
+++ b/drivers/isdn/hisax/avma1_cs.c
@@ -156,7 +156,7 @@ static struct pcmcia_driver avma1cs_driver = {
 	.owner		= THIS_MODULE,
 	.name		= "avma1_cs",
 	.probe		= avma1cs_probe,
-	.remove		= __devexit_p(avma1cs_detach),
+	.remove		= avma1cs_detach,
 	.id_table	= avma1cs_ids,
 };
 
diff --git a/drivers/isdn/hisax/elsa_cs.c b/drivers/isdn/hisax/elsa_cs.c
index a8c4d3f..231ec71 100644
--- a/drivers/isdn/hisax/elsa_cs.c
+++ b/drivers/isdn/hisax/elsa_cs.c
@@ -210,7 +210,7 @@ static struct pcmcia_driver elsa_cs_driver = {
 	.owner		= THIS_MODULE,
 	.name		= "elsa_cs",
 	.probe		= elsa_cs_probe,
-	.remove		= __devexit_p(elsa_cs_detach),
+	.remove		= elsa_cs_detach,
 	.id_table	= elsa_ids,
 	.suspend	= elsa_suspend,
 	.resume		= elsa_resume,
diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c
index f794850..e85b612 100644
--- a/drivers/isdn/hisax/hfc4s8s_l1.c
+++ b/drivers/isdn/hisax/hfc4s8s_l1.c
@@ -1662,7 +1662,7 @@ hfc4s8s_remove(struct pci_dev *pdev)
 static struct pci_driver hfc4s8s_driver = {
 	.name	= "hfc4s8s_l1",
 	.probe	= hfc4s8s_probe,
-	.remove	= __devexit_p(hfc4s8s_remove),
+	.remove	= hfc4s8s_remove,
 	.id_table	= hfc4s8s_ids,
 };
 
diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c b/drivers/isdn/hisax/hisax_fcpcipnp.c
index e4f47fe..3d063d1 100644
--- a/drivers/isdn/hisax/hisax_fcpcipnp.c
+++ b/drivers/isdn/hisax/hisax_fcpcipnp.c
@@ -973,7 +973,7 @@ static void __devexit fcpnp_remove(struct pnp_dev *pdev)
 static struct pnp_driver fcpnp_driver = {
 	.name		= "fcpnp",
 	.probe		= fcpnp_probe,
-	.remove		= __devexit_p(fcpnp_remove),
+	.remove		= fcpnp_remove,
 	.id_table	= fcpnp_ids,
 };
 #endif
@@ -990,7 +990,7 @@ static void __devexit fcpci_remove(struct pci_dev *pdev)
 static struct pci_driver fcpci_driver = {
 	.name		= "fcpci",
 	.probe		= fcpci_probe,
-	.remove		= __devexit_p(fcpci_remove),
+	.remove		= fcpci_remove,
 	.id_table	= fcpci_ids,
 };
 
diff --git a/drivers/isdn/hisax/sedlbauer_cs.c b/drivers/isdn/hisax/sedlbauer_cs.c
index f0dfc0c..42abb24 100644
--- a/drivers/isdn/hisax/sedlbauer_cs.c
+++ b/drivers/isdn/hisax/sedlbauer_cs.c
@@ -201,7 +201,7 @@ static struct pcmcia_driver sedlbauer_driver = {
 	.owner		= THIS_MODULE,
 	.name		= "sedlbauer_cs",
 	.probe		= sedlbauer_probe,
-	.remove		= __devexit_p(sedlbauer_detach),
+	.remove		= sedlbauer_detach,
 	.id_table	= sedlbauer_ids,
 	.suspend	= sedlbauer_suspend,
 	.resume		= sedlbauer_resume,
diff --git a/drivers/isdn/hisax/teles_cs.c b/drivers/isdn/hisax/teles_cs.c
index 4deac45..a36fa04 100644
--- a/drivers/isdn/hisax/teles_cs.c
+++ b/drivers/isdn/hisax/teles_cs.c
@@ -192,7 +192,7 @@ static struct pcmcia_driver teles_cs_driver = {
 	.owner		= THIS_MODULE,
 	.name		= "teles_cs",
 	.probe		= teles_probe,
-	.remove		= __devexit_p(teles_detach),
+	.remove		= teles_detach,
 	.id_table       = teles_ids,
 	.suspend	= teles_suspend,
 	.resume		= teles_resume,
diff --git a/drivers/isdn/hysdn/hysdn_init.c b/drivers/isdn/hysdn/hysdn_init.c
index b61bbb4..c103c28 100644
--- a/drivers/isdn/hysdn/hysdn_init.c
+++ b/drivers/isdn/hysdn/hysdn_init.c
@@ -147,7 +147,7 @@ static struct pci_driver hysdn_pci_driver = {
 	.name		= "hysdn",
 	.id_table	= hysdn_pci_tbl,
 	.probe		= hysdn_pci_init_one,
-	.remove		= __devexit_p(hysdn_pci_remove_one),
+	.remove		= hysdn_pci_remove_one,
 };
 
 static int hysdn_have_procfs;
-- 
1.8.0

^ permalink raw reply related

* [PATCH 018/493] net: remove CONFIG_HOTPLUG ifdefs
From: Bill Pemberton @ 2012-11-19 18:19 UTC (permalink / raw)
  To: gregkh; +Cc: David S. Miller, netdev
In-Reply-To: <1353349642-3677-1-git-send-email-wfp5p@virginia.edu>

Remove conditional code based on CONFIG_HOTPLUG being false.  It's
always on now in preparation of it going away as an option.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: "David S. Miller" <davem@davemloft.net> 
Cc: netdev@vger.kernel.org 
---
 net/core/net-sysfs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index bcf02f6..adcb1b5 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1320,7 +1320,6 @@ struct kobj_ns_type_operations net_ns_type_operations = {
 };
 EXPORT_SYMBOL_GPL(net_ns_type_operations);
 
-#ifdef CONFIG_HOTPLUG
 static int netdev_uevent(struct device *d, struct kobj_uevent_env *env)
 {
 	struct net_device *dev = to_net_dev(d);
@@ -1339,7 +1338,6 @@ static int netdev_uevent(struct device *d, struct kobj_uevent_env *env)
 exit:
 	return retval;
 }
-#endif
 
 /*
  *	netdev_release -- destroy and free a dead device.
@@ -1368,9 +1366,7 @@ static struct class net_class = {
 #ifdef CONFIG_SYSFS
 	.dev_attrs = net_class_attributes,
 #endif /* CONFIG_SYSFS */
-#ifdef CONFIG_HOTPLUG
 	.dev_uevent = netdev_uevent,
-#endif
 	.ns_type = &net_ns_type_operations,
 	.namespace = net_namespace,
 };
-- 
1.8.0

^ permalink raw reply related

* [PATCH 010/493] isdn: remove CONFIG_HOTPLUG ifdefs
From: Bill Pemberton @ 2012-11-19 18:19 UTC (permalink / raw)
  To: gregkh; +Cc: Karsten Keil, netdev
In-Reply-To: <1353349642-3677-1-git-send-email-wfp5p@virginia.edu>

Remove conditional code based on CONFIG_HOTPLUG being false.  It's
always on now in preparation of it going away as an option.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Karsten Keil <isdn@linux-pingi.de> 
Cc: netdev@vger.kernel.org 
---
 drivers/isdn/hisax/config.c     | 3 ---
 drivers/isdn/hisax/hfc4s8s_l1.c | 8 --------
 drivers/isdn/mISDN/core.c       | 4 ----
 3 files changed, 15 deletions(-)

diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index b5edc0e..386f544 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn/hisax/config.c
@@ -1547,8 +1547,6 @@ static void __exit HiSax_exit(void)
 	printk(KERN_INFO "HiSax module removed\n");
 }
 
-#ifdef CONFIG_HOTPLUG
-
 int __devinit hisax_init_pcmcia(void *pcm_iob, int *busy_flag, struct IsdnCard *card)
 {
 	u_char ids[16];
@@ -1570,7 +1568,6 @@ error:
 }
 
 EXPORT_SYMBOL(hisax_init_pcmcia);
-#endif
 
 EXPORT_SYMBOL(HiSax_closecard);
 
diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c
index dea04de..f794850 100644
--- a/drivers/isdn/hisax/hfc4s8s_l1.c
+++ b/drivers/isdn/hisax/hfc4s8s_l1.c
@@ -1688,14 +1688,6 @@ hfc4s8s_module_init(void)
 	}
 	printk(KERN_INFO "HFC-4S/8S: found %d cards\n", card_cnt);
 
-#if !defined(CONFIG_HOTPLUG)
-	if (err == 0) {
-		err = -ENODEV;
-		pci_unregister_driver(&hfc4s8s_driver);
-		goto out;
-	}
-#endif
-
 	return 0;
 out:
 	return (err);
diff --git a/drivers/isdn/mISDN/core.c b/drivers/isdn/mISDN/core.c
index c401634..3e24571 100644
--- a/drivers/isdn/mISDN/core.c
+++ b/drivers/isdn/mISDN/core.c
@@ -140,7 +140,6 @@ static struct device_attribute mISDN_dev_attrs[] = {
 	{}
 };
 
-#ifdef CONFIG_HOTPLUG
 static int mISDN_uevent(struct device *dev, struct kobj_uevent_env *env)
 {
 	struct mISDNdevice *mdev = dev_to_mISDN(dev);
@@ -153,7 +152,6 @@ static int mISDN_uevent(struct device *dev, struct kobj_uevent_env *env)
 
 	return 0;
 }
-#endif
 
 static void mISDN_class_release(struct class *cls)
 {
@@ -163,9 +161,7 @@ static void mISDN_class_release(struct class *cls)
 static struct class mISDN_class = {
 	.name = "mISDN",
 	.owner = THIS_MODULE,
-#ifdef CONFIG_HOTPLUG
 	.dev_uevent = mISDN_uevent,
-#endif
 	.dev_attrs = mISDN_dev_attrs,
 	.dev_release = mISDN_dev_release,
 	.class_release = mISDN_class_release,
-- 
1.8.0

^ permalink raw reply related

* [PATCH 082/493] ieee802154: remove use of __devexit_p
From: Bill Pemberton @ 2012-11-19 18:20 UTC (permalink / raw)
  To: gregkh; +Cc: netdev
In-Reply-To: <1353349642-3677-1-git-send-email-wfp5p@virginia.edu>

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: netdev@vger.kernel.org 
---
 drivers/net/ieee802154/at86rf230.c | 2 +-
 drivers/net/ieee802154/fakehard.c  | 2 +-
 drivers/net/ieee802154/fakelb.c    | 2 +-
 drivers/net/ieee802154/mrf24j40.c  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index ba753d8..cbb08de 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -947,7 +947,7 @@ static struct spi_driver at86rf230_driver = {
 		.owner	= THIS_MODULE,
 	},
 	.probe      = at86rf230_probe,
-	.remove     = __devexit_p(at86rf230_remove),
+	.remove     = at86rf230_remove,
 	.suspend    = at86rf230_suspend,
 	.resume     = at86rf230_resume,
 };
diff --git a/drivers/net/ieee802154/fakehard.c b/drivers/net/ieee802154/fakehard.c
index 7d39add..8c719e0 100644
--- a/drivers/net/ieee802154/fakehard.c
+++ b/drivers/net/ieee802154/fakehard.c
@@ -423,7 +423,7 @@ static struct platform_device *ieee802154fake_dev;
 
 static struct platform_driver ieee802154fake_driver = {
 	.probe = ieee802154fake_probe,
-	.remove = __devexit_p(ieee802154fake_remove),
+	.remove = ieee802154fake_remove,
 	.driver = {
 			.name = "ieee802154hardmac",
 			.owner = THIS_MODULE,
diff --git a/drivers/net/ieee802154/fakelb.c b/drivers/net/ieee802154/fakelb.c
index e7456fc..2d2e027 100644
--- a/drivers/net/ieee802154/fakelb.c
+++ b/drivers/net/ieee802154/fakelb.c
@@ -269,7 +269,7 @@ static struct platform_device *ieee802154fake_dev;
 
 static struct platform_driver ieee802154fake_driver = {
 	.probe = fakelb_probe,
-	.remove = __devexit_p(fakelb_remove),
+	.remove = fakelb_remove,
 	.driver = {
 			.name = "ieee802154fakelb",
 			.owner = THIS_MODULE,
diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index ed75216..90b5467 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -746,7 +746,7 @@ static struct spi_driver mrf24j40_driver = {
 	},
 	.id_table = mrf24j40_ids,
 	.probe = mrf24j40_probe,
-	.remove = __devexit_p(mrf24j40_remove),
+	.remove = mrf24j40_remove,
 };
 
 static int __init mrf24j40_init(void)
-- 
1.8.0

^ permalink raw reply related

* [PATCH 189/493] ssb: remove use of __devinit
From: Bill Pemberton @ 2012-11-19 18:22 UTC (permalink / raw)
  To: gregkh; +Cc: Michael Buesch, netdev
In-Reply-To: <1353349642-3677-1-git-send-email-wfp5p@virginia.edu>

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Michael Buesch <m@bues.ch> 
Cc: netdev@vger.kernel.org 
---
 drivers/ssb/driver_gige.c     |  6 +++---
 drivers/ssb/driver_pcicore.c  | 10 +++++-----
 drivers/ssb/main.c            | 12 ++++++------
 drivers/ssb/pcihost_wrapper.c |  4 ++--
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
index f30ea68..b0e995d 100644
--- a/drivers/ssb/driver_gige.c
+++ b/drivers/ssb/driver_gige.c
@@ -107,7 +107,7 @@ void gige_pcicfg_write32(struct ssb_gige *dev,
 	gige_write32(dev, SSB_GIGE_PCICFG + offset, value);
 }
 
-static int __devinit ssb_gige_pci_read_config(struct pci_bus *bus,
+static int ssb_gige_pci_read_config(struct pci_bus *bus,
 					      unsigned int devfn, int reg,
 					      int size, u32 *val)
 {
@@ -138,7 +138,7 @@ static int __devinit ssb_gige_pci_read_config(struct pci_bus *bus,
 	return PCIBIOS_SUCCESSFUL;
 }
 
-static int __devinit ssb_gige_pci_write_config(struct pci_bus *bus,
+static int ssb_gige_pci_write_config(struct pci_bus *bus,
 					       unsigned int devfn, int reg,
 					       int size, u32 val)
 {
@@ -169,7 +169,7 @@ static int __devinit ssb_gige_pci_write_config(struct pci_bus *bus,
 	return PCIBIOS_SUCCESSFUL;
 }
 
-static int __devinit ssb_gige_probe(struct ssb_device *sdev,
+static int ssb_gige_probe(struct ssb_device *sdev,
 				    const struct ssb_device_id *id)
 {
 	struct ssb_gige *dev;
diff --git a/drivers/ssb/driver_pcicore.c b/drivers/ssb/driver_pcicore.c
index 49d2091..59801d2 100644
--- a/drivers/ssb/driver_pcicore.c
+++ b/drivers/ssb/driver_pcicore.c
@@ -315,7 +315,7 @@ int ssb_pcicore_pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
 	return ssb_mips_irq(extpci_core->dev) + 2;
 }
 
-static void __devinit ssb_pcicore_init_hostmode(struct ssb_pcicore *pc)
+static void ssb_pcicore_init_hostmode(struct ssb_pcicore *pc)
 {
 	u32 val;
 
@@ -380,7 +380,7 @@ static void __devinit ssb_pcicore_init_hostmode(struct ssb_pcicore *pc)
 	register_pci_controller(&ssb_pcicore_controller);
 }
 
-static int __devinit pcicore_is_in_hostmode(struct ssb_pcicore *pc)
+static int pcicore_is_in_hostmode(struct ssb_pcicore *pc)
 {
 	struct ssb_bus *bus = pc->dev->bus;
 	u16 chipid_top;
@@ -413,7 +413,7 @@ static int __devinit pcicore_is_in_hostmode(struct ssb_pcicore *pc)
  * Workarounds.
  **************************************************/
 
-static void __devinit ssb_pcicore_fix_sprom_core_index(struct ssb_pcicore *pc)
+static void ssb_pcicore_fix_sprom_core_index(struct ssb_pcicore *pc)
 {
 	u16 tmp = pcicore_read16(pc, SSB_PCICORE_SPROM(0));
 	if (((tmp & 0xF000) >> 12) != pc->dev->core_index) {
@@ -515,7 +515,7 @@ static void ssb_pcicore_pcie_setup_workarounds(struct ssb_pcicore *pc)
  * Generic and Clientmode operation code.
  **************************************************/
 
-static void __devinit ssb_pcicore_init_clientmode(struct ssb_pcicore *pc)
+static void ssb_pcicore_init_clientmode(struct ssb_pcicore *pc)
 {
 	struct ssb_device *pdev = pc->dev;
 	struct ssb_bus *bus = pdev->bus;
@@ -534,7 +534,7 @@ static void __devinit ssb_pcicore_init_clientmode(struct ssb_pcicore *pc)
 	}
 }
 
-void __devinit ssb_pcicore_init(struct ssb_pcicore *pc)
+void ssb_pcicore_init(struct ssb_pcicore *pc)
 {
 	struct ssb_device *dev = pc->dev;
 
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index df0f145..bfde3ee 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -542,7 +542,7 @@ error:
 }
 
 /* Needs ssb_buses_lock() */
-static int __devinit ssb_attach_queued_buses(void)
+static int ssb_attach_queued_buses(void)
 {
 	struct ssb_bus *bus, *n;
 	int err = 0;
@@ -753,7 +753,7 @@ out:
 	return err;
 }
 
-static int __devinit ssb_bus_register(struct ssb_bus *bus,
+static int ssb_bus_register(struct ssb_bus *bus,
 				      ssb_invariants_func_t get_invariants,
 				      unsigned long baseaddr)
 {
@@ -836,7 +836,7 @@ err_disable_xtal:
 }
 
 #ifdef CONFIG_SSB_PCIHOST
-int __devinit ssb_bus_pcibus_register(struct ssb_bus *bus,
+int ssb_bus_pcibus_register(struct ssb_bus *bus,
 				      struct pci_dev *host_pci)
 {
 	int err;
@@ -860,7 +860,7 @@ EXPORT_SYMBOL(ssb_bus_pcibus_register);
 #endif /* CONFIG_SSB_PCIHOST */
 
 #ifdef CONFIG_SSB_PCMCIAHOST
-int __devinit ssb_bus_pcmciabus_register(struct ssb_bus *bus,
+int ssb_bus_pcmciabus_register(struct ssb_bus *bus,
 					 struct pcmcia_device *pcmcia_dev,
 					 unsigned long baseaddr)
 {
@@ -882,7 +882,7 @@ EXPORT_SYMBOL(ssb_bus_pcmciabus_register);
 #endif /* CONFIG_SSB_PCMCIAHOST */
 
 #ifdef CONFIG_SSB_SDIOHOST
-int __devinit ssb_bus_sdiobus_register(struct ssb_bus *bus,
+int ssb_bus_sdiobus_register(struct ssb_bus *bus,
 				       struct sdio_func *func,
 				       unsigned int quirks)
 {
@@ -904,7 +904,7 @@ int __devinit ssb_bus_sdiobus_register(struct ssb_bus *bus,
 EXPORT_SYMBOL(ssb_bus_sdiobus_register);
 #endif /* CONFIG_SSB_PCMCIAHOST */
 
-int __devinit ssb_bus_ssbbus_register(struct ssb_bus *bus,
+int ssb_bus_ssbbus_register(struct ssb_bus *bus,
 				      unsigned long baseaddr,
 				      ssb_invariants_func_t get_invariants)
 {
diff --git a/drivers/ssb/pcihost_wrapper.c b/drivers/ssb/pcihost_wrapper.c
index af5448f..9fd81f0 100644
--- a/drivers/ssb/pcihost_wrapper.c
+++ b/drivers/ssb/pcihost_wrapper.c
@@ -54,7 +54,7 @@ static int ssb_pcihost_resume(struct pci_dev *dev)
 # define ssb_pcihost_resume	NULL
 #endif /* CONFIG_PM */
 
-static int __devinit ssb_pcihost_probe(struct pci_dev *dev,
+static int ssb_pcihost_probe(struct pci_dev *dev,
 				       const struct pci_device_id *id)
 {
 	struct ssb_bus *ssb;
@@ -111,7 +111,7 @@ static void ssb_pcihost_remove(struct pci_dev *dev)
 	pci_set_drvdata(dev, NULL);
 }
 
-int __devinit ssb_pcihost_register(struct pci_driver *driver)
+int ssb_pcihost_register(struct pci_driver *driver)
 {
 	driver->probe = ssb_pcihost_probe;
 	driver->remove = ssb_pcihost_remove;
-- 
1.8.0

^ permalink raw reply related

* Re: [rfc net-next v6 2/3] virtio_net: multiqueue support
From: Ben Hutchings @ 2012-11-19 18:44 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: Rusty Russell, Jason Wang, davem, virtualization, linux-kernel,
	netdev, krkumar2, kvm, edumazet
In-Reply-To: <20121118091354.GA31775@redhat.com>

On Sun, 2012-11-18 at 11:13 +0200, Michael S. Tsirkin wrote:
> On Sat, Nov 17, 2012 at 12:35:29AM +0000, Ben Hutchings wrote:
> > On Tue, 2012-11-13 at 08:40 +0200, Michael S. Tsirkin wrote:
> > > On Mon, Nov 05, 2012 at 11:38:39AM +1030, Rusty Russell wrote:
> > > > > @@ -924,11 +1032,10 @@ static void virtnet_get_ringparam(struct net_device *dev,
> > > > >  {
> > > > >  	struct virtnet_info *vi = netdev_priv(dev);
> > > > >  
> > > > > -	ring->rx_max_pending = virtqueue_get_vring_size(vi->rvq);
> > > > > -	ring->tx_max_pending = virtqueue_get_vring_size(vi->svq);
> > > > > +	ring->rx_max_pending = virtqueue_get_vring_size(vi->rq[0].vq);
> > > > > +	ring->tx_max_pending = virtqueue_get_vring_size(vi->sq[0].vq);
> > > > >  	ring->rx_pending = ring->rx_max_pending;
> > > > >  	ring->tx_pending = ring->tx_max_pending;
> > > > > -
> > > > >  }
> > > > 
> > > > This assumes all vqs are the same size.  I think this should probably
> > > > check: for mq mode, use the first vq, otherewise use the 0th.
> > > 
> > > For rx_pending/tx_pending I think what is required here is the
> > > actual number of outstanding buffers.
> > > Dave, Eric - right?
> > > 
> > > So this should be the total over all rings and to be useful,
> > > rx_max_pending/tx_max_pending should be the total too.
> > 
> > So far as I know, all current implementations use the number of
> > descriptors per ring here. virtio_net should be consistent with this.
> > 
> > Ben.
> 
> Problem is, it could in theory be different between rings. I guess we
> could use the maximum.
> 
> What's the right thing to do for rx_pending - I am guessing
> we want the current outstanding packets right?

The 'max_pending' fields are for the maximum ring sizes supported; the
'pending' fields are for the current ring sizes.  The current number of
descriptors pending is not included (would be a bit pointless).

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply

* Re: [PATCH 079/493] can: remove use of __devexit_p
From: Marc Kleine-Budde @ 2012-11-19 18:45 UTC (permalink / raw)
  To: Bill Pemberton; +Cc: gregkh, Wolfgang Grandegger, linux-can, netdev
In-Reply-To: <1353349642-3677-79-git-send-email-wfp5p@virginia.edu>

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

On 11/19/2012 07:20 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> needed.
> 
> Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Wolfgang Grandegger <wg@grandegger.com> 
> Cc: Marc Kleine-Budde <mkl@pengutronix.de> 
> Cc: linux-can@vger.kernel.org 
> Cc: netdev@vger.kernel.org 

In net-next/master are two patches, a new driver and support for more
hardware:

> 6cec9b0 can: grcan: Add device driver for GRCAN and GRHCAN cores
> e4bc6c0 can: sja1000: plx_pci: add support for Connect Tech Inc's Canpro/104-Plus Opto CAN board

...so you've missed these:

> ./grcan.c:1662:static int __devinit grcan_probe(struct platform_device *ofdev)
> ./grcan.c:1717:static int __devexit grcan_remove(struct platform_device *ofdev)
> ./grcan.c:1732:static struct of_device_id grcan_match[] __devinitconst = {
> ./grcan.c:1749: .remove = __devexit_p(grcan_remove),
> ./sja1000/plx_pci.c:229:static struct plx_pci_card_info plx_pci_card_info_cti __devinitdata = {

I can create the missing patches and push them mainline via the net-next
tree.

Otherwise...Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply

* Re: [PATCH 202/493] can: remove use of __devinit
From: Marc Kleine-Budde @ 2012-11-19 18:48 UTC (permalink / raw)
  To: Bill Pemberton; +Cc: gregkh, Wolfgang Grandegger, linux-can, netdev
In-Reply-To: <1353349642-3677-202-git-send-email-wfp5p@virginia.edu>

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On 11/19/2012 07:22 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devinit is no longer
> needed.
> 
> Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Wolfgang Grandegger <wg@grandegger.com> 
> Cc: Marc Kleine-Budde <mkl@pengutronix.de> 
> Cc: linux-can@vger.kernel.org 
> Cc: netdev@vger.kernel.org 

You've missed (upstreamed via net-next/master):

./grcan.c:1662:static int __devinit grcan_probe(struct platform_device
*ofdev)
./grcan.c:1717:static int __devexit grcan_remove(struct platform_device
*ofdev)

Otherwise...Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply

* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: Maciej W. Rozycki @ 2012-11-19 18:49 UTC (permalink / raw)
  To: Bill Pemberton; +Cc: gregkh, netdev
In-Reply-To: <1353349642-3677-80-git-send-email-wfp5p@virginia.edu>

On Mon, 19 Nov 2012, Bill Pemberton wrote:

> CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> needed.

 Shouldn't this be switching to __exit_p() instead?  Likewise all the 
other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake 
of drivers built into the kernel proper (yes, there are people out there 
still doing that).  Am I missing something?

 This change scores my NAK as it stands, until updated accordingly or 
further justified.

  Maciej

^ permalink raw reply

* Re: [PATCH 333/493] net: remove use of __devinitdata
From: Marc Kleine-Budde @ 2012-11-19 18:50 UTC (permalink / raw)
  To: Bill Pemberton
  Cc: gregkh, Wolfgang Grandegger, Maciej W. Rozycki, Jes Sorensen,
	John W. Linville, Larry Finger, Chaoming Li, linux-can, netdev,
	linux-hippi, linux-wireless
In-Reply-To: <1353349642-3677-333-git-send-email-wfp5p@virginia.edu>

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On 11/19/2012 07:24 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devinitdata is no
> longer needed.
> 
> Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Wolfgang Grandegger <wg@grandegger.com> 
> Cc: Marc Kleine-Budde <mkl@pengutronix.de> 
> Cc: "Maciej W. Rozycki" <macro@linux-mips.org> 
> Cc: Jes Sorensen <jes@trained-monkey.org> 
> Cc: "John W. Linville" <linville@tuxdriver.com> 
> Cc: Larry Finger <Larry.Finger@lwfinger.net> 
> Cc: Chaoming Li <chaoming_li@realsil.com.cn> 
> Cc: linux-can@vger.kernel.org 
> Cc: netdev@vger.kernel.org 
> Cc: linux-hippi@sunsite.dk 
> Cc: linux-wireless@vger.kernel.org 

You've missed (mainlined via net-next/master):
> ./sja1000/plx_pci.c:229:static struct plx_pci_card_info plx_pci_card_info_cti __devinitdata = {

Otherwise...
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> (for the CAN part)

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply

* Re: [PATCH 379/493] net: remove use of __devinitconst
From: Marc Kleine-Budde @ 2012-11-19 18:51 UTC (permalink / raw)
  To: Bill Pemberton
  Cc: gregkh, Wolfgang Grandegger, Luciano Coelho, John W. Linville,
	linux-can, netdev, linux-wireless
In-Reply-To: <1353349642-3677-379-git-send-email-wfp5p@virginia.edu>

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

On 11/19/2012 07:25 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devinitconst is no
> longer needed.
> 
> Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Wolfgang Grandegger <wg@grandegger.com> 
> Cc: Marc Kleine-Budde <mkl@pengutronix.de> 
> Cc: Luciano Coelho <coelho@ti.com> 
> Cc: "John W. Linville" <linville@tuxdriver.com> 
> Cc: linux-can@vger.kernel.org 
> Cc: netdev@vger.kernel.org 
> Cc: linux-wireless@vger.kernel.org 

You've missed (mainlined via net-next/master):
> ./grcan.c:1732:static struct of_device_id grcan_match[] __devinitconst = {

Otherwise...
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> (for the CAN part)

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply

* Re: [PATCH 04/10] batman-adv: export compatibility version via debugfs
From: Ben Hutchings @ 2012-11-19 18:52 UTC (permalink / raw)
  To: Antonio Quartulli; +Cc: davem, netdev, b.a.t.m.a.n, Marek Lindner
In-Reply-To: <1353313451-2930-5-git-send-email-ordex@autistici.org>

On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
> Different versions of the batman-adv module may use the same compatibility
> version, but this is not understandable at runtime (the only way is to parse the
> kernel log and fetch the batman-adv advertisement message on loading). The user
> may want to know whether two nodes using different versions can communicate or
> not. For this purpose the module has to export this value through debugfs.
[...]

I do hope that you're not planning to use unstable debugfs interfaces
indefinitely.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply

* Re: [PATCH net-next 0/17] Make the network stack usable by userns root
From: David Miller @ 2012-11-19 18:52 UTC (permalink / raw)
  To: ebiederm-aS9lmoZGLiVWk0Htik3J/w
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
In-Reply-To: <87haomkq7q.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>

From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
Date: Sun, 18 Nov 2012 23:27:05 -0800

> Shucks, I had thought I had tested and verified there would not be
> merge issues.  Oh well.

After you had submitted, there were netlink changes, particularly
in the bridging code.

^ permalink raw reply

* Re: [PATCH 471/493] net: remove use of __devexit
From: Marc Kleine-Budde @ 2012-11-19 18:56 UTC (permalink / raw)
  To: Bill Pemberton
  Cc: gregkh, Wolfgang Grandegger, Francois Romieu, Krzysztof Halasa,
	John W. Linville, netdev, linux-can
In-Reply-To: <1353349642-3677-471-git-send-email-wfp5p@virginia.edu>

[-- Attachment #1: Type: text/plain, Size: 2138 bytes --]

On 11/19/2012 07:27 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devexit is no
> longer needed.
> 
> Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Wolfgang Grandegger <wg@grandegger.com> 
> Cc: Marc Kleine-Budde <mkl@pengutronix.de> 
> Cc: "Maciej W. Rozycki" <macro@linux-mips.org> 
> Cc: Jes Sorensen <jes@trained-monkey.org> 
> Cc: Samuel Ortiz <samuel@sortiz.org> 
> Cc: Rusty Russell <rusty@rustcorp.com.au> 
> Cc: "Michael S. Tsirkin" <mst@redhat.com> 
> Cc: Shreyas Bhatewara <sbhatewara@vmware.com> 
> Cc: "VMware, Inc." <pv-drivers@vmware.com> 
> Cc: Francois Romieu <romieu@fr.zoreil.com> 
> Cc: Krzysztof Halasa <khc@pm.waw.pl> 
> Cc: "John W. Linville" <linville@tuxdriver.com> 
> Cc: Jiri Slaby <jirislaby@gmail.com> 
> Cc: Nick Kossifidis <mickflemm@gmail.com> 
> Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com> 
> Cc: Simon Kelley <simon@thekelleys.org.uk> 
> Cc: Stefano Brivio <stefano.brivio@polimi.it> 
> Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com> 
> Cc: Dan Williams <dcbw@redhat.com> 
> Cc: Christian Lamparter <chunkeey@googlemail.com> 
> Cc: Herton Ronaldo Krzesinski <herton@canonical.com> 
> Cc: Hin-Tak Leung <htl10@users.sourceforge.net> 
> Cc: Larry Finger <Larry.Finger@lwfinger.net> 
> Cc: Luciano Coelho <coelho@ti.com> 
> Cc: netdev@vger.kernel.org 
> Cc: linux-can@vger.kernel.org 
> Cc: linux-hippi@sunsite.dk 
> Cc: virtualization@lists.linux-foundation.org 
> Cc: linux-wireless@vger.kernel.org 
> Cc: ath5k-devel@lists.ath5k.org 
> Cc: b43-dev@lists.infradead.org 
> Cc: libertas-dev@lists.infradead.org 
> Cc: xen-devel@lists.xensource.com 

You've missed (mainlined via net-next/master):
> ./grcan.c:1749: .remove = __devexit_p(grcan_remove),

Otherwise...
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> (for the CAN part)

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

^ permalink raw reply

* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: Ben Hutchings @ 2012-11-19 18:57 UTC (permalink / raw)
  To: Maciej W. Rozycki; +Cc: Bill Pemberton, gregkh, netdev
In-Reply-To: <alpine.LFD.2.02.1211191842180.25230@eddie.linux-mips.org>

On Mon, 2012-11-19 at 18:49 +0000, Maciej W. Rozycki wrote:
> On Mon, 19 Nov 2012, Bill Pemberton wrote:
> 
> > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> > needed.
> 
>  Shouldn't this be switching to __exit_p() instead?  Likewise all the 
> other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake 
> of drivers built into the kernel proper (yes, there are people out there 
> still doing that).  Am I missing something?

Drivers can be unbound by poking in sysfs.

Ben.

>  This change scores my NAK as it stands, until updated accordingly or 
> further justified.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply

* Re: [PATCH 3/3] net: mvneta: adjust multiline comments to net/ style
From: David Miller @ 2012-11-19 19:01 UTC (permalink / raw)
  To: sshtylyov
  Cc: thomas.petazzoni, jason, alior, andrew, netdev, gregory.clement,
	linux-arm-kernel
In-Reply-To: <50AA2AD4.6030007@mvista.com>

From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Mon, 19 Nov 2012 16:49:24 +0400

>    Why the heck you're doing this? It's the preferred style, see
>    Documentation/CodingStyle, chapter 8.

Not in the networking code, we prefer:

	/* Doing it,
	 * like this.
	 */

there.

^ permalink raw reply

* New ASIX USB3 product
From: Jérôme Poulin @ 2012-11-19 19:02 UTC (permalink / raw)
  To: netdev

I just bought a gigabit ethernet USB3 adapter, it is a StarTech
USB31000S adapter and it does not seem to be un ASIX product database
yet.

I tried binding it with the driver and it returns error -32, what does
this mean?

Here is the dmesg output:
[214792.189316] usb 3-1: new SuperSpeed USB device number 11 using xhci_hcd
[214792.207219] usb 3-1: Parent hub missing LPM exit latency info.
Power management will be impacted.
[214792.211922] usb 3-1: New USB device found, idVendor=0b95, idProduct=1790
[214792.211941] usb 3-1: New USB device strings: Mfr=1, Product=2,
SerialNumber=3
[214792.211944] usb 3-1: Product: AX88179
[214792.211948] usb 3-1: Manufacturer: ASIX Elec. Corp.
[214792.211951] usb 3-1: SerialNumber: <12 digits...>
[214792.216865] asix: probe of 3-1:1.0 failed with error -32

Here is lsusb output:
Bus 003 Device 012: ID 0b95:1790 ASIX Electronics Corp.
Couldn't open device, some information will be missing
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               3.00
  bDeviceClass          255 Vendor Specific Class
  bDeviceSubClass       255 Vendor Specific Subclass
  bDeviceProtocol         0
  bMaxPacketSize0         9
  idVendor           0x0b95 ASIX Electronics Corp.
  idProduct          0x1790
  bcdDevice            1.00
  iManufacturer           1
  iProduct                2
  iSerial                 3
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength           57
    bNumInterfaces          1
    bConfigurationValue     1
    iConfiguration          0
    bmAttributes         0xa0
      (Bus Powered)
      Remote Wakeup
    MaxPower              124mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           3
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass    255 Vendor Specific Subclass
      bInterfaceProtocol      0
      iInterface              4
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0008  1x 8 bytes
        bInterval              11
        bMaxBurst               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x82  EP 2 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               3
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x03  EP 3 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15

And
T:  Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 12 Spd=5000 MxCh= 0
D:  Ver= 3.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS= 9 #Cfgs=  1
P:  Vendor=0b95 ProdID=1790 Rev=01.00
S:  Manufacturer=ASIX Elec. Corp.
S:  Product=AX88179
S:  SerialNumber=0000249B0438C8
C:  #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=124mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=(none)

^ permalink raw reply

* Re: [PATCH 200/493] irda: remove use of __devinit
From: David Miller @ 2012-11-19 19:06 UTC (permalink / raw)
  To: wfp5p; +Cc: gregkh, samuel, netdev
In-Reply-To: <1353349642-3677-200-git-send-email-wfp5p@virginia.edu>


It is absolutely not reasonable to post nearly 500 patches all
at the same time.

Do not do this ever again.

Thanks.

^ permalink raw reply

* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: David Miller @ 2012-11-19 19:08 UTC (permalink / raw)
  To: macro; +Cc: wfp5p, gregkh, netdev
In-Reply-To: <alpine.LFD.2.02.1211191842180.25230@eddie.linux-mips.org>

From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Mon, 19 Nov 2012 18:49:00 +0000 (GMT)

> On Mon, 19 Nov 2012, Bill Pemberton wrote:
> 
>  This change scores my NAK as it stands, until updated accordingly or 
> further justified.

I also refuse to apply any of these patches, they are rediculous
and also submitted in an inconsiderate and improper manner.

^ permalink raw reply

* Re: [PATCH 04/10] batman-adv: export compatibility version via debugfs
From: David Miller @ 2012-11-19 19:10 UTC (permalink / raw)
  To: bhutchings; +Cc: ordex, netdev, b.a.t.m.a.n, lindner_marek
In-Reply-To: <1353351150.4156.4.camel@bwh-desktop.uk.solarflarecom.com>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 19 Nov 2012 18:52:30 +0000

> On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
>> Different versions of the batman-adv module may use the same compatibility
>> version, but this is not understandable at runtime (the only way is to parse the
>> kernel log and fetch the batman-adv advertisement message on loading). The user
>> may want to know whether two nodes using different versions can communicate or
>> not. For this purpose the module has to export this value through debugfs.
> [...]
> 
> I do hope that you're not planning to use unstable debugfs interfaces
> indefinitely.

I think this is a huge mess and I don't think I'm going to pull this
series for that reason.

Once we allow you to merge your protocol/facility/whatever into the
main kernel tree, you have to be mindful of compatability in a very
real way.

These kinds of changes show that this isn't actually happening.

So the only weapon I have against you doing more foolishly
incompatable changes is to simply stop taking your submissions until
things are corrected.

^ permalink raw reply

* Re: [PATCH net-next ] net: Allow userns root to control tun and tap devices
From: David Miller @ 2012-11-19 19:16 UTC (permalink / raw)
  To: serge-A9i7LUbDfNHQT0dZR+AlfA
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w
In-Reply-To: <20121119142331.GA4453-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>

From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
Date: Mon, 19 Nov 2012 14:23:31 +0000

> Quoting Eric W. Biederman (ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org):
>> 
>> Allow an unpriviled user who has created a user namespace, and then
>> created a network namespace to effectively use the new network
>> namespace, by reducing capable(CAP_NET_ADMIN) calls to
>> ns_capable(net->user_ns,CAP_NET_ADMIN) calls.
>> 
>> Allow setting of the tun iff flags.
>> Allow creating of tun devices.
>> Allow adding a new queue to a tun device.
>> 
> 
> Acked-by: Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>

Applied.

^ permalink raw reply

* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: Maciej W. Rozycki @ 2012-11-19 19:16 UTC (permalink / raw)
  To: Bill Pemberton; +Cc: gregkh, netdev
In-Reply-To: <alpine.LFD.2.02.1211191842180.25230@eddie.linux-mips.org>

On Mon, 19 Nov 2012, Maciej W. Rozycki wrote:

> > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> > needed.
> 
>  Shouldn't this be switching to __exit_p() instead?  Likewise all the 
> other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake 
> of drivers built into the kernel proper (yes, there are people out there 
> still doing that).  Am I missing something?
> 
>  This change scores my NAK as it stands, until updated accordingly or 
> further justified.

 I have unconfused myself now, so please replace the above with the 
following question: what about configurations (e.g. buses) that not 
support hotplug at all?  For example apart from PCI the defxx driver 
concerned here supports the TURBOchannel bus that by design does not have 
the concept of live option card removal (no such circuitry).  So should 
now the precious memory be wasted on systems that will never ever handle 
hotplug?

  Maciej

^ permalink raw reply

* Re: [GIT PULL] Marvell mvneta Ethernet/MDIO drivers checkpatch fixes
From: David Miller @ 2012-11-19 19:16 UTC (permalink / raw)
  To: thomas.petazzoni
  Cc: jason, andrew, gregory.clement, linux-arm-kernel, alior, netdev
In-Reply-To: <1353322834-16952-1-git-send-email-thomas.petazzoni@free-electrons.com>

From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Mon, 19 Nov 2012 12:00:31 +0100

> Sebastian Hesselbarth noticed that the new mvmdio and mvneta drivers
> produce a number of checkpatch warnings, related to the incluse of
> <asm/delay.h> and to the style of multiline comments. The following
> three patches fix those checkpatch warnings. Feel free to integrate
> them either as follow-up patches of the network driver patches, or to
> squash them into the driver patches as you prefer.
> 
> David, are you OK with those patches and the fact that we carry them
> through the arm-soc tree, as we agreed to do for the mvmdio and mvneta
> drivers? Those patches are really simple/stupid fixes.

No problem, thanks.

^ permalink raw reply

* Re: [PATCH 1/1] vhost: Remove duplicate inclusion of linux/vhost.h
From: David Miller @ 2012-11-19 19:18 UTC (permalink / raw)
  To: sachin.kamat; +Cc: kvm, virtualization, netdev, mst, nab, patches
In-Reply-To: <1353324508-22083-1-git-send-email-sachin.kamat@linaro.org>

From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Mon, 19 Nov 2012 16:58:28 +0530

> linux/vhost.h was included twice.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Michael, are you gonna take this?

Thanks.

^ permalink raw reply

* Re: [patch 0/6] s390: network patches for net-next
From: David Miller @ 2012-11-19 19:19 UTC (permalink / raw)
  To: frank.blaschka; +Cc: netdev, linux-s390
In-Reply-To: <20121119124644.679089322@de.ibm.com>

From: frank.blaschka@de.ibm.com
Date: Mon, 19 Nov 2012 13:46:44 +0100

> here are some s390 related patches for net-next

All applied, thanks.

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox