* Re: [PATCH 04/10] batman-adv: export compatibility version via debugfs
From: Ben Hutchings @ 2012-11-19 19:40 UTC (permalink / raw)
To: Sven Eckelmann
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r, Marek Lindner,
davem-fT/PcQaiUtIeIZ0/mPfg9Q
In-Reply-To: <5268262.CIrZ93ERtB@bentobox>
On Mon, 2012-11-19 at 20:29 +0100, Sven Eckelmann wrote:
> On Monday 19 November 2012 18:52:30 Ben Hutchings wrote:
> > On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
> > > Different versions of the batman-adv module may use the same compatibility
> > > version, but this is not understandable at runtime (the only way is to
> > > parse the kernel log and fetch the batman-adv advertisement message on
> > > loading). The user may want to know whether two nodes using different
> > > versions can communicate or not. For this purpose the module has to
> > > export this value through debugfs.
> > [...]
> >
> > I do hope that you're not planning to use unstable debugfs interfaces
> > indefinitely.
>
> Why are you refering to the adding of an file as "incompatible" debugfs
> interface? I would call it additional information. And the rest of the commit
> message is talking about *possible* protocol incompatibilies of the network
> protocol (which caused this uncontrolled erruption of anger in a network
> maintainer).
I didn't say that. But debugfs tends to be exempted from expectations
of interface stability or cleanliness (as it's for development, not
production... right?). It's also an optional feature that might not be
enabled at compile time or run-time. If BATMAN is ever going to be
ready for general use it will need stable interfaces that are updated in
a backward-compatible way and don't depend on debugfs.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [PATCH 200/493] irda: remove use of __devinit
From: Greg KH @ 2012-11-19 19:30 UTC (permalink / raw)
To: David Miller; +Cc: wfp5p, samuel, netdev
In-Reply-To: <20121119.142446.1954365383179623684.davem@davemloft.net>
On Mon, Nov 19, 2012 at 02:24:46PM -0500, David Miller wrote:
> From: Greg KH <gregkh@linuxfoundation.org>
> Date: Mon, 19 Nov 2012 11:21:21 -0800
>
> > On Mon, Nov 19, 2012 at 02:06:54PM -0500, David Miller wrote:
> >>
> >> It is absolutely not reasonable to post nearly 500 patches all
> >> at the same time.
> >>
> >> Do not do this ever again.
> >
> > Bill did this with the assumption that I would take them through my
> > driver-core tree, as I asked that he do this work. The 000 message said
> > that, but that wasn't sent out to all of the recipients, so I can
> > understand how you didn't see this.
> >
> > Also, I was the only one that got all 500 emails, everyone else should
> > have only seen a small quantity.
>
> I had to purge nearly 100 out of networking's patchwork.
>
> This is unacceptable.
Ok, fair enough, sorry about that.
greg k-h
^ permalink raw reply
* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: Greg KH @ 2012-11-19 19:29 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: Bill Pemberton, netdev
In-Reply-To: <alpine.LFD.2.02.1211191912040.25230@eddie.linux-mips.org>
On Mon, Nov 19, 2012 at 07:16:44PM +0000, Maciej W. Rozycki wrote:
> On Mon, 19 Nov 2012, Maciej W. Rozycki wrote:
>
> > > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> > > needed.
> >
> > Shouldn't this be switching to __exit_p() instead? Likewise all the
> > other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake
> > of drivers built into the kernel proper (yes, there are people out there
> > still doing that). Am I missing something?
> >
> > This change scores my NAK as it stands, until updated accordingly or
> > further justified.
>
> I have unconfused myself now, so please replace the above with the
> following question: what about configurations (e.g. buses) that not
> support hotplug at all? For example apart from PCI the defxx driver
> concerned here supports the TURBOchannel bus that by design does not have
> the concept of live option card removal (no such circuitry). So should
> now the precious memory be wasted on systems that will never ever handle
> hotplug?
CONFIG_HOTPLUG is always enabled now, so that's not an option anymore.
And again, a user can "hot unbind" a driver from a device from
userspace, no matter if the bus physically supports it or not.
thanks,
greg k-h
^ permalink raw reply
* Re: [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: export compatibility version via debugfs
From: Sven Eckelmann @ 2012-11-19 19:29 UTC (permalink / raw)
To: b.a.t.m.a.n
Cc: Ben Hutchings, Antonio Quartulli, netdev, Marek Lindner, davem
In-Reply-To: <1353351150.4156.4.camel@bwh-desktop.uk.solarflarecom.com>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
On Monday 19 November 2012 18:52:30 Ben Hutchings wrote:
> On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
> > Different versions of the batman-adv module may use the same compatibility
> > version, but this is not understandable at runtime (the only way is to
> > parse the kernel log and fetch the batman-adv advertisement message on
> > loading). The user may want to know whether two nodes using different
> > versions can communicate or not. For this purpose the module has to
> > export this value through debugfs.
> [...]
>
> I do hope that you're not planning to use unstable debugfs interfaces
> indefinitely.
Why are you refering to the adding of an file as "incompatible" debugfs
interface? I would call it additional information. And the rest of the commit
message is talking about *possible* protocol incompatibilies of the network
protocol (which caused this uncontrolled erruption of anger in a network
maintainer).
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH 200/493] irda: remove use of __devinit
From: David Miller @ 2012-11-19 19:24 UTC (permalink / raw)
To: gregkh; +Cc: wfp5p, samuel, netdev
In-Reply-To: <20121119192121.GA16694@kroah.com>
From: Greg KH <gregkh@linuxfoundation.org>
Date: Mon, 19 Nov 2012 11:21:21 -0800
> On Mon, Nov 19, 2012 at 02:06:54PM -0500, David Miller wrote:
>>
>> It is absolutely not reasonable to post nearly 500 patches all
>> at the same time.
>>
>> Do not do this ever again.
>
> Bill did this with the assumption that I would take them through my
> driver-core tree, as I asked that he do this work. The 000 message said
> that, but that wasn't sent out to all of the recipients, so I can
> understand how you didn't see this.
>
> Also, I was the only one that got all 500 emails, everyone else should
> have only seen a small quantity.
I had to purge nearly 100 out of networking's patchwork.
This is unacceptable.
^ permalink raw reply
* Re: [PATCH v2] net/macb: move to circ_buf macros and fix initial condition
From: David Miller @ 2012-11-19 19:22 UTC (permalink / raw)
To: nicolas.ferre; +Cc: netdev, plagnioj, manabian, linux-arm-kernel, linux-kernel
In-Reply-To: <1353340821-12658-1-git-send-email-nicolas.ferre@atmel.com>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Date: Mon, 19 Nov 2012 17:00:21 +0100
> Move to circular buffers management macro and correct an error
> with circular buffer initial condition.
>
> Without this patch, the macb_tx_ring_avail() function was
> not reporting the proper ring availability at startup:
> macb macb: eth0: BUG! Tx Ring full when queue awake!
> macb macb: eth0: tx_head = 0, tx_tail = 0
> And hanginig forever...
>
> I remove the macb_tx_ring_avail() function and use the
> proven macros from circ_buf.h. CIRC_CNT() is used in the
> "consumer" part of the driver: macb_tx_interrupt() to match
> advice from Documentation/circular-buffers.txt.
>
> Reported-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Tested-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Applied, thanks.
> ---
> v2: - added tags from Jean-Christophe PLAGNIOL-VILLARD
Note that under normal circumstances, if the only change is the
tags that people added in replies, you don't need to do this.
Patchwork accumulates all of the signoffs, acks, tested-by,
reviewed-by, etc. tags made in replies to the patch automatically for
me, so when I apply the patch they will be there.
^ permalink raw reply
* Re: [PATCH 200/493] irda: remove use of __devinit
From: Greg KH @ 2012-11-19 19:21 UTC (permalink / raw)
To: David Miller; +Cc: wfp5p, samuel, netdev
In-Reply-To: <20121119.140654.780679585475336928.davem@davemloft.net>
On Mon, Nov 19, 2012 at 02:06:54PM -0500, David Miller wrote:
>
> It is absolutely not reasonable to post nearly 500 patches all
> at the same time.
>
> Do not do this ever again.
Bill did this with the assumption that I would take them through my
driver-core tree, as I asked that he do this work. The 000 message said
that, but that wasn't sent out to all of the recipients, so I can
understand how you didn't see this.
Also, I was the only one that got all 500 emails, everyone else should
have only seen a small quantity.
As you object to these, that's fine, I'll not apply anything to my
treethat touches the drivers/net/ or net/ tree at this point in time, is
that ok?
But the end goal is to drop CONFIG_HOTPLUG entirely, and these __dev*
markings, as they don't do anything anymore.
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH] netfilter: Remove the spurious \ in __ip_vs_lblc_init
From: David Miller @ 2012-11-19 19:20 UTC (permalink / raw)
To: ebiederm; +Cc: netdev
In-Reply-To: <87zk2d7gwp.fsf@xmission.com>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Mon, 19 Nov 2012 07:26:30 -0800
>
> In (464dc801c76a net: Don't export sysctls to unprivileged users)
> I typoed and introduced a spurious backslash. Delete it.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Applied.
^ permalink raw reply
* Re: [patch 0/6] s390: network patches for net-next
From: David Miller @ 2012-11-19 19:19 UTC (permalink / raw)
To: frank.blaschka; +Cc: netdev, linux-s390
In-Reply-To: <20121119124644.679089322@de.ibm.com>
From: frank.blaschka@de.ibm.com
Date: Mon, 19 Nov 2012 13:46:44 +0100
> here are some s390 related patches for net-next
All applied, thanks.
^ permalink raw reply
* Re: [PATCH 1/1] vhost: Remove duplicate inclusion of linux/vhost.h
From: David Miller @ 2012-11-19 19:18 UTC (permalink / raw)
To: sachin.kamat; +Cc: kvm, virtualization, netdev, mst, nab, patches
In-Reply-To: <1353324508-22083-1-git-send-email-sachin.kamat@linaro.org>
From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Mon, 19 Nov 2012 16:58:28 +0530
> linux/vhost.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Michael, are you gonna take this?
Thanks.
^ permalink raw reply
* Re: [GIT PULL] Marvell mvneta Ethernet/MDIO drivers checkpatch fixes
From: David Miller @ 2012-11-19 19:16 UTC (permalink / raw)
To: thomas.petazzoni
Cc: jason, andrew, gregory.clement, linux-arm-kernel, alior, netdev
In-Reply-To: <1353322834-16952-1-git-send-email-thomas.petazzoni@free-electrons.com>
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Mon, 19 Nov 2012 12:00:31 +0100
> Sebastian Hesselbarth noticed that the new mvmdio and mvneta drivers
> produce a number of checkpatch warnings, related to the incluse of
> <asm/delay.h> and to the style of multiline comments. The following
> three patches fix those checkpatch warnings. Feel free to integrate
> them either as follow-up patches of the network driver patches, or to
> squash them into the driver patches as you prefer.
>
> David, are you OK with those patches and the fact that we carry them
> through the arm-soc tree, as we agreed to do for the mvmdio and mvneta
> drivers? Those patches are really simple/stupid fixes.
No problem, thanks.
^ permalink raw reply
* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: Maciej W. Rozycki @ 2012-11-19 19:16 UTC (permalink / raw)
To: Bill Pemberton; +Cc: gregkh, netdev
In-Reply-To: <alpine.LFD.2.02.1211191842180.25230@eddie.linux-mips.org>
On Mon, 19 Nov 2012, Maciej W. Rozycki wrote:
> > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> > needed.
>
> Shouldn't this be switching to __exit_p() instead? Likewise all the
> other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake
> of drivers built into the kernel proper (yes, there are people out there
> still doing that). Am I missing something?
>
> This change scores my NAK as it stands, until updated accordingly or
> further justified.
I have unconfused myself now, so please replace the above with the
following question: what about configurations (e.g. buses) that not
support hotplug at all? For example apart from PCI the defxx driver
concerned here supports the TURBOchannel bus that by design does not have
the concept of live option card removal (no such circuitry). So should
now the precious memory be wasted on systems that will never ever handle
hotplug?
Maciej
^ permalink raw reply
* Re: [PATCH net-next ] net: Allow userns root to control tun and tap devices
From: David Miller @ 2012-11-19 19:16 UTC (permalink / raw)
To: serge-A9i7LUbDfNHQT0dZR+AlfA
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
ebiederm-aS9lmoZGLiVWk0Htik3J/w
In-Reply-To: <20121119142331.GA4453-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
Date: Mon, 19 Nov 2012 14:23:31 +0000
> Quoting Eric W. Biederman (ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org):
>>
>> Allow an unpriviled user who has created a user namespace, and then
>> created a network namespace to effectively use the new network
>> namespace, by reducing capable(CAP_NET_ADMIN) calls to
>> ns_capable(net->user_ns,CAP_NET_ADMIN) calls.
>>
>> Allow setting of the tun iff flags.
>> Allow creating of tun devices.
>> Allow adding a new queue to a tun device.
>>
>
> Acked-by: Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Applied.
^ permalink raw reply
* Re: [PATCH 04/10] batman-adv: export compatibility version via debugfs
From: David Miller @ 2012-11-19 19:10 UTC (permalink / raw)
To: bhutchings; +Cc: ordex, netdev, b.a.t.m.a.n, lindner_marek
In-Reply-To: <1353351150.4156.4.camel@bwh-desktop.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 19 Nov 2012 18:52:30 +0000
> On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
>> Different versions of the batman-adv module may use the same compatibility
>> version, but this is not understandable at runtime (the only way is to parse the
>> kernel log and fetch the batman-adv advertisement message on loading). The user
>> may want to know whether two nodes using different versions can communicate or
>> not. For this purpose the module has to export this value through debugfs.
> [...]
>
> I do hope that you're not planning to use unstable debugfs interfaces
> indefinitely.
I think this is a huge mess and I don't think I'm going to pull this
series for that reason.
Once we allow you to merge your protocol/facility/whatever into the
main kernel tree, you have to be mindful of compatability in a very
real way.
These kinds of changes show that this isn't actually happening.
So the only weapon I have against you doing more foolishly
incompatable changes is to simply stop taking your submissions until
things are corrected.
^ permalink raw reply
* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: David Miller @ 2012-11-19 19:08 UTC (permalink / raw)
To: macro; +Cc: wfp5p, gregkh, netdev
In-Reply-To: <alpine.LFD.2.02.1211191842180.25230@eddie.linux-mips.org>
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Mon, 19 Nov 2012 18:49:00 +0000 (GMT)
> On Mon, 19 Nov 2012, Bill Pemberton wrote:
>
> This change scores my NAK as it stands, until updated accordingly or
> further justified.
I also refuse to apply any of these patches, they are rediculous
and also submitted in an inconsiderate and improper manner.
^ permalink raw reply
* Re: [PATCH 200/493] irda: remove use of __devinit
From: David Miller @ 2012-11-19 19:06 UTC (permalink / raw)
To: wfp5p; +Cc: gregkh, samuel, netdev
In-Reply-To: <1353349642-3677-200-git-send-email-wfp5p@virginia.edu>
It is absolutely not reasonable to post nearly 500 patches all
at the same time.
Do not do this ever again.
Thanks.
^ permalink raw reply
* New ASIX USB3 product
From: Jérôme Poulin @ 2012-11-19 19:02 UTC (permalink / raw)
To: netdev
I just bought a gigabit ethernet USB3 adapter, it is a StarTech
USB31000S adapter and it does not seem to be un ASIX product database
yet.
I tried binding it with the driver and it returns error -32, what does
this mean?
Here is the dmesg output:
[214792.189316] usb 3-1: new SuperSpeed USB device number 11 using xhci_hcd
[214792.207219] usb 3-1: Parent hub missing LPM exit latency info.
Power management will be impacted.
[214792.211922] usb 3-1: New USB device found, idVendor=0b95, idProduct=1790
[214792.211941] usb 3-1: New USB device strings: Mfr=1, Product=2,
SerialNumber=3
[214792.211944] usb 3-1: Product: AX88179
[214792.211948] usb 3-1: Manufacturer: ASIX Elec. Corp.
[214792.211951] usb 3-1: SerialNumber: <12 digits...>
[214792.216865] asix: probe of 3-1:1.0 failed with error -32
Here is lsusb output:
Bus 003 Device 012: ID 0b95:1790 ASIX Electronics Corp.
Couldn't open device, some information will be missing
Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 3.00
bDeviceClass 255 Vendor Specific Class
bDeviceSubClass 255 Vendor Specific Subclass
bDeviceProtocol 0
bMaxPacketSize0 9
idVendor 0x0b95 ASIX Electronics Corp.
idProduct 0x1790
bcdDevice 1.00
iManufacturer 1
iProduct 2
iSerial 3
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 57
bNumInterfaces 1
bConfigurationValue 1
iConfiguration 0
bmAttributes 0xa0
(Bus Powered)
Remote Wakeup
MaxPower 124mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 0
iInterface 4
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0008 1x 8 bytes
bInterval 11
bMaxBurst 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0400 1x 1024 bytes
bInterval 0
bMaxBurst 3
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x03 EP 3 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0400 1x 1024 bytes
bInterval 0
bMaxBurst 15
And
T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 12 Spd=5000 MxCh= 0
D: Ver= 3.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS= 9 #Cfgs= 1
P: Vendor=0b95 ProdID=1790 Rev=01.00
S: Manufacturer=ASIX Elec. Corp.
S: Product=AX88179
S: SerialNumber=0000249B0438C8
C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=124mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=(none)
^ permalink raw reply
* Re: [PATCH 3/3] net: mvneta: adjust multiline comments to net/ style
From: David Miller @ 2012-11-19 19:01 UTC (permalink / raw)
To: sshtylyov
Cc: thomas.petazzoni, jason, alior, andrew, netdev, gregory.clement,
linux-arm-kernel
In-Reply-To: <50AA2AD4.6030007@mvista.com>
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Mon, 19 Nov 2012 16:49:24 +0400
> Why the heck you're doing this? It's the preferred style, see
> Documentation/CodingStyle, chapter 8.
Not in the networking code, we prefer:
/* Doing it,
* like this.
*/
there.
^ permalink raw reply
* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: Ben Hutchings @ 2012-11-19 18:57 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: Bill Pemberton, gregkh, netdev
In-Reply-To: <alpine.LFD.2.02.1211191842180.25230@eddie.linux-mips.org>
On Mon, 2012-11-19 at 18:49 +0000, Maciej W. Rozycki wrote:
> On Mon, 19 Nov 2012, Bill Pemberton wrote:
>
> > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> > needed.
>
> Shouldn't this be switching to __exit_p() instead? Likewise all the
> other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake
> of drivers built into the kernel proper (yes, there are people out there
> still doing that). Am I missing something?
Drivers can be unbound by poking in sysfs.
Ben.
> This change scores my NAK as it stands, until updated accordingly or
> further justified.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [PATCH 471/493] net: remove use of __devexit
From: Marc Kleine-Budde @ 2012-11-19 18:56 UTC (permalink / raw)
To: Bill Pemberton
Cc: gregkh, Wolfgang Grandegger, Francois Romieu, Krzysztof Halasa,
John W. Linville, netdev, linux-can
In-Reply-To: <1353349642-3677-471-git-send-email-wfp5p@virginia.edu>
[-- Attachment #1: Type: text/plain, Size: 2138 bytes --]
On 11/19/2012 07:27 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devexit is no
> longer needed.
>
> Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
> Cc: Jes Sorensen <jes@trained-monkey.org>
> Cc: Samuel Ortiz <samuel@sortiz.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Shreyas Bhatewara <sbhatewara@vmware.com>
> Cc: "VMware, Inc." <pv-drivers@vmware.com>
> Cc: Francois Romieu <romieu@fr.zoreil.com>
> Cc: Krzysztof Halasa <khc@pm.waw.pl>
> Cc: "John W. Linville" <linville@tuxdriver.com>
> Cc: Jiri Slaby <jirislaby@gmail.com>
> Cc: Nick Kossifidis <mickflemm@gmail.com>
> Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
> Cc: Simon Kelley <simon@thekelleys.org.uk>
> Cc: Stefano Brivio <stefano.brivio@polimi.it>
> Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>
> Cc: Dan Williams <dcbw@redhat.com>
> Cc: Christian Lamparter <chunkeey@googlemail.com>
> Cc: Herton Ronaldo Krzesinski <herton@canonical.com>
> Cc: Hin-Tak Leung <htl10@users.sourceforge.net>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Luciano Coelho <coelho@ti.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-can@vger.kernel.org
> Cc: linux-hippi@sunsite.dk
> Cc: virtualization@lists.linux-foundation.org
> Cc: linux-wireless@vger.kernel.org
> Cc: ath5k-devel@lists.ath5k.org
> Cc: b43-dev@lists.infradead.org
> Cc: libertas-dev@lists.infradead.org
> Cc: xen-devel@lists.xensource.com
You've missed (mainlined via net-next/master):
> ./grcan.c:1749: .remove = __devexit_p(grcan_remove),
Otherwise...
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> (for the CAN part)
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
^ permalink raw reply
* Re: [PATCH net-next 0/17] Make the network stack usable by userns root
From: David Miller @ 2012-11-19 18:52 UTC (permalink / raw)
To: ebiederm-aS9lmoZGLiVWk0Htik3J/w
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
In-Reply-To: <87haomkq7q.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
Date: Sun, 18 Nov 2012 23:27:05 -0800
> Shucks, I had thought I had tested and verified there would not be
> merge issues. Oh well.
After you had submitted, there were netlink changes, particularly
in the bridging code.
^ permalink raw reply
* Re: [PATCH 04/10] batman-adv: export compatibility version via debugfs
From: Ben Hutchings @ 2012-11-19 18:52 UTC (permalink / raw)
To: Antonio Quartulli; +Cc: davem, netdev, b.a.t.m.a.n, Marek Lindner
In-Reply-To: <1353313451-2930-5-git-send-email-ordex@autistici.org>
On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
> Different versions of the batman-adv module may use the same compatibility
> version, but this is not understandable at runtime (the only way is to parse the
> kernel log and fetch the batman-adv advertisement message on loading). The user
> may want to know whether two nodes using different versions can communicate or
> not. For this purpose the module has to export this value through debugfs.
[...]
I do hope that you're not planning to use unstable debugfs interfaces
indefinitely.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [PATCH 379/493] net: remove use of __devinitconst
From: Marc Kleine-Budde @ 2012-11-19 18:51 UTC (permalink / raw)
To: Bill Pemberton
Cc: gregkh, Wolfgang Grandegger, Luciano Coelho, John W. Linville,
linux-can, netdev, linux-wireless
In-Reply-To: <1353349642-3677-379-git-send-email-wfp5p@virginia.edu>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
On 11/19/2012 07:25 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devinitconst is no
> longer needed.
>
> Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: Luciano Coelho <coelho@ti.com>
> Cc: "John W. Linville" <linville@tuxdriver.com>
> Cc: linux-can@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
You've missed (mainlined via net-next/master):
> ./grcan.c:1732:static struct of_device_id grcan_match[] __devinitconst = {
Otherwise...
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> (for the CAN part)
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply
* Re: [PATCH 333/493] net: remove use of __devinitdata
From: Marc Kleine-Budde @ 2012-11-19 18:50 UTC (permalink / raw)
To: Bill Pemberton
Cc: gregkh, Wolfgang Grandegger, Maciej W. Rozycki, Jes Sorensen,
John W. Linville, Larry Finger, Chaoming Li, linux-can, netdev,
linux-hippi, linux-wireless
In-Reply-To: <1353349642-3677-333-git-send-email-wfp5p@virginia.edu>
[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]
On 11/19/2012 07:24 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devinitdata is no
> longer needed.
>
> Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
> Cc: Jes Sorensen <jes@trained-monkey.org>
> Cc: "John W. Linville" <linville@tuxdriver.com>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Chaoming Li <chaoming_li@realsil.com.cn>
> Cc: linux-can@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-hippi@sunsite.dk
> Cc: linux-wireless@vger.kernel.org
You've missed (mainlined via net-next/master):
> ./sja1000/plx_pci.c:229:static struct plx_pci_card_info plx_pci_card_info_cti __devinitdata = {
Otherwise...
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> (for the CAN part)
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply
* Re: [PATCH 080/493] fddi: remove use of __devexit_p
From: Maciej W. Rozycki @ 2012-11-19 18:49 UTC (permalink / raw)
To: Bill Pemberton; +Cc: gregkh, netdev
In-Reply-To: <1353349642-3677-80-git-send-email-wfp5p@virginia.edu>
On Mon, 19 Nov 2012, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> needed.
Shouldn't this be switching to __exit_p() instead? Likewise all the
other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake
of drivers built into the kernel proper (yes, there are people out there
still doing that). Am I missing something?
This change scores my NAK as it stands, until updated accordingly or
further justified.
Maciej
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox