* Re: [PATCH] sctp: verify length provided in heartbeat information parameter
From: Vlad Yasevich @ 2012-11-30 17:34 UTC (permalink / raw)
To: Thomas Graf; +Cc: davem, netdev, linux-sctp
In-Reply-To: <20121130121627.GG30697@casper.infradead.org>
On 11/30/2012 07:16 AM, Thomas Graf wrote:
> If the variable parameter length provided in the mandatory
> heartbeat information parameter exceeds the calculated payload
> length the packet has been corrupted. Reply with a parameter
> length protocol violation message.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
-vlad
> ---
> net/sctp/sm_statefuns.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
> index b6adef8..e92079d 100644
> --- a/net/sctp/sm_statefuns.c
> +++ b/net/sctp/sm_statefuns.c
> @@ -1055,6 +1055,7 @@ sctp_disposition_t sctp_sf_beat_8_3(struct net *net,
> void *arg,
> sctp_cmd_seq_t *commands)
> {
> + sctp_paramhdr_t *param_hdr;
> struct sctp_chunk *chunk = arg;
> struct sctp_chunk *reply;
> size_t paylen = 0;
> @@ -1072,12 +1073,17 @@ sctp_disposition_t sctp_sf_beat_8_3(struct net *net,
> * Information field copied from the received HEARTBEAT chunk.
> */
> chunk->subh.hb_hdr = (sctp_heartbeathdr_t *) chunk->skb->data;
> + param_hdr = (sctp_paramhdr_t *) chunk->subh.hb_hdr;
> paylen = ntohs(chunk->chunk_hdr->length) - sizeof(sctp_chunkhdr_t);
> +
> + if (ntohs(param_hdr->length) > paylen)
> + return sctp_sf_violation_paramlen(net, ep, asoc, type, arg,
> + param_hdr, commands);
> +
> if (!pskb_pull(chunk->skb, paylen))
> goto nomem;
>
> - reply = sctp_make_heartbeat_ack(asoc, chunk,
> - chunk->subh.hb_hdr, paylen);
> + reply = sctp_make_heartbeat_ack(asoc, chunk, param_hdr, paylen);
> if (!reply)
> goto nomem;
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* [PATCH] Smack: Add missing depends on INET in Kconfig
From: Casey Schaufler @ 2012-11-30 17:28 UTC (permalink / raw)
To: Randy Dunlap
Cc: Paul Moore, Stephen Rothwell, linux-next, linux-kernel,
netdev@vger.kernel.org, linux-security-module
In-Reply-To: <50B8E4E6.2040901@xenotime.net>
Because NETLABEL depends on INET SECURITY_SMACK
has to explicitly call out the dependency.
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
---
security/smack/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/smack/Kconfig b/security/smack/Kconfig
index 9fb14ef..1be1088 100644
--- a/security/smack/Kconfig
+++ b/security/smack/Kconfig
@@ -1,5 +1,6 @@
config SECURITY_SMACK
bool "Simplified Mandatory Access Control Kernel Support"
+ depends on INET
depends on NET
depends on SECURITY
select NETLABEL
^ permalink raw reply related
* Re: [PATCH] MAINTAINERS: fix bouncing tun/tap entries
From: David Miller @ 2012-11-30 17:28 UTC (permalink / raw)
To: jslaby; +Cc: maxk, netdev, jirislaby, linux-kernel
In-Reply-To: <1354295140-6355-1-git-send-email-jslaby@suse.cz>
From: Jiri Slaby <jslaby@suse.cz>
Date: Fri, 30 Nov 2012 18:05:40 +0100
> Delivery to the following recipient failed permanently:
>
> vtun@office.satix.net
>
> Technical details of permanent failure:
> DNS Error: Domain name not found
>
> Of course:
> $ host office.satix.net
> Host office.satix.net not found: 3(NXDOMAIN)
>
> ===========
>
> And "Change of Email Address Notification":
> Old Address New Address Email Subject
> ------------------------------------------------------
> maxk@qualcomm.com maxk@qti.qualcomm.com "tuntap: multiqueue...
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Applied.
^ permalink raw reply
* Re: [PATCH 0/5] smsc95xx enhancements
From: David Miller @ 2012-11-30 17:28 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev
In-Reply-To: <1354290952-27109-1-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Fri, 30 Nov 2012 15:55:47 +0000
> This patchset is a resubmission of several patches plus two new
> patches, including the expansion of cpp macros at the request of
> davem.
>
> Steve Glendinning (5):
> smsc95xx: fix suspend buffer overflow
> smsc95xx: fix error handling in suspend failure case
> smsc95xx: don't enable remote wakeup directly
> smsc95xx: fix smsc_crc return type
> smsc95xx: expand check_ macros
All applied, thanks again Steve.
^ permalink raw reply
* Re: [PATCH 0/2] smsc75xx enhancements
From: David Miller @ 2012-11-30 17:27 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev
In-Reply-To: <1354287164-9884-1-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Fri, 30 Nov 2012 14:52:42 +0000
> This patchset, as requestes, expands the macros used in
> smsc75xx to make the flow control clearer.
>
> I've left the fix in a separate patch, so the macro-
> expanding patch should have zero functional change.
Applied, thanks for fixing this up.
^ permalink raw reply
* Re: [PATCH] sctp: verify length provided in heartbeat information parameter
From: David Miller @ 2012-11-30 17:26 UTC (permalink / raw)
To: nhorman; +Cc: tgraf, netdev, linux-sctp
In-Reply-To: <20121130160156.GC6039@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 30 Nov 2012 11:01:57 -0500
> On Fri, Nov 30, 2012 at 12:16:27PM +0000, Thomas Graf wrote:
>> If the variable parameter length provided in the mandatory
>> heartbeat information parameter exceeds the calculated payload
>> length the packet has been corrupted. Reply with a parameter
>> length protocol violation message.
>>
>> Signed-off-by: Thomas Graf <tgraf@suug.ch>
...
>>
> Looks good, thanks Thomas.
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next] rtnelink: remove unused parameter from rtnl_create_link().
From: David Miller @ 2012-11-30 17:25 UTC (permalink / raw)
To: ramirose; +Cc: netdev, ebiederm, jiri
In-Reply-To: <1354273727-6336-1-git-send-email-ramirose@gmail.com>
From: Rami Rosen <ramirose@gmail.com>
Date: Fri, 30 Nov 2012 13:08:47 +0200
> This patch removes an unused parameter (src_net) from rtnl_create_link()
> method and from the method single invocation, in veth.
> This parameter was used in the past when calling
> ops->get_tx_queues(src_net, tb) in rtnl_create_link().
> The get_tx_queues() member of rtnl_link_ops was replaced by two methods,
> get_num_tx_queues() and get_num_rx_queues(), which do not get any
> parameter. This was done in commit d40156aa5ecbd51fed932ed4813df82b56e5ff4d by
> Jiri Pirko ("rtnl: allow to specify different num for rx and tx queue count").
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] smsc: RFC: Workaround for problems with lan8710 phy auto MDI-X
From: David Miller @ 2012-11-30 17:23 UTC (permalink / raw)
To: jkosina; +Cc: pt, otavio, javier, chohnstaedt, netdev, linux-kernel
In-Reply-To: <alpine.LNX.2.00.1211301622110.25639@pobox.suse.cz>
From: Jiri Kosina <jkosina@suse.cz>
Date: Fri, 30 Nov 2012 16:23:30 +0100 (CET)
> Of course it'd be far better if faulty hardware can be autodetected in
> runtime.
That is how this must be handled.
^ permalink raw reply
* Re: [PATCH] net: ICMPv6 packets transmitted on wrong interface if nfmark is mangled
From: David Miller @ 2012-11-30 17:22 UTC (permalink / raw)
To: dries.dewinter; +Cc: pablo, kaber, netdev, netfilter-devel
In-Reply-To: <CA+e04fhY1KjYFwbQ6P=V==kyU3fqMrvrzRJSyz6sy=RwHki07Q@mail.gmail.com>
From: Dries De Winter <dries.dewinter@gmail.com>
Date: Fri, 30 Nov 2012 13:29:20 +0100
> 2012/11/29 David Miller <davem@davemloft.net>:
>> Regardless of the answer to that question, it should be explained
>> in the commit message.
> Should I post a new patch email including this comment?
Yes, please do.
^ permalink raw reply
* Re: linux-next: Tree for Nov 29 (netlabel)
From: Casey Schaufler @ 2012-11-30 17:22 UTC (permalink / raw)
To: Randy Dunlap
Cc: Paul Moore, Stephen Rothwell, linux-next, linux-kernel,
netdev@vger.kernel.org, linux-security-module, Casey Schaufler
In-Reply-To: <50B8E4E6.2040901@xenotime.net>
On 11/30/2012 8:55 AM, Randy Dunlap wrote:
> On 11/30/2012 07:31 AM, Paul Moore wrote:
>
>> On Friday, November 30, 2012 10:19:16 AM Paul Moore wrote:
>>> On Thursday, November 29, 2012 04:05:26 PM Randy Dunlap wrote:
>>>> On 11/28/2012 10:40 PM, Stephen Rothwell wrote:
>>>>> Hi all,
>>>>> Changes since 20121128:
>>>> (on i386:)
>>> If I had to guess it looks like CONFIG_NETLABEL needs to be dependent on
>>> CONFIG_INET. While the net/ Kconfig only pulls in the net/netlabel Kconfig
>>> if CONFIG_INET is defined, I'm guessing that without the explicit
>>> dependency there is nothing preventing someone from arriving at a bad
>>> configuration as we see here.
>>>
>>> Let me test this out to make sure my reasoning is right and if it is I'll
>>> post a patch to netdev later today.
>>>
>>> Thanks for catching this.
>> Hmmm. The existing logic in net/Kconfig seems to disable CONFIG_NETLABEL at
>> build time whenever CONFIG_INET is disabled in my .config file. The only way
>> I can recreate what you are seeing here is if I move the NetLabel include
>> outside of the INET conditional in net/Kconfig.
>>
>> Regardless, adding an explicit dependency on INET to NETLABEL shouldn't hurt
>> anything so I'll go ahead and post the patch to netdev. Hopefully someone who
>> understands Kconfig better than I do can help shed some light on this.
> Sorry, this patch doesn't help.
>
> I just checked the kernel .config again. SECURITY_SMACK
> selects NETLABEL even when INET is not enabled. Bad SMACK.
I'll send the patch properly, but it'll look like this.
security/smack/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/smack/Kconfig b/security/smack/Kconfig
index 9fb14ef..1be1088 100644
--- a/security/smack/Kconfig
+++ b/security/smack/Kconfig
@@ -1,5 +1,6 @@
config SECURITY_SMACK
bool "Simplified Mandatory Access Control Kernel Support"
+ depends on INET
depends on NET
depends on SECURITY
select NETLABEL
>
> I added Casey and mailing list to the cc:
>
>>>> net/built-in.o: In function `netlbl_cfg_cipsov4_add':
>>>> (.text+0x61757): undefined reference to `cipso_v4_doi_add'
>>>> net/built-in.o: In function `netlbl_cfg_cipsov4_del':
>>>> (.text+0x6177d): undefined reference to `cipso_v4_doi_remove'
>>>> net/built-in.o: In function `netlbl_cfg_cipsov4_map_add':
>>>> (.text+0x617ae): undefined reference to `cipso_v4_doi_getdef'
>>>> net/built-in.o: In function `netlbl_cfg_cipsov4_map_add':
>>>> (.text+0x61a49): undefined reference to `cipso_v4_doi_putdef'
>>>> net/built-in.o: In function `netlbl_sock_setattr':
>>>> (.text+0x6218c): undefined reference to `cipso_v4_sock_setattr'
>>>> net/built-in.o: In function `netlbl_sock_delattr':
>>>> (.text+0x6220b): undefined reference to `cipso_v4_sock_delattr'
>>>> net/built-in.o: In function `netlbl_sock_getattr':
>>>> (.text+0x62238): undefined reference to `cipso_v4_sock_getattr'
>>>> net/built-in.o: In function `netlbl_conn_setattr':
>>>> (.text+0x622de): undefined reference to `cipso_v4_sock_setattr'
>>>> net/built-in.o: In function `netlbl_conn_setattr':
>>>> (.text+0x62303): undefined reference to `cipso_v4_sock_delattr'
>>>> net/built-in.o: In function `netlbl_req_setattr':
>>>> (.text+0x62429): undefined reference to `cipso_v4_req_setattr'
>>>> net/built-in.o: In function `netlbl_req_setattr':
>>>> (.text+0x6244e): undefined reference to `cipso_v4_req_delattr'
>>>> net/built-in.o: In function `netlbl_req_delattr':
>>>> (.text+0x624ba): undefined reference to `cipso_v4_req_delattr'
>>>> net/built-in.o: In function `netlbl_skbuff_setattr':
>>>> (.text+0x62551): undefined reference to `cipso_v4_skbuff_setattr'
>>>> net/built-in.o: In function `netlbl_skbuff_setattr':
>>>> (.text+0x62576): undefined reference to `cipso_v4_skbuff_delattr'
>>>> net/built-in.o: In function `netlbl_skbuff_getattr':
>>>> (.text+0x62619): undefined reference to `cipso_v4_skbuff_getattr'
>>>> net/built-in.o: In function `netlbl_skbuff_err':
>>>> (.text+0x62685): undefined reference to `cipso_v4_error'
>>>> net/built-in.o: In function `netlbl_cache_invalidate':
>>>> (.text+0x626ab): undefined reference to `cipso_v4_cache_invalidate'
>>>> net/built-in.o: In function `netlbl_cache_add':
>>>> (.text+0x626ec): undefined reference to `cipso_v4_cache_add'
>>>> net/built-in.o: In function `netlbl_domhsh_remove_entry':
>>>> (.text+0x63294): undefined reference to `cipso_v4_doi_putdef'
>>>> net/built-in.o: In function `netlbl_domhsh_remove_entry':
>>>> (.text+0x632eb): undefined reference to `cipso_v4_doi_putdef'
>>>> net/built-in.o: In function `netlbl_domhsh_remove_af4':
>>>> (.text+0x6349b): undefined reference to `cipso_v4_doi_putdef'
>>>> net/built-in.o: In function `netlbl_mgmt_add_common.clone.1':
>>>> netlabel_mgmt.c:(.text+0x64a87): undefined reference to
>>>> `cipso_v4_doi_getdef' netlabel_mgmt.c:(.text+0x64c83): undefined reference
>>>> to `cipso_v4_doi_putdef' net/built-in.o: In function
>>>> `netlbl_cipsov4_listall':
>>>> netlabel_cipso_v4.c:(.text+0x66e52): undefined reference to
>>>> `cipso_v4_doi_walk' net/built-in.o: In function `netlbl_cipsov4_list':
>>>> netlabel_cipso_v4.c:(.text+0x67199): undefined reference to
>>>> `cipso_v4_doi_getdef' net/built-in.o: In function `netlbl_cipsov4_remove':
>>>> netlabel_cipso_v4.c:(.text+0x6771b): undefined reference to
>>>> `cipso_v4_doi_remove' net/built-in.o: In function
>>>> `netlbl_cipsov4_add_pass':
>>>> netlabel_cipso_v4.c:(.text+0x67a4b): undefined reference to
>>>> `cipso_v4_doi_add' netlabel_cipso_v4.c:(.text+0x67a76): undefined
>>>> reference
>>>> to `cipso_v4_doi_free' net/built-in.o: In function
>>>> `netlbl_cipsov4_add_local':
>>>> netlabel_cipso_v4.c:(.text+0x67b9a): undefined reference to
>>>> `cipso_v4_doi_add' netlabel_cipso_v4.c:(.text+0x67bc5): undefined
>>>> reference
>>>> to `cipso_v4_doi_free' net/built-in.o: In function
>>>> `netlbl_cipsov4_add_std':
>>>> netlabel_cipso_v4.c:(.text+0x68535): undefined reference to
>>>> `cipso_v4_doi_add' netlabel_cipso_v4.c:(.text+0x68575): undefined
>>>> reference
>>>> to `cipso_v4_doi_free'
>>>>
>>>>
>>>> Full randconfig file is attached.
>
>
^ permalink raw reply related
* Re: pull request: batman-adv 2012-11-30
From: David Miller @ 2012-11-30 17:22 UTC (permalink / raw)
To: ordex; +Cc: netdev, b.a.t.m.a.n
In-Reply-To: <1354270450-25935-1-git-send-email-ordex@autistici.org>
From: Antonio Quartulli <ordex@autistici.org>
Date: Fri, 30 Nov 2012 11:14:09 +0100
> Here is a lonely patch intended for net-next/linux-3.8.
> It it simply adapting the batman-adv code to use the new ETH_P_BATMAN define
> recently introduced in if_ether.h.
Pulled, thanks.
^ permalink raw reply
* Re: [PATCH] sctp: fix CONFIG_SCTP_DBG_MSG=y null pointer dereference in sctp_v6_get_dst()
From: David Miller @ 2012-11-30 17:21 UTC (permalink / raw)
To: tt.rantala; +Cc: linux-sctp, netdev, nhorman, vyasevich, sri, davej
In-Reply-To: <1354267062-15888-1-git-send-email-tt.rantala@gmail.com>
From: Tommi Rantala <tt.rantala@gmail.com>
Date: Fri, 30 Nov 2012 11:17:42 +0200
> Trinity (the syscall fuzzer) triggered the following BUG, reproducible
> only when the kernel is configured with CONFIG_SCTP_DBG_MSG=y.
>
> When CONFIG_SCTP_DBG_MSG is not set, the null pointer is never
> dereferenced.
...
> Signed-off-by: Tommi Rantala <tt.rantala@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 2/2] mac802154: use kfree_skb() instead of dev_kfree_skb()
From: David Miller @ 2012-11-30 17:19 UTC (permalink / raw)
To: alan
Cc: alex.bluesman.smirnov, dbaryshkov, eric.dumazet,
linux-zigbee-devel, netdev, linux-kernel
In-Reply-To: <1354249511-8086-2-git-send-email-alan@signal11.us>
From: Alan Ott <alan@signal11.us>
Date: Thu, 29 Nov 2012 23:25:11 -0500
> kfree_skb() indicates failure, which is where this is being used.
>
> Signed-off-by: Alan Ott <alan@signal11.us>
Applied.
^ permalink raw reply
* Re: [PATCH 1/2] mac802154: fix memory leaks
From: David Miller @ 2012-11-30 17:19 UTC (permalink / raw)
To: alan
Cc: alex.bluesman.smirnov, dbaryshkov, eric.dumazet,
linux-zigbee-devel, netdev, linux-kernel
In-Reply-To: <1354249511-8086-1-git-send-email-alan@signal11.us>
From: Alan Ott <alan@signal11.us>
Date: Thu, 29 Nov 2012 23:25:10 -0500
> kfree_skb() was not getting called in the case of some failures.
> This was pointed out by Eric Dumazet.
>
> Signed-off-by: Alan Ott <alan@signal11.us>
Applied.
^ permalink raw reply
* Re: [PATCH] 6lowpan: consider checksum bytes in fragmentation threshold
From: David Miller @ 2012-11-30 17:19 UTC (permalink / raw)
To: alan
Cc: alex.bluesman.smirnov, dbaryshkov, linux-zigbee-devel, netdev,
linux-kernel
In-Reply-To: <1354240544-22214-1-git-send-email-alan@signal11.us>
From: Alan Ott <alan@signal11.us>
Date: Thu, 29 Nov 2012 20:55:44 -0500
> Change the threshold for framentation of a lowpan packet from
> using the MTU size to now use the MTU size minus the checksum length,
> which is added by the hardware. For IEEE 802.15.4, this effectively
> changes it from 127 bytes to 125 bytes.
>
> Signed-off-by: Alan Ott <alan@signal11.us>
Applied.
^ permalink raw reply
* Re: [PATCH v3 net-next 0/2] myri10ge: LRO to GRO conversion
From: David Miller @ 2012-11-30 17:17 UTC (permalink / raw)
To: gallatin; +Cc: netdev
In-Reply-To: <50B7CE83.1020809@myri.com>
From: Andrew Gallatin <gallatin@myri.com>
Date: Thu, 29 Nov 2012 16:07:15 -0500
>
> drivers/net/ethernet/myricom/Kconfig | 1 -
> drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 275
> ++++++----------------
> 2 files changed, 74 insertions(+), 202 deletions(-)
>
Your email client is chopping up long lines, corrupting your
patches.
^ permalink raw reply
* Re: [PATCH net-next v1 3/3] net/mlx4_en: Set number of rx/tx channels using ethtool
From: David Miller @ 2012-11-30 17:16 UTC (permalink / raw)
To: amirv; +Cc: ogerlitz, oren, netdev
In-Reply-To: <1354216903-830-4-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.com>
Date: Thu, 29 Nov 2012 21:21:43 +0200
> +static void mlx4_en_get_channels(struct net_device *dev,
> + struct ethtool_channels *channel)
This is not formatted correctly, the argument on the second line
must line up with the first column after the openning "(" on the
previous line.
^ permalink raw reply
* Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc
From: chas williams - CONTRACTOR @ 2012-11-30 17:12 UTC (permalink / raw)
To: David Woodhouse
Cc: Krzysztof Mazur, David Laight, davem, netdev, linux-kernel,
nathan
In-Reply-To: <1354292626.21562.298.camel@shinybook.infradead.org>
On Fri, 30 Nov 2012 16:23:46 +0000
David Woodhouse <dwmw2@infradead.org> wrote:
> On Fri, 2012-11-30 at 12:10 +0000, David Woodhouse wrote:
> > In that case I think we're fine. I'll just do the same thing in
> > br2684_push(), fix up the comment you just corrected, and we're all
> > good.
>
> OK, here's an update to me my patch 8/17 'br2684: don't send frames on
> not-ready vcc'. It takes the socket lock and does fairly much the same
> thing as your pppoatm version. It returns NETDEV_TX_BUSY and stops the
> queue if the socket is locked, and it gets woken from the ->release_cb
> callback.
>
> I've dropped your Acked-By: since it's mostly new, but feel free to give
> me a fresh one. With this I think we're done.
>
> Unless Chas has any objections, I'll ask Dave to pull it...
no objections. i think this deals with my concerns. as for splitting
the close functions, from one of your previous messages:
>Really, what we're saying is that *one* of the driver or protocol close
>functions needs to be split, and we need to do DPD or PDP. Since the
>device driver *can* abort/flush the TX queue and also any pending RX
>being handled by a tasklet, I think it makes most sense to keep it in
>the middle, with the protocol being handled first and last... which is
>the current order, as long as we consider setting ATM_VF_CLOSE to be the
>first part.
i believe this is essentially already done with the release_cb()
implementation right? that is splitting the protocol detach/shutdown
into two parts.
^ permalink raw reply
* Re: pull-request: can-next 2012-11-29
From: David Miller @ 2012-11-30 17:12 UTC (permalink / raw)
To: mkl; +Cc: netdev, linux-can
In-Reply-To: <50B76815.8010907@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Thu, 29 Nov 2012 14:50:13 +0100
> this pull request is for net-next/master. There is a patch by Alexander
> Stein fixing a reference counter problem which can make driver
> unloading impossible (stable Cc'ed). And several patches by me which
> remove an obsolete mechanism from several drivers, which is already
> handled at the infrastructure level.
Applied thanks.
^ permalink raw reply
* Re: [PATCH] mISDN: improve bitops usage
From: David Miller @ 2012-11-30 17:11 UTC (permalink / raw)
To: akinobu.mita; +Cc: netdev, isdn
In-Reply-To: <1354188465-29012-1-git-send-email-akinobu.mita@gmail.com>
From: Akinobu Mita <akinobu.mita@gmail.com>
Date: Thu, 29 Nov 2012 20:27:45 +0900
> This improves bitops usages in several points:
>
> - Convert u64 to a proper bitmap declaration. This enables to remove
> superfluous typecasting from 'u64' to 'unsigned long *'.
>
> - Convert superfluous atomic bitops to non atomic bitops. The bitmap
> is allocated on the stack and it is not accessed by any other threads,
> so using atomic bitops is not necessary.
>
> - Use find_next_zero_bit and find_next_zero_bit instead of calling
> test_bit() for each bit.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] ipv6: unify logic evaluating inet6_dev's accept_ra property
From: David Miller @ 2012-11-30 17:09 UTC (permalink / raw)
To: shmulik.ladkani; +Cc: netdev, yoshfuji, tgraf, tore
In-Reply-To: <1354181179-16294-1-git-send-email-shmulik.ladkani@gmail.com>
From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Date: Thu, 29 Nov 2012 11:26:19 +0200
> + /*
> + * If forwarding is enabled, RA are not accepted unless the special
> + * hybrid mode (accept_ra=2) is enabled.
> + */
Please format this comment correctly, in the networking we use
the style:
/* That looks
* like this.
*/
/*
* Not
* like this.
*/
Thanks.
^ permalink raw reply
* Re: [net-next PATCH v1] 8021q: fix vlan device to inherit the unicast filtering capability flag
From: David Miller @ 2012-11-30 17:09 UTC (permalink / raw)
To: yi.zou; +Cc: netdev, devel
In-Reply-To: <20121128234520.6615.41220.stg.yi.zou@intel.com>
From: Yi Zou <yi.zou@intel.com>
Date: Wed, 28 Nov 2012 15:45:24 -0800
> This bug is observed on running FCoE over a VLAN device associated w/
> a real device that has IFF_UNICAST_FLT set since FCoE would add unicast
> address such as FLOGI MAC to the VLAN interface that FCoE is on. Since
> currently, VLAN device is not inheriting the IFF_UNICAST_FLT flag from the
> parent real device even though the real device is capable of doing unicast
> filtering. This forces the VLAN device and its real device go to promiscuous
> mode unnecessarily even the added address is actually being added to the
> available unicast filter table in real device.
>
> Signed-off-by: Yi Zou <yi.zou@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH][RESEND] bonding: delete migrated IP addresses from the rlb hash table
From: David Miller @ 2012-11-30 17:08 UTC (permalink / raw)
To: fubar; +Cc: jbohac, andy, netdev
In-Reply-To: <18712.1354223407@death.nxdomain>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Thu, 29 Nov 2012 13:10:07 -0800
> Jiri Bohac <jbohac@suse.cz> wrote:
>
>>Signed-off-by: Jiri Bohac <jbohac@suse.cz>
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied.
^ permalink raw reply
* Re: [PATCH] bonding: rlb mode of bond should not alter ARP originating via bridge
From: David Miller @ 2012-11-30 17:08 UTC (permalink / raw)
To: fubar; +Cc: zheng.x.li, netdev, andy, linux-kernel, joe.jin
In-Reply-To: <15005.1354213705@death.nxdomain>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Thu, 29 Nov 2012 10:28:25 -0800
> Zheng Li <zheng.x.li@oracle.com> wrote:
>
>>Do not modify or load balance ARP packets passing through balance-alb
>>mode (wherein the ARP did not originate locally, and arrived via a bridge).
>>
>>Modifying pass-through ARP replies causes an incorrect MAC address
>>to be placed into the ARP packet, rendering peers unable to communicate
>>with the actual destination from which the ARP reply originated.
>>
>>Load balancing pass-through ARP requests causes an entry to be
>>created for the peer in the rlb table, and bond_alb_monitor will
>>occasionally issue ARP updates to all peers in the table instrucing them
>>as to which MAC address they should communicate with; this occurs when
>>some event sets rx_ntt. In the bridged case, however, the MAC address
>>used for the update would be the MAC of the slave, not the actual source
>>MAC of the originating destination. This would render peers unable to
>>communicate with the destinations beyond the bridge.
>>
>>Signed-off-by: Zheng Li <zheng.x.li@oracle.com>
>>Cc: Jay Vosburgh <fubar@us.ibm.com>
>>Cc: Andy Gospodarek <andy@greyhouse.net>
>>Cc: "David S. Miller" <davem@davemloft.net>
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied.
^ permalink raw reply
* [PATCH] MAINTAINERS: fix bouncing tun/tap entries
From: Jiri Slaby @ 2012-11-30 17:05 UTC (permalink / raw)
To: maxk; +Cc: netdev, jirislaby, linux-kernel
Delivery to the following recipient failed permanently:
vtun@office.satix.net
Technical details of permanent failure:
DNS Error: Domain name not found
Of course:
$ host office.satix.net
Host office.satix.net not found: 3(NXDOMAIN)
===========
And "Change of Email Address Notification":
Old Address New Address Email Subject
------------------------------------------------------
maxk@qualcomm.com maxk@qti.qualcomm.com "tuntap: multiqueue...
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Maxim Krasnyansky <maxk@qti.qualcomm.com>
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 61b2e14..75d3b88 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7696,8 +7696,7 @@ S: Maintained
F: drivers/net/ethernet/dec/tulip/
TUN/TAP driver
-M: Maxim Krasnyansky <maxk@qualcomm.com>
-L: vtun@office.satix.net
+M: Maxim Krasnyansky <maxk@qti.qualcomm.com>
W: http://vtun.sourceforge.net/tun
S: Maintained
F: Documentation/networking/tuntap.txt
--
1.8.0.1
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox