* (unknown),
From: Mr Peter Steve @ 2013-03-13 9:57 UTC (permalink / raw)
Do You Need A Loan?If Yes Apply With Loan Amount. Duration. Full Name. Country. Address. Phone Number,
^ permalink raw reply
* Re: rt2x00: Kconfig symbols RALINK_RT288X and RALINK_RT305X
From: Jonas Gorski @ 2013-03-13 10:35 UTC (permalink / raw)
To: Paul Bolle
Cc: Ivo van Doorn, Gertjan van Wingerde, Helmut Schaa,
John W. Linville, linux-wireless, users, netdev, linux-kernel,
John Crispin
In-Reply-To: <1363169039.3137.186.camel@x61.thuisdomein>
On 13 March 2013 11:03, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Wed, 2013-03-13 at 10:51 +0100, Jonas Gorski wrote:
>> The actual accepted Kconfig symbol names are different though, so they
>> should be changed in rt2x00 to match them (SOC_RT288X and SOC_RT305X).
>
> Thanks. Note that I could not find an actual Kconfig symbol SOC_RT288X!
Ah, yes, the inital submission only included RT305X support, not
RT288X (and neither of the newer chips). These will come later.
> Anyhow, I guess somebody has the (trivial) patch to convert
> RALINK_RT...X and CONFIG_RALINK_RT...X to their SOC_* equivalents queued
> for inclusion in v3.9-rcX. Is that correct?
Yes, that should be everything. John Crispin, anything missing from that?
Jonas
^ permalink raw reply
* Re: [PATCH net-next v3] netxen: write IP address to firmware when using bonding
From: Nikolay Aleksandrov @ 2013-03-13 10:34 UTC (permalink / raw)
To: David Miller; +Cc: netdev, rajesh.borundia, agospoda, sony.chacko
In-Reply-To: <20130313.044244.2078533144108853623.davem@davemloft.net>
On 13/03/13 09:42, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay@redhat.com>
> Date: Tue, 12 Mar 2013 13:49:01 +0100
>
>> This patch allows LRO aggregation on bonded devices that contain an
>> NX3031 device. It also adds a for_each_netdev_in_bond_rcu(bond, slave)
>> macro which executes for each slave that has bond as master.
>
> The new logic looks like it will configure the IPs for bonding
> but not for VLANs, is that intentional?
The case bond -> vlan -> netxen was intentionally dropped as it leads to
many new issues, if that is what you are referring to. The case vlan ->
netxen still works, since the address of orig_dev is unconditionally
programmed if the original dev is a netxen. The problem was with a bond
acting on a vlan which is configured on a netxen because we would have
to keep track of which bonding master the programmed addresses belong to.
^ permalink raw reply
* [PATCH v2 1/1] ipv4: fix definition of FIB_TABLE_HASHSZ
From: Denis V. Lunev @ 2013-03-13 10:24 UTC (permalink / raw)
To: davem; +Cc: netdev, Denis V. Lunev, Tingwei Liu, Alexey Kuznetsov
From: "Denis V. Lunev" <den@openvz.org>
a long time ago by the commit
commit 93456b6d7753def8760b423ac6b986eb9d5a4a95
Author: Denis V. Lunev <den@openvz.org>
Date: Thu Jan 10 03:23:38 2008 -0800
[IPV4]: Unify access to the routing tables.
the defenition of FIB_HASH_TABLE size has obtained wrong dependency:
it should depend upon CONFIG_IP_MULTIPLE_TABLES (as was in the original
code) but it was depended from CONFIG_IP_ROUTE_MULTIPATH
This patch returns the situation to the original state.
The problem was spotted by Tingwei Liu.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Tingwei Liu <tingw.liu@gmail.com>
CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
---
Changes from v1:
- corrected CONFIG_IP_MULTIPLE_TABLES branches. HASHSZ should be 256
if defined
- holy crap. Original patch has wrong define CONFIG_IP_MULTIPLE_TABLES
I have forgotten all things in kernel :( Fixed too. Checked both
branches with #error inside
include/net/ip_fib.h | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 9497be1..3a7ce04 100644
--- a/include/net/ip_fib.h
+++ b/include/net/ip_fib.h
@@ -152,18 +152,16 @@ struct fib_result_nl {
};
#ifdef CONFIG_IP_ROUTE_MULTIPATH
-
#define FIB_RES_NH(res) ((res).fi->fib_nh[(res).nh_sel])
-
-#define FIB_TABLE_HASHSZ 2
-
#else /* CONFIG_IP_ROUTE_MULTIPATH */
-
#define FIB_RES_NH(res) ((res).fi->fib_nh[0])
+#endif /* CONFIG_IP_ROUTE_MULTIPATH */
+#ifdef CONFIG_IP_MULTIPLE_TABLES
#define FIB_TABLE_HASHSZ 256
-
-#endif /* CONFIG_IP_ROUTE_MULTIPATH */
+#else
+#define FIB_TABLE_HASHSZ 2
+#endif
extern __be32 fib_info_update_nh_saddr(struct net *net, struct fib_nh *nh);
--
1.7.7.6
^ permalink raw reply related
* Re: [iproute2] Fix -oneline output when alias present
From: Andreas Henriksson @ 2013-03-13 9:48 UTC (permalink / raw)
To: roopa; +Cc: shemminger, netdev
In-Reply-To: <1363125827-14129-1-git-send-email-roopa@cumulusnetworks.com>
Hi!
Just wanted to point out some minor style issues with your patch.
See below...
On Tue, Mar 12, 2013 at 12:03:47PM -0000, roopa@cumulusnetworks.com wrote:
[...]
> - if (do_link && tb[IFLA_IFALIAS])
> - fprintf(fp,"\n alias %s",
> + if (do_link && tb[IFLA_IFALIAS]) {
> + fprintf(fp, "%s", _SL_);
> + fprintf(fp," alias %s",
^^^ missing space here.
Also, why not use a single fprintf?
Like:
fprintf(fp, "%s alias %s",
_SL_,
> rta_getattr_str(tb[IFLA_IFALIAS]));
> + }
Then you wouldn't need these brackets either...
>
> if (do_link && show_stats) {
> if (tb[IFLA_STATS64])
--
Andreas Henriksson
^ permalink raw reply
* Re: [PATCH] sunrpc: drop "select NETVM"
From: Mel Gorman @ 2013-03-13 10:08 UTC (permalink / raw)
To: J. Bruce Fields
Cc: Paul Bolle, Trond Myklebust, David S. Miller, linux-nfs, netdev,
linux-kernel
In-Reply-To: <20130309175118.GJ31448@fieldses.org>
On Sat, Mar 09, 2013 at 12:51:18PM -0500, J. Bruce Fields wrote:
> ACK.
>
> On Sat, Mar 09, 2013 at 05:02:31PM +0100, Paul Bolle wrote:
> > The Kconfig entry for SUNRPC_SWAP selects NETVM. That select statement
> > was added in commit a564b8f0398636ba30b07c0eaebdef7ff7837249 ("nfs:
> > enable swap on NFS").
>
> Cc'ing Mel Gorman just in case there was something else going on there.
>
> --b.
>
> > But there's no Kconfig symbol NETVM. It apparently
> > was only in used in development versions of the swap over nfs
> > functionality but never entered mainline. Anyhow, it is a nop and can
> > safely be dropped.
> >
Correct, the NETVM symbol existed in an early version of swap-over-nfs
that I failed to clean up properly. Thanks.
--
Mel Gorman
SUSE Labs
^ permalink raw reply
* Re: rt2x00: Kconfig symbols RALINK_RT288X and RALINK_RT305X
From: Paul Bolle @ 2013-03-13 10:03 UTC (permalink / raw)
To: Jonas Gorski
Cc: Ivo van Doorn, Gertjan van Wingerde, Helmut Schaa,
John W. Linville, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, John Crispin
In-Reply-To: <CAOiHx=n4a26z=PS02E2KjD2Y3Pp0P0x-5Ns6WRc-WScNF=EO_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, 2013-03-13 at 10:51 +0100, Jonas Gorski wrote:
> On 13 March 2013 09:59, Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org> wrote:
> > 3) What is the current status of the (out of tree) code that adds
> > RALINK_RT288X and RALINK_RT305X?
>
> They are now present in 3.9-rc1, see a0b0197c (more specifically
> 85639910..d3d2b420) :)
Great.
> The actual accepted Kconfig symbol names are different though, so they
> should be changed in rt2x00 to match them (SOC_RT288X and SOC_RT305X).
Thanks. Note that I could not find an actual Kconfig symbol SOC_RT288X!
Anyhow, I guess somebody has the (trivial) patch to convert
RALINK_RT...X and CONFIG_RALINK_RT...X to their SOC_* equivalents queued
for inclusion in v3.9-rcX. Is that correct?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: rt2x00: Kconfig symbols RALINK_RT288X and RALINK_RT305X
From: Jonas Gorski @ 2013-03-13 9:51 UTC (permalink / raw)
To: Paul Bolle
Cc: Ivo van Doorn, Gertjan van Wingerde, Helmut Schaa,
John W. Linville, linux-wireless, users, netdev, linux-kernel,
John Crispin
In-Reply-To: <1363165170.3137.182.camel@x61.thuisdomein>
On 13 March 2013 09:59, Paul Bolle <pebolle@tiscali.nl> wrote:
> 0) Support for rt2800pci (or "the rt2860/rt3090 chipsets") was added in
> v2.6.33 (three years ago). References to the related Kconfig symbols
> RALINK_RT288X and RALINK_RT305X were introduced in that release. So were
> checks for their macros (CONFIG_RALINK_RT288X and CONFIG_RALINK_RT305X).
>
> 1) The Kconfig symbols themselves were never added in mainline. So these
> references and macros appear to be just markers for dead code in
> mainline, as that code will not be built.
>
> 2) This was previously discussed in
> https://lkml.org/lkml/2010/7/14/110 . The patch submitted in that
> message (which would remove all the dead code at the time) did not get
> applied.
>
> 3) What is the current status of the (out of tree) code that adds
> RALINK_RT288X and RALINK_RT305X?
They are now present in 3.9-rc1, see a0b0197c (more specifically
85639910..d3d2b420) :)
The actual accepted Kconfig symbol names are different though, so they
should be changed in rt2x00 to match them (SOC_RT288X and SOC_RT305X).
Jonas
^ permalink raw reply
* Re: [PATCH net-next 2/2] qlcnic: Bump up the version to 5.1.37
From: David Miller @ 2013-03-13 9:37 UTC (permalink / raw)
To: shahed.shaikh; +Cc: netdev, Dept_NX_Linux_NIC_Driver
In-Reply-To: <1363114937-23283-2-git-send-email-shahed.shaikh@qlogic.com>
From: Shahed Shaikh <shahed.shaikh@qlogic.com>
Date: Tue, 12 Mar 2013 15:02:17 -0400
> From: Shahed Shaikh <shahed.shaikh@qlogic.com>
>
> Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/2] qlcnic: Implement flash sysfs callback for 83xx adapter
From: David Miller @ 2013-03-13 9:37 UTC (permalink / raw)
To: shahed.shaikh; +Cc: netdev, Dept_NX_Linux_NIC_Driver, himanshu.madhani
In-Reply-To: <1363114937-23283-1-git-send-email-shahed.shaikh@qlogic.com>
From: Shahed Shaikh <shahed.shaikh@qlogic.com>
Date: Tue, 12 Mar 2013 15:02:16 -0400
> From: Himanshu Madhani <himanshu.madhani@qlogic.com>
>
> QLogic applications use these callbacks to perform
>
> o NIC Partitioning (NPAR) configuration and management
> o Diagnostic tests
> o Flash access and updates
>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
> Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Applied.
^ permalink raw reply
* Re: [PATCH v3 net-next 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly
From: Mark Jackson @ 2013-03-13 9:34 UTC (permalink / raw)
To: Mugunthan V N; +Cc: netdev, davem, linux-arm-kernel, linux-omap
In-Reply-To: <1361175560-600-1-git-send-email-mugunthanvnm@ti.com>
On 18/02/13 08:19, Mugunthan V N wrote:
> CPDMA interrupts are not properly acknowledged which leads to interrupt
> storm, only cpdma interrupt 0 is acknowledged in Davinci CPDMA driver.
> Changed cpdma_ctlr_eoi api to acknowledge 1 and 2 interrupts which are
> used for rx and tx respectively.
>
> Reported-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Not sure if I'm seeing this same problem [1], but it doesn't appear fixed to me.
I've tried both mainline -rc2 and -next.
[1] https://lkml.org/lkml/2013/3/12/376
Regards
Mark J.
^ permalink raw reply
* Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR
From: David Miller @ 2013-03-13 9:31 UTC (permalink / raw)
To: silviupopescu1990
Cc: linux-bluetooth, marcel, gustavo, johan.hedberg, netdev,
linux-kernel
In-Reply-To: <1363111995-26866-1-git-send-email-silviupopescu1990@gmail.com>
From: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Date: Tue, 12 Mar 2013 20:13:15 +0200
> @@ -590,10 +590,7 @@ int __init bt_sysfs_init(void)
> bt_debugfs = debugfs_create_dir("bluetooth", NULL);
>
> bt_class = class_create(THIS_MODULE, "bluetooth");
> - if (IS_ERR(bt_class))
> - return PTR_ERR(bt_class);
> -
> - return 0;
> + return PTR_RET(bt_class)
Don't bother submitting patches you aren't even going to try
to compile.
I'm rejecting all of your current submissions. Resubmit them
when you feel like typing 'make' from time to time.
^ permalink raw reply
* FW: [PATCH ethtool] ethtool: Add string to display support for KR PHY
From: Vasundhara, Volam @ 2013-03-13 9:29 UTC (permalink / raw)
To: bhutchings@solarflare.com; +Cc: netdev@vger.kernel.org
In-Reply-To: <f30e7788-1920-426f-88c2-afadac2cee75@CMEXHTCAS2.ad.emulex.com>
Please apply.
-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On Behalf Of Vasundhara, Volam
Sent: Tuesday, February 12, 2013 3:16 PM
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org; Vasundhara, Volam
Subject: [PATCH ethtool] ethtool: Add string to display support for KR PHY
Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex.com>
---
ethtool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ethtool.c b/ethtool.c
index 55bc082..205f574 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -512,6 +512,7 @@ dump_link_caps(const char *prefix, const char *an_prefix, u32 mask,
{ 0, ADVERTISED_2500baseX_Full, "2500baseX/Full" },
{ 0, ADVERTISED_10000baseT_Full, "10000baseT/Full" },
{ 0, ADVERTISED_10000baseKX4_Full, "10000baseKX4/Full" },
+ { 0, ADVERTISED_10000baseKR_Full, "10000baseKR/Full" },
{ 0, ADVERTISED_20000baseMLD2_Full, "20000baseMLD2/Full" },
{ 0, ADVERTISED_40000baseKR4_Full, "40000baseKR4/Full" },
{ 0, ADVERTISED_40000baseCR4_Full, "40000baseCR4/Full" },
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH 1/1] ipv4: fix definition of FIB_TABLE_HASHSZ
From: Denis V. Lunev @ 2013-03-13 9:27 UTC (permalink / raw)
To: Li Wei; +Cc: Denis V. Lunev, davem, netdev, Tingwei Liu, Alexey Kuznetsov
In-Reply-To: <514043CE.2080607@cn.fujitsu.com>
On 3/13/13 1:15 PM, Li Wei wrote:
> On 03/13/2013 04:43 PM, Denis V. Lunev wrote:
>> From: "Denis V. Lunev" <den@openvz.org>
>>
>> a long time ago by the commit
>>
>> commit 93456b6d7753def8760b423ac6b986eb9d5a4a95
>> Author: Denis V. Lunev <den@openvz.org>
>> Date: Thu Jan 10 03:23:38 2008 -0800
>>
>> [IPV4]: Unify access to the routing tables.
>>
>> the defenition of FIB_HASH_TABLE size has obtained wrong dependency:
>> it should depend upon CONFIG_IP_MULTIPLE_TABLES (as was in the original
>> code) but it was depended from CONFIG_IP_ROUTE_MULTIPATH
>>
>> This patch returns the situation to the original state.
>>
>> The problem was spotted by Tingwei Liu.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Tingwei Liu <tingw.liu@gmail.com>
>> CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
>> ---
>> include/net/ip_fib.h | 12 +++++-------
>> 1 files changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
>> index 9497be1..3b12d5c 100644
>> --- a/include/net/ip_fib.h
>> +++ b/include/net/ip_fib.h
>> @@ -152,18 +152,16 @@ struct fib_result_nl {
>> };
>>
>> #ifdef CONFIG_IP_ROUTE_MULTIPATH
>> -
>> #define FIB_RES_NH(res) ((res).fi->fib_nh[(res).nh_sel])
>> -
>> -#define FIB_TABLE_HASHSZ 2
>> -
>> #else /* CONFIG_IP_ROUTE_MULTIPATH */
>> -
>> #define FIB_RES_NH(res) ((res).fi->fib_nh[0])
>> +#endif /* CONFIG_IP_ROUTE_MULTIPATH */
>>
>> +#ifdef CONFIG_IP_ROUTE_MULTIPLE_TABLES
>> +#define FIB_TABLE_HASHSZ 2
>> +#else
>> #define FIB_TABLE_HASHSZ 256
>> -
>> -#endif /* CONFIG_IP_ROUTE_MULTIPATH */
>> +#endif
> With CONFIG_IP_ROUTE_MULTIPLE_TABLES defined we use a smaller FIB_TABLE_HASHSZ ?
>
> Thanks.
pfff :((( I have mistaken once again. Thank you for pointing this out.
I'll resend the patch.
>>
>> extern __be32 fib_info_update_nh_saddr(struct net *net, struct fib_nh *nh);
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* Re: [PATCH 1/1] ipv4: fix definition of FIB_TABLE_HASHSZ
From: Li Wei @ 2013-03-13 9:15 UTC (permalink / raw)
To: Denis V. Lunev; +Cc: davem, netdev, Tingwei Liu, Alexey Kuznetsov
In-Reply-To: <1363164218-16316-1-git-send-email-den@openvz.org>
On 03/13/2013 04:43 PM, Denis V. Lunev wrote:
> From: "Denis V. Lunev" <den@openvz.org>
>
> a long time ago by the commit
>
> commit 93456b6d7753def8760b423ac6b986eb9d5a4a95
> Author: Denis V. Lunev <den@openvz.org>
> Date: Thu Jan 10 03:23:38 2008 -0800
>
> [IPV4]: Unify access to the routing tables.
>
> the defenition of FIB_HASH_TABLE size has obtained wrong dependency:
> it should depend upon CONFIG_IP_MULTIPLE_TABLES (as was in the original
> code) but it was depended from CONFIG_IP_ROUTE_MULTIPATH
>
> This patch returns the situation to the original state.
>
> The problem was spotted by Tingwei Liu.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Tingwei Liu <tingw.liu@gmail.com>
> CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> ---
> include/net/ip_fib.h | 12 +++++-------
> 1 files changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
> index 9497be1..3b12d5c 100644
> --- a/include/net/ip_fib.h
> +++ b/include/net/ip_fib.h
> @@ -152,18 +152,16 @@ struct fib_result_nl {
> };
>
> #ifdef CONFIG_IP_ROUTE_MULTIPATH
> -
> #define FIB_RES_NH(res) ((res).fi->fib_nh[(res).nh_sel])
> -
> -#define FIB_TABLE_HASHSZ 2
> -
> #else /* CONFIG_IP_ROUTE_MULTIPATH */
> -
> #define FIB_RES_NH(res) ((res).fi->fib_nh[0])
> +#endif /* CONFIG_IP_ROUTE_MULTIPATH */
>
> +#ifdef CONFIG_IP_ROUTE_MULTIPLE_TABLES
> +#define FIB_TABLE_HASHSZ 2
> +#else
> #define FIB_TABLE_HASHSZ 256
> -
> -#endif /* CONFIG_IP_ROUTE_MULTIPATH */
> +#endif
With CONFIG_IP_ROUTE_MULTIPLE_TABLES defined we use a smaller FIB_TABLE_HASHSZ ?
Thanks.
>
> extern __be32 fib_info_update_nh_saddr(struct net *net, struct fib_nh *nh);
>
>
^ permalink raw reply
* Re: Pull request: sfc 2013-03-12
From: David Miller @ 2013-03-13 9:17 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers, scrum-linux
In-Reply-To: <1363110445.2780.14.camel@bwh-desktop.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 12 Mar 2013 17:47:25 +0000
> The following changes since commit c80a8512ee3a8e1f7c3704140ea55f21dc6bd651:
>
> net/core: move vlan_depth out of while loop in skb_network_protocol() (2013-03-12 11:47:40 -0400)
>
> are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/bwh/sfc.git sfc-3.9
>
> (commit fae8563b25f73dc584a07bcda7a82750ff4f7672)
>
> Just the one bug fix I mentioned before, but it's a pretty important one
> as it can cause silent data corruption or IOMMU page faults.
>
> This would be suitable for stable and should apply cleanly to all the
> 3.x.y branches. I'm still working through testing of larger sets of
> fixes.
Pulled, thanks Ben.
^ permalink raw reply
* Re: [ 000/100] 3.8.3-stable review
From: Andre Heider @ 2013-03-13 9:13 UTC (permalink / raw)
To: David Miller; +Cc: gregkh, linux-kernel, torvalds, akpm, stable, netdev
In-Reply-To: <20130313.043343.704615564539285477.davem@davemloft.net>
On Wed, Mar 13, 2013 at 9:33 AM, David Miller <davem@davemloft.net> wrote:
> From: Andre Heider <a.heider@gmail.com>
> Date: Wed, 13 Mar 2013 09:02:46 +0100
>
>> On Tue, Mar 12, 2013 at 11:30 PM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>>> This is the start of the stable review cycle for the 3.8.3 release.
>>> There are 100 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>
>> Hi,
>>
>> I'm missing a drivers/net/ethernet/atheros/atl1c patch, namely "atl1c:
>> restore buffer state".
>> In fact, it seems the whole netdev stable patch queue is missing:
>> http://patchwork.ozlabs.org/bundle/davem/stable/?state=*
>>
>> Unsure what the workflow is here, how are these supposed to make to stable?
>
> I submit those patches at a time of my own choosing, and if you
> read stable@vger.kernel.org you will see when I do that.
>
> I let patches cook in Linus's tree for a week or so before submitting
> to -stable so that any bugs in those changes are more likely to be
> discovered before the change is in -stable too.
I hoped that a fix I care about makes it to 3.8.3, but ok, that makes sense.
Thanks,
Andre
^ permalink raw reply
* rt2x00: Kconfig symbols RALINK_RT288X and RALINK_RT305X
From: Paul Bolle @ 2013-03-13 8:59 UTC (permalink / raw)
To: Ivo van Doorn, Gertjan van Wingerde, Helmut Schaa,
John W. Linville
Cc: linux-wireless, users, netdev, linux-kernel
0) Support for rt2800pci (or "the rt2860/rt3090 chipsets") was added in
v2.6.33 (three years ago). References to the related Kconfig symbols
RALINK_RT288X and RALINK_RT305X were introduced in that release. So were
checks for their macros (CONFIG_RALINK_RT288X and CONFIG_RALINK_RT305X).
1) The Kconfig symbols themselves were never added in mainline. So these
references and macros appear to be just markers for dead code in
mainline, as that code will not be built.
2) This was previously discussed in
https://lkml.org/lkml/2010/7/14/110 . The patch submitted in that
message (which would remove all the dead code at the time) did not get
applied.
3) What is the current status of the (out of tree) code that adds
RALINK_RT288X and RALINK_RT305X?
Paul Bolle
^ permalink raw reply
* Re: [PATCH] bonding: don't call update_speed_duplex() under spinlocks
From: David Miller @ 2013-03-13 8:53 UTC (permalink / raw)
To: vfalico
Cc: netdev, lkml, eric.dumazet, fubar, jeffrey.t.kirsher,
xiyou.wangcong, andy
In-Reply-To: <1363105892-3172-1-git-send-email-vfalico@redhat.com>
From: Veaceslav Falico <vfalico@redhat.com>
Date: Tue, 12 Mar 2013 17:31:32 +0100
> bond_update_speed_duplex() might sleep while calling underlying slave's
> routines. Move it out of atomic context in bond_enslave() and remove it
> from bond_miimon_commit() - it was introduced by commit 546add79, however
> when the slave interfaces go up/change state it's their responsibility to
> fire NETDEV_UP/NETDEV_CHANGE events so that bonding can properly update
> their speed.
>
> I've tested it on all combinations of ifup/ifdown, autoneg/speed/duplex
> changes, remote-controlled and local, on (not) MII-based cards. All changes
> are visible.
>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc()
From: David Miller @ 2013-03-13 8:51 UTC (permalink / raw)
To: andreas.fenkart; +Cc: mugunthanvnm, zonque, netdev, s.neumann, koen
In-Reply-To: <20130312202027.GA935@blumentopf>
From: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Date: Tue, 12 Mar 2013 21:20:27 +0100
> On Wed, Mar 13, 2013 at 01:17:44AM +0530, Mugunthan V N wrote:
>> On 3/12/2013 10:01 PM, Daniel Mack wrote:
>> >Commit fae50823d0 ("net: ethernet: davinci_cpdma: Add boundary for rx
>> >and tx descriptors") introduced a function to check the current
>> >allocation state of tx packets. The return value is taken into account
>> >to stop the netqork queue on the adapter in case there are no free
>> >slots.
>> >
>> >However, cpdma_check_free_tx_desc() returns 'true' if there is room in
>> >the bitmap, not 'false', so the usage of the function is wrong.
>> >
>> >Signed-off-by: Daniel Mack <zonque@gmail.com>
>> >Cc: Mugunthan V N <mugunthanvnm@ti.com>
>> >Reported-by: Sven Neumann <s.neumann@raumfeld.com>
>> >Reported-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
...
>> Tested-by: Mugunthan V N <mugunthanvnm@ti.com>
>> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
...
> This restores throughput to the level of 3.7.0
>
> Tested-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] packet: packet fanout rollover during socket overload
From: David Miller @ 2013-03-13 8:45 UTC (permalink / raw)
To: willemb; +Cc: netdev, edumazet
In-Reply-To: <20130313.044405.628402628153303315.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 13 Mar 2013 04:44:05 -0400 (EDT)
>
> My kingdom for a proper signoff.
Nevermind I see you did this in the second copy you posted.
Please mention that such things have changed below the "---"
seperator so that people can know instead of just guess.
^ permalink raw reply
* [PATCH 1/1] ipv4: fix definition of FIB_TABLE_HASHSZ
From: Denis V. Lunev @ 2013-03-13 8:43 UTC (permalink / raw)
To: davem; +Cc: netdev, Denis V. Lunev, Tingwei Liu, Alexey Kuznetsov
From: "Denis V. Lunev" <den@openvz.org>
a long time ago by the commit
commit 93456b6d7753def8760b423ac6b986eb9d5a4a95
Author: Denis V. Lunev <den@openvz.org>
Date: Thu Jan 10 03:23:38 2008 -0800
[IPV4]: Unify access to the routing tables.
the defenition of FIB_HASH_TABLE size has obtained wrong dependency:
it should depend upon CONFIG_IP_MULTIPLE_TABLES (as was in the original
code) but it was depended from CONFIG_IP_ROUTE_MULTIPATH
This patch returns the situation to the original state.
The problem was spotted by Tingwei Liu.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Tingwei Liu <tingw.liu@gmail.com>
CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
---
include/net/ip_fib.h | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 9497be1..3b12d5c 100644
--- a/include/net/ip_fib.h
+++ b/include/net/ip_fib.h
@@ -152,18 +152,16 @@ struct fib_result_nl {
};
#ifdef CONFIG_IP_ROUTE_MULTIPATH
-
#define FIB_RES_NH(res) ((res).fi->fib_nh[(res).nh_sel])
-
-#define FIB_TABLE_HASHSZ 2
-
#else /* CONFIG_IP_ROUTE_MULTIPATH */
-
#define FIB_RES_NH(res) ((res).fi->fib_nh[0])
+#endif /* CONFIG_IP_ROUTE_MULTIPATH */
+#ifdef CONFIG_IP_ROUTE_MULTIPLE_TABLES
+#define FIB_TABLE_HASHSZ 2
+#else
#define FIB_TABLE_HASHSZ 256
-
-#endif /* CONFIG_IP_ROUTE_MULTIPATH */
+#endif
extern __be32 fib_info_update_nh_saddr(struct net *net, struct fib_nh *nh);
--
1.7.7.6
^ permalink raw reply related
* Re: [PATCH net-next] packet: packet fanout rollover during socket overload
From: David Miller @ 2013-03-13 8:44 UTC (permalink / raw)
To: willemb; +Cc: netdev, edumazet
In-Reply-To: <1363100153-24433-1-git-send-email-willemb@google.com>
My kingdom for a proper signoff.
^ permalink raw reply
* Re: [PATCH net-next v3] netxen: write IP address to firmware when using bonding
From: David Miller @ 2013-03-13 8:42 UTC (permalink / raw)
To: nikolay; +Cc: netdev, rajesh.borundia, agospoda, sony.chacko
In-Reply-To: <1363092541-12391-1-git-send-email-nikolay@redhat.com>
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Tue, 12 Mar 2013 13:49:01 +0100
> This patch allows LRO aggregation on bonded devices that contain an
> NX3031 device. It also adds a for_each_netdev_in_bond_rcu(bond, slave)
> macro which executes for each slave that has bond as master.
The new logic looks like it will configure the IPs for bonding
but not for VLANs, is that intentional?
^ permalink raw reply
* [PATCH] net/core: another bug fix related to dst_neigh_lookup/dst_neigh_lookup_skb
From: Zhouyi Zhou @ 2013-03-13 8:40 UTC (permalink / raw)
To: netdev; +Cc: stable, trivial
I do a
/home/zzy/linux-stable#find . -name "*.c"|xargs grep -A 2 dst_neigh_lookup
and find that there are two places in drivers/infiniband/hw/cxgb4/cm.c
do not treat the error return of dst_neigh_lookup/dst_neigh_lookup_skb
Signed-off-by: Zhouyi Zhou <zhouzhouyi <at> gmail.com>
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 565bfb1..b5d6c4a 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -1575,6 +1575,12 @@ static int c4iw_reconnect(struct c4iw_ep *ep)
neigh = dst_neigh_lookup(ep->dst,
&ep->com.cm_id->remote_addr.sin_addr.s_addr);
+ if (!neigh) {
+ pr_err("%s - cannot alloc l2e.\n", __func__);
+ err = -ENOMEM;
+ goto fail4;
+ }
+
/* get a l2t entry */
if (neigh->dev->flags & IFF_LOOPBACK) {
PDBG("%s LOOPBACK\n", __func__);
@@ -3052,7 +3058,11 @@ static int rx_pkt(struct c4iw_dev *dev, struct
sk_buff *skb)
}
dst = &rt->dst;
neigh = dst_neigh_lookup_skb(dst, skb);
-
+ if (!neigh){
+ pr_err("%s - failed to allocate l2t entry!\n",
+ __func__);
+ goto free_dst;
+ }
if (neigh->dev->flags & IFF_LOOPBACK) {
pdev = ip_dev_find(&init_net, iph->daddr);
e = cxgb4_l2t_get(dev->rdev.lldi.l2t, neigh,
Thanks for your review
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox