* Re: [PATCH net-next] openvswitch: set correct protocol on route lookup
From: David Miller @ 2014-12-09 21:01 UTC (permalink / raw)
To: jbenc; +Cc: netdev, dev, pshelar, wenyuz
In-Reply-To: <0ead411e38bc57a8971ffd9826f7bf9bfdc6ccf1.1417796557.git.jbenc@redhat.com>
From: Jiri Benc <jbenc@redhat.com>
Date: Fri, 5 Dec 2014 17:24:28 +0100
> Respect what the caller passed to ovs_tunnel_get_egress_info.
>
> Fixes: 8f0aad6f35f7e ("openvswitch: Extend packet attribute for egress tunnel info")
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next ] Documentation (ixgbe.txt): use a decimal address.
From: David Miller @ 2014-12-09 21:02 UTC (permalink / raw)
To: ramirose; +Cc: netdev, jeffrey.t.kirsher
In-Reply-To: <1417800943-4429-1-git-send-email-ramirose@gmail.com>
From: Rami Rosen <ramirose@gmail.com>
Date: Fri, 5 Dec 2014 19:35:43 +0200
> This patch fixes the erronous usage of an hexadecimal address in the
> example, by replacing it with a decimal address.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] tipc: fix broadcast link wakeup after congestion
From: David Miller @ 2014-12-09 21:03 UTC (permalink / raw)
To: richard.alpe; +Cc: netdev, tipc-discussion, erik.hugne
In-Reply-To: <1417802360-5383-1-git-send-email-richard.alpe@ericsson.com>
From: <richard.alpe@ericsson.com>
Date: Fri, 5 Dec 2014 18:59:20 +0100
> From: Richard Alpe <richard.alpe@ericsson.com>
>
> commit 908344cdda80 ("tipc: fix bug in multicast congestion
> handling") introduced two bugs in the bclink wakeup function.
>
> This patch fixes the missing spinlock init for the broadcast link
> waiting_sks list and eliminates a broadcast link wakeup race caused
> by operation on the wakeup list without proper locking.
>
> Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
> Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
> Acked-by: Tero Aho <Tero.Aho@coriant.com>
This patch does not apply to the current 'net' tree.
^ permalink raw reply
* Re: the next chunk of iov_iter-net stuff for review
From: Al Viro @ 2014-12-09 21:04 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel
In-Reply-To: <20141209.150732.158834258918114526.davem@davemloft.net>
On Tue, Dec 09, 2014 at 03:07:32PM -0500, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Fri, 5 Dec 2014 05:56:23 +0000
>
> > OK, here's the tentative next batch (covers most of the ->recvmsg()
> > side of conversion). That's on top of merge of net-next#master with
> > vfs#iov_iter (the latter had been posted earlier today, Cc'd to netdev among
> > other places). This series corresponds to vfs#for-davem. Review and comments
> > would be very welcome...
>
> Al, what's the state of this? The iov_iter rewrite had some changes
> recently.
Well, I've got no comments whatsoever on the networking side of things;
might mean that everything's fine, might mean that everyone had been too
polite to say it's shite, might be something in between... FWIW, changes
in iov_iter do not affect any of those patches, so the stuff posted
for review is unchanged by those.
> Also, never assume I just know what GIT url to pull from, always
> explicitly state where you want me to pull changes from.
Sure, but that was just a call for review. _If_ you think that those patches
are OK, the URL is
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-davem
(and it pulls the fixed variant of iov_iter, otherwise it's exactly the same
as when I posted those).
FWIW, this stuff seems to work here, but I'd really like to hear at least
something before asking to pull. As it is, your mail is the first reply of
any kind...
^ permalink raw reply
* Re: [PATCH net] bnx2x: Implement ndo_gso_check()
From: David Miller @ 2014-12-09 21:05 UTC (permalink / raw)
To: joestringer; +Cc: netdev, ariel.elior, jesse, therbert, linux-kernel
In-Reply-To: <1417808146-3436-1-git-send-email-joestringer@nicira.com>
From: Joe Stringer <joestringer@nicira.com>
Date: Fri, 5 Dec 2014 11:35:46 -0800
> Use vxlan_gso_check() to advertise offload support for this NIC.
>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] dummy: add support for ethtool get_drvinfo
From: David Miller @ 2014-12-09 21:07 UTC (permalink / raw)
To: fbl; +Cc: netdev
In-Reply-To: <1417824804-20634-1-git-send-email-fbl@redhat.com>
From: Flavio Leitner <fbl@redhat.com>
Date: Fri, 5 Dec 2014 22:13:24 -0200
> The command 'ethtool -i' is useful to find details
> about the interface like the device driver being used.
> This was missing for dummy driver.
>
> Signed-off-by: Flavio Leitner <fbl@redhat.com>
Applied, thank you.
Consider adding a MODULE_VERSION instance since you've added an
explicit version.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next] dst: no need to take reference on DST_NOCACHE dsts
From: David Miller @ 2014-12-09 21:08 UTC (permalink / raw)
To: hannes; +Cc: netdev, edumazet, ja
In-Reply-To: <51b54bc66109594459e1a08c9022c5c48f20d910.1417889528.git.hannes@stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 6 Dec 2014 19:19:42 +0100
> Since commit f8864972126899 ("ipv4: fix dst race in sk_dst_get()")
> DST_NOCACHE dst_entries get freed by RCU. So there is no need to get a
> reference on them when we are in rcu protected sections.
>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next 1/4] netdevice: Add a function to check macvlan port
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417909984-13133-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:04 -0800
> Similar to a check for macvlan device, netif_is_macvlan(), add
> another function to check if a device is used as macvlan port.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/4] ipvlan: play well with macvlan device
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417909999-13234-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:19 -0800
> If a device is already a macvlan port then refuse to use it as
> an ipvlan port in the early stage of port creation.
>
> thost1:~# ip link add link eth0 mvl0 type macvlan
> thost1:~# echo $?
> 0
> thost1:~# ip link add link eth0 ipvl0 type ipvlan
> RTNETLINK answers: Device or resource busy
> thost1:~# echo $?
> 2
> thost1:~#
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 3/4] ipvlan: move the device check function into netdevice.h
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417910013-13274-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:33 -0800
> Move the port check [ipvlan_dev_master()] and device check
> [ipvlan_dev_slave()] functions to netdevice.h and rename them
> netif_is_ipvlan_port() and netif_is_ipvlan() resp. to be
> consistent with macvlan api naming.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 4/4] macvlan: play well with ipvlan device
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417910026-13371-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:46 -0800
> If device is already used as an ipvlan port then refuse to
> use it as a macvlan port at early stage of port creation.
>
> thost1:~# ip link add link eth0 ipvl0 type ipvlan
> thost1:~# echo $?
> 0
> thost1:~# ip link add link eth0 mvl0 type macvlan
> RTNETLINK answers: Device or resource busy
> thost1:~# echo $?
> 2
> thost1:~#
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] enic: add support for set/get rss hash key
From: David Miller @ 2014-12-09 21:12 UTC (permalink / raw)
To: _govind; +Cc: netdev, ssujith, benve
In-Reply-To: <1417972273-22661-1-git-send-email-_govind@gmx.com>
From: Govindarajulu Varadarajan <_govind@gmx.com>
Date: Sun, 7 Dec 2014 22:41:13 +0530
> This patch adds support for setting/getting rss hash key using ethtool.
>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 12/20] hp100: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:13 UTC (permalink / raw)
To: Julia.Lawall; +Cc: perex, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-13-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:54 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 14/20] chelsio: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:13 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux, joe, linux-kernel
In-Reply-To: <1417980062-25151-15-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:56 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 12/20] hp100: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: perex, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-13-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:54 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 14/20] chelsio: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux, joe, linux-kernel
In-Reply-To: <1417980062-25151-15-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:56 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 10/20] uli526x: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: grundler, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-11-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:52 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 4/20] dmfe: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: grundler, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-5-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:46 +0100
> The function name contains cleanup, not clean.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 5/20] isdn: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: isdn, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-6-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:47 +0100
> Replace a misspelled function name by %s and then __func__.
>
> In the first case, the print is just dropped, because kmalloc itself does
> enough error reporting.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* [PATCH] fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c
From: Valdis Kletnieks @ 2014-12-09 21:15 UTC (permalink / raw)
To: Eric Dumazet, John Fastabend, David S. Miller; +Cc: linux-kernel, netdev
commit 46e5da40ae (net: qdisc: use rcu prefix and silence
sparse warnings) triggers a spurious warning:
net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage!
The code should be using the _bh variant of rcu_dereference.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
net/sched/sch_fq_codel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
index b9ca32ebc1de..1e52decb7b59 100644
--- a/net/sched/sch_fq_codel.c
+++ b/net/sched/sch_fq_codel.c
@@ -94,7 +94,7 @@ static unsigned int fq_codel_classify(struct sk_buff *skb, struct Qdisc *sch,
TC_H_MIN(skb->priority) <= q->flows_cnt)
return TC_H_MIN(skb->priority);
- filter = rcu_dereference(q->filter_list);
+ filter = rcu_dereference_bh(q->filter_list);
if (!filter)
return fq_codel_hash(q, skb) + 1;
--
2.2.0
^ permalink raw reply related
* Re: the next chunk of iov_iter-net stuff for review
From: David Miller @ 2014-12-09 21:17 UTC (permalink / raw)
To: viro; +Cc: netdev, linux-kernel
In-Reply-To: <20141209210414.GJ22149@ZenIV.linux.org.uk>
From: Al Viro <viro@ZenIV.linux.org.uk>
Date: Tue, 9 Dec 2014 21:04:14 +0000
> Well, I've got no comments whatsoever on the networking side of things;
I've been away for more than 10 days, so I personally haven't had time
to review any of it.
Why don't you respin and I'll try to allocate some review time myself?
Thanks.
^ permalink raw reply
* Re: [PATCH net-next] enic: add support for set/get rss hash key
From: David Miller @ 2014-12-09 21:17 UTC (permalink / raw)
To: _govind; +Cc: netdev, ssujith, benve
In-Reply-To: <20141209.161218.1737626879465253606.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 09 Dec 2014 16:12:18 -0500 (EST)
> From: Govindarajulu Varadarajan <_govind@gmx.com>
> Date: Sun, 7 Dec 2014 22:41:13 +0530
>
>> This patch adds support for setting/getting rss hash key using ethtool.
>>
>> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
>
> Applied, thanks.
Hmmm...
drivers/net/ethernet/cisco/enic/enic_ethtool.c:461:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:461:2: warning: (near initialization for ‘enic_ethtool_ops.get_rxfh’) [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:462:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:462:2: warning: (near initialization for ‘enic_ethtool_ops.set_rxfh’) [enabled by default]
The function signature has changed for this method, you need to update this
patch and resubmit.
I've reverted it for now.
^ permalink raw reply
* Re: [RFC PATCH net-next 04/11] atl1c: remove disable_irq from netpoll controller, use netpoll_irq_lock
From: Chris Snook @ 2014-12-09 21:17 UTC (permalink / raw)
To: Sabrina Dubroca; +Cc: David S. Miller, netdev@vger.kernel.org, Jay Cliburn
In-Reply-To: <20141209172310.GA14343@kria>
Thanks for clarifying. I'll see if I can find someone with an atl1c
device to test this.
-- Chris
On Tue, Dec 9, 2014 at 9:23 AM, Sabrina Dubroca <sd@queasysnail.net> wrote:
> 2014-12-09, 16:13:33 +0000, Chris Snook wrote:
>> Could you explain the bug a little more for us? It's not obvious to me how
>> sleeping there is a problem.
>>
>> -- Chris
>
> Sorry for the lack of context.
>
> A might_sleep() check in disable_irq() was added in commit
> e22b886a8a43b ("sched/wait: Add might_sleep() checks") [1], and it
> triggers when using netconsole:
>
> BUG: sleeping function called from invalid context at kernel/irq/manage.c:104
> in_atomic(): 1, irqs_disabled(): 1, pid: 1, name: systemd
> no locks held by systemd/1.
> irq event stamp: 10102965
> hardirqs last enabled at (10102965): [<ffffffff810cbafd>] vprintk_emit+0x2dd/0x6a0
> hardirqs last disabled at (10102964): [<ffffffff810cb897>] vprintk_emit+0x77/0x6a0
> softirqs last enabled at (10102342): [<ffffffff810666aa>] __do_softirq+0x27a/0x6f0
> softirqs last disabled at (10102337): [<ffffffff81066e86>] irq_exit+0x56/0xe0
> Preemption disabled at:[<ffffffff817de50d>] printk_emit+0x31/0x33
>
> CPU: 1 PID: 1 Comm: systemd Not tainted 3.18.0-rc2-next-20141029-dirty #222
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140617_173321-var-lib-archbuild-testing-x86_64-tobias 04/01/2014
> ffffffff81a82291 ffff88001e743978 ffffffff817df31d 0000000000000000
> 0000000000000000 ffff88001e7439a8 ffffffff8108dfa2 ffff88001e7439a8
> ffffffff81a82291 0000000000000068 0000000000000000 ffff88001e7439d8
> Call Trace:
> [<ffffffff817df31d>] dump_stack+0x4f/0x7c
> [<ffffffff8108dfa2>] ___might_sleep+0x182/0x2b0
> [<ffffffff8108e10a>] __might_sleep+0x3a/0xc0
> [<ffffffff810ce358>] synchronize_irq+0x38/0xa0
> [<ffffffff810ce633>] ? __disable_irq_nosync+0x43/0x70
> [<ffffffff810ce690>] disable_irq+0x20/0x30
> [<ffffffff815d7253>] e1000_netpoll+0x23/0x60
> [<ffffffff81678d02>] netpoll_poll_dev+0x72/0x3a0
> [<ffffffff817e9993>] ? _raw_spin_trylock+0x73/0x90
> [<ffffffff8167920f>] ? netpoll_send_skb_on_dev+0x1df/0x2e0
> [<ffffffff816791e7>] netpoll_send_skb_on_dev+0x1b7/0x2e0
> [<ffffffff816795f3>] netpoll_send_udp+0x2e3/0x490
>
>
> The initial discussion of this problem is here: https://lkml.org/lkml/2014/10/29/523
>
>
> [1] https://lkml.org/lkml/2014/10/28/427
>
>
>> On Tue, Dec 9, 2014, 06:39 Sabrina Dubroca <sd@queasysnail.net> wrote:
>>
>> > disable_irq() may sleep, replace it with a spin_lock in the interrupt
>> > handler.
>> >
>> > No actual testing done, only compiled.
>> >
>> > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
>> > Cc: Jay Cliburn <jcliburn@gmail.com>
>> > Cc: Chris Snook <chris.snook@gmail.com>
>> > ---
>> > drivers/net/ethernet/atheros/atl1c/atl1c.h | 3 +++
>> > drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 12 ++++++++----
>> > 2 files changed, 11 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c.h
>> > b/drivers/net/ethernet/atheros/atl1c/atl1c.h
>> > index b9203d928938..8d97791e1516 100644
>> > --- a/drivers/net/ethernet/atheros/atl1c/atl1c.h
>> > +++ b/drivers/net/ethernet/atheros/atl1c/atl1c.h
>> > @@ -49,6 +49,7 @@
>> > #include <linux/workqueue.h>
>> > #include <net/checksum.h>
>> > #include <net/ip6_checksum.h>
>> > +#include <linux/netpoll.h>
>> >
>> > #include "atl1c_hw.h"
>> >
>> > @@ -555,6 +556,8 @@ struct atl1c_adapter {
>> > struct atl1c_rfd_ring rfd_ring;
>> > struct atl1c_rrd_ring rrd_ring;
>> > u32 bd_number; /* board number;*/
>> > +
>> > + struct netpoll_irq_lock netpoll_lock;
>> > };
>> >
>> > #define AT_WRITE_REG(a, reg, value) ( \
>> > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
>> > b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
>> > index 72fb86b9aa24..7a1b11eb8e4e 100644
>> > --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
>> > +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
>> > @@ -826,6 +826,7 @@ static int atl1c_sw_init(struct atl1c_adapter *adapter)
>> > atomic_set(&adapter->irq_sem, 1);
>> > spin_lock_init(&adapter->mdio_lock);
>> > spin_lock_init(&adapter->tx_lock);
>> > + netpoll_irq_lock_init(&adapter->netpoll_lock);
>> > set_bit(__AT_DOWN, &adapter->flags);
>> >
>> > return 0;
>> > @@ -1584,10 +1585,11 @@ static irqreturn_t atl1c_intr(int irq, void *data)
>> > struct pci_dev *pdev = adapter->pdev;
>> > struct atl1c_hw *hw = &adapter->hw;
>> > int max_ints = AT_MAX_INT_WORK;
>> > - int handled = IRQ_NONE;
>> > + irqreturn_t handled = IRQ_NONE;
>> > u32 status;
>> > u32 reg_data;
>> >
>> > + netpoll_irq_lock(&adapter->netpoll_lock);
>> > do {
>> > AT_READ_REG(hw, REG_ISR, ®_data);
>> > status = reg_data & hw->intr_mask;
>> > @@ -1622,7 +1624,8 @@ static irqreturn_t atl1c_intr(int irq, void *data)
>> > /* reset MAC */
>> > set_bit(ATL1C_WORK_EVENT_RESET,
>> > &adapter->work_event);
>> > schedule_work(&adapter->common_task);
>> > - return IRQ_HANDLED;
>> > + handled = IRQ_HANDLED;
>> > + goto out;
>> > }
>> >
>> > if (status & ISR_OVER)
>> > @@ -1641,6 +1644,9 @@ static irqreturn_t atl1c_intr(int irq, void *data)
>> > } while (--max_ints > 0);
>> > /* re-enable Interrupt*/
>> > AT_WRITE_REG(&adapter->hw, REG_ISR, 0);
>> > +
>> > +out:
>> > + netpoll_irq_unlock(&adapter->netpoll_lock);
>> > return handled;
>> > }
>> >
>> > @@ -1900,9 +1906,7 @@ static void atl1c_netpoll(struct net_device *netdev)
>> > {
>> > struct atl1c_adapter *adapter = netdev_priv(netdev);
>> >
>> > - disable_irq(adapter->pdev->irq);
>> > atl1c_intr(adapter->pdev->irq, netdev);
>> > - enable_irq(adapter->pdev->irq);
>> > }
>> > #endif
>> >
>> > --
>> > 2.1.3
>> >
>> >
>
> --
> Sabrina
^ permalink raw reply
* Re: [PATCH net-next v2 0/4] net: allow setting congctl via routing table
From: Daniel Borkmann @ 2014-12-09 21:22 UTC (permalink / raw)
To: David Miller; +Cc: hannes, fw, netdev
In-Reply-To: <20141209.155844.1175199719902606020.davem@davemloft.net>
On 12/09/2014 09:58 PM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Sun, 7 Dec 2014 00:39:19 +0100
>
>> This is the second part of our work and allows for setting the congestion
>> control algorithm via routing table. For details, please see individual
>> patches.
>>
>> Joint work with Florian Westphal, suggested by Hannes Frederic Sowa.
>>
>> Patch for iproute2: http://patchwork.ozlabs.org/patch/418149/
>>
>> Thanks!
>>
>> v1->v2:
>> - Very sorry, I noticed I had decnet disabled during testing.
>> Added missing header include in decnet, rest as is.
>
> I don't like how you have to explicitly load the congestion control
> module before asking for it to be used in the route entry metric.
>
> It should request the module automatically just like the stack already
> does for other cases.
Ok, sure, adding auto-loading should not be a problem. Will respin
with that tomorrow.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next 2/2] tcp_cubic: refine Hystart delay threshold
From: Dave Taht @ 2014-12-09 21:22 UTC (permalink / raw)
To: David Miller
Cc: Eric Dumazet, netdev@vger.kernel.org, Nandita Dukkipati,
Neal Cardwell, Yuchung Cheng, sangtae.ha
In-Reply-To: <20141209.145856.1280304544503810169.davem@davemloft.net>
On Tue, Dec 9, 2014 at 11:58 AM, David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 04 Dec 2014 16:13:49 -0800
>
>> From: Eric Dumazet <edumazet@google.com>
>>
>> In commit 2b4636a5f8ca ("tcp_cubic: make the delay threshold of HyStart
>> less sensitive"), HYSTART_DELAY_MIN was changed to 4 ms.
>>
>> The remaining problem is that using delay_min + (delay_min/16) as the
>> threshold is too sensitive.
>>
>> 6.25 % of variation is too small for rtt above 60 ms, which are not
>> uncommon.
> ...
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Applied.
Thank you (in a weird way!) for invalidating several weeks worth of
long rtt tests of some aqm and fq variants.
http://snapon.lab.bufferbloat.net/~d/comprehensive.puck/long_rtt_baseline.png
/me goes off to pull and recompile, and try again.
--
Dave Täht
http://www.bufferbloat.net/projects/bloat/wiki/Upcoming_Talks
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox