* [net-next v2 01/13] i40e: clear NVM update state on ethtool test
From: Jeff Kirsher @ 2014-12-09 21:26 UTC (permalink / raw)
To: davem; +Cc: Shannon Nelson, netdev, nhorman, sassmann, jogreene, Jeff Kirsher
In-Reply-To: <1418160380-29847-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Shannon Nelson <shannon.nelson@intel.com>
Once in a great while the NVMUpdate tools and the driver get out
of phase with each other. This gives us a way to reset things
without having to unload the driver.
Change-ID: I353f688236249a666a90ba3e7233e0ed8c1a04e9
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Tested-by: Jim Young <jamesx.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index fcd815d..25242f5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -1393,6 +1393,9 @@ static int i40e_eeprom_test(struct net_device *netdev, u64 *data)
netif_info(pf, hw, netdev, "eeprom test\n");
*data = i40e_diag_eeprom_test(&pf->hw);
+ /* forcebly clear the NVM Update state machine */
+ pf->hw.nvmupd_state = I40E_NVMUPD_STATE_INIT;
+
return *data;
}
--
1.9.3
^ permalink raw reply related
* [net-next v2 00/13][pull request] Intel Wired LAN Driver Updates 2014-12-09
From: Jeff Kirsher @ 2014-12-09 21:26 UTC (permalink / raw)
To: davem; +Cc: Jeff Kirsher, netdev, nhorman, sassmann, jogreene
This series contains updates to i40e and i40evf.
Jeff (me) provides a single patch to convert a macro to a static inline
function based on feedback from Joe Perches on a previous patch.
Shannon provides the remaining twelve patches against i40e. Almost all
of Shannon's patches cleanup/fix NVM issues varying in range from
adding more detail to debug messages, to removing dead code, to fixing
NVM state transitions after an error. Change the handy decoder interface
for admin queue return code to help catch and properly report the condition
as a useful errno rather than returning a misleading '0'. Added a range
check to avoid any possible array index-out-of-bound issues.
v2:
- fixed up patch 05 in the series to use the ARRAY_SIZE() macro as suggested
by Sergei Shtylyov
- fix up patch 13 to remove unnecessary parens in the return statement
as suggested by Sergei Shtylyov
The following are changes since commit b2abeeddad3844072d63f27602b581d9c4adc134:
net: ethernet: rocker: Add dependency to CONFIG_BRIDGE in Kconfig
and are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
Jeff Kirsher (1):
i40e/i40evf: Convert macro to static inline
Shannon Nelson (12):
i40e: clear NVM update state on ethtool test
i40e: better error messages for NVM update issues
i40e: let firmware catch the NVM busy error
i40e: rework debug messages for NVM update
i40e: add range check to i40e_aq_rc_to_posix
i40e: init NVM update state on adminq init
i40e: remove unused nvm_semaphore_wait
i40e: set max limit for access polling
i40e: fix up NVM update sm error handling
i40e: poll on NVM semaphore only if not other error
i40e: check for AQ timeout in aq_rc decode
i40e: add to NVM update debug message
drivers/net/ethernet/intel/i40e/i40e_adminq.c | 13 +-
drivers/net/ethernet/intel/i40e/i40e_adminq.h | 10 +-
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 55 ++++---
drivers/net/ethernet/intel/i40e/i40e_nvm.c | 198 ++++++++++++++++--------
drivers/net/ethernet/intel/i40e/i40e_type.h | 8 +-
drivers/net/ethernet/intel/i40evf/i40e_adminq.c | 6 -
drivers/net/ethernet/intel/i40evf/i40e_adminq.h | 10 +-
drivers/net/ethernet/intel/i40evf/i40e_type.h | 8 +-
8 files changed, 197 insertions(+), 111 deletions(-)
--
1.9.3
^ permalink raw reply
* Re: Possible regression: "gre: Use inner mac length when computing tunnel length"
From: Tom Herbert @ 2014-12-09 21:23 UTC (permalink / raw)
To: Timo Teras; +Cc: Alexander Duyck, Linux Netdev List
In-Reply-To: <20141209084425.7499dbd4@vostro>
On Mon, Dec 8, 2014 at 10:44 PM, Timo Teras <timo.teras@iki.fi> wrote:
> On Tue, 9 Dec 2014 08:26:45 +0200
> Timo Teras <timo.teras@iki.fi> wrote:
>
>> On Thu, 4 Dec 2014 08:00:19 -0800
>> Tom Herbert <therbert@google.com> wrote:
>>
>> > A fix is pending for net. Please try if you can.
>>
>> Finally got to testing this. Unfortunately, this does not seem to fix
>> the issue I am experiencing.
>>
>> Any suggestions?
>
> I think this fix is required, but does not fix the issue.
>
> I suspect my problem is with the fact that I have NBMA GRE tunnel.
>
> In ipgre_xmit() it is gre_handle_offloads() that is called first.
> However, in my case, the GRE header was already pushed earlier via
> header_ops. That's why the packet is skb_pull()'ed in the
> "if (dev->header_ops)" path, so that __gre_xmit can push back the
> header again on it.
>
> I wonder if it is correct to just move the gre_handle_offloads() call
> after the if() block, or if additional fixing is needed to make
> offloads work with nbma tunnels.
>
Yes, that probably is a good idea. iptunnel_handle_offloads resets
inner headers so that inner_mac header is probably wrong when there
are dev->header_ops.
Tom
> /Timo
^ permalink raw reply
* Re: the next chunk of iov_iter-net stuff for review
From: Al Viro @ 2014-12-09 21:23 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel
In-Reply-To: <20141209.161712.1258837733606317716.davem@davemloft.net>
On Tue, Dec 09, 2014 at 04:17:12PM -0500, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Tue, 9 Dec 2014 21:04:14 +0000
>
> > Well, I've got no comments whatsoever on the networking side of things;
>
> I've been away for more than 10 days, so I personally haven't had time
> to review any of it.
>
> Why don't you respin and I'll try to allocate some review time myself?
Umm... Do you want a rebase on top of current net-next/master?
^ permalink raw reply
* [patch net-next v2] net: sched: cls: use nla_nest_cancel instead of nlmsg_trim
From: Jiri Pirko @ 2014-12-09 21:23 UTC (permalink / raw)
To: netdev; +Cc: davem, jhs
In-Reply-To: <20141209.154849.439054105924395285.davem@davemloft.net>
To cancel nesting, this function is more convenient.
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
v1->v2:
- removed remaining use of b in tcindex pointed out by DaveM
---
net/sched/cls_cgroup.c | 3 +--
net/sched/cls_flow.c | 2 +-
net/sched/cls_fw.c | 3 +--
net/sched/cls_route.c | 3 +--
net/sched/cls_rsvp.h | 3 +--
net/sched/cls_tcindex.c | 7 +++----
6 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c
index 741bfa7..221697a 100644
--- a/net/sched/cls_cgroup.c
+++ b/net/sched/cls_cgroup.c
@@ -177,7 +177,6 @@ static int cls_cgroup_dump(struct net *net, struct tcf_proto *tp, unsigned long
struct sk_buff *skb, struct tcmsg *t)
{
struct cls_cgroup_head *head = rtnl_dereference(tp->root);
- unsigned char *b = skb_tail_pointer(skb);
struct nlattr *nest;
t->tcm_handle = head->handle;
@@ -198,7 +197,7 @@ static int cls_cgroup_dump(struct net *net, struct tcf_proto *tp, unsigned long
return skb->len;
nla_put_failure:
- nlmsg_trim(skb, b);
+ nla_nest_cancel(skb, nest);
return -1;
}
diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c
index 8e22718..15d68f2 100644
--- a/net/sched/cls_flow.c
+++ b/net/sched/cls_flow.c
@@ -638,7 +638,7 @@ static int flow_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
return skb->len;
nla_put_failure:
- nlmsg_trim(skb, nest);
+ nla_nest_cancel(skb, nest);
return -1;
}
diff --git a/net/sched/cls_fw.c b/net/sched/cls_fw.c
index 23fda2a..a5269f7 100644
--- a/net/sched/cls_fw.c
+++ b/net/sched/cls_fw.c
@@ -356,7 +356,6 @@ static int fw_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
{
struct fw_head *head = rtnl_dereference(tp->root);
struct fw_filter *f = (struct fw_filter *)fh;
- unsigned char *b = skb_tail_pointer(skb);
struct nlattr *nest;
if (f == NULL)
@@ -397,7 +396,7 @@ static int fw_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
return skb->len;
nla_put_failure:
- nlmsg_trim(skb, b);
+ nla_nest_cancel(skb, nest);
return -1;
}
diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c
index 098a273..2ecd246 100644
--- a/net/sched/cls_route.c
+++ b/net/sched/cls_route.c
@@ -593,7 +593,6 @@ static int route4_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
struct sk_buff *skb, struct tcmsg *t)
{
struct route4_filter *f = (struct route4_filter *)fh;
- unsigned char *b = skb_tail_pointer(skb);
struct nlattr *nest;
u32 id;
@@ -635,7 +634,7 @@ static int route4_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
return skb->len;
nla_put_failure:
- nlmsg_trim(skb, b);
+ nla_nest_cancel(skb, nest);
return -1;
}
diff --git a/net/sched/cls_rsvp.h b/net/sched/cls_rsvp.h
index b7af362..edd8ade 100644
--- a/net/sched/cls_rsvp.h
+++ b/net/sched/cls_rsvp.h
@@ -653,7 +653,6 @@ static int rsvp_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
{
struct rsvp_filter *f = (struct rsvp_filter *)fh;
struct rsvp_session *s;
- unsigned char *b = skb_tail_pointer(skb);
struct nlattr *nest;
struct tc_rsvp_pinfo pinfo;
@@ -694,7 +693,7 @@ static int rsvp_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
return skb->len;
nla_put_failure:
- nlmsg_trim(skb, b);
+ nla_nest_cancel(skb, nest);
return -1;
}
diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
index 0d9d891..bd49bf5 100644
--- a/net/sched/cls_tcindex.c
+++ b/net/sched/cls_tcindex.c
@@ -489,11 +489,10 @@ static int tcindex_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
{
struct tcindex_data *p = rtnl_dereference(tp->root);
struct tcindex_filter_result *r = (struct tcindex_filter_result *) fh;
- unsigned char *b = skb_tail_pointer(skb);
struct nlattr *nest;
- pr_debug("tcindex_dump(tp %p,fh 0x%lx,skb %p,t %p),p %p,r %p,b %p\n",
- tp, fh, skb, t, p, r, b);
+ pr_debug("tcindex_dump(tp %p,fh 0x%lx,skb %p,t %p),p %p,r %p\n",
+ tp, fh, skb, t, p, r);
pr_debug("p->perfect %p p->h %p\n", p->perfect, p->h);
nest = nla_nest_start(skb, TCA_OPTIONS);
@@ -543,7 +542,7 @@ static int tcindex_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
return skb->len;
nla_put_failure:
- nlmsg_trim(skb, b);
+ nla_nest_cancel(skb, nest);
return -1;
}
--
1.9.3
^ permalink raw reply related
* Re: [PATCH net-next 2/2] tcp_cubic: refine Hystart delay threshold
From: Dave Taht @ 2014-12-09 21:22 UTC (permalink / raw)
To: David Miller
Cc: Eric Dumazet, netdev@vger.kernel.org, Nandita Dukkipati,
Neal Cardwell, Yuchung Cheng, sangtae.ha
In-Reply-To: <20141209.145856.1280304544503810169.davem@davemloft.net>
On Tue, Dec 9, 2014 at 11:58 AM, David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 04 Dec 2014 16:13:49 -0800
>
>> From: Eric Dumazet <edumazet@google.com>
>>
>> In commit 2b4636a5f8ca ("tcp_cubic: make the delay threshold of HyStart
>> less sensitive"), HYSTART_DELAY_MIN was changed to 4 ms.
>>
>> The remaining problem is that using delay_min + (delay_min/16) as the
>> threshold is too sensitive.
>>
>> 6.25 % of variation is too small for rtt above 60 ms, which are not
>> uncommon.
> ...
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Applied.
Thank you (in a weird way!) for invalidating several weeks worth of
long rtt tests of some aqm and fq variants.
http://snapon.lab.bufferbloat.net/~d/comprehensive.puck/long_rtt_baseline.png
/me goes off to pull and recompile, and try again.
--
Dave Täht
http://www.bufferbloat.net/projects/bloat/wiki/Upcoming_Talks
^ permalink raw reply
* Re: [PATCH net-next v2 0/4] net: allow setting congctl via routing table
From: Daniel Borkmann @ 2014-12-09 21:22 UTC (permalink / raw)
To: David Miller; +Cc: hannes, fw, netdev
In-Reply-To: <20141209.155844.1175199719902606020.davem@davemloft.net>
On 12/09/2014 09:58 PM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Sun, 7 Dec 2014 00:39:19 +0100
>
>> This is the second part of our work and allows for setting the congestion
>> control algorithm via routing table. For details, please see individual
>> patches.
>>
>> Joint work with Florian Westphal, suggested by Hannes Frederic Sowa.
>>
>> Patch for iproute2: http://patchwork.ozlabs.org/patch/418149/
>>
>> Thanks!
>>
>> v1->v2:
>> - Very sorry, I noticed I had decnet disabled during testing.
>> Added missing header include in decnet, rest as is.
>
> I don't like how you have to explicitly load the congestion control
> module before asking for it to be used in the route entry metric.
>
> It should request the module automatically just like the stack already
> does for other cases.
Ok, sure, adding auto-loading should not be a problem. Will respin
with that tomorrow.
Thanks.
^ permalink raw reply
* Re: [RFC PATCH net-next 04/11] atl1c: remove disable_irq from netpoll controller, use netpoll_irq_lock
From: Chris Snook @ 2014-12-09 21:17 UTC (permalink / raw)
To: Sabrina Dubroca; +Cc: David S. Miller, netdev@vger.kernel.org, Jay Cliburn
In-Reply-To: <20141209172310.GA14343@kria>
Thanks for clarifying. I'll see if I can find someone with an atl1c
device to test this.
-- Chris
On Tue, Dec 9, 2014 at 9:23 AM, Sabrina Dubroca <sd@queasysnail.net> wrote:
> 2014-12-09, 16:13:33 +0000, Chris Snook wrote:
>> Could you explain the bug a little more for us? It's not obvious to me how
>> sleeping there is a problem.
>>
>> -- Chris
>
> Sorry for the lack of context.
>
> A might_sleep() check in disable_irq() was added in commit
> e22b886a8a43b ("sched/wait: Add might_sleep() checks") [1], and it
> triggers when using netconsole:
>
> BUG: sleeping function called from invalid context at kernel/irq/manage.c:104
> in_atomic(): 1, irqs_disabled(): 1, pid: 1, name: systemd
> no locks held by systemd/1.
> irq event stamp: 10102965
> hardirqs last enabled at (10102965): [<ffffffff810cbafd>] vprintk_emit+0x2dd/0x6a0
> hardirqs last disabled at (10102964): [<ffffffff810cb897>] vprintk_emit+0x77/0x6a0
> softirqs last enabled at (10102342): [<ffffffff810666aa>] __do_softirq+0x27a/0x6f0
> softirqs last disabled at (10102337): [<ffffffff81066e86>] irq_exit+0x56/0xe0
> Preemption disabled at:[<ffffffff817de50d>] printk_emit+0x31/0x33
>
> CPU: 1 PID: 1 Comm: systemd Not tainted 3.18.0-rc2-next-20141029-dirty #222
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140617_173321-var-lib-archbuild-testing-x86_64-tobias 04/01/2014
> ffffffff81a82291 ffff88001e743978 ffffffff817df31d 0000000000000000
> 0000000000000000 ffff88001e7439a8 ffffffff8108dfa2 ffff88001e7439a8
> ffffffff81a82291 0000000000000068 0000000000000000 ffff88001e7439d8
> Call Trace:
> [<ffffffff817df31d>] dump_stack+0x4f/0x7c
> [<ffffffff8108dfa2>] ___might_sleep+0x182/0x2b0
> [<ffffffff8108e10a>] __might_sleep+0x3a/0xc0
> [<ffffffff810ce358>] synchronize_irq+0x38/0xa0
> [<ffffffff810ce633>] ? __disable_irq_nosync+0x43/0x70
> [<ffffffff810ce690>] disable_irq+0x20/0x30
> [<ffffffff815d7253>] e1000_netpoll+0x23/0x60
> [<ffffffff81678d02>] netpoll_poll_dev+0x72/0x3a0
> [<ffffffff817e9993>] ? _raw_spin_trylock+0x73/0x90
> [<ffffffff8167920f>] ? netpoll_send_skb_on_dev+0x1df/0x2e0
> [<ffffffff816791e7>] netpoll_send_skb_on_dev+0x1b7/0x2e0
> [<ffffffff816795f3>] netpoll_send_udp+0x2e3/0x490
>
>
> The initial discussion of this problem is here: https://lkml.org/lkml/2014/10/29/523
>
>
> [1] https://lkml.org/lkml/2014/10/28/427
>
>
>> On Tue, Dec 9, 2014, 06:39 Sabrina Dubroca <sd@queasysnail.net> wrote:
>>
>> > disable_irq() may sleep, replace it with a spin_lock in the interrupt
>> > handler.
>> >
>> > No actual testing done, only compiled.
>> >
>> > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
>> > Cc: Jay Cliburn <jcliburn@gmail.com>
>> > Cc: Chris Snook <chris.snook@gmail.com>
>> > ---
>> > drivers/net/ethernet/atheros/atl1c/atl1c.h | 3 +++
>> > drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 12 ++++++++----
>> > 2 files changed, 11 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c.h
>> > b/drivers/net/ethernet/atheros/atl1c/atl1c.h
>> > index b9203d928938..8d97791e1516 100644
>> > --- a/drivers/net/ethernet/atheros/atl1c/atl1c.h
>> > +++ b/drivers/net/ethernet/atheros/atl1c/atl1c.h
>> > @@ -49,6 +49,7 @@
>> > #include <linux/workqueue.h>
>> > #include <net/checksum.h>
>> > #include <net/ip6_checksum.h>
>> > +#include <linux/netpoll.h>
>> >
>> > #include "atl1c_hw.h"
>> >
>> > @@ -555,6 +556,8 @@ struct atl1c_adapter {
>> > struct atl1c_rfd_ring rfd_ring;
>> > struct atl1c_rrd_ring rrd_ring;
>> > u32 bd_number; /* board number;*/
>> > +
>> > + struct netpoll_irq_lock netpoll_lock;
>> > };
>> >
>> > #define AT_WRITE_REG(a, reg, value) ( \
>> > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
>> > b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
>> > index 72fb86b9aa24..7a1b11eb8e4e 100644
>> > --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
>> > +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
>> > @@ -826,6 +826,7 @@ static int atl1c_sw_init(struct atl1c_adapter *adapter)
>> > atomic_set(&adapter->irq_sem, 1);
>> > spin_lock_init(&adapter->mdio_lock);
>> > spin_lock_init(&adapter->tx_lock);
>> > + netpoll_irq_lock_init(&adapter->netpoll_lock);
>> > set_bit(__AT_DOWN, &adapter->flags);
>> >
>> > return 0;
>> > @@ -1584,10 +1585,11 @@ static irqreturn_t atl1c_intr(int irq, void *data)
>> > struct pci_dev *pdev = adapter->pdev;
>> > struct atl1c_hw *hw = &adapter->hw;
>> > int max_ints = AT_MAX_INT_WORK;
>> > - int handled = IRQ_NONE;
>> > + irqreturn_t handled = IRQ_NONE;
>> > u32 status;
>> > u32 reg_data;
>> >
>> > + netpoll_irq_lock(&adapter->netpoll_lock);
>> > do {
>> > AT_READ_REG(hw, REG_ISR, ®_data);
>> > status = reg_data & hw->intr_mask;
>> > @@ -1622,7 +1624,8 @@ static irqreturn_t atl1c_intr(int irq, void *data)
>> > /* reset MAC */
>> > set_bit(ATL1C_WORK_EVENT_RESET,
>> > &adapter->work_event);
>> > schedule_work(&adapter->common_task);
>> > - return IRQ_HANDLED;
>> > + handled = IRQ_HANDLED;
>> > + goto out;
>> > }
>> >
>> > if (status & ISR_OVER)
>> > @@ -1641,6 +1644,9 @@ static irqreturn_t atl1c_intr(int irq, void *data)
>> > } while (--max_ints > 0);
>> > /* re-enable Interrupt*/
>> > AT_WRITE_REG(&adapter->hw, REG_ISR, 0);
>> > +
>> > +out:
>> > + netpoll_irq_unlock(&adapter->netpoll_lock);
>> > return handled;
>> > }
>> >
>> > @@ -1900,9 +1906,7 @@ static void atl1c_netpoll(struct net_device *netdev)
>> > {
>> > struct atl1c_adapter *adapter = netdev_priv(netdev);
>> >
>> > - disable_irq(adapter->pdev->irq);
>> > atl1c_intr(adapter->pdev->irq, netdev);
>> > - enable_irq(adapter->pdev->irq);
>> > }
>> > #endif
>> >
>> > --
>> > 2.1.3
>> >
>> >
>
> --
> Sabrina
^ permalink raw reply
* Re: [PATCH net-next] enic: add support for set/get rss hash key
From: David Miller @ 2014-12-09 21:17 UTC (permalink / raw)
To: _govind; +Cc: netdev, ssujith, benve
In-Reply-To: <20141209.161218.1737626879465253606.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 09 Dec 2014 16:12:18 -0500 (EST)
> From: Govindarajulu Varadarajan <_govind@gmx.com>
> Date: Sun, 7 Dec 2014 22:41:13 +0530
>
>> This patch adds support for setting/getting rss hash key using ethtool.
>>
>> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
>
> Applied, thanks.
Hmmm...
drivers/net/ethernet/cisco/enic/enic_ethtool.c:461:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:461:2: warning: (near initialization for ‘enic_ethtool_ops.get_rxfh’) [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:462:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:462:2: warning: (near initialization for ‘enic_ethtool_ops.set_rxfh’) [enabled by default]
The function signature has changed for this method, you need to update this
patch and resubmit.
I've reverted it for now.
^ permalink raw reply
* Re: the next chunk of iov_iter-net stuff for review
From: David Miller @ 2014-12-09 21:17 UTC (permalink / raw)
To: viro; +Cc: netdev, linux-kernel
In-Reply-To: <20141209210414.GJ22149@ZenIV.linux.org.uk>
From: Al Viro <viro@ZenIV.linux.org.uk>
Date: Tue, 9 Dec 2014 21:04:14 +0000
> Well, I've got no comments whatsoever on the networking side of things;
I've been away for more than 10 days, so I personally haven't had time
to review any of it.
Why don't you respin and I'll try to allocate some review time myself?
Thanks.
^ permalink raw reply
* [PATCH] fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c
From: Valdis Kletnieks @ 2014-12-09 21:15 UTC (permalink / raw)
To: Eric Dumazet, John Fastabend, David S. Miller; +Cc: linux-kernel, netdev
commit 46e5da40ae (net: qdisc: use rcu prefix and silence
sparse warnings) triggers a spurious warning:
net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage!
The code should be using the _bh variant of rcu_dereference.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
net/sched/sch_fq_codel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
index b9ca32ebc1de..1e52decb7b59 100644
--- a/net/sched/sch_fq_codel.c
+++ b/net/sched/sch_fq_codel.c
@@ -94,7 +94,7 @@ static unsigned int fq_codel_classify(struct sk_buff *skb, struct Qdisc *sch,
TC_H_MIN(skb->priority) <= q->flows_cnt)
return TC_H_MIN(skb->priority);
- filter = rcu_dereference(q->filter_list);
+ filter = rcu_dereference_bh(q->filter_list);
if (!filter)
return fq_codel_hash(q, skb) + 1;
--
2.2.0
^ permalink raw reply related
* Re: [PATCH 5/20] isdn: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: isdn, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-6-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:47 +0100
> Replace a misspelled function name by %s and then __func__.
>
> In the first case, the print is just dropped, because kmalloc itself does
> enough error reporting.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 4/20] dmfe: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: grundler, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-5-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:46 +0100
> The function name contains cleanup, not clean.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 10/20] uli526x: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: grundler, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-11-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:52 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 14/20] chelsio: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux, joe, linux-kernel
In-Reply-To: <1417980062-25151-15-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:56 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 12/20] hp100: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: perex, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-13-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:54 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 14/20] chelsio: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:13 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux, joe, linux-kernel
In-Reply-To: <1417980062-25151-15-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:56 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 12/20] hp100: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:13 UTC (permalink / raw)
To: Julia.Lawall; +Cc: perex, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-13-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:54 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] enic: add support for set/get rss hash key
From: David Miller @ 2014-12-09 21:12 UTC (permalink / raw)
To: _govind; +Cc: netdev, ssujith, benve
In-Reply-To: <1417972273-22661-1-git-send-email-_govind@gmx.com>
From: Govindarajulu Varadarajan <_govind@gmx.com>
Date: Sun, 7 Dec 2014 22:41:13 +0530
> This patch adds support for setting/getting rss hash key using ethtool.
>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next 4/4] macvlan: play well with ipvlan device
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417910026-13371-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:46 -0800
> If device is already used as an ipvlan port then refuse to
> use it as a macvlan port at early stage of port creation.
>
> thost1:~# ip link add link eth0 ipvl0 type ipvlan
> thost1:~# echo $?
> 0
> thost1:~# ip link add link eth0 mvl0 type macvlan
> RTNETLINK answers: Device or resource busy
> thost1:~# echo $?
> 2
> thost1:~#
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 3/4] ipvlan: move the device check function into netdevice.h
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417910013-13274-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:33 -0800
> Move the port check [ipvlan_dev_master()] and device check
> [ipvlan_dev_slave()] functions to netdevice.h and rename them
> netif_is_ipvlan_port() and netif_is_ipvlan() resp. to be
> consistent with macvlan api naming.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/4] ipvlan: play well with macvlan device
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417909999-13234-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:19 -0800
> If a device is already a macvlan port then refuse to use it as
> an ipvlan port in the early stage of port creation.
>
> thost1:~# ip link add link eth0 mvl0 type macvlan
> thost1:~# echo $?
> 0
> thost1:~# ip link add link eth0 ipvl0 type ipvlan
> RTNETLINK answers: Device or resource busy
> thost1:~# echo $?
> 2
> thost1:~#
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/4] netdevice: Add a function to check macvlan port
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417909984-13133-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:04 -0800
> Similar to a check for macvlan device, netif_is_macvlan(), add
> another function to check if a device is used as macvlan port.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] dst: no need to take reference on DST_NOCACHE dsts
From: David Miller @ 2014-12-09 21:08 UTC (permalink / raw)
To: hannes; +Cc: netdev, edumazet, ja
In-Reply-To: <51b54bc66109594459e1a08c9022c5c48f20d910.1417889528.git.hannes@stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 6 Dec 2014 19:19:42 +0100
> Since commit f8864972126899 ("ipv4: fix dst race in sk_dst_get()")
> DST_NOCACHE dst_entries get freed by RCU. So there is no need to get a
> reference on them when we are in rcu protected sections.
>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] dummy: add support for ethtool get_drvinfo
From: David Miller @ 2014-12-09 21:07 UTC (permalink / raw)
To: fbl; +Cc: netdev
In-Reply-To: <1417824804-20634-1-git-send-email-fbl@redhat.com>
From: Flavio Leitner <fbl@redhat.com>
Date: Fri, 5 Dec 2014 22:13:24 -0200
> The command 'ethtool -i' is useful to find details
> about the interface like the device driver being used.
> This was missing for dummy driver.
>
> Signed-off-by: Flavio Leitner <fbl@redhat.com>
Applied, thank you.
Consider adding a MODULE_VERSION instance since you've added an
explicit version.
Thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox