* Re: [PATCH net-next v2] tcp: avoid reducing cwnd when ACK+DSACK is received
From: Neal Cardwell @ 2015-01-09 20:36 UTC (permalink / raw)
To: Yuchung Cheng
Cc: Eric Dumazet, Sébastien Barré, David Miller, Netdev,
Gregory Detal, Nandita Dukkipati
In-Reply-To: <CAK6E8=dhW=0hRYHjjgBh0KwKOQfzHhwY2egusQ8S4tsoJb0Nsg@mail.gmail.com>
On Fri, Jan 9, 2015 at 2:43 PM, Yuchung Cheng <ycheng@google.com> wrote:
> Sebastien: I suggest breaking down by ACK types for readability. e.g.,
I like this approach, as well. It breaks up the logic into smaller
pieces that are easier to comment and understand, without having
helper bool flags to read and mentally track. And this version passes
all our internal TLP tests, FWIW.
neal
^ permalink raw reply
* Re: [PATCH net-next RFC 1/5] net-timestamp: no-payload option
From: Andy Lutomirski @ 2015-01-09 20:55 UTC (permalink / raw)
To: Willem de Bruijn
Cc: Network Development, David S. Miller, Richard Cochran,
Eric Dumazet
In-Reply-To: <CA+FuTSdWWv65CNQYv1d9+WG1X54eGyP_+mbh3dMHw_HmH8wzYA@mail.gmail.com>
On Fri, Jan 9, 2015 at 12:33 PM, Willem de Bruijn <willemb@google.com> wrote:
> On Fri, Jan 9, 2015 at 3:02 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>> On Fri, Jan 9, 2015 at 11:47 AM, Willem de Bruijn <willemb@google.com> wrote:
>>> On Fri, Jan 9, 2015 at 2:43 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>>>> On Fri, Jan 9, 2015 at 9:31 AM, Willem de Bruijn <willemb@google.com> wrote:
>>>>> From: Willem de Bruijn <willemb@google.com>
>>>>>
>>>>> Add timestamping option SOF_TIMESTAMPING_OPT_TSONLY. For transmit
>>>>> timestamps, this loops timestamps on top of empty packets.
>>>>>
>>>>> Doing so reduces the pressure on SO_RCVBUF. Payload inspection and
>>>>> cmsg reception (aside from timestamps) are no longer possible. This
>>>>> works together with a follow on patch that allows administrators to
>>>>> only allow tx timestamping if it does not loop payload or metadata.
>>>>
>>>> If this loses IP_PKTINFO, that will be a bit unfortunate.
>>>>
>>>
>>> If it doesn't, then we might as well loop the entire payload. For applications
>>> that need pktinfo or other cmsg, do not select the option.
>>
>> Right, but it loses the ability to get the ifindex if the sysctl is
>> set to the conservative option, which I don't think is desirable.
>
> Understood. I just find the alternative, where the no-data policy is
> weakened by exceptions, even less desirable. That makes it
> harder to explain what the sysctl/option do and what the security
> implications are.
Agreed.
If there was no-payload but not no-cmsg, then it would be a nice
middle ground, but I guess that's bad for some reason involving
accounting?
--Andy
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply
* لسلام عليك ورحمة الله
From: BARR ALHARIRI @ 2015-01-09 20:36 UTC (permalink / raw)
لسلام عليكم
مرحبا اخي انا المدام براءه الحريري من سوريا والحين عندي مشروع بدي اعرضه
عليك فارجوا منك ترسل لي رساله بالايميل مشان اقدراحكي معك وخبرك بالتفاصيل
وبانتظار ردك
وفيك تتواصل معي علي هالايميل : barralhariri24@gmail.com
براءه الحريري
^ permalink raw reply
* Re: [PATCH net-next RFC 1/5] net-timestamp: no-payload option
From: Willem de Bruijn @ 2015-01-09 21:18 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Network Development, David S. Miller, Richard Cochran,
Eric Dumazet
In-Reply-To: <CALCETrW55OFy5RGKdEMyzMCTyGG-da6qtOUF4Bq1FZUAzpVS0g@mail.gmail.com>
On Fri, Jan 9, 2015 at 3:55 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Fri, Jan 9, 2015 at 12:33 PM, Willem de Bruijn <willemb@google.com> wrote:
>> On Fri, Jan 9, 2015 at 3:02 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>>> On Fri, Jan 9, 2015 at 11:47 AM, Willem de Bruijn <willemb@google.com> wrote:
>>>> On Fri, Jan 9, 2015 at 2:43 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>>>>> On Fri, Jan 9, 2015 at 9:31 AM, Willem de Bruijn <willemb@google.com> wrote:
>>>>>> From: Willem de Bruijn <willemb@google.com>
>>>>>>
>>>>>> Add timestamping option SOF_TIMESTAMPING_OPT_TSONLY. For transmit
>>>>>> timestamps, this loops timestamps on top of empty packets.
>>>>>>
>>>>>> Doing so reduces the pressure on SO_RCVBUF. Payload inspection and
>>>>>> cmsg reception (aside from timestamps) are no longer possible. This
>>>>>> works together with a follow on patch that allows administrators to
>>>>>> only allow tx timestamping if it does not loop payload or metadata.
>>>>>
>>>>> If this loses IP_PKTINFO, that will be a bit unfortunate.
>>>>>
>>>>
>>>> If it doesn't, then we might as well loop the entire payload. For applications
>>>> that need pktinfo or other cmsg, do not select the option.
>>>
>>> Right, but it loses the ability to get the ifindex if the sysctl is
>>> set to the conservative option, which I don't think is desirable.
>>
>> Understood. I just find the alternative, where the no-data policy is
>> weakened by exceptions, even less desirable. That makes it
>> harder to explain what the sysctl/option do and what the security
>> implications are.
>
> Agreed.
>
> If there was no-payload but not no-cmsg, then it would be a nice
> middle ground, but I guess that's bad for some reason involving
> accounting?
Enabling all cmsg opens up quite a few holes, including the tos
options that we previously discussed. Also, these are implemented
by reading the relevant bits from the payload at recvmsg time, so
at least we would have to queue the full payload (though not
necessarily return it).
> --Andy
>
> --
> Andy Lutomirski
> AMA Capital Management, LLC
^ permalink raw reply
* Re: route/max_size sysctl in ipv4
From: Ani Sinha @ 2015-01-09 21:23 UTC (permalink / raw)
To: Cong Wang; +Cc: Eric Dumazet, David Miller, netdev@vger.kernel.org
In-Reply-To: <CAHA+R7Pi=87b_umrKnd4bsZ+DPkRoTWhNyPwAND5pDzF_3EDaQ@mail.gmail.com>
On Fri, Jan 9, 2015 at 11:37 AM, Cong Wang <cwang@twopensource.com> wrote:
> On Fri, Jan 9, 2015 at 11:08 AM, Ani Sinha <ani@arista.com> wrote:
>>
>> Perhaps. What I am truly confused about is :
>>
>> - We are keeping a sysctl interface that does absolutely nothing in
>> the kernel and is completely useless in case some userland
>> scripts/tools are rendered broken from it's removal.
>
> I am all for getting rid of it, sane script should always check
> the sysctl existence first. I think we did remove some sysctl's
> from kernel before.
I'd be much happier if things break uniformly everywhere - within and
outside namespaces. Besides, keeping a useless sysctl around that does
nothing is confusing and error prone, to say the least.
If we do decide to keep the sysctl around, I beg that we at least
update the documentation to reflect the true fact. I have already sent
a patch for this.
^ permalink raw reply
* Re: [PATCH net-next RFC 1/5] net-timestamp: no-payload option
From: Andy Lutomirski @ 2015-01-09 22:00 UTC (permalink / raw)
To: Willem de Bruijn
Cc: Network Development, David S. Miller, Richard Cochran,
Eric Dumazet
In-Reply-To: <CA+FuTSe90dh+8QnABH=GGVrExqjur_OW8WaWS3b6J2BogbhCQQ@mail.gmail.com>
OK, makes sense.
On Fri, Jan 9, 2015 at 1:18 PM, Willem de Bruijn <willemb@google.com> wrote:
> On Fri, Jan 9, 2015 at 3:55 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>> On Fri, Jan 9, 2015 at 12:33 PM, Willem de Bruijn <willemb@google.com> wrote:
>>> On Fri, Jan 9, 2015 at 3:02 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>>>> On Fri, Jan 9, 2015 at 11:47 AM, Willem de Bruijn <willemb@google.com> wrote:
>>>>> On Fri, Jan 9, 2015 at 2:43 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>>>>>> On Fri, Jan 9, 2015 at 9:31 AM, Willem de Bruijn <willemb@google.com> wrote:
>>>>>>> From: Willem de Bruijn <willemb@google.com>
>>>>>>>
>>>>>>> Add timestamping option SOF_TIMESTAMPING_OPT_TSONLY. For transmit
>>>>>>> timestamps, this loops timestamps on top of empty packets.
>>>>>>>
>>>>>>> Doing so reduces the pressure on SO_RCVBUF. Payload inspection and
>>>>>>> cmsg reception (aside from timestamps) are no longer possible. This
>>>>>>> works together with a follow on patch that allows administrators to
>>>>>>> only allow tx timestamping if it does not loop payload or metadata.
>>>>>>
>>>>>> If this loses IP_PKTINFO, that will be a bit unfortunate.
>>>>>>
>>>>>
>>>>> If it doesn't, then we might as well loop the entire payload. For applications
>>>>> that need pktinfo or other cmsg, do not select the option.
>>>>
>>>> Right, but it loses the ability to get the ifindex if the sysctl is
>>>> set to the conservative option, which I don't think is desirable.
>>>
>>> Understood. I just find the alternative, where the no-data policy is
>>> weakened by exceptions, even less desirable. That makes it
>>> harder to explain what the sysctl/option do and what the security
>>> implications are.
>>
>> Agreed.
>>
>> If there was no-payload but not no-cmsg, then it would be a nice
>> middle ground, but I guess that's bad for some reason involving
>> accounting?
>
> Enabling all cmsg opens up quite a few holes, including the tos
> options that we previously discussed. Also, these are implemented
> by reading the relevant bits from the payload at recvmsg time, so
> at least we would have to queue the full payload (though not
> necessarily return it).
>
>> --Andy
>>
>> --
>> Andy Lutomirski
>> AMA Capital Management, LLC
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply
* Re: [PATCH 2/6] vxlan: Group Policy extension
From: Thomas Graf @ 2015-01-09 22:10 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: David S. Miller, Jesse Gross, Stephen Hemminger, Pravin Shelar,
Tom Herbert, netdev@vger.kernel.org, dev@openvswitch.org
In-Reply-To: <CAADnVQKUNc4pu7W6Riies3tVeh848ihHidb3iM2UnbEmea-Y-Q@mail.gmail.com>
On 01/09/15 at 09:37am, Alexei Starovoitov wrote:
> On Thu, Jan 8, 2015 at 2:47 PM, Thomas Graf <tgraf@suug.ch> wrote:
> > +
> > +struct vxlan_gbp {
> > +} __packed;
>
> empty struct ? seems unused.
> looks good to me otherwise.
Poor leftover, must feel all lonely there. Thanks for the reviews.
Will wait a little bit longer for more feedback and send out v3.
^ permalink raw reply
* Re: [PATCH net v3] gen_stats.c: Duplicate xstats buffer for later use
From: Cong Wang @ 2015-01-09 22:35 UTC (permalink / raw)
To: Ignacy Gawędzki, netdev
In-Reply-To: <20150108133037.GA10389@zenon.in.qult.net>
On Thu, Jan 8, 2015 at 5:30 AM, Ignacy Gawędzki
<ignacy.gawedzki@green-communications.fr> wrote:
> The gnet_stats_copy_app() function gets called, more often than not, with its
> second argument a pointer to an automatic variable in the caller's stack.
> Therefore, to avoid copying garbage afterwards when calling
> gnet_stats_finish_copy(), this data is better copied to a dynamically allocated
> memory that gets freed after use.
Good catch!
>
> Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
> ---
> net/core/gen_stats.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c
> index 0c08062..c9f1fa8 100644
> --- a/net/core/gen_stats.c
> +++ b/net/core/gen_stats.c
> @@ -32,6 +32,9 @@ gnet_stats_copy(struct gnet_dump *d, int type, void *buf, int size)
> return 0;
>
> nla_put_failure:
> + kfree(d->xstats);
> + d->xstats = NULL;
> + d->xstats_len = 0;
> spin_unlock_bh(d->lock);
> return -1;
> }
Although it is not your fault, the API sucks, gnet_stats_copy()
should not need to care about the error path of its caller.
I will cook a patch for it.
> @@ -305,7 +308,10 @@ int
> gnet_stats_copy_app(struct gnet_dump *d, void *st, int len)
> {
> if (d->compat_xstats) {
> - d->xstats = st;
> + kfree(d->xstats);
> + d->xstats = kmemdup(st, len, GFP_ATOMIC);
> + if (!d->xstats)
> + goto kmalloc_failure;
Do we really need to call kfree() before kmemdup()?
I don't think gnet_stats_copy_app() is supposed to be called
twice before gnet_stats_copy_finish()?
Thanks.
^ permalink raw reply
* Re: [patch -next] net: eth: xgene: devm_ioremap() returns NULL on error
From: Iyappan Subramanian @ 2015-01-09 22:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Feng Kan, Keyur Chudgar, Grant Likely, Rob Herring, netdev,
kernel-janitors
In-Reply-To: <20150108105211.GB10597@mwanda>
On Thu, Jan 8, 2015 at 2:52 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> devm_ioremap() returns NULL on failure, it doesn't return an ERR_PTR.
>
> Fixes: de7b5b3d790a ('net: eth: xgene: change APM X-Gene SoC platform ethernet to support ACPI')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 1e56bf3..02add38 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -804,9 +804,9 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata)
> return -ENODEV;
> }
> pdata->base_addr = devm_ioremap(dev, res->start, resource_size(res));
> - if (IS_ERR(pdata->base_addr)) {
> + if (!pdata->base_addr) {
> dev_err(dev, "Unable to retrieve ENET Port CSR region\n");
> - return PTR_ERR(pdata->base_addr);
> + return -ENOMEM;
> }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, RES_RING_CSR);
> @@ -816,9 +816,9 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata)
> }
> pdata->ring_csr_addr = devm_ioremap(dev, res->start,
> resource_size(res));
> - if (IS_ERR(pdata->ring_csr_addr)) {
> + if (!pdata->ring_csr_addr) {
> dev_err(dev, "Unable to retrieve ENET Ring CSR region\n");
> - return PTR_ERR(pdata->ring_csr_addr);
> + return -ENOMEM;
> }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, RES_RING_CMD);
> @@ -828,9 +828,9 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata)
> }
> pdata->ring_cmd_addr = devm_ioremap(dev, res->start,
> resource_size(res));
> - if (IS_ERR(pdata->ring_cmd_addr)) {
> + if (!pdata->ring_cmd_addr) {
> dev_err(dev, "Unable to retrieve ENET Ring command region\n");
> - return PTR_ERR(pdata->ring_cmd_addr);
> + return -ENOMEM;
> }
>
> ret = platform_get_irq(pdev, 0);
Acked-by: Iyappan Subramanian <isubramanian@apm.com>
^ permalink raw reply
* Re: [PATCH RFC net-next] ip_tunnel: create percpu gro_cell
From: Eric Dumazet @ 2015-01-09 22:57 UTC (permalink / raw)
To: Martin KaFai Lau; +Cc: netdev, kernel-team
In-Reply-To: <1420828933-844290-1-git-send-email-kafai@fb.com>
On Fri, 2015-01-09 at 10:42 -0800, Martin KaFai Lau wrote:
> In the ipip tunnel, the skb->queue_mapping is lost in ipip_rcv().
> All skb will be queued to the same cell->napi_skbs. The
> gro_cell_poll is pinned to one core under load. In production traffic,
> we also see severe rx_dropped in the tunl iface and it is probably due to
> this limit: skb_queue_len(&cell->napi_skbs) > netdev_max_backlog
>
> This patch is trying to alloc_percpu(struct gro_cell) and schedule
> gro_cell_poll to process it in the same core.
I wrote a similar patch here at Google, but I removed the
____cacheline_aligned_in_smp attribute on struct gro_cell
It was needed because of kcalloc(), but with alloc_percpu(), no gain
adding a padding.
^ permalink raw reply
* Re: [PATCH net v3] gen_stats.c: Duplicate xstats buffer for later use
From: Ignacy Gawędzki @ 2015-01-09 23:01 UTC (permalink / raw)
To: Cong Wang; +Cc: netdev
In-Reply-To: <CAHA+R7OpbP_+iwh6X=sh4SsXJ4VreBjze7dPrV6Xh8RHEe+cGw@mail.gmail.com>
On Fri, Jan 09, 2015 at 02:35:41PM -0800, thus spake Cong Wang:
> On Thu, Jan 8, 2015 at 5:30 AM, Ignacy Gawędzki
> > diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c
> > index 0c08062..c9f1fa8 100644
> > --- a/net/core/gen_stats.c
> > +++ b/net/core/gen_stats.c
> > @@ -32,6 +32,9 @@ gnet_stats_copy(struct gnet_dump *d, int type, void *buf, int size)
> > return 0;
> >
> > nla_put_failure:
> > + kfree(d->xstats);
> > + d->xstats = NULL;
> > + d->xstats_len = 0;
> > spin_unlock_bh(d->lock);
> > return -1;
> > }
>
> Although it is not your fault, the API sucks, gnet_stats_copy()
> should not need to care about the error path of its caller.
> I will cook a patch for it.
That would be great, as I'm certainly not that fluent in kernel code.
> > @@ -305,7 +308,10 @@ int
> > gnet_stats_copy_app(struct gnet_dump *d, void *st, int len)
> > {
> > if (d->compat_xstats) {
> > - d->xstats = st;
> > + kfree(d->xstats);
> > + d->xstats = kmemdup(st, len, GFP_ATOMIC);
> > + if (!d->xstats)
> > + goto kmalloc_failure;
>
> Do we really need to call kfree() before kmemdup()?
> I don't think gnet_stats_copy_app() is supposed to be called
> twice before gnet_stats_copy_finish()?
It's not, but I figured it's safer that way and probably not that expensive
given the frequency with which calls to these functions are performed in
practice.
--
Ignacy Gawędzki
R&D Engineer
Green Communications
^ permalink raw reply
* [PATCH] usb/kaweth: use GFP_ATOMIC under spin_lock in usb_start_wait_urb()
From: Alexey Khoroshilov @ 2015-01-09 23:16 UTC (permalink / raw)
To: David S. Miller
Cc: Alexey Khoroshilov, linux-usb, netdev, linux-kernel, ldv-project
Commit e4c7f259c5be ("USB: kaweth.c: use GFP_ATOMIC under spin_lock")
makes sure that kaweth_internal_control_msg() allocates memory with GFP_ATOMIC,
but kaweth_internal_control_msg() also calls usb_start_wait_urb()
that still allocates memory with GFP_NOIO.
The patch fixes usb_start_wait_urb() as well.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/net/usb/kaweth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c
index dcb6d33141e0..1e9cdca37014 100644
--- a/drivers/net/usb/kaweth.c
+++ b/drivers/net/usb/kaweth.c
@@ -1276,7 +1276,7 @@ static int usb_start_wait_urb(struct urb *urb, int timeout, int* actual_length)
awd.done = 0;
urb->context = &awd;
- status = usb_submit_urb(urb, GFP_NOIO);
+ status = usb_submit_urb(urb, GFP_ATOMIC);
if (status) {
// something went wrong
usb_free_urb(urb);
--
1.9.1
^ permalink raw reply related
* Re: [PATCH RFC net-next] ip_tunnel: create percpu gro_cell
From: Martin Lau @ 2015-01-09 23:17 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, kernel-team
In-Reply-To: <1420844264.5947.81.camel@edumazet-glaptop2.roam.corp.google.com>
On Fri, Jan 09, 2015 at 02:57:44PM -0800, Eric Dumazet wrote:
> On Fri, 2015-01-09 at 10:42 -0800, Martin KaFai Lau wrote:
> > In the ipip tunnel, the skb->queue_mapping is lost in ipip_rcv().
> > All skb will be queued to the same cell->napi_skbs. The
> > gro_cell_poll is pinned to one core under load. In production traffic,
> > we also see severe rx_dropped in the tunl iface and it is probably due to
> > this limit: skb_queue_len(&cell->napi_skbs) > netdev_max_backlog
> >
> > This patch is trying to alloc_percpu(struct gro_cell) and schedule
> > gro_cell_poll to process it in the same core.
>
>
> I wrote a similar patch here at Google, but I removed the
> ____cacheline_aligned_in_smp attribute on struct gro_cell
>
> It was needed because of kcalloc(), but with alloc_percpu(), no gain
> adding a padding.
Is the spin_lock() still needed?
Thanks,
--Martin
^ permalink raw reply
* [PATCH net-next] Driver: Vmxnet3: Reinitialize vmxnet3 backend on wakeup from hibernate
From: Shrikrishna Khare @ 2015-01-09 23:19 UTC (permalink / raw)
To: sbhatewara, pv-drivers, netdev, linux-kernel
Cc: Shrikrishna Khare, Srividya Murali
Failing to reinitialize on wakeup results in loss of network connectivity for
vmxnet3 interface.
Signed-off-by: Srividya Murali <smurali@vmware.com>
Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
Reviewed-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 44 +++++++++++++++++++++----------------
drivers/net/vmxnet3/vmxnet3_int.h | 4 +-
2 files changed, 27 insertions(+), 21 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 7af1f5c..3143981 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -3290,27 +3290,15 @@ skip_arp:
static int
vmxnet3_resume(struct device *device)
{
- int err, i = 0;
+ int err;
unsigned long flags;
struct pci_dev *pdev = to_pci_dev(device);
struct net_device *netdev = pci_get_drvdata(pdev);
struct vmxnet3_adapter *adapter = netdev_priv(netdev);
- struct Vmxnet3_PMConf *pmConf;
if (!netif_running(netdev))
return 0;
- /* Destroy wake-up filters. */
- pmConf = adapter->pm_conf;
- memset(pmConf, 0, sizeof(*pmConf));
-
- adapter->shared->devRead.pmConfDesc.confVer = cpu_to_le32(1);
- adapter->shared->devRead.pmConfDesc.confLen = cpu_to_le32(sizeof(
- *pmConf));
- adapter->shared->devRead.pmConfDesc.confPA =
- cpu_to_le64(adapter->pm_conf_pa);
-
- netif_device_attach(netdev);
pci_set_power_state(pdev, PCI_D0);
pci_restore_state(pdev);
err = pci_enable_device_mem(pdev);
@@ -3319,15 +3307,31 @@ vmxnet3_resume(struct device *device)
pci_enable_wake(pdev, PCI_D0, 0);
+ vmxnet3_alloc_intr_resources(adapter);
+
+ /* During hibernate and suspend, device has to be reinitialized as the
+ * device state need not be preserved.
+ */
+
+ /* Need not check adapter state as other reset tasks cannot run during
+ * device resume.
+ */
spin_lock_irqsave(&adapter->cmd_lock, flags);
VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
- VMXNET3_CMD_UPDATE_PMCFG);
+ VMXNET3_CMD_QUIESCE_DEV);
spin_unlock_irqrestore(&adapter->cmd_lock, flags);
- vmxnet3_alloc_intr_resources(adapter);
- vmxnet3_request_irqs(adapter);
- for (i = 0; i < adapter->num_rx_queues; i++)
- napi_enable(&adapter->rx_queue[i].napi);
- vmxnet3_enable_all_intrs(adapter);
+ vmxnet3_tq_cleanup_all(adapter);
+ vmxnet3_rq_cleanup_all(adapter);
+
+ vmxnet3_reset_dev(adapter);
+ err = vmxnet3_activate_dev(adapter);
+ if (err != 0) {
+ netdev_err(netdev,
+ "failed to re-activate on resume, error: %d", err);
+ vmxnet3_force_close(adapter);
+ return err;
+ }
+ netif_device_attach(netdev);
return 0;
}
@@ -3335,6 +3339,8 @@ vmxnet3_resume(struct device *device)
static const struct dev_pm_ops vmxnet3_pm_ops = {
.suspend = vmxnet3_suspend,
.resume = vmxnet3_resume,
+ .freeze = vmxnet3_suspend,
+ .restore = vmxnet3_resume,
};
#endif
diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
index 048f020..6297d9f 100644
--- a/drivers/net/vmxnet3/vmxnet3_int.h
+++ b/drivers/net/vmxnet3/vmxnet3_int.h
@@ -69,10 +69,10 @@
/*
* Version numbers
*/
-#define VMXNET3_DRIVER_VERSION_STRING "1.3.1.0-k"
+#define VMXNET3_DRIVER_VERSION_STRING "1.3.2.0-k"
/* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */
-#define VMXNET3_DRIVER_VERSION_NUM 0x01030100
+#define VMXNET3_DRIVER_VERSION_NUM 0x01030200
#if defined(CONFIG_PCI_MSI)
/* RSS only makes sense if MSI-X is supported. */
--
1.7.4.1
^ permalink raw reply related
* Re: [PATCH net-next] Driver: Vmxnet3: Reinitialize vmxnet3 backend on wakeup from hibernate
From: Shrikrishna Khare @ 2015-01-09 23:20 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: sbhatewara, pv-drivers, netdev, linux-kernel, Srividya Murali
In-Reply-To: <54ADABDE.6030008@cogentembedded.com>
Hi Sergei,
Thanks for the review. I have addressed all the review comments and
resubmitted the patch.
Thanks,
Shri
On Wed, 7 Jan 2015, Sergei Shtylyov wrote:
> Hello.
>
> On 01/07/2015 08:56 PM, Shrikrishna Khare wrote:
>
> > Failing to reinitialize on wakeup results in loss of network connectivity
> > for
> > vmxnet3 interface.
>
> > Signed-off-by: Srividya Murali <smurali@vmware.com>
> > Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
> > Reviewed-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
> > ---
> > drivers/net/vmxnet3/vmxnet3_drv.c | 50
> > +++++++++++++++++++++---------------
> > drivers/net/vmxnet3/vmxnet3_int.h | 4 +-
> > 2 files changed, 31 insertions(+), 23 deletions(-)
>
> > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> > b/drivers/net/vmxnet3/vmxnet3_drv.c
> > index 7af1f5c..124cb9f 100644
> > --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> > @@ -3290,51 +3290,59 @@ skip_arp:
> > static int
> > vmxnet3_resume(struct device *device)
> > {
> > - int err, i = 0;
> > + int err;
> > unsigned long flags;
> > struct pci_dev *pdev = to_pci_dev(device);
> > struct net_device *netdev = pci_get_drvdata(pdev);
> > struct vmxnet3_adapter *adapter = netdev_priv(netdev);
> > - struct Vmxnet3_PMConf *pmConf;
> >
> > if (!netif_running(netdev))
> > return 0;
> >
> > - /* Destroy wake-up filters. */
> > - pmConf = adapter->pm_conf;
> > - memset(pmConf, 0, sizeof(*pmConf));
> > -
> > - adapter->shared->devRead.pmConfDesc.confVer = cpu_to_le32(1);
> > - adapter->shared->devRead.pmConfDesc.confLen = cpu_to_le32(sizeof(
> > - *pmConf));
> > - adapter->shared->devRead.pmConfDesc.confPA =
> > - cpu_to_le64(adapter->pm_conf_pa);
> > -
> > - netif_device_attach(netdev);
> > pci_set_power_state(pdev, PCI_D0);
> > pci_restore_state(pdev);
> > err = pci_enable_device_mem(pdev);
> > if (err != 0)
> > - return err;
> > + goto err;
>
> Why?
>
> >
> > pci_enable_wake(pdev, PCI_D0, 0);
> >
> > + vmxnet3_alloc_intr_resources(adapter);
> > +
> > + /* During hibernate and suspend, device has to be reinitialized as the
> > + * device state need not be preserved.
> > + */
> > +
> > + /* Need not check adapter state as other reset tasks cannot run during
> > + * device resume.
> > + */
> > spin_lock_irqsave(&adapter->cmd_lock, flags);
> > VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
> > - VMXNET3_CMD_UPDATE_PMCFG);
> > + VMXNET3_CMD_QUIESCE_DEV);
> > spin_unlock_irqrestore(&adapter->cmd_lock, flags);
> > - vmxnet3_alloc_intr_resources(adapter);
> > - vmxnet3_request_irqs(adapter);
> > - for (i = 0; i < adapter->num_rx_queues; i++)
> > - napi_enable(&adapter->rx_queue[i].napi);
> > - vmxnet3_enable_all_intrs(adapter);
> > + vmxnet3_tq_cleanup_all(adapter);
> > + vmxnet3_rq_cleanup_all(adapter);
> >
> > - return 0;
> > + vmxnet3_reset_dev(adapter);
> > + err = vmxnet3_activate_dev(adapter);
> > + if (err) {
> > + netdev_err(adapter->netdev,
>
> Not just 'netdev'?
>
> > + "%s: failed to re-activate on resume, error: %d",
> > + netdev->name, err);
>
> Should have been aligned with the line right above. And isn't netdev->name
> printed by netdev_err() already?
>
> > + vmxnet3_force_close(adapter);
> > + goto err;
>
> Why not just *return*?
>
> > + }
> > + netif_device_attach(netdev);
> > +
> > +err:
> > + return err;
> > }
> [...]
>
> WBR, Sergei
>
>
^ permalink raw reply
* [PATCH RFC ethtool] QSFP Diagnostics Information Support
From: vidya @ 2015-01-09 23:41 UTC (permalink / raw)
To: netdev, bwh; +Cc: shm, vidya, roopa, bkenward, dave.lee
From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
This patch provides support for diagnostics information
for QSFP Plus modules which based on SFF 8436 specification
This implementation is loosely based on current SFP DOM parser
and SFF-8436 specs (ftp://ftp.seagate.com/pub/sff/SFF-8436.PDF)
by SFF Committee.
Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
---
Makefile.am | 2 +-
ethtool-copy.h | 2 +
ethtool.c | 3 +
internal.h | 3 +
qsfp.c | 827 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
qsfp.h | 541 ++++++++++++++++++++++++++++++++++++
6 files changed, 1377 insertions(+), 1 deletion(-)
create mode 100644 qsfp.c
create mode 100644 qsfp.h
diff --git a/Makefile.am b/Makefile.am
index 4698d16..b6162db 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -13,7 +13,7 @@ ethtool_SOURCES += \
fec_8xx.c ibm_emac.c ixgb.c ixgbe.c natsemi.c \
pcnet32.c realtek.c tg3.c marvell.c vioc.c \
smsc911x.c at76c50x-usb.c sfc.c stmmac.c \
- sfpid.c sfpdiag.c ixgbevf.c tse.c
+ sfpid.c sfpdiag.c ixgbevf.c tse.c qsfp.c
endif
TESTS = test-cmdline test-features
diff --git a/ethtool-copy.h b/ethtool-copy.h
index 61b78fc..8c4fb8b 100644
--- a/ethtool-copy.h
+++ b/ethtool-copy.h
@@ -1314,6 +1314,8 @@ enum ethtool_sfeatures_retval_bits {
#define ETH_MODULE_SFF_8079_LEN 256
#define ETH_MODULE_SFF_8472 0x2
#define ETH_MODULE_SFF_8472_LEN 512
+#define ETH_MODULE_SFF_8436 0x3
+#define ETH_MODULE_SFF_8436_LEN 640
/* Reset flags */
/* The reset() operation must clear the flags for the components which
diff --git a/ethtool.c b/ethtool.c
index bf583f3..8cf1968 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -3918,6 +3918,9 @@ static int do_getmodule(struct cmd_context *ctx)
sff8079_show_all(eeprom->data);
sff8472_show_all(eeprom->data);
break;
+ case ETH_MODULE_SFF_8436:
+ sff8436_show_all(eeprom->data);
+ break;
#endif
default:
geeprom_dump_hex = 1;
diff --git a/internal.h b/internal.h
index a9dfae0..03543a9 100644
--- a/internal.h
+++ b/internal.h
@@ -262,4 +262,7 @@ void sff8079_show_all(const __u8 *id);
/* Optics diagnostics */
void sff8472_show_all(const __u8 *id);
+/* QSFP Optics diagnostics */
+void sff8436_show_all(const __u8 *id);
+
#endif /* ETHTOOL_INTERNAL_H__ */
diff --git a/qsfp.c b/qsfp.c
new file mode 100644
index 0000000..03e80d9
--- /dev/null
+++ b/qsfp.c
@@ -0,0 +1,827 @@
+/*
+ * qsfp.c: Implements SFF-8436 based QSFP+ Diagnostics Memory map.
+ *
+ * Copyright (C) 2014 Cumulus networks Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Freeoftware Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * Vidya Ravipati <vidya@cumulusnetworks.com>
+ * This implementation is loosely based on current SFP parser
+ * and SFF-8436 specs (ftp://ftp.seagate.com/pub/sff/SFF-8436.PDF)
+ * by SFF Committee.
+ */
+
+/*
+ * Description:
+ * a) The register/memory layout is up to 5 128 byte pages defined by
+ * a "pages valid" register and switched via a "page select"
+ * register. Memory of 256 bytes can be memory mapped at a time
+ * according to SFF 8436.
+ * b) SFF 8436 based 640 bytes memory layout is presented for parser
+ *
+ * SFF 8436 based QSFP Memory Map
+ *
+ * 2-Wire Serial Address: 1010000x
+ *
+ * Lower Page 00h (128 bytes)
+ * ======================
+ * | |
+ * |Page Select Byte(127)|
+ * ======================
+ * |
+ * V
+ * ----------------------------------------
+ * | | | |
+ * V V V V
+ * ---------- ---------- --------- ------------
+ * | Upper | | Upper | | Upper | | Upper |
+ * | Page 00h | | Page 01h | | Page 02h | | Page 03h |
+ * | | |(Optional)| |(Optional)| | (Optional) |
+ * | | | | | | | |
+ * | | | | | | | |
+ * | ID | | AST | | User | | For |
+ * | Fields | | Table | | EEPROM | | Cable |
+ * | | | | | Data | | Assemblies |
+ * | | | | | | | |
+ * | | | | | | | |
+ * ----------- ----------- ---------- --------------
+ *
+ *
+ **/
+#include <stdio.h>
+#include <math.h>
+#include "internal.h"
+#include "qsfp.h"
+
+#define MAX_DESC_SIZE 42
+
+/* Channel Monitoring Fields */
+struct sff8436_channel_diags {
+
+ __u16 bias_cur; /* Measured bias current in 2uA units */
+ __u16 rx_power; /* Measured RX Power */
+
+};
+
+/* Module Monitoring Fields */
+struct sff8436_diags {
+
+#define MAX_CHANNEL_NUM 4
+#define LWARN 0
+#define HWARN 1
+#define LALRM 2
+#define HALRM 3
+
+ __u8 supports_dom; /* Supports DOM */
+ __u8 supports_alarms; /* Supports alarm/warning thold */
+ __u8 rx_power_type; /* 0 = OMA, 1 = Average power */
+ __u16 sfp_voltage; /* SFP voltage in 0.1mV units */
+ __s16 sfp_temp; /* SFP Temp in 16-bit signed 1/256 Celcius */
+ /* [4] tables are low/high warn, low/high alarm */
+ /* SFP voltage in 0.1mV units */
+ __u16 thresh_sfp_voltage[4];
+ /* SFP Temp in 16-bit signed 1/256 Celcius */
+ __s16 thresh_sfp_temp[4];
+ /* Measured bias current in 2uA units */
+ __u16 thresh_bias_cur[4];
+ /* Measured RX Power */
+ __u16 thresh_rx_power[4];
+ struct sff8436_channel_diags scd[MAX_CHANNEL_NUM];
+};
+
+static struct sff8436_aw_flags {
+ const char *str; /* Human-readable string, null at the end */
+ int offset; /* A2-relative adress offset */
+ __u8 value; /* Alarm is on if (offset & value) != 0. */
+} sff8436_aw_flags[] = {
+ { "Laser bias current high alarm (Chan 1)",
+ SFF8436_TX_BIAS_12_AW_OFFSET, (SFF8436_TX_BIAS_1_HALARM) },
+ { "Laser bias current low alarm (Chan 1)",
+ SFF8436_TX_BIAS_12_AW_OFFSET, (SFF8436_TX_BIAS_1_LALARM) },
+ { "Laser bias current high warning (Chan 1)",
+ SFF8436_TX_BIAS_12_AW_OFFSET, (SFF8436_TX_BIAS_1_HWARN) },
+ { "Laser bias current low warning (Chan 1)",
+ SFF8436_TX_BIAS_12_AW_OFFSET, (SFF8436_TX_BIAS_1_LWARN) },
+
+ { "Laser bias current high alarm (Chan 2)",
+ SFF8436_TX_BIAS_12_AW_OFFSET, (SFF8436_TX_BIAS_2_HALARM) },
+ { "Laser bias current low alarm (Chan 2)",
+ SFF8436_TX_BIAS_12_AW_OFFSET, (SFF8436_TX_BIAS_2_LALARM) },
+ { "Laser bias current high warning (Chan 2)",
+ SFF8436_TX_BIAS_12_AW_OFFSET, (SFF8436_TX_BIAS_2_HWARN) },
+ { "Laser bias current low warning (Chan 2)",
+ SFF8436_TX_BIAS_12_AW_OFFSET, (SFF8436_TX_BIAS_2_LWARN) },
+
+ { "Laser bias current high alarm (Chan 3)",
+ SFF8436_TX_BIAS_34_AW_OFFSET, (SFF8436_TX_BIAS_3_HALARM) },
+ { "Laser bias current low alarm (Chan 3)",
+ SFF8436_TX_BIAS_34_AW_OFFSET, (SFF8436_TX_BIAS_3_LALARM) },
+ { "Laser bias current high warning (Chan 3)",
+ SFF8436_TX_BIAS_34_AW_OFFSET, (SFF8436_TX_BIAS_3_HWARN) },
+ { "Laser bias current low warning (Chan 3)",
+ SFF8436_TX_BIAS_34_AW_OFFSET, (SFF8436_TX_BIAS_3_LWARN) },
+
+ { "Laser bias current high alarm (Chan 4)",
+ SFF8436_TX_BIAS_34_AW_OFFSET, (SFF8436_TX_BIAS_4_HALARM) },
+ { "Laser bias current low alarm (Chan 4)",
+ SFF8436_TX_BIAS_34_AW_OFFSET, (SFF8436_TX_BIAS_4_LALARM) },
+ { "Laser bias current high warning (Chan 4)",
+ SFF8436_TX_BIAS_34_AW_OFFSET, (SFF8436_TX_BIAS_4_HWARN) },
+ { "Laser bias current low warning (Chan 4)",
+ SFF8436_TX_BIAS_34_AW_OFFSET, (SFF8436_TX_BIAS_4_LWARN) },
+
+ { "Module temperature high alarm",
+ SFF8436_TEMP_AW_OFFSET, (SFF8436_TEMP_HALARM_STATUS) },
+ { "Module temperature low alarm",
+ SFF8436_TEMP_AW_OFFSET, (SFF8436_TEMP_LALARM_STATUS) },
+ { "Module temperature high warning",
+ SFF8436_TEMP_AW_OFFSET, (SFF8436_TEMP_HWARN_STATUS) },
+ { "Module temperature low warning",
+ SFF8436_TEMP_AW_OFFSET, (SFF8436_TEMP_LWARN_STATUS) },
+
+ { "Module voltage high alarm",
+ SFF8436_VCC_AW_OFFSET, (SFF8436_VCC_HALARM_STATUS) },
+ { "Module voltage low alarm",
+ SFF8436_VCC_AW_OFFSET, (SFF8436_VCC_LALARM_STATUS) },
+ { "Module voltage high warning",
+ SFF8436_VCC_AW_OFFSET, (SFF8436_VCC_HWARN_STATUS) },
+ { "Module voltage low warning",
+ SFF8436_VCC_AW_OFFSET, (SFF8436_VCC_LWARN_STATUS) },
+
+ { "Laser rx power high alarm (Channel 1)",
+ SFF8436_RX_PWR_12_AW_OFFSET, (SFF8436_RX_PWR_1_HALARM) },
+ { "Laser rx power low alarm (Channel 1)",
+ SFF8436_RX_PWR_12_AW_OFFSET, (SFF8436_RX_PWR_1_LALARM) },
+ { "Laser rx power high warning (Channel 1)",
+ SFF8436_RX_PWR_12_AW_OFFSET, (SFF8436_RX_PWR_1_HWARN) },
+ { "Laser rx power low warning (Channel 1)",
+ SFF8436_RX_PWR_12_AW_OFFSET, (SFF8436_RX_PWR_1_LWARN) },
+
+ { "Laser rx power high alarm (Channel 2)",
+ SFF8436_RX_PWR_12_AW_OFFSET, (SFF8436_RX_PWR_2_HALARM) },
+ { "Laser rx power low alarm (Channel 2)",
+ SFF8436_RX_PWR_12_AW_OFFSET, (SFF8436_RX_PWR_2_LALARM) },
+ { "Laser rx power high warning (Channel 2)",
+ SFF8436_RX_PWR_12_AW_OFFSET, (SFF8436_RX_PWR_2_HWARN) },
+ { "Laser rx power low warning (Channel 2)",
+ SFF8436_RX_PWR_12_AW_OFFSET, (SFF8436_RX_PWR_2_LWARN) },
+
+ { "Laser rx power high alarm (Channel 3)",
+ SFF8436_RX_PWR_34_AW_OFFSET, (SFF8436_RX_PWR_3_HALARM) },
+ { "Laser rx power low alarm (Channel 3)",
+ SFF8436_RX_PWR_34_AW_OFFSET, (SFF8436_RX_PWR_3_LALARM) },
+ { "Laser rx power high warning (Channel 3)",
+ SFF8436_RX_PWR_34_AW_OFFSET, (SFF8436_RX_PWR_3_HWARN) },
+ { "Laser rx power low warning (Channel 3)",
+ SFF8436_RX_PWR_34_AW_OFFSET, (SFF8436_RX_PWR_3_LWARN) },
+
+ { "Laser rx power high alarm (Channel 4)",
+ SFF8436_RX_PWR_34_AW_OFFSET, (SFF8436_RX_PWR_4_HALARM) },
+ { "Laser rx power low alarm (Channel 4)",
+ SFF8436_RX_PWR_34_AW_OFFSET, (SFF8436_RX_PWR_4_LALARM) },
+ { "Laser rx power high warning (Channel 4)",
+ SFF8436_RX_PWR_34_AW_OFFSET, (SFF8436_RX_PWR_4_HWARN) },
+ { "Laser rx power low warning (Channel 4)",
+ SFF8436_RX_PWR_34_AW_OFFSET, (SFF8436_RX_PWR_4_LWARN) },
+
+ { NULL, 0, 0 },
+};
+
+static void sff8436_show_identifier(const __u8 *id)
+{
+ printf("\t%-41s : 0x%02x", "Identifier", id[SFF8436_ID_OFFSET]);
+ switch (id[SFF8436_ID_OFFSET]) {
+ case SFF8436_ID_UNKNOWN:
+ printf(" (no module present, unknown, or unspecified)\n");
+ break;
+ case SFF8436_ID_GBIC:
+ printf(" (GBIC)\n");
+ break;
+ case SFF8436_ID_SOLDERED_MODULE:
+ printf(" (module soldered to motherboard)\n");
+ break;
+ case SFF8436_ID_SFP:
+ printf(" (SFP)\n");
+ break;
+ case SFF8436_ID_300_PIN_XBI:
+ printf(" (300 pin XBI)\n");
+ break;
+ case SFF8436_ID_XENPAK:
+ printf(" (XENPAK)\n");
+ break;
+ case SFF8436_ID_XFP:
+ printf(" (XFP)\n");
+ break;
+ case SFF8436_ID_XFF:
+ printf(" (XFF)\n");
+ break;
+ case SFF8436_ID_XFP_E:
+ printf(" (XFP-E)\n");
+ break;
+ case SFF8436_ID_XPAK:
+ printf(" (XPAK)\n");
+ break;
+ case SFF8436_ID_X2:
+ printf(" (X2)\n");
+ break;
+ case SFF8436_ID_DWDM_SFP:
+ printf(" (DWDM-SFP)\n");
+ break;
+ case SFF8436_ID_DWDM_QSFP:
+ printf(" (QSFP)\n");
+ break;
+ case SFF8436_ID_DWDM_QSFP_PLUS:
+ printf(" (QSFP+)\n");
+ break;
+ default:
+ printf(" (reserved or unknown)\n");
+ break;
+ }
+}
+
+static void sff8436_show_ext_identifier(const __u8 *id)
+{
+ printf("\t%-41s : 0x%02x", "Extended identifier",
+ id[SFF8436_EXT_ID_OFFSET]);
+
+ switch (id[SFF8436_EXT_ID_OFFSET] & SFF8436_EXT_ID_PWR_CLASS_MASK) {
+ case SFF8436_EXT_ID_PWR_CLASS_1:
+ printf(" (1.5W max. Power consumption,");
+ break;
+ case SFF8436_EXT_ID_PWR_CLASS_2:
+ printf(" (2.0W max. Power consumption,");
+ break;
+ case SFF8436_EXT_ID_PWR_CLASS_3:
+ printf(" (2.5W max. Power consumption,");
+ break;
+ case SFF8436_EXT_ID_PWR_CLASS_4:
+ printf(" (3.5W max. Power consumption,");
+ break;
+ }
+ if (id[SFF8436_EXT_ID_OFFSET] & SFF8436_EXT_ID_CDR_TX_MASK)
+ printf(" CDR present in TX,");
+ else
+ printf(" No CDR in TX,");
+
+ if (id[SFF8436_EXT_ID_OFFSET] & SFF8436_EXT_ID_CDR_RX_MASK)
+ printf(" CDR present in RX)\n");
+ else
+ printf(" No CDR in RX)\n");
+}
+
+static void sff8436_show_connector(const __u8 *id)
+{
+ printf("\t%-41s : 0x%02x", "Connector", id[SFF8436_CTOR_OFFSET]);
+ switch (id[SFF8436_CTOR_OFFSET]) {
+ case SFF8436_CTOR_UNKNOWN:
+ printf(" (unknown or unspecified)\n");
+ break;
+ case SFF8436_CTOR_SC:
+ printf(" (SC)\n");
+ break;
+ case SFF8436_CTOR_FC_STYLE_1:
+ printf(" (Fibre Channel Style 1 copper)\n");
+ break;
+ case SFF8436_CTOR_FC_STYLE_2:
+ printf(" (Fibre Channel Style 2 copper)\n");
+ break;
+ case SFF8436_CTOR_BNC_TNC:
+ printf(" (BNC/TNC)\n");
+ break;
+ case SFF8436_CTOR_FC_COAX:
+ printf(" (Fibre Channel coaxial headers)\n");
+ break;
+ case SFF8436_CTOR_FIBER_JACK:
+ printf(" (FibreJack)\n");
+ break;
+ case SFF8436_CTOR_LC:
+ printf(" (LC)\n");
+ break;
+ case SFF8436_CTOR_MT_RJ:
+ printf(" (MT-RJ)\n");
+ break;
+ case SFF8436_CTOR_MU:
+ printf(" (MU)\n");
+ break;
+ case SFF8436_CTOR_SG:
+ printf(" (SG)\n");
+ break;
+ case SFF8436_CTOR_OPT_PT:
+ printf(" (Optical pigtail)\n");
+ break;
+ case SFF8436_CTOR_MPO:
+ printf(" (MPO Parallel Optic)\n");
+ break;
+ case SFF8436_CTOR_HSDC_II:
+ printf(" (HSSDC II)\n");
+ break;
+ case SFF8436_CTOR_COPPER_PT:
+ printf(" (Copper pigtail)\n");
+ break;
+ case SFF8436_CTOR_RJ45:
+ printf(" (RJ45)\n");
+ break;
+ case SFF8436_CTOR_NO_SEPARABLE:
+ printf(" (No separable connector)\n");
+ break;
+ default:
+ printf(" (reserved or unknown)\n");
+ break;
+ }
+}
+
+static void sff8436_show_transceiver(const __u8 *id)
+{
+ static const char *pfx =
+ "\tTransceiver type :";
+
+ printf("\t%-41s : 0x%02x 0x%02x 0x%02x " \
+ "0x%02x 0x%02x 0x%02x 0x%02x 0x%02x\n",
+ "Transceiver codes",
+ id[SFF8436_ETHERNET_COMP_OFFSET],
+ id[SFF8436_SONET_COMP_OFFSET],
+ id[SFF8436_SAS_COMP_OFFSET],
+ id[SFF8436_GIGE_COMP_OFFSET],
+ id[SFF8436_FC_LEN_OFFSET],
+ id[SFF8436_FC_TECH_OFFSET],
+ id[SFF8436_FC_TRANS_MEDIA_OFFSET],
+ id[SFF8436_FC_SPEED_OFFSET]);
+
+ /* 10G/40G Ethernet Compliance Codes */
+ if (id[SFF8436_ETHERNET_COMP_OFFSET] & SFF8436_ETHERNET_RSRVD)
+ printf("%s (reserved or unknown)\n", pfx);
+ if (id[SFF8436_ETHERNET_COMP_OFFSET] & SFF8436_ETHERNET_10G_LRM)
+ printf("%s 10G Ethernet: 10G Base-LRM\n", pfx);
+ if (id[SFF8436_ETHERNET_COMP_OFFSET] & SFF8436_ETHERNET_10G_LR)
+ printf("%s 10G Ethernet: 10G Base-LR\n", pfx);
+ if (id[SFF8436_ETHERNET_COMP_OFFSET] & SFF8436_ETHERNET_10G_SR)
+ printf("%s 10G Ethernet: 10G Base-SR\n", pfx);
+ if (id[SFF8436_ETHERNET_COMP_OFFSET] & SFF8436_ETHERNET_40G_CR4)
+ printf("%s 40G Ethernet: 40G Base-CR4\n", pfx);
+ if (id[SFF8436_ETHERNET_COMP_OFFSET] & SFF8436_ETHERNET_40G_SR4)
+ printf("%s 40G Ethernet: 40G Base-SR4\n", pfx);
+ if (id[SFF8436_ETHERNET_COMP_OFFSET] & SFF8436_ETHERNET_40G_LR4)
+ printf("%s 40G Ethernet: 40G Base-LR4\n", pfx);
+ if (id[SFF8436_ETHERNET_COMP_OFFSET] & SFF8436_ETHERNET_40G_ACTIVE)
+ printf("%s 40G Ethernet: 40G Active Cable (XLPPI)\n", pfx);
+
+ /* SONET Compliance Codes */
+ if (id[SFF8436_SONET_COMP_OFFSET] & (SFF8436_SONET_40G_OTN))
+ printf("%s 40G OTN (OTU3B/OTU3C)\n", pfx);
+ if (id[SFF8436_SONET_COMP_OFFSET] & (SFF8436_SONET_OC48_LR))
+ printf("%s SONET: OC-48, long reach\n", pfx);
+ if (id[SFF8436_SONET_COMP_OFFSET] & (SFF8436_SONET_OC48_IR))
+ printf("%s SONET: OC-48, intermediate reach\n", pfx);
+ if (id[SFF8436_SONET_COMP_OFFSET] & (SFF8436_SONET_OC48_SR))
+ printf("%s SONET: OC-48, short reach\n", pfx);
+
+ /* SAS/SATA Compliance Codes */
+ if (id[SFF8436_SAS_COMP_OFFSET] & (SFF8436_SAS_6G))
+ printf("%s SAS 6.0G\n", pfx);
+ if (id[SFF8436_SAS_COMP_OFFSET] & (SFF8436_SAS_3G))
+ printf("%s SAS 3.0G\n", pfx);
+
+ /* Ethernet Compliance Codes */
+ if (id[SFF8436_GIGE_COMP_OFFSET] & SFF8436_GIGE_1000_BASE_T)
+ printf("%s Ethernet: 1000BASE-T\n", pfx);
+ if (id[SFF8436_GIGE_COMP_OFFSET] & SFF8436_GIGE_1000_BASE_CX)
+ printf("%s Ethernet: 1000BASE-CX\n", pfx);
+ if (id[SFF8436_GIGE_COMP_OFFSET] & SFF8436_GIGE_1000_BASE_LX)
+ printf("%s Ethernet: 1000BASE-LX\n", pfx);
+ if (id[SFF8436_GIGE_COMP_OFFSET] & SFF8436_GIGE_1000_BASE_SX)
+ printf("%s Ethernet: 1000BASE-SX\n", pfx);
+
+ /* Fibre Channel link length */
+ if (id[SFF8436_FC_LEN_OFFSET] & SFF8436_FC_LEN_VERY_LONG)
+ printf("%s FC: very long distance (V)\n", pfx);
+ if (id[SFF8436_FC_LEN_OFFSET] & SFF8436_FC_LEN_SHORT)
+ printf("%s FC: short distance (S)\n", pfx);
+ if (id[SFF8436_FC_LEN_OFFSET] & SFF8436_FC_LEN_INT)
+ printf("%s FC: intermediate distance (I)\n", pfx);
+ if (id[SFF8436_FC_LEN_OFFSET] & SFF8436_FC_LEN_LONG)
+ printf("%s FC: long distance (L)\n", pfx);
+ if (id[SFF8436_FC_LEN_OFFSET] & SFF8436_FC_LEN_MED)
+ printf("%s FC: medium distance (M)\n", pfx);
+
+ /* Fibre Channel transmitter technology */
+ if (id[SFF8436_FC_LEN_OFFSET] & SFF8436_FC_TECH_LONG_LC)
+ printf("%s FC: Longwave laser (LC)\n", pfx);
+ if (id[SFF8436_FC_LEN_OFFSET] & SFF8436_FC_TECH_ELEC_INTER)
+ printf("%s FC: Electrical inter-enclosure (EL)\n", pfx);
+ if (id[SFF8436_FC_TECH_OFFSET] & SFF8436_FC_TECH_ELEC_INTRA)
+ printf("%s FC: Electrical intra-enclosure (EL)\n", pfx);
+ if (id[SFF8436_FC_TECH_OFFSET] & SFF8436_FC_TECH_SHORT_WO_OFC)
+ printf("%s FC: Shortwave laser w/o OFC (SN)\n", pfx);
+ if (id[SFF8436_FC_TECH_OFFSET] & SFF8436_FC_TECH_SHORT_W_OFC)
+ printf("%s FC: Shortwave laser with OFC (SL)\n", pfx);
+ if (id[SFF8436_FC_TECH_OFFSET] & SFF8436_FC_TECH_LONG_LL)
+ printf("%s FC: Longwave laser (LL)\n", pfx);
+
+ /* Fibre Channel transmission media */
+ if (id[SFF8436_FC_TRANS_MEDIA_OFFSET] & SFF8436_FC_TRANS_MEDIA_TW)
+ printf("%s FC: Twin Axial Pair (TW)\n", pfx);
+ if (id[SFF8436_FC_TRANS_MEDIA_OFFSET] & SFF8436_FC_TRANS_MEDIA_TP)
+ printf("%s FC: Twisted Pair (TP)\n", pfx);
+ if (id[SFF8436_FC_TRANS_MEDIA_OFFSET] & SFF8436_FC_TRANS_MEDIA_MI)
+ printf("%s FC: Miniature Coax (MI)\n", pfx);
+ if (id[SFF8436_FC_TRANS_MEDIA_OFFSET] & SFF8436_FC_TRANS_MEDIA_TV)
+ printf("%s FC: Video Coax (TV)\n", pfx);
+ if (id[SFF8436_FC_TRANS_MEDIA_OFFSET] & SFF8436_FC_TRANS_MEDIA_M6)
+ printf("%s FC: Multimode, 62.5m (M6)\n", pfx);
+ if (id[SFF8436_FC_TRANS_MEDIA_OFFSET] & SFF8436_FC_TRANS_MEDIA_M5)
+ printf("%s FC: Multimode, 50m (M5)\n", pfx);
+ if (id[SFF8436_FC_TRANS_MEDIA_OFFSET] & SFF8436_FC_TRANS_MEDIA_OM3)
+ printf("%s FC: Multimode, 50um (OM3)\n", pfx);
+ if (id[SFF8436_FC_TRANS_MEDIA_OFFSET] & SFF8436_FC_TRANS_MEDIA_SM)
+ printf("%s FC: Single Mode (SM)\n", pfx);
+
+ /* Fibre Channel speed */
+ if (id[SFF8436_FC_SPEED_OFFSET] & SFF8436_FC_SPEED_1200_MBPS)
+ printf("%s FC: 1200 MBytes/sec\n", pfx);
+ if (id[SFF8436_FC_SPEED_OFFSET] & SFF8436_FC_SPEED_800_MBPS)
+ printf("%s FC: 800 MBytes/sec\n", pfx);
+ if (id[SFF8436_FC_SPEED_OFFSET] & SFF8436_FC_SPEED_1600_MBPS)
+ printf("%s FC: 1600 MBytes/sec\n", pfx);
+ if (id[SFF8436_FC_SPEED_OFFSET] & SFF8436_FC_SPEED_400_MBPS)
+ printf("%s FC: 400 MBytes/sec\n", pfx);
+ if (id[SFF8436_FC_SPEED_OFFSET] & SFF8436_FC_SPEED_200_MBPS)
+ printf("%s FC: 200 MBytes/sec\n", pfx);
+ if (id[SFF8436_FC_SPEED_OFFSET] & SFF8436_FC_SPEED_100_MBPS)
+ printf("%s FC: 100 MBytes/sec\n", pfx);
+}
+
+static void sff8436_show_encoding(const __u8 *id)
+{
+ printf("\t%-41s : 0x%02x", "Encoding", id[SFF8436_ENCODING_OFFSET]);
+ switch (id[SFF8436_ENCODING_OFFSET]) {
+ case SFF8436_ENCODING_UNSPEC:
+ printf(" (unspecified)\n");
+ break;
+ case SFF8436_ENCODING_8B10B:
+ printf(" (8B/10B)\n");
+ break;
+ case SFF8436_ENCODING_4B5B:
+ printf(" (4B/5B)\n");
+ break;
+ case SFF8436_ENCODING_NRZ:
+ printf(" (NRZ)\n");
+ break;
+ case SFF8436_ENCODING_SONET:
+ printf(" (SONET Scrambled)\n");
+ break;
+ case SFF8436_ENCODING_64B66B:
+ printf(" (64B/66B)\n");
+ break;
+ case SFF8436_ENCODING_MANCHESTER:
+ printf(" (Manchester)\n");
+ break;
+ default:
+ printf(" (reserved or unknown)\n");
+ break;
+ }
+}
+
+static void sff8436_show_rate_identifier(const __u8 *id)
+{
+ /* TODO: Need to fix rate select logic */
+ printf("\t%-41s : 0x%02x\n", "Rate identifier",
+ id[SFF8436_EXT_RS_OFFSET]);
+}
+
+static void sff8436_show_oui(const __u8 *id)
+{
+ printf("\t%-41s : %02x:%02x:%02x\n", "Vendor OUI",
+ id[SFF8436_VENDOR_OUI_OFFSET],
+ id[SFF8436_VENDOR_OUI_OFFSET + 1],
+ id[SFF8436_VENDOR_OUI_OFFSET + 2]);
+}
+
+static void sff8436_show_wavelength_or_copper_compliance(const __u8 *id)
+{
+ printf("\t%-41s : 0x%02x", "Transmitter technology",
+ (id[SFF8436_DEVICE_TECH_OFFSET] & SFF8436_TRANS_TECH_MASK));
+
+ switch (id[SFF8436_DEVICE_TECH_OFFSET] & SFF8436_TRANS_TECH_MASK) {
+ case SFF8436_TRANS_850_VCSEL:
+ printf(" (850 nm VCSEL)\n");
+ break;
+ case SFF8436_TRANS_1310_VCSEL:
+ printf(" (1310 nm VCSEL)\n");
+ break;
+ case SFF8436_TRANS_1550_VCSEL:
+ printf(" (1550 nm VCSEL)\n");
+ break;
+ case SFF8436_TRANS_1310_FP:
+ printf(" (1310 nm FP)\n");
+ break;
+ case SFF8436_TRANS_1310_DFB:
+ printf(" (1310 nm DFB)\n");
+ break;
+ case SFF8436_TRANS_1550_DFB:
+ printf(" (1550 nm DFB)\n");
+ break;
+ case SFF8436_TRANS_1310_EML:
+ printf(" (1310 nm EML)\n");
+ break;
+ case SFF8436_TRANS_1550_EML:
+ printf(" (1550 nm EML)\n");
+ break;
+ case SFF8436_TRANS_OTHERS:
+ printf(" (Others)\n");
+ break;
+ case SFF8436_TRANS_1490_DFB:
+ printf(" (1490 nm DFB)\n");
+ break;
+ case SFF8436_TRANS_COPPER_PAS_UNEQUAL:
+ printf(" (Copper cable unequalized)\n");
+ break;
+ case SFF8436_TRANS_COPPER_PAS_EQUAL:
+ printf(" (Copper cable passive equalized)\n");
+ break;
+ case SFF8436_TRANS_COPPER_LNR_FAR_EQUAL:
+ printf(" (Copper cable, near and far end "
+ "limiting active equalizers)\n");
+ break;
+ case SFF8436_TRANS_COPPER_FAR_EQUAL:
+ printf(" (Copper cable, far end limiting "
+ "active equalizers)\n");
+ break;
+ case SFF8436_TRANS_COPPER_NEAR_EQUAL:
+ printf(" (Copper cable, near end limiting "
+ "active equalizers)\n");
+ break;
+ case SFF8436_TRANS_COPPER_LNR_EQUAL:
+ printf(" (Copper cable, linear active equalizers)\n");
+ break;
+ }
+
+ if ((id[SFF8436_DEVICE_TECH_OFFSET] & SFF8436_TRANS_TECH_MASK)
+ >= SFF8436_TRANS_COPPER_PAS_UNEQUAL) {
+ printf("\t%-41s : %udb\n", "Attenuation at 2.5GHz",
+ id[SFF8436_WAVELEN_HIGH_BYTE_OFFSET]);
+ printf("\t%-41s : %udb\n", "Attenuation at 5.0GHz",
+ id[SFF8436_WAVELEN_LOW_BYTE_OFFSET]);
+ } else {
+ printf("\t%-41s : %.3lfnm\n", "Laser wavelength",
+ (((id[SFF8436_WAVELEN_HIGH_BYTE_OFFSET] << 8) |
+ id[SFF8436_WAVELEN_LOW_BYTE_OFFSET])*0.05));
+ printf("\t%-41s : %.3lfnm\n", "Laser wavelength tolerance",
+ (((id[SFF8436_WAVE_TOL_HIGH_BYTE_OFFSET] << 8) |
+ id[SFF8436_WAVE_TOL_LOW_BYTE_OFFSET])*0.005));
+ }
+}
+
+static void sff8436_show_value_with_unit(const __u8 *id, unsigned int reg,
+ const char *name, unsigned int mult,
+ const char *unit)
+{
+ unsigned int val = id[reg];
+
+ printf("\t%-41s : %u%s\n", name, val * mult, unit);
+}
+
+static void sff8436_show_ascii(const __u8 *id, unsigned int first_reg,
+ unsigned int last_reg, const char *name)
+{
+ unsigned int reg, val;
+
+ printf("\t%-41s : ", name);
+ for (reg = first_reg; reg <= last_reg; reg++) {
+ val = id[reg];
+ putchar(((val >= 32) && (val <= 126)) ? val : '_');
+ }
+ printf("\n");
+}
+
+static double convert_mw_to_dbm(double mw)
+{
+ return (10. * log10(mw / 1000.)) + 30.;
+}
+
+/* Most common case: 16-bit unsigned integer in a certain unit */
+#define OFFSET_TO_U16(offset) \
+ (id[offset] << 8 | id[offset + 1])
+
+/*
+ * 2-byte internal temperature conversions:
+ * First byte is a signed 8-bit integer, which is the temp decimal part
+ * Second byte are 1/256th of degree, which are added to the dec part.
+ */
+#define SFF8436_OFFSET_TO_TEMP(offset) ((__s16)OFFSET_TO_U16(offset))
+
+static void sff8436_dom_parse(const __u8 *id, struct sff8436_diags *sd)
+{
+ int i = 0;
+
+ /* Monitoring Thresholds for Alarms and Warnings */
+ sd->thresh_sfp_voltage[HALRM] = OFFSET_TO_U16(SFF8436_VCC_HALRM);
+ sd->thresh_sfp_voltage[LALRM] = OFFSET_TO_U16(SFF8436_VCC_LALRM);
+ sd->thresh_sfp_voltage[HWARN] = OFFSET_TO_U16(SFF8436_VCC_HWARN);
+ sd->thresh_sfp_voltage[LWARN] = OFFSET_TO_U16(SFF8436_VCC_LWARN);
+
+ sd->thresh_sfp_temp[HALRM] = SFF8436_OFFSET_TO_TEMP(SFF8436_TEMP_HALRM);
+ sd->thresh_sfp_temp[LALRM] = SFF8436_OFFSET_TO_TEMP(SFF8436_TEMP_LALRM);
+ sd->thresh_sfp_temp[HWARN] = SFF8436_OFFSET_TO_TEMP(SFF8436_TEMP_HWARN);
+ sd->thresh_sfp_temp[LWARN] = SFF8436_OFFSET_TO_TEMP(SFF8436_TEMP_LWARN);
+
+ sd->thresh_bias_cur[HALRM] = OFFSET_TO_U16(SFF8436_TX_BIAS_HALRM);
+ sd->thresh_bias_cur[LALRM] = OFFSET_TO_U16(SFF8436_TX_BIAS_LALRM);
+ sd->thresh_bias_cur[HWARN] = OFFSET_TO_U16(SFF8436_TX_BIAS_HWARN);
+ sd->thresh_bias_cur[LWARN] = OFFSET_TO_U16(SFF8436_TX_BIAS_LWARN);
+
+ sd->thresh_rx_power[HALRM] = OFFSET_TO_U16(SFF8436_RX_PWR_HALRM);
+ sd->thresh_rx_power[LALRM] = OFFSET_TO_U16(SFF8436_RX_PWR_LALRM);
+ sd->thresh_rx_power[HWARN] = OFFSET_TO_U16(SFF8436_RX_PWR_HWARN);
+ sd->thresh_rx_power[LWARN] = OFFSET_TO_U16(SFF8436_RX_PWR_LWARN);
+
+ /* Current Values for Module */
+ sd->sfp_voltage = OFFSET_TO_U16(SFF8436_VCC_CURR);
+ sd->sfp_temp = SFF8436_OFFSET_TO_TEMP(SFF8436_TEMP_CURR);
+
+ /* Channel Specific Data */
+ for (i = 0; i < MAX_CHANNEL_NUM; i++) {
+ u8 rx_power_offset, tx_bias_offset;
+
+ switch (i) {
+ case 0:
+ rx_power_offset = SFF8436_RX_PWR_1_OFFSET;
+ tx_bias_offset = SFF8436_TX_BIAS_1_OFFSET;
+ break;
+ case 1:
+ rx_power_offset = SFF8436_RX_PWR_2_OFFSET;
+ tx_bias_offset = SFF8436_TX_BIAS_2_OFFSET;
+ break;
+ case 2:
+ rx_power_offset = SFF8436_RX_PWR_3_OFFSET;
+ tx_bias_offset = SFF8436_TX_BIAS_3_OFFSET;
+ break;
+ case 3:
+ rx_power_offset = SFF8436_RX_PWR_4_OFFSET;
+ tx_bias_offset = SFF8436_TX_BIAS_4_OFFSET;
+ break;
+ default:
+ printf(" Invalid channel: %d\n", i);
+ break;
+ }
+ sd->scd[i].bias_cur = OFFSET_TO_U16(tx_bias_offset);
+ sd->scd[i].rx_power = OFFSET_TO_U16(rx_power_offset);
+ }
+
+}
+
+static void sff8436_show_dom(const __u8 *id)
+{
+ struct sff8436_diags sd;
+ char *rx_power_string = NULL;
+ char power_string[MAX_DESC_SIZE];
+ int i;
+
+ /*
+ * There is no clear identifier to signify the existance of
+ * optical diagnostics similar to SFF-8472. So checking existance
+ * of page 3, will provide the gurantee for existance of alarms
+ * and thresholds
+ */
+ sd.supports_alarms = id[SFF8436_STATUS_2_OFFSET] &
+ SFF8436_STATUS_PAGE_3_PRESENT;
+ sd.rx_power_type = id[SFF8436_DIAG_TYPE_OFFSET] &
+ SFF8436_RX_PWR_TYPE_MASK;
+
+ sff8436_dom_parse(id, &sd);
+
+# define PRINT_xX_PWR(string, var) \
+ printf("\t%-41s : %.4f mW / %.2f dBm\n", (string), \
+ (double)((var) / 10000.), \
+ convert_mw_to_dbm((double)((var) / 10000.)))
+
+#define PRINT_BIAS(string, bias_cur) \
+ printf("\t%-41s : %.3f mA\n", (string), \
+ (double)(bias_cur / 500.))
+
+#define PRINT_TEMP(string, temp) \
+ printf("\t%-41s : %.2f degrees C / %.2f degrees F\n", (string), \
+ (double)(temp / 256.), (double)(temp / 256. * 1.8 + 32.))
+
+
+#define PRINT_VCC(string, sfp_voltage) \
+ printf("\t%-41s : %.4f V\n", (string), \
+ (double)(sfp_voltage / 10000.))
+
+#define PRINT_THRESH_BIAS(string, index) \
+ PRINT_BIAS(string, sd.thresh_bias_cur[(index)])
+
+# define PRINT_xX_THRESH_PWR(string, var, index) \
+ PRINT_xX_PWR(string, (var)[(index)])
+
+#define PRINT_THRESH_TEMP(string, index) \
+ PRINT_TEMP(string, sd.thresh_sfp_temp[(index)])
+
+#define PRINT_THRESH_VCC(string, index) \
+ PRINT_VCC(string, sd.thresh_sfp_temp[(index)])
+
+ for (i = 0; i < MAX_CHANNEL_NUM; i++) {
+ snprintf(power_string, MAX_DESC_SIZE, "%s (Channel %d)",
+ "Laser bias current", i+1);
+ PRINT_BIAS(power_string, sd.scd[i].bias_cur);
+ }
+
+ if (!sd.rx_power_type)
+ rx_power_string = "Receiver signal OMA";
+ else
+ rx_power_string = "Rcvr signal avg optical power";
+
+ for (i = 0; i < MAX_CHANNEL_NUM; i++) {
+ snprintf(power_string, MAX_DESC_SIZE, "%s(Channel %d)",
+ rx_power_string, i+1);
+ PRINT_xX_PWR(power_string, sd.scd[i].rx_power);
+ }
+
+ PRINT_TEMP("Module temperature", sd.sfp_temp);
+ PRINT_VCC("Module voltage", sd.sfp_voltage);
+
+ printf("\t%-41s : %s\n", "Alarm/warning flags implemented",
+ (!sd.supports_alarms ? "Yes" : "No"));
+ if (!sd.supports_alarms) {
+
+ for (i = 0; sff8436_aw_flags[i].str; ++i) {
+ printf("\t%-41s : %s\n", sff8436_aw_flags[i].str,
+ id[sff8436_aw_flags[i].offset]
+ & sff8436_aw_flags[i].value ? "On" : "Off");
+ }
+
+ PRINT_THRESH_BIAS("Laser bias current high alarm threshold",
+ HALRM);
+ PRINT_THRESH_BIAS("Laser bias current low alarm threshold",
+ LALRM);
+ PRINT_THRESH_BIAS("Laser bias current high warning threshold",
+ HWARN);
+ PRINT_THRESH_BIAS("Laser bias current low warning threshold",
+ LWARN);
+
+ PRINT_THRESH_TEMP("Module temperature high alarm threshold",
+ HALRM);
+ PRINT_THRESH_TEMP("Module temperature low alarm threshold",
+ LALRM);
+ PRINT_THRESH_TEMP("Module temperature high warning threshold",
+ HWARN);
+ PRINT_THRESH_TEMP("Module temperature low warning threshold",
+ LWARN);
+
+ PRINT_THRESH_VCC("Module voltage high alarm threshold",
+ HALRM);
+ PRINT_THRESH_VCC("Module voltage low alarm threshold",
+ LALRM);
+ PRINT_THRESH_VCC("Module voltage high warning threshold",
+ HWARN);
+ PRINT_THRESH_VCC("Module voltage low warning threshold",
+ LWARN);
+
+ PRINT_xX_THRESH_PWR("Laser rx power high alarm threshold",
+ sd.thresh_rx_power, HALRM);
+ PRINT_xX_THRESH_PWR("Laser rx power low alarm threshold",
+ sd.thresh_rx_power, LALRM);
+ PRINT_xX_THRESH_PWR("Laser rx power high warning threshold",
+ sd.thresh_rx_power, HWARN);
+ PRINT_xX_THRESH_PWR("Laser rx power low warning threshold",
+ sd.thresh_rx_power, LWARN);
+ }
+
+}
+void sff8436_show_all(const __u8 *id)
+{
+
+ sff8436_show_identifier(id);
+ if (id[SFF8436_ID_OFFSET] == 0x0d) {
+ sff8436_show_ext_identifier(id);
+ sff8436_show_connector(id);
+ sff8436_show_transceiver(id);
+ sff8436_show_encoding(id);
+ sff8436_show_value_with_unit(id, SFF8436_BR_NOMINAL_OFFSET,
+ "BR, Nominal", 100, "Mbps");
+ sff8436_show_rate_identifier(id);
+ sff8436_show_value_with_unit(id, SFF8436_SM_LEN_OFFSET,
+ "Length (SMF,km)", 1, "km");
+ sff8436_show_value_with_unit(id, SFF8436_OM3_LEN_OFFSET,
+ "Length (OM3 50um)", 2, "m");
+ sff8436_show_value_with_unit(id, SFF8436_OM2_LEN_OFFSET,
+ "Length (OM2 50um)", 1, "m");
+ sff8436_show_value_with_unit(id, SFF8436_OM1_LEN_OFFSET,
+ "Length (OM1 62.5um)", 1, "m");
+ sff8436_show_value_with_unit(id, SFF8436_CBL_LEN_OFFSET,
+ "Length (Copper or Active cable)", 1, "m");
+ sff8436_show_wavelength_or_copper_compliance(id);
+ sff8436_show_ascii(id, SFF8436_VENDOR_NAME_START_OFFSET,
+ SFF8436_VENDOR_NAME_END_OFFSET, "Vendor name");
+ sff8436_show_oui(id);
+ sff8436_show_ascii(id, SFF8436_VENDOR_PN_START_OFFSET,
+ SFF8436_VENDOR_PN_END_OFFSET, "Vendor PN");
+ sff8436_show_ascii(id, SFF8436_VENDOR_REV_START_OFFSET,
+ SFF8436_VENDOR_REV_END_OFFSET, "Vendor rev");
+ sff8436_show_ascii(id, SFF8436_VENDOR_SN_START_OFFSET,
+ SFF8436_VENDOR_SN_END_OFFSET, "Vendor SN");
+ sff8436_show_dom(id);
+ }
+}
diff --git a/qsfp.h b/qsfp.h
new file mode 100644
index 0000000..28107fa
--- /dev/null
+++ b/qsfp.h
@@ -0,0 +1,541 @@
+/*
+ * SFF 8436 standards based QSFP EEPROM Field Definitions
+ *
+ * Vidya Ravipati <vidya@cumulusnetworks.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef QSFP_H__
+#define QSFP_H__
+
+
+/*------------------------------------------------------------------------------
+ *
+ * QSFP EEPROM data structures
+ *
+ * register info from SFF-8436 Rev 4.8
+ */
+
+/*------------------------------------------------------------------------------
+ *
+ * Lower Memory Page 00h
+ * Measurement, Diagnostic and Control Functions
+ *
+ */
+/* Identifier - 0 */
+#define SFF8436_ID_OFFSET 0x00
+#define SFF8436_ID_UNKNOWN 0x00
+#define SFF8436_ID_GBIC 0x01
+#define SFF8436_ID_SOLDERED_MODULE 0x02
+#define SFF8436_ID_SFP 0x03
+#define SFF8436_ID_300_PIN_XBI 0x04
+#define SFF8436_ID_XENPAK 0x05
+#define SFF8436_ID_XFP 0x06
+#define SFF8436_ID_XFF 0x07
+#define SFF8436_ID_XFP_E 0x08
+#define SFF8436_ID_XPAK 0x09
+#define SFF8436_ID_X2 0x0A
+#define SFF8436_ID_DWDM_SFP 0x0B
+#define SFF8436_ID_DWDM_QSFP 0x0C
+#define SFF8436_ID_DWDM_QSFP_PLUS 0x0D
+
+#define SFF8436_STATUS_1_OFFSET 0x01
+#define SFF8436_STATUS_2_OFFSET 0x02
+/* Flat Memory:0- Paging, 1- Page 0 only */
+#define SFF8436_STATUS_PAGE_3_PRESENT (1 << 2)
+#define SFF8436_STATUS_INTL_OUTPUT (1 << 1)
+#define SFF8436_STATUS_DATA_NOT_READY (1 << 0)
+
+/* Channel Status Interrupt Flags - 3-5 */
+#define SFF8436_LOS_AW_OFFSET 0x03
+#define SFF8436_TX4_LOS_AW (1 << 7)
+#define SFF8436_TX3_LOS_AW (1 << 6)
+#define SFF8436_TX2_LOS_AW (1 << 5)
+#define SFF8436_TX1_LOS_AW (1 << 4)
+#define SFF8436_RX4_LOS_AW (1 << 3)
+#define SFF8436_RX3_LOS_AW (1 << 2)
+#define SFF8436_RX2_LOS_AW (1 << 1)
+#define SFF8436_RX1_LOS_AW (1 << 0)
+
+#define SFF8436_FAULT_AW_OFFSET 0x04
+#define SFF8436_TX4_FAULT_AW (1 << 3)
+#define SFF8436_TX3_FAULT_AW (1 << 2)
+#define SFF8436_TX2_FAULT_AW (1 << 1)
+#define SFF8436_TX1_FAULT_AW (1 << 0)
+
+/* Module Monitor Interrupt Flags - 6-8 */
+#define SFF8436_TEMP_AW_OFFSET 0x06
+#define SFF8436_TEMP_HALARM_STATUS (1 << 7)
+#define SFF8436_TEMP_LALARM_STATUS (1 << 6)
+#define SFF8436_TEMP_HWARN_STATUS (1 << 5)
+#define SFF8436_TEMP_LWARN_STATUS (1 << 4)
+
+#define SFF8436_VCC_AW_OFFSET 0x07
+#define SFF8436_VCC_HALARM_STATUS (1 << 7)
+#define SFF8436_VCC_LALARM_STATUS (1 << 6)
+#define SFF8436_VCC_HWARN_STATUS (1 << 5)
+#define SFF8436_VCC_LWARN_STATUS (1 << 4)
+
+/* Channel Monitor Interrupt Flags - 9-21 */
+#define SFF8436_RX_PWR_12_AW_OFFSET 0x09
+#define SFF8436_RX_PWR_1_HALARM (1 << 7)
+#define SFF8436_RX_PWR_1_LALARM (1 << 6)
+#define SFF8436_RX_PWR_1_HWARN (1 << 5)
+#define SFF8436_RX_PWR_1_LWARN (1 << 4)
+#define SFF8436_RX_PWR_2_HALARM (1 << 3)
+#define SFF8436_RX_PWR_2_LALARM (1 << 2)
+#define SFF8436_RX_PWR_2_HWARN (1 << 1)
+#define SFF8436_RX_PWR_2_LWARN (1 << 0)
+
+#define SFF8436_RX_PWR_34_AW_OFFSET 0x0A
+#define SFF8436_RX_PWR_3_HALARM (1 << 7)
+#define SFF8436_RX_PWR_3_LALARM (1 << 6)
+#define SFF8436_RX_PWR_3_HWARN (1 << 5)
+#define SFF8436_RX_PWR_3_LWARN (1 << 4)
+#define SFF8436_RX_PWR_4_HALARM (1 << 3)
+#define SFF8436_RX_PWR_4_LALARM (1 << 2)
+#define SFF8436_RX_PWR_4_HWARN (1 << 1)
+#define SFF8436_RX_PWR_4_LWARN (1 << 0)
+
+#define SFF8436_TX_BIAS_12_AW_OFFSET 0x0B
+#define SFF8436_TX_BIAS_1_HALARM (1 << 7)
+#define SFF8436_TX_BIAS_1_LALARM (1 << 6)
+#define SFF8436_TX_BIAS_1_HWARN (1 << 5)
+#define SFF8436_TX_BIAS_1_LWARN (1 << 4)
+#define SFF8436_TX_BIAS_2_HALARM (1 << 3)
+#define SFF8436_TX_BIAS_2_LALARM (1 << 2)
+#define SFF8436_TX_BIAS_2_HWARN (1 << 1)
+#define SFF8436_TX_BIAS_2_LWARN (1 << 0)
+
+#define SFF8436_TX_BIAS_34_AW_OFFSET 0xC
+#define SFF8436_TX_BIAS_3_HALARM (1 << 7)
+#define SFF8436_TX_BIAS_3_LALARM (1 << 6)
+#define SFF8436_TX_BIAS_3_HWARN (1 << 5)
+#define SFF8436_TX_BIAS_3_LWARN (1 << 4)
+#define SFF8436_TX_BIAS_4_HALARM (1 << 3)
+#define SFF8436_TX_BIAS_4_LALARM (1 << 2)
+#define SFF8436_TX_BIAS_4_HWARN (1 << 1)
+#define SFF8436_TX_BIAS_4_LWARN (1 << 0)
+
+/* Module Monitoring Values - 22-33 */
+#define SFF8436_TEMP_CURR 0x16
+#define SFF8436_TEMP_MSB_OFFSET 0x16
+#define SFF8436_TEMP_LSB_OFFSET 0x17
+
+#define SFF8436_VCC_CURR 0x1A
+#define SFF8436_VCC_MSB_OFFSET 0x1A
+#define SFF8436_VCC_LSB_OFFSET 0x1B
+
+/* Channel Monitoring Values - 34-81 */
+#define SFF8436_RX_PWR_1_OFFSET 0x22
+#define SFF8436_RX_PWR_2_OFFSET 0x24
+#define SFF8436_RX_PWR_3_OFFSET 0x26
+#define SFF8436_RX_PWR_4_OFFSET 0x28
+
+#define SFF8436_TX_BIAS_1_OFFSET 0x2A
+#define SFF8436_TX_BIAS_2_OFFSET 0x2C
+#define SFF8436_TX_BIAS_3_OFFSET 0x2E
+#define SFF8436_TX_BIAS_4_OFFSET 0x30
+
+/* Control Bytes - 86 - 99 */
+#define SFF8436_TX_DISABLE_OFFSET 0x56
+#define SFF8436_TX_DISABLE_4 (1 << 3)
+#define SFF8436_TX_DISABLE_3 (1 << 2)
+#define SFF8436_TX_DISABLE_2 (1 << 1)
+#define SFF8436_TX_DISABLE_1 (1 << 0)
+
+#define SFF8436_RX_RATE_SELECT_OFFSET 0x57
+#define SFF8436_RX_RATE_SELECT_4_MASK (3 << 6)
+#define SFF8436_RX_RATE_SELECT_3_MASK (3 << 4)
+#define SFF8436_RX_RATE_SELECT_2_MASK (3 << 2)
+#define SFF8436_RX_RATE_SELECT_1_MASK (3 << 0)
+
+#define SFF8436_TX_RATE_SELECT_OFFSET 0x58
+#define SFF8436_TX_RATE_SELECT_4_MASK (3 << 6)
+#define SFF8436_TX_RATE_SELECT_3_MASK (3 << 4)
+#define SFF8436_TX_RATE_SELECT_2_MASK (3 << 2)
+#define SFF8436_TX_RATE_SELECT_1_MASK (3 << 0)
+
+#define SFF8436_RX_APP_SELECT_4_OFFSET 0x58
+#define SFF8436_RX_APP_SELECT_3_OFFSET 0x59
+#define SFF8436_RX_APP_SELECT_2_OFFSET 0x5A
+#define SFF8436_RX_APP_SELECT_1_OFFSET 0x5B
+
+#define SFF8436_PWR_MODE_OFFSET 0x5D
+#define SFF8436_LOW_PWR_MODE (1 << 1)
+#define SFF8436_PWR_OVERRIDE (1 << 0)
+
+#define SFF8436_TX_APP_SELECT_4_OFFSET 0x5E
+#define SFF8436_TX_APP_SELECT_3_OFFSET 0x5F
+#define SFF8436_TX_APP_SELECT_2_OFFSET 0x60
+#define SFF8436_TX_APP_SELECT_1_OFFSET 0x61
+
+#define SFF8436_LOS_MASK_OFFSET 0x64
+#define SFF8436_TX_LOS_4_MASK (1 << 7)
+#define SFF8436_TX_LOS_3_MASK (1 << 6)
+#define SFF8436_TX_LOS_2_MASK (1 << 5)
+#define SFF8436_TX_LOS_1_MASK (1 << 4)
+#define SFF8436_RX_LOS_4_MASK (1 << 3)
+#define SFF8436_RX_LOS_3_MASK (1 << 2)
+#define SFF8436_RX_LOS_2_MASK (1 << 1)
+#define SFF8436_RX_LOS_1_MASK (1 << 0)
+
+#define SFF8436_FAULT_MASK_OFFSET 0x65
+#define SFF8436_TX_FAULT_1_MASK (1 << 3)
+#define SFF8436_TX_FAULT_2_MASK (1 << 2)
+#define SFF8436_TX_FAULT_3_MASK (1 << 1)
+#define SFF8436_TX_FAULT_4_MASK (1 << 0)
+
+#define SFF8436_TEMP_MASK_OFFSET 0x67
+#define SFF8436_TEMP_HALARM_MASK (1 << 7)
+#define SFF8436_TEMP_LALARM_MASK (1 << 6)
+#define SFF8436_TEMP_HWARN_MASK (1 << 5)
+#define SFF8436_TEMP_LWARN_MASK (1 << 4)
+
+#define SFF8436_VCC_MASK_OFFSET 0x68
+#define SFF8436_VCC_HALARM_MASK (1 << 7)
+#define SFF8436_VCC_LALARM_MASK (1 << 6)
+#define SFF8436_VCC_HWARN_MASK (1 << 5)
+#define SFF8436_VCC_LWARN_MASK (1 << 4)
+
+/*------------------------------------------------------------------------------
+ *
+ * Upper Memory Page 00h
+ * Serial ID - Base ID, Extended ID and Vendor Specific ID fields
+ *
+ */
+/* Identifier - 128 */
+/* Identifier values same as Lower Memory Page 00h */
+#define SFF8436_UPPER_PAGE_0_ID_OFFSET 0x80
+
+/* Extended Identifier - 128 */
+#define SFF8436_EXT_ID_OFFSET 0x81
+#define SFF8436_EXT_ID_PWR_CLASS_MASK 0xC0
+#define SFF8436_EXT_ID_PWR_CLASS_1 (0 << 6)
+#define SFF8436_EXT_ID_PWR_CLASS_2 (1 << 6)
+#define SFF8436_EXT_ID_PWR_CLASS_3 (2 << 6)
+#define SFF8436_EXT_ID_PWR_CLASS_4 (3 << 6)
+#define SFF8436_EXT_ID_CLIE_MASK 0x10
+#define SFF8436_EXT_ID_CLIEI_CODE_PRESENT (1 << 4)
+#define SFF8436_EXT_ID_CDR_TX_MASK 0x08
+#define SFF8436_EXT_ID_CDR_TX_PRESENT (1 << 3)
+#define SFF8436_EXT_ID_CDR_RX_MASK 0x04
+#define SFF8436_EXT_ID_CDR_RX_PRESENT (1 << 2)
+
+/* Connector Values offset - 130 */
+#define SFF8436_CTOR_OFFSET 0x82
+#define SFF8436_CTOR_UNKNOWN 0x00
+#define SFF8436_CTOR_SC 0x01
+#define SFF8436_CTOR_FC_STYLE_1 0x02
+#define SFF8436_CTOR_FC_STYLE_2 0x03
+#define SFF8436_CTOR_BNC_TNC 0x04
+#define SFF8436_CTOR_FC_COAX 0x05
+#define SFF8436_CTOR_FIBER_JACK 0x06
+#define SFF8436_CTOR_LC 0x07
+#define SFF8436_CTOR_MT_RJ 0x08
+#define SFF8436_CTOR_MU 0x09
+#define SFF8436_CTOR_SG 0x0A
+#define SFF8436_CTOR_OPT_PT 0x0B
+#define SFF8436_CTOR_MPO 0x0C
+/* 0D-1Fh --- Reserved */
+#define SFF8436_CTOR_HSDC_II 0x20
+#define SFF8436_CTOR_COPPER_PT 0x21
+#define SFF8436_CTOR_RJ45 0x22
+#define SFF8436_CTOR_NO_SEPARABLE 0x23
+
+/* Specification Compliance - 131-138 */
+/* Ethernet Compliance Codes - 131 */
+#define SFF8436_ETHERNET_COMP_OFFSET 0x83
+#define SFF8436_ETHERNET_RSRVD (1 << 7)
+#define SFF8436_ETHERNET_10G_LRM (1 << 6)
+#define SFF8436_ETHERNET_10G_LR (1 << 5)
+#define SFF8436_ETHERNET_10G_SR (1 << 4)
+#define SFF8436_ETHERNET_40G_CR4 (1 << 3)
+#define SFF8436_ETHERNET_40G_SR4 (1 << 2)
+#define SFF8436_ETHERNET_40G_LR4 (1 << 1)
+#define SFF8436_ETHERNET_40G_ACTIVE (1 << 0)
+
+/* SONET Compliance Codes - 132 */
+#define SFF8436_SONET_COMP_OFFSET 0x84
+#define SFF8436_SONET_40G_OTN (1 << 3)
+#define SFF8436_SONET_OC48_LR (1 << 2)
+#define SFF8436_SONET_OC48_IR (1 << 1)
+#define SFF8436_SONET_OC48_SR (1 << 0)
+
+/* SAS/SATA Complaince Codes - 133 */
+#define SFF8436_SAS_COMP_OFFSET 0x85
+#define SFF8436_SAS_6G (1 << 5)
+#define SFF8436_SAS_3G (1 << 4)
+
+/* Gigabit Ethernet Compliance Codes - 134 */
+#define SFF8436_GIGE_COMP_OFFSET 0x86
+#define SFF8436_GIGE_1000_BASE_T (1 << 3)
+#define SFF8436_GIGE_1000_BASE_CX (1 << 2)
+#define SFF8436_GIGE_1000_BASE_LX (1 << 1)
+#define SFF8436_GIGE_1000_BASE_SX (1 << 0)
+
+
+/* Fibre Channel Link length/Transmitter Tech. - 135,136 */
+#define SFF8436_FC_LEN_OFFSET 0x87
+#define SFF8436_FC_LEN_VERY_LONG (1 << 7)
+#define SFF8436_FC_LEN_SHORT (1 << 6)
+#define SFF8436_FC_LEN_INT (1 << 5)
+#define SFF8436_FC_LEN_LONG (1 << 4)
+#define SFF8436_FC_LEN_MED (1 << 3)
+#define SFF8436_FC_TECH_LONG_LC (1 << 1)
+#define SFF8436_FC_TECH_ELEC_INTER (1 << 0)
+
+#define SFF8436_FC_TECH_OFFSET 0x88
+#define SFF8436_FC_TECH_ELEC_INTRA (1 << 7)
+#define SFF8436_FC_TECH_SHORT_WO_OFC (1 << 6)
+#define SFF8436_FC_TECH_SHORT_W_OFC (1 << 5)
+#define SFF8436_FC_TECH_LONG_LL (1 << 4)
+
+
+/* Fibre Channel Transmitter Media - 137 */
+#define SFF8436_FC_TRANS_MEDIA_OFFSET 0x89
+/* Twin Axial Pair */
+#define SFF8436_FC_TRANS_MEDIA_TW (1 << 7)
+/* Shielded Twisted Pair */
+#define SFF8436_FC_TRANS_MEDIA_TP (1 << 6)
+/* Miniature Coax */
+#define SFF8436_FC_TRANS_MEDIA_MI (1 << 5)
+/* Video Coax */
+#define SFF8436_FC_TRANS_MEDIA_TV (1 << 4)
+/* Multi-mode 62.5m */
+#define SFF8436_FC_TRANS_MEDIA_M6 (1 << 3)
+/* Multi-mode 50m */
+#define SFF8436_FC_TRANS_MEDIA_M5 (1 << 2)
+/* Multi-mode 50um */
+#define SFF8436_FC_TRANS_MEDIA_OM3 (1 << 1)
+/* Single Mode */
+#define SFF8436_FC_TRANS_MEDIA_SM (1 << 0)
+
+/* Fibre Channel Speed - 138 */
+#define SFF8436_FC_SPEED_OFFSET 0x8A
+#define SFF8436_FC_SPEED_1200_MBPS (1 << 7)
+#define SFF8436_FC_SPEED_800_MBPS (1 << 6)
+#define SFF8436_FC_SPEED_1600_MBPS (1 << 5)
+#define SFF8436_FC_SPEED_400_MBPS (1 << 4)
+#define SFF8436_FC_SPEED_200_MBPS (1 << 2)
+#define SFF8436_FC_SPEED_100_MBPS (1 << 0)
+
+/* Encoding - 139 */
+#define SFF8436_ENCODING_OFFSET 0x8B
+#define SFF8436_ENCODING_MANCHESTER 0x06
+#define SFF8436_ENCODING_64B66B 0x05
+#define SFF8436_ENCODING_SONET 0x04
+#define SFF8436_ENCODING_NRZ 0x03
+#define SFF8436_ENCODING_4B5B 0x02
+#define SFF8436_ENCODING_8B10B 0x01
+#define SFF8436_ENCODING_UNSPEC 0x00
+
+/* BR, Nominal - 140 */
+#define SFF8436_BR_NOMINAL_OFFSET 0x8C
+
+/* Extended RateSelect - 141 */
+#define SFF8436_EXT_RS_OFFSET 0x8D
+#define SFF8436_EXT_RS_V1 (1 << 0)
+
+/* Length (Standard SM Fiber)-km - 142 */
+#define SFF8436_SM_LEN_OFFSET 0x8E
+
+/* Length (OM3)-Unit 2m - 143 */
+#define SFF8436_OM3_LEN_OFFSET 0x8F
+
+/* Length (OM2)-Unit 1m - 144 */
+#define SFF8436_OM2_LEN_OFFSET 0x90
+
+/* Length (OM1)-Unit 1m - 145 */
+#define SFF8436_OM1_LEN_OFFSET 0x91
+
+/* Cable Assembly Length -Unit 1m - 146 */
+#define SFF8436_CBL_LEN_OFFSET 0x92
+
+/* Device Technology - 147 */
+#define SFF8436_DEVICE_TECH_OFFSET 0x93
+/* Transmitter Technology */
+#define SFF8436_TRANS_TECH_MASK 0xF0
+/* Copper cable, linear active equalizers */
+#define SFF8436_TRANS_COPPER_LNR_EQUAL (15 << 4)
+/* Copper cable, near end limiting active equalizers */
+#define SFF8436_TRANS_COPPER_NEAR_EQUAL (14 << 4)
+/* Copper cable, far end limiting active equalizers */
+#define SFF8436_TRANS_COPPER_FAR_EQUAL (13 << 4)
+/* Copper cable, near & far end limiting active equalizers */
+#define SFF8436_TRANS_COPPER_LNR_FAR_EQUAL (12 << 4)
+/* Copper cable, passive equalized */
+#define SFF8436_TRANS_COPPER_PAS_EQUAL (11 << 4)
+/* Copper cable, unequalized */
+#define SFF8436_TRANS_COPPER_PAS_UNEQUAL (10 << 4)
+/* 1490 nm DFB */
+#define SFF8436_TRANS_1490_DFB (9 << 4)
+/* Others */
+#define SFF8436_TRANS_OTHERS (8 << 4)
+/* 1550 nm EML */
+#define SFF8436_TRANS_1550_EML (7 << 4)
+/* 1310 nm EML */
+#define SFF8436_TRANS_1310_EML (6 << 4)
+/* 1550 nm DFB */
+#define SFF8436_TRANS_1550_DFB (5 << 4)
+/* 1310 nm DFB */
+#define SFF8436_TRANS_1310_DFB (4 << 4)
+/* 1310 nm FP */
+#define SFF8436_TRANS_1310_FP (3 << 4)
+/* 1550 nm VCSEL */
+#define SFF8436_TRANS_1550_VCSEL (2 << 4)
+/* 1310 nm VCSEL */
+#define SFF8436_TRANS_1310_VCSEL (1 << 4)
+/* 850 nm VCSEL */
+#define SFF8436_TRANS_850_VCSEL (0 << 4)
+
+ /* Active/No wavelength control */
+#define SFF8436_DEV_TECH_ACTIVE_WAVE_LEN (1 << 3)
+/* Cooled transmitter */
+#define SFF8436_DEV_TECH_COOL_TRANS (1 << 2)
+/* APD/Pin Detector */
+#define SFF8436_DEV_TECH_APD_DETECTOR (1 << 1)
+/* Transmitter tunable */
+#define SFF8436_DEV_TECH_TUNABLE (1 << 0)
+
+/* Vendor Name - 148-163 */
+#define SFF8436_VENDOR_NAME_START_OFFSET 0x94
+#define SFF8436_VENDOR_NAME_END_OFFSET 0xA3
+
+/* Extended Module Codes - 164 */
+#define SFF8436_EXT_MOD_CODE_OFFSET 0xA4
+#define SFF8436_EXT_MOD_INFINIBAND_EDR (1 << 4)
+#define SFF8436_EXT_MOD_INFINIBAND_FDR (1 << 3)
+#define SFF8436_EXT_MOD_INFINIBAND_QDR (1 << 2)
+#define SFF8436_EXT_MOD_INFINIBAND_DDR (1 << 1)
+#define SFF8436_EXT_MOD_INFINIBAND_SDR (1 << 0)
+
+/* Vendor OUI - 165-167 */
+#define SFF8436_VENDOR_OUI_OFFSET 0xA5
+#define SFF8436_VENDOR_OUI_LEN 3
+
+/* Vendor OUI - 165-167 */
+#define SFF8436_VENDOR_PN_START_OFFSET 0xA8
+#define SFF8436_VENDOR_PN_END_OFFSET 0xB7
+
+/* Vendor Revision - 184-185 */
+#define SFF8436_VENDOR_REV_START_OFFSET 0xB8
+#define SFF8436_VENDOR_REV_END_OFFSET 0xB8
+
+/* Wavelength - 186-187 */
+#define SFF8436_WAVELEN_HIGH_BYTE_OFFSET 0xBA
+#define SFF8436_WAVELEN_LOW_BYTE_OFFSET 0xBB
+
+/* Wavelength Tolerance- 188-189 */
+#define SFF8436_WAVE_TOL_HIGH_BYTE_OFFSET 0xBC
+#define SFF8436_WAVE_TOL_LOW_BYTE_OFFSET 0xBD
+
+/* Max case temp - Other than 70 C - 190 */
+#define SFF8436_MAXCASE_TEMP_OFFSET 0xBE
+
+/* CC_BASE - 191 */
+#define SFF8436_CC_BASE_OFFSET 0xBF
+
+/* Option Values - 192-195 */
+#define SFF8436_OPTION_1_OFFSET 0xC0
+#define SFF8436_OPTION_2_OFFSET 0xC1
+/* Rx output amplitude */
+#define SFF8436_O2_RX_OUTPUT_AMP (1 << 0)
+#define SFF8436_OPTION_3_OFFSET 0xC2
+/* Rx Squelch Disable */
+#define SFF8436_O3_RX_SQL_DSBL (1 << 3)
+/* Rx Output Disable capable */
+#define SFF8436_O3_RX_OUTPUT_DSBL (1 << 2)
+/* Tx Squelch Disable */
+#define SFF8436_O3_TX_SQL_DSBL (1 << 1)
+/* Tx Squelch Impl */
+#define SFF8436_O3_TX_SQL_IMPL (1 << 0)
+#define SFF8436_OPTION_4_OFFSET 0xC3
+/* Memory Page 02 present */
+#define SFF8436_O4_PAGE_02_PRESENT (1 << 7)
+/* Memory Page 01 present */
+#define SFF8436_O4_PAGE_01_PRESENT (1 << 6)
+/* Rate Select implemented */
+#define SFF8436_O4_RATE_SELECT (1 << 5)
+/* Tx_DISABLE implemented */
+#define SFF8436_O4_TX_DISABLE (1 << 4)
+/* Tx_FAULT implemented */
+#define SFF8436_O4_TX_FAULT (1 << 3)
+/* Tx Squelch implemented */
+#define SFF8436_O4_TX_SQUELCH (1 << 2)
+/* Tx Loss of Signal */
+#define SFF8436_O4_TX_LOS (1 << 1)
+
+/* Vendor SN - 196-211 */
+#define SFF8436_VENDOR_SN_START_OFFSET 0xC4
+#define SFF8436_VENDOR_SN_END_OFFSET 0xD3
+
+/* Vendor Date - 212-219 */
+#define SFF8436_DATE_YEAR_OFFSET 0xD4
+#define SFF8436_DATE_YEAR_LEN 2
+#define SFF8436_DATE_MONTH_OFFSET 0xD6
+#define SFF8436_DATE_MONTH_LEN 2
+#define SFF8436_DATE_DAY_OFFSET 0xD8
+#define SFF8436_DATE_DAY_LEN 2
+
+/* Diagnostic Monitoring Type - 220 */
+#define SFF8436_DIAG_TYPE_OFFSET 0xDC
+#define SFF8436_RX_PWR_TYPE_MASK 0x8
+#define SFF8436_RX_PWR_TYPE_AVG_PWR (1 << 3)
+#define SFF8436_RX_PWR_TYPE_OMA (0 << 3)
+
+/* Enhanced Options - 221 */
+#define SFF8436_ENH_OPTIONS_OFFSET 0xDD
+#define SFF8436_RATE_SELECT_EXT_SUPPORT (1 << 3)
+#define SFF8436_RATE_SELECT_APP_TABLE_SUPPORT (1 << 2)
+
+/* Check code - 223 */
+#define SFF8436_CC_EXT_OFFSET 0xDF
+#define SFF8436_CC_EXT_LEN 1
+
+
+/*------------------------------------------------------------------------------
+ *
+ * Upper Memory Page 03h
+ * Contains module thresholds, channel thresholds and masks,
+ * and optional channel controls
+ *
+ * Offset - Page Num(3) * PageSize(0x80) + Page offset
+ */
+
+/* Module Thresholds (48 Bytes) 128-175 */
+/* MSB at low address, LSB at high address */
+#define SFF8436_TEMP_HALRM 0x200
+#define SFF8436_TEMP_LALRM 0x202
+#define SFF8436_TEMP_HWARN 0x204
+#define SFF8436_TEMP_LWARN 0x206
+
+#define SFF8436_VCC_HALRM 0x210
+#define SFF8436_VCC_LALRM 0x212
+#define SFF8436_VCC_HWARN 0x214
+#define SFF8436_VCC_LWARN 0x216
+
+#define SFF8436_RX_PWR_HALRM 0x230
+#define SFF8436_RX_PWR_LALRM 0x232
+#define SFF8436_RX_PWR_HWARN 0x234
+#define SFF8436_RX_PWR_LWARN 0x236
+
+#define SFF8436_TX_BIAS_HALRM 0x238
+#define SFF8436_TX_BIAS_LALRM 0x23A
+#define SFF8436_TX_BIAS_HWARN 0x23C
+#define SFF8436_TX_BIAS_LWARN 0x23E
+
+#endif /* QSFP_H__ */
--
1.7.10.4
^ permalink raw reply related
* Re: Query regarding sk_filter
From: Alexei Starovoitov @ 2015-01-10 0:51 UTC (permalink / raw)
To: Kumar Sanghvi; +Cc: netdev@vger.kernel.org
In-Reply-To: <20150109112302.GA9428@kumar-pc.asicdesigners.com>
On Fri, Jan 9, 2015 at 3:23 AM, Kumar Sanghvi <kumaras@chelsio.com> wrote:
> Hi netdev team,
>
> I have a query regarding sk_filter call in tcp receive path:
>
> In 'tcp_v4_rcv' function, if sk is found by __inet_lookup_skb then,
> down the line, there is a call to sk_filter to ensure if the incoming packet
> is allowed to be processed for that sk.
>
> However, in 'tcp_v4_hnd_req' function, if nsk is found by inet_lookup_established
> then, later, there does not seem to be a sk_filter call for that nsk in the receive
> path processing.
>
> I am wondering shouldn't there be a sk_filter call on nsk found in 'tcp_v4_hnd_req'
> function ? Or, probably I am missing something.
hmm. I'm not sure what you're seeing.
tcp_v4_hnd_req() is called from tcp_v4_do_rcv() which is called
after sk_filter() check is done in tcp_v4_rcv() (either directly
or via prequeue/backlog)
> I am running some high rate syn-flood tests and trying to understand
> the sk_filter behaviour in this case.
are you saying not all of syn packets are reaching filter?
^ permalink raw reply
* Re: [PATCH RFC net-next] ip_tunnel: create percpu gro_cell
From: Eric Dumazet @ 2015-01-10 1:02 UTC (permalink / raw)
To: Martin Lau; +Cc: netdev, kernel-team
In-Reply-To: <20150109231703.GF3842288@devbig242.prn2.facebook.com>
On Fri, 2015-01-09 at 15:17 -0800, Martin Lau wrote:
> Is the spin_lock() still needed?
Think about cpu hotplug, we can have interesting things here.
Basically no cost at all once mem is percpu.
^ permalink raw reply
* Re: Clarification regarding IFLA_BRPORT_LEARNING_SYNC and aging of fdb entries learnt via br_fdb_external_learn_add()
From: B Viswanath @ 2015-01-10 2:31 UTC (permalink / raw)
To: Scott Feldman; +Cc: Arad, Ronen, Jiri Pirko, Siva Mannem, Netdev
In-Reply-To: <CAE4R7bCVCwPNq44_Ax2RQvtdZg_LCHGTQW0RrRAs-jCiDUduzQ@mail.gmail.com>
Hi Scot,
I think we can see the problem in case 1 itself.
Driver's can't periodically update kernel about refreshing the fdb
entry in reality. Some of the switches I worked on a while ago have
16K entries in a MAC table, Surely it has grown folds now. For the
driver to be able to refresh kernel periodically would be a nightmare,
performance wise, to poll this many entries from hardware, see which
of them is updated.
The driver is updating the kernel about learnt entry. I think it makes
sence to have driver update the kernel about ageing too.
Thanks
Viswanath
On 10 January 2015 at 00:17, Scott Feldman <sfeldma@gmail.com> wrote:
> On Fri, Jan 9, 2015 at 8:15 AM, Arad, Ronen <ronen.arad@intel.com> wrote:
>>
>>
>>>-----Original Message-----
>>>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
>>>Behalf Of Scott Feldman
>>>Sent: Friday, January 09, 2015 3:47 AM
>>>To: Jiri Pirko
>>>Cc: Siva Mannem; Netdev
>>>Subject: Re: Clarification regarding IFLA_BRPORT_LEARNING_SYNC and aging of
>>>fdb entries learnt via br_fdb_external_learn_add()
>>>
>>>On Wed, Jan 7, 2015 at 4:53 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>>> Tue, Dec 30, 2014 at 07:20:21PM CET, siva.mannem.lnx@gmail.com wrote:
>>>>>Hi,
>>>>>
>>>>>I am trying to understand the ongoing switch device offload effort and
>>>>>am following the discussions. I have a question regarding
>>>>>IFLA_BRPORT_LEARNING_SYNC flag and how aging happens when this flag is
>>>>>enabled on a port that is attached to a bridge that has vlan filtering
>>>>>enabled.
>>>>>
>>>>>If I understand correctly, when IFLA_BRPORT_LEARNING_SYNC is set on a
>>>>>bridge port, fdb entries that are learnt externally(may be learnt by
>>>>>hardware and driver is notified) are synced to bridges fdb using
>>>>>br_fdb_external_learn_add(). The fdb
>>>>>entries(fdb->added_by_external_learn set to true) that are learnt via
>>>>>this method are also deleted by the aging logic after the aging time
>>>>>even though L2 data forwadring happens in hardware.
>>>
>>>This is correct...
>>>
>>>>> Is there a way
>>>>>where aging can be disabled for these entries? and let the entries be
>>>>>removed only via br_fdb_external_learn_delete()? or am I missing
>>>>>something?
>>>>
>>>> Currently extenaly learned fdb entries are indeed removed during aging
>>>> cleanup. I believe that br_fdb_cleanup should check added_by_external_learn
>>>> and not remove that fdbs. What do you think Scott?
>>>
>>>Something like that would work, if we added another brport flag to
>>>control that. With the current arrangement, using bridge for aging
>>>out entries, we want br_fdb_cleanup removing the external_learned
>>>fdbs, but if there was another brport flag we could fine tune that.
>>>Say new flag is IFLA_BRPORT_AGING_OFFLOAD or something like that. I'm
>>>not sure how aging settings for the bridge are pushed down to offload
>>>hw, or if there is a different set for hw.
>>>
>>>But, isn't it nice to let Linux bridge control aging? That way,
>>>bridge -s fdb dump shows nice statistics on fdb entries. Hardware
>>>isn't involved in the aging processes (other than being told to remove
>>>an entry). Simple hardware equals simple driver. Linux remains
>>>control point.
>>>
>> It is indeed simpler. However, if the overhead of reading hit bits from the HW
>> and updating freshness of entries using br_fdb_external_learn_add() is too
>> expensive, it would force such platforms to disable learning sync altogether.
>> Therefore, I believe aging offload flag (could be sufficient at bridge level)
>> and external aging interval (possibly longer than the software aging interval)
>> will encourage drivers to use leaning sync.
>>>-scott
>
> I'm not sure I follow that last part.
>
> Can we list out the use-cases to see what's missing?
>
> Case 1: bridge ages out learned_sync'ed entries
>
> bridge port learning: off
> offload port learning: on
> offload port learning_sync: on
>
> Driver calls br_fdb_external_learn_add() periodically to refresh
> bridge fdb entry
> to keep it from going stale.
> Bridge removes aged out fdb entries (and indirectly tells offload
> device to do the same).
>
> Case 2: offload device/bridge age out entries independently
>
> bridge port learning: on
> offload port learning: on
> offload port learning_sync: off
>
> Bridge ages out its stale learned entries, independent of offload device.
> Offload device ages out its stale learned entries, independent of bridge.
>
> Case 3: ?
>
> Please help me finish the use-case list so we can see what's missing.
>
> -scott
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH net-next 16/16] tipc: make netlink support net namespace
From: Ying Xue @ 2015-01-10 6:04 UTC (permalink / raw)
To: Sergei Shtylyov, davem
Cc: jon.maloy, Tero.Aho, netdev, Paul.Gortmaker, tipc-discussion
In-Reply-To: <54AFDABB.3080103@cogentembedded.com>
On 01/09/2015 09:42 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 1/9/2015 10:27 AM, Ying Xue wrote:
>
>> Currently tipc module only allows users sitting on "init_net" namespace
>> to configure it through netlink interface. But now almost each tipc
>> component is able to be aware of net namespace, so it's time to open
>> the permission for users residing in other namespaces, allowing them
>> to configure their own tipc stack instance through netlink interface.
>
>> Signed-off-by: Ying Xue <ying.xue@windriver.com>
>> Tested-by: Tero Aho <Tero.Aho@coriant.com>
>> Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
>> ---
>> net/tipc/netlink.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>> diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c
>> index 282b596..fe0f513 100644
>> --- a/net/tipc/netlink.c
>> +++ b/net/tipc/netlink.c
>> @@ -54,7 +54,8 @@ static int handle_cmd(struct sk_buff *skb, struct
>> genl_info *info)
>> int hdr_space = nlmsg_total_size(GENL_HDRLEN + TIPC_GENL_HDRLEN);
>> u16 cmd;
>>
>> - if ((req_userhdr->cmd & 0xC000) && (!netlink_capable(skb,
>> CAP_NET_ADMIN)))
>> + if ((req_userhdr->cmd & 0xC000) &&
>> + (!netlink_net_capable(skb, CAP_NET_ADMIN)))
>
> Why? Also, it seems like unrelated change...
>
Without above change, the line length is over 80 characters. Of course,
this change is not much related to what the patch is really doing.
Regards,
Ying
> [...]
>
> WBR, Sergei
>
>
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
^ permalink raw reply
* RE: Clarification regarding IFLA_BRPORT_LEARNING_SYNC and aging of fdb entries learnt via br_fdb_external_learn_add()
From: Arad, Ronen @ 2015-01-10 6:51 UTC (permalink / raw)
To: Scott Feldman, Netdev; +Cc: Jiri Pirko, Siva Mannem
In-Reply-To: <CAE4R7bCVCwPNq44_Ax2RQvtdZg_LCHGTQW0RrRAs-jCiDUduzQ@mail.gmail.com>
[...]
>> It is indeed simpler. However, if the overhead of reading hit bits from the
>HW
>> and updating freshness of entries using br_fdb_external_learn_add() is too
>> expensive, it would force such platforms to disable learning sync
>altogether.
>> Therefore, I believe aging offload flag (could be sufficient at bridge
>level)
>> and external aging interval (possibly longer than the software aging
>interval)
>> will encourage drivers to use leaning sync.
>>>-scott
>
>I'm not sure I follow that last part.
>
>Can we list out the use-cases to see what's missing?
>
>Case 1: bridge ages out learned_sync'ed entries
>
>bridge port learning: off
>offload port learning: on
>offload port learning_sync: on
>
>Driver calls br_fdb_external_learn_add() periodically to refresh
>bridge fdb entry
>to keep it from going stale.
>Bridge removes aged out fdb entries (and indirectly tells offload
>device to do the same).
>
>Case 2: offload device/bridge age out entries independently
>
>bridge port learning: on
>offload port learning: on
>offload port learning_sync: off
>
>Bridge ages out its stale learned entries, independent of offload device.
>Offload device ages out its stale learned entries, independent of bridge.
>
>Case 3: ?
>
>Please help me finish the use-case list so we can see what's missing.
Case 3: offload device ages out external entries and notifies bridge
bridge port learning: on or off (Bridge only learns from packets seen (Rx/Tx))
offload port learning: on
offload port learning_sync: on
bridge aging of external learn: off
offload device aging: on
Switch port/device driver ages entries (could be by HW aging or soft aging in
driver/firmware),
notifies bridge about aged entries using br_fdb_externallearn_del().
This allows efficient HW aging and batched notification at a pace independent
of bridge aging interval.
User still enjoys a single VLAN-aware FDB within the bridge module and having
all entries in one place. Externally learned entries are identified as such by
iproute2 "bridge fdb show" command. Device does not have to implement
ndo_bridge_fdb_dump() for each offload port as the bridge module provides it
for the common FDB.
Case 4: bridge ages owned and external entries at different intervals
bridge port learning: on (Effectively only for Rx/Tx traffic seen by
software bridge)
offload port learning: on (transient traffic and RxTx, overlap with bridge
learned entries possible)
offload port learning_sync: on
bridge aging of external learn: on
offload device aging: off
bridge aging interval for owned entries: T1
bridge aging interval for external entries: T2 (Typically T2 > T1)
This allows for fine-tuning the overhead of periodic updates of entries
freshness from offload port device.
The bottom line of cases 3-4 is that it is desirable to use the common bridge
FDB as long as bridge aging of externally learned entries could be controlled
by the offload device: Either be at a longer interval or disabled.
>
>-scott
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [Question] vxlan_features_check()
From: Sriharsha Basavapatna @ 2015-01-10 6:52 UTC (permalink / raw)
To: Jesse Gross, Tom Herbert; +Cc: netdev@vger.kernel.org
Hi Jesse, Tom,
The current implementation of vxlan_features_check() disables csum/gso flags
for only a subset of Non-VxLAN tunnels - those with tunnel outer transport type
of UDP. Is there any reason why this was not done for non-UDP tunnels like
GRE too ? This can avoid additional code in the driver ndo_features_check()
to disable those flags for non-UDP tunnels. Please let me know if I'm
missing something here.
The current code in vxlan_features_check() is this:
if ((l4_hdr == IPPROTO_UDP) &&
(skb->inner_protocol_type != ENCAP_TYPE_ETHER ||
skb->inner_protocol != htons(ETH_P_TEB) ||
(skb_inner_mac_header(skb) - skb_transport_header(skb) !=
sizeof(struct udphdr) + sizeof(struct vxlanhdr))))
return features & ~(NETIF_F_ALL_CSUM | NETIF_F_GSO_MASK);
That should change to:
if (l4_hdr != IPPROTO_UDP ||
skb->inner_protocol_type != ENCAP_TYPE_ETHER ||
skb->inner_protocol != htons(ETH_P_TEB) ||
(skb_inner_mac_header(skb) - skb_transport_header(skb) !=
sizeof(struct udphdr) + sizeof(struct vxlanhdr)))
return features & ~(NETIF_F_ALL_CSUM | NETIF_F_GSO_MASK);
Thanks,
-Harsha
^ permalink raw reply
* [PATCH net] drivers: net: xen-netfront: remove residual dead code
From: Vincenzo Maffione @ 2015-01-10 9:20 UTC (permalink / raw)
To: netdev
Cc: xen-devel, david.vrabel, boris.ostrovsky, konrad.wilk,
Vincenzo Maffione
This patch removes some unused arrays from the netfront private
data structures. These arrays were used in "flip" receive mode.
Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
---
drivers/net/xen-netfront.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 22bcb4e..a4e5048 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -144,10 +144,6 @@ struct netfront_queue {
struct sk_buff *rx_skbs[NET_RX_RING_SIZE];
grant_ref_t gref_rx_head;
grant_ref_t grant_rx_ref[NET_RX_RING_SIZE];
-
- unsigned long rx_pfn_array[NET_RX_RING_SIZE];
- struct multicall_entry rx_mcl[NET_RX_RING_SIZE+1];
- struct mmu_update rx_mmu[NET_RX_RING_SIZE];
};
struct netfront_info {
--
2.2.1
^ permalink raw reply related
* [PATCH 1/1] MAINTAINERS: remove ath5k mailing list
From: Jiri Slaby @ 2015-01-10 11:02 UTC (permalink / raw)
To: davem
Cc: netdev, linux-kernel, Jiri Slaby, Nick Kossifidis,
Luis R. Rodriguez, linux-wireless, Michael Renzmann
The list is in the process of closing.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: linux-wireless@vger.kernel.org
Cc: "Michael Renzmann" <mrenzmann@madwifi-project.org>
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0519e79197ad..5ce30f9810b1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1596,7 +1596,6 @@ M: Jiri Slaby <jirislaby@gmail.com>
M: Nick Kossifidis <mickflemm@gmail.com>
M: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
L: linux-wireless@vger.kernel.org
-L: ath5k-devel@lists.ath5k.org
W: http://wireless.kernel.org/en/users/Drivers/ath5k
S: Maintained
F: drivers/net/wireless/ath/ath5k/
--
2.2.1
^ permalink raw reply related
* Re: [PATCH net-next v2] tcp: avoid reducing cwnd when ACK+DSACK is received
From: Sébastien Barré @ 2015-01-10 11:51 UTC (permalink / raw)
To: Yuchung Cheng, Eric Dumazet
Cc: Neal Cardwell, David Miller, Netdev, Gregory Detal,
Nandita Dukkipati
In-Reply-To: <CAK6E8=dhW=0hRYHjjgBh0KwKOQfzHhwY2egusQ8S4tsoJb0Nsg@mail.gmail.com>
All,
Le 09/01/2015 20:43, Yuchung Cheng a écrit :
>
> Sebastien: I suggest breaking down by ACK types for readability. e.g.,
>
> /* This routine deals with acks during a TLP episode.
> * We mark the end of a TLP episode on receiving TLP dupack or when
> * ack is after tlp_high_seq.
> * Ref: loss detection algorithm in draft-dukkipati-tcpm-tcp-loss-probe.
> */
> static void tcp_process_tlp_ack(struct sock *sk, u32 ack, int flag)
> {
> struct tcp_sock *tp = tcp_sk(sk);
>
> if (before(ack, tp->tlp_high_seq))
> return;
>
> if (flag & FLAG_DSACKING_ACK) {
> /* This DSACK means original and TLP probe arrived; no loss */
> tp->tlp_high_seq = 0;
> } else if (after(ack, tp->tlp_high_seq)) {
> /* ACK advances: there was a loss, so reduce cwnd. Reset
> * tlp_high_seq in tcp_init_cwnd_reduction()
Indeed, hadn't seen that.
> */
> tcp_init_cwnd_reduction(sk);
> tcp_set_ca_state(sk, TCP_CA_CWR);
> tcp_end_cwnd_reduction(sk);
> tcp_try_keep_open(sk);
> NET_INC_STATS_BH(sock_net(sk),
> LINUX_MIB_TCPLOSSPROBERECOVERY);
> } else if (!(flag & (FLAG_SND_UNA_ADVANCED |
> FLAG_NOT_DUP | FLAG_DATA_SACKED))) {
> /* Pure dupack: original and TLP probe arrived; no loss */
> tp->tlp_high_seq = 0;
> }
> }
That looks much more readable compared to my v2.
It is currently passing our tests (These are in fact MPTCP tests appart
from Neal's packetdrill that I will add, but actually the MPTCP stack
happens to reveal this situation quite easily, I think because in MPTCP,
we store the send queue in the "meta-flow", which currently cannot be
used for tail loss probes).
As probably everyone will be happy with this (Eric as well ?), I suggest
I prepare a v3 once all our tests are passed as well, with Yuchung's
structure and Neal's packetdrill test in the commit text. Will also add
proper credit as there is now stuff from several people in those few
lines now :-).
Looks good ?
Thanks again for your fast and helpful interactions !
Sébastien.
>
>>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox