* Re: [PATCH net 1/1] qlcnic: Fix NAPI poll routine for Tx completion
From: David Miller @ 2015-02-05 8:24 UTC (permalink / raw)
To: shahed.shaikh; +Cc: netdev, Dept-GELinuxNICDev
In-Reply-To: <1423046485-9526-1-git-send-email-shahed.shaikh@qlogic.com>
From: Shahed Shaikh <shahed.shaikh@qlogic.com>
Date: Wed, 4 Feb 2015 05:41:25 -0500
> From: Shahed Shaikh <shahed.shaikh@qlogic.com>
>
> After d75b1ade567f ("net: less interrupt masking in NAPI")
> driver's NAPI poll routine is expected to return
> exact budget value if it wants to be re-called.
>
> Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
> Fixes: d75b1ade567f ("net: less interrupt masking in NAPI")
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] myri10ge: Delete an unnecessary check before the function call "kfree"
From: David Miller @ 2015-02-05 8:25 UTC (permalink / raw)
To: elfring; +Cc: hykim, netdev, linux-kernel, kernel-janitors, julia.lawall
In-Reply-To: <54D20422.5050703@users.sourceforge.net>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 04 Feb 2015 12:36:02 +0100
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 4 Feb 2015 12:32:14 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied.
^ permalink raw reply
* Re: [PATCH] net: fec: Delete unnecessary checks before the function call "kfree"
From: David Miller @ 2015-02-05 8:26 UTC (permalink / raw)
To: elfring; +Cc: netdev, linux-kernel, kernel-janitors, julia.lawall
In-Reply-To: <54D209EE.2000404@users.sourceforge.net>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 04 Feb 2015 13:00:46 +0100
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 4 Feb 2015 12:56:42 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied.
^ permalink raw reply
* Re: [PATCH] netxen: Delete an unnecessary check before the function call "kfree"
From: David Miller @ 2015-02-05 8:26 UTC (permalink / raw)
To: elfring
Cc: manish.chopra, rajesh.borundia, sony.chacko, netdev, linux-kernel,
kernel-janitors, julia.lawall
In-Reply-To: <54D20EC9.8090105@users.sourceforge.net>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 04 Feb 2015 13:21:29 +0100
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 4 Feb 2015 13:17:48 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied.
^ permalink raw reply
* Re: [PATCH] net: ethernet: ti/cpsw-common.c: fix sparse warning
From: David Miller @ 2015-02-05 8:28 UTC (permalink / raw)
To: prabhakar.csengg; +Cc: netdev, linux-kernel, tony
In-Reply-To: <1423053088-6589-1-git-send-email-prabhakar.csengg@gmail.com>
From: Lad Prabhakar <prabhakar.csengg@gmail.com>
Date: Wed, 4 Feb 2015 12:31:28 +0000
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
>
> cpsw-common.c:23:5: warning: symbol 'cpsw_am33xx_cm_get_macid' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Applied.
^ permalink raw reply
* Re: pull-request: can-next 2015-02-04
From: David Miller @ 2015-02-05 8:29 UTC (permalink / raw)
To: mkl; +Cc: netdev, kernel, linux-can
In-Reply-To: <54D21A09.70101@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Wed, 04 Feb 2015 14:09:29 +0100
> this is a pull request of 2 patches for net-next/master.
>
> Nicholas Mc Guire contributes a patch for the janz-ican3 driver to fix
> a mismatch in an assignment. Ahmed S. Darwish contributes a patch for
> the kvaser_usb driver, to make the driver more robust during the
> bus-off handling.
Applied.
^ permalink raw reply
* Re: [PATCH] qlogic: Deletion of unnecessary checks before two function calls
From: David Miller @ 2015-02-05 8:33 UTC (permalink / raw)
To: elfring
Cc: shahed.shaikh, Dept-GELinuxNICDev, netdev, linux-kernel,
kernel-janitors, julia.lawall
In-Reply-To: <54D21B01.30802@users.sourceforge.net>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 04 Feb 2015 14:13:37 +0100
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 4 Feb 2015 14:07:56 +0100
>
> The functions kfree() and vfree() perform also input parameter validation.
> Thus the test around their calls is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied.
^ permalink raw reply
* Re: [PATCH] tun: Use static attribute groups for sysfs entries
From: David Miller @ 2015-02-05 8:33 UTC (permalink / raw)
To: tiwai; +Cc: netdev
In-Reply-To: <1423057054-6889-1-git-send-email-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
Date: Wed, 4 Feb 2015 14:37:34 +0100
> Instead of manual calls of device_create_file() and
> device_remove_files(), assign the static attribute groups to netdev
> groups array. This simplifies the code and avoids the possible
> races.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied.
^ permalink raw reply
* Re: [PATCH] xen-netfront: Use static attribute groups for sysfs entries
From: David Miller @ 2015-02-05 8:33 UTC (permalink / raw)
To: tiwai; +Cc: konrad.wilk, boris.ostrovsky, david.vrabel, xen-devel, netdev
In-Reply-To: <1423057135-6939-1-git-send-email-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
Date: Wed, 4 Feb 2015 14:38:55 +0100
> Instead of manual calls of device_create_file() and
> device_remove_files(), assign the static attribute groups to netdev
> groups array. This simplifies the code and avoids the possible
> races.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied.
^ permalink raw reply
* Re: [PATCH] hso: Use static attribute groups for sysfs entry
From: David Miller @ 2015-02-05 8:33 UTC (permalink / raw)
To: tiwai; +Cc: j.dumon, linux-usb, netdev
In-Reply-To: <1423057173-6981-1-git-send-email-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
Date: Wed, 4 Feb 2015 14:39:33 +0100
> Pass the static attribute groups and the driver data via
> tty_port_register_device_attr() instead of manual device_create_file()
> and device_remove_file() calls.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This does not apply cleanly to the net-next tree, please respin.
^ permalink raw reply
* Re: [PATCH] net: Mellanox: Delete unnecessary checks before the function call "vunmap"
From: David Miller @ 2015-02-05 8:34 UTC (permalink / raw)
To: elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f
Cc: eli-VPRAkNaXOzVWk0Htik3J/w, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, julia.lawall-L2FTfq7BK8M
In-Reply-To: <54D22B29.3020200-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
From: SF Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Date: Wed, 04 Feb 2015 15:22:33 +0100
> From: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> Date: Wed, 4 Feb 2015 15:17:00 +0100
>
> The vunmap() function performs also input parameter validation.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
This does not apply cleanly to the net-next tree, please respin.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH net] ip6_gre: fix endianness errors in ip6gre_err
From: David Miller @ 2015-02-05 8:34 UTC (permalink / raw)
To: sd; +Cc: netdev
In-Reply-To: <1423059909-15606-1-git-send-email-sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Wed, 4 Feb 2015 15:25:09 +0100
> info is in network byte order, change it back to host byte order
> before use. In particular, the current code sets the MTU of the tunnel
> to a wrong (too big) value.
>
> Fixes: c12b395a4664 ("gre: Support GRE over IPv6")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied.
^ permalink raw reply
* Re: [PATCH] net: ep93xx_eth: Delete unnecessary checks before the function call "kfree"
From: David Miller @ 2015-02-05 8:37 UTC (permalink / raw)
To: elfring; +Cc: hsweeten, netdev, linux-kernel, kernel-janitors, julia.lawall
In-Reply-To: <54D23415.6070005@users.sourceforge.net>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 04 Feb 2015 16:00:37 +0100
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 4 Feb 2015 15:56:58 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] vxlan: Only set has-GBP bit in header if any other bits would be set
From: David Miller @ 2015-02-05 8:38 UTC (permalink / raw)
To: tgraf; +Cc: davem, netdev
In-Reply-To: <776a985ae0db9e2c24aefe6d7d6cef1794eb685a.1423065534.git.tgraf@suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Wed, 4 Feb 2015 17:00:04 +0100
> This allows for a VXLAN-GBP socket to talk to a Linux VXLAN socket by
> not setting any of the bits.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Applied.
^ permalink raw reply
* Re: Throughput regression with `tcp: refine TSO autosizing`
From: Michal Kazior @ 2015-02-05 8:38 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Neal Cardwell, linux-wireless, Network Development, eyalpe
In-Reply-To: <1423084303.31870.15.camel@edumazet-glaptop2.roam.corp.google.com>
On 4 February 2015 at 22:11, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> I do not see how a TSO patch could hurt a flow not using TSO/GSO.
>
> This makes no sense.
Hmm..
@@ -2018,8 +2053,8 @@ static bool tcp_write_xmit(struct sock *sk,
unsigned int mss_now, int nonagle,
* of queued bytes to ensure line rate.
* One example is wifi aggregation (802.11 AMPDU)
*/
- limit = max_t(unsigned int, sysctl_tcp_limit_output_bytes,
- sk->sk_pacing_rate >> 10);
+ limit = max(2 * skb->truesize, sk->sk_pacing_rate >> 10);
+ limit = min_t(u32, limit, sysctl_tcp_limit_output_bytes);
if (atomic_read(&sk->sk_wmem_alloc) > limit) {
set_bit(TSQ_THROTTLED, &tp->tsq_flags);
Doesn't this effectively invert how tcp_limit_output_bytes is used?
This would explain why raising the limit wasn't changing anything
anymore when you asked me do so. Only decreasing it yielded any
change.
I've added a printk to show up the new and old values. Excerpt from logs:
[ 114.782740] (4608 39126 131072 = 39126) vs (131072 39126 = 131072)
(2*truesize, pacing_rate, tcp_limit = limit) vs (tcp_limit, pacing_rate = limit)
Reverting this patch hunk alone fixes my TCP problem. Not that I'm
saying the old logic was correct (it seems it wasn't, a limit should
be applied as min(value, max_value), right?).
Anyway the change doesn't seem to be TSO-only oriented so it would
explain the "makes no sense".
Michał
^ permalink raw reply
* Re: [PATCH net] flow_keys: n_proto type should be __be16
From: David Miller @ 2015-02-05 8:40 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, _govind
In-Reply-To: <1423085514.31870.20.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 04 Feb 2015 13:31:54 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> (struct flow_keys)->n_proto is in network order, use
> proper type for this.
>
> Fixes following sparse errors :
...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Fixes: e0f31d849867 ("flow_keys: Record IP layer protocol in skb_flow_dissect()")
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net] net: remove some sparse warnings
From: David Miller @ 2015-02-05 8:41 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1423085864.31870.23.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 04 Feb 2015 13:37:44 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> netdev_adjacent_add_links() and netdev_adjacent_del_links()
> are static.
>
> queue->qdisc has __rcu annotation, need to use RCU_INIT_POINTER()
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ipv6: fix sparse errors in ip6_make_flowlabel()
From: David Miller @ 2015-02-05 8:42 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1423091005.31870.26.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 04 Feb 2015 15:03:25 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> include/net/ipv6.h:713:22: warning: incorrect type in assignment (different base types)
> include/net/ipv6.h:713:22: expected restricted __be32 [usertype] hash
> include/net/ipv6.h:713:22: got unsigned int
> include/net/ipv6.h:719:25: warning: restricted __be32 degrades to integer
> include/net/ipv6.h:719:22: warning: invalid assignment: ^=
> include/net/ipv6.h:719:22: left side has type restricted __be32
> include/net/ipv6.h:719:22: right side has type unsigned int
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH] sit: fix some __be16/u16 mismatches
From: David Miller @ 2015-02-05 8:43 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1423091524.31870.29.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 04 Feb 2015 15:12:04 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Fixes following sparse warnings :
...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH 0/6 v2 net-next] rhashtable fixes
From: Thomas Graf @ 2015-02-05 8:47 UTC (permalink / raw)
To: Ying Xue; +Cc: davem, netdev, herbert
In-Reply-To: <54D2D656.8060709@windriver.com>
On 02/05/15 at 10:32am, Ying Xue wrote:
> After I applied the sires, it sounds like panic doesn't occur any more. But soft
> lockup still happens although the frequency of its reproduction is much lower
> than before. Please take a look at its relevant log:
Thanks for testing and the report. I had run your bind_netlink test
overnight on a 4 CPU VM. Anything particular that might help trigger it?
^ permalink raw reply
* [GIT] Networking
From: David Miller @ 2015-02-05 9:07 UTC (permalink / raw)
To: torvalds; +Cc: akpm, netdev, linux-kernel
1) Stretch ACKs can kill performance with Reno and CUBIC congestion control,
largely due to LRO and GRO. Fix from Neal Cardwell.
2) Fix userland breakage because we accidently emit zero length netlink
messages from the bridging code. From Roopa Prabhu.
3) Carry handling in generic csum_tcpudp_nofold is broken, fix from
Karl Beldan.
4) Remove bogus dev_set_net() calls from CAIF driver, from Nicolas
Dichtel.
5) Make sure PPP deflation never returns a length greater then the
output buffer, otherwise we overflow and trigger skb_over_panic().
Fix from Florian Westphal.
6) COSA driver needs VIRT_TO_BUS Kconfig dependencies, from Arnd
Bergmann.
7) Don't increase route cached MTU on datagram too big ICMPs.
From Li Wei.
8) Fix error path leaks in nf_tables, from Pablo Neira Ayuso.
9) Fix bitmask handling regression in netlink that broke things
like acpi userland tools. From Pablo Neira Ayuso.
10) Wrong header pointer passed to param_type2af() in SCTP code,
from Saran Maruti Ramanara.
11) Stacked vlans not handled correctly by vlan_get_protocol(), from
Toshiaki Makita.
12) Add missing DMA memory barrier to xgene driver, from Iyappan
Subramanian.
13) Fix crash in rate estimators, from Eric Dumazet.
14) We've been adding various workarounds, one after another, for
the change which added the per-net tcp_sock. It was meant to
reduce socket contention but added lots of problems.
Reduce this instead to a proper per-cpu socket and that rids
us of all the daemons.
From Eric Dumazet.
15) Fix memory corruption and OOPS in mlx4 driver, from Jack
Morgenstein.
16) When we disabled UFO in the virtio_net device, it introduces some
serious performance regressions. The orignal problem was IPV6
fragment ID generation, so fix that properly instead. From Vlad
Yasevich.
17) sr9700 driver build breaks on xtensa because it defines macros
with the same name as those used by the arch code. Use more
unique names. From Chen Gang.
18) Fix endianness in new virio 1.0 mode of the vhost net driver,
from Michael S. Tsirkin.
19) Several sysctls were setting the maxlen attribute incorrectly,
from Sasha Levin.
20) Don't accept an FQ scheduler quantum of zero, that leads to
crashes. From Kenneth Klette Jonassen.
21) Fix dumping of non-existing actions in the packet scheduler
classifier. From Ignacy Gawędzki.
22) Return the write work_done value when doing TX work in the qlcnic
driver.
23) ip6gre_err accesses the info field with the wrong endianness,
from Sabrina Dubroca.
Please pull, thanks a lot!
The following changes since commit 59343cd7c4809cf7598789e1cd14563780ae4239:
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2015-01-27 13:55:36 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
for you to fetch changes up to a409caecb2e17fc475533738dd1c69b32e13fe09:
sit: fix some __be16/u16 mismatches (2015-02-05 00:43:14 -0800)
----------------------------------------------------------------
Arnd Bergmann (4):
net: cs89x0: always build platform code if !HAS_IOPORT_MAP
net: wan: add missing virt_to_bus dependencies
net: lance,ni64: don't build for ARM
net: am2150: fix nmclan_cs.c shared interrupt handling
Chen Gang (1):
net: usb: sr9700: Use 'SR_' prefix for the common register macros
Dan Carpenter (1):
isdn: off by one in connect_res()
David L Stevens (1):
sunvnet: set queue mapping when doing packet copies
David S. Miller (6):
Merge branch 'tcp_stretch_acks'
Merge branch 'netns'
Merge branch 'arm-build-fixes'
Merge branch 'vlan_get_protocol'
Merge git://git.kernel.org/.../pablo/nf
Merge branch 'virtio_net_ufo'
David Vrabel (1):
xen-netback: stop the guest rx thread after a fatal error
Eric Dumazet (7):
tcp: ipv4: initialize unicast_sock sk_pacing_rate
net: sched: fix panic in rate estimators
ipv4: tcp: get rid of ugly unicast_sock
flow_keys: n_proto type should be __be16
net: remove some sparse warnings
ipv6: fix sparse errors in ip6_make_flowlabel()
sit: fix some __be16/u16 mismatches
Florian Westphal (1):
ppp: deflate: never return len larger than output buffer
Haiyang Zhang (1):
hyperv: Fix the error processing in netvsc_send()
Ignacy Gawędzki (1):
cls_api.c: Fix dumping of non-existing actions' stats.
Iyappan Subramanian (1):
drivers: net: xgene: fix: Out of order descriptor bytes read
Jack Morgenstein (1):
net/mlx4_core: Fix kernel Oops (mem corruption) when working with more than 80 VFs
Julian Anastasov (1):
ipvs: rerouting to local clients is not needed anymore
Kenneth Klette Jonassen (1):
pkt_sched: fq: avoid hang when quantum 0
Lendacky, Thomas (2):
amd-xgbe: Adjust for zero-based traffic class count
amd-xgbe: Set RSS enablement based on hardware features
Li Wei (1):
ipv4: Don't increase PMTU with Datagram Too Big message.
Marcelo Leitner (1):
qlge: Fix qlge_update_hw_vlan_features to handle if interface is down
Michael S. Tsirkin (1):
vhost/net: fix up num_buffers endian-ness
Neal Cardwell (5):
tcp: stretch ACK fixes prep
tcp: fix the timid additive increase on stretch ACKs
tcp: fix stretch ACK bugs in Reno
tcp: fix stretch ACK bugs in CUBIC
tcp: fix timing issue in CUBIC slope calculation
Nicolas Dichtel (2):
caif: remove wrong dev_net_set() call
vxlan: setup the right link netns in newlink hdlr
Pablo Neira (1):
netlink: fix wrong subscription bitmask to group mapping in
Pablo Neira Ayuso (3):
netfilter: nf_tables: validate hooks in NAT expressions
netfilter: nf_tables: disable preemption when restoring chain counters
netfilter: nf_tables: fix leaks in error path of nf_tables_newchain()
Richard Weinberger (1):
Documentation: Update netlink_mmap.txt
Roopa Prabhu (1):
bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
Sabrina Dubroca (1):
ip6_gre: fix endianness errors in ip6gre_err
Sanjeev Sharma (1):
gianfar: correct the bad expression while writing bit-pattern
Saran Maruti Ramanara (1):
net: sctp: fix passing wrong parameter header to param_type2af in sctp_process_param
Sasha Levin (1):
net: rds: use correct size for max unacked packets and bytes
Shahed Shaikh (1):
qlcnic: Fix NAPI poll routine for Tx completion
Toshiaki Makita (4):
net: Fix vlan_get_protocol for stacked vlan
igbvf: Fix checksum error when using stacked vlan
ixgbe: Fix checksum error when using stacked vlan
ixgbevf: Fix checksum error when using stacked vlan
Vlad Yasevich (3):
ipv6: Select fragment id during UFO segmentation if not set.
Revert "drivers/net, ipv6: Select IPv6 fragment idents for virtio UFO packets"
Revert "drivers/net: Disable UFO through virtio"
karl beldan (2):
lib/checksum.c: fix carry in csum_tcpudp_nofold
lib/checksum.c: fix build for generic csum_tcpudp_nofold
Documentation/networking/netlink_mmap.txt | 13 ++---
drivers/isdn/hardware/eicon/message.c | 2 +-
drivers/net/caif/caif_hsi.c | 1 -
drivers/net/ethernet/amd/Kconfig | 4 +-
drivers/net/ethernet/amd/nmclan_cs.c | 2 +
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 4 +-
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 +
drivers/net/ethernet/cirrus/Kconfig | 3 +-
drivers/net/ethernet/freescale/gianfar_ethtool.c | 2 +-
drivers/net/ethernet/intel/igbvf/netdev.c | 19 ++++---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 +-
drivers/net/ethernet/mellanox/mlx4/mlx4.h | 3 +-
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 27 ++++++++--
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 26 +++++----
drivers/net/ethernet/sun/sunvnet.c | 1 +
drivers/net/hyperv/netvsc.c | 11 ++--
drivers/net/macvtap.c | 16 +++---
drivers/net/ppp/ppp_deflate.c | 2 +-
drivers/net/tun.c | 25 ++++-----
drivers/net/usb/sr9700.c | 36 ++++++-------
drivers/net/usb/sr9700.h | 66 +++++++++++------------
drivers/net/virtio_net.c | 24 ++++-----
drivers/net/vxlan.c | 10 ++--
drivers/net/wan/Kconfig | 6 +--
drivers/net/xen-netback/interface.c | 2 +
drivers/net/xen-netback/netback.c | 3 +-
drivers/vhost/net.c | 4 +-
include/linux/if_vlan.h | 60 ++++++++++++++++-----
include/linux/mlx4/device.h | 2 +-
include/net/flow_keys.h | 6 +--
include/net/ip.h | 2 +-
include/net/ipv6.h | 7 ++-
include/net/netfilter/nf_tables.h | 2 +
include/net/netns/ipv4.h | 1 +
include/net/sch_generic.h | 13 ++---
include/net/tcp.h | 4 +-
lib/checksum.c | 12 ++++-
net/bridge/netfilter/nft_reject_bridge.c | 29 +++-------
net/caif/chnl_net.c | 1 -
net/core/dev.c | 37 ++-----------
net/core/rtnetlink.c | 6 ++-
net/ipv4/ip_output.c | 29 ++--------
net/ipv4/route.c | 3 ++
net/ipv4/tcp_bic.c | 2 +-
net/ipv4/tcp_cong.c | 32 ++++++-----
net/ipv4/tcp_cubic.c | 39 ++++++--------
net/ipv4/tcp_ipv4.c | 37 +++++++++++--
net/ipv4/tcp_scalable.c | 3 +-
net/ipv4/tcp_veno.c | 2 +-
net/ipv4/tcp_yeah.c | 2 +-
net/ipv6/ip6_gre.c | 4 +-
net/ipv6/ip6_output.c | 14 -----
net/ipv6/output_core.c | 41 +++++++++++---
net/ipv6/sit.c | 8 +--
net/ipv6/udp_offload.c | 10 +++-
net/netfilter/ipvs/ip_vs_core.c | 33 ++++++++----
net/netfilter/nf_tables_api.c | 28 +++++++++-
net/netfilter/nft_masq.c | 26 +++++----
net/netfilter/nft_nat.c | 40 ++++++++++----
net/netfilter/nft_redir.c | 25 ++++++---
net/netlink/af_netlink.c | 4 +-
net/rds/sysctl.c | 4 +-
net/sched/cls_api.c | 7 +--
net/sched/sch_fq.c | 10 +++-
net/sctp/sm_make_chunk.c | 2 +-
66 files changed, 524 insertions(+), 383 deletions(-)
^ permalink raw reply
* Re: [PATCH bluetooth-next v2] ieee802154: fix netns settings
From: Alexander Aring @ 2015-02-05 9:10 UTC (permalink / raw)
To: Nicolas Dichtel; +Cc: netdev, davem, linux-wpan, marcel
In-Reply-To: <20150128203645.GB30188@omega>
On Wed, Jan 28, 2015 at 09:36:53PM +0100, Alexander Aring wrote:
> On Wed, Jan 28, 2015 at 03:58:32PM +0100, Nicolas Dichtel wrote:
> > 6LoWPAN currently doesn't supports x-netns and works only in init_net.
> >
> > With this patch, we ensure that:
> > - the wpan interface cannot be moved to another netns;
> > - the 6lowpan interface cannot be moved to another netns;
> > - the wpan interface is in the same netns than the 6lowpan interface;
> > - the 6lowpan interface is in init_net.
> >
> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>
> Acked-by: Alexander Aring <alex.aring@gmail.com>
>
> Marcel, can you please queue this for bluetooth-next?
>
ping.
- Alex
^ permalink raw reply
* Re: [PATCH 0/6 v2 net-next] rhashtable fixes
From: Ying Xue @ 2015-02-05 9:14 UTC (permalink / raw)
To: Thomas Graf; +Cc: davem, netdev, herbert
In-Reply-To: <20150205084737.GA15549@casper.infradead.org>
On 02/05/2015 04:47 PM, Thomas Graf wrote:
> On 02/05/15 at 10:32am, Ying Xue wrote:
>> After I applied the sires, it sounds like panic doesn't occur any more. But soft
>> lockup still happens although the frequency of its reproduction is much lower
>> than before. Please take a look at its relevant log:
>
> Thanks for testing and the report. I had run your bind_netlink test
> overnight on a 4 CPU VM. Anything particular that might help trigger it?
>
>
My hardware platform seems a bit advanced than you, for example, I run the test
case on a 8 CPU VM.
Additionally, I guess the port number you gave the bind_netlink application is a
little small, for instance, my given port number is 9000. Below is my complete
procedures about how to reproduce the soft lockup issue in my environment:
root@localhost:/mnt# gcc -Wall -o bind-netlink bind_netlink.c
root@localhost:/mnt# ulimit -n 100000
root@localhost:/mnt# ./bind-netlink 9000
Create 9000 ports
Created 1000 ports
Created 2000 ports
Created 3000 ports
Created 4000 ports
Created 5000 ports
Created 6000 ports
Created 7000 ports
Created 8000 ports
Created 9000 ports
Ports successfully created, terminating
root@localhost:/mnt# ./bind-netlink 9000
Create 9000 ports
Created 1000 ports
Created 2000 ports
Created 3000 ports
Created 4000 ports
Created 5000 ports
Created 6000 ports
Created 7000 ports
Created 8000 ports
Created 9000 ports
Ports successfully created, terminating
root@localhost:/mnt# ./bind-netlink 9000
Create 9000 ports
[ 442.800079] ------------[ cut here ]------------
[ 442.800456] WARNING: CPU: 2 PID: 0 at net/sched/sch_generic.c:303
dev_watchdog+0x247/0x250()
[ 442.801002] NETDEV WATCHDOG: eth0 (e1000): transmit queue 0 timed out
[ 442.801419] Modules linked in: tipc
[ 442.801671] CPU: 2 PID: 0 Comm: swapper/2 Not tainted 3.19.0-rc6+ #185
[ 442.802091] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
[ 442.802460] 000000000000012f ffff880017c83d08 ffffffff8175d285 000000000000104e
[ 442.802969] ffff880017c83d58 ffff880017c83d48 ffffffff81059717 ffffffff00000000
[ 442.803482] ffff880015eb2000 ffff880015eb23e0 ffff88000008ae00 0000000000000001
[ 442.803981] Call Trace:
[ 442.804067] <IRQ> [<ffffffff8175d285>] dump_stack+0x4c/0x65
[ 442.804067] [<ffffffff81059717>] warn_slowpath_common+0x97/0xe0
[ 442.804067] [<ffffffff81059816>] warn_slowpath_fmt+0x46/0x50
[ 442.804067] [<ffffffff81654617>] dev_watchdog+0x247/0x250
[ 442.804067] [<ffffffff816543d0>] ? pfifo_fast_dequeue+0xe0/0xe0
[ 442.804067] [<ffffffff816543d0>] ? pfifo_fast_dequeue+0xe0/0xe0
[ 442.804067] [<ffffffff810c5ebc>] call_timer_fn+0x8c/0x1e0
[ 442.804067] [<ffffffff810c5e35>] ? call_timer_fn+0x5/0x1e0
[ 442.804067] [<ffffffff817669d0>] ? _raw_spin_unlock_irq+0x30/0x40
[ 442.804067] [<ffffffff816543d0>] ? pfifo_fast_dequeue+0xe0/0xe0
[ 442.804067] [<ffffffff810c7994>] run_timer_softirq+0x2d4/0x320
[ 442.804067] [<ffffffff810d6214>] ? clockevents_program_event+0x74/0x100
[ 442.804067] [<ffffffff8105d653>] __do_softirq+0x123/0x360
[ 442.804067] [<ffffffff8105db2e>] irq_exit+0x8e/0xb0
[ 442.804067] [<ffffffff81769b2a>] smp_apic_timer_interrupt+0x4a/0x60
[ 442.804067] [<ffffffff81767eaf>] apic_timer_interrupt+0x6f/0x80
[ 442.804067] <EOI> [<ffffffff8100d174>] ? default_idle+0x24/0x100
[ 442.804067] [<ffffffff8100d172>] ? default_idle+0x22/0x100
[ 442.804067] [<ffffffff8100daaf>] arch_cpu_idle+0xf/0x20
[ 442.804067] [<ffffffff8109a509>] cpu_startup_entry+0x2c9/0x3c0
[ 442.804067] [<ffffffff810d5ea2>] ? clockevents_register_device+0xe2/0x140
[ 442.804067] [<ffffffff810333c1>] start_secondary+0x141/0x150
[ 442.804067] ---[ end trace 839863d69c70be7a ]---
[ 442.804067] e1000 0000:00:03.0 eth0: Reset adapter
[ 452.716005] NMI watchdog: BUG: soft lockup - CPU#7 stuck for 22s!
[bind-netlink:641]
[ 452.716005] Modules linked in: tipc
[ 452.716005] irq event stamp: 16417
[ 452.716005] hardirqs last enabled at (16416): [<ffffffff81767be0>]
restore_args+0x0/0x30
[ 452.716005] hardirqs last disabled at (16417): [<ffffffff81767eaa>]
apic_timer_interrupt+0x6a/0x80
[ 452.716005] softirqs last enabled at (4280): [<ffffffff8161893f>]
lock_sock_nested+0x4f/0xc0
[ 452.716005] softirqs last disabled at (4282): [<ffffffff8139d51a>]
lock_buckets+0x3a/0x80
[ 452.716005] CPU: 7 PID: 641 Comm: bind-netlink Tainted: G W
3.19.0-rc6+ #185
[ 452.716005] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
[ 452.716005] task: ffff880013f4c220 ti: ffff880014558000 task.ti: ffff880014558000
[ 452.716005] RIP: 0010:[<ffffffff8165d900>] [<ffffffff8165d900>]
netlink_compare+0x10/0x30
[ 452.716005] RSP: 0018:ffff88001455bcf0 EFLAGS: 00000293
[ 452.716005] RAX: 0000000000000000 RBX: 0000000000000004 RCX: 000000000bfbcdfb
[ 452.716005] RDX: 00000000000002ae RSI: ffff88001455bdb8 RDI: ffff88001651b800
[ 452.716005] RBP: ffff88001455bd48 R08: 00000000bef85eb8 R09: ffff880011bf1c68
[ 452.716005] R10: 0000000000000004 R11: 0000000000000001 R12: ffffffff81767be0
[ 452.716005] R13: ffffffff810c2d18 R14: ffff88001455bc58 R15: 0000000000000046
[ 452.716005] FS: 0000000000000000(0000) GS:ffff880017dc0000(0063)
knlGS:00000000f753e900
[ 452.716005] CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b
[ 452.716005] CR2: 00000000f75f8b30 CR3: 0000000015abd000 CR4: 00000000000006e0
[ 452.716005] Stack:
[ 452.716005] ffffffff8139e5ce ffffffff8139e540 000000028105d9c8 00c662f713caac00
[ 452.716005] ffff880013d15200 ffff88001455bd48 ffff880016500000 ffff880013caac00
[ 452.716005] 0000000000000007 ffff880013d15200 ffff880011bf1e08 ffff88001455bda8
[ 452.716005] Call Trace:
[ 452.716005] [<ffffffff8139e5ce>] ? rhashtable_lookup_compare+0x8e/0x120
[ 452.716005] [<ffffffff8139e540>] ? rht_deferred_worker+0xa0/0xa0
[ 452.716005] [<ffffffff8139e72f>] rhashtable_lookup_compare_insert+0x9f/0x110
[ 452.716005] [<ffffffff8139e6c5>] ? rhashtable_lookup_compare_insert+0x35/0x110
[ 452.716005] [<ffffffff8165d8f0>] ? netlink_overrun+0x50/0x50
[ 452.716005] [<ffffffff8165e1d3>] ? netlink_insert+0x43/0xf0
[ 452.716005] [<ffffffff8165e221>] netlink_insert+0x91/0xf0
[ 452.716005] [<ffffffff81660550>] netlink_bind+0x210/0x260
[ 452.716005] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 452.716005] [<ffffffff810a5b10>] ? lock_release_non_nested+0xa0/0x340
[ 452.716005] [<ffffffff81616ce4>] SYSC_bind+0xa4/0xc0
[ 452.716005] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 452.716005] [<ffffffff81616fde>] SyS_bind+0xe/0x10
[ 452.716005] [<ffffffff816523f8>] compat_SyS_socketcall+0xa8/0x200
[ 452.716005] [<ffffffff817693f3>] sysenter_dispatch+0x7/0x1f
[ 452.716005] [<ffffffff8139660e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 452.716005] Code: f0 ff 83 98 01 00 00 48 83 c4 08 5b 5d c3 66 66 66 66 2e 0f
1f 84 00 00 00 00 00 0f 1f 44 00 00 31 c0 8b 56 08 39 97 68 04 00 00 <55> 48 89
e5 74 0a 5d c3 0f 1f 84 00 00 00 00 00 48 8b 47 30 48
[ 480.716005] NMI watchdog: BUG: soft lockup - CPU#7 stuck for 22s!
[bind-netlink:641]
[ 480.716005] Modules linked in: tipc
[ 480.716005] irq event stamp: 30405
[ 480.716005] hardirqs last enabled at (30404): [<ffffffff81767be0>]
restore_args+0x0/0x30
[ 480.716005] hardirqs last disabled at (30405): [<ffffffff81767eaa>]
apic_timer_interrupt+0x6a/0x80
[ 480.716005] softirqs last enabled at (4280): [<ffffffff8161893f>]
lock_sock_nested+0x4f/0xc0
[ 480.716005] softirqs last disabled at (4282): [<ffffffff8139d51a>]
lock_buckets+0x3a/0x80
[ 480.716005] CPU: 7 PID: 641 Comm: bind-netlink Tainted: G W L
3.19.0-rc6+ #185
[ 480.716005] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
[ 480.716005] task: ffff880013f4c220 ti: ffff880014558000 task.ti: ffff880014558000
[ 480.716005] RIP: 0010:[<ffffffff8139e5c1>] [<ffffffff8139e5c1>]
rhashtable_lookup_compare+0x81/0x120
[ 480.716005] RSP: 0018:ffff88001455bcf8 EFLAGS: 00000246
[ 480.716005] RAX: 0000000000000000 RBX: ffffffff81767be0 RCX: 000000000bfbcdfb
[ 480.716005] RDX: 00000000000002ae RSI: ffff88001455bdb8 RDI: ffff88001651b800
[ 480.716005] RBP: ffff88001455bd48 R08: 00000000bef85eb8 R09: ffff880011bf1c68
[ 480.716005] R10: 0000000000000004 R11: 0000000000000001 R12: ffff88001455bc68
[ 480.716005] R13: 0000000000000046 R14: ffff880014558000 R15: ffff880013f4c220
[ 480.716005] FS: 0000000000000000(0000) GS:ffff880017dc0000(0063)
knlGS:00000000f753e900
[ 480.716005] CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b
[ 480.716005] CR2: 00000000f75f8b30 CR3: 0000000015abd000 CR4: 00000000000006e0
[ 480.716005] Stack:
[ 480.716005] ffffffff8139e540 000000028105d9c8 00c662f713caac00 ffff880013d15200
[ 480.716005] ffff88001455bd48 ffff880016500000 ffff880013caac00 0000000000000007
[ 480.716005] ffff880013d15200 ffff880011bf1e08 ffff88001455bda8 ffffffff8139e72f
[ 480.716005] Call Trace:
[ 480.716005] [<ffffffff8139e540>] ? rht_deferred_worker+0xa0/0xa0
[ 480.716005] [<ffffffff8139e72f>] rhashtable_lookup_compare_insert+0x9f/0x110
[ 480.716005] [<ffffffff8139e6c5>] ? rhashtable_lookup_compare_insert+0x35/0x110
[ 480.716005] [<ffffffff8165d8f0>] ? netlink_overrun+0x50/0x50
[ 480.716005] [<ffffffff8165e1d3>] ? netlink_insert+0x43/0xf0
[ 480.716005] [<ffffffff8165e221>] netlink_insert+0x91/0xf0
[ 480.716005] [<ffffffff81660550>] netlink_bind+0x210/0x260
[ 480.716005] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 480.716005] [<ffffffff810a5b10>] ? lock_release_non_nested+0xa0/0x340
[ 480.716005] [<ffffffff81616ce4>] SYSC_bind+0xa4/0xc0
[ 480.716005] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 480.716005] [<ffffffff81616fde>] SyS_bind+0xe/0x10
[ 480.716005] [<ffffffff816523f8>] compat_SyS_socketcall+0xa8/0x200
[ 480.716005] [<ffffffff817693f3>] sysenter_dispatch+0x7/0x1f
[ 480.716005] [<ffffffff8139660e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 480.716005] Code: 73 20 48 89 45 c8 ff 53 60 c1 e8 05 89 45 c4 48 8b 55 c8 48
8b 02 83 e8 01 23 45 c4 48 83 c0 02 4c 8b 74 c2 08 41 f6 c6 01 75 1a <4c> 89 f7
48 2b 7b 30 4c 89 ee 41 ff d4 84 c0 75 46 4d 8b 36 41
[ 488.456005] INFO: rcu_sched self-detected stall on CPU { 7} (t=15000 jiffies
g=472 c=471 q=113)
[ 488.456005] Task dump for CPU 7:
[ 488.456005] bind-netlink R running task 0 641 569 0x20020008
[ 488.456005] 0000000000000239 ffff880017dc3d68 ffffffff81086c26 ffffffff81086b88
[ 488.456005] 000000003b803b7f 0000000000000007 ffffffff81c53940 ffff880017dc3d88
[ 488.456005] ffffffff8108a57f ffffffff81c53940 ffffffff81c53940 ffff880017dc3db8
[ 488.456005] Call Trace:
[ 488.456005] <IRQ> [<ffffffff81086c26>] sched_show_task+0x106/0x170
[ 488.456005] [<ffffffff81086b88>] ? sched_show_task+0x68/0x170
[ 488.456005] [<ffffffff8108a57f>] dump_cpu_task+0x3f/0x50
[ 488.456005] [<ffffffff810bfa7b>] rcu_dump_cpu_stacks+0x8b/0xc0
[ 488.456005] [<ffffffff810c33d0>] rcu_check_callbacks+0x480/0x6d0
[ 488.456005] [<ffffffff810a133d>] ? trace_hardirqs_off+0xd/0x10
[ 488.456005] [<ffffffff810c8408>] update_process_times+0x38/0x70
[ 488.456005] [<ffffffff810d8623>] tick_sched_handle.isra.15+0x33/0x70
[ 488.456005] [<ffffffff810d88cb>] tick_sched_timer+0x4b/0x80
[ 488.456005] [<ffffffff810c8d8b>] __run_hrtimer+0x9b/0x290
[ 488.456005] [<ffffffff810d8880>] ? tick_sched_do_timer+0x40/0x40
[ 488.456005] [<ffffffff810c95e4>] ? hrtimer_interrupt+0x74/0x260
[ 488.456005] [<ffffffff810c9677>] hrtimer_interrupt+0x107/0x260
[ 488.456005] [<ffffffff8165d8f0>] ? netlink_overrun+0x50/0x50
[ 488.456005] [<ffffffff81034cb9>] local_apic_timer_interrupt+0x39/0x60
[ 488.456005] [<ffffffff81769b25>] smp_apic_timer_interrupt+0x45/0x60
[ 488.456005] [<ffffffff81767eaf>] apic_timer_interrupt+0x6f/0x80
[ 488.456005] <EOI> [<ffffffff81767be0>] ? retint_restore_args+0xe/0xe
[ 488.456005] [<ffffffff8165d900>] ? netlink_compare+0x10/0x30
[ 488.456005] [<ffffffff8139e5ce>] ? rhashtable_lookup_compare+0x8e/0x120
[ 488.456005] [<ffffffff8139e540>] ? rht_deferred_worker+0xa0/0xa0
[ 488.456005] [<ffffffff8139e72f>] rhashtable_lookup_compare_insert+0x9f/0x110
[ 488.456005] [<ffffffff8139e6c5>] ? rhashtable_lookup_compare_insert+0x35/0x110
[ 488.456005] [<ffffffff8165d8f0>] ? netlink_overrun+0x50/0x50
[ 488.456005] [<ffffffff8165e1d3>] ? netlink_insert+0x43/0xf0
[ 488.456005] [<ffffffff8165e221>] netlink_insert+0x91/0xf0
[ 488.456005] [<ffffffff81660550>] netlink_bind+0x210/0x260
[ 488.456005] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 488.456005] [<ffffffff810a5b10>] ? lock_release_non_nested+0xa0/0x340
[ 488.456005] [<ffffffff81616ce4>] SYSC_bind+0xa4/0xc0
[ 488.456005] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 488.456005] [<ffffffff81616fde>] SyS_bind+0xe/0x10
[ 488.456005] [<ffffffff816523f8>] compat_SyS_socketcall+0xa8/0x200
[ 488.456005] [<ffffffff817693f3>] sysenter_dispatch+0x7/0x1f
[ 488.456005] [<ffffffff8139660e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 488.468021] INFO: rcu_sched detected stalls on CPUs/tasks: { 7} (detected by
3, t=15005 jiffies, g=472, c=471, q=113)
[ 488.468021] Task dump for CPU 7:
[ 488.468021] bind-netlink R running task 0 641 569 0x20020008
[ 488.468021] 0000000000000000 0000000000000000 ffff88001455bf28 0000000000000002
[ 488.468021] 00000000ff856f80 000000000000000c ffff88001455bf28 ffffffff81616fde
[ 488.468021] ffff88001455bf78 ffffffff816523f8 0000000000000001 ff856f980000002f
[ 488.468021] Call Trace:
[ 488.468021] [<ffffffff81616fde>] ? SyS_bind+0xe/0x10
[ 488.468021] [<ffffffff816523f8>] ? compat_SyS_socketcall+0xa8/0x200
[ 488.468021] [<ffffffff817693f3>] ? sysenter_dispatch+0x7/0x1f
[ 488.468021] [<ffffffff8139660e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 512.716007] NMI watchdog: BUG: soft lockup - CPU#7 stuck for 22s!
[bind-netlink:641]
[ 512.716007] Modules linked in: tipc
[ 512.716007] irq event stamp: 46383
[ 512.716007] hardirqs last enabled at (46382): [<ffffffff81767be0>]
restore_args+0x0/0x30
[ 512.716007] hardirqs last disabled at (46383): [<ffffffff81767eaa>]
apic_timer_interrupt+0x6a/0x80
[ 512.716007] softirqs last enabled at (4280): [<ffffffff8161893f>]
lock_sock_nested+0x4f/0xc0
[ 512.716007] softirqs last disabled at (4282): [<ffffffff8139d51a>]
lock_buckets+0x3a/0x80
[ 512.716007] CPU: 7 PID: 641 Comm: bind-netlink Tainted: G W L
3.19.0-rc6+ #185
[ 512.716007] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
[ 512.716007] task: ffff880013f4c220 ti: ffff880014558000 task.ti: ffff880014558000
[ 512.716007] RIP: 0010:[<ffffffff8165d900>] [<ffffffff8165d900>]
netlink_compare+0x10/0x30
[ 512.716007] RSP: 0018:ffff88001455bcf0 EFLAGS: 00000293
[ 512.716007] RAX: 0000000000000000 RBX: ffffffff81767be0 RCX: 000000000bfbcdfb
[ 512.716007] RDX: 00000000000002ae RSI: ffff88001455bdb8 RDI: ffff88001651b800
[ 512.716007] RBP: ffff88001455bd48 R08: 00000000bef85eb8 R09: ffff880011bf1c68
[ 512.716007] R10: 0000000000000004 R11: 0000000000000001 R12: ffff88001455bc68
[ 512.716007] R13: 0000000000000046 R14: ffff880014558000 R15: ffff880013f4c220
[ 512.716007] FS: 0000000000000000(0000) GS:ffff880017dc0000(0063)
knlGS:00000000f753e900
[ 512.716007] CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b
[ 512.716007] CR2: 00000000f75f8b30 CR3: 0000000015abd000 CR4: 00000000000006e0
[ 512.716007] Stack:
[ 512.716007] ffffffff8139e5ce ffffffff8139e540 000000028105d9c8 00c662f713caac00
[ 512.716007] ffff880013d15200 ffff88001455bd48 ffff880016500000 ffff880013caac00
[ 512.716007] 0000000000000007 ffff880013d15200 ffff880011bf1e08 ffff88001455bda8
[ 512.716007] Call Trace:
[ 512.716007] [<ffffffff8139e5ce>] ? rhashtable_lookup_compare+0x8e/0x120
[ 512.716007] [<ffffffff8139e540>] ? rht_deferred_worker+0xa0/0xa0
[ 512.716007] [<ffffffff8139e72f>] rhashtable_lookup_compare_insert+0x9f/0x110
[ 512.716007] [<ffffffff8139e6c5>] ? rhashtable_lookup_compare_insert+0x35/0x110
[ 512.716007] [<ffffffff8165d8f0>] ? netlink_overrun+0x50/0x50
[ 512.716007] [<ffffffff8165e1d3>] ? netlink_insert+0x43/0xf0
[ 512.716007] [<ffffffff8165e221>] netlink_insert+0x91/0xf0
[ 512.716007] [<ffffffff81660550>] netlink_bind+0x210/0x260
[ 512.716007] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 512.716007] [<ffffffff810a5b10>] ? lock_release_non_nested+0xa0/0x340
[ 512.716007] [<ffffffff81616ce4>] SYSC_bind+0xa4/0xc0
[ 512.716007] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 512.716007] [<ffffffff81616fde>] SyS_bind+0xe/0x10
[ 512.716007] [<ffffffff816523f8>] compat_SyS_socketcall+0xa8/0x200
[ 512.716007] [<ffffffff817693f3>] sysenter_dispatch+0x7/0x1f
[ 512.716007] [<ffffffff8139660e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 512.716007] Code: f0 ff 83 98 01 00 00 48 83 c4 08 5b 5d c3 66 66 66 66 2e 0f
1f 84 00 00 00 00 00 0f 1f 44 00 00 31 c0 8b 56 08 39 97 68 04 00 00 <55> 48 89
e5 74 0a 5d c3 0f 1f 84 00 00 00 00 00 48 8b 47 30 48
[ 540.716005] NMI watchdog: BUG: soft lockup - CPU#7 stuck for 22s!
[bind-netlink:641]
[ 540.716005] Modules linked in: tipc
[ 540.716005] irq event stamp: 60371
[ 540.716005] hardirqs last enabled at (60370): [<ffffffff81767be0>]
restore_args+0x0/0x30
[ 540.716005] hardirqs last disabled at (60371): [<ffffffff81767eaa>]
apic_timer_interrupt+0x6a/0x80
[ 540.716005] softirqs last enabled at (4280): [<ffffffff8161893f>]
lock_sock_nested+0x4f/0xc0
[ 540.716005] softirqs last disabled at (4282): [<ffffffff8139d51a>]
lock_buckets+0x3a/0x80
[ 540.716005] CPU: 7 PID: 641 Comm: bind-netlink Tainted: G W L
3.19.0-rc6+ #185
[ 540.716005] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
[ 540.716005] task: ffff880013f4c220 ti: ffff880014558000 task.ti: ffff880014558000
[ 540.716005] RIP: 0010:[<ffffffff8165d900>] [<ffffffff8165d900>]
netlink_compare+0x10/0x30
[ 540.716005] RSP: 0018:ffff88001455bcf0 EFLAGS: 00000293
[ 540.716005] RAX: 0000000000000000 RBX: ffffffff81767be0 RCX: 000000000bfbcdfb
[ 540.716005] RDX: 00000000000002ae RSI: ffff88001455bdb8 RDI: ffff88001651b800
[ 540.716005] RBP: ffff88001455bd48 R08: 00000000bef85eb8 R09: ffff880011bf1c68
[ 540.716005] R10: 0000000000000004 R11: 0000000000000001 R12: ffff88001455bc68
[ 540.716005] R13: 0000000000000046 R14: ffff880014558000 R15: ffff880013f4c220
[ 540.716005] FS: 0000000000000000(0000) GS:ffff880017dc0000(0063)
knlGS:00000000f753e900
[ 540.716005] CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b
[ 540.716005] CR2: 00000000f75f8b30 CR3: 0000000015abd000 CR4: 00000000000006e0
[ 540.716005] Stack:
[ 540.716005] ffffffff8139e5ce ffffffff8139e540 000000028105d9c8 00c662f713caac00
[ 540.716005] ffff880013d15200 ffff88001455bd48 ffff880016500000 ffff880013caac00
[ 540.716005] 0000000000000007 ffff880013d15200 ffff880011bf1e08 ffff88001455bda8
[ 540.716005] Call Trace:
[ 540.716005] [<ffffffff8139e5ce>] ? rhashtable_lookup_compare+0x8e/0x120
[ 540.716005] [<ffffffff8139e540>] ? rht_deferred_worker+0xa0/0xa0
[ 540.716005] [<ffffffff8139e72f>] rhashtable_lookup_compare_insert+0x9f/0x110
[ 540.716005] [<ffffffff8139e6c5>] ? rhashtable_lookup_compare_insert+0x35/0x110
[ 540.716005] [<ffffffff8165d8f0>] ? netlink_overrun+0x50/0x50
[ 540.716005] [<ffffffff8165e1d3>] ? netlink_insert+0x43/0xf0
[ 540.716005] [<ffffffff8165e221>] netlink_insert+0x91/0xf0
[ 540.716005] [<ffffffff81660550>] netlink_bind+0x210/0x260
[ 540.716005] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 540.716005] [<ffffffff810a5b10>] ? lock_release_non_nested+0xa0/0x340
[ 540.716005] [<ffffffff81616ce4>] SYSC_bind+0xa4/0xc0
[ 540.716005] [<ffffffff81184fc6>] ? might_fault+0x66/0xc0
[ 540.716005] [<ffffffff81616fde>] SyS_bind+0xe/0x10
[ 540.716005] [<ffffffff816523f8>] compat_SyS_socketcall+0xa8/0x200
[ 540.716005] [<ffffffff817693f3>] sysenter_dispatch+0x7/0x1f
[ 540.716005] [<ffffffff8139660e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 540.716005] Code: f0 ff 83 98 01 00 00 48 83 c4 08 5b 5d c3 66 66 66 66 2e 0f
1f 84 00 00 00 00 00 0f 1f 44 00 00 31 c0 8b 56 08 39 97 68 04 00 00 <55> 48 89
e5 74 0a 5d c3 0f 1f 84 00 00 00 00 00 48 8b 47 30
Regards,
Ying
^ permalink raw reply
* [net-next 00/16][pull request] Intel Wired LAN Driver Updates 2015-02-05
From: Jeff Kirsher @ 2015-02-05 9:35 UTC (permalink / raw)
To: davem; +Cc: Jeff Kirsher, netdev, nhorman, sassmann, jogreene
This series contains updates to fm10k, ixgbe and ixgbevf.
Matthew fixes an issue where fm10k does not properly drop the upper-most four
bits on of the VLAN ID due to type promotion, so resolve the issue by not
masking off the bits, but by throwing an error if the VLAN ID is out-of-bounds.
Then cleans up two cases where variables were not being used, but were
being set, so just remove the unused variables.
Don cleans up sparse errors in the x550 family file for ixgbe. Fixed up
a redundant setting of the default value for set_rxpba, which was done
twice accidentally. Cleaned up the probe routine to remove a redundant
attempt to identify the PHY, which could lead to a panic on x550. Added
support for VXLAN receive checksum offload in x550 hardware. Added the
Ethertype Anti-spoofing feature for affected devices.
Emil enables ixgbe and ixgbevf to allow multiple queues in SRIOV mode.
Adds RSS support for x550 per VF. Fixed up a couple of issues introduced
in commit 2b509c0cd292 ("ixgbe: cleanup ixgbe_ndo_set_vf_vlan"), fixed
setting of the VLAN inside ixgbe_enable_port_vlan() and disable the
"hide VLAN" bit in PFQDE when port VLAN is disabled. Cleaned up the
setting of vlan_features by enabling all features at once. Fixed the
ordering of the shutdown patch so that we attempt to shutdown the rings
more gracefully. We shutdown the main Rx filter in the case of Rx and we
set the carrier_off state in the case of Tx so that packets stop being
delivered from outside the driver. Then we shutdown interrupts and NAPI,
then finally stop the rings from performing DMA and clean them. Added
code to allow for Tx hang checking to provide more robust debug info in
the event of a transmit unit hang in ixgbevf. Cleaned up ixgbevf logic
dealing with link up/down by breaking down the link detection and up/down
events into separate functions, similar to how these events are handled
in other drivers. Combined the ixgbevf reset and watchdog tasks into a
single task so that we can avoid multiple schedules of the reset task when
we have a reset event needed due to either the mailbox going down or
transmit packets being present on a link down.
The following are changes since commit db79a621835ee91d3e10177abd97f48e0a4dcf9b:
vxlan: Only set has-GBP bit in header if any other bits would be set
and are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
Don Skidmore (5):
ixgbe: cleanup sparse errors in new ixgbe_x550.c file
ixgbe: cleanup redundant default method set_rxpba
ixgbe: Cleanup probe to remove redundant attempt to ID PHY
ixgbe: add VXLAN offload support for X550 devices
ixgbe: add Tx anti spoofing support
Emil Tantilov (9):
ixgbe: allow multiple queues in SRIOV mode
ixgbevf: enable multiple queue support
ixgbevf: add RSS support for X550
ixgbe: fix setting port VLAN
ixgbevf: set vlan_features in a single write instead of several ORs
ixgbevf: Fix ordering of shutdown to correctly disable Rx and Tx
ixgbevf: Add code to check for Tx hang
ixgbevf: rewrite watchdog task to function similar to igbvf
ixgbevf: combine all of the tasks into a single service task
Matthew Vick (2):
fm10k: Validate VLAN ID in fm10k_update_xc_addr_pf
fm10k: Resolve compile warnings with W=1
drivers/net/ethernet/intel/Kconfig | 11 +
drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 5 +-
drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 7 +-
drivers/net/ethernet/intel/fm10k/fm10k_ptp.c | 3 -
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 3 +
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 112 ++++-
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 16 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 16 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 3 -
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 90 ++--
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 36 +-
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 495 +++++++++++++++-------
drivers/net/ethernet/intel/ixgbevf/regs.h | 10 +
13 files changed, 586 insertions(+), 221 deletions(-)
--
1.9.3
^ permalink raw reply
* [net-next 01/16] fm10k: Validate VLAN ID in fm10k_update_xc_addr_pf
From: Jeff Kirsher @ 2015-02-05 9:35 UTC (permalink / raw)
To: davem; +Cc: Matthew Vick, netdev, nhorman, sassmann, jogreene, Jeff Kirsher
In-Reply-To: <1423128950-12388-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Matthew Vick <matthew.vick@intel.com>
Currently, fm10k_update_xc_addr_pf has an issue where it does not
properly drop the upper-most four bits of the VLAN ID due to type
promotion. Resolve the issue not by masking off the bits, but by
throwing an error if the VLAN ID is out-of-bounds.
Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Matthew Vick <matthew.vick@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c
index 275423d..7e47119 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c
@@ -330,13 +330,10 @@ static s32 fm10k_update_xc_addr_pf(struct fm10k_hw *hw, u16 glort,
struct fm10k_mac_update mac_update;
u32 msg[5];
- /* if glort is not valid return error */
- if (!fm10k_glort_valid_pf(hw, glort))
+ /* if glort or vlan are not valid return error */
+ if (!fm10k_glort_valid_pf(hw, glort) || vid >= FM10K_VLAN_TABLE_VID_MAX)
return FM10K_ERR_PARAM;
- /* drop upper 4 bits of VLAN ID */
- vid = (vid << 4) >> 4;
-
/* record fields */
mac_update.mac_lower = cpu_to_le32(((u32)mac[2] << 24) |
((u32)mac[3] << 16) |
--
1.9.3
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox