* RE: [PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings
From: Fugang Duan @ 2016-05-09 1:57 UTC (permalink / raw)
To: Philippe Reynes, davem@davemloft.net, ben@decadent.org.uk,
kan.liang@intel.com, decot@googlers.com, aduyck@mirantis.com,
jiri@mellanox.com, jacob.e.keller@intel.com, tom@herbertland.com,
andrew@lunn.ch
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <1462743877-31738-1-git-send-email-tremyfr@gmail.com>
Fom: Philippe Reynes <tremyfr@gmail.com> Sent: Monday, May 09, 2016 5:45 AM
> To: Fugang Duan <fugang.duan@nxp.com>; davem@davemloft.net;
> ben@decadent.org.uk; kan.liang@intel.com; decot@googlers.com;
> aduyck@mirantis.com; jiri@mellanox.com; jacob.e.keller@intel.com;
> tom@herbertland.com; andrew@lunn.ch
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Philippe Reynes
> <tremyfr@gmail.com>
> Subject: [PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings
>
> Ethtool callbacks {get|set}_link_ksettings may be the same for many drivers. So
> we add two generics callbacks ethtool_op_{get|set}_link_ksettings.
>
> To use those generics callbacks, the ethernet driver must use the pointer
> phydev contained in struct net_device, and not use a private structure to store
> this pointer.
>
> Changelog:
> v2:
> - use generic function instead of macro
> - ethernet driver use the pointer phydev provided by struct net_device
> Those idea were provided by Ben Hutchings,
> and Florian Fainelli acknowledge them.
>
> Philippe Reynes (3):
> net: core: ethtool: add ethtool_op_{get|set}_link_ksettings
> net: ethernet: fec: use phydev from struct net_device
> net: ethernet: fec: use ethtool_op_{get|set}_link_ksettings
>
> drivers/net/ethernet/freescale/fec.h | 1 -
> drivers/net/ethernet/freescale/fec_main.c | 71 +++++++++--------------------
> include/linux/ethtool.h | 5 ++
> net/core/ethtool.c | 24 ++++++++++
> 4 files changed, 50 insertions(+), 51 deletions(-)
>
> --
> 1.7.4.4
Acked-by: Fugang Duan <fugang.duan@nxp.com>
^ permalink raw reply
* RE: [PATCH net 1/1] net: fec: update dirty_tx even if no skb
From: Fugang Duan @ 2016-05-09 2:00 UTC (permalink / raw)
To: Troy Kisky, netdev@vger.kernel.org, davem@davemloft.net,
lznuaa@gmail.com
Cc: Fabio Estevam, l.stach@pengutronix.de, andrew@lunn.ch,
tremyfr@gmail.com, gerg@uclinux.org,
linux-arm-kernel@lists.infradead.org, johannes@sipsolutions.net,
stillcompiling@gmail.com, sergei.shtylyov@cogentembedded.com,
arnd@arndb.de, holgerschurig@gmail.com
In-Reply-To: <0288eea6-9669-d763-4bd8-9438ce0c1f94@boundarydevices.com>
From: Troy Kisky <troy.kisky@boundarydevices.com> Sent: Sunday, May 08, 2016 2:57 AM
> To: Fugang Duan <fugang.duan@nxp.com>; netdev@vger.kernel.org;
> davem@davemloft.net; lznuaa@gmail.com
> Cc: Fabio Estevam <fabio.estevam@nxp.com>; l.stach@pengutronix.de;
> andrew@lunn.ch; tremyfr@gmail.com; gerg@uclinux.org; linux-arm-
> kernel@lists.infradead.org; johannes@sipsolutions.net;
> stillcompiling@gmail.com; sergei.shtylyov@cogentembedded.com;
> arnd@arndb.de; holgerschurig@gmail.com
> Subject: Re: [PATCH net 1/1] net: fec: update dirty_tx even if no skb
>
> On 4/21/2016 10:59 PM, Fugang Duan wrote:
> > From: Troy Kisky <troy.kisky@boundarydevices.com> Sent: Friday, April
> > 22, 2016 10:01 AM
> >> To: netdev@vger.kernel.org; davem@davemloft.net; Fugang Duan
> >> <fugang.duan@nxp.com>; lznuaa@gmail.com
> >> Cc: Fabio Estevam <fabio.estevam@nxp.com>; l.stach@pengutronix.de;
> >> andrew@lunn.ch; tremyfr@gmail.com; gerg@uclinux.org; linux-arm-
> >> kernel@lists.infradead.org; johannes@sipsolutions.net;
> >> stillcompiling@gmail.com; sergei.shtylyov@cogentembedded.com;
> >> arnd@arndb.de; holgerschurig@gmail.com; Troy Kisky
> >> <troy.kisky@boundarydevices.com>
> >> Subject: [PATCH net 1/1] net: fec: update dirty_tx even if no skb
> >>
> >> If dirty_tx isn't updated, then dma_unmap_single will be called twice.
> >>
> >> This fixes a
> >> [ 58.420980] ------------[ cut here ]------------
> >> [ 58.425667] WARNING: CPU: 0 PID: 377 at /home/schurig/d/mkarm/linux-
> >> 4.5/lib/dma-debug.c:1096 check_unmap+0x9d0/0xab8()
> >> [ 58.436405] fec 2188000.ethernet: DMA-API: device driver tries to free
> DMA
> >> memory it has not allocated [device address=0x0000000000000000]
> >> [size=66 bytes]
> >>
> >> encountered by Holger
> >>
> >> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> >> Tested-by: <holgerschurig@gmail.com>
> >> ---
> >> drivers/net/ethernet/freescale/fec_main.c | 8 +++-----
> >> 1 file changed, 3 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> >> b/drivers/net/ethernet/freescale/fec_main.c
> >> index 08243c2..b71654c 100644
> >> --- a/drivers/net/ethernet/freescale/fec_main.c
> >> +++ b/drivers/net/ethernet/freescale/fec_main.c
> >> @@ -1197,10 +1197,8 @@ fec_enet_tx_queue(struct net_device *ndev,
> u16
> >> queue_id)
> >> fec16_to_cpu(bdp->cbd_datlen),
> >> DMA_TO_DEVICE);
> >> bdp->cbd_bufaddr = cpu_to_fec32(0);
> >> - if (!skb) {
> >> - bdp = fec_enet_get_nextdesc(bdp, &txq->bd);
> >> - continue;
> >> - }
> >> + if (!skb)
> >> + goto skb_done;
> >>
> >> /* Check for errors. */
> >> if (status & (BD_ENET_TX_HB | BD_ENET_TX_LC | @@ -1239,7
> >> +1237,7 @@ fec_enet_tx_queue(struct net_device *ndev, u16 queue_id)
> >>
> >> /* Free the sk buffer associated with this last transmit */
> >> dev_kfree_skb_any(skb);
> >> -
> >> +skb_done:
> >> /* Make sure the update to bdp and tx_skbuff are performed
> >> * before dirty_tx
> >> */
> >> --
> >> 2.5.0
> >
> > The patch is fine for me.
> > Can you review below patch that also fix the issue. It can take much
> > effort due to less rmb() and READ_ONCE() operation that is very
> > sensitive for duplex Gbps test for i.MX6SX/i.MX7d SOC. (i.MX6SX can
> > reach at 1.4Gbps, i.MX7D can reach at 1.8Gbps.)
> >
>
>
> Am I supposed to do anything else to get this patch into net ?
I will ack your patch that is fine into net tree.
^ permalink raw reply
* RE: [PATCH net 1/1] net: fec: update dirty_tx even if no skb
From: Fugang Duan @ 2016-05-09 2:02 UTC (permalink / raw)
To: Troy Kisky, netdev@vger.kernel.org, davem@davemloft.net,
lznuaa@gmail.com
Cc: Fabio Estevam, l.stach@pengutronix.de, andrew@lunn.ch,
tremyfr@gmail.com, gerg@uclinux.org,
linux-arm-kernel@lists.infradead.org, johannes@sipsolutions.net,
stillcompiling@gmail.com, sergei.shtylyov@cogentembedded.com,
arnd@arndb.de, holgerschurig@gmail.com
In-Reply-To: <1461290434-18462-1-git-send-email-troy.kisky@boundarydevices.com>
From: Troy Kisky <troy.kisky@boundarydevices.com> Sent: Friday, April 22, 2016 10:01 AM
> To: netdev@vger.kernel.org; davem@davemloft.net; Fugang Duan
> <fugang.duan@nxp.com>; lznuaa@gmail.com
> Cc: Fabio Estevam <fabio.estevam@nxp.com>; l.stach@pengutronix.de;
> andrew@lunn.ch; tremyfr@gmail.com; gerg@uclinux.org; linux-arm-
> kernel@lists.infradead.org; johannes@sipsolutions.net;
> stillcompiling@gmail.com; sergei.shtylyov@cogentembedded.com;
> arnd@arndb.de; holgerschurig@gmail.com; Troy Kisky
> <troy.kisky@boundarydevices.com>
> Subject: [PATCH net 1/1] net: fec: update dirty_tx even if no skb
>
> If dirty_tx isn't updated, then dma_unmap_single will be called twice.
>
> This fixes a
> [ 58.420980] ------------[ cut here ]------------
> [ 58.425667] WARNING: CPU: 0 PID: 377 at /home/schurig/d/mkarm/linux-
> 4.5/lib/dma-debug.c:1096 check_unmap+0x9d0/0xab8()
> [ 58.436405] fec 2188000.ethernet: DMA-API: device driver tries to free DMA
> memory it has not allocated [device address=0x0000000000000000] [size=66
> bytes]
>
> encountered by Holger
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> Tested-by: <holgerschurig@gmail.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 08243c2..b71654c 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -1197,10 +1197,8 @@ fec_enet_tx_queue(struct net_device *ndev, u16
> queue_id)
> fec16_to_cpu(bdp->cbd_datlen),
> DMA_TO_DEVICE);
> bdp->cbd_bufaddr = cpu_to_fec32(0);
> - if (!skb) {
> - bdp = fec_enet_get_nextdesc(bdp, &txq->bd);
> - continue;
> - }
> + if (!skb)
> + goto skb_done;
>
> /* Check for errors. */
> if (status & (BD_ENET_TX_HB | BD_ENET_TX_LC | @@ -1239,7
> +1237,7 @@ fec_enet_tx_queue(struct net_device *ndev, u16 queue_id)
>
> /* Free the sk buffer associated with this last transmit */
> dev_kfree_skb_any(skb);
> -
> +skb_done:
> /* Make sure the update to bdp and tx_skbuff are performed
> * before dirty_tx
> */
> --
> 2.5.0
Thanks.
Acked-by: Fugang Duan <fugang.duan@nxp.com>
^ permalink raw reply
* CAN YOU ASSIST ME IN THIS FOR BOTH OF OUR MUTUAL BENEFIT?
From: Mr. Hamza Kabore @ 2016-05-09 2:40 UTC (permalink / raw)
--
Dear Friend,
I know that this message will come to you as a surprise. I am the
Auditing and Accounting section manager with African Development Bank,
Ouagadougou Burkina faso. I Hope that you will not expose or betray
this trust and confident that I am about to repose on you for the
mutual benefit of our both families.
I need your urgent assistance in transferring the sum of($39.5)million
to your account within 10 or 14 banking days. This money has been
dormant for years in our Bank without claim.I want the bank to release
the money to you as the nearest person to our deceased customer late
George small. who died along with his supposed next of kin in an air
crash since 31st October 1999.
I don't want the money to go into government treasury as an abandoned
fund. So this is the reason why I am contacting you so that the bank
can release the money to you as the next of kin to the deceased
customer. Please I would like you to keep this proposal as atop secret
and delete it if you are not interested.
Upon receipt of your reply, I will give you full details on how the
business will be executed and also note that you will have 40% of the
above mentioned sum if you agree to handle this business with me.
I am expecting your urgent response as soon as you receive my message.
Best Regard,
Auditor Hamza Kabore.
^ permalink raw reply
* Re: [net-next PATCH v2 1/6] net sched: vlan action fix late binding
From: Cong Wang @ 2016-05-09 3:08 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: David Miller, Linux Kernel Network Developers
In-Reply-To: <1462728392-28489-2-git-send-email-jhs@emojatatu.com>
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c
> index c1682ab..352653f 100644
> --- a/net/sched/act_vlan.c
> +++ b/net/sched/act_vlan.c
> @@ -77,7 +77,7 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
> int action;
> __be16 push_vid = 0;
> __be16 push_proto = 0;
> - int ret = 0;
> + int ret = 0, aexists = 0;
> int err;
>
> if (!nla)
> @@ -90,15 +90,25 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
> if (!tb[TCA_VLAN_PARMS])
> return -EINVAL;
> parm = nla_data(tb[TCA_VLAN_PARMS]);
> + aexists = tcf_hash_check(tn, parm->index, a, bind);
I think 'exists' is a better name than 'aexists', shorter and clear.
> + if (aexists && bind)
> + return 0;
> +
> switch (parm->v_action) {
> case TCA_VLAN_ACT_POP:
> break;
> case TCA_VLAN_ACT_PUSH:
> - if (!tb[TCA_VLAN_PUSH_VLAN_ID])
> + if (!tb[TCA_VLAN_PUSH_VLAN_ID]) {
> + if (aexists)
> + tcf_hash_release(a, bind);
> return -EINVAL;
> + }
> push_vid = nla_get_u16(tb[TCA_VLAN_PUSH_VLAN_ID]);
> - if (push_vid >= VLAN_VID_MASK)
> + if (push_vid >= VLAN_VID_MASK) {
> + if (aexists)
> + tcf_hash_release(a, bind);
> return -ERANGE;
> + }
>
> if (tb[TCA_VLAN_PUSH_VLAN_PROTOCOL]) {
> push_proto = nla_get_be16(tb[TCA_VLAN_PUSH_VLAN_PROTOCOL]);
> @@ -114,11 +124,13 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
> }
> break;
> default:
> + if (aexists)
> + tcf_hash_release(a, bind);
Introduce a goto to reduce duplicated cleanup code?
> return -EINVAL;
> }
> action = parm->v_action;
>
> - if (!tcf_hash_check(tn, parm->index, a, bind)) {
> + if (!aexists) {
> ret = tcf_hash_create(tn, parm->index, est, a,
> sizeof(*v), bind, false);
> if (ret)
> @@ -126,8 +138,6 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
>
> ret = ACT_P_CREATED;
> } else {
> - if (bind)
> - return 0;
> tcf_hash_release(a, bind);
> if (!ovr)
> return -EEXIST;
The rest looks good to me.
^ permalink raw reply
* Re: [net-next PATCH v2 3/6] net sched: mirred action fix late binding
From: Cong Wang @ 2016-05-09 3:19 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: David Miller, Linux Kernel Network Developers
In-Reply-To: <1462728392-28489-4-git-send-email-jhs@emojatatu.com>
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> -static int tcf_mirred_dump(struct sk_buff *skb, struct tc_action *a, int bind, int ref)
> +static int tcf_mirred_dump(struct sk_buff *skb, struct tc_action *a, int bind,
> + int ref)
> {
> unsigned char *b = skb_tail_pointer(skb);
> struct tcf_mirred *m = a->priv;
Nit: this is irrelevant to the bug you fix.
^ permalink raw reply
* Re: [net-next PATCH v2 5/6] net sched: skbedit action fix late binding
From: Cong Wang @ 2016-05-09 3:28 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: David Miller, Linux Kernel Network Developers
In-Reply-To: <1462728392-28489-6-git-send-email-jhs@emojatatu.com>
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
>
> The process below was broken and is fixed with this patch.
>
> //add a skbedit action and give it an instance id of 1
> sudo tc actions add action skbedit mark 10 index 1
> //create a filter which binds to skbedit action id 1
> sudo tc filter add dev $DEV parent ffff: protocol ip prio 1 u32\
> match ip dst 17.0.0.1/32 flowid 1:10 action skbedit index 1
>
> Message before fix was:
> RTNETLINK answers: Invalid argument
> We have an error talking to the kernel
>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
> ---
> net/sched/act_skbedit.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c
> index 51b2499..784b478 100644
> --- a/net/sched/act_skbedit.c
> +++ b/net/sched/act_skbedit.c
> @@ -69,7 +69,7 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla,
> struct tcf_skbedit *d;
> u32 flags = 0, *priority = NULL, *mark = NULL;
> u16 *queue_mapping = NULL;
> - int ret = 0, err;
> + int ret = 0, err, aexists = 0;
>
> if (nla == NULL)
> return -EINVAL;
> @@ -96,12 +96,22 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla,
> mark = nla_data(tb[TCA_SKBEDIT_MARK]);
> }
>
> - if (!flags)
> - return -EINVAL;
> -
> parm = nla_data(tb[TCA_SKBEDIT_PARMS]);
>
> - if (!tcf_hash_check(tn, parm->index, a, bind)) {
> + aexists = tcf_hash_check(tn, parm->index, a, bind);
> +
> + /* if action exists and this is a late filter bind, no need
> + * to continue processing
> + */
This comment looks useless, at least for me, because the code
is already clear.
> + if (aexists && bind)
> + return 0;
One extra tab?
> +
> + if (!flags) {
> + tcf_hash_release(a, bind);
> + return -EINVAL;
> + }
> +
> + if (!aexists) {
> ret = tcf_hash_create(tn, parm->index, est, a,
> sizeof(*d), bind, false);
> if (ret)
> @@ -111,8 +121,6 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla,
> ret = ACT_P_CREATED;
> } else {
> d = to_skbedit(a);
> - if (bind)
> - return 0;
> tcf_hash_release(a, bind);
> if (!ovr)
> return -EEXIST;
> --
> 1.9.1
>
^ permalink raw reply
* Re: [patch] qede: uninitialized variable in qede_start_xmit()
From: David Miller @ 2016-05-09 3:32 UTC (permalink / raw)
To: dan.carpenter
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev, linux-kernel,
kernel-janitors
In-Reply-To: <20160505132130.GE3038@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 5 May 2016 16:21:30 +0300
> "data_split" was never set to false. It's just uninitialized.
>
> Fixes: 2950219d87b0 ('qede: Add basic network device support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply
* Re: [net-next PATCH v2 6/6] net sched: ife action fix late binding
From: Cong Wang @ 2016-05-09 3:32 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: David Miller, Linux Kernel Network Developers
In-Reply-To: <1462728392-28489-7-git-send-email-jhs@emojatatu.com>
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> @@ -689,7 +695,7 @@ static int tcf_ife_encode(struct sk_buff *skb, const struct tc_action *a,
> /*
> OUTERHDR:TOTMETALEN:{TLVHDR:Metadatum:TLVHDR..}:ORIGDATA
> where ORIGDATA = original ethernet header ...
> - */
> + */
Irrelevant to the bug fix.
^ permalink raw reply
* Re: [PATCH] tools: bpf_jit_disasm: check for klogctl failure
From: David Miller @ 2016-05-09 3:33 UTC (permalink / raw)
To: daniel; +Cc: colin.king, netdev, linux-kernel
In-Reply-To: <572BCD60.1000804@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Fri, 06 May 2016 00:46:56 +0200
> On 05/06/2016 12:39 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> klogctl can fail and return -ve len, so check for this and
>> return NULL to avoid passing a (size_t)-1 to malloc.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> [ would be nice to get Cc'ed in future ... ]
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Applied.
^ permalink raw reply
* Re: [PATCH v2] net: arc/emac: Move arc_emac_tx_clean() into arc_emac_tx() and disable tx interrut
From: David Miller @ 2016-05-09 3:42 UTC (permalink / raw)
To: wxt; +Cc: heiko, linux-rockchip, sy.w, al.kochet, netdev, linux-kernel
In-Reply-To: <1462537156-10489-1-git-send-email-wxt@rock-chips.com>
From: Caesar Wang <wxt@rock-chips.com>
Date: Fri, 6 May 2016 20:19:16 +0800
> Doing tx_clean() inside poll() may scramble the tx ring buffer if
> tx() is running. This will cause tx to stop working, which can be
> reproduced by simultaneously downloading two large files at high speed.
>
> Moving tx_clean() into tx() will prevent this. And tx interrupt is no
> longer needed now.
TX completion work is always recommended to be done in the ->poll()
handler.
Fix the race or whatever bug there is rather than working around it,
and regressing the driver, by handling TX completion in the interrupt
handler.
Thanks.
^ permalink raw reply
* Re: [PATCH net] macvtap: segmented packet is consumed
From: David Miller @ 2016-05-09 3:44 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, vyasevic
In-Reply-To: <1462539501.13075.29.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 06 May 2016 05:58:21 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> If GSO packet is segmented and its segments are properly queued,
> we call consume_skb() instead of kfree_skb() to be drop monitor
> friendly.
>
> Fixes: 3e4f8b7873709 ("macvtap: Perform GSO on forwarding path.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Vlad Yasevich <vyasevic@redhat.com>
Applied, thanks Eric.
^ permalink raw reply
* Re: [PATCH v4 1/2] soc: qcom: smd: Introduce compile stubs
From: David Miller @ 2016-05-09 3:47 UTC (permalink / raw)
To: bjorn.andersson; +Cc: andy.gross, linux-kernel, netdev, linux-arm-msm, ccavin
In-Reply-To: <1462543748-29187-1-git-send-email-bjorn.andersson@linaro.org>
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Fri, 6 May 2016 07:09:07 -0700
> Introduce compile stubs for the SMD API, allowing consumers to be
> compile tested.
>
> Acked-by: Andy Gross <andy.gross@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Applied.
^ permalink raw reply
* Re: [PATCH v4 2/2] net: Add Qualcomm IPC router
From: David Miller @ 2016-05-09 3:47 UTC (permalink / raw)
To: bjorn.andersson
Cc: andy.gross, linux-kernel, netdev, linux-arm-msm, ccavin,
courtney.cavin, bjorn.andersson
In-Reply-To: <1462543748-29187-2-git-send-email-bjorn.andersson@linaro.org>
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Fri, 6 May 2016 07:09:08 -0700
> From: Courtney Cavin <courtney.cavin@sonymobile.com>
>
> Add an implementation of Qualcomm's IPC router protocol, used to
> communicate with service providing remote processors.
>
> Signed-off-by: Courtney Cavin <courtney.cavin@sonymobile.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> [bjorn: Cope with 0 being a valid node id and implement RTM_NEWADDR]
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] fq_codel: add memory limitation per queue
From: David Miller @ 2016-05-09 3:49 UTC (permalink / raw)
To: eric.dumazet; +Cc: brouer, dave.taht, netdev, moeller0
In-Reply-To: <1462550112.13075.47.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 06 May 2016 08:55:12 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> On small embedded routers, one wants to control maximal amount of
> memory used by fq_codel, instead of controlling number of packets or
> bytes, since GRO/TSO make these not practical.
>
> Assuming skb->truesize is accurate, we have to keep track of
> skb->truesize sum for skbs in queue.
>
> This patch adds a new TCA_FQ_CODEL_MEMORY_LIMIT attribute.
>
> I chose a default value of 32 MBytes, which looks reasonable even
> for heavy duty usages. (Prior fq_codel users should not be hurt
> when they upgrade their kernels)
>
> Two fields are added to tc_fq_codel_qd_stats to report :
> - Current memory usage
> - Number of drops caused by memory limits
>
> # tc qd replace dev eth1 root est 1sec 4sec fq_codel memory_limit 4M
> ..
> # tc -s -d qd sh dev eth1
> qdisc fq_codel 8008: root refcnt 257 limit 10240p flows 1024
> quantum 1514 target 5.0ms interval 100.0ms memory_limit 4Mb ecn
> Sent 2083566791363 bytes 1376214889 pkt (dropped 4994406, overlimits 0
> requeues 21705223)
> rate 9841Mbit 812549pps backlog 3906120b 376p requeues 21705223
> maxpacket 68130 drop_overlimit 4994406 new_flow_count 28855414
> ecn_mark 0 memory_used 4190048 drop_overmemory 4994406
> new_flows_len 1 old_flows_len 177
>
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
^ permalink raw reply
* Re: [PATCH v2] Documentation/networking: more accurate LCO explanation
From: David Miller @ 2016-05-09 3:55 UTC (permalink / raw)
To: shmulik.ladkani; +Cc: netdev, alexander.duyck, ecree
In-Reply-To: <1462555663-10216-1-git-send-email-shmulik.ladkani@gmail.com>
From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Date: Fri, 6 May 2016 20:27:43 +0300
> In few places the term "ones-complement sum" was used but the actual
> meaning is "the complement of the ones-complement sum".
>
> Also, avoid enclosing long statements with underscore, to ease
> readability.
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
> Acked-by: Edward Cree <ecree@solarflare.com>
Applied.
^ permalink raw reply
* Re: [PATCH v1 1/1] ISDN: eicon: replace custom hex_asc_lo() / hex_pack_byte()
From: David Miller @ 2016-05-09 3:55 UTC (permalink / raw)
To: andriy.shevchenko; +Cc: mac, netdev
In-Reply-To: <1462557323-102678-1-git-send-email-andriy.shevchenko@linux.intel.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Fri, 6 May 2016 20:55:23 +0300
> Instead of custom approach re-use generic helpers to convert byte to hex
> format.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: make sch_handle_ingress() drop monitor ready
From: David Miller @ 2016-05-09 3:55 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, jhs
In-Reply-To: <1462575350.13075.60.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 06 May 2016 15:55:50 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> TC_ACT_STOLEN is used when ingress traffic is mirred/redirected
> to say ifb.
>
> Packet is not dropped, but consumed.
>
> Only TC_ACT_SHOT is a clear indication something went wrong.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Applied.
^ permalink raw reply
* Re: [PATCH 0/2] Quiet noisy LSM denial when accessing net sysctl
From: David Miller @ 2016-05-09 3:56 UTC (permalink / raw)
To: tyhicks; +Cc: linux-security-module, netdev, linux-kernel, serge.hallyn
In-Reply-To: <1462575854-4301-1-git-send-email-tyhicks@canonical.com>
From: Tyler Hicks <tyhicks@canonical.com>
Date: Fri, 6 May 2016 18:04:12 -0500
> This pair of patches does away with what I believe is a useless denial
> audit message when a privileged process initially accesses a net sysctl.
The LSM folks can apply this if they agree with you.
^ permalink raw reply
* Re: [PATCH v2 net-next] ifb: support more features
From: David Miller @ 2016-05-09 4:01 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1462583999.13075.67.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 06 May 2016 18:19:59 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> When using ifb+netem on ingress on SIT/IPIP/GRE traffic,
> GRO packets are not properly processed.
>
> Segmentation should not be forced, since ifb is already adding
> quite a performance hit.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] tcp: replace cnt & rtt with struct in pkts_acked()
From: David Miller @ 2016-05-09 4:02 UTC (permalink / raw)
To: brakmo; +Cc: netdev, kernel-team, ncardwell, eric.dumazet, ycheng
In-Reply-To: <1462591714-1892853-1-git-send-email-brakmo@fb.com>
From: Lawrence Brakmo <brakmo@fb.com>
Date: Fri, 6 May 2016 20:28:34 -0700
> + if (icsk->icsk_ca_ops->pkts_acked) {
> + struct ack_sample sample = {pkts_acked, ca_rtt_us};
Please use named initializers.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next] tcp: refactor struct tcp_skb_cb
From: David Miller @ 2016-05-09 4:06 UTC (permalink / raw)
To: brakmo; +Cc: netdev, kernel-team, ncardwell, eric.dumazet, ycheng
In-Reply-To: <1462592135-1905403-1-git-send-email-brakmo@fb.com>
From: Lawrence Brakmo <brakmo@fb.com>
Date: Fri, 6 May 2016 20:35:35 -0700
> Refactor tcp_skb_cb to create two overlaping areas to store
> state for incoming or outgoing skbs based on comments by
> Neal Cardwell to tcp_nv patch:
>
> AFAICT this patch would not require an increase in the size of
> sk_buff cb[] if it were to take advantage of the fact that the
> tcp_skb_cb header.h4 and header.h6 fields are only used in the packet
> reception code path, and this in_flight field is only used on the
> transmit side.
>
> Signed-off-by: Lawrence Brakmo <brakmo@fb.com>
> Acked-by: Yuchung Cheng <ycheng@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] macsec: key identifier is 128 bits, not 64
From: David Miller @ 2016-05-09 4:09 UTC (permalink / raw)
To: sd; +Cc: netdev, hannes
In-Reply-To: <a4f37c780ee1a5c368662bb389274995b2b51dbc.1462644509.git.sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Sat, 7 May 2016 20:19:29 +0200
> The MACsec standard mentions a key identifier for each key, but
> doesn't specify anything about it, so I arbitrarily chose 64 bits.
>
> IEEE 802.1X-2010 specifies MKA (MACsec Key Agreement), and defines the
> key identifier to be 128 bits (96 bits "member identifier" + 32 bits
> "key number").
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied.
^ permalink raw reply
* Re: pull request: bluetooth-next 2016-05-07
From: David Miller @ 2016-05-09 4:10 UTC (permalink / raw)
To: johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20160507185623.GA18557-ae+CCJ+dGXjCW7GOcxkI+ioyn5ZhHHrn@public.gmane.org>
From: Johan Hedberg <johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Sat, 7 May 2016 21:56:23 +0300
> Here are a few more Bluetooth patches for the 4.7 kernel:
>
> - NULL pointer fix in hci_intel driver
> - New Intel Bluetooth controller id in btusb driver
> - Added device tree binding documentation for Marvel's bt-sd8xxx
> - Platform specific wakeup interrupt support for btmrvl driver
>
> Please let me know if there are any issues pulling. Thanks.
Pulled, thanks.
^ permalink raw reply
* Re: [PATCH net-next] fq_codel: add memory limitation per queue
From: Cong Wang @ 2016-05-09 4:14 UTC (permalink / raw)
To: Eric Dumazet
Cc: David Miller, Jesper Dangaard Brouer, Dave Täht, netdev,
moeller0
In-Reply-To: <1462550112.13075.47.camel@edumazet-glaptop3.roam.corp.google.com>
On Fri, May 6, 2016 at 8:55 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> @@ -193,6 +199,7 @@ static int fq_codel_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> unsigned int idx, prev_backlog, prev_qlen;
> struct fq_codel_flow *flow;
> int uninitialized_var(ret);
> + bool memory_limited;
>
> idx = fq_codel_classify(skb, sch, &ret);
> if (idx == 0) {
> @@ -215,7 +222,9 @@ static int fq_codel_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> flow->deficit = q->quantum;
> flow->dropped = 0;
> }
> - if (++sch->q.qlen <= sch->limit)
> + q->memory_usage += skb->truesize;
> + memory_limited = q->memory_usage > q->memory_limit;
> + if (++sch->q.qlen <= sch->limit && !memory_limited)
> return NET_XMIT_SUCCESS;
>
> prev_backlog = sch->qstats.backlog;
> @@ -229,7 +238,8 @@ static int fq_codel_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> ret = fq_codel_drop(sch, q->drop_batch_size);
>
> q->drop_overlimit += prev_qlen - sch->q.qlen;
> -
> + if (memory_limited)
> + q->drop_overmemory += prev_qlen - sch->q.qlen;
So when the packet is dropped due to memory over limit, should
we return failure for this case? Or I miss anything?
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox