* RE: [PATCH net-next v2 0/3] net: ethernet: mediatek: add HW LRO functions
From: Nelson Chang @ 2016-09-17 15:50 UTC (permalink / raw)
To: davem; +Cc: john, f.fainelli, nbd, netdev, linux-mediatek, nelsonch.tw
Thanks David!
I'll respin the patch and submit the newer version.
-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Saturday, September 17, 2016 9:46 PM
To: Nelson Chang (張家祥)
Cc: john@phrozen.org; f.fainelli@gmail.com; nbd@openwrt.org;
netdev@vger.kernel.org; linux-mediatek@lists.infradead.org;
nelsonch.tw@gmail.com
Subject: Re: [PATCH net-next v2 0/3] net: ethernet: mediatek: add HW LRO
functions
From: Nelson Chang <nelson.chang@mediatek.com>
Date: Wed, 14 Sep 2016 13:58:56 +0800
> The series add the large receive offload (LRO) functions by hardware
> and the ethtool functions to configure RX flows of HW LRO.
>
> changes since v2:
> - Add ndo_fix_features to prevent NETIF_F_LRO off while RX flow is
> programmed
> - Rephrase the dts property is a capability if the hardware supports
> LRO
>
> changes since v1:
> - Add HW LRO support
> - Add ethtool hooks to set LRO RX flows
This doesn't apply cleanly to net-next.
^ permalink raw reply
* [net PATCH V3] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full
From: Jesper Dangaard Brouer @ 2016-09-17 15:48 UTC (permalink / raw)
To: netdev, tariqt
Cc: tom, bblanco, rana.shahot, David S. Miller,
Jesper Dangaard Brouer
In-Reply-To: <20160917164650.53e68314@redhat.com>
The XDP_TX action can fail transmitting the frame in case the TX ring
is full or port is down. In case of TX failure it should drop the
frame, and not as now call 'break' which is the same as XDP_PASS.
Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
Is this goto lable inside a switch case too ugly?
Note, this fix have nothing to do with the page-refcnt bug I reported.
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 2040dad8611d..9eadda431965 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -906,11 +906,12 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
length, tx_index,
&doorbell_pending))
goto consumed;
- break;
+ goto xdp_drop; /* Drop on xmit failure */
default:
bpf_warn_invalid_xdp_action(act);
case XDP_ABORTED:
case XDP_DROP:
+ xdp_drop:
if (mlx4_en_rx_recycle(ring, frags))
goto consumed;
goto next;
^ permalink raw reply related
* Your (Email Address) Outlook exceeded
From: Kaitlin Schneekloth @ 2016-09-17 15:37 UTC (permalink / raw)
Your (Email Address) Outlook exceeded its storage limit. https://docs.google.com/forms/d/e/1FAIpQLSdtc96pXFgZ5LIOEaRYQaBOvX0ae7kS_RpTukKOq7eI4RASQw/viewform (FILL) and Click on Submit to get more space or you wont be able to send Mail.
^ permalink raw reply
* Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full
From: Jesper Dangaard Brouer @ 2016-09-17 14:46 UTC (permalink / raw)
To: Brenden Blanco
Cc: brouer, netdev, tariqt, Eric Dumazet, tom, rana.shahot,
David S. Miller
In-Reply-To: <20160916204350.GA20076@gmail.com>
On Fri, 16 Sep 2016 13:43:50 -0700
Brenden Blanco <bblanco@plumgrid.com> wrote:
> On Fri, Sep 16, 2016 at 10:36:12PM +0200, Jesper Dangaard Brouer wrote:
> > The XDP_TX action can fail transmitting the frame in case the TX ring
> > is full or port is down. In case of TX failure it should drop the
> > frame, and not as now call 'break' which is the same as XDP_PASS.
> >
> > Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support")
> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
>
> You could in theory have also tried to recycle the page instead of
> dropping it, but that's probably not worth optimizing when tx is backed
> up, as you'll only save a handful of page_put's. The code to do so
> wouldn't have been pretty.
Yes, we could (and perhaps should) recycle the page instead. But as you
also mention it would not look pretty. I'll send a V3, as XDPs primary
concern is performance.
> Reviewed-by: Brenden Blanco <bblanco@plumgrid.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply
* Re: [PATCH net-next 0/4] ip_tunnel: add collect_md mode to IPv4/IPv6 tunnels
From: David Miller @ 2016-09-17 14:13 UTC (permalink / raw)
To: ast; +Cc: daniel, tgraf, netdev, kernel-team
In-Reply-To: <1473969632-2408261-1-git-send-email-ast@fb.com>
From: Alexei Starovoitov <ast@fb.com>
Date: Thu, 15 Sep 2016 13:00:28 -0700
> Similar to geneve, vxlan, gre tunnels implement 'collect metadata' mode
> in ipip, ipip6, ip6ip6 tunnels.
Series applied, thanks.
^ permalink raw reply
* Re: [PATCH 0/3] constify net_device_ops structures
From: David Miller @ 2016-09-17 14:07 UTC (permalink / raw)
To: Julia.Lawall; +Cc: linux-kernel, kernel-janitors, netdev
In-Reply-To: <1473971006-2074-1-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Thu, 15 Sep 2016 22:23:23 +0200
> Constify net_device_ops structures.
All applied, thanks.
^ permalink raw reply
* Re: [PATCH] llc: switch type to bool as the timeout is only tested versus 0
From: David Miller @ 2016-09-17 14:05 UTC (permalink / raw)
To: alan; +Cc: netdev
In-Reply-To: <147396186808.57417.10184810920101482487.stgit@localhost.localdomain>
From: Alan <alan@linux.intel.com>
Date: Thu, 15 Sep 2016 18:51:25 +0100
> (As asked by Dave in Februrary)
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: l3mdev: Remove netif_index_is_l3_master
From: David Miller @ 2016-09-17 14:05 UTC (permalink / raw)
To: dsa; +Cc: netdev
In-Reply-To: <1473959925-22881-1-git-send-email-dsa@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Thu, 15 Sep 2016 10:18:45 -0700
> No longer used after e0d56fdd73422 ("net: l3mdev: remove redundant calls")
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: vrf: Remove RT_FL_TOS
From: David Miller @ 2016-09-17 14:05 UTC (permalink / raw)
To: dsa; +Cc: netdev
In-Reply-To: <1473959627-5268-1-git-send-email-dsa@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Thu, 15 Sep 2016 10:13:47 -0700
> No longer used after d66f6c0a8f3c0 ("net: ipv4: Remove l3mdev_get_saddr")
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] tcp: prepare skbs for better sack shifting
From: David Miller @ 2016-09-17 14:05 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, ycheng
In-Reply-To: <1473957182.22679.50.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 15 Sep 2016 09:33:02 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> With large BDP TCP flows and lossy networks, it is very important
> to keep a low number of skbs in the write queue.
>
> RACK and SACK processing can perform a linear scan of it.
>
> We should avoid putting any payload in skb->head, so that SACK
> shifting can be done if needed.
>
> With this patch, we allow to pack ~0.5 MB per skb instead of
> the 64KB initially cooked at tcp_sendmsg() time.
>
> This gives a reduction of number of skbs in write queue by eight.
> tcp_rack_detect_loss() likes this.
>
> We still allow payload in skb->head for first skb put in the queue,
> to not impact RPC workloads.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] sctp: fix SSN comparision
From: David Miller @ 2016-09-17 14:00 UTC (permalink / raw)
To: marcelo.leitner; +Cc: netdev, linux-sctp, nhorman, vyasevich
In-Reply-To: <9f22e4725d836feda1b2c2483303adb30838216f.1473962178.git.marcelo.leitner@gmail.com>
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Thu, 15 Sep 2016 15:02:38 -0300
> This function actually operates on u32 yet its paramteres were declared
> as u16, causing integer truncation upon calling.
>
> Note in patch context that ADDIP_SERIAL_SIGN_BIT is already 32 bits.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] irda: Free skb on irda_accept error path.
From: David Miller @ 2016-09-17 14:00 UTC (permalink / raw)
To: phil.turnbull; +Cc: netdev, samuel
In-Reply-To: <20160915164144.24472-1-phil.turnbull@oracle.com>
From: Phil Turnbull <phil.turnbull@oracle.com>
Date: Thu, 15 Sep 2016 12:41:44 -0400
> skb is not freed if newsk is NULL. Rework the error path so free_skb is
> unconditionally called on function exit.
>
> Fixes: c3ea9fa27413 ("[IrDA] af_irda: IRDA_ASSERT cleanups")
> Signed-off-by: Phil Turnbull <phil.turnbull@oracle.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] net: avoid sk_forward_alloc overflows
From: David Miller @ 2016-09-17 14:00 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1473954526.22679.38.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 15 Sep 2016 08:48:46 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> A malicious TCP receiver, sending SACK, can force the sender to split
> skbs in write queue and increase its memory usage.
>
> Then, when socket is closed and its write queue purged, we might
> overflow sk_forward_alloc (It becomes negative)
>
> sk_mem_reclaim() does nothing in this case, and more than 2GB
> are leaked from TCP perspective (tcp_memory_allocated is not changed)
>
> Then warnings trigger from inet_sock_destruct() and
> sk_stream_kill_queues() seeing a not zero sk_forward_alloc
>
> All TCP stack can be stuck because TCP is under memory pressure.
>
> A simple fix is to preemptively reclaim from sk_mem_uncharge().
>
> This makes sure a socket wont have more than 2 MB forward allocated,
> after burst and idle period.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] tcp: fix overflow in __tcp_retransmit_skb()
From: David Miller @ 2016-09-17 14:00 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1473952353.22679.25.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 15 Sep 2016 08:12:33 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> If a TCP socket gets a large write queue, an overflow can happen
> in a test in __tcp_retransmit_skb() preventing all retransmits.
>
> The flow then stalls and resets after timeouts.
>
> Tested:
>
> sysctl -w net.core.wmem_max=1000000000
> netperf -H dest -- -s 1000000000
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH v2] xen-netback: fix error handling on netback_probe()
From: David Miller @ 2016-09-17 13:56 UTC (permalink / raw)
To: filipe.manco; +Cc: netdev, wei.liu2, xen-devel
In-Reply-To: <1473952246-27037-1-git-send-email-filipe.manco@neclab.eu>
From: Filipe Manco <filipe.manco@neclab.eu>
Date: Thu, 15 Sep 2016 17:10:46 +0200
> In case of error during netback_probe() (e.g. an entry missing on the
> xenstore) netback_remove() is called on the new device, which will set
> the device backend state to XenbusStateClosed by calling
> set_backend_state(). However, the backend state wasn't initialized by
> netback_probe() at this point, which will cause and invalid transaction
> and set_backend_state() to BUG().
>
> Initialize the backend state at the beginning of netback_probe() to
> XenbusStateInitialising, and create two new valid state transitions on
> set_backend_state(), from XenbusStateInitialising to XenbusStateClosed,
> and from XenbusStateInitialising to XenbusStateInitWait.
>
> Signed-off-by: Filipe Manco <filipe.manco@neclab.eu>
Applied, thanks.
^ permalink raw reply
* Re: pull-request: wireless-drivers-next 2016-09-15
From: David Miller @ 2016-09-17 13:54 UTC (permalink / raw)
To: kvalo-sgV2jX0FEOL9JmXXK+q4OQ
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <87zin99p3y.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Date: Thu, 15 Sep 2016 18:09:21 +0300
> here's the first pull request for 4.9. The ones I want to point out are
> the FIELD_PREP() and FIELD_GET() macros added to bitfield.h, which are
> reviewed by Linus, and make it possible to remove util.h from mt7601u.
>
> Also we have new HW support to various drivers and other smaller
> features, the signed tag below contains more information. And I pulled
> my ath-current (uses older net tree as the baseline) branch to fix a
> conflict in ath10k.
>
> Once again the diffstat from git request-pull was wrong. I fixed it by
> manually copying the diffstat from a test pull against net-next, so
> everything should be ok. But please let me know if there are any
> problems.
Pulled, thanks Kalle.
^ permalink raw reply
* Re: [PATCH net-next 0/3] mlx5e Order-0 pages for Striding RQ
From: David Miller @ 2016-09-17 13:52 UTC (permalink / raw)
To: tariqt; +Cc: netdev, eranbe, saeedm
In-Reply-To: <1473944918-31290-1-git-send-email-tariqt@mellanox.com>
From: Tariq Toukan <tariqt@mellanox.com>
Date: Thu, 15 Sep 2016 16:08:35 +0300
> In this series, we refactor our Striding RQ receive-flow to always use
> fragmented WQEs (Work Queue Elements) using order-0 pages, omitting the
> flow that allocates and splits high-order pages which would fragment
> and deplete high-order pages in the system.
>
> The first patch gives a slight degradation, but opens the opportunity
> to using a simple page-cache mechanism of a fair size.
> The page-cache, implemented in patch 3, not only closes the performance
> gap but even gives a gain.
> In patch 2 we re-organize the code to better manage the calls for
> alloc/de-alloc pages in the RX flow.
>
> Series generated against net-next commit:
> bed806cb266e "Merge branch 'mlxsw-ethtool'"
Series applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next v2 0/3] net: ethernet: mediatek: add HW LRO functions
From: David Miller @ 2016-09-17 13:46 UTC (permalink / raw)
To: nelson.chang; +Cc: john, f.fainelli, nbd, netdev, linux-mediatek, nelsonch.tw
In-Reply-To: <1473832739-4983-1-git-send-email-nelson.chang@mediatek.com>
From: Nelson Chang <nelson.chang@mediatek.com>
Date: Wed, 14 Sep 2016 13:58:56 +0800
> The series add the large receive offload (LRO) functions by hardware and
> the ethtool functions to configure RX flows of HW LRO.
>
> changes since v2:
> - Add ndo_fix_features to prevent NETIF_F_LRO off while RX flow is programmed
> - Rephrase the dts property is a capability if the hardware supports LRO
>
> changes since v1:
> - Add HW LRO support
> - Add ethtool hooks to set LRO RX flows
This doesn't apply cleanly to net-next.
^ permalink raw reply
* Re: [PATCH net-next 2/2] net sched ife action: Introduce skb tcindex metadata encap decap
From: David Miller @ 2016-09-17 13:43 UTC (permalink / raw)
To: jhs; +Cc: daniel, xiyou.wangcong, netdev
In-Reply-To: <1473936594-5152-2-git-send-email-jhs@emojatatu.com>
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Thu, 15 Sep 2016 06:49:54 -0400
> +static int __init ifetc_index_init_module(void)
> +{
> + pr_emerg("Loaded IFE tc_index\n");
...
> +static void __exit ifetc_index_cleanup_module(void)
> +{
> + pr_emerg("Unloaded IFE tc_index\n");
This looks like some leftover debugging, please remove.
^ permalink raw reply
* Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support
From: Maxime Ripard @ 2016-09-17 13:40 UTC (permalink / raw)
To: LABBE Corentin
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
wens-jdAy2FN1RRM, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
davem-fT/PcQaiUtIeIZ0/mPfg9Q, netdev-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20160914140304.GA27639@Red>
[-- Attachment #1: Type: text/plain, Size: 2980 bytes --]
On Wed, Sep 14, 2016 at 04:03:04PM +0200, LABBE Corentin wrote:
> > > +static int __maybe_unused sun8i_emac_suspend(struct platform_device *pdev, pm_message_t state)
> > > +{
> > > + struct net_device *ndev = platform_get_drvdata(pdev);
> > > + struct sun8i_emac_priv *priv = netdev_priv(ndev);
> > > +
> > > + napi_disable(&priv->napi);
> > > +
> > > + if (netif_running(ndev))
> > > + netif_device_detach(ndev);
> > > +
> > > + sun8i_emac_stop_tx(ndev);
> > > + sun8i_emac_stop_rx(ndev);
> > > +
> > > + sun8i_emac_rx_clean(ndev);
> > > + sun8i_emac_tx_clean(ndev);
> > > +
> > > + phy_stop(ndev->phydev);
> > > +
> > > + return 0;
> > > +}
> > > +
> > > +static int __maybe_unused sun8i_emac_resume(struct platform_device *pdev)
> > > +{
> > > + struct net_device *ndev = platform_get_drvdata(pdev);
> > > + struct sun8i_emac_priv *priv = netdev_priv(ndev);
> > > +
> > > + phy_start(ndev->phydev);
> > > +
> > > + sun8i_emac_start_tx(ndev);
> > > + sun8i_emac_start_rx(ndev);
> > > +
> > > + if (netif_running(ndev))
> > > + netif_device_attach(ndev);
> > > +
> > > + netif_start_queue(ndev);
> > > +
> > > + napi_enable(&priv->napi);
> > > +
> > > + return 0;
> > > +}
> >
> > The main idea behind the runtime PM hooks is that they bring the
> > device to a working state and shuts it down when it's not needed
> > anymore.
Indeed.
> I expect that the first part (all pm_runtime_xxx) of the patch bring that.
> When the interface is not opened:
> cat /sys/devices/platform/soc/1c30000.ethernet/power/runtime_status
> suspended
>
> > However, they shouldn't be called when the device is still in used, so
> > all the mangling with NAPI, the phy and so on is irrelevant here, but
> > the clocks, resets, for example, are.
> >
>
> I do the same as other ethernet driver for suspend/resume.
suspend / resume are used when you put the whole system into suspend,
and bring it back.
runtime_pm is only when the device is not used anymore. It makes sense
when you suspend to do whatever you're doing here. It doesn't make any
when the system is not suspended, but the device is.
> > > static const struct of_device_id sun8i_emac_of_match_table[] = {
> > > { .compatible = "allwinner,sun8i-a83t-emac",
> > > .data = &emac_variant_a83t },
> > > @@ -2246,6 +2302,8 @@ static struct platform_driver sun8i_emac_driver = {
> > > .name = "sun8i-emac",
> > > .of_match_table = sun8i_emac_of_match_table,
> > > },
> > > + .suspend = sun8i_emac_suspend,
> > > + .resume = sun8i_emac_resume,
> >
> > These are not the runtime PM hooks. How did you test that?
> >
>
> Anyway I didnt test suspend/resume so I will remove it until I
> successfully found how to hibernate my board.
So you submit code you never tested? That's usually a recipe for
disaster.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* Re: [PATCH net-next 05/14] tcp: track data delivery rate for a TCP connection
From: Neal Cardwell @ 2016-09-17 12:09 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, David Miller, Netdev, Yuchung Cheng, Van Jacobson,
Nandita Dukkipati, Eric Dumazet, Soheil Hassas Yeganeh
In-Reply-To: <201609170509.mUNO6Hq1%fengguang.wu@intel.com>
On Fri, Sep 16, 2016 at 5:38 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Yuchung,
>
> [auto build test WARNING on net-next/master]
> All warnings (new ones prefixed by >>):
>
> In file included from net/ipv4/route.c:103:0:
>>> include/net/tcp.h:769:11: warning: 'packed' attribute ignored for field of type 'struct skb_mstamp' [-Wattributes]
> struct skb_mstamp first_tx_mstamp __packed;
> ^~~~~~~~~~
> include/net/tcp.h:771:11: warning: 'packed' attribute ignored for field of type 'struct skb_mstamp' [-Wattributes]
> struct skb_mstamp delivered_mstamp __packed;
> ^~~~~~~~~~
We have a fix for this, and we'll post it with the v2 series.
thanks,
neal
^ permalink raw reply
* Re: [patch net-next v10 2/3] net: core: Add offload stats to if_stats_msg
From: Nikolay Aleksandrov @ 2016-09-17 10:55 UTC (permalink / raw)
To: Jiri Pirko
Cc: Linux Kernel Network Developers, davem, nogahf, idosch, eladr,
yotamg, ogerlitz, roopa, linville, tgraf, gospo, sfeldma, sd,
eranbe, ast, edumazet, hannes, f.fainelli, dsa
In-Reply-To: <1474031138-2065-3-git-send-email-jiri@resnulli.us>
> On Sep 16, 2016, at 4:05 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>
> From: Nogah Frankel <nogahf@mellanox.com>
>
> Add a nested attribute of offload stats to if_stats_msg
> named IFLA_STATS_LINK_OFFLOAD_XSTATS.
> Under it, add SW stats, meaning stats only per packets that went via
> slowpath to the cpu, named IFLA_OFFLOAD_XSTATS_CPU_HIT.
>
> Signed-off-by: Nogah Frankel <nogahf@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> include/uapi/linux/if_link.h | 9 ++++
> net/core/rtnetlink.c | 111 +++++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 116 insertions(+), 4 deletions(-)
>
>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
^ permalink raw reply
* Re: [patch net-next v10 1/3] netdevice: Add offload statistics ndo
From: Nikolay Aleksandrov @ 2016-09-17 10:50 UTC (permalink / raw)
To: Jiri Pirko
Cc: Linux Kernel Network Developers, David S. Miller, nogahf,
Ido Schimmel, eladr, yotamg, ogerlitz, Roopa Prabhu, linville,
tgraf, Andy Gospodarek, sfeldma, sd, eranbe, ast, edumazet,
hannes, f.fainelli, dsa
In-Reply-To: <1474031138-2065-2-git-send-email-jiri@resnulli.us>
> On Sep 16, 2016, at 4:05 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>
> From: Nogah Frankel <nogahf@mellanox.com>
>
> Add a new ndo to return statistics for offloaded operation.
> Since there can be many different offloaded operation with many
> stats types, the ndo gets an attribute id by which it knows which
> stats are wanted. The ndo also gets a void pointer to be cast according
> to the attribute id.
>
> Signed-off-by: Nogah Frankel <nogahf@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> include/linux/netdevice.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
^ permalink raw reply
* Re: [PATCH net-next v2 3/5] cxgb4: add parser to translate u32 filters to internal spec
From: Rahul Lakkireddy @ 2016-09-17 8:40 UTC (permalink / raw)
To: John Fastabend; +Cc: netdev, davem, hariprasad, leedom, nirranjan, indranil
In-Reply-To: <57DAAFCC.8000207@gmail.com>
On Thursday, September 09/15/16, 2016 at 07:27:24 -0700, John Fastabend wrote:
> On 16-09-13 04:42 AM, Rahul Lakkireddy wrote:
> > Parse information sent by u32 into internal filter specification.
> > Add support for parsing several fields in IPv4, IPv6, TCP, and UDP.
> >
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> > Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
> > ---
>
> Looks good to me. Also curious if you would find it worthwhile to
> have a cls_u32 mode that starts at L2 instead of the IP header? The
> use case would be to use cls_u32 with various encapsulation protocols
> in front of the IP header.
>
> Reviewed-by: John Fastabend <john.r.fastabend@intel.com>
Thanks for the review John. Yes, we are also looking for getting u32
to start from L2 header in order to allow matching encapsulation
protocols in front of IP header.
In addition, our hardware also keeps track of per-filter statistics
such as number of times the filter has been hit and number of bytes
that hit the filter. Hence, we are also looking for exposing these
per-filter stats to u32.
Thanks,
Rahul
^ permalink raw reply
* Re: [PATCH net-next] rxrpc: Make IPv6 support conditional on CONFIG_IPV6
From: David Miller @ 2016-09-17 7:59 UTC (permalink / raw)
To: dhowells; +Cc: netdev, linux-afs, linux-kernel
In-Reply-To: <147409356125.30214.18028040340873709660.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Sat, 17 Sep 2016 07:26:01 +0100
> Add CONFIG_AF_RXRPC_IPV6 and make the IPv6 support code conditional on it.
> This is then made conditional on CONFIG_IPV6.
>
> Without this, the following can be seen:
>
> net/built-in.o: In function `rxrpc_init_peer':
>>> peer_object.c:(.text+0x18c3c8): undefined reference to `ip6_route_output_flags'
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox