* [PATCH net-next] firewire: net: really fix maximum possible MTU
From: Stefan Richter @ 2016-10-29 20:16 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux1394-devel, Jarod Wilson, linux-kernel
In-Reply-To: <20161023163056.6bc38610@kant>
The maximum unicast datagram size /without/ link fragmentation is
4096 - 4 = 4092 (max IEEE 1394 async payload size at >= S800 bus speed,
minus unfragmented encapssulation header). Max broadcast datagram size
without fragmentation is 8 bytes less than that (due to GASP header).
The maximum datagram size /with/ link fragmentation is 0xfff = 4095
for unicast and broadcast. This is because the RFC 2734 fragment
encapsulation header field for datagram size is only 12 bits wide.
Fixes: 5d48f00d836a('firewire: net: fix maximum possible MTU')
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 03715e7d9d92..363fc5ec1a4e 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -1465,7 +1465,7 @@ static int fwnet_probe(struct fw_unit *unit,
net->mtu = 1500U;
net->min_mtu = ETH_MIN_MTU;
- net->max_mtu = ETH_MAX_MTU;
+ net->max_mtu = 0xfff;
/* Set our hardware address while we're at it */
ha = (union fwnet_hwaddr *)net->dev_addr;
--
Stefan Richter
-======----- =-=- ===-=
http://arcgraph.de/sr/
^ permalink raw reply related
* Re: [PATCH RDS v1] rds: debug messages are enabled by default
From: David Miller @ 2016-10-29 19:56 UTC (permalink / raw)
To: shamir.rabinovitch; +Cc: netdev, santosh.shilimkar
In-Reply-To: <1477561598-20186-1-git-send-email-shamir.rabinovitch@oracle.com>
From: shamir.rabinovitch@oracle.com
Date: Thu, 27 Oct 2016 05:46:38 -0400
> From: shamir rabinovitch <shamir.rabinovitch@oracle.com>
>
> rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages.
> This option cause the rds Makefile to add -DDEBUG to the rds gcc command
> line.
>
> When CONFIG_DYNAMIC_DEBUG is enabled, the "DEBUG" macro is used by
> include/linux/dynamic_debug.h to decide if dynamic debug prints should
> be sent by default to the kernel log.
>
> rds should not enable this macro for production builds. rds dynamic
> debug work as expected follow this fix.
>
> Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] bpf: Print function name in addition to function id
From: David Miller @ 2016-10-29 19:56 UTC (permalink / raw)
To: tgraf; +Cc: netdev, daniel, ast
In-Reply-To: <67466f1b43b8a586bcf63fa1e5e292ed340d515c.1477560166.git.tgraf@suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 27 Oct 2016 11:23:51 +0200
> The verifier currently prints raw function ids when printing CALL
> instructions or when complaining:
>
> 5: (85) call 23
> unknown func 23
>
> print a meaningful function name instead:
>
> 5: (85) call bpf_redirect#23
> unknown func bpf_redirect#23
>
> Moves the function documentation to a single comment and renames all
> helpers names in the list to conform to the bpf_ prefix notation so
> they can be greped in the kernel source.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
Applied.
^ permalink raw reply
* Re: pull-request: mac80211 2016-10-27
From: David Miller @ 2016-10-29 19:54 UTC (permalink / raw)
To: johannes; +Cc: netdev, linux-wireless
In-Reply-To: <20161027080550.31309-1-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu, 27 Oct 2016 10:05:49 +0200
> Before I go off for LPC and the workshop and everything, I have
> two fixes. Neither is very important, but I figured I'd get them
> out since I won't have any others soon.
>
> Let me know if there's any problem.
Pulled, thanks.
^ permalink raw reply
* [PATCH 15/15] solos-pci: use permission-specific DEVICE_ATTR variants
From: Julia Lawall @ 2016-10-29 19:37 UTC (permalink / raw)
To: Chas Williams; +Cc: kernel-janitors, linux-atm-general, netdev, linux-kernel
In-Reply-To: <1477769829-22230-1-git-send-email-Julia.Lawall@lip6.fr>
Use DEVICE_ATTR_RW for read-write attributes. This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@rw@
declarer name DEVICE_ATTR;
identifier x,x_show,x_store;
@@
DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
@script:ocaml@
x << rw.x;
x_show << rw.x_show;
x_store << rw.x_store;
@@
if not (x^"_show" = x_show && x^"_store" = x_store)
then Coccilib.include_match false
@@
declarer name DEVICE_ATTR_RW;
identifier rw.x,rw.x_show,rw.x_store;
@@
- DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
+ DEVICE_ATTR_RW(x);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/atm/solos-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 6ac2b2b..5ad037c 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -584,7 +584,7 @@ static ssize_t hardware_show(struct device *dev, struct device_attribute *attr,
return sprintf(buf, "%d\n", data32);
}
-static DEVICE_ATTR(console, 0644, console_show, console_store);
+static DEVICE_ATTR_RW(console);
#define SOLOS_ATTR_RO(x) static DEVICE_ATTR(x, 0444, solos_param_show, NULL);
^ permalink raw reply related
* [PATCH 12/15] ptp: use permission-specific DEVICE_ATTR variants
From: Julia Lawall @ 2016-10-29 19:37 UTC (permalink / raw)
To: Richard Cochran; +Cc: kernel-janitors, netdev, linux-kernel
In-Reply-To: <1477769829-22230-1-git-send-email-Julia.Lawall@lip6.fr>
Use DEVICE_ATTR_RO for read only attributes. This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@ro@
declarer name DEVICE_ATTR;
identifier x,x_show;
@@
DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
@script:ocaml@
x << ro.x;
x_show << ro.x_show;
@@
if not (x^"_show" = x_show) then Coccilib.include_match false
@@
declarer name DEVICE_ATTR_RO;
identifier ro.x,ro.x_show;
@@
- DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
+ DEVICE_ATTR_RO(x);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/ptp/ptp_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c
index 302e626..53d4395 100644
--- a/drivers/ptp/ptp_sysfs.c
+++ b/drivers/ptp/ptp_sysfs.c
@@ -28,7 +28,7 @@ static ssize_t clock_name_show(struct device *dev,
struct ptp_clock *ptp = dev_get_drvdata(dev);
return snprintf(page, PAGE_SIZE-1, "%s\n", ptp->info->name);
}
-static DEVICE_ATTR(clock_name, 0444, clock_name_show, NULL);
+static DEVICE_ATTR_RO(clock_name);
#define PTP_SHOW_INT(name, var) \
static ssize_t var##_show(struct device *dev, \
^ permalink raw reply related
* [PATCH 00/15] use permission-specific DEVICE_ATTR variants
From: Julia Lawall @ 2016-10-29 19:36 UTC (permalink / raw)
To: netdev
Cc: kernel-janitors, linux-omap, alsa-devel, linuxppc-dev, linux-mips,
linux-pm, patches, linux-kernel, linux-usb, linux-arm-kernel,
linux-fbdev, linux-pci, linux-atm-general
Use DEVICE_ATTR_RO etc. for read only attributes etc. This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.
The complete semantic patch is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@ro@
declarer name DEVICE_ATTR;
identifier x,x_show;
@@
DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
@wo@
declarer name DEVICE_ATTR;
identifier x,x_store;
@@
DEVICE_ATTR(x, \(0200\|S_IWUSR\), NULL, x_store);
@rw@
declarer name DEVICE_ATTR;
identifier x,x_show,x_store;
@@
DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
@script:ocaml@
x << ro.x;
x_show << ro.x_show;
@@
if not (x^"_show" = x_show) then Coccilib.include_match false
@script:ocaml@
x << wo.x;
x_store << wo.x_store;
@@
if not (x^"_store" = x_store) then Coccilib.include_match false
@script:ocaml@
x << rw.x;
x_show << rw.x_show;
x_store << rw.x_store;
@@
if not (x^"_show" = x_show && x^"_store" = x_store)
then Coccilib.include_match false
@@
declarer name DEVICE_ATTR_RO;
identifier ro.x,ro.x_show;
@@
- DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
+ DEVICE_ATTR_RO(x);
@@
declarer name DEVICE_ATTR_WO;
identifier wo.x,wo.x_store;
@@
- DEVICE_ATTR(x, \(0200\|S_IWUSR\), NULL, x_store);
+ DEVICE_ATTR_WO(x);
@@
declarer name DEVICE_ATTR_RW;
identifier rw.x,rw.x_show,rw.x_store;
@@
- DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
+ DEVICE_ATTR_RW(x);
// </smpl>
---
arch/mips/txx9/generic/7segled.c | 4 ++--
arch/powerpc/kernel/iommu.c | 3 +--
arch/tile/kernel/sysfs.c | 14 +++++++-------
drivers/atm/solos-pci.c | 2 +-
drivers/pci/pcie/aspm.c | 4 ++--
drivers/power/supply/wm8350_power.c | 2 +-
drivers/ptp/ptp_sysfs.c | 2 +-
drivers/thermal/int340x_thermal/int3400_thermal.c | 2 +-
drivers/thermal/thermal_hwmon.c | 2 +-
drivers/tty/nozomi.c | 4 ++--
drivers/usb/wusbcore/dev-sysfs.c | 6 +++---
drivers/usb/wusbcore/wusbhc.c | 13 +++++--------
drivers/video/fbdev/wm8505fb.c | 2 +-
sound/soc/omap/mcbsp.c | 4 ++--
sound/soc/soc-dapm.c | 2 +-
15 files changed, 31 insertions(+), 35 deletions(-)
^ permalink raw reply
* Re: iproute: ss truncates abstract unix domain socket embedding null
From: Isaac Boukris @ 2016-10-29 19:35 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
In-Reply-To: <20161026152217.4058fcaa@xeon-e3>
On Thu, Oct 27, 2016 at 1:22 AM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> Just translating all null characters to @ seems the most consistent and
> logical. Also translating other all non-printing characters to something (maybe '?')
> might be wise. It would be nice if all utilities output the same thing.
I've sent two patches to netdev with which all of ss, netstat and lsof
would translate all null bytes the same way.
I left out the other non-printable characters as I wasn't as confident about it.
Thanks.
^ permalink raw reply
* [PATCH] unix: escape all null bytes in abstract unix domain socket
From: Isaac Boukris @ 2016-10-29 19:20 UTC (permalink / raw)
To: stephen, davem, netdev, linux-kernel; +Cc: Isaac Boukris
In-Reply-To: <1477768820-1295-1-git-send-email-iboukris@gmail.com>
Abstract unix domain socket may embed null characters,
these should be translated to '@' when printed out to
proc the same way the null prefix is currently being
translated.
This helps for tools such as netstat, lsof and the proc
based implementation in ss to show all the significant
bytes of the name (instead of getting cut at the first
null occurrence).
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
---
net/unix/af_unix.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 145082e..9250b03 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -2805,14 +2805,19 @@ static int unix_seq_show(struct seq_file *seq, void *v)
i = 0;
len = u->addr->len - sizeof(short);
- if (!UNIX_ABSTRACT(s))
+ if (!UNIX_ABSTRACT(s)) {
len--;
- else {
+ for ( ; i < len; i++)
+ seq_putc(seq,
+ u->addr->name->sun_path[i]);
+ } else {
seq_putc(seq, '@');
i++;
+ for ( ; i < len; i++)
+ seq_putc(seq,
+ u->addr->name->sun_path[i] ?:
+ '@');
}
- for ( ; i < len; i++)
- seq_putc(seq, u->addr->name->sun_path[i]);
}
unix_state_unlock(s);
seq_putc(seq, '\n');
--
2.7.4
^ permalink raw reply related
* [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket
From: Isaac Boukris @ 2016-10-29 19:20 UTC (permalink / raw)
To: stephen, davem, netdev, linux-kernel; +Cc: Isaac Boukris
Abstract unix domain socket may embed null characters,
these should be translated to '@' when printed by ss the
same way the null prefix is currently being translated.
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
---
misc/ss.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index dd77b81..0e28998 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -2895,7 +2895,9 @@ static int unix_show_sock(const struct sockaddr_nl *addr, struct nlmsghdr *nlh,
memcpy(name, RTA_DATA(tb[UNIX_DIAG_NAME]), len);
name[len] = '\0';
if (name[0] == '\0')
- name[0] = '@';
+ for (int i = 0; i < len; i++)
+ if (name[i] == '\0')
+ name[i] = '@';
stat.name = &name[0];
memcpy(stat.local.data, &stat.name, sizeof(stat.name));
}
--
2.7.4
^ permalink raw reply related
* Re: [PATCH net] ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context
From: David Miller @ 2016-10-29 19:12 UTC (permalink / raw)
To: tlfalcon; +Cc: netdev
In-Reply-To: <1477508258-13205-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Wed, 26 Oct 2016 13:57:38 -0500
> Schedule these XPORT event tasks in the shared workqueue
> so that IRQs are not freed in an interrupt context when
> sub-CRQs are released.
>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: mv643xx_eth: Fetch the phy connection type from DT
From: David Miller @ 2016-10-29 19:11 UTC (permalink / raw)
To: jgunthorpe; +Cc: sebastian.hesselbarth, devicetree, netdev
In-Reply-To: <20161026174702.GB24717@obsidianresearch.com>
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Date: Wed, 26 Oct 2016 11:47:02 -0600
> The MAC is capable of RGMII mode and that is probably a more typical
> connection type than GMII today (eg it is used by Marvell Reference
> designs for several SOCs). Let DT users specify the standard
>
> phy-connection-type = "rgmii-id";
>
> On a phy node.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Applied.
^ permalink raw reply
* Re: [PATCH next] flow_dissector: __skb_get_hash_symmetric arg can be const
From: David Miller @ 2016-10-29 19:10 UTC (permalink / raw)
To: fw; +Cc: netdev
In-Reply-To: <1477500586-17451-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Wed, 26 Oct 2016 18:49:46 +0200
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks Florian.
^ permalink raw reply
* Re: [PATCH net-next] tcp/dccp: drop SYN packets if accept queue is full
From: David Miller @ 2016-10-29 19:09 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, ycheng, ncardwell
In-Reply-To: <1477499277.7065.193.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 26 Oct 2016 09:27:57 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Per listen(fd, backlog) rules, there is really no point accepting a SYN,
> sending a SYNACK, and dropping the following ACK packet if accept queue
> is full, because application is not draining accept queue fast enough.
>
> This behavior is fooling TCP clients that believe they established a
> flow, while there is nothing at server side. They might then send about
> 10 MSS (if using IW10) that will be dropped anyway while server is under
> stress.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: phy: at803x: Add a definition for PHY ID mask
From: David Miller @ 2016-10-29 19:09 UTC (permalink / raw)
To: fabio.estevam; +Cc: f.fainelli, netdev
In-Reply-To: <1477497834-9964-1-git-send-email-fabio.estevam@nxp.com>
From: Fabio Estevam <fabio.estevam@nxp.com>
Date: Wed, 26 Oct 2016 14:03:54 -0200
> Add a definition for PHY ID mask for improving code readability.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied.
^ permalink raw reply
* Re: [PATCH 0/3] pull request for net: batman-adv 2016-10-26
From: David Miller @ 2016-10-29 19:06 UTC (permalink / raw)
To: sw; +Cc: netdev, b.a.t.m.a.n
In-Reply-To: <20161026155515.18075-1-sw@simonwunderlich.de>
From: Simon Wunderlich <sw@simonwunderlich.de>
Date: Wed, 26 Oct 2016 17:55:12 +0200
> here are some bugfix patches which we would like to have integrated
> into net.
>
> Please pull or let me know of any problem!
Pulled, thanks Simon.
^ permalink raw reply
* Re: [PATCH net] Revert "hv_netvsc: report vmbus name in ethtool"
From: David Miller @ 2016-10-29 19:04 UTC (permalink / raw)
To: stephen; +Cc: kys, vkuznets, netdev
In-Reply-To: <20161026092753.1555a5ac@xeon-e3>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 26 Oct 2016 09:27:53 -0700
> From: Stephen Hemminger <sthemmin@microsoft.com>
>
> This reverts commit e3f74b841d48
> ("hv_netvsc: report vmbus name in ethtool")'
> because of problem introduced by commit f9a56e5d6a0ba
> ("Drivers: hv: make VMBus bus ids persistent").
> This changed the format of the vmbus name and this new format is too
> long to fit in the bus_info field of ethtool.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied.
^ permalink raw reply
* [net-next:master 68/93] include/net/raw.h:71:21: error: field 'inet' has incomplete type
From: kbuild test robot @ 2016-10-29 19:02 UTC (permalink / raw)
To: Cyrill Gorcunov; +Cc: kbuild-all, netdev
[-- Attachment #1: Type: text/plain, Size: 2511 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: c778453b138889587eee23e246e231bb12d1e80d
commit: 432490f9d455fb842d70219f22d9d2c812371676 [68/93] net: ip, diag -- Add diag interface for raw sockets
config: i386-randconfig-x012-201644 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
git checkout 432490f9d455fb842d70219f22d9d2c812371676
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
In file included from net/ipv4/raw_diag.c:6:0:
>> include/net/raw.h:71:21: error: field 'inet' has incomplete type
struct inet_sock inet;
^~~~
net/ipv4/raw_diag.c: In function 'raw_diag_dump':
>> net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk' [-Werror=implicit-function-declaration]
struct inet_sock *inet = inet_sk(sk);
^~~~~~~
>> net/ipv4/raw_diag.c:166:29: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
>> net/ipv4/raw_diag.c:174:33: error: dereferencing pointer to incomplete type 'struct inet_sock'
if (r->id.idiag_sport != inet->inet_sport &&
^~
cc1: some warnings being treated as errors
vim +/inet +71 include/net/raw.h
20380731 Arnaldo Carvalho de Melo 2005-08-16 65
086c653f Craig Gallek 2016-02-10 66 int raw_hash_sk(struct sock *sk);
fc8717ba Pavel Emelyanov 2008-03-22 67 void raw_unhash_sk(struct sock *sk);
65b4c50b Pavel Emelyanov 2007-11-19 68
f74e49b5 Patrick McHardy 2010-04-13 69 struct raw_sock {
f74e49b5 Patrick McHardy 2010-04-13 70 /* inet_sock has to be the first member */
f74e49b5 Patrick McHardy 2010-04-13 @71 struct inet_sock inet;
f74e49b5 Patrick McHardy 2010-04-13 72 struct icmp_filter filter;
f0ad0860 Patrick McHardy 2010-04-13 73 u32 ipmr_table;
f74e49b5 Patrick McHardy 2010-04-13 74 };
:::::: The code at line 71 was first introduced by commit
:::::: f74e49b5613206fb18468bdc9509a1db746aa01b ipv4: raw: move struct raw_sock and raw_sk() to include/net/raw.h
:::::: TO: Patrick McHardy <kaber@trash.net>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28884 bytes --]
^ permalink raw reply
* Re: [PATCH net v2] packet: on direct_xmit, limit tso and csum to supported devices
From: David Miller @ 2016-10-29 19:03 UTC (permalink / raw)
To: willemdebruijn.kernel; +Cc: netdev, daniel, willemb
In-Reply-To: <1477495387-36861-1-git-send-email-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Wed, 26 Oct 2016 11:23:07 -0400
> From: Willem de Bruijn <willemb@google.com>
>
> When transmitting on a packet socket with PACKET_VNET_HDR and
> PACKET_QDISC_BYPASS, validate device support for features requested
> in vnet_hdr.
>
> Drop TSO packets sent to devices that do not support TSO or have the
> feature disabled. Note that the latter currently do process those
> packets correctly, regardless of not advertising the feature.
>
> Because of SKB_GSO_DODGY, it is not sufficient to test device features
> with netif_needs_gso. Full validate_xmit_skb is needed.
>
> Switch to software checksum for non-TSO packets that request checksum
> offload if that device feature is unsupported or disabled. Note that
> similar to the TSO case, device drivers may perform checksum offload
> correctly even when not advertising it.
>
> When switching to software checksum, packets hit skb_checksum_help,
> which has two BUG_ON checksum not in linear segment. Packet sockets
> always allocate at least up to csum_start + csum_off + 2 as linear.
>
> Tested by running github.com/wdebruij/kerneltools/psock_txring_vnet.c
>
> ethtool -K eth0 tso off tx on
> psock_txring_vnet -d $dst -s $src -i eth0 -l 2000 -n 1 -q -v
> psock_txring_vnet -d $dst -s $src -i eth0 -l 2000 -n 1 -q -v -N
>
> ethtool -K eth0 tx off
> psock_txring_vnet -d $dst -s $src -i eth0 -l 1000 -n 1 -q -v -G
> psock_txring_vnet -d $dst -s $src -i eth0 -l 1000 -n 1 -q -v -G -N
>
> v2:
> - add EXPORT_SYMBOL_GPL(validate_xmit_skb_list)
>
> Fixes: d346a3fae3ff ("packet: introduce PACKET_QDISC_BYPASS socket option")
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied and queued up for -stable.
^ permalink raw reply
* Re: [PATCH] net_sched actions: use nla_parse_nested()
From: David Miller @ 2016-10-29 19:01 UTC (permalink / raw)
To: johannes; +Cc: netdev, jhs, johannes.berg
In-Reply-To: <1477485873-32598-1-git-send-email-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 26 Oct 2016 14:44:33 +0200
> From: Johannes Berg <johannes.berg@intel.com>
>
> Use nla_parse_nested instead of open-coding the call to
> nla_parse() with the attribute data/len.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next] switchdev: Remove redundant variable
From: David Miller @ 2016-10-29 18:59 UTC (permalink / raw)
To: idosch; +Cc: jiri, netdev, mlxsw, idosch
In-Reply-To: <1477472583-11710-1-git-send-email-idosch@idosch.org>
From: idosch@idosch.org
Date: Wed, 26 Oct 2016 12:03:03 +0300
> From: Ido Schimmel <idosch@mellanox.com>
>
> Instead of storing return value in 'err' and returning, just return
> directly.
>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr
From: David Miller @ 2016-10-29 18:57 UTC (permalink / raw)
To: tgraf-G/eBtMaohhA
Cc: johannes-cdvu00un1VgdHxzADdlk8Q, daniel-FeC+5ew28dpmcu3hnIyYJQ,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <2d0864c85200f1b42b1ebceee7c2dc60fe29f26a.1477471562.git.tgraf-G/eBtMaohhA@public.gmane.org>
From: Thomas Graf <tgraf-G/eBtMaohhA@public.gmane.org>
Date: Wed, 26 Oct 2016 10:53:16 +0200
> Wrap several common instances of:
> kmemdup(nla_data(attr), nla_len(attr), GFP_KERNEL);
>
> Signed-off-by: Thomas Graf <tgraf-G/eBtMaohhA@public.gmane.org>
Applied.
^ permalink raw reply
* Re: [PATCH net] cxgb4: Fix error handling in alloc_uld_rxqs().
From: David Miller @ 2016-10-29 18:57 UTC (permalink / raw)
To: ganeshgr; +Cc: netdev, hariprasad, nirranjan
In-Reply-To: <1477468598-11296-1-git-send-email-ganeshgr@chelsio.com>
From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Wed, 26 Oct 2016 13:26:38 +0530
> Fix to release resources properly in error handling path of
> alloc_uld_rxqs(), This patch also removes unwanted arguments
> and avoids calling the same function twice.
>
> Fixes: 94cdb8bb993a (cxgb4: Add support for dynamic allocation
> of resources for ULD
> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Applied.
^ permalink raw reply
* Re: [PATCH] [net-next] net: ip, diag: include net/inet_sock.h
From: David Miller @ 2016-10-29 18:53 UTC (permalink / raw)
To: arnd; +Cc: kuznet, jmorris, yoshfuji, kaber, gorcunov, netdev, linux-kernel
In-Reply-To: <20161025155339.9892-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 25 Oct 2016 17:53:22 +0200
> The newly added raw_diag.c fails to build in some configurations
> unless we include this header:
>
> In file included from net/ipv4/raw_diag.c:6:0:
> include/net/raw.h:71:21: error: field 'inet' has incomplete type
> net/ipv4/raw_diag.c: In function 'raw_diag_dump':
> net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk'
>
> Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
^ permalink raw reply
* Re: [PATCH] ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()
From: David Miller @ 2016-10-29 18:50 UTC (permalink / raw)
To: elicooper; +Cc: netdev, tom
In-Reply-To: <20161026021109.19277-1-elicooper@gmx.com>
From: Eli Cooper <elicooper@gmx.com>
Date: Wed, 26 Oct 2016 10:11:09 +0800
> This patch updates skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit() when an
> IPv6 header is installed to a socket buffer.
>
> This is not a cosmetic change. Without updating this value, GSO packets
> transmitted through an ipip6 tunnel have the protocol of ETH_P_IP and
> skb_mac_gso_segment() will attempt to call gso_segment() for IPv4,
> which results in the packets being dropped.
>
> Fixes: b8921ca83eed ("ip4ip6: Support for GSO/GRO")
> Signed-off-by: Eli Cooper <elicooper@gmx.com>
Applied and queued up for -stable, thank you.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox