* RE: [PATCH] net: ioctl SIOCSIFADDR minor cleanup
From: YUAN Linyu @ 2016-11-16 3:57 UTC (permalink / raw)
To: David Miller; +Cc: cugyly@163.com, netdev@vger.kernel.org
In-Reply-To: <20161115.223111.734917440131578613.davem@davemloft.net>
No, this patch will not change dev->name,
It's care about ifa->ifa_label.
> - if (colon)
> - memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
> - else
> - memcpy(ifa->ifa_label, dev->name, IFNAMSIZ);
When ifr.ifr_name have no colon, dev->name must equal to ifr.ifr_name.
So we change to
> - else
> - memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
Then if and else do same thing. Just one line is enough,
memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, November 16, 2016 11:31 AM
> To: YUAN Linyu
> Cc: cugyly@163.com; netdev@vger.kernel.org
> Subject: Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup
>
> From: YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> Date: Wed, 16 Nov 2016 03:13:31 +0000
>
> > So assign label to request name will do same thing as original code.
>
> Nope. dev->name does not have the colon, it was trimmed from the
> string for the device lookup. So the found device's dev->name does
> not have the colon character, even if it was in ifr.ifr_name
>
> This was my entire point.
>
> You are changing the behvaior of the code in an invalid way.
^ permalink raw reply
* Re: [PATCH net-next V2 0/9] alx: add multi queue support
From: David Miller @ 2016-11-16 3:46 UTC (permalink / raw)
To: tobias.regnery; +Cc: netdev, jcliburn, chris.snook
In-Reply-To: <cover.1479208627.git.tobias.regnery@gmail.com>
From: Tobias Regnery <tobias.regnery@gmail.com>
Date: Tue, 15 Nov 2016 12:43:07 +0100
> This patchset lays the groundwork for multi queue support in the alx driver
> and enables multi queue support for the tx path by default. The hardware
> supports up to 4 tx queues.
Series applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next v3 0/5] Adding PHY-Tunables and downshift support
From: David Miller @ 2016-11-16 3:44 UTC (permalink / raw)
To: allan.nielsen; +Cc: netdev, andrew, raju.lakkaraju
In-Reply-To: <1479205204-27768-1-git-send-email-allan.nielsen@microsemi.com>
From: "Allan W. Nielsen" <allan.nielsen@microsemi.com>
Date: Tue, 15 Nov 2016 11:19:59 +0100
> Old cover letters included below.
Please do not form your cover letter by quoting older and older
cover letters.
Always write a clean, single, cover letter with a changelog of
changed between each and every version leading up to the
current one.
Thank you.
^ permalink raw reply
* Re: [PATCH net] rtnetlink: fix rtnl message size computation for XDP
From: David Miller @ 2016-11-16 3:43 UTC (permalink / raw)
To: sd; +Cc: netdev, bblanco
In-Reply-To: <0169d2419991a4ba533087a4fda70420ccdaca30.1479204870.git.sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Tue, 15 Nov 2016 11:16:35 +0100
> rtnl_xdp_size() only considers the size of the actual payload attribute,
> and misses the space taken by the attribute used for nesting (IFLA_XDP).
>
> Fixes: d1fdd9138682 ("rtnl: add option for setting link xdp prog")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied and queued up for -stable.
^ permalink raw reply
* Re: [PATCH net] rtnetlink: fix rtnl_vfinfo_size
From: David Miller @ 2016-11-16 3:42 UTC (permalink / raw)
To: sd; +Cc: netdev, eranbe, hadarh, ogerlitz, sucheta.chakraborty
In-Reply-To: <188991b3f1ede7ff1231f78411f4716cb5926950.1479202614.git.sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Tue, 15 Nov 2016 10:39:03 +0100
> The size reported by rtnl_vfinfo_size doesn't match the space used by
> rtnl_fill_vfinfo.
>
> rtnl_vfinfo_size currently doesn't account for the nest attributes
> used by statistics (added in commit 3b766cd83232), nor for struct
> ifla_vf_tx_rate (since commit ed616689a3d9, which added ifla_vf_rate
> to the dump without removing ifla_vf_tx_rate, but replaced
> ifla_vf_tx_rate with ifla_vf_rate in the size computation).
>
> Fixes: 3b766cd83232 ("net/core: Add reading VF statistics through the PF netdevice")
> Fixes: ed616689a3d9 ("net-next:v4: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied and queued up for -stable.
^ permalink raw reply
* Re: [PATCH net-next 2/2] net: marvell: Allow drivers to be built with COMPILE_TEST
From: kbuild test robot @ 2016-11-16 3:35 UTC (permalink / raw)
To: Florian Fainelli
Cc: kbuild-all, netdev, davem, mw, arnd, gregory.clement, Shaohui.Xie,
Igal.Liberman, Florian Fainelli
In-Reply-To: <20161115173548.32567-3-f.fainelli@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3163 bytes --]
Hi Florian,
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-Allow-Marvell-Freescale-to-COMPILE_TEST/20161116-024633
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
drivers/built-in.o: In function `.mvneta_bm_pool_use':
>> (.text+0x19a18cc): undefined reference to `.mvebu_mbus_get_dram_win_info'
drivers/built-in.o: In function `.brcmf_create_iovar.constprop.1':
fwil.c:(.text+0x1ff95f0): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.memcpy' defined in .text section in arch/powerpc/lib/built-in.o
fwil.c:(.text+0x1ff9614): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.memcpy' defined in .text section in arch/powerpc/lib/built-in.o
drivers/built-in.o: In function `.brcmf_create_bsscfg.constprop.0':
fwil.c:(.text+0x1ff976c): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.memcpy' defined in .text section in arch/powerpc/lib/built-in.o
fwil.c:(.text+0x1ff9790): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.memcpy' defined in .text section in arch/powerpc/lib/built-in.o
drivers/built-in.o: In function `.brcmf_fil_cmd_data_get':
(.text+0x1ff9c7c): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.debug_lockdep_rcu_enabled' defined in .text section in kernel/built-in.o
drivers/built-in.o: In function `.brcmf_fil_cmd_data_get':
(.text+0x1ff9dc4): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.debug_lockdep_rcu_enabled' defined in .text section in kernel/built-in.o
drivers/built-in.o: In function `.brcmf_fil_iovar_data_set':
(.text+0x1ffa1ac): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.debug_lockdep_rcu_enabled' defined in .text section in kernel/built-in.o
drivers/built-in.o: In function `.brcmf_fil_iovar_data_set':
(.text+0x1ffa2f4): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.debug_lockdep_rcu_enabled' defined in .text section in kernel/built-in.o
drivers/built-in.o: In function `.brcmf_fil_iovar_data_get':
(.text+0x1ffa51c): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.memcpy' defined in .text section in arch/powerpc/lib/built-in.o
drivers/built-in.o: In function `.brcmf_fil_iovar_data_get':
(.text+0x1ffa5fc): relocation truncated to fit: R_PPC64_REL24 (stub) against symbol `.debug_lockdep_rcu_enabled' defined in .text section in kernel/built-in.o
drivers/built-in.o: In function `.brcmf_fil_iovar_data_get':
(.text+0x1ffa744): additional relocation overflows omitted from the output
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51094 bytes --]
^ permalink raw reply
* Re: [PATCH net-next v8 0/9] dpaa_eth: Add the QorIQ DPAA Ethernet driver
From: David Miller @ 2016-11-16 3:34 UTC (permalink / raw)
To: madalin.bucur
Cc: netdev, linuxppc-dev, linux-kernel, oss, ppc, joe, pebolle,
joakim.tjernlund
In-Reply-To: <1479199269-9748-1-git-send-email-madalin.bucur@nxp.com>
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Tue, 15 Nov 2016 10:41:00 +0200
> This patch series adds the Ethernet driver for the Freescale
> QorIQ Data Path Acceleration Architecture (DPAA).
Series applied, thanks.
^ permalink raw reply
* [PATCH iproute2] ifstat/nstat: fix help output alignment
From: Mike Frysinger @ 2016-11-16 3:34 UTC (permalink / raw)
To: stephen.hemminger, netdev
Some lines use tabs while others use spaces. Use spaces everywhere.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
misc/ifstat.c | 24 ++++++++++++------------
misc/nstat.c | 22 +++++++++++-----------
2 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index d55197375e3c..92d67b0c5fd1 100644
--- a/misc/ifstat.c
+++ b/misc/ifstat.c
@@ -662,18 +662,18 @@ static void usage(void)
{
fprintf(stderr,
"Usage: ifstat [OPTION] [ PATTERN [ PATTERN ] ]\n"
-" -h, --help this message\n"
-" -a, --ignore ignore history\n"
-" -d, --scan=SECS sample every statistics every SECS\n"
-" -e, --errors show errors\n"
-" -j, --json format output in JSON\n"
-" -n, --nooutput do history only\n"
-" -p, --pretty pretty print\n"
-" -r, --reset reset history\n"
-" -s, --noupdate don\'t update history\n"
-" -t, --interval=SECS report average over the last SECS\n"
-" -V, --version output version information\n"
-" -z, --zeros show entries with zero activity\n");
+" -h, --help this message\n"
+" -a, --ignore ignore history\n"
+" -d, --scan=SECS sample every statistics every SECS\n"
+" -e, --errors show errors\n"
+" -j, --json format output in JSON\n"
+" -n, --nooutput do history only\n"
+" -p, --pretty pretty print\n"
+" -r, --reset reset history\n"
+" -s, --noupdate don't update history\n"
+" -t, --interval=SECS report average over the last SECS\n"
+" -V, --version output version information\n"
+" -z, --zeros show entries with zero activity\n");
exit(-1);
}
diff --git a/misc/nstat.c b/misc/nstat.c
index 1cb6c7eea27a..1212b1f2c812 100644
--- a/misc/nstat.c
+++ b/misc/nstat.c
@@ -526,17 +526,17 @@ static void usage(void)
{
fprintf(stderr,
"Usage: nstat [OPTION] [ PATTERN [ PATTERN ] ]\n"
-" -h, --help this message\n"
-" -a, --ignore ignore history\n"
-" -d, --scan=SECS sample every statistics every SECS\n"
-" -j, --json format output in JSON\n"
-" -n, --nooutput do history only\n"
-" -p, --pretty pretty print\n"
-" -r, --reset reset history\n"
-" -s, --noupdate don\'t update history\n"
-" -t, --interval=SECS report average over the last SECS\n"
-" -V, --version output version information\n"
-" -z, --zeros show entries with zero activity\n");
+" -h, --help this message\n"
+" -a, --ignore ignore history\n"
+" -d, --scan=SECS sample every statistics every SECS\n"
+" -j, --json format output in JSON\n"
+" -n, --nooutput do history only\n"
+" -p, --pretty pretty print\n"
+" -r, --reset reset history\n"
+" -s, --noupdate don't update history\n"
+" -t, --interval=SECS report average over the last SECS\n"
+" -V, --version output version information\n"
+" -z, --zeros show entries with zero activity\n");
exit(-1);
}
--
2.10.2
^ permalink raw reply related
* Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup
From: David Miller @ 2016-11-16 3:31 UTC (permalink / raw)
To: Linyu.Yuan; +Cc: cugyly, netdev
In-Reply-To: <8729016553E3654398EA69218DA29EEF0E42F73A@cnshjmbx02>
From: YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Date: Wed, 16 Nov 2016 03:13:31 +0000
> So assign label to request name will do same thing as original code.
Nope. dev->name does not have the colon, it was trimmed from the
string for the device lookup. So the found device's dev->name does
not have the colon character, even if it was in ifr.ifr_name
This was my entire point.
You are changing the behvaior of the code in an invalid way.
^ permalink raw reply
* Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup
From: David Miller @ 2016-11-16 3:30 UTC (permalink / raw)
To: Linyu.Yuan; +Cc: cugyly, netdev
In-Reply-To: <8729016553E3654398EA69218DA29EEF0E42F73A@cnshjmbx02>
From: YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Date: Wed, 16 Nov 2016 03:13:31 +0000
> orginal code means when reqest name have colon, then label name will have colon.
And that is intentional.
^ permalink raw reply
* Re: [PATCH net-next] tcp: allow to enable the repair mode for non-listening sockets
From: David Miller @ 2016-11-16 3:29 UTC (permalink / raw)
To: avagin; +Cc: linux-kernel, netdev, kuznet, jmorris, yoshfuji, kaber, criu
In-Reply-To: <1479176114-12658-1-git-send-email-avagin@openvz.org>
From: Andrei Vagin <avagin@openvz.org>
Date: Mon, 14 Nov 2016 18:15:14 -0800
> The repair mode is used to get and restore sequence numbers and
> data from queues. It used to checkpoint/restore connections.
>
> Currently the repair mode can be enabled for sockets in the established
> and closed states, but for other states we have to dump the same socket
> properties, so lets allow to enable repair mode for these sockets.
>
> The repair mode reveals nothing more for sockets in other states.
>
> Signed-off-by: Andrei Vagin <avagin@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH net] gro_cells: mark napi struct as not busy poll candidates
From: David Miller @ 2016-11-16 3:29 UTC (permalink / raw)
To: eric.dumazet
Cc: ebiederm, paulmck, xiyou.wangcong, rolf.neugebauer, netdev,
justin.cormack, ian.campbell, edumazet
In-Reply-To: <1479169722.8455.108.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 Nov 2016 16:28:42 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Rolf Neugebauer reported very long delays at netns dismantle.
>
> Eric W. Biederman was kind enough to look at this problem
> and noticed synchronize_net() occurring from netif_napi_del() that was
> added in linux-4.5
>
> Busy polling makes no sense for tunnels NAPI.
> If busy poll is used for sessions over tunnels, the poller will need to
> poll the physical device queue anyway.
>
> netif_tx_napi_add() could be used here, but function name is misleading,
> and renaming it is not stable material, so set NAPI_STATE_NO_BUSY_POLL
> bit directly.
>
> This will avoid inserting gro_cells napi structures in napi_hash[]
> and avoid the problematic synchronize_net() (per possible cpu) that
> Rolf reported.
>
> Fixes: 93d05d4a320c ("net: provide generic busy polling to all NAPI drivers")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
> Reported-by: Eric W. Biederman <ebiederm@xmission.com>
Applied, thanks.
^ permalink raw reply
* [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit
From: Andrew Lunn @ 2016-11-16 3:26 UTC (permalink / raw)
To: David Miller; +Cc: Vivien Didelot, netdev, Andrew Lunn
The SPEED_UNFORCED indicates the MAC & PHY should perform
auto-negotiation to determine a speed which works. If this is called
for, don't set the force bit. If it is set, the MAC actually does
10Gbps, why the internal PHYs don't support.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/port.c b/drivers/net/dsa/mv88e6xxx/port.c
index e4978f6367aa..af4772d86086 100644
--- a/drivers/net/dsa/mv88e6xxx/port.c
+++ b/drivers/net/dsa/mv88e6xxx/port.c
@@ -213,7 +213,7 @@ static int mv88e6xxx_port_set_speed(struct mv88e6xxx_chip *chip, int port,
reg &= ~PORT_PCS_CTRL_ALTSPEED;
if (force_bit) {
reg &= ~PORT_PCS_CTRL_FORCE_SPEED;
- if (speed)
+ if (speed != SPEED_UNFORCED)
ctrl |= PORT_PCS_CTRL_FORCE_SPEED;
}
reg |= ctrl;
--
2.10.2
^ permalink raw reply related
* Re: [PATCH net-next V6 0/9] liquidio CN23XX VF support
From: David Miller @ 2016-11-16 3:25 UTC (permalink / raw)
To: rvatsavayi; +Cc: netdev
In-Reply-To: <1479167687-9904-1-git-send-email-rvatsavayi@caviumnetworks.com>
From: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
Date: Mon, 14 Nov 2016 15:54:38 -0800
> Following is the V6 patch series for adding VF support on
> CN23XX devices. This version addressed:
> 1) Your concern for ordering of local variable declarations
> from longest to shortest line.
> 2) Removed module parameters max_vfs, num_queues_per_{p,v}f.
> 3) Minor changes for fixing new checkpatch script related
> errors on pre-existing driver.
> 4) Fixed compilation issues when CONFIG_PCI_IOV/CONFIG_PCI_ATS
> options are disabled.
> 5) Modified qualifiers for printing mac addresses with pM format.
>
> I will post remaining VF patches soon after this patchseries is
> applied. Please apply patches in the following order as some of
> the patches depend on earlier patches.
Series applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next v3 2/3] net: fsl: Allow most drivers to be built with COMPILE_TEST
From: kbuild test robot @ 2016-11-16 3:23 UTC (permalink / raw)
To: Florian Fainelli
Cc: kbuild-all, netdev, davem, mw, arnd, gregory.clement, Shaohui.Xie,
Florian Fainelli
In-Reply-To: <20161116004037.20941-4-f.fainelli@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3891 bytes --]
Hi Florian,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-gianfar_ptp-Rename-FS-bit-to-FIPERST/20161116-095805
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh
All warnings (new ones prefixed by >>):
drivers/net/ethernet/freescale/fsl_pq_mdio.c: In function 'fsl_pq_mdio_remove':
>> drivers/net/ethernet/freescale/fsl_pq_mdio.c:498:27: warning: unused variable 'priv' [-Wunused-variable]
struct fsl_pq_mdio_priv *priv = bus->priv;
^~~~
vim +/priv +498 drivers/net/ethernet/freescale/fsl_pq_mdio.c
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 482 return 0;
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 483
dd3b8a32 drivers/net/ethernet/freescale/fsl_pq_mdio.c Timur Tabi 2012-08-29 484 error:
dd3b8a32 drivers/net/ethernet/freescale/fsl_pq_mdio.c Timur Tabi 2012-08-29 485 if (priv->map)
b3319b10 drivers/net/fsl_pq_mdio.c Anton Vorontsov 2009-12-30 486 iounmap(priv->map);
dd3b8a32 drivers/net/ethernet/freescale/fsl_pq_mdio.c Timur Tabi 2012-08-29 487
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 488 kfree(new_bus);
dd3b8a32 drivers/net/ethernet/freescale/fsl_pq_mdio.c Timur Tabi 2012-08-29 489
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 490 return err;
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 491 }
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 492
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 493
5078ac79 drivers/net/ethernet/freescale/fsl_pq_mdio.c Timur Tabi 2012-08-29 494 static int fsl_pq_mdio_remove(struct platform_device *pdev)
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 495 {
5078ac79 drivers/net/ethernet/freescale/fsl_pq_mdio.c Timur Tabi 2012-08-29 496 struct device *device = &pdev->dev;
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 497 struct mii_bus *bus = dev_get_drvdata(device);
b3319b10 drivers/net/fsl_pq_mdio.c Anton Vorontsov 2009-12-30 @498 struct fsl_pq_mdio_priv *priv = bus->priv;
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 499
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 500 mdiobus_unregister(bus);
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 501
b3319b10 drivers/net/fsl_pq_mdio.c Anton Vorontsov 2009-12-30 502 iounmap(priv->map);
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 503 mdiobus_free(bus);
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 504
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 505 return 0;
1577ecef drivers/net/fsl_pq_mdio.c Andy Fleming 2009-02-04 506 }
:::::: The code at line 498 was first introduced by commit
:::::: b3319b10523d8dac82b134a05de2a403119abebd fsl_pq_mdio: Fix iomem unmapping for non-eTSEC2.0 controllers
:::::: TO: Anton Vorontsov <avorontsov@ru.mvista.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42369 bytes --]
^ permalink raw reply
* Re: [PATCH net] udp: restore UDPlite many-cast delivery
From: David Miller @ 2016-11-16 3:14 UTC (permalink / raw)
To: pablo; +Cc: netdev, edumazet, drheld
In-Reply-To: <1479163230-8734-1-git-send-email-pablo@netfilter.org>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 14 Nov 2016 23:40:30 +0100
> Honor udptable parameter that is passed to __udp*_lib_mcast_deliver(),
> otherwise udplite broadcast/multicast use the wrong table and it breaks.
>
> Fixes: 2dc41cff7545 ("udp: Use hash2 for long hash1 chains in __udp*_lib_mcast_deliver.")
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Applied and queued up for -stable, thanks Pablo.
^ permalink raw reply
* RE: [PATCH] net: ioctl SIOCSIFADDR minor cleanup
From: YUAN Linyu @ 2016-11-16 3:13 UTC (permalink / raw)
To: David Miller, cugyly@163.com; +Cc: netdev@vger.kernel.org
In-Reply-To: <20161115.220108.1225196299725031215.davem@davemloft.net>
hi david,
> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
> On Behalf Of David Miller
> Sent: Wednesday, November 16, 2016 11:01 AM
> To: cugyly@163.com
> Cc: netdev@vger.kernel.org; YUAN Linyu
> Subject: Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup
>
> From: yuan linyu <cugyly@163.com>
> Date: Tue, 15 Nov 2016 20:44:59 +0800
>
> > @@ -1063,10 +1063,7 @@ int devinet_ioctl(struct net *net, unsigned int
> cmd, void __user *arg)
> > if (!ifa)
> > break;
> > INIT_HLIST_NODE(&ifa->hash);
> > - if (colon)
> > - memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
> > - else
> > - memcpy(ifa->ifa_label, dev->name, IFNAMSIZ);
> > + memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
>
> This is an incorrect and untested change.
>
> If there is a colon character in ifr.ifr_name, earlier in this function
> we will:
>
> 1) First replace that colon with a NULL character.
>
> 2) Perform __dev_get_by_name() on the result.
>
> 3) Put the ":" colon character back into ifr.ifr_name
>
> So the two strings ifr.ifr_name and dev->name can in fact be different
> here. Therefore the code has to be left as it is.
Here we assign value to ifa->ifa_label.
orginal code means when reqest name have colon, then label name will have colon.
If request name have no colon, label name will same as dev-name, it's also have no colon.
So assign label to request name will do same thing as original code.
thanks
^ permalink raw reply
* Re: [PATCH 0/2] amd-xgbe: AMD XGBE driver updates 2016-11-14
From: David Miller @ 2016-11-16 3:13 UTC (permalink / raw)
To: thomas.lendacky; +Cc: netdev, julia.lawall, christophe.jaillet
In-Reply-To: <20161114222827.25160.24791.stgit@tlendack-t1.amdoffice.net>
From: Tom Lendacky <thomas.lendacky@amd.com>
Date: Mon, 14 Nov 2016 16:28:27 -0600
> This patch series addresses some minor issues found in the recently
> accepted patch series for the AMD XGBE driver.
>
> The following fixes are included in this driver update series:
>
> - Fix how a mask is applied to a Clause 37 register value
> - Fix some coccinelle identified warnings
>
> This patch series is based on net-next.
Series applied.
^ permalink raw reply
* Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed
From: David Miller @ 2016-11-16 3:12 UTC (permalink / raw)
To: alex.g; +Cc: f.fainelli, gokhan, netdev, linux-kernel
In-Reply-To: <c9c60bc8-d93f-a60c-7f25-4cd508507e65@adaptrum.com>
From: Alex <alex.g@adaptrum.com>
Date: Mon, 14 Nov 2016 13:54:57 -0800
>
>
> On 11/14/2016 01:25 PM, Florian Fainelli wrote:
>> On 11/14/2016 01:18 PM, David Miller wrote:
>>> From: Alexandru Gagniuc <alex.g@adaptrum.com>
>>> Date: Sat, 12 Nov 2016 15:32:13 -0800
>>>
>>>> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
>>>> + ret = vsc8601_add_skew(phydev);
>>>
>>> I think you should use phy_interface_is_rgmii() here.
>>>
>>
>> This would include all RGMII modes, here I think the intent is to
>> check
>> for PHY_INTERFACE_MODE_RGMII_ID and PHY_INTERFACE_MODE_RGMII_TXID (or
>> RXID),
>
> That is correct.
>
>> Alexandru, what direction does the skew settings apply to?
>
> It applies a skew in both TX and RX directions.
Please repost your patch, making the intent clear either in the
commit message or a code comment.
Thanks.
^ permalink raw reply
* Re: [PATCH 0/3 v5] Fixes for running a big-endian kernel on Cubieboard2
From: David Miller @ 2016-11-16 3:06 UTC (permalink / raw)
To: michael.weiser; +Cc: netdev
In-Reply-To: <20161114175807.4747-1-michael.weiser@gmx.de>
From: Michael Weiser <michael.weiser@gmx.de>
Date: Mon, 14 Nov 2016 18:58:04 +0100
> the following patches are what remains to be fixed in order to allow running a
> big-endian kernel on the Cubieboard2.
Series applied to net-next, thanks.
^ permalink raw reply
* Re: [PATCH next] dctcp: update cwnd on congestion event
From: David Miller @ 2016-11-16 3:02 UTC (permalink / raw)
To: fw; +Cc: netdev, brakmo, agshew, glenn.judd, daniel
In-Reply-To: <1479138121-32294-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Mon, 14 Nov 2016 16:42:01 +0100
> draft-ietf-tcpm-dctcp-02 says:
>
> ... when the sender receives an indication of congestion
> (ECE), the sender SHOULD update cwnd as follows:
>
> cwnd = cwnd * (1 - DCTCP.Alpha / 2)
>
> So, lets do this and reduce cwnd more smoothly (and faster), as per
> current congestion estimate.
>
> Cc: Lawrence Brakmo <brakmo@fb.com>
> Cc: Andrew Shewmaker <agshew@gmail.com>
> Cc: Glenn Judd <glenn.judd@morganstanley.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied.
^ permalink raw reply
* Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup
From: David Miller @ 2016-11-16 3:01 UTC (permalink / raw)
To: cugyly; +Cc: netdev, Linyu.Yuan
In-Reply-To: <1479213899-5952-1-git-send-email-cugyly@163.com>
From: yuan linyu <cugyly@163.com>
Date: Tue, 15 Nov 2016 20:44:59 +0800
> @@ -1063,10 +1063,7 @@ int devinet_ioctl(struct net *net, unsigned int cmd, void __user *arg)
> if (!ifa)
> break;
> INIT_HLIST_NODE(&ifa->hash);
> - if (colon)
> - memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
> - else
> - memcpy(ifa->ifa_label, dev->name, IFNAMSIZ);
> + memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
This is an incorrect and untested change.
If there is a colon character in ifr.ifr_name, earlier in this function
we will:
1) First replace that colon with a NULL character.
2) Perform __dev_get_by_name() on the result.
3) Put the ":" colon character back into ifr.ifr_name
So the two strings ifr.ifr_name and dev->name can in fact be different
here. Therefore the code has to be left as it is.
^ permalink raw reply
* Re: [PATCH net-next] net: bcm63xx_enet: Fix build failure with phy_ethtool_nway_reset
From: David Miller @ 2016-11-16 2:56 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev
In-Reply-To: <20161116022109.26935-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 15 Nov 2016 18:21:09 -0800
> Introduced a typo making the driver no longer build, *sigh*.
>
> Fixes: 42469bf5d9bb ("net: bcm63xx_enet: Utilize phy_ethtool_nway_reset")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply
* [PATCH net-next] net: bcm63xx_enet: Fix build failure with phy_ethtool_nway_reset
From: Florian Fainelli @ 2016-11-16 2:21 UTC (permalink / raw)
To: netdev; +Cc: davem, Florian Fainelli
Introduced a typo making the driver no longer build, *sigh*.
Fixes: 42469bf5d9bb ("net: bcm63xx_enet: Utilize phy_ethtool_nway_reset")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index a43ab90c051e..3b14d5144228 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -1435,7 +1435,7 @@ static int bcm_enet_nway_reset(struct net_device *dev)
priv = netdev_priv(dev);
if (priv->has_phy)
- return phy_ethtool_nway_reset(dev),
+ return phy_ethtool_nway_reset(dev);
return -EOPNOTSUPP;
}
--
2.9.3
^ permalink raw reply related
* Re: [PATCH] icmp: Restore resistence to abnormal messages
From: Florian Westphal @ 2016-11-16 1:14 UTC (permalink / raw)
To: Vicente Jiménez
Cc: Florian Westphal, David Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, linux-kernel
In-Reply-To: <CAO1wt+aZjRE_KTY0iRNJryeHvehrK6kuGMn6wOOeFuT1ncpPxA@mail.gmail.com>
Vicente Jiménez <googuy@gmail.com> wrote:
> I agree that both patches try to solve the same problem in a very similar way.
> Florian Westphal's patch do two more things:
> 1- add warning with pr_warn_ratelimited. I like this idea. I also
> though about adding some message but I have no kernel experience and I
> preferred to have just a working solution.
I added this only to show whats happening.
I don't like such printks because end users can't do anything about it.
> 2- Check if the packet size is lower than (536 + 8). I think this is
> not necessary because low values (even the zero case) is already
> handled by the protocol. Also I don't understand why you choose this
> value, it seems to be related to TCP MSS and the compared value is IP
> packet size.
Right, no need for this check.
> Finally, both patches decrement current packet by a value: Mine by 2
> and Florian's by 8 bytes. Both arbitrary values. Personally I prefer
> to go by small steps. If the small step fails, it just iterate again
> and with 4 iterations, my patch also decrement the original value by 8
> bytes (4x2).
> Basically they are the same but my patch take smaller steps and miss
> the warning message.
IIRC I chose 8 because connection recovered faster in my case.
I have not experienced this issue again (I dropped the patch from
my kernel at some point and the connection stalls did not reappear so
this got fixed elsewhere).
I'd just apply your patch, possibly with an additional comment that
says that we're grasping at straws because some middlebox is evidently
feeding bogus pmtu information.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox