Netdev List
 help / color / mirror / Atom feed
* Re: [PATCH] net: sunhme: fix spelling mistakes: "ParityErro" -> "ParityError"
From: David Miller @ 2017-05-01  2:55 UTC (permalink / raw)
  To: colin.king; +Cc: tremyfr, jarod, tklauser, netdev, linux-kernel
In-Reply-To: <20170429213857.11297-1-colin.king@canonical.com>

From: Colin King <colin.king@canonical.com>
Date: Sat, 29 Apr 2017 22:38:57 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> trivial fix to spelling mistakes in printk message.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

^ permalink raw reply

* Re: [PATCH net v3] driver: dummy: Fix one possbile memleak when fail to register_netdevice
From: David Miller @ 2017-05-01  2:53 UTC (permalink / raw)
  To: gfree.wind; +Cc: sd, phil, stephen, zhangshengju, netdev
In-Reply-To: <1493437186-26727-1-git-send-email-gfree.wind@foxmail.com>


Please, Gao, submit this as a proper, numbered, patch series
with a proper header posting.

That way you can explain why you took this strategy to fix
this problem, compared to your original approach.

Thanks.

^ permalink raw reply

* Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error
From: David Miller @ 2017-05-01  2:52 UTC (permalink / raw)
  To: viro
  Cc: dingtianhong, pabeni, edumazet, hannes, netdev, linux-kernel,
	linuxarm, weiyongjun1
In-Reply-To: <20170429204822.GS29622@ZenIV.linux.org.uk>

From: Al Viro <viro@ZenIV.linux.org.uk>
Date: Sat, 29 Apr 2017 21:48:23 +0100

> On Sat, Apr 29, 2017 at 05:37:38PM +0800, Ding Tianhong wrote:
> 
>> Looks good, if so, we don't need the csum_error any more,
> 
> Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> Dave, I could put that through my tree, but I think it would be better off
> in net.git; either way, it needs to go into mainline before -final...

Please just send it directly to Linus, thanks.

^ permalink raw reply

* Re: [PATCH net] bnx2x: Align RX buffers
From: David Miller @ 2017-05-01  2:50 UTC (permalink / raw)
  To: swood
  Cc: Yuval.Mintz, ariel.elior, everest-linux-l2, netdev, edumazet,
	mschmidt, linuxppc-dev
In-Reply-To: <20170429001741.14563-1-swood@redhat.com>

From: Scott Wood <swood@redhat.com>
Date: Fri, 28 Apr 2017 19:17:41 -0500

> The bnx2x driver is not providing proper alignment on the receive buffers it
> passes to build_skb(), causing skb_shared_info to be misaligned.
> skb_shared_info contains an atomic, and while PPC normally supports
> unaligned accesses, it does not support unaligned atomics.
> 
> Aligning the size of rx buffers will ensure that page_frag_alloc() returns
> aligned addresses.
> 
> This can be reproduced on PPC by setting the network MTU to 1450 (or other
> non-multiple-of-4) and then generating sufficient inbound network traffic
> (one or two large "wget"s usually does it), producing the following oops:
 ...
> Fixes: d46d132cc021 ("bnx2x: use netdev_alloc_frag()")
> Signed-off-by: Scott Wood <swood@redhat.com>

Applied, thanks.

^ permalink raw reply

* Re: [PATCH v3 1/2] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360.
From: David Miller @ 2017-05-01  2:48 UTC (permalink / raw)
  To: eric-WhKQ6XTQaPysTnJN9+BGXg
  Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w,
	vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/,
	andrew-g2DYL2Zd6BY, netdev-u79uwXL29TY76Z2rM5mHXA,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w,
	rjui-dY08KVG/lbpWk0Htik3J/w, sbranden-dY08KVG/lbpWk0Htik3J/w,
	jonmason-dY08KVG/lbpWk0Htik3J/w
In-Reply-To: <20170428222204.7103-1-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>

From: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
Date: Fri, 28 Apr 2017 15:22:03 -0700

> Cygnus is a small family of SoCs, of which we currently have
> devicetree for BCM11360 and BCM58300.  The 11360's B53 is mostly the
> same as 58xx, just requiring a tiny bit of setup that was previously
> missing.
> 
> v2: Reorder the entry in the docs (suggestion by Scott Branden), add
>     missing '"'
> 
> Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
> Reviewed-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

The second patch with the DTS file update doesn't apply cleanly
at all to net-next.

So I'm dropping this series.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply

* Re: [PATCH net-next v3] net: bridge: Fix improper taking over HW learned FDB
From: David Miller @ 2017-05-01  2:46 UTC (permalink / raw)
  To: arkadis; +Cc: netdev, stephen, bridge, idosch, nikolay
In-Reply-To: <1493408347-44779-1-git-send-email-arkadis@mellanox.com>

From: Arkadi Sharshevsky <arkadis@mellanox.com>
Date: Fri, 28 Apr 2017 22:39:07 +0300

> Commit 7e26bf45e4cb ("net: bridge: allow SW learn to take over HW fdb
> entries") added the ability to "take over an entry which was previously
> learned via HW when it shows up from a SW port".
> 
> However, if an entry was learned via HW and then a control packet
> (e.g., ARP request) was trapped to the CPU, the bridge driver will
> update the entry and remove the externally learned flag, although the
> entry is still present in HW. Instead, only clear the externally learned
> flag in case of roaming.
> 
> Fixes: 7e26bf45e4cb ("net: bridge: allow SW learn to take over HW fdb entries")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Signed-off-by: Arkadi Sharashevsky <arkadis@mellanox.com>

Applied, thanks.

^ permalink raw reply

* Re: [PATCH net-next] rtnetlink: Remove NETDEV_CHANGEINFODATA
From: David Miller @ 2017-05-01  2:46 UTC (permalink / raw)
  To: dsa; +Cc: netdev, jiri
In-Reply-To: <1493402785-18844-1-git-send-email-dsa@cumulusnetworks.com>

From: David Ahern <dsa@cumulusnetworks.com>
Date: Fri, 28 Apr 2017 11:06:25 -0700

> NETDEV_CHANGEINFODATA was added by d4261e5650004 ("bonding: create
> netlink event when bonding option is changed"). RTM_NEWLINK
> messages are already created on changelink events, so this event
> is just a duplicate. Remove it.
> 
> Cc: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>

I think you need to respin this, I get rejects when I try to
apply this to net-next.

^ permalink raw reply

* Re: [Patch net-next v2] ipv4: get rid of ip_ra_lock
From: David Miller @ 2017-05-01  2:44 UTC (permalink / raw)
  To: xiyou.wangcong; +Cc: netdev
In-Reply-To: <1493399069-31743-1-git-send-email-xiyou.wangcong@gmail.com>

From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Fri, 28 Apr 2017 10:04:29 -0700

> After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control")
> we always take RTNL lock for ip_ra_control() which is the only place
> we update the list ip_ra_chain, so the ip_ra_lock is no longer needed.
> 
> As Eric points out, BH does not need to disable either, RCU readers
> don't care.
> 
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>

Applied.

^ permalink raw reply

* Re: [net-next PATCH V1] samples/bpf: bpf_load.c detect and abort if ELF maps section size is wrong
From: David Miller @ 2017-05-01  2:43 UTC (permalink / raw)
  To: brouer; +Cc: kafai, netdev, eric, borkmann, alexei.starovoitov
In-Reply-To: <149338948065.27354.8568861008673180957.stgit@firesoul>

From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Fri, 28 Apr 2017 16:25:04 +0200

> The struct bpf_map_def was extended in commit fb30d4b71214 ("bpf: Add tests
> for map-in-map") with member unsigned int inner_map_idx.  This changed the size
> of the maps section in the generated ELF _kern.o files.
> 
> Unfortunately the loader in bpf_load.c does not detect or handle this.  Thus,
> older _kern.o files became incompatible, and caused hard-to-debug errors
> where the syscall validation rejected BPF_MAP_CREATE request.
> 
> This patch only detect the situation and aborts load_bpf_file(). It also
> add code comments warning people that read this loader for inspiration
> for these pitfalls.
> 
> Fixes: fb30d4b71214 ("bpf: Add tests for map-in-map")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>

Applied.

^ permalink raw reply

* Re: [PATCH net-next] lwtunnel: fix error path in lwtunnel_fill_encap()
From: David Miller @ 2017-05-01  2:42 UTC (permalink / raw)
  To: dan.carpenter
  Cc: bianpan2016, roopa, dsa, rshearma, tom, david.lebrun, netdev,
	kernel-janitors
In-Reply-To: <20170428130347.53hagk77wh6scmcs@mwanda>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 28 Apr 2017 16:03:48 +0300

> We recently added a check to see if nla_nest_start() fails.  There are
> two issues with that.  First, if it fails then I don't think we should
> call nla_nest_cancel().  Second, it's slightly convoluted but the
> current code returns success but we should return -EMSGSIZE instead.
> 
> Fixes: a50fe0ffd76f ("lwtunnel: check return value of nla_nest_start")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

^ permalink raw reply

* Re: [PATCH net] liquidio: silence a locking static checker warning
From: David Miller @ 2017-05-01  2:42 UTC (permalink / raw)
  To: dan.carpenter
  Cc: derek.chickles, satananda.burla, felix.manlunas, raghu.vatsavayi,
	netdev, kernel-janitors
In-Reply-To: <20170428125715.h6d5ttnfq7rdnpni@mwanda>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 28 Apr 2017 15:57:15 +0300

> Presumably we never hit this return, but static checkers complain that
> we need to unlock so we may as well fix that.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

^ permalink raw reply

* Re: [PATCH net] qed: Unlock on error in qed_vf_pf_acquire()
From: David Miller @ 2017-05-01  2:42 UTC (permalink / raw)
  To: dan.carpenter
  Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev,
	kernel-janitors
In-Reply-To: <20170428125608.djln5r7h4d53it5s@mwanda>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 28 Apr 2017 15:56:09 +0300

> My static checker complains that we're holding a mutex on this error
> path.  Let's goto exit instead of returning directly.
> 
> Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

^ permalink raw reply

* Re: [PATCH net-next v5 0/2] net: hns: bug fix for HNS driver
From: David Miller @ 2017-05-01  2:39 UTC (permalink / raw)
  To: yankejian
  Cc: salil.mehta, yisen.zhuang, matthias.bgg, lipeng321, zhouhuiru,
	huangdaode, netdev, linuxarm
In-Reply-To: <1493362187-51671-1-git-send-email-yankejian@huawei.com>

From: Yankejian <yankejian@huawei.com>
Date: Fri, 28 Apr 2017 14:49:45 +0800

> From: lipeng <lipeng321@huawei.com>
> 
> This patchset add support defered dsaf probe when mdio and
> mbigen module is not insmod.
> 
> For more details, please refer to individual patch.

Series applied, thanks.

^ permalink raw reply

* Re: [PATCH net-next 0/6] nfp: optimize XDP TX and small fixes
From: David Miller @ 2017-05-01  2:37 UTC (permalink / raw)
  To: jakub.kicinski; +Cc: netdev, oss-drivers, kubakici
In-Reply-To: <20170428040620.8256-1-jakub.kicinski@netronome.com>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 27 Apr 2017 21:06:14 -0700

> This series optimizes the nfp XDP TX performance a little bit.  
> I run quick tests on an Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz.  
> Single core/queue performance for both touch and drop and touch and
> forward is above 20Mpps @64B packets, drop being 2Mpps faster.  
> I think this is max for a single queue on the low power NFPs.
> 
> There are also a few minor fixes included for code in net-next.

Series applied, thanks.

^ permalink raw reply

* Re: [PATCH] drivers:net:ethernet:emulex:benet: Use time_before_eq for time comparison
From: David Miller @ 2017-05-01  2:34 UTC (permalink / raw)
  To: karim.eshapa
  Cc: sathya.perla, ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	netdev, linux-kernel, kaim.eshapa
In-Reply-To: <1493344139-6678-1-git-send-email-karim.eshapa@gmail.com>

From: Karim Eshapa <karim.eshapa@gmail.com>
Date: Fri, 28 Apr 2017 03:48:59 +0200

> Use time_before_eq for time comparison more safe and dealing
> with timer wrapping to be future-proof.
> 
> Signed-off-by: Karim Eshapa <kaim.eshapa@gmail.com>

Subject line has way too many subsystem prefixes, simply
"benet: " is sufficient.

And in situations where multiple subsystem prefixes are
appropriate, one must put a space after each one like
"one: two: three: ".

Thanks.

^ permalink raw reply

* Re: [PATCH net-next] virtio-net: use netif_tx_napi_add for tx napi
From: David Miller @ 2017-05-01  2:33 UTC (permalink / raw)
  To: willemdebruijn.kernel; +Cc: netdev, mst, willemb
In-Reply-To: <20170428003758.48143-1-willemdebruijn.kernel@gmail.com>

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Thu, 27 Apr 2017 20:37:58 -0400

> From: Willem de Bruijn <willemb@google.com>
> 
> Avoid hashing the tx napi struct into napi_hash[], which is used for
> busy polling receive queues.
> 
> Signed-off-by: Willem de Bruijn <willemb@google.com>

Applied.

^ permalink raw reply

* Re: [PATCH net-next] net: Initialise init_net.count to 1
From: David Miller @ 2017-05-01  2:32 UTC (permalink / raw)
  To: dhowells; +Cc: netdev, linux-afs, linux-kernel
In-Reply-To: <149332922378.28919.11614036268701178135.stgit@warthog.procyon.org.uk>

From: David Howells <dhowells@redhat.com>
Date: Thu, 27 Apr 2017 22:40:23 +0100

> Initialise init_net.count to 1 for its pointer from init_nsproxy lest
> someone tries to do a get_net() and a put_net() in a process in which
> current->ns_proxy->net_ns points to the initial network namespace.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied.

^ permalink raw reply

* Re: [PATCH net-next] geneve: fix incorrect setting of UDP checksum flag
From: David Miller @ 2017-05-01  2:31 UTC (permalink / raw)
  To: girish.moodalbail; +Cc: netdev, pshelar
In-Reply-To: <1493327513-23247-1-git-send-email-girish.moodalbail@oracle.com>

From: Girish Moodalbail <girish.moodalbail@oracle.com>
Date: Thu, 27 Apr 2017 14:11:53 -0700

> Creating a geneve link with 'udpcsum' set results in a creation of link
> for which UDP checksum will NOT be computed on outbound packets, as can
> be seen below.
> 
> 11: gen0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN
>     link/ether c2:85:27:b6:b4:15 brd ff:ff:ff:ff:ff:ff promiscuity 0
>     geneve id 200 remote 192.168.13.1 dstport 6081 noudpcsum
> 
> Similarly, creating a link with 'noudpcsum' set results in a creation
> of link for which UDP checksum will be computed on outbound packets.
> 
> Fixes: 9b4437a5b870 ("geneve: Unify LWT and netdev handling.")
> Signed-off-by: Girish Moodalbail <girish.moodalbail@oracle.com>

Applied and queued up for -stable.

^ permalink raw reply

* Re: [PATCH net 0/2] vxlan: do not error out on disabled IPv6
From: David Miller @ 2017-05-01  2:30 UTC (permalink / raw)
  To: jbenc; +Cc: netdev, mleitner
In-Reply-To: <cover.1493320999.git.jbenc@redhat.com>

From: Jiri Benc <jbenc@redhat.com>
Date: Thu, 27 Apr 2017 21:24:34 +0200

> This patchset fixes a bug with metadata based tunnels when booted with
> ipv6.disable=1.

Series applied, thanks.

^ permalink raw reply

* Re: [PATCH v1 3/3] bnx2x: Get rid of useless temporary variable
From: David Miller @ 2017-05-01  2:29 UTC (permalink / raw)
  To: andriy.shevchenko
  Cc: Yuval.Mintz, ariel.elior, everest-linux-l2, netdev,
	andy.shevchenko
In-Reply-To: <20170427133701.72701-3-andriy.shevchenko@linux.intel.com>

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 27 Apr 2017 16:37:01 +0300

> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Replace pattern
> 
>  int status;
>  ...
>  status = func(...);
>  return status;
> 
> by
> 
>  return func(...);
> 
> No functional change intented.
> 
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Applied.

^ permalink raw reply

* Re: [PATCH v1 2/3] bnx2x: Reuse bnx2x_null_format_ver()
From: David Miller @ 2017-05-01  2:29 UTC (permalink / raw)
  To: andriy.shevchenko
  Cc: Yuval.Mintz, ariel.elior, everest-linux-l2, netdev,
	andy.shevchenko
In-Reply-To: <20170427133701.72701-2-andriy.shevchenko@linux.intel.com>

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 27 Apr 2017 16:37:00 +0300

> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Reuse bnx2x_null_format_ver() in functions where it's appropriated
> instead of open coded variant.
> 
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Applied.

^ permalink raw reply

* Re: [PATCH v1 1/3] bnx2x: Replace custom scnprintf()
From: David Miller @ 2017-05-01  2:29 UTC (permalink / raw)
  To: andriy.shevchenko
  Cc: Yuval.Mintz, ariel.elior, everest-linux-l2, netdev,
	andy.shevchenko
In-Reply-To: <20170427133701.72701-1-andriy.shevchenko@linux.intel.com>

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 27 Apr 2017 16:36:59 +0300

> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Use scnprintf() when printing version instead of custom open coded variants.
> 
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Applied.

^ permalink raw reply

* Re: pull-request: can-next 2017-04-25,pull-request: can-next 2017-04-25
From: David Miller @ 2017-05-01  2:26 UTC (permalink / raw)
  To: mkl; +Cc: netdev, kernel, linux-can
In-Reply-To: <17d73df9-8f7a-1458-c4f8-e8153be206d5@pengutronix.de>

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Thu, 27 Apr 2017 09:54:33 +0200

> this is a pull request of 1 patch for net-next/master.
> 
> This patch by Oliver Hartkopp fixes the build of the broad cast manager
> with CONFIG_PROC_FS disabled.

Pulled, thanks!

^ permalink raw reply

* Re: [PATCH net-next] Fix inaccurate helper function description
From: David Miller @ 2017-05-01  2:25 UTC (permalink / raw)
  To: chenbofeng.kernel; +Cc: netdev, mic, fengc
In-Reply-To: <1493250083-1954-1-git-send-email-chenbofeng.kernel@gmail.com>

From: Chenbo Feng <chenbofeng.kernel@gmail.com>
Date: Wed, 26 Apr 2017 16:41:23 -0700

> From: Chenbo Feng <fengc@google.com>
> 
> The description inside uapi/linux/bpf.h about bpf_get_socket_uid
> helper function is no longer valid. It returns overflowuid rather
> than 0 when failed.
> 
> Signed-off-by: Chenbo Feng <fengc@google.com>

Applied.

^ permalink raw reply

* Re: [PATCH net] tcp: fix access to sk->sk_state in tcp_poll()
From: David Miller @ 2017-05-01  2:25 UTC (permalink / raw)
  To: dcaratti; +Cc: kuznet, jmorris, yoshfuji, kaber, weiwan, netdev
In-Reply-To: <0a1710138c3e55c388a52dba817b2d1b1996c899.1493226034.git.dcaratti@redhat.com>

From: Davide Caratti <dcaratti@redhat.com>
Date: Wed, 26 Apr 2017 19:07:35 +0200

> avoid direct access to sk->sk_state when tcp_poll() is called on a socket
> using active TCP fastopen with deferred connect. Use local variable
> 'state', which stores the result of sk_state_load(), like it was done in
> commit 00fd38d938db ("tcp: ensure proper barriers in lockless contexts").
> 
> Fixes: 19f6d3f3c842 ("net/tcp-fastopen: Add new API support")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>

Applied.

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox