* Re: [PATCH net-next] qed: Utilize FW 8.20.0.0
From: David Miller @ 2017-05-18 14:43 UTC (permalink / raw)
To: Yuval.Mintz
Cc: netdev, linux-scsi, Chad.Dupuis, Ram.Amrani, Tomer.Tayar,
Manish.Rangankar
In-Reply-To: <20170518.103428.1194147893495615244.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 18 May 2017 10:34:28 -0400 (EDT)
> From: Yuval Mintz <Yuval.Mintz@cavium.com>
> Date: Wed, 17 May 2017 22:38:40 +0300
>
>> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0
>> firmware. The changes are mostly contained in qed with minor changes
>> to qedi due to some HSI changes.
>>
>> Content-wise, the firmware contains fixes to various issues exposed
>> since the release of the previous firmware, including:
>> - Corrects iSCSI fast retransmit when data digest is enabled.
>> - Stop draining packets when receiving several consecutive PFCs.
>> - Prevent possible assertion when consecutively opening/closing
>> many connections.
>> - Prevent possible assertion due to too long BDQ fetch time.
>>
>> In addition, the new firmware would allow us to later add iWARP support
>> in qed and qedr.
>>
>> Signed-off-by: Chad Dupuis <Chad.Dupuis@cavium.com>
>> Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com>
>> Signed-off-by: Tomer Tayar <Tomer.Tayar@cavium.com>
>> Signed-off-by: Manish Rangankar <Manish.Rangankar@cavium.com>
>> Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
>
> Applied.
Actually I had to revert. Please look at the compiler output before
submitting changes:
drivers/net/ethernet/qlogic/qed/qed_debug.c: In function ‘qed_grc_dump’:
drivers/net/ethernet/qlogic/qed/qed_debug.c:2425:6: warning: ‘addr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
u32 byte_addr = DWORDS_TO_BYTES(addr), offset = 0, i;
^
drivers/net/ethernet/qlogic/qed/qed_debug.c:3534:7: note: ‘addr’ was declared here
u32 addr, size = RSS_REG_RSS_RAM_DATA_SIZE;
^
'addr' is never, ever, assigned a value, yet it is passed into a function as an
argument.
^ permalink raw reply
* [PATCH] xfrm: fix state migration replay sequence numbers
From: Antony Antony @ 2017-05-18 14:39 UTC (permalink / raw)
To: netdev, Herbert Xu, Steffen Klassert; +Cc: Richard Guy Briggs, Antony Antony
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
During xfrm migration replay and preplay sequence numbers are not
copied from the previous state.
Here is tcpdump output showing the problem.
10.0.10.46 is running vanilla kernel, IKE/IPsec responder.
After the migration it sent wrong sequence number, reset to 1.
The migration is from 10.0.0.52 to 10.0.0.53.
IP 10.0.0.52.4500 > 10.0.10.46.4500: UDP-encap: ESP(spi=0x43ef462d,seq=0x7cf), length 136
IP 10.0.10.46.4500 > 10.0.0.52.4500: UDP-encap: ESP(spi=0xca1c282d,seq=0x7cf), length 136
IP 10.0.0.52.4500 > 10.0.10.46.4500: UDP-encap: ESP(spi=0x43ef462d,seq=0x7d0), length 136
IP 10.0.10.46.4500 > 10.0.0.52.4500: UDP-encap: ESP(spi=0xca1c282d,seq=0x7d0), length 136
IP 10.0.0.53.4500 > 10.0.10.46.4500: NONESP-encap: isakmp: child_sa inf2[I]
IP 10.0.10.46.4500 > 10.0.0.53.4500: NONESP-encap: isakmp: child_sa inf2[R]
IP 10.0.0.53.4500 > 10.0.10.46.4500: NONESP-encap: isakmp: child_sa inf2[I]
IP 10.0.10.46.4500 > 10.0.0.53.4500: NONESP-encap: isakmp: child_sa inf2[R]
IP 10.0.0.53.4500 > 10.0.10.46.4500: UDP-encap: ESP(spi=0x43ef462d,seq=0x7d1), length 136
NOTE: next sequence is wrong 0x1
IP 10.0.10.46.4500 > 10.0.0.53.4500: UDP-encap: ESP(spi=0xca1c282d,seq=0x1), length 136
IP 10.0.0.53.4500 > 10.0.10.46.4500: UDP-encap: ESP(spi=0x43ef462d,seq=0x7d2), length 136
IP 10.0.10.46.4500 > 10.0.0.53.4500: UDP-encap: ESP(spi=0xca1c282d,seq=0x2), length 136
The attached patch fix it by copying replay and preplay.
regards,
-antony
Antony Antony (1):
xfrm: fix state migration replay sequence numbers
net/xfrm/xfrm_state.c | 2 ++
1 file changed, 2 insertions(+)
--
2.9.3
[-- Attachment #2: 0001-xfrm-fix-state-migration.patch --]
[-- Type: text/plain, Size: 1017 bytes --]
>From 1241e8b4c38ad2bf7399599165f763af38aba8d9 Mon Sep 17 00:00:00 2001
From: Antony Antony <antony@phenome.org>
Date: Thu, 18 May 2017 12:19:32 +0200
Subject: [PATCH] xfrm: fix state migration copy replay sequence numbers
To: netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>, Steffen Klassert <steffen.klassert@secunet.com>
Cc: Richard Guy Briggs <rgb@tricolour.ca>
During xfrm migration copy replay and preplay sequence numbers
from the previous state.
Signed-off-by: Antony Antony <antony@phenome.org>
---
net/xfrm/xfrm_state.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index fc3c5aa..2e291bc 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -1383,6 +1383,8 @@ static struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig)
x->curlft.add_time = orig->curlft.add_time;
x->km.state = orig->km.state;
x->km.seq = orig->km.seq;
+ x->replay = orig->replay;
+ x->preplay = orig->preplay;
return x;
--
2.9.3
^ permalink raw reply related
* Re: [PATCH net-next 0/3] net: dsa: headers cleanup
From: David Miller @ 2017-05-18 14:36 UTC (permalink / raw)
To: vivien.didelot; +Cc: netdev, linux-kernel, kernel, f.fainelli, andrew
In-Reply-To: <20170517194605.31639-1-vivien.didelot@savoirfairelinux.com>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Wed, 17 May 2017 15:46:02 -0400
> The DSA core files share a common private header file. Include the DSA
> public header there instead of independently in each core source file.
>
> DSA core and its drivers use switchdev, thus include switchdev.h in the
> public DSA header. This allows us to get rid of the forward declaration
> and use typedef defined by switchdev.
This looks fine, series applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next] qed: Utilize FW 8.20.0.0
From: David Miller @ 2017-05-18 14:34 UTC (permalink / raw)
To: Yuval.Mintz
Cc: netdev, linux-scsi, Chad.Dupuis, Ram.Amrani, Tomer.Tayar,
Manish.Rangankar
In-Reply-To: <1495049920-22782-1-git-send-email-Yuval.Mintz@cavium.com>
From: Yuval Mintz <Yuval.Mintz@cavium.com>
Date: Wed, 17 May 2017 22:38:40 +0300
> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0
> firmware. The changes are mostly contained in qed with minor changes
> to qedi due to some HSI changes.
>
> Content-wise, the firmware contains fixes to various issues exposed
> since the release of the previous firmware, including:
> - Corrects iSCSI fast retransmit when data digest is enabled.
> - Stop draining packets when receiving several consecutive PFCs.
> - Prevent possible assertion when consecutively opening/closing
> many connections.
> - Prevent possible assertion due to too long BDQ fetch time.
>
> In addition, the new firmware would allow us to later add iWARP support
> in qed and qedr.
>
> Signed-off-by: Chad Dupuis <Chad.Dupuis@cavium.com>
> Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com>
> Signed-off-by: Tomer Tayar <Tomer.Tayar@cavium.com>
> Signed-off-by: Manish Rangankar <Manish.Rangankar@cavium.com>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next v2] net: fix __skb_try_recv_from_queue to return the old behavior
From: David Miller @ 2017-05-18 14:33 UTC (permalink / raw)
To: avagin; +Cc: netdev, pabeni, edumazet
In-Reply-To: <20170517183905.10971-1-avagin@openvz.org>
From: Andrei Vagin <avagin@openvz.org>
Date: Wed, 17 May 2017 11:39:05 -0700
> This function has to return NULL on a error case, because there is a
> separate error variable.
>
> The offset has to be changed only if skb is returned
>
> v2: fix udp code to not use an extra variable
>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: David S. Miller <davem@davemloft.net>
> Fixes: 65101aeca522 ("net/sock: factor out dequeue/peek with offset cod")
> Signed-off-by: Andrei Vagin <avagin@openvz.org>
Applied.
^ permalink raw reply
* Re: [PATCH net] cxgb4: update latest firmware version supported
From: David Miller @ 2017-05-18 14:32 UTC (permalink / raw)
To: ganeshgr; +Cc: netdev, nirranjan, indranil
In-Reply-To: <1495046296-9009-1-git-send-email-ganeshgr@chelsio.com>
From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Thu, 18 May 2017 00:08:16 +0530
> Change t4fw_version.h to update latest firmware version
> number to 1.16.43.0.
>
> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: make struct dst_entry::dev first member
From: David Miller @ 2017-05-18 14:30 UTC (permalink / raw)
To: adobriyan; +Cc: netdev
In-Reply-To: <20170517163138.GA5269@avx2>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Wed, 17 May 2017 19:31:39 +0300
> struct dst_entry::dev is used most often. Move it so it can be
> accessed without imm8 offset on x86_64.
...
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 7/8] net/wan/fsl_ucc_hdlc: add hdlc-bus support
From: David Miller @ 2017-05-18 14:29 UTC (permalink / raw)
To: holger.brunck; +Cc: netdev, qiang.zhao
In-Reply-To: <20170517152439.8817-7-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Wed, 17 May 2017 17:24:38 +0200
> This adds support for hdlc-bus mode to the fsl_ucc_hdlc driver. This can
> be enabled with the "fsl,hdlc-bus" property in the DTS node of the
> corresponding ucc.
>
> This aligns the configuration of the UPSMR and GUMR registers to what is
> done in our ucc_hdlc driver (that only support hdlc-bus mode) and with
> the QuickEngine's documentation for hdlc-bus mode.
>
> GUMR/SYNL is set to AUTO for the busmode as in this case the CD signal
> is ignored. The brkpt_support is enabled to set the HBM1 bit in the
> CMXUCR register to configure an open-drain connected HDLC bus.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 8/8] powerpc/85xx/kmcent2: use hdlc busmode for UCC1
From: David Miller @ 2017-05-18 14:29 UTC (permalink / raw)
To: holger.brunck; +Cc: netdev
In-Reply-To: <20170517152439.8817-8-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Wed, 17 May 2017 17:24:39 +0200
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 6/8] fsl/qe: add bit description for SYNL register for GUMR
From: David Miller @ 2017-05-18 14:29 UTC (permalink / raw)
To: holger.brunck; +Cc: netdev, qiang.zhao
In-Reply-To: <20170517152439.8817-6-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Wed, 17 May 2017 17:24:37 +0200
> Add the bitmask for the two bit SYNL register according to the QUICK
> Engine Reference Manual.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 5/8] net/wan/fsl_ucc_hdlc: call qe_setbrg only for loopback mode
From: David Miller @ 2017-05-18 14:29 UTC (permalink / raw)
To: holger.brunck; +Cc: netdev, qiang.zhao
In-Reply-To: <20170517152439.8817-5-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Wed, 17 May 2017 17:24:36 +0200
> We can't assume that we are always in loopback mode if rx and tx clock
> have the same clock source. If we want to use HDLC busmode we also have
> the same clock source but we are not in loopback mode. So move the
> setting of the baudrate generator after the check for property for the
> loopback mode.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 4/8] net/wan/fsl_ucc_hdlc: fix incorrect memory allocation
From: David Miller @ 2017-05-18 14:29 UTC (permalink / raw)
To: holger.brunck; +Cc: netdev, qiang.zhao
In-Reply-To: <20170517152439.8817-4-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Wed, 17 May 2017 17:24:35 +0200
> We need space for the struct qe_bd and not for a pointer to this struct.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/8] net/wan/fsl_ucc_hdlc: fix unitialized variable warnings
From: David Miller @ 2017-05-18 14:29 UTC (permalink / raw)
To: holger.brunck; +Cc: netdev, qiang.zhao
In-Reply-To: <20170517152439.8817-2-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Wed, 17 May 2017 17:24:33 +0200
> This fixes the following compiler warnings:
> drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_poll':
> warning: 'skb' may be used uninitialized in this function
> [-Wmaybe-uninitialized]
> skb->mac_header = skb->data - skb->head;
>
> and
>
> drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_probe':
> drivers/net/wan/fsl_ucc_hdlc.c:1127:3: warning: 'utdm' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> kfree(utdm);
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 3/8] net/wan/fsl_ucc_hdlc: fix wrong indentation
From: David Miller @ 2017-05-18 14:29 UTC (permalink / raw)
To: holger.brunck; +Cc: netdev, qiang.zhao
In-Reply-To: <20170517152439.8817-3-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Wed, 17 May 2017 17:24:34 +0200
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/8] net/wan/fsl_ucc_hdlc: cleanup debug traces
From: David Miller @ 2017-05-18 14:29 UTC (permalink / raw)
To: holger.brunck; +Cc: netdev, qiang.zhao
In-Reply-To: <20170517152439.8817-1-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Wed, 17 May 2017 17:24:32 +0200
> Some of the tracing seems to be remaining traces for basic driver
> development. They can be removed now, as they cause noisy printouts.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Cc: Zhao Qiang <qiang.zhao@nxp.com>
Applied.
^ permalink raw reply
* Re: [PATCH net,stable] qmi_wwan: add another Lenovo EM74xx device ID
From: David Miller @ 2017-05-18 14:25 UTC (permalink / raw)
To: bjorn; +Cc: netdev, linux-usb
In-Reply-To: <20170517143141.28483-1-bjorn@mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Wed, 17 May 2017 16:31:41 +0200
> In their infinite wisdom, and never ending quest for end user frustration,
> Lenovo has decided to use a new USB device ID for the wwan modules in
> their 2017 laptops. The actual hardware is still the Sierra Wireless
> EM7455 or EM7430, depending on region.
>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Applied and queued up for -stable, thank you.
^ permalink raw reply
* Re: [PATCH net] sctp: do not inherit ipv6_{mc|ac|fl}_list from parent
From: David Miller @ 2017-05-18 14:24 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, xiyou.wangcong, andreyknvl, vyasevich, nhorman
In-Reply-To: <1495030600.6465.19.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 17 May 2017 07:16:40 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> SCTP needs fixes similar to 83eaddab4378 ("ipv6/dccp: do not inherit
> ipv6_mc_list from parent"), otherwise bad things can happen.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH net] udp: make *udp*_queue_rcv_skb() functions static
From: David Miller @ 2017-05-18 14:23 UTC (permalink / raw)
To: pabeni; +Cc: netdev
In-Reply-To: <8c68f6f2fb91313ab71606e42c4d3d4c561b73a9.1495024097.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Wed, 17 May 2017 14:52:16 +0200
> Since the udp memory accounting refactor, we don't need any more
> to export the *udp*_queue_rcv_skb(). Make them static and fix
> a couple of sparse warnings:
>
> net/ipv4/udp.c:1615:5: warning: symbol 'udp_queue_rcv_skb' was not
> declared. Should it be static?
> net/ipv6/udp.c:572:5: warning: symbol 'udpv6_queue_rcv_skb' was not
> declared. Should it be static?
>
> Fixes: 850cbaddb52d ("udp: use it's own memory accounting schema")
> Fixes: c915fe13cbaa ("udplite: fix NULL pointer dereference")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: make struct net_device::tx_queue_len unsigned int
From: David Miller @ 2017-05-18 14:20 UTC (permalink / raw)
To: adobriyan; +Cc: netdev
In-Reply-To: <20170517103044.GA28488@avx2>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Wed, 17 May 2017 13:30:44 +0300
> 4 billion packet queue is something unthinkable so use 32-bit value
> for now.
>
> Space savings on x86_64:
>
> add/remove: 0/0 grow/shrink: 3/70 up/down: 16/-131 (-115)
> function old new delta
> change_tx_queue_len 94 108 +14
> qdisc_create 1176 1177 +1
> alloc_netdev_mqs 1124 1125 +1
> xenvif_alloc 533 532 -1
> x25_asy_setup 167 166 -1
> ...
> tun_queue_resize 945 940 -5
> pfifo_fast_enqueue 167 162 -5
> qfq_init_qdisc 168 158 -10
> tap_queue_resize 810 799 -11
> transmit 719 698 -21
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH v5 16/17] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate
From: Greg Kroah-Hartman @ 2017-05-18 14:19 UTC (permalink / raw)
To: Stefan Wahren
Cc: Rob Herring, David S. Miller, Mark Rutland, Jiri Slaby,
linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA,
Lino Sanfilippo, Jakub Kicinski
In-Reply-To: <d5533816-5d87-3772-19c0-5e57e519a3f1-eS4NqCHxEME@public.gmane.org>
On Wed, May 17, 2017 at 01:58:05PM +0200, Stefan Wahren wrote:
> Hi Greg,
>
> Am 10.05.2017 um 10:53 schrieb Stefan Wahren:
> > Instead of returning the requested baudrate, we better return the
> > actual one because it isn't always the same.
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
> > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> > drivers/tty/serdev/serdev-ttyport.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
> > index 487c88f..2cfdf34 100644
> > --- a/drivers/tty/serdev/serdev-ttyport.c
> > +++ b/drivers/tty/serdev/serdev-ttyport.c
> > @@ -151,7 +151,7 @@ static unsigned int ttyport_set_baudrate(struct serdev_controller *ctrl, unsigne
> >
> > /* tty_set_termios() return not checked as it is always 0 */
> > tty_set_termios(tty, &ktermios);
> > - return speed;
> > + return ktermios.c_ospeed;
> > }
> >
> > static void ttyport_set_flow_control(struct serdev_controller *ctrl, bool enable)
>
> there is no dependency to this series. I would be happy if this could be
> applied, so i don't have to carry it for the next version.
Ok, I'll take it now.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v4] bridge: netlink: check vlan_default_pvid range
From: David Miller @ 2017-05-18 14:15 UTC (permalink / raw)
To: tobias.jungel; +Cc: sd, nikolay, stephen, netdev
In-Reply-To: <20170517072912.13063-1-tobias.jungel@bisdn.de>
From: Tobias Jungel <tobias.jungel@bisdn.de>
Date: Wed, 17 May 2017 09:29:12 +0200
> Currently it is allowed to set the default pvid of a bridge to a value
> above VLAN_VID_MASK (0xfff). This patch adds a check to br_validate and
> returns -EINVAL in case the pvid is out of bounds.
>
> Reproduce by calling:
>
> [root@test ~]# ip l a type bridge
> [root@test ~]# ip l a type dummy
> [root@test ~]# ip l s bridge0 type bridge vlan_filtering 1
> [root@test ~]# ip l s bridge0 type bridge vlan_default_pvid 9999
> [root@test ~]# ip l s dummy0 master bridge0
> [root@test ~]# bridge vlan
> port vlan ids
> bridge0 9999 PVID Egress Untagged
>
> dummy0 9999 PVID Egress Untagged
>
> Fixes: 0f963b7592ef ("bridge: netlink: add support for default_pvid")
> Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Signed-off-by: Tobias Jungel <tobias.jungel@bisdn.de>
Applied and queued up for -stable, thank you.
^ permalink raw reply
* Re: rtlwifi: rtl8723ae: fix spelling mistake: "Coexistance" -> "Coexistence"
From: Kalle Valo @ 2017-05-18 14:15 UTC (permalink / raw)
To: Colin Ian King
Cc: Larry Finger, Chaoming Li, Joe Perches, Christian Engelmayer,
Arnd Bergmann, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20170513223702.19748-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> wrote:
> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>
> Trivial fix to spelling mistake in RT_TRACE text
>
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Patch applied to wireless-drivers-next.git, thanks.
e8dc072dd50d rtlwifi: rtl8723ae: fix spelling mistake: "Coexistance" -> "Coexistence"
--
https://patchwork.kernel.org/patch/9725457/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: rtlwifi: fix spelling mistake: "Pairwiase" -> "Pairwise"
From: Kalle Valo @ 2017-05-18 14:14 UTC (permalink / raw)
To: Colin Ian King
Cc: Larry Finger, Chaoming Li, Joe Perches, Ping-Ke Shih,
linux-wireless, netdev
In-Reply-To: <20170503225543.10296-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fixes to spelling mistakes in RT_TRACE messages.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
6b9e6f62552e rtlwifi: fix spelling mistake: "Pairwiase" -> "Pairwise"
--
https://patchwork.kernel.org/patch/9710495/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] udp: make function udp_skb_dtor_locked static
From: David Miller @ 2017-05-18 14:13 UTC (permalink / raw)
To: colin.king
Cc: pabeni, kuznet, jmorris, yoshfuji, kaber, netdev, kernel-janitors,
linux-kernel
In-Reply-To: <20170517085036.15261-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Wed, 17 May 2017 09:50:36 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Function udp_skb_dtor_locked does not need to be in global scope
> so make it static to fix sparse warning:
>
> net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not
> declared. Should it be static?
>
> Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Please explcitily say "[PATCH net-next]" in your Subject line next time
so that it is clear what tree your patch is targetting.
Thanks.
^ permalink raw reply
* Re: [PATCH v5] net: ethernet: faraday: To support device tree usage.
From: David Miller @ 2017-05-18 14:11 UTC (permalink / raw)
To: green.hu-Re5JQEeQqe8AvxtiuMwx3w
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA,
andrew-g2DYL2Zd6BY, arnd-r2nGTMty4D4, jiri-rHqAuBHg3fBzbRFIqnYvSA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8
In-Reply-To: <20170517072810.GA4324@app09>
From: Greentime Hu <green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Wed, 17 May 2017 15:28:19 +0800
> To support device tree usage for ftmac100.
>
> Signed-off-by: Greentime Hu <green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox