* [PATCH 0/5] atm: Adjustments for some function implementations
From: SF Markus Elfring @ 2017-05-21 20:12 UTC (permalink / raw)
To: netdev, Augusto Mecking Caringi, David S. Miller, Jarod Wilson,
Javier Martinez Canillas, Kees Cook
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 21 May 2017 22:09:11 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Improve a size determination in four functions
Delete an error message for a failed memory allocation in make_entry()
Adjust 19 checks for null pointers
Use seq_puts() in lec_info()
Use seq_putc() in lec_info()
net/atm/lec.c | 55 +++++++++++++++++++++++++++----------------------------
1 file changed, 27 insertions(+), 28 deletions(-)
--
2.13.0
^ permalink raw reply
* Re: [patch net-next 2/2] net/sched: fix filter flushing
From: Jiri Pirko @ 2017-05-21 19:19 UTC (permalink / raw)
To: Cong Wang
Cc: Linux Kernel Network Developers, David Miller, Jamal Hadi Salim,
Eric Dumazet, Daniel Borkmann, Simon Horman, mlxsw, Colin King
In-Reply-To: <CAM_iQpVPuC-FQ3R4QNDCBWxrX5s7Q4bENxMU7+1LooCdHdMZhw@mail.gmail.com>
Sun, May 21, 2017 at 08:27:21PM CEST, xiyou.wangcong@gmail.com wrote:
>On Sat, May 20, 2017 at 10:54 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>> Sun, May 21, 2017 at 02:16:45AM CEST, xiyou.wangcong@gmail.com wrote:
>>>On Sat, May 20, 2017 at 6:01 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>>> +static void tcf_chain_destroy(struct tcf_chain *chain)
>>>> +{
>>>> + list_del(&chain->list);
>>>> + tcf_chain_flush(chain);
>>>> kfree(chain);
>>>> }
>>>>
>>>> @@ -510,7 +517,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
>>>>
>>>> if (n->nlmsg_type == RTM_DELTFILTER && prio == 0) {
>>>> tfilter_notify_chain(net, skb, n, chain, RTM_DELTFILTER);
>>>> - tcf_chain_destroy(chain);
>>>> + tcf_chain_flush(chain);
>>>
>>>
>>>I wonder if we should return EBUSY and do nothing in case of busy?
>>>The chain is no longer visual to new actions after your list_del(), but
>>>the old one could still use and see it.
>>
>> No. User request to flush the chain, that is what happens in the past
>> and that is what should happen now.
>> If there is still a reference, the chain_put will keep the empty chain.
>
>But if you dump the actions, this chain is still shown "goto chain"?
Yes, it will be shown there.
>You can't claim you really delete it as long as actions can still
>see it and dump it.
No, user just wants to delete all the filters. That is done. User does
not care if the actual chain structure is there or not.
^ permalink raw reply
* [PATCH net-next] net: socket: fix a typo in sockfd_lookup().
From: Rami Rosen @ 2017-05-21 19:12 UTC (permalink / raw)
To: davem; +Cc: netdev, Rami Rosen
This patch fixes a typo in sockfd_lookup() in net/socket.c.
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
net/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/socket.c b/net/socket.c
index cb355a7..8f9dab3 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -461,7 +461,7 @@ EXPORT_SYMBOL(sock_from_file);
* @err: pointer to an error code return
*
* The file handle passed in is locked and the socket it is bound
- * too is returned. If an error occurs the err pointer is overwritten
+ * to is returned. If an error occurs the err pointer is overwritten
* with a negative errno code and NULL is returned. The function checks
* for both invalid handles and passing a handle which is not a socket.
*
--
2.7.4
^ permalink raw reply related
* Re: [patch net-next 2/2] net/sched: fix filter flushing
From: Cong Wang @ 2017-05-21 18:27 UTC (permalink / raw)
To: Jiri Pirko
Cc: Linux Kernel Network Developers, David Miller, Jamal Hadi Salim,
Eric Dumazet, Daniel Borkmann, Simon Horman, mlxsw, Colin King
In-Reply-To: <20170521055416.GA1848@nanopsycho>
On Sat, May 20, 2017 at 10:54 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> Sun, May 21, 2017 at 02:16:45AM CEST, xiyou.wangcong@gmail.com wrote:
>>On Sat, May 20, 2017 at 6:01 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>> +static void tcf_chain_destroy(struct tcf_chain *chain)
>>> +{
>>> + list_del(&chain->list);
>>> + tcf_chain_flush(chain);
>>> kfree(chain);
>>> }
>>>
>>> @@ -510,7 +517,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
>>>
>>> if (n->nlmsg_type == RTM_DELTFILTER && prio == 0) {
>>> tfilter_notify_chain(net, skb, n, chain, RTM_DELTFILTER);
>>> - tcf_chain_destroy(chain);
>>> + tcf_chain_flush(chain);
>>
>>
>>I wonder if we should return EBUSY and do nothing in case of busy?
>>The chain is no longer visual to new actions after your list_del(), but
>>the old one could still use and see it.
>
> No. User request to flush the chain, that is what happens in the past
> and that is what should happen now.
> If there is still a reference, the chain_put will keep the empty chain.
But if you dump the actions, this chain is still shown "goto chain"?
You can't claim you really delete it as long as actions can still
see it and dump it.
^ permalink raw reply
* Re: [PATCH net-next] tcp: fix tcp_probe_timer() for TCP_USER_TIMEOUT
From: Eric Dumazet @ 2017-05-21 18:01 UTC (permalink / raw)
To: Soheil Hassas Yeganeh; +Cc: David Miller, netdev
In-Reply-To: <CACSApvaY+fBwG5dGM-hiYF-51vLzn2D8V-PM5JP_=Pa8hru3xw@mail.gmail.com>
On Sun, 2017-05-21 at 13:46 -0400, Soheil Hassas Yeganeh wrote:
> On Sun, May 21, 2017 at 1:39 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > TCP_USER_TIMEOUT is still converted to jiffies value in
> > icsk_user_timeout
> >
> > So we need to make a conversion for the cases HZ != 1000
> >
> > Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
>
> Thank you for the fix, Eric!
Thanks for reviewing !
^ permalink raw reply
* Re: [PATCH net-next] tcp: fix tcp_probe_timer() for TCP_USER_TIMEOUT
From: Eric Dumazet @ 2017-05-21 18:00 UTC (permalink / raw)
To: David Miller; +Cc: netdev, soheil
In-Reply-To: <20170521.135111.1511992009561369461.davem@davemloft.net>
On Sun, 2017-05-21 at 13:51 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Sun, 21 May 2017 10:39:00 -0700
>
> > From: Eric Dumazet <edumazet@google.com>
> >
> > TCP_USER_TIMEOUT is still converted to jiffies value in
> > icsk_user_timeout
> >
> > So we need to make a conversion for the cases HZ != 1000
> >
> > Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Applied, thank Eric.
>
> I kinda expected a few pieces of fallout from the 1ms changes :)
Absolutely ;)
One last piece is in TCP_SYNCNT support.
I saw that retransmits_timed_out() could have a rounding error :
tcp_time_stamp(tcp_sk(sk)) - start_ts) ends up to 999 ms,
while the timeout is/was 1000 ms (And timer _was_ progammed with 1000
jiffies for HZ=1000 kernel)
So if user setup TCP_SYNCNT = 1 socket option, we sometime sends one
extra SYN packet.
I will send a fix later.
^ permalink raw reply
* Re: [PATCH net-next] tcp: fix tcp_probe_timer() for TCP_USER_TIMEOUT
From: David Miller @ 2017-05-21 17:51 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, soheil
In-Reply-To: <1495388340.6465.50.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 21 May 2017 10:39:00 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> TCP_USER_TIMEOUT is still converted to jiffies value in
> icsk_user_timeout
>
> So we need to make a conversion for the cases HZ != 1000
>
> Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thank Eric.
I kinda expected a few pieces of fallout from the 1ms changes :)
^ permalink raw reply
* Re: [PATCH net-next] tcp: fix tcp_probe_timer() for TCP_USER_TIMEOUT
From: Soheil Hassas Yeganeh @ 2017-05-21 17:46 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev
In-Reply-To: <1495388340.6465.50.camel@edumazet-glaptop3.roam.corp.google.com>
On Sun, May 21, 2017 at 1:39 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> TCP_USER_TIMEOUT is still converted to jiffies value in
> icsk_user_timeout
>
> So we need to make a conversion for the cases HZ != 1000
>
> Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Thank you for the fix, Eric!
^ permalink raw reply
* Re: [PATCH net-next 9/9] ipv6: remove unused variables in esp6
From: David Miller @ 2017-05-21 17:44 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin, steffen.klassert
In-Reply-To: <20170519165556.483-10-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:56 -0700
> Resolves warnings:
> net/ipv6/esp6.c: In function ‘esp_ssg_unref’:
> net/ipv6/esp6.c:121:10: warning: variable ‘seqhi’ set but not used [-Wunused-but-set-variable]
> net/ipv6/esp6.c: In function ‘esp6_output_head’:
> net/ipv6/esp6.c:227:21: warning: variable ‘esph’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Stephen please always CC: the IPSEC maintainer for IPSEC implementation
fixes.
Steffen, please consider taking this into your tree.
> ---
> net/ipv6/esp6.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
> index 1fe99ba8066c..53b6b870b935 100644
> --- a/net/ipv6/esp6.c
> +++ b/net/ipv6/esp6.c
> @@ -118,7 +118,6 @@ static inline struct scatterlist *esp_req_sg(struct crypto_aead *aead,
>
> static void esp_ssg_unref(struct xfrm_state *x, void *tmp)
> {
> - __be32 *seqhi;
> struct crypto_aead *aead = x->data;
> int seqhilen = 0;
> u8 *iv;
> @@ -128,7 +127,6 @@ static void esp_ssg_unref(struct xfrm_state *x, void *tmp)
> if (x->props.flags & XFRM_STATE_ESN)
> seqhilen += sizeof(__be32);
>
> - seqhi = esp_tmp_seqhi(tmp);
> iv = esp_tmp_iv(aead, tmp, seqhilen);
> req = esp_tmp_req(aead, iv);
>
> @@ -224,12 +222,9 @@ int esp6_output_head(struct xfrm_state *x, struct sk_buff *skb, struct esp_info
> u8 *vaddr;
> int nfrags;
> struct page *page;
> - struct ip_esp_hdr *esph;
> struct sk_buff *trailer;
> int tailen = esp->tailen;
>
> - esph = ip_esp_hdr(skb);
> -
> if (!skb_cloned(skb)) {
> if (tailen <= skb_availroom(skb)) {
> nfrags = 1;
> --
> 2.11.0
>
^ permalink raw reply
* Re: [PATCH net-next 8/9] ipv6: drop unused variables in seg6_genl_dumphac
From: David Miller @ 2017-05-21 17:43 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
In-Reply-To: <20170519165556.483-9-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:55 -0700
> THe seg6_pernet_data variable was set but never used.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 7/9] fou: make local function static
From: David Miller @ 2017-05-21 17:43 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
In-Reply-To: <20170519165556.483-8-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:54 -0700
> The build header functions are not used by any other code.
>
> net/ipv6/fou6.c:36:5: warning: no previous prototype for ‘fou6_build_header’ [-Wmissing-prototypes]
> net/ipv6/fou6.c:54:5: warning: no previous prototype for ‘gue6_build_header’ [-Wmissing-prototypes]
>
> Need to do some code rearranging to satisfy different Kconfig possiblities.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 6/9] xfrm: make xfrm_dev_register static
From: David Miller @ 2017-05-21 17:43 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
In-Reply-To: <20170519165556.483-7-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:53 -0700
> This function is only used in this file and should not be global.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Steffen said he already took this.
^ permalink raw reply
* Re: [PATCH net-next 5/9] tcpnv: do not export local function
From: David Miller @ 2017-05-21 17:43 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
In-Reply-To: <20170519165556.483-6-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:52 -0700
> The TCP New Vegas congestion control was exporting an internal
> function tcpnv_get_info which is not used by any other in tree
> kernel code. Make it static.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 4/9] inet: fix warning about missing prototype
From: David Miller @ 2017-05-21 17:43 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
In-Reply-To: <20170519165556.483-5-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:51 -0700
> The prototype for inet_rcv_saddr_equal was not being included.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 3/9] udp: make local function static
From: David Miller @ 2017-05-21 17:43 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
In-Reply-To: <20170519165556.483-4-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:50 -0700
> udp_queue_rcv_skb was global but only used in one file.
> Identified by this warning:
> net/ipv4/udp.c:1775:5: warning: no previous prototype for ‘udp_queue_rcv_skb’ [-Wmissing-prototypes]
> int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Already fixed in net-next, please generate patches against
current sources.
^ permalink raw reply
* Re: [PATCH net-next 2/9] ila: propagate error code in ila_output
From: David Miller @ 2017-05-21 17:43 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
In-Reply-To: <20170519165556.483-3-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:49 -0700
> This warning:
> net/ipv6/ila/ila_lwt.c: In function ‘ila_output’:
> net/ipv6/ila/ila_lwt.c:42:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
>
> It looks like the code attempts to set propagate different error
> values, but always returned -EINVAL.
>
> Compile tested only. Needs review by original author.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/9] dcb: enforce minimum length on IEEE_APPS attribute
From: David Miller @ 2017-05-21 17:42 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
In-Reply-To: <20170519165556.483-2-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:48 -0700
> Found by reviewing the warning about unused policy table.
> The code implies that it meant to check for size, but since
> it unrolled the loop for attribute validation that is never used.
> Instead do explicit check for attribute.
>
> Compile tested only. Needs review by original author.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied.
^ permalink raw reply
* [PATCH net-next] tcp: fix tcp_probe_timer() for TCP_USER_TIMEOUT
From: Eric Dumazet @ 2017-05-21 17:39 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Soheil Hassas Yeganeh
From: Eric Dumazet <edumazet@google.com>
TCP_USER_TIMEOUT is still converted to jiffies value in
icsk_user_timeout
So we need to make a conversion for the cases HZ != 1000
Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/ipv4/tcp_timer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c
index 27a667bce8060e6b2290fe636c27a79d0d593b48..c4a35ba7f8ed0dac573c864900b081b4847927d8 100644
--- a/net/ipv4/tcp_timer.c
+++ b/net/ipv4/tcp_timer.c
@@ -341,7 +341,8 @@ static void tcp_probe_timer(struct sock *sk)
if (!start_ts)
tcp_send_head(sk)->skb_mstamp = tp->tcp_mstamp;
else if (icsk->icsk_user_timeout &&
- (s32)(tcp_time_stamp(tp) - start_ts) > icsk->icsk_user_timeout)
+ (s32)(tcp_time_stamp(tp) - start_ts) >
+ jiffies_to_msecs(icsk->icsk_user_timeout))
goto abort;
max_probes = sock_net(sk)->ipv4.sysctl_tcp_retries2;
^ permalink raw reply related
* Re: [PATCH v6 net-next 0/7] Extend socket timestamping API
From: David Miller @ 2017-05-21 17:38 UTC (permalink / raw)
To: mlichvar; +Cc: netdev, richardcochran, willemb
In-Reply-To: <20170519155241.15817-1-mlichvar@redhat.com>
From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Fri, 19 May 2017 17:52:34 +0200
> This patchset adds new options to the timestamping API that will be
> useful for NTP implementations and possibly other applications.
>
> The first patch specifies a timestamp filter for NTP packets. The second
> patch updates drivers that can timestamp all packets, or need to list
> the filter as unsupported. There is no attempt to add the support to the
> phyter driver.
>
> The third patch adds two helper functions working with NAPI ID, which is
> needed by the next patch. The fourth patch adds a new option to get a
> new control message with the L2 length and interface index for incoming
> packets with hardware timestamps.
>
> The fifth patch fixes documentation on number of non-zero fields in
> scm_timestamping and warns about false software timestamps when
> SO_TIMESTAMP(NS) is combined with SCM_TIMESTAMPING.
>
> The sixth patch adds a new option to request both software and hardware
> timestamps for outgoing packets. The seventh patch updates drivers that
> assumed software timestamping cannot be used together with hardware
> timestamping.
>
> The patches have been tested on x86_64 machines with igb and e1000e
> drivers.
Series applied, thanks.
^ permalink raw reply
* Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start
From: David Miller @ 2017-05-21 17:34 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, nikolay, cera
In-Reply-To: <6e78bfea3969ca1a937b37e28e796a3047b82615.1495203629.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Fri, 19 May 2017 22:20:29 +0800
> Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop
> kernel hello and hold timers"), bridge would not start hello_timer if
> stp_enabled is not KERNEL_STP when br_dev_open.
>
> The problem is even if users set stp_enabled with KERNEL_STP later,
> the timer will still not be started. It causes that KERNEL_STP can
> not really work. Users have to re-ifup the bridge to avoid this.
>
> This patch is to fix it by starting br->hello_timer when enabling
> KERNEL_STP in br_stp_start.
>
> As an improvement, it's also to start hello_timer again only when
> br->stp_enabled is KERNEL_STP in br_hello_timer_expired, there is
> no reason to start the timer again when it's NO_STP.
>
> Fixes: 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers")
> Reported-by: Haidong Li <haili@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH v2 net] smsc95xx: Support only IPv4 TCP/UDP csum offload
From: David Miller @ 2017-05-21 17:32 UTC (permalink / raw)
To: Nisar.Sayed; +Cc: netdev, UNGLinuxDriver, steve.glendinning, popcornmix
In-Reply-To: <CE371C1263339941885964188A0225FA308E06@CHN-SV-EXMX03.mchp-main.com>
From: <Nisar.Sayed@microchip.com>
Date: Fri, 19 May 2017 14:00:25 +0000
> From: Nisar Sayed <Nisar.Sayed@microchip.com>
>
> When TX checksum offload is used, if the computed checksum is 0 the
> LAN95xx device do not alter the checksum to 0xffff. In the case of ipv4
> UDP checksum, it indicates to receiver that no checksum is calculated.
> Under ipv6, UDP checksum yields a result of zero must be changed to
> 0xffff. Hence disabling checksum offload for ipv6 packets.
>
> Signed-off-by: Nisar Sayed <Nisar.Sayed@microchip.com>
>
> Reported-by: popcorn mix <popcornmix@gmail.com>
Appied, thanks.
^ permalink raw reply
* Re: [PATCH net-next] cxgb4 : retrieve port information from firmware
From: David Miller @ 2017-05-21 17:30 UTC (permalink / raw)
To: ganeshgr; +Cc: netdev, nirranjan, indranil, leedom
In-Reply-To: <1495196415-22234-1-git-send-email-ganeshgr@chelsio.com>
From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Fri, 19 May 2017 17:50:15 +0530
> issue get port information command to firmware to retrieve port
> information and update if it is different from what was last
> recorded and also add indication for supported link modes for
> firmware port types FW_PORT_TYPE_SFP28, FW_PORT_TYPE_KR_SFP28,
> FW_PORT_TYPE_CR4_QSFP.
>
> Based on the original work by Casey Leedom <leedom@chelsio.com>
>
> Signed-off-by: Casey Leedom <leedom@chelsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next v2] ibmveth: Support to enable LSO/CSO for Trunk VEA.
From: David Miller @ 2017-05-21 17:29 UTC (permalink / raw)
To: ksiva
Cc: netdev, tlfalcon, benh, paulus, mpe, linuxppc-dev, linux-kernel,
brking, seroyer, bryantly
In-Reply-To: <1495186238-19058-1-git-send-email-ksiva@linux.vnet.ibm.com>
From: Sivakumar Krishnasamy <ksiva@linux.vnet.ibm.com>
Date: Fri, 19 May 2017 05:30:38 -0400
...
> Signed-off-by: Sivakumar Krishnasamy <ksiva@linux.vnet.ibm.com>
Applied, thanks for the more detailed commit message.
^ permalink raw reply
* Re: [PATCH 1/4] net-next: stmmac: Convert new_state to bool
From: David Miller @ 2017-05-21 17:28 UTC (permalink / raw)
To: clabbe.montjoie; +Cc: peppe.cavallaro, alexandre.torgue, netdev, linux-kernel
In-Reply-To: <20170519070335.1604-2-clabbe.montjoie@gmail.com>
From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Fri, 19 May 2017 09:03:32 +0200
> This patch convert new_state from int to bool since it store only 1 or 0
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
You must also change it to use the values "true" and "false" as well.
Thanks.
^ permalink raw reply
* Re: [PATCH v2 0/4] arp: always override existing neigh entries with gratuitous ARP
From: David Miller @ 2017-05-21 17:27 UTC (permalink / raw)
To: ihrachys; +Cc: ja, netdev
In-Reply-To: <cover.1495136258.git.ihrachys@redhat.com>
From: Ihar Hrachyshka <ihrachys@redhat.com>
Date: Thu, 18 May 2017 12:41:17 -0700
> This patchset is spurred by discussion started at
> https://patchwork.ozlabs.org/patch/760372/ where we figured that there is no
> real reason for enforcing override by gratuitous ARP packets only when
> arp_accept is 1. Same should happen when it's 0 (the default value).
>
> changelog v2: handled review comments by Julian Anastasov
> - fixed a mistake in a comment;
> - postponed addr_type calculation to as late as possible.
Series applied, thanks.
Please address the feedback from Julian about the ieee1394 change
you put into ARP earlier.
Thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox