* Re: [patch net-next 3/3] net/sched: Change act_api and act_xxx modules to use IDR
From: Jamal Hadi Salim @ 2017-08-28 21:56 UTC (permalink / raw)
To: Chris Mi, netdev; +Cc: xiyou.wangcong, jiri, davem, mawilcox
In-Reply-To: <1503902477-39829-4-git-send-email-chrism@mellanox.com>
On 17-08-28 02:41 AM, Chris Mi wrote:
> Typically, each TC filter has its own action. All the actions of the
> same type are saved in its hash table. But the hash buckets are too
> small that it degrades to a list. And the performance is greatly
> affected. For example, it takes about 0m11.914s to insert 64K rules.
> If we convert the hash table to IDR, it only takes about 0m1.500s.
> The improvement is huge.
>
> But please note that the test result is based on previous patch that
> cls_flower uses IDR.
>
> Signed-off-by: Chris Mi <chrism@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
^ permalink raw reply
* Re: [PATCH net-next 1/3] if_ether: add forces ife lfb type
From: Jamal Hadi Salim @ 2017-08-28 22:03 UTC (permalink / raw)
To: Alexander Aring
Cc: yotamg, xiyou.wangcong, jiri, lucasb, netdev, linux-kselftest
In-Reply-To: <20170828190315.26646-2-aring@mojatatu.com>
On 17-08-28 03:03 PM, Alexander Aring wrote:
> This patch adds the forces IFE lfb type according to IEEE registered
> ethertypes. See http://standards-oui.ieee.org/ethertype/eth.txt for more
> information. Since there exists the IFE subsystem it can be used there.
>
> This patch also use the correct word "ForCES" instead of "FoRCES" which
> is a spelling error inside the IEEE ethertype specification.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
^ permalink raw reply
* Re: [PATCH net-next 0/3] gre: add collect_md mode for ERSPAN tunnel
From: David Miller @ 2017-08-28 22:06 UTC (permalink / raw)
To: u9012063; +Cc: netdev
In-Reply-To: <1503678089-27131-1-git-send-email-u9012063@gmail.com>
From: William Tu <u9012063@gmail.com>
Date: Fri, 25 Aug 2017 09:21:26 -0700
> This patch series provide collect_md mode for ERSPAN tunnel. The fist patch
> refactors the existing gre_fb_xmit function by exacting the route cache
> portion into a new function called prepare_fb_xmit. The second patch
> introduces the collect_md mode for ERSPAN tunnel, by calling the
> prepare_fb_xmit function and adding ERSPAN specific logic. The final patch
> adds the test case using bpf_skb_{set,get}_tunnel_{key,opt}.
Series applied, thanks William.
^ permalink raw reply
* Re: [PATCH net-next 2/3] act_ife: use registered ife_type as fallback
From: Jamal Hadi Salim @ 2017-08-28 22:14 UTC (permalink / raw)
To: Alexander Aring
Cc: yotamg, xiyou.wangcong, jiri, lucasb, netdev, linux-kselftest
In-Reply-To: <20170828190315.26646-3-aring@mojatatu.com>
On 17-08-28 03:03 PM, Alexander Aring wrote:
> This patch handles a default IFE type if it's not given by user space
> netlink api. The default IFE type will be the registered ethertype by
> IEEE for IFE ForCES.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
^ permalink raw reply
* [PATCH net-next] net: Add comment that early_demux can change via sysctl
From: David Ahern @ 2017-08-28 22:14 UTC (permalink / raw)
To: netdev; +Cc: David Ahern
Twice patches trying to constify inet{6}_protocol have been reverted:
39294c3df2a8 ("Revert "ipv6: constify inet6_protocol structures"") to
revert 3a3a4e3054137 and then 03157937fe0b5 ("Revert "ipv4: make
net_protocol const"") to revert aa8db499ea67.
Add a comment that the structures can not be const because the
early_demux field can change based on a sysctl.
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/ipv4/af_inet.c | 6 ++++++
net/ipv6/tcp_ipv6.c | 3 +++
net/ipv6/udp.c | 3 +++
3 files changed, 12 insertions(+)
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index d678820e4306..e31108e5ef79 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1596,6 +1596,9 @@ static const struct net_protocol igmp_protocol = {
};
#endif
+/* thinking of making this const? Don't.
+ * early_demux can change based on sysctl.
+ */
static struct net_protocol tcp_protocol = {
.early_demux = tcp_v4_early_demux,
.early_demux_handler = tcp_v4_early_demux,
@@ -1606,6 +1609,9 @@ static struct net_protocol tcp_protocol = {
.icmp_strict_tag_validation = 1,
};
+/* thinking of making this const? Don't.
+ * early_demux can change based on sysctl.
+ */
static struct net_protocol udp_protocol = {
.early_demux = udp_v4_early_demux,
.early_demux_handler = udp_v4_early_demux,
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index abba3bc2a3d9..38f76d8b231e 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1949,6 +1949,9 @@ struct proto tcpv6_prot = {
.diag_destroy = tcp_abort,
};
+/* thinking of making this const? Don't.
+ * early_demux can change based on sysctl.
+ */
static struct inet6_protocol tcpv6_protocol = {
.early_demux = tcp_v6_early_demux,
.early_demux_handler = tcp_v6_early_demux,
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 2a15f1bb6ef8..976f30391356 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -1472,6 +1472,9 @@ int compat_udpv6_getsockopt(struct sock *sk, int level, int optname,
}
#endif
+/* thinking of making this const? Don't.
+ * early_demux can change based on sysctl.
+ */
static struct inet6_protocol udpv6_protocol = {
.early_demux = udp_v6_early_demux,
.early_demux_handler = udp_v6_early_demux,
--
2.1.4
^ permalink raw reply related
* Re: [PATCH net-next 3/3] tc-testing: add test for testing ife type
From: Jamal Hadi Salim @ 2017-08-28 22:16 UTC (permalink / raw)
To: Alexander Aring
Cc: yotamg, xiyou.wangcong, jiri, lucasb, netdev, linux-kselftest
In-Reply-To: <20170828190315.26646-4-aring@mojatatu.com>
On 17-08-28 03:03 PM, Alexander Aring wrote:
> This patch adds a new testcase for the IFE type setting in tc. In case
> of user specified the type it will check if the ife is correctly
> configured to react on it. If it's not specified the default IFE type
> should be used.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
We should add the tests which do filter binding as well
(both auto-binding and late binding)
cheers,
jamal
^ permalink raw reply
* Re: [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero
From: Jamal Hadi Salim @ 2017-08-28 22:16 UTC (permalink / raw)
To: Alexander Aring; +Cc: yotamg, xiyou.wangcong, jiri, netdev
In-Reply-To: <20170828190738.26829-2-aring@mojatatu.com>
On 17-08-28 03:07 PM, Alexander Aring wrote:
> This patch allows to set an ethertype for IFE which is zero. There is no
> kernel side validation which forbids a type to zero.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
^ permalink raw reply
* Re: [PATCH net-next] net: Add comment that early_demux can change via sysctl
From: David Miller @ 2017-08-28 22:17 UTC (permalink / raw)
To: dsahern; +Cc: netdev
In-Reply-To: <1503958460-20765-1-git-send-email-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Mon, 28 Aug 2017 15:14:20 -0700
> Twice patches trying to constify inet{6}_protocol have been reverted:
> 39294c3df2a8 ("Revert "ipv6: constify inet6_protocol structures"") to
> revert 3a3a4e3054137 and then 03157937fe0b5 ("Revert "ipv4: make
> net_protocol const"") to revert aa8db499ea67.
>
> Add a comment that the structures can not be const because the
> early_demux field can change based on a sysctl.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] xen-netback: update ubuf_info initialization to anonymous union
From: David Miller @ 2017-08-28 22:17 UTC (permalink / raw)
To: willemdebruijn.kernel; +Cc: netdev, wei.liu2, paul.durrant, kbuild-all, willemb
In-Reply-To: <20170825171043.84011-1-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Fri, 25 Aug 2017 13:10:43 -0400
> From: Willem de Bruijn <willemb@google.com>
>
> The xen driver initializes struct ubuf_info fields using designated
> initializers. I recently moved these fields inside a nested anonymous
> struct inside an anonymous union. I had missed this use case.
>
> This breaks compilation of xen-netback with older compilers.
> From kbuild bot with gcc-4.4.7:
>
> drivers/net//xen-netback/interface.c: In function
> 'xenvif_init_queue':
> >> drivers/net//xen-netback/interface.c:554: error: unknown field 'ctx' specified in initializer
> >> drivers/net//xen-netback/interface.c:554: warning: missing braces around initializer
> drivers/net//xen-netback/interface.c:554: warning: (near initialization for '(anonymous).<anonymous>')
> >> drivers/net//xen-netback/interface.c:554: warning: initialization makes integer from pointer without a cast
> >> drivers/net//xen-netback/interface.c:555: error: unknown field 'desc' specified in initializer
>
> Add double braces around the designated initializers to match their
> nested position in the struct. After this, compilation succeeds again.
>
> Fixes: 4ab6c99d99bb ("sock: MSG_ZEROCOPY notification coalescing")
> Reported-by: kbuild bot <lpk@intel.com>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
APplied.
^ permalink raw reply
* Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format
From: Jamal Hadi Salim @ 2017-08-28 22:18 UTC (permalink / raw)
To: Alexander Aring; +Cc: yotamg, xiyou.wangcong, jiri, netdev
In-Reply-To: <20170828190738.26829-3-aring@mojatatu.com>
Alex,
I think we should get rid of these fprintfs instead of fixing them.
They were originally intended to be debug outputs.
cheers,
jamal
On 17-08-28 03:07 PM, Alexander Aring wrote:
> This patch uses the usually IEEE format to display an ethertype which is
> 4-digits and every digit in upper case.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
> ---
> tc/m_ife.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tc/m_ife.c b/tc/m_ife.c
> index e05e2276..7b57130e 100644
> --- a/tc/m_ife.c
> +++ b/tc/m_ife.c
> @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
> NEXT_ARG();
> if (get_u16(&ife_type, *argv, 0))
> invarg("ife type is invalid", *argv);
> - fprintf(stderr, "IFE type 0x%x\n", ife_type);
> + fprintf(stderr, "IFE type 0x%04X\n", ife_type);
> user_type = 1;
> } else if (matches(*argv, "dst") == 0) {
> NEXT_ARG();
>
^ permalink raw reply
* Re: [PATCH iproute2 3/4] tc: m_ife: report about kernels default type
From: Jamal Hadi Salim @ 2017-08-28 22:18 UTC (permalink / raw)
To: Alexander Aring; +Cc: yotamg, xiyou.wangcong, jiri, netdev
In-Reply-To: <20170828190738.26829-4-aring@mojatatu.com>
Same comment as previous patch.
cheers,
jamal
On 17-08-28 03:07 PM, Alexander Aring wrote:
> This patch will report about if the ethertype for IFE is not specified
> that the default IFE type is used.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
> ---
> tc/m_ife.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tc/m_ife.c b/tc/m_ife.c
> index 7b57130e..5633ab90 100644
> --- a/tc/m_ife.c
> +++ b/tc/m_ife.c
> @@ -189,6 +189,8 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
> addattr_l(n, MAX_MSG, TCA_IFE_DMAC, dbuf, ETH_ALEN);
> if (user_type)
> addattr_l(n, MAX_MSG, TCA_IFE_TYPE, &ife_type, 2);
> + else
> + fprintf(stderr, "IFE type 0x%04X\n", ETH_P_IFE);
> if (saddr)
> addattr_l(n, MAX_MSG, TCA_IFE_SMAC, sbuf, ETH_ALEN);
>
>
^ permalink raw reply
* Re: [PATCH iproute2 4/4] man: tc-ife: add default type note
From: Jamal Hadi Salim @ 2017-08-28 22:19 UTC (permalink / raw)
To: Alexander Aring; +Cc: yotamg, xiyou.wangcong, jiri, netdev
In-Reply-To: <20170828190738.26829-5-aring@mojatatu.com>
On 17-08-28 03:07 PM, Alexander Aring wrote:
> This patch updates the tc-ife man page that the default IFE ethertype
> will be used if it's not specified.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
^ permalink raw reply
* Re: [PATCH net 0/3] fix layer calculation and flow dissector use
From: David Miller @ 2017-08-28 22:20 UTC (permalink / raw)
To: pieter.jansenvanvuuren; +Cc: netdev, oss-drivers, simon.horman, jakub.kicinski
In-Reply-To: <1503682263-17858-1-git-send-email-pieter.jansenvanvuuren@netronome.com>
From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Date: Fri, 25 Aug 2017 19:31:00 +0200
> Previously when calculating the supported key layers MPLS, IPv4/6
> TTL and TOS were not considered. Formerly flow dissectors were referenced
> without first checking that they are in use and correctly populated by TC.
> Additionally this patch set fixes the incorrect use of mask field for vlan
> matching.
Series applied, thanks.
^ permalink raw reply
* Re: [PATCH 4/4] net: stmmac: sun8i: Remove the compatibles
From: David Miller @ 2017-08-28 22:23 UTC (permalink / raw)
To: maxime.ripard
Cc: arm, wens, linux-arm-kernel, netdev, f.fainelli, clabbe.montjoie,
andrew, linux-kernel
In-Reply-To: <20170825191217.10278-5-maxime.ripard@free-electrons.com>
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Fri, 25 Aug 2017 21:12:17 +0200
> Since the bindings have been controversial, and we follow the DT stable ABI
> rule, we shouldn't let a driver with a DT binding that might change slip
> through in a stable release.
>
> Remove the compatibles to make sure the driver will not probe and no-one
> will start using the binding currently implemented. This commit will
> obviously need to be reverted in due time.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied to net tree.
^ permalink raw reply
* Re: [PATCH net-next] bpf: fix oops on allocation failure
From: David Miller @ 2017-08-28 22:23 UTC (permalink / raw)
To: dan.carpenter; +Cc: ast, john.fastabend, daniel, netdev, kernel-janitors
In-Reply-To: <20170825202714.64ivixeindjph3z6@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 25 Aug 2017 23:27:14 +0300
> "err" is set to zero if bpf_map_area_alloc() fails so it means we return
> ERR_PTR(0) which is NULL. The caller, find_and_alloc_map(), is not
> expecting NULL returns and will oops.
>
> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/3 v9] net: ether: Add support for multiplexing and aggregation type
From: Dan Williams @ 2017-08-28 22:22 UTC (permalink / raw)
To: Subash Abhinov Kasiviswanathan, netdev, davem, fengguang.wu, jiri,
stephen, David.Laight, marcel, andrew
In-Reply-To: <1503635966-14076-2-git-send-email-subashab@codeaurora.org>
On Thu, 2017-08-24 at 22:39 -0600, Subash Abhinov Kasiviswanathan
wrote:
> Define the multiplexing and aggregation (MAP) ether type 0x00F9. This
> is needed for receiving data in the MAP protocol like RMNET. This is
> not an officially registered ID.
>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.or
> g>
> ---
> include/uapi/linux/if_ether.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/if_ether.h
> b/include/uapi/linux/if_ether.h
> index 5bc9bfd..0d73ecc 100644
> --- a/include/uapi/linux/if_ether.h
> +++ b/include/uapi/linux/if_ether.h
> @@ -137,6 +137,7 @@
> #define ETH_P_IEEE802154 0x00F6 /* IEEE802.15.4 frame
> */
> #define ETH_P_CAIF 0x00F7 /* ST-Ericsson CAIF
> protocol */
> #define ETH_P_XDSA 0x00F8 /* Multiplexed DSA
> protocol */
> +#define ETH_P_MAP 0x00F9 /* Multiplex &
> aggregation proto*/
Any chance you could name this QUALCOMM_MAP or something like that? Or
at least update the comment to include that fact.
Dan
> /*
> * This is an Ethernet frame header.
^ permalink raw reply
* Re: [PATCH net] cxgb4: Fix stack out-of-bounds read due to wrong size to t4_record_mbox()
From: David Miller @ 2017-08-28 22:24 UTC (permalink / raw)
To: sbrivio; +Cc: ganeshgr, netdev, hariprasad, leedom, svemuri
In-Reply-To: <04759fe12e6a8eb8e36e46060b907f02c269a826.1503692361.git.sbrivio@redhat.com>
From: Stefano Brivio <sbrivio@redhat.com>
Date: Fri, 25 Aug 2017 22:48:48 +0200
> Passing commands for logging to t4_record_mbox() with size
> MBOX_LEN, when the actual command size is actually smaller,
> causes out-of-bounds stack accesses in t4_record_mbox() while
> copying command words here:
>
> for (i = 0; i < size / 8; i++)
> entry->cmd[i] = be64_to_cpu(cmd[i]);
>
> Up to 48 bytes from the stack are then leaked to debugfs.
>
> This happens whenever we send (and log) commands described by
> structs fw_sched_cmd (32 bytes leaked), fw_vi_rxmode_cmd (48),
> fw_hello_cmd (48), fw_bye_cmd (48), fw_initialize_cmd (48),
> fw_reset_cmd (48), fw_pfvf_cmd (32), fw_eq_eth_cmd (16),
> fw_eq_ctrl_cmd (32), fw_eq_ofld_cmd (32), fw_acl_mac_cmd(16),
> fw_rss_glb_config_cmd(32), fw_rss_vi_config_cmd(32),
> fw_devlog_cmd(32), fw_vi_enable_cmd(48), fw_port_cmd(32),
> fw_sched_cmd(32), fw_devlog_cmd(32).
>
> The cxgb4vf driver got this right instead.
>
> When we call t4_record_mbox() to log a command reply, a MBOX_LEN
> size can be used though, as get_mbox_rpl() will fill cmd_rpl up
> completely.
>
> Fixes: 7f080c3f2ff0 ("cxgb4: Add support to enable logging of firmware mailbox commands")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> ---
> I guess this should be queued up for -stable, back to 4.7.
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH net-next] selftests/bpf: check the instruction dumps are populated
From: David Miller @ 2017-08-28 22:35 UTC (permalink / raw)
To: jakub.kicinski; +Cc: netdev, daniel, kafai, oss-drivers
In-Reply-To: <20170825213957.4768-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 25 Aug 2017 14:39:57 -0700
> Add a basic test for checking whether kernel is populating
> the jited and xlated BPF images. It was used to confirm
> the behaviour change from commit d777b2ddbecf ("bpf: don't
> zero out the info struct in bpf_obj_get_info_by_fd()"),
> which made bpf_obj_get_info_by_fd() usable for retrieving
> the image dumps.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] ipv6: fix sparse warning on rt6i_node
From: David Miller @ 2017-08-28 22:35 UTC (permalink / raw)
To: weiwan; +Cc: netdev, edumazet, kafai
In-Reply-To: <20170825220310.24863-1-tracywwnj@gmail.com>
From: Wei Wang <weiwan@google.com>
Date: Fri, 25 Aug 2017 15:03:10 -0700
> From: Wei Wang <weiwan@google.com>
>
> Commit c5cff8561d2d adds rcu grace period before freeing fib6_node. This
> generates a new sparse warning on rt->rt6i_node related code:
> net/ipv6/route.c:1394:30: error: incompatible types in comparison
> expression (different address spaces)
> ./include/net/ip6_fib.h:187:14: error: incompatible types in comparison
> expression (different address spaces)
>
> This commit adds "__rcu" tag for rt6i_node and makes sure corresponding
> rcu API is used for it.
> After this fix, sparse no longer generates the above warning.
>
> Fixes: c5cff8561d2d ("ipv6: add rcu grace period before freeing fib6_node")
> Signed-off-by: Wei Wang <weiwan@google.com>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format
From: Stephen Hemminger @ 2017-08-28 22:37 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: Alexander Aring, yotamg, xiyou.wangcong, jiri, netdev
In-Reply-To: <ff74308c-2fe9-7c73-6215-8a269ea1be5e@mojatatu.com>
On Mon, 28 Aug 2017 18:18:04 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> Alex,
>
> I think we should get rid of these fprintfs instead of fixing them.
> They were originally intended to be debug outputs.
>
> cheers,
> jamal
>
> On 17-08-28 03:07 PM, Alexander Aring wrote:
> > This patch uses the usually IEEE format to display an ethertype which is
> > 4-digits and every digit in upper case.
> >
> > Signed-off-by: Alexander Aring <aring@mojatatu.com>
> > ---
> > tc/m_ife.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tc/m_ife.c b/tc/m_ife.c
> > index e05e2276..7b57130e 100644
> > --- a/tc/m_ife.c
> > +++ b/tc/m_ife.c
> > @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
> > NEXT_ARG();
> > if (get_u16(&ife_type, *argv, 0))
> > invarg("ife type is invalid", *argv);
> > - fprintf(stderr, "IFE type 0x%x\n", ife_type);
> > + fprintf(stderr, "IFE type 0x%04X\n", ife_type);
> > user_type = 1;
> > } else if (matches(*argv, "dst") == 0) {
> > NEXT_ARG();
> >
>
For iproute commands the show output is supposed to match the corresponding set inputs.
^ permalink raw reply
* Re: [PATCH v3 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)
From: David Miller @ 2017-08-28 22:38 UTC (permalink / raw)
To: decui
Cc: jhansen, stefanha, netdev, mkubecek, olaf, sthemmin,
rolf.neugebauer, jasowang, dave.scott, linux-kernel, apw,
marcelo.cerri, dan.carpenter, gregkh, joe, devel, vkuznets,
haiyangz, georgezhang
In-Reply-To: <PS1P15301MB00117CF517E0EFF548C9F572BF980@PS1P15301MB0011.APCP153.PROD.OUTLOOK.COM>
From: Dexuan Cui <decui@microsoft.com>
Date: Sat, 26 Aug 2017 04:52:43 +0000
>
> Hyper-V Sockets (hv_sock) supplies a byte-stream based communication
> mechanism between the host and the guest. It uses VMBus ringbuffer as the
> transportation layer.
>
> With hv_sock, applications between the host (Windows 10, Windows Server
> 2016 or newer) and the guest can talk with each other using the traditional
> socket APIs.
>
> More info about Hyper-V Sockets is available here:
>
> "Make your own integration services":
> https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/user-guide/make-integration-service
>
> The patch implements the necessary support in Linux guest by introducing a new
> vsock transport for AF_VSOCK.
>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
Applied, thank you.
^ permalink raw reply
* Re: [patch net-next 0/2] mlxsw: spectrum: Fix couple of dpipe ipv4 host table bugs
From: David Miller @ 2017-08-28 22:41 UTC (permalink / raw)
To: jiri; +Cc: netdev, arkadis, idosch, mlxsw
In-Reply-To: <20170826063539.2741-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 26 Aug 2017 08:35:37 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Arkadi Sharshevsky (1):
> mlxsw: spectrum_dpipe: Fix host table dump
>
> Jiri Pirko (1):
> mlxsw: spectrum: compile-in dpipe support only if devlink is enabled
Series applied, thanks Jiri.
^ permalink raw reply
* Re: [PATCH 1/4] sgiseeq: switch to dma_alloc_attrs
From: David Miller @ 2017-08-28 22:41 UTC (permalink / raw)
To: hch; +Cc: netdev, ralf, linux-mips, linux-parisc, linux-kernel
In-Reply-To: <20170826072125.9790-2-hch@lst.de>
From: Christoph Hellwig <hch@lst.de>
Date: Sat, 26 Aug 2017 09:21:22 +0200
> Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 2/4] au1000_eth: switch to dma_alloc_attrs
From: David Miller @ 2017-08-28 22:42 UTC (permalink / raw)
To: hch; +Cc: netdev, ralf, linux-mips, linux-parisc, linux-kernel
In-Reply-To: <20170826072125.9790-3-hch@lst.de>
From: Christoph Hellwig <hch@lst.de>
Date: Sat, 26 Aug 2017 09:21:23 +0200
> Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 3/4] i825xx: switch to switch to dma_alloc_attrs
From: David Miller @ 2017-08-28 22:42 UTC (permalink / raw)
To: hch; +Cc: netdev, ralf, linux-mips, linux-parisc, linux-kernel
In-Reply-To: <20170826072125.9790-4-hch@lst.de>
From: Christoph Hellwig <hch@lst.de>
Date: Sat, 26 Aug 2017 09:21:24 +0200
> This way we can always pass DMA_ATTR_NON_CONSISTENT, the SNI mips version
> will simply ignore the flag.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox