* Re: [PATCH net-next] net-next/hinic: fix comparison of a uint16_t type with -1
From: David Miller @ 2017-08-28 23:44 UTC (permalink / raw)
To: aviad.krawczyk; +Cc: linux-kernel, netdev, zhaochen6, colin.king, dan.carpenter
In-Reply-To: <1503855330-84810-1-git-send-email-aviad.krawczyk@huawei.com>
From: Aviad Krawczyk <aviad.krawczyk@huawei.com>
Date: Mon, 28 Aug 2017 01:35:30 +0800
> Remove the search for index of constant buffer size
>
> Signed-off-by: Aviad Krawczyk <aviad.krawczyk@huawei.com>
> Signed-off-by: Zhao Chen <zhaochen6@huawei.com>
Applied.
^ permalink raw reply
* Re: [PATCH V2 net-next] net-next/hinic: Fix MTU limitation
From: David Miller @ 2017-08-28 23:44 UTC (permalink / raw)
To: aviad.krawczyk; +Cc: linux-kernel, netdev, zhaochen6, andrew
In-Reply-To: <1503854426-42046-1-git-send-email-aviad.krawczyk@huawei.com>
From: Aviad Krawczyk <aviad.krawczyk@huawei.com>
Date: Mon, 28 Aug 2017 01:20:26 +0800
> Fix the hw MTU limitation by setting max_mtu
>
> Signed-off-by: Aviad Krawczyk <aviad.krawczyk@huawei.com>
> Signed-off-by: Zhao Chen <zhaochen6@huawei.com>
Applied.
^ permalink raw reply
* Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it
From: David Miller @ 2017-08-28 23:42 UTC (permalink / raw)
To: gregkh; +Cc: devel, netdev, samuel, linux-kernel
In-Reply-To: <20170827150334.32495-1-gregkh@linuxfoundation.org>
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Sun, 27 Aug 2017 17:03:30 +0200
> The IRDA code has long been obsolete and broken. So, to keep people
> from trying to use it, and to prevent people from having to maintain it,
> let's move it to drivers/staging/ so that we can delete it entirely from
> the kernel in a few releases.
No objection, I'll apply this to net-next, thanks Greg.
^ permalink raw reply
* Re: [PATCH v4 0/7] Add RSS to DPAA 1.x Ethernet driver
From: David Miller @ 2017-08-28 23:41 UTC (permalink / raw)
To: madalin.bucur; +Cc: netdev, linuxppc-dev, linux-kernel
In-Reply-To: <1503839623-3906-1-git-send-email-madalin.bucur@nxp.com>
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Sun, 27 Aug 2017 16:13:36 +0300
> This patch set introduces Receive Side Scaling for the DPAA Ethernet
> driver. Documentation is updated with details related to the new
> feature and limitations that apply.
> Added also a small fix.
>
> v2: removed a C++ style comment
> v3: move struct fman to header file to avoid exporting a function
> v4: addressed compilation issues introduced in v3
Series applied, thanks.
^ permalink raw reply
* RE: [PATCH v3 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)
From: Dexuan Cui @ 2017-08-28 23:30 UTC (permalink / raw)
To: David Miller
Cc: mkubecek@suse.cz, olaf@aepfle.de, Stephen Hemminger,
georgezhang@vmware.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, jasowang@redhat.com,
dave.scott@docker.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, marcelo.cerri@canonical.com,
dan.carpenter@oracle.com, stefanha@redhat.com,
rolf.neugebauer@docker.com, apw@canonical.com, joe@perches.com,
vkuznets@redhat.com, Haiyang Zhang
In-Reply-To: <20170828.153852.1182668029079177666.davem@davemloft.net>
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Monday, August 28, 2017 15:39
> From: Dexuan Cui <decui@microsoft.com>
> Date: Sat, 26 Aug 2017 04:52:43 +0000
>
> >
> > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication
> > mechanism between the host and the guest. It uses VMBus ringbuffer as
> the
> > transportation layer.
> >
> > With hv_sock, applications between the host (Windows 10, Windows
> Server
> > 2016 or newer) and the guest can talk with each other using the traditional
> > socket APIs.
> >
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
>
> Applied, thank you.
Thanks a lot!
There are some supporting patches still pending in the VMBus driver.
I'll make sure they go in through the char-misc tree.
Thanks,
-- Dexuan
^ permalink raw reply
* Re: [PATCH] be2net: Fix some u16 fields appropriately
From: David Miller @ 2017-08-28 23:19 UTC (permalink / raw)
To: yanhaishuang
Cc: sathya.perla, ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
netdev, linux-kernel
In-Reply-To: <1503818685-32068-1-git-send-email-yanhaishuang@cmss.chinamobile.com>
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Sun, 27 Aug 2017 15:24:45 +0800
> In be_tx_compl_process, frag_index declared as u32, so it's better to
> declare last_index as u32 also.
>
> CC: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Fixes: b0fd2eb28bd4 ("be2net: Declare some u16 fields as u32 to improve
> performance")
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
That is not a legitimate reason for making this change.
> @@ -255,7 +255,7 @@ struct be_tx_stats {
> /* Structure to hold some data of interest obtained from a TX CQE */
> struct be_tx_compl_info {
> u8 status; /* Completion status */
> - u16 end_index; /* Completed TXQ Index */
> + u32 end_index; /* Completed TXQ Index */
> };
>
> struct be_tx_obj {
The ->end_index comes solely from:
txcp->end_index = GET_TX_COMPL_BITS(wrb_index, compl);
Which is precisely a 16-bit value.
I'm not applying this, sorry.
^ permalink raw reply
* Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format
From: Jamal Hadi Salim @ 2017-08-28 22:56 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Alexander Aring, yotamg, xiyou.wangcong, jiri, netdev
In-Reply-To: <20170828153734.4b32fa02@xeon-e3>
On 17-08-28 06:37 PM, Stephen Hemminger wrote:
> On Mon, 28 Aug 2017 18:18:04 -0400
[..]
>>> @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
>>> NEXT_ARG();
>>> if (get_u16(&ife_type, *argv, 0))
>>> invarg("ife type is invalid", *argv);
>>> - fprintf(stderr, "IFE type 0x%x\n", ife_type);
>>> + fprintf(stderr, "IFE type 0x%04X\n", ife_type);
>>> user_type = 1;
>>> } else if (matches(*argv, "dst") == 0) {
>>> NEXT_ARG();
>>>
>>
>
>
> For iproute commands the show output is supposed to match the corresponding set inputs.
>
These were being printed at parse time ...
cheers,
jamal
^ permalink raw reply
* Re: [PATCH] net: ethernet: broadcom: Remove null check before kfree
From: David Miller @ 2017-08-28 22:53 UTC (permalink / raw)
To: himanshujha199640; +Cc: jarod, netdev, linux-kernel
In-Reply-To: <1503778667-4416-1-git-send-email-himanshujha199640@gmail.com>
From: Himanshu Jha <himanshujha199640@gmail.com>
Date: Sun, 27 Aug 2017 01:47:47 +0530
> Kfree on NULL pointer is a no-op and therefore checking is redundant.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net 0/4] xfrm_user info leaks
From: David Miller @ 2017-08-28 22:52 UTC (permalink / raw)
To: minipli; +Cc: steffen.klassert, herbert, netdev
In-Reply-To: <1503760140-9095-1-git-send-email-minipli@googlemail.com>
From: Mathias Krause <minipli@googlemail.com>
Date: Sat, 26 Aug 2017 17:08:56 +0200
> Hi David, Steffen,
>
> the following series fixes a few info leaks due to missing padding byte
> initialization in the xfrm_user netlink interface.
>
> Please apply!
Steffen please pick this up if you haven't already.
Thank you.
^ permalink raw reply
* Re: [PATCH net-next v2] sched: sfq: drop packets after root qdisc lock is released
From: David Miller @ 2017-08-28 22:52 UTC (permalink / raw)
To: gfree.wind; +Cc: jhs, xiyou.wangcong, jiri, edumazet, netdev
In-Reply-To: <1503759538-32890-1-git-send-email-gfree.wind@vip.163.com>
From: gfree.wind@vip.163.com
Date: Sat, 26 Aug 2017 22:58:58 +0800
> From: Gao Feng <gfree.wind@vip.163.com>
>
> The commit 520ac30f4551 ("net_sched: drop packets after root qdisc lock
> is released) made a big change of tc for performance. But there are
> some points which are not changed in SFQ enqueue operation.
> 1. Fail to find the SFQ hash slot;
> 2. When the queue is full;
>
> Now use qdisc_drop instead free skb directly.
>
> Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH] sni_82596: Add Thomas' email address to driver.
From: David Miller @ 2017-08-28 22:51 UTC (permalink / raw)
To: ralf; +Cc: tsbogend, hch, netdev, linux-mips
In-Reply-To: <20170826131507.GA15074@linux-mips.org>
I need this reposted with a proper commit message and a signoff before
I can apply this, thanks.
^ permalink raw reply
* Re: [PATCH net] ipv6: set dst.obsolete when a cached route has expired
From: David Miller @ 2017-08-28 22:45 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, hannes
In-Reply-To: <cd3d9312a3d31ee72b9377e7200898c30f73ab8e.1503749410.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Sat, 26 Aug 2017 20:10:10 +0800
> Now it doesn't check for the cached route expiration in ipv6's
> dst_ops->check(), because it trusts dst_gc that would clean the
> cached route up when it's expired.
>
> The problem is in dst_gc, it would clean the cached route only
> when it's refcount is 1. If some other module (like xfrm) keeps
> holding it and the module only release it when dst_ops->check()
> fails.
>
> But without checking for the cached route expiration, .check()
> may always return true. Meanwhile, without releasing the cached
> route, dst_gc couldn't del it. It will cause this cached route
> never to expire.
>
> This patch is to set dst.obsolete with DST_OBSOLETE_KILL in .gc
> when it's expired, and check obsolete != DST_OBSOLETE_FORCE_CHK
> in .check.
>
> Note that this is even needed when ipv6 dst_gc timer is removed
> one day. It would set dst.obsolete in .redirect and .update_pmtu
> instead, and check for cached route expiration when getting it,
> just like what ipv4 route does.
>
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH 3/4] i825xx: switch to switch to dma_alloc_attrs
From: David Miller @ 2017-08-28 22:42 UTC (permalink / raw)
To: hch; +Cc: netdev, ralf, linux-mips, linux-parisc, linux-kernel
In-Reply-To: <20170826072125.9790-4-hch@lst.de>
From: Christoph Hellwig <hch@lst.de>
Date: Sat, 26 Aug 2017 09:21:24 +0200
> This way we can always pass DMA_ATTR_NON_CONSISTENT, the SNI mips version
> will simply ignore the flag.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 2/4] au1000_eth: switch to dma_alloc_attrs
From: David Miller @ 2017-08-28 22:42 UTC (permalink / raw)
To: hch; +Cc: netdev, ralf, linux-mips, linux-parisc, linux-kernel
In-Reply-To: <20170826072125.9790-3-hch@lst.de>
From: Christoph Hellwig <hch@lst.de>
Date: Sat, 26 Aug 2017 09:21:23 +0200
> Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 1/4] sgiseeq: switch to dma_alloc_attrs
From: David Miller @ 2017-08-28 22:41 UTC (permalink / raw)
To: hch; +Cc: netdev, ralf, linux-mips, linux-parisc, linux-kernel
In-Reply-To: <20170826072125.9790-2-hch@lst.de>
From: Christoph Hellwig <hch@lst.de>
Date: Sat, 26 Aug 2017 09:21:22 +0200
> Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [patch net-next 0/2] mlxsw: spectrum: Fix couple of dpipe ipv4 host table bugs
From: David Miller @ 2017-08-28 22:41 UTC (permalink / raw)
To: jiri; +Cc: netdev, arkadis, idosch, mlxsw
In-Reply-To: <20170826063539.2741-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 26 Aug 2017 08:35:37 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Arkadi Sharshevsky (1):
> mlxsw: spectrum_dpipe: Fix host table dump
>
> Jiri Pirko (1):
> mlxsw: spectrum: compile-in dpipe support only if devlink is enabled
Series applied, thanks Jiri.
^ permalink raw reply
* Re: [PATCH v3 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)
From: David Miller @ 2017-08-28 22:38 UTC (permalink / raw)
To: decui
Cc: jhansen, stefanha, netdev, mkubecek, olaf, sthemmin,
rolf.neugebauer, jasowang, dave.scott, linux-kernel, apw,
marcelo.cerri, dan.carpenter, gregkh, joe, devel, vkuznets,
haiyangz, georgezhang
In-Reply-To: <PS1P15301MB00117CF517E0EFF548C9F572BF980@PS1P15301MB0011.APCP153.PROD.OUTLOOK.COM>
From: Dexuan Cui <decui@microsoft.com>
Date: Sat, 26 Aug 2017 04:52:43 +0000
>
> Hyper-V Sockets (hv_sock) supplies a byte-stream based communication
> mechanism between the host and the guest. It uses VMBus ringbuffer as the
> transportation layer.
>
> With hv_sock, applications between the host (Windows 10, Windows Server
> 2016 or newer) and the guest can talk with each other using the traditional
> socket APIs.
>
> More info about Hyper-V Sockets is available here:
>
> "Make your own integration services":
> https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/user-guide/make-integration-service
>
> The patch implements the necessary support in Linux guest by introducing a new
> vsock transport for AF_VSOCK.
>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format
From: Stephen Hemminger @ 2017-08-28 22:37 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: Alexander Aring, yotamg, xiyou.wangcong, jiri, netdev
In-Reply-To: <ff74308c-2fe9-7c73-6215-8a269ea1be5e@mojatatu.com>
On Mon, 28 Aug 2017 18:18:04 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> Alex,
>
> I think we should get rid of these fprintfs instead of fixing them.
> They were originally intended to be debug outputs.
>
> cheers,
> jamal
>
> On 17-08-28 03:07 PM, Alexander Aring wrote:
> > This patch uses the usually IEEE format to display an ethertype which is
> > 4-digits and every digit in upper case.
> >
> > Signed-off-by: Alexander Aring <aring@mojatatu.com>
> > ---
> > tc/m_ife.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tc/m_ife.c b/tc/m_ife.c
> > index e05e2276..7b57130e 100644
> > --- a/tc/m_ife.c
> > +++ b/tc/m_ife.c
> > @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
> > NEXT_ARG();
> > if (get_u16(&ife_type, *argv, 0))
> > invarg("ife type is invalid", *argv);
> > - fprintf(stderr, "IFE type 0x%x\n", ife_type);
> > + fprintf(stderr, "IFE type 0x%04X\n", ife_type);
> > user_type = 1;
> > } else if (matches(*argv, "dst") == 0) {
> > NEXT_ARG();
> >
>
For iproute commands the show output is supposed to match the corresponding set inputs.
^ permalink raw reply
* Re: [PATCH net] ipv6: fix sparse warning on rt6i_node
From: David Miller @ 2017-08-28 22:35 UTC (permalink / raw)
To: weiwan; +Cc: netdev, edumazet, kafai
In-Reply-To: <20170825220310.24863-1-tracywwnj@gmail.com>
From: Wei Wang <weiwan@google.com>
Date: Fri, 25 Aug 2017 15:03:10 -0700
> From: Wei Wang <weiwan@google.com>
>
> Commit c5cff8561d2d adds rcu grace period before freeing fib6_node. This
> generates a new sparse warning on rt->rt6i_node related code:
> net/ipv6/route.c:1394:30: error: incompatible types in comparison
> expression (different address spaces)
> ./include/net/ip6_fib.h:187:14: error: incompatible types in comparison
> expression (different address spaces)
>
> This commit adds "__rcu" tag for rt6i_node and makes sure corresponding
> rcu API is used for it.
> After this fix, sparse no longer generates the above warning.
>
> Fixes: c5cff8561d2d ("ipv6: add rcu grace period before freeing fib6_node")
> Signed-off-by: Wei Wang <weiwan@google.com>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] selftests/bpf: check the instruction dumps are populated
From: David Miller @ 2017-08-28 22:35 UTC (permalink / raw)
To: jakub.kicinski; +Cc: netdev, daniel, kafai, oss-drivers
In-Reply-To: <20170825213957.4768-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 25 Aug 2017 14:39:57 -0700
> Add a basic test for checking whether kernel is populating
> the jited and xlated BPF images. It was used to confirm
> the behaviour change from commit d777b2ddbecf ("bpf: don't
> zero out the info struct in bpf_obj_get_info_by_fd()"),
> which made bpf_obj_get_info_by_fd() usable for retrieving
> the image dumps.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] cxgb4: Fix stack out-of-bounds read due to wrong size to t4_record_mbox()
From: David Miller @ 2017-08-28 22:24 UTC (permalink / raw)
To: sbrivio; +Cc: ganeshgr, netdev, hariprasad, leedom, svemuri
In-Reply-To: <04759fe12e6a8eb8e36e46060b907f02c269a826.1503692361.git.sbrivio@redhat.com>
From: Stefano Brivio <sbrivio@redhat.com>
Date: Fri, 25 Aug 2017 22:48:48 +0200
> Passing commands for logging to t4_record_mbox() with size
> MBOX_LEN, when the actual command size is actually smaller,
> causes out-of-bounds stack accesses in t4_record_mbox() while
> copying command words here:
>
> for (i = 0; i < size / 8; i++)
> entry->cmd[i] = be64_to_cpu(cmd[i]);
>
> Up to 48 bytes from the stack are then leaked to debugfs.
>
> This happens whenever we send (and log) commands described by
> structs fw_sched_cmd (32 bytes leaked), fw_vi_rxmode_cmd (48),
> fw_hello_cmd (48), fw_bye_cmd (48), fw_initialize_cmd (48),
> fw_reset_cmd (48), fw_pfvf_cmd (32), fw_eq_eth_cmd (16),
> fw_eq_ctrl_cmd (32), fw_eq_ofld_cmd (32), fw_acl_mac_cmd(16),
> fw_rss_glb_config_cmd(32), fw_rss_vi_config_cmd(32),
> fw_devlog_cmd(32), fw_vi_enable_cmd(48), fw_port_cmd(32),
> fw_sched_cmd(32), fw_devlog_cmd(32).
>
> The cxgb4vf driver got this right instead.
>
> When we call t4_record_mbox() to log a command reply, a MBOX_LEN
> size can be used though, as get_mbox_rpl() will fill cmd_rpl up
> completely.
>
> Fixes: 7f080c3f2ff0 ("cxgb4: Add support to enable logging of firmware mailbox commands")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> ---
> I guess this should be queued up for -stable, back to 4.7.
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH net-next 1/3 v9] net: ether: Add support for multiplexing and aggregation type
From: Dan Williams @ 2017-08-28 22:22 UTC (permalink / raw)
To: Subash Abhinov Kasiviswanathan, netdev, davem, fengguang.wu, jiri,
stephen, David.Laight, marcel, andrew
In-Reply-To: <1503635966-14076-2-git-send-email-subashab@codeaurora.org>
On Thu, 2017-08-24 at 22:39 -0600, Subash Abhinov Kasiviswanathan
wrote:
> Define the multiplexing and aggregation (MAP) ether type 0x00F9. This
> is needed for receiving data in the MAP protocol like RMNET. This is
> not an officially registered ID.
>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.or
> g>
> ---
> include/uapi/linux/if_ether.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/if_ether.h
> b/include/uapi/linux/if_ether.h
> index 5bc9bfd..0d73ecc 100644
> --- a/include/uapi/linux/if_ether.h
> +++ b/include/uapi/linux/if_ether.h
> @@ -137,6 +137,7 @@
> #define ETH_P_IEEE802154 0x00F6 /* IEEE802.15.4 frame
> */
> #define ETH_P_CAIF 0x00F7 /* ST-Ericsson CAIF
> protocol */
> #define ETH_P_XDSA 0x00F8 /* Multiplexed DSA
> protocol */
> +#define ETH_P_MAP 0x00F9 /* Multiplex &
> aggregation proto*/
Any chance you could name this QUALCOMM_MAP or something like that? Or
at least update the comment to include that fact.
Dan
> /*
> * This is an Ethernet frame header.
^ permalink raw reply
* Re: [PATCH net-next] bpf: fix oops on allocation failure
From: David Miller @ 2017-08-28 22:23 UTC (permalink / raw)
To: dan.carpenter; +Cc: ast, john.fastabend, daniel, netdev, kernel-janitors
In-Reply-To: <20170825202714.64ivixeindjph3z6@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 25 Aug 2017 23:27:14 +0300
> "err" is set to zero if bpf_map_area_alloc() fails so it means we return
> ERR_PTR(0) which is NULL. The caller, find_and_alloc_map(), is not
> expecting NULL returns and will oops.
>
> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/4] net: stmmac: sun8i: Remove the compatibles
From: David Miller @ 2017-08-28 22:23 UTC (permalink / raw)
To: maxime.ripard
Cc: arm, wens, linux-arm-kernel, netdev, f.fainelli, clabbe.montjoie,
andrew, linux-kernel
In-Reply-To: <20170825191217.10278-5-maxime.ripard@free-electrons.com>
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Fri, 25 Aug 2017 21:12:17 +0200
> Since the bindings have been controversial, and we follow the DT stable ABI
> rule, we shouldn't let a driver with a DT binding that might change slip
> through in a stable release.
>
> Remove the compatibles to make sure the driver will not probe and no-one
> will start using the binding currently implemented. This commit will
> obviously need to be reverted in due time.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied to net tree.
^ permalink raw reply
* Re: [PATCH net 0/3] fix layer calculation and flow dissector use
From: David Miller @ 2017-08-28 22:20 UTC (permalink / raw)
To: pieter.jansenvanvuuren; +Cc: netdev, oss-drivers, simon.horman, jakub.kicinski
In-Reply-To: <1503682263-17858-1-git-send-email-pieter.jansenvanvuuren@netronome.com>
From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Date: Fri, 25 Aug 2017 19:31:00 +0200
> Previously when calculating the supported key layers MPLS, IPv4/6
> TTL and TOS were not considered. Formerly flow dissectors were referenced
> without first checking that they are in use and correctly populated by TC.
> Additionally this patch set fixes the incorrect use of mask field for vlan
> matching.
Series applied, thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox