* Re: [PATCH] net/9p: correct some comment errors in 9p file system code
From: Randy Dunlap @ 2018-05-08 4:51 UTC (permalink / raw)
To: Sun Lianwen, viro; +Cc: netdev
In-Reply-To: <20180508014938.28134-1-sunlw.fnst@cn.fujitsu.com>
On 05/07/2018 06:49 PM, Sun Lianwen wrote:
> There are follow comment errors:
> 1 The function name is wrong in p9_release_pages() comment.
> 2 The function name and variable name is wrong in p9_poll_workfn() comment.
> 3 There is no variable dm_mr and lkey in struct p9_trans_rdma.
> 4 The function name is wrong in rdma_create_trans() comment.
> 5 There is no variable initialized in struct virtio_chan.
> 6 The variable name is wrong in p9_virtio_zc_request() comment.
>
> Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Uh, you aren't supposed to add that (line above) until or unless I offer it.
See Documentation/process/submitting-patches.rst for details.
> ---
> net/9p/trans_common.c | 2 +-
> net/9p/trans_fd.c | 4 ++--
> net/9p/trans_rdma.c | 4 +---
> net/9p/trans_virtio.c | 5 ++---
> 4 files changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
thanks,
--
~Randy
^ permalink raw reply
* Re: [Bug 199643] New: UBSAN: Undefined behaviour in ./include/net/route.h:240:2
From: David Miller @ 2018-05-08 4:12 UTC (permalink / raw)
To: stephen; +Cc: netdev
In-Reply-To: <20180507103400.222a60a4@xeon-e3>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 7 May 2018 10:34:00 -0700
> Subject: [Bug 199643] New: UBSAN: Undefined behaviour in ./include/net/route.h:240:2
That's an empty line in both of my trees.
^ permalink raw reply
* Re: [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc
From: Cong Wang @ 2018-05-08 4:11 UTC (permalink / raw)
To: Toke Høiland-Jørgensen
Cc: Linux Kernel Network Developers, Cake List
In-Reply-To: <87in7zmhwy.fsf@toke.dk>
On Mon, May 7, 2018 at 11:37 AM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> Cong Wang <xiyou.wangcong@gmail.com> writes:
>
>> On Fri, May 4, 2018 at 12:10 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>> Thank you for the review! A few comments below, I'll fix the rest.
>>>
>>>> [...]
>>>>
>>>> So sch_cake doesn't accept normal tc filters? Is this intentional?
>>>> If so, why?
>>>
>>> For two reasons:
>>>
>>> - The two-level scheduling used in CAKE (tins / diffserv classes, and
>>> flow hashing) does not map in an obvious way to the classification
>>> index of tc filters.
>>
>> Sounds like you need to extend struct tcf_result?
>
> Well, the obvious way to support filters would be to have skb->priority
> override the diffserv mapping if set, and have the filter classification
> result select the queue within that tier. That would probably be doable,
> but see below.
>
>>> - No one has asked for it. We have done our best to accommodate the
>>> features people want in a home router qdisc directly in CAKE, and the
>>> ability to integrate tc filters has never been requested.
>>
>> It is not hard to integrate, basically you need to call
>> tcf_classify(). Although it is not mandatory, it is odd to merge a
>> qdisc doesn't work with existing tc filters (and actions too).
>
> I looked at the fq_codel code to do this. Is it possible to support
> filtering without implementing Qdisc_class_ops? If so, I'll give it a
> shot; but implementing the class ops is more than I can commit to...
Good question. The tc classes in flow-based qdisc's are actually
used as flows rather than a normal tc class in a hierarchy qdisc.
Like in fq_code, the classes are mapped to each flow and because
of that we can dump stats of each flow.
I am not sure if you can totally bypass class_ops, you need to look
into these API's. Most of them are easy to implement, probably
only except the ->dump_stats(), so I don't think it is a barrier here.
>
>>>>> +static int cake_init(struct Qdisc *sch, struct nlattr *opt,
>>>>> + struct netlink_ext_ack *extack)
>>>>> +{
>>>>> + struct cake_sched_data *q = qdisc_priv(sch);
>>>>> + int i, j;
>>>>> +
>>>>> + sch->limit = 10240;
>>>>> + q->tin_mode = CAKE_DIFFSERV_BESTEFFORT;
>>>>> + q->flow_mode = CAKE_FLOW_TRIPLE;
>>>>> +
>>>>> + q->rate_bps = 0; /* unlimited by default */
>>>>> +
>>>>> + q->interval = 100000; /* 100ms default */
>>>>> + q->target = 5000; /* 5ms: codel RFC argues
>>>>> + * for 5 to 10% of interval
>>>>> + */
>>>>> +
>>>>> + q->cur_tin = 0;
>>>>> + q->cur_flow = 0;
>>>>> +
>>>>> + if (opt) {
>>>>> + int err = cake_change(sch, opt, extack);
>>>>> +
>>>>> + if (err)
>>>>> + return err;
>>>>
>>>>
>>>> Not sure if you really want to reallocate q->tines below for this
>>>> case.
>>>
>>> I'm not sure what you mean here? If there's an error we return it and
>>> the qdisc is not created. If there's not, we allocate and on subsequent
>>> changes cake_change() will be called directly, or? Can the init function
>>> ever be called again during the lifetime of the qdisc?
>>>
>>
>> In non-error case, you call cake_change() first and then allocate
>> ->tins with kvzalloc() below. For me it looks like you don't need to
>> allocate it again when ->tins!=NULL.
>
> No, we definitely don't. It's just not clear to me how cake_init() could
> ever be called with q->tins already allocated?
>
> I can add a check in any case, though, I see that there is one in
> fq_codel as well...
Ah, that's right, you have a check in cake_change() before
cake_reconfigure().
^ permalink raw reply
* Re: [PATCH net] llc: better deal with too small mtu
From: David Miller @ 2018-05-08 4:12 UTC (permalink / raw)
To: edumazet; +Cc: netdev, eric.dumazet
In-Reply-To: <20180507160225.237901-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 7 May 2018 09:02:25 -0700
> syzbot loves to set very small mtu on devices, since it brings joy.
> We must make llc_ui_sendmsg() fool proof.
This thing is just too smart for it's own good :)
> usercopy: Kernel memory overwrite attempt detected to wrapped address (offset 0, size 18446612139802320068)!
...
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied and queued up for -stable, thanks Eric.
^ permalink raw reply
* Re: [net-next 0/6][pull request] 100GbE Intel Wired LAN Driver Updates 2018-05-07
From: David Miller @ 2018-05-08 4:10 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, nhorman, sassmann, jogreene
In-Reply-To: <20180507144521.6979-1-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 7 May 2018 07:45:15 -0700
> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 100GbE
Hmmm...
[davem@localhost net-next]$ git pull --no-ff git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 100GbE
>From git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue
* branch 100GbE -> FETCH_HEAD
Already up to date.
[davem@localhost net-next]$
^ permalink raw reply
* Re: [PATCH net-next] net-next/hinic: add pci device ids for 25ge and 100ge card
From: David Miller @ 2018-05-08 4:08 UTC (permalink / raw)
To: zhaochen6
Cc: linux-kernel, netdev, aviad.krawczyk, tony.qu, yin.yinshi,
luoshaokai
In-Reply-To: <20180507132157.25047-1-zhaochen6@huawei.com>
From: Zhao Chen <zhaochen6@huawei.com>
Date: Mon, 7 May 2018 09:21:57 -0400
> This patch adds PCI device IDs to support 25GE and 100GE card:
>
> 1. Add device id 0x0201 for HINIC 100GE dual port card.
> 2. Add device id 0x0200 for HINIC 25GE dual port card.
> 3. Macro of device id 0x1822 is modified for HINIC 25GE quad port card.
>
> Signed-off-by: Zhao Chen <zhaochen6@huawei.com>
Applied.
^ permalink raw reply
* Re: [PATCH net 0/2] Aquantia various patches 2018-05
From: David Miller @ 2018-05-08 4:07 UTC (permalink / raw)
To: igor.russkikh; +Cc: netdev, darcari, pavel.belous
In-Reply-To: <cover.1525360773.git.igor.russkikh@aquantia.com>
From: Igor Russkikh <igor.russkikh@aquantia.com>
Date: Mon, 7 May 2018 16:10:37 +0300
> These are two patches covering issues found during test cycles:
>
> First is that driver should declare valid vlan_features
> Second fix is about correct allocation of MSI interrupts on some systems.
Series applied, thank you.
^ permalink raw reply
* Re: [PATCH] trivial: fix inconsistent help texts
From: David Miller @ 2018-05-08 4:05 UTC (permalink / raw)
To: georg; +Cc: kuznet, yoshfuji, trivial, netdev, linux-kernel
In-Reply-To: <1525694598-1666-1-git-send-email-georg@hofmannsweb.com>
From: Georg Hofmann <georg@hofmannsweb.com>
Date: Mon, 7 May 2018 14:03:18 +0200
> This patch removes "experimental" from the help text where depends on
> CONFIG_EXPERIMENTAL was already removed.
>
> Signed-off-by: Georg Hofmann <georg@hofmannsweb.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] MAINTAINERS: Update the 3c59x network driver entry
From: David Miller @ 2018-05-08 4:04 UTC (permalink / raw)
To: steffen.klassert; +Cc: netdev
In-Reply-To: <20180507103930.kodednyr5wvwt375@gauss3.secunet.de>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Mon, 7 May 2018 12:39:30 +0200
> Replace my old E-Mail address with a working one.
> While at it, change the maintainance status to
> 'Odd Fixes'. I'm still around with some knowledge,
> but don't actively maintain it anymore.
>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH net-next] flow_dissector: do not rely on implicit casts
From: David Miller @ 2018-05-08 4:03 UTC (permalink / raw)
To: pabeni; +Cc: netdev
In-Reply-To: <163b504b851217e600d9b48aa7cba76b376a675a.1525687522.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Mon, 7 May 2018 12:06:03 +0200
> This change fixes a couple of type mismatch reported by the sparse
> tool, explicitly using the requested type for the offending arguments.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied, thank you.
^ permalink raw reply
* Re: pull request (net-next): ipsec-next 2018-05-07
From: David Miller @ 2018-05-08 3:57 UTC (permalink / raw)
To: steffen.klassert; +Cc: herbert, netdev
In-Reply-To: <20180507090116.31222-1-steffen.klassert@secunet.com>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Mon, 7 May 2018 11:01:11 +0200
> 1) Add selftests for the xfrm commands.
> From Shannon Nelson.
>
> 2) Enable hardware checksum offload for ESP encapsulated
> UDP packets if the hardware supports this.
> From Jacek Kalwas.
>
> 3) Remove VLA usage in __xfrm6_sort. From Kees Cook.
>
> 4) Fix a typo in the comment of vti6_ioctl.
> From Sun Lianwen.
>
> 5) Use a dedicated slab cache for struct xfrm_state,
> this reduces the memory usage of this struct
> by 25 percent. From Mathias Krause.
...
> git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
Pulled, thanks Steffen.
^ permalink raw reply
* Re: pull request (net): ipsec 2018-05-07
From: David Miller @ 2018-05-08 3:52 UTC (permalink / raw)
To: steffen.klassert; +Cc: herbert, netdev
In-Reply-To: <20180507084323.22165-1-steffen.klassert@secunet.com>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Mon, 7 May 2018 10:43:20 +0200
> 1) Always verify length of provided sadb_key to fix a
> slab-out-of-bounds read in pfkey_add. From Kevin Easton.
>
> 2) Make sure that all states are really deleted
> before we check that the state lists are empty.
> Otherwise we trigger a warning.
>
> 3) Fix MTU handling of the VTI6 interfaces on
> interfamily tunnels. From Stefano Brivio.
>
> Please pull or let me know if there are problems.
Pulled, thanks Steffen.
^ permalink raw reply
* Re: [PATCH net-next 0/2] net/ipv6 misc
From: David Miller @ 2018-05-08 3:50 UTC (permalink / raw)
To: tariqt; +Cc: netdev, eranbe
In-Reply-To: <1525679127-26987-1-git-send-email-tariqt@mellanox.com>
From: Tariq Toukan <tariqt@mellanox.com>
Date: Mon, 7 May 2018 10:45:25 +0300
> This patchset contains two patches for net/ipv6.
>
> Patch 1 is a trivial typo fix in documentation.
> Patch 2 by Eran is a re-spin. It adds GRO support for IPv6 GRE tunnel,
> this significantly improves performance in case GRO in native interface
> is disabled.
>
> Series generated against net-next commit:
> 90278871d4b0 Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next
Series applied, thanks Tariq.
^ permalink raw reply
* Re: [PATCH net] net/tls: Fix connection stall on partial tls record
From: David Miller @ 2018-05-08 3:49 UTC (permalink / raw)
To: andre; +Cc: netdev, borisp, aviadye, davejwatson
In-Reply-To: <20180507022439.265020-1-andre@tomt.net>
From: Andre Tomt <andre@tomt.net>
Date: Mon, 7 May 2018 04:24:39 +0200
> In the case of writing a partial tls record we forgot to clear the
> ctx->in_tcp_sendpages flag, causing some connections to stall.
>
> Fixes: c212d2c7fc47 ("net/tls: Don't recursively call push_record during tls_write_space callbacks")
> Signed-off-by: Andre Tomt <andre@tomt.net>
Applied, thanks Andre.
^ permalink raw reply
* Re: [PATCH 8/9] net: flow_dissector: fix typo 'can by' to 'can be'
From: David Miller @ 2018-05-08 3:47 UTC (permalink / raw)
To: wsa+renesas; +Cc: trivial, linux-renesas-soc, netdev, linux-kernel
In-Reply-To: <20180506112404.24872-9-wsa+renesas@sang-engineering.com>
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: Sun, 6 May 2018 13:23:52 +0200
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 0/4] qed*: Add support for new multi partitioning modes.
From: David Miller @ 2018-05-08 3:46 UTC (permalink / raw)
To: sudarsana.kalluru; +Cc: netdev, Ariel.Elior
In-Reply-To: <20180506014302.29110-1-sudarsana.kalluru@cavium.com>
From: Sudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com>
Date: Sat, 5 May 2018 18:42:58 -0700
> From: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
>
> The patch series simplifies the multi function (MF) mode implementation of
> qed/qede drivers, and adds support for new MF modes.
>
> Please consider applying it to net-next branch.
Series applied, thanks.
^ permalink raw reply
* Re: [PATCH net] net: dsa: mv88e6xxx: Fix PHY interrupts by parameterising PHY base address
From: David Miller @ 2018-05-08 3:42 UTC (permalink / raw)
To: andrew; +Cc: netdev, vivien.didelot
In-Reply-To: <1525546702-704-1-git-send-email-andrew@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Sat, 5 May 2018 20:58:22 +0200
> Most of the mv88e6xxx switches have the PHYs at address 0, 1, 2, ...
> The 6341 however has the PHYs at 0x10, 0x11, 0x12. Add a parameter to
> the info structure for this base address.
>
> Testing of 6f88284f3bd7 ("net: dsa: mv88e6xxx: Add MDIO interrupts for
> internal PHYs") was performed on the 6341. So it works only on the
> 6341. Use this base information to correctly set the interrupt.
>
> Fixes: 6f88284f3bd7 ("net: dsa: mv88e6xxx: Add MDIO interrupts for internal PHYs")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied to 'net'.
> This is a rather big patch for net, but it is simple. What it is
> fixing is also not too big an issue. Since the interrupt number is in
> the wrong place, phylib does not find it, and so does polling. So i
> would understand if this goes to net-next, not net.
It's 'big' but simple.
^ permalink raw reply
* Re: [PATCH net] tls: fix use after free in tls_sk_proto_close
From: David Miller @ 2018-05-08 3:41 UTC (permalink / raw)
To: edumazet
Cc: netdev, eric.dumazet, atul.gupta, swise, ilyal, aviadye,
davejwatson
In-Reply-To: <20180505153504.109670-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Sat, 5 May 2018 08:35:04 -0700
> syzbot reported a use-after-free in tls_sk_proto_close
>
> Add a boolean value to cleanup a bit this function.
...
> Fixes: dd0bed1665d6 ("tls: support for Inline tls record")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Atul Gupta <atul.gupta@chelsio.com>
> Cc: Steve Wise <swise@opengridcomputing.com>
> Cc: Ilya Lesokhin <ilyal@mellanox.com>
> Cc: Aviad Yehezkel <aviadye@mellanox.com>
> Cc: Dave Watson <davejwatson@fb.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied, thanks Eric.
^ permalink raw reply
* Re: [PATCHv2 net] sctp: delay the authentication for the duplicated cookie-echo chunk
From: David Miller @ 2018-05-08 3:39 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman
In-Reply-To: <2a815adb308826967c84cd8dc371c3c9b054c8da.1525503587.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Sat, 5 May 2018 14:59:47 +0800
> Now sctp only delays the authentication for the normal cookie-echo
> chunk by setting chunk->auth_chunk in sctp_endpoint_bh_rcv(). But
> for the duplicated one with auth, in sctp_assoc_bh_rcv(), it does
> authentication first based on the old asoc, which will definitely
> fail due to the different auth info in the old asoc.
>
> The duplicated cookie-echo chunk will create a new asoc with the
> auth info from this chunk, and the authentication should also be
> done with the new asoc's auth info for all of the collision 'A',
> 'B' and 'D'. Otherwise, the duplicated cookie-echo chunk with auth
> will never pass the authentication and create the new connection.
>
> This issue exists since very beginning, and this fix is to make
> sctp_assoc_bh_rcv() follow the way sctp_endpoint_bh_rcv() does
> for the normal cookie-echo chunk to delay the authentication.
>
> While at it, remove the unused params from sctp_sf_authenticate()
> and define sctp_auth_chunk_verify() used for all the places that
> do the delayed authentication.
>
> v1->v2:
> fix the typo in changelog as Marcelo noticed.
>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] net/9p: correct the variable name in v9fs_get_trans_by_name() comment
From: David Miller @ 2018-05-08 3:38 UTC (permalink / raw)
To: sunlw.fnst; +Cc: netdev
In-Reply-To: <20180505032916.6069-1-sunlw.fnst@cn.fujitsu.com>
From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
Date: Sat, 5 May 2018 11:29:16 +0800
> The v9fs_get_trans_by_name(char *s) variable name is not "name" but "s".
>
> Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] vlan: correct the file path in vlan_dev_change_flags() comment
From: David Miller @ 2018-05-08 3:37 UTC (permalink / raw)
To: sunlw.fnst; +Cc: netdev
In-Reply-To: <20180505010818.3309-1-sunlw.fnst@cn.fujitsu.com>
From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
Date: Sat, 5 May 2018 09:08:18 +0800
> The vlan_flags enum is defined in include/uapi/linux/if_vlan.h file.
> not in include/linux/if_vlan.h file.
>
> Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
Applied.
^ permalink raw reply
* Re: pull-request: bpf-next 2018-05-05
From: David Miller @ 2018-05-08 3:36 UTC (permalink / raw)
To: daniel; +Cc: ast, netdev
In-Reply-To: <20180505002547.4567-1-daniel@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Sat, 5 May 2018 02:25:47 +0200
> The following pull-request contains BPF updates for your *net-next* tree.
>
> The main changes are:
...
> Please consider pulling these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git
Pulled.
> This has a minor merge conflict in tools/testing/selftests/bpf/test_progs.c.
> Resolution is to take the hunk from bpf-next tree and change the first CHECK()
> condition such that the missing '\n' is added to the end of the string, like:
>
> if (CHECK(build_id_matches < 1, "build id match",
> "Didn't find expected build ID from the map\n"))
> goto disable_pmu;
Thanks a lot for this.
^ permalink raw reply
* Re: [PATCH net] Added support for 802.1ad Q in Q Ethernet tagged frames
From: David Miller @ 2018-05-08 3:32 UTC (permalink / raw)
To: eladv6; +Cc: netdev
In-Reply-To: <cc17f655-337d-0789-b3b2-f322efab907e@gmail.com>
From: Elad Nachman <eladv6@gmail.com>
Date: Fri, 4 May 2018 21:25:47 +0300
> stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before calling napi_gro_receive().
Please fix your Subject line.
A subject line should have an appropriate subsystem prefix after
the "[ ... ]" clause, in this case an appropriate subsystem
prefix would be "stmmac: ", thus:
Subject: [PATCH net] stmmac: Add support for 802.1ad Q in Q Ethernet tagged frames
^ permalink raw reply
* Re: [PATCH V2 net-next] liquidio: support use of ethtool to set link speed of CN23XX-225 cards
From: David Miller @ 2018-05-08 3:31 UTC (permalink / raw)
To: felix.manlunas
Cc: netdev, raghu.vatsavayi, derek.chickles, satananda.burla,
weilin.chang
In-Reply-To: <20180504180719.GA2053@felix-thinkpad.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Fri, 4 May 2018 11:07:19 -0700
> From: Weilin Chang <weilin.chang@cavium.com>
>
> Support setting the link speed of CN23XX-225 cards (which can do 25Gbps or
> 10Gbps) via ethtool_ops.set_link_ksettings.
>
> Also fix the function assigned to ethtool_ops.get_link_ksettings to use the
> new link_ksettings api completely (instead of partially via
> ethtool_convert_legacy_u32_to_link_mode).
>
> Signed-off-by: Weilin Chang <weilin.chang@cavium.com>
> Acked-by: Raghu Vatsavayi <raghu.vatsavayi@cavium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
> ---
> Patch Change Log:
> V1 -> V2:
> In lio_set_link_ksettings(), set the order of local variable
> declarations from longest to shortest line.
Applied.
^ permalink raw reply
* Re: [PATCH 2/2] net: nixge: Address compiler warnings about signedness
From: David Miller @ 2018-05-08 3:30 UTC (permalink / raw)
To: mdf; +Cc: linux-kernel, netdev, alex.williams
In-Reply-To: <20180504171834.9365-2-mdf@kernel.org>
From: Moritz Fischer <mdf@kernel.org>
Date: Fri, 4 May 2018 10:18:34 -0700
> Fixes the following warnings:
> warning: pointer targets in passing argument 1 of
> ‘is_valid_ether_addr’ differ in signedness [-Wpointer-sign]
> if (mac_addr && is_valid_ether_addr(mac_addr)) {
> ^~~~~~~~
> expected ‘const u8 * {aka const unsigned char *}’ but argument
> is of type ‘const char *’
> static inline bool is_valid_ether_addr(const u8 *addr)
> ^~~~~~~~~~~~~~~~~~~
> warning: pointer targets in passing argument 2 of
> ‘ether_addr_copy’ differ in signedness [-Wpointer-sign]
> ether_addr_copy(ndev->dev_addr, mac_addr);
> ^~~~~~~~
> expected ‘const u8 * {aka const unsigned char *}’ but argument
> is of type ‘const char *’
> static inline void ether_addr_copy(u8 *dst, const u8 *src)
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox