* Re: [PATCH] [RFC v2] Drop all 00-INDEX files from Documentation/
From: Mike Rapoport @ 2018-09-04 17:56 UTC (permalink / raw)
To: Henrik Austad
Cc: Mark Rutland, linux-mips, linux-fbdev, x86, kvm, linux-doc,
Peter Zijlstra, James Hogan, Linus Walleij, Will Deacon,
dri-devel, Masahiro Yamada, Jan Kandziora, Paul Mackerras,
Henrik Austad, Pavel Machek, H. Peter Anvin, Evgeniy Polyakov,
linux-s390, Ian Kent, linux-security-module, Paul Moore,
Jonathan Corbet, Helge Deller, Radim Krčmář,
James E.J. Bottomley
In-Reply-To: <1536012923-16275-1-git-send-email-henrik@austad.us>
On Tue, Sep 04, 2018 at 12:15:23AM +0200, Henrik Austad wrote:
> This is a respin with a wider audience (all that get_maintainer returned)
> and I know this spams a *lot* of people. Not sure what would be the correct
> way, so my apologies for ruining your inbox.
>
> The 00-INDEX files are supposed to give a summary of all files present
> in a directory, but these files are horribly out of date and their
> usefulness is brought into question. Often a simple "ls" would reveal
> the same information as the filenames are generally quite descriptive as
> a short introduction to what the file covers (it should not surprise
> anyone what Documentation/sched/sched-design-CFS.txt covers)
>
> A few years back it was mentioned that these files were no longer really
> needed, and they have since then grown further out of date, so perhaps
> it is time to just throw them out.
>
> A short status yields the following _outdated_ 00-INDEX files, first
> counter is files listed in 00-INDEX but missing in the directory, last
> is files present but not listed in 00-INDEX.
>
> List of outdated 00-INDEX:
> Documentation: (4/10)
> Documentation/sysctl: (0/1)
> Documentation/timers: (1/0)
> Documentation/blockdev: (3/1)
> Documentation/w1/slaves: (0/1)
> Documentation/locking: (0/1)
> Documentation/devicetree: (0/5)
> Documentation/power: (1/1)
> Documentation/powerpc: (0/5)
> Documentation/arm: (1/0)
> Documentation/x86: (0/9)
> Documentation/x86/x86_64: (1/1)
> Documentation/scsi: (4/4)
> Documentation/filesystems: (2/9)
> Documentation/filesystems/nfs: (0/2)
> Documentation/cgroup-v1: (0/2)
> Documentation/kbuild: (0/4)
> Documentation/spi: (1/0)
> Documentation/virtual/kvm: (1/0)
> Documentation/scheduler: (0/2)
> Documentation/fb: (0/1)
> Documentation/block: (0/1)
> Documentation/networking: (6/37)
> Documentation/vm: (1/3)
>
> Then there are 364 subdirectories in Documentation/ with several files that
> are missing 00-INDEX alltogether (and another 120 with a single file and no
> 00-INDEX).
>
> I don't really have an opinion to whether or not we /should/ have 00-INDEX,
> but the above 00-INDEX should either be removed or be kept up to date. If
> we should keep the files, I can try to keep them updated, but I rather not
> if we just want to delete them anyway.
>
> As a starting point, remove all index-files and references to 00-INDEX and
> see where the discussion is going.
For the Documentation/vm
Acked-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
> Again, sorry for the insanely wide distribution.
>
> Signed-off-by: Henrik Austad <henrik@austad.us>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Michal Marek <michal.lkml@markovi.net>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: James Hogan <jhogan@kernel.org>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Radim Krčmář" <rkrcmar@redhat.com>
> Cc: Evgeniy Polyakov <zbr@ioremap.net>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Henrik Austad <henrik@austad.us>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Ian Kent <raven@themaw.net>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
> Cc: Jan Kandziora <jjj@gmx.de>
> Cc: linux-doc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-ide@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-kbuild@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Cc: linux-security-module@vger.kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-s390@vger.kernel.org
> Cc: linux-spi@vger.kernel.org
> Cc: kvm@vger.kernel.org
> Signed-off-by: Henrik Austad <haustad@cisco.com>
> ---
> Documentation/00-INDEX | 428 --------------------------------
> Documentation/PCI/00-INDEX | 26 --
> Documentation/RCU/00-INDEX | 34 ---
> Documentation/RCU/rcu.txt | 4 -
> Documentation/admin-guide/README.rst | 3 +-
> Documentation/arm/00-INDEX | 50 ----
> Documentation/block/00-INDEX | 34 ---
> Documentation/blockdev/00-INDEX | 18 --
> Documentation/cdrom/00-INDEX | 11 -
> Documentation/cgroup-v1/00-INDEX | 26 --
> Documentation/devicetree/00-INDEX | 12 -
> Documentation/fb/00-INDEX | 75 ------
> Documentation/filesystems/00-INDEX | 153 ------------
> Documentation/filesystems/nfs/00-INDEX | 26 --
> Documentation/fmc/00-INDEX | 38 ---
> Documentation/gpio/00-INDEX | 4 -
> Documentation/ide/00-INDEX | 14 --
> Documentation/ioctl/00-INDEX | 12 -
> Documentation/isdn/00-INDEX | 42 ----
> Documentation/kbuild/00-INDEX | 14 --
> Documentation/laptops/00-INDEX | 16 --
> Documentation/leds/00-INDEX | 32 ---
> Documentation/locking/00-INDEX | 16 --
> Documentation/m68k/00-INDEX | 7 -
> Documentation/mips/00-INDEX | 4 -
> Documentation/mmc/00-INDEX | 10 -
> Documentation/netlabel/00-INDEX | 10 -
> Documentation/netlabel/cipso_ipv4.txt | 11 +-
> Documentation/netlabel/introduction.txt | 2 +-
> Documentation/networking/00-INDEX | 234 -----------------
> Documentation/parisc/00-INDEX | 6 -
> Documentation/power/00-INDEX | 44 ----
> Documentation/powerpc/00-INDEX | 34 ---
> Documentation/s390/00-INDEX | 28 ---
> Documentation/scheduler/00-INDEX | 18 --
> Documentation/scsi/00-INDEX | 108 --------
> Documentation/serial/00-INDEX | 16 --
> Documentation/spi/00-INDEX | 16 --
> Documentation/sysctl/00-INDEX | 16 --
> Documentation/timers/00-INDEX | 16 --
> Documentation/virtual/00-INDEX | 11 -
> Documentation/virtual/kvm/00-INDEX | 35 ---
> Documentation/vm/00-INDEX | 50 ----
> Documentation/w1/00-INDEX | 10 -
> Documentation/w1/masters/00-INDEX | 12 -
> Documentation/w1/slaves/00-INDEX | 14 --
> Documentation/x86/00-INDEX | 20 --
> Documentation/x86/x86_64/00-INDEX | 16 --
> README | 1 -
> scripts/check_00index.sh | 67 -----
> 50 files changed, 8 insertions(+), 1896 deletions(-)
> delete mode 100644 Documentation/00-INDEX
> delete mode 100644 Documentation/PCI/00-INDEX
> delete mode 100644 Documentation/RCU/00-INDEX
> delete mode 100644 Documentation/arm/00-INDEX
> delete mode 100644 Documentation/block/00-INDEX
> delete mode 100644 Documentation/blockdev/00-INDEX
> delete mode 100644 Documentation/cdrom/00-INDEX
> delete mode 100644 Documentation/cgroup-v1/00-INDEX
> delete mode 100644 Documentation/devicetree/00-INDEX
> delete mode 100644 Documentation/fb/00-INDEX
> delete mode 100644 Documentation/filesystems/00-INDEX
> delete mode 100644 Documentation/filesystems/nfs/00-INDEX
> delete mode 100644 Documentation/fmc/00-INDEX
> delete mode 100644 Documentation/gpio/00-INDEX
> delete mode 100644 Documentation/ide/00-INDEX
> delete mode 100644 Documentation/ioctl/00-INDEX
> delete mode 100644 Documentation/isdn/00-INDEX
> delete mode 100644 Documentation/kbuild/00-INDEX
> delete mode 100644 Documentation/laptops/00-INDEX
> delete mode 100644 Documentation/leds/00-INDEX
> delete mode 100644 Documentation/locking/00-INDEX
> delete mode 100644 Documentation/m68k/00-INDEX
> delete mode 100644 Documentation/mips/00-INDEX
> delete mode 100644 Documentation/mmc/00-INDEX
> delete mode 100644 Documentation/netlabel/00-INDEX
> delete mode 100644 Documentation/networking/00-INDEX
> delete mode 100644 Documentation/parisc/00-INDEX
> delete mode 100644 Documentation/power/00-INDEX
> delete mode 100644 Documentation/powerpc/00-INDEX
> delete mode 100644 Documentation/s390/00-INDEX
> delete mode 100644 Documentation/scheduler/00-INDEX
> delete mode 100644 Documentation/scsi/00-INDEX
> delete mode 100644 Documentation/serial/00-INDEX
> delete mode 100644 Documentation/spi/00-INDEX
> delete mode 100644 Documentation/sysctl/00-INDEX
> delete mode 100644 Documentation/timers/00-INDEX
> delete mode 100644 Documentation/virtual/00-INDEX
> delete mode 100644 Documentation/virtual/kvm/00-INDEX
> delete mode 100644 Documentation/vm/00-INDEX
> delete mode 100644 Documentation/w1/00-INDEX
> delete mode 100644 Documentation/w1/masters/00-INDEX
> delete mode 100644 Documentation/w1/slaves/00-INDEX
> delete mode 100644 Documentation/x86/00-INDEX
> delete mode 100644 Documentation/x86/x86_64/00-INDEX
> delete mode 100755 scripts/check_00index.sh
>
> diff --git a/Documentation/00-INDEX b/Documentation/00-INDEX
> deleted file mode 100644
> index 2754fe8..0000000
> --- a/Documentation/00-INDEX
> +++ /dev/null
> @@ -1,428 +0,0 @@
> -
> -This is a brief list of all the files in ./linux/Documentation and what
> -they contain. If you add a documentation file, please list it here in
> -alphabetical order as well, or risk being hunted down like a rabid dog.
> -Please keep the descriptions small enough to fit on one line.
> - Thanks -- Paul G.
> -
> -Following translations are available on the WWW:
> -
> - - Japanese, maintained by the JF Project (jf@listserv.linux.or.jp), at
> - http://linuxjf.sourceforge.jp/
> -
> -00-INDEX
> - - this file.
> -ABI/
> - - info on kernel <-> userspace ABI and relative interface stability.
> -CodingStyle
> - - nothing here, just a pointer to process/coding-style.rst.
> -DMA-API.txt
> - - DMA API, pci_ API & extensions for non-consistent memory machines.
> -DMA-API-HOWTO.txt
> - - Dynamic DMA mapping Guide
> -DMA-ISA-LPC.txt
> - - How to do DMA with ISA (and LPC) devices.
> -DMA-attributes.txt
> - - listing of the various possible attributes a DMA region can have
> -EDID/
> - - directory with info on customizing EDID for broken gfx/displays.
> -IPMI.txt
> - - info on Linux Intelligent Platform Management Interface (IPMI) Driver.
> -IRQ-affinity.txt
> - - how to select which CPU(s) handle which interrupt events on SMP.
> -IRQ-domain.txt
> - - info on interrupt numbering and setting up IRQ domains.
> -IRQ.txt
> - - description of what an IRQ is.
> -Intel-IOMMU.txt
> - - basic info on the Intel IOMMU virtualization support.
> -Makefile
> - - It's not of interest for those who aren't touching the build system.
> -PCI/
> - - info related to PCI drivers.
> -RCU/
> - - directory with info on RCU (read-copy update).
> -SAK.txt
> - - info on Secure Attention Keys.
> -SM501.txt
> - - Silicon Motion SM501 multimedia companion chip
> -SubmittingPatches
> - - nothing here, just a pointer to process/coding-style.rst.
> -accounting/
> - - documentation on accounting and taskstats.
> -acpi/
> - - info on ACPI-specific hooks in the kernel.
> -admin-guide/
> - - info related to Linux users and system admins.
> -aoe/
> - - description of AoE (ATA over Ethernet) along with config examples.
> -arm/
> - - directory with info about Linux on the ARM architecture.
> -arm64/
> - - directory with info about Linux on the 64 bit ARM architecture.
> -auxdisplay/
> - - misc. LCD driver documentation (cfag12864b, ks0108).
> -backlight/
> - - directory with info on controlling backlights in flat panel displays
> -block/
> - - info on the Block I/O (BIO) layer.
> -blockdev/
> - - info on block devices & drivers
> -bt8xxgpio.txt
> - - info on how to modify a bt8xx video card for GPIO usage.
> -btmrvl.txt
> - - info on Marvell Bluetooth driver usage.
> -bus-devices/
> - - directory with info on TI GPMC (General Purpose Memory Controller)
> -bus-virt-phys-mapping.txt
> - - how to access I/O mapped memory from within device drivers.
> -cdrom/
> - - directory with information on the CD-ROM drivers that Linux has.
> -cgroup-v1/
> - - cgroups v1 features, including cpusets and memory controller.
> -cma/
> - - Continuous Memory Area (CMA) debugfs interface.
> -conf.py
> - - It's not of interest for those who aren't touching the build system.
> -connector/
> - - docs on the netlink based userspace<->kernel space communication mod.
> -console/
> - - documentation on Linux console drivers.
> -core-api/
> - - documentation on kernel core components.
> -cpu-freq/
> - - info on CPU frequency and voltage scaling.
> -cpu-hotplug.txt
> - - document describing CPU hotplug support in the Linux kernel.
> -cpu-load.txt
> - - document describing how CPU load statistics are collected.
> -cpuidle/
> - - info on CPU_IDLE, CPU idle state management subsystem.
> -cputopology.txt
> - - documentation on how CPU topology info is exported via sysfs.
> -crc32.txt
> - - brief tutorial on CRC computation
> -crypto/
> - - directory with info on the Crypto API.
> -dcdbas.txt
> - - information on the Dell Systems Management Base Driver.
> -debugging-modules.txt
> - - some notes on debugging modules after Linux 2.6.3.
> -debugging-via-ohci1394.txt
> - - how to use firewire like a hardware debugger memory reader.
> -dell_rbu.txt
> - - document demonstrating the use of the Dell Remote BIOS Update driver.
> -dev-tools/
> - - directory with info on development tools for the kernel.
> -device-mapper/
> - - directory with info on Device Mapper.
> -dmaengine/
> - - the DMA engine and controller API guides.
> -devicetree/
> - - directory with info on device tree files used by OF/PowerPC/ARM
> -digsig.txt
> - -info on the Digital Signature Verification API
> -dma-buf-sharing.txt
> - - the DMA Buffer Sharing API Guide
> -docutils.conf
> - - nothing here. Just a configuration file for docutils.
> -dontdiff
> - - file containing a list of files that should never be diff'ed.
> -driver-api/
> - - the Linux driver implementer's API guide.
> -driver-model/
> - - directory with info about Linux driver model.
> -early-userspace/
> - - info about initramfs, klibc, and userspace early during boot.
> -efi-stub.txt
> - - How to use the EFI boot stub to bypass GRUB or elilo on EFI systems.
> -eisa.txt
> - - info on EISA bus support.
> -extcon/
> - - directory with porting guide for Android kernel switch driver.
> -isa.txt
> - - info on EISA bus support.
> -fault-injection/
> - - dir with docs about the fault injection capabilities infrastructure.
> -fb/
> - - directory with info on the frame buffer graphics abstraction layer.
> -features/
> - - status of feature implementation on different architectures.
> -filesystems/
> - - info on the vfs and the various filesystems that Linux supports.
> -firmware_class/
> - - request_firmware() hotplug interface info.
> -flexible-arrays.txt
> - - how to make use of flexible sized arrays in linux
> -fmc/
> - - information about the FMC bus abstraction
> -fpga/
> - - FPGA Manager Core.
> -futex-requeue-pi.txt
> - - info on requeueing of tasks from a non-PI futex to a PI futex
> -gcc-plugins.txt
> - - GCC plugin infrastructure.
> -gpio/
> - - gpio related documentation
> -gpu/
> - - directory with information on GPU driver developer's guide.
> -hid/
> - - directory with information on human interface devices
> -highuid.txt
> - - notes on the change from 16 bit to 32 bit user/group IDs.
> -hwspinlock.txt
> - - hardware spinlock provides hardware assistance for synchronization
> -timers/
> - - info on the timer related topics
> -hw_random.txt
> - - info on Linux support for random number generator in i8xx chipsets.
> -hwmon/
> - - directory with docs on various hardware monitoring drivers.
> -i2c/
> - - directory with info about the I2C bus/protocol (2 wire, kHz speed).
> -x86/i386/
> - - directory with info about Linux on Intel 32 bit architecture.
> -ia64/
> - - directory with info about Linux on Intel 64 bit architecture.
> -ide/
> - - Information regarding the Enhanced IDE drive.
> -iio/
> - - info on industrial IIO configfs support.
> -index.rst
> - - main index for the documentation at ReST format.
> -infiniband/
> - - directory with documents concerning Linux InfiniBand support.
> -input/
> - - info on Linux input device support.
> -intel_txt.txt
> - - info on intel Trusted Execution Technology (intel TXT).
> -io-mapping.txt
> - - description of io_mapping functions in linux/io-mapping.h
> -io_ordering.txt
> - - info on ordering I/O writes to memory-mapped addresses.
> -ioctl/
> - - directory with documents describing various IOCTL calls.
> -iostats.txt
> - - info on I/O statistics Linux kernel provides.
> -irqflags-tracing.txt
> - - how to use the irq-flags tracing feature.
> -isapnp.txt
> - - info on Linux ISA Plug & Play support.
> -isdn/
> - - directory with info on the Linux ISDN support, and supported cards.
> -kbuild/
> - - directory with info about the kernel build process.
> -kdump/
> - - directory with mini HowTo on getting the crash dump code to work.
> -doc-guide/
> - - how to write and format reStructuredText kernel documentation
> -kernel-per-CPU-kthreads.txt
> - - List of all per-CPU kthreads and how they introduce jitter.
> -kobject.txt
> - - info of the kobject infrastructure of the Linux kernel.
> -kprobes.txt
> - - documents the kernel probes debugging feature.
> -kref.txt
> - - docs on adding reference counters (krefs) to kernel objects.
> -laptops/
> - - directory with laptop related info and laptop driver documentation.
> -ldm.txt
> - - a brief description of LDM (Windows Dynamic Disks).
> -leds/
> - - directory with info about LED handling under Linux.
> -livepatch/
> - - info on kernel live patching.
> -locking/
> - - directory with info about kernel locking primitives
> -lockup-watchdogs.txt
> - - info on soft and hard lockup detectors (aka nmi_watchdog).
> -logo.gif
> - - full colour GIF image of Linux logo (penguin - Tux).
> -logo.txt
> - - info on creator of above logo & site to get additional images from.
> -lsm.txt
> - - Linux Security Modules: General Security Hooks for Linux
> -lzo.txt
> - - kernel LZO decompressor input formats
> -m68k/
> - - directory with info about Linux on Motorola 68k architecture.
> -mailbox.txt
> - - How to write drivers for the common mailbox framework (IPC).
> -md/
> - - directory with info about Linux Software RAID
> -media/
> - - info on media drivers: uAPI, kAPI and driver documentation.
> -memory-barriers.txt
> - - info on Linux kernel memory barriers.
> -memory-devices/
> - - directory with info on parts like the Texas Instruments EMIF driver
> -memory-hotplug.txt
> - - Hotpluggable memory support, how to use and current status.
> -men-chameleon-bus.txt
> - - info on MEN chameleon bus.
> -mic/
> - - Intel Many Integrated Core (MIC) architecture device driver.
> -mips/
> - - directory with info about Linux on MIPS architecture.
> -misc-devices/
> - - directory with info about devices using the misc dev subsystem
> -mmc/
> - - directory with info about the MMC subsystem
> -mtd/
> - - directory with info about memory technology devices (flash)
> -namespaces/
> - - directory with various information about namespaces
> -netlabel/
> - - directory with information on the NetLabel subsystem.
> -networking/
> - - directory with info on various aspects of networking with Linux.
> -nfc/
> - - directory relating info about Near Field Communications support.
> -nios2/
> - - Linux on the Nios II architecture.
> -nommu-mmap.txt
> - - documentation about no-mmu memory mapping support.
> -numastat.txt
> - - info on how to read Numa policy hit/miss statistics in sysfs.
> -ntb.txt
> - - info on Non-Transparent Bridge (NTB) drivers.
> -nvdimm/
> - - info on non-volatile devices.
> -nvmem/
> - - info on non volatile memory framework.
> -output/
> - - default directory where html/LaTeX/pdf files will be written.
> -padata.txt
> - - An introduction to the "padata" parallel execution API
> -parisc/
> - - directory with info on using Linux on PA-RISC architecture.
> -parport-lowlevel.txt
> - - description and usage of the low level parallel port functions.
> -pcmcia/
> - - info on the Linux PCMCIA driver.
> -percpu-rw-semaphore.txt
> - - RCU based read-write semaphore optimized for locking for reading
> -perf/
> - - info about the APM X-Gene SoC Performance Monitoring Unit (PMU).
> -phy/
> - - ino on Samsung USB 2.0 PHY adaptation layer.
> -phy.txt
> - - Description of the generic PHY framework.
> -pi-futex.txt
> - - documentation on lightweight priority inheritance futexes.
> -pinctrl.txt
> - - info on pinctrl subsystem and the PINMUX/PINCONF and drivers
> -platform/
> - - List of supported hardware by compal and Dell laptop.
> -pnp.txt
> - - Linux Plug and Play documentation.
> -power/
> - - directory with info on Linux PCI power management.
> -powerpc/
> - - directory with info on using Linux with the PowerPC.
> -prctl/
> - - directory with info on the priveledge control subsystem
> -preempt-locking.txt
> - - info on locking under a preemptive kernel.
> -process/
> - - how to work with the mainline kernel development process.
> -pps/
> - - directory with information on the pulse-per-second support
> -pti/
> - - directory with info on Intel MID PTI.
> -ptp/
> - - directory with info on support for IEEE 1588 PTP clocks in Linux.
> -pwm.txt
> - - info on the pulse width modulation driver subsystem
> -rapidio/
> - - directory with info on RapidIO packet-based fabric interconnect
> -rbtree.txt
> - - info on what red-black trees are and what they are for.
> -remoteproc.txt
> - - info on how to handle remote processor (e.g. AMP) offloads/usage.
> -rfkill.txt
> - - info on the radio frequency kill switch subsystem/support.
> -robust-futex-ABI.txt
> - - documentation of the robust futex ABI.
> -robust-futexes.txt
> - - a description of what robust futexes are.
> -rpmsg.txt
> - - info on the Remote Processor Messaging (rpmsg) Framework
> -rtc.txt
> - - notes on how to use the Real Time Clock (aka CMOS clock) driver.
> -s390/
> - - directory with info on using Linux on the IBM S390.
> -scheduler/
> - - directory with info on the scheduler.
> -scsi/
> - - directory with info on Linux scsi support.
> -security/
> - - directory that contains security-related info
> -serial/
> - - directory with info on the low level serial API.
> -sgi-ioc4.txt
> - - description of the SGI IOC4 PCI (multi function) device.
> -sh/
> - - directory with info on porting Linux to a new architecture.
> -smsc_ece1099.txt
> - -info on the smsc Keyboard Scan Expansion/GPIO Expansion device.
> -sound/
> - - directory with info on sound card support.
> -spi/
> - - overview of Linux kernel Serial Peripheral Interface (SPI) support.
> -sphinx/
> - - no documentation here, just files required by Sphinx toolchain.
> -sphinx-static/
> - - no documentation here, just files required by Sphinx toolchain.
> -static-keys.txt
> - - info on how static keys allow debug code in hotpaths via patching
> -svga.txt
> - - short guide on selecting video modes at boot via VGA BIOS.
> -sync_file.txt
> - - Sync file API guide.
> -sysctl/
> - - directory with info on the /proc/sys/* files.
> -target/
> - - directory with info on generating TCM v4 fabric .ko modules
> -tee.txt
> - - info on the TEE subsystem and drivers
> -this_cpu_ops.txt
> - - List rationale behind and the way to use this_cpu operations.
> -thermal/
> - - directory with information on managing thermal issues (CPU/temp)
> -trace/
> - - directory with info on tracing technologies within linux
> -translations/
> - - translations of this document from English to another language
> -unaligned-memory-access.txt
> - - info on how to avoid arch breaking unaligned memory access in code.
> -unshare.txt
> - - description of the Linux unshare system call.
> -usb/
> - - directory with info regarding the Universal Serial Bus.
> -vfio.txt
> - - info on Virtual Function I/O used in guest/hypervisor instances.
> -video-output.txt
> - - sysfs class driver interface to enable/disable a video output device.
> -virtual/
> - - directory with information on the various linux virtualizations.
> -vm/
> - - directory with info on the Linux vm code.
> -w1/
> - - directory with documents regarding the 1-wire (w1) subsystem.
> -watchdog/
> - - how to auto-reboot Linux if it has "fallen and can't get up". ;-)
> -wimax/
> - - directory with info about Intel Wireless Wimax Connections
> -core-api/workqueue.rst
> - - information on the Concurrency Managed Workqueue implementation
> -x86/x86_64/
> - - directory with info on Linux support for AMD x86-64 (Hammer) machines.
> -xillybus.txt
> - - Overview and basic ui of xillybus driver
> -xtensa/
> - - directory with documents relating to arch/xtensa port/implementation
> -xz.txt
> - - how to make use of the XZ data compression within linux kernel
> -zorro.txt
> - - info on writing drivers for Zorro bus devices found on Amigas.
> diff --git a/Documentation/PCI/00-INDEX b/Documentation/PCI/00-INDEX
> deleted file mode 100644
> index 206b1d5..0000000
> --- a/Documentation/PCI/00-INDEX
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -00-INDEX
> - - this file
> -acpi-info.txt
> - - info on how PCI host bridges are represented in ACPI
> -MSI-HOWTO.txt
> - - the Message Signaled Interrupts (MSI) Driver Guide HOWTO and FAQ.
> -PCIEBUS-HOWTO.txt
> - - a guide describing the PCI Express Port Bus driver
> -pci-error-recovery.txt
> - - info on PCI error recovery
> -pci-iov-howto.txt
> - - the PCI Express I/O Virtualization HOWTO
> -pci.txt
> - - info on the PCI subsystem for device driver authors
> -pcieaer-howto.txt
> - - the PCI Express Advanced Error Reporting Driver Guide HOWTO
> -endpoint/pci-endpoint.txt
> - - guide to add endpoint controller driver and endpoint function driver.
> -endpoint/pci-endpoint-cfs.txt
> - - guide to use configfs to configure the PCI endpoint function.
> -endpoint/pci-test-function.txt
> - - specification of *PCI test* function device.
> -endpoint/pci-test-howto.txt
> - - userguide for PCI endpoint test function.
> -endpoint/function/binding/
> - - binding documentation for PCI endpoint function
> diff --git a/Documentation/RCU/00-INDEX b/Documentation/RCU/00-INDEX
> deleted file mode 100644
> index f46980c..0000000
> --- a/Documentation/RCU/00-INDEX
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -00-INDEX
> - - This file
> -arrayRCU.txt
> - - Using RCU to Protect Read-Mostly Arrays
> -checklist.txt
> - - Review Checklist for RCU Patches
> -listRCU.txt
> - - Using RCU to Protect Read-Mostly Linked Lists
> -lockdep.txt
> - - RCU and lockdep checking
> -lockdep-splat.txt
> - - RCU Lockdep splats explained.
> -NMI-RCU.txt
> - - Using RCU to Protect Dynamic NMI Handlers
> -rcu_dereference.txt
> - - Proper care and feeding of return values from rcu_dereference()
> -rcubarrier.txt
> - - RCU and Unloadable Modules
> -rculist_nulls.txt
> - - RCU list primitives for use with SLAB_TYPESAFE_BY_RCU
> -rcuref.txt
> - - Reference-count design for elements of lists/arrays protected by RCU
> -rcu.txt
> - - RCU Concepts
> -RTFP.txt
> - - List of RCU papers (bibliography) going back to 1980.
> -stallwarn.txt
> - - RCU CPU stall warnings (module parameter rcu_cpu_stall_suppress)
> -torture.txt
> - - RCU Torture Test Operation (CONFIG_RCU_TORTURE_TEST)
> -UP.txt
> - - RCU on Uniprocessor Systems
> -whatisRCU.txt
> - - What is RCU?
> diff --git a/Documentation/RCU/rcu.txt b/Documentation/RCU/rcu.txt
> index 7d4ae11..721b3e4 100644
> --- a/Documentation/RCU/rcu.txt
> +++ b/Documentation/RCU/rcu.txt
> @@ -87,7 +87,3 @@ o Where can I find more information on RCU?
>
> See the RTFP.txt file in this directory.
> Or point your browser at http://www.rdrop.com/users/paulmck/RCU/.
> -
> -o What are all these files in this directory?
> -
> - See 00-INDEX for the list.
> diff --git a/Documentation/admin-guide/README.rst b/Documentation/admin-guide/README.rst
> index 15ea785..0797eec 100644
> --- a/Documentation/admin-guide/README.rst
> +++ b/Documentation/admin-guide/README.rst
> @@ -51,8 +51,7 @@ Documentation
>
> - There are various README files in the Documentation/ subdirectory:
> these typically contain kernel-specific installation notes for some
> - drivers for example. See Documentation/00-INDEX for a list of what
> - is contained in each file. Please read the
> + drivers for example. Please read the
> :ref:`Documentation/process/changes.rst <changes>` file, as it
> contains information about the problems, which may result by upgrading
> your kernel.
> diff --git a/Documentation/arm/00-INDEX b/Documentation/arm/00-INDEX
> deleted file mode 100644
> index b6e69fd..0000000
> --- a/Documentation/arm/00-INDEX
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -00-INDEX
> - - this file
> -Booting
> - - requirements for booting
> -CCN.txt
> - - Cache Coherent Network ring-bus and perf PMU driver.
> -Interrupts
> - - ARM Interrupt subsystem documentation
> -IXP4xx
> - - Intel IXP4xx Network processor.
> -Netwinder
> - - Netwinder specific documentation
> -Porting
> - - Symbol definitions for porting Linux to a new ARM machine.
> -Setup
> - - Kernel initialization parameters on ARM Linux
> -README
> - - General ARM documentation
> -SA1100/
> - - SA1100 documentation
> -Samsung-S3C24XX/
> - - S3C24XX ARM Linux Overview
> -SPEAr/
> - - ST SPEAr platform Linux Overview
> -VFP/
> - - Release notes for Linux Kernel Vector Floating Point support code
> -cluster-pm-race-avoidance.txt
> - - Algorithm for CPU and Cluster setup/teardown
> -empeg/
> - - Ltd's Empeg MP3 Car Audio Player
> -firmware.txt
> - - Secure firmware registration and calling.
> -kernel_mode_neon.txt
> - - How to use NEON instructions in kernel mode
> -kernel_user_helpers.txt
> - - Helper functions in kernel space made available for userspace.
> -mem_alignment
> - - alignment abort handler documentation
> -memory.txt
> - - description of the virtual memory layout
> -nwfpe/
> - - NWFPE floating point emulator documentation
> -swp_emulation
> - - SWP/SWPB emulation handler/logging description
> -tcm.txt
> - - ARM Tightly Coupled Memory
> -uefi.txt
> - - [U]EFI configuration and runtime services documentation
> -vlocks.txt
> - - Voting locks, low-level mechanism relying on memory system atomic writes.
> diff --git a/Documentation/block/00-INDEX b/Documentation/block/00-INDEX
> deleted file mode 100644
> index 8d55b4b..0000000
> --- a/Documentation/block/00-INDEX
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -00-INDEX
> - - This file
> -bfq-iosched.txt
> - - BFQ IO scheduler and its tunables
> -biodoc.txt
> - - Notes on the Generic Block Layer Rewrite in Linux 2.5
> -biovecs.txt
> - - Immutable biovecs and biovec iterators
> -capability.txt
> - - Generic Block Device Capability (/sys/block/<device>/capability)
> -cfq-iosched.txt
> - - CFQ IO scheduler tunables
> -cmdline-partition.txt
> - - how to specify block device partitions on kernel command line
> -data-integrity.txt
> - - Block data integrity
> -deadline-iosched.txt
> - - Deadline IO scheduler tunables
> -ioprio.txt
> - - Block io priorities (in CFQ scheduler)
> -pr.txt
> - - Block layer support for Persistent Reservations
> -null_blk.txt
> - - Null block for block-layer benchmarking.
> -queue-sysfs.txt
> - - Queue's sysfs entries
> -request.txt
> - - The members of struct request (in include/linux/blkdev.h)
> -stat.txt
> - - Block layer statistics in /sys/block/<device>/stat
> -switching-sched.txt
> - - Switching I/O schedulers at runtime
> -writeback_cache_control.txt
> - - Control of volatile write back caches
> diff --git a/Documentation/blockdev/00-INDEX b/Documentation/blockdev/00-INDEX
> deleted file mode 100644
> index c08df56..0000000
> --- a/Documentation/blockdev/00-INDEX
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -00-INDEX
> - - this file
> -README.DAC960
> - - info on Mylex DAC960/DAC1100 PCI RAID Controller Driver for Linux.
> -cciss.txt
> - - info, major/minor #'s for Compaq's SMART Array Controllers.
> -cpqarray.txt
> - - info on using Compaq's SMART2 Intelligent Disk Array Controllers.
> -floppy.txt
> - - notes and driver options for the floppy disk driver.
> -mflash.txt
> - - info on mGine m(g)flash driver for linux.
> -nbd.txt
> - - info on a TCP implementation of a network block device.
> -paride.txt
> - - information about the parallel port IDE subsystem.
> -ramdisk.txt
> - - short guide on how to set up and use the RAM disk.
> diff --git a/Documentation/cdrom/00-INDEX b/Documentation/cdrom/00-INDEX
> deleted file mode 100644
> index 433edf2..0000000
> --- a/Documentation/cdrom/00-INDEX
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -00-INDEX
> - - this file (info on CD-ROMs and Linux)
> -Makefile
> - - only used to generate TeX output from the documentation.
> -cdrom-standard.tex
> - - LaTeX document on standardizing the CD-ROM programming interface.
> -ide-cd
> - - info on setting up and using ATAPI (aka IDE) CD-ROMs.
> -packet-writing.txt
> - - Info on the CDRW packet writing module
> -
> diff --git a/Documentation/cgroup-v1/00-INDEX b/Documentation/cgroup-v1/00-INDEX
> deleted file mode 100644
> index 13e0c85..0000000
> --- a/Documentation/cgroup-v1/00-INDEX
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -00-INDEX
> - - this file
> -blkio-controller.txt
> - - Description for Block IO Controller, implementation and usage details.
> -cgroups.txt
> - - Control Groups definition, implementation details, examples and API.
> -cpuacct.txt
> - - CPU Accounting Controller; account CPU usage for groups of tasks.
> -cpusets.txt
> - - documents the cpusets feature; assign CPUs and Mem to a set of tasks.
> -admin-guide/devices.rst
> - - Device Whitelist Controller; description, interface and security.
> -freezer-subsystem.txt
> - - checkpointing; rationale to not use signals, interface.
> -hugetlb.txt
> - - HugeTLB Controller implementation and usage details.
> -memcg_test.txt
> - - Memory Resource Controller; implementation details.
> -memory.txt
> - - Memory Resource Controller; design, accounting, interface, testing.
> -net_cls.txt
> - - Network classifier cgroups details and usages.
> -net_prio.txt
> - - Network priority cgroups details and usages.
> -pids.txt
> - - Process number cgroups details and usages.
> diff --git a/Documentation/devicetree/00-INDEX b/Documentation/devicetree/00-INDEX
> deleted file mode 100644
> index 8c4102c..0000000
> --- a/Documentation/devicetree/00-INDEX
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -Documentation for device trees, a data structure by which bootloaders pass
> -hardware layout to Linux in a device-independent manner, simplifying hardware
> -probing. This subsystem is maintained by Grant Likely
> -<grant.likely@secretlab.ca> and has a mailing list at
> -https://lists.ozlabs.org/listinfo/devicetree-discuss
> -
> -00-INDEX
> - - this file
> -booting-without-of.txt
> - - Booting Linux without Open Firmware, describes history and format of device trees.
> -usage-model.txt
> - - How Linux uses DT and what DT aims to solve.
> \ No newline at end of file
> diff --git a/Documentation/fb/00-INDEX b/Documentation/fb/00-INDEX
> deleted file mode 100644
> index fe85e7c..0000000
> --- a/Documentation/fb/00-INDEX
> +++ /dev/null
> @@ -1,75 +0,0 @@
> -Index of files in Documentation/fb. If you think something about frame
> -buffer devices needs an entry here, needs correction or you've written one
> -please mail me.
> - Geert Uytterhoeven <geert@linux-m68k.org>
> -
> -00-INDEX
> - - this file.
> -api.txt
> - - The frame buffer API between applications and buffer devices.
> -arkfb.txt
> - - info on the fbdev driver for ARK Logic chips.
> -aty128fb.txt
> - - info on the ATI Rage128 frame buffer driver.
> -cirrusfb.txt
> - - info on the driver for Cirrus Logic chipsets.
> -cmap_xfbdev.txt
> - - an introduction to fbdev's cmap structures.
> -deferred_io.txt
> - - an introduction to deferred IO.
> -efifb.txt
> - - info on the EFI platform driver for Intel based Apple computers.
> -ep93xx-fb.txt
> - - info on the driver for EP93xx LCD controller.
> -fbcon.txt
> - - intro to and usage guide for the framebuffer console (fbcon).
> -framebuffer.txt
> - - introduction to frame buffer devices.
> -gxfb.txt
> - - info on the framebuffer driver for AMD Geode GX2 based processors.
> -intel810.txt
> - - documentation for the Intel 810/815 framebuffer driver.
> -intelfb.txt
> - - docs for Intel 830M/845G/852GM/855GM/865G/915G/945G fb driver.
> -internals.txt
> - - quick overview of frame buffer device internals.
> -lxfb.txt
> - - info on the framebuffer driver for AMD Geode LX based processors.
> -matroxfb.txt
> - - info on the Matrox framebuffer driver for Alpha, Intel and PPC.
> -metronomefb.txt
> - - info on the driver for the Metronome display controller.
> -modedb.txt
> - - info on the video mode database.
> -pvr2fb.txt
> - - info on the PowerVR 2 frame buffer driver.
> -pxafb.txt
> - - info on the driver for the PXA25x LCD controller.
> -s3fb.txt
> - - info on the fbdev driver for S3 Trio/Virge chips.
> -sa1100fb.txt
> - - information about the driver for the SA-1100 LCD controller.
> -sh7760fb.txt
> - - info on the SH7760/SH7763 integrated LCDC Framebuffer driver.
> -sisfb.txt
> - - info on the framebuffer device driver for various SiS chips.
> -sm501.txt
> - - info on the framebuffer device driver for sm501 videoframebuffer.
> -sstfb.txt
> - - info on the frame buffer driver for 3dfx' Voodoo Graphics boards.
> -tgafb.txt
> - - info on the TGA (DECChip 21030) frame buffer driver.
> -tridentfb.txt
> - info on the framebuffer driver for some Trident chip based cards.
> -udlfb.txt
> - - Driver for DisplayLink USB 2.0 chips.
> -uvesafb.txt
> - - info on the userspace VESA (VBE2+ compliant) frame buffer device.
> -vesafb.txt
> - - info on the VESA frame buffer device.
> -viafb.modes
> - - list of modes for VIA Integration Graphic Chip.
> -viafb.txt
> - - info on the VIA Integration Graphic Chip console framebuffer driver.
> -vt8623fb.txt
> - - info on the fb driver for the graphics core in VIA VT8623 chipsets.
> diff --git a/Documentation/filesystems/00-INDEX b/Documentation/filesystems/00-INDEX
> deleted file mode 100644
> index 0937bad..0000000
> --- a/Documentation/filesystems/00-INDEX
> +++ /dev/null
> @@ -1,153 +0,0 @@
> -00-INDEX
> - - this file (info on some of the filesystems supported by linux).
> -Locking
> - - info on locking rules as they pertain to Linux VFS.
> -9p.txt
> - - 9p (v9fs) is an implementation of the Plan 9 remote fs protocol.
> -adfs.txt
> - - info and mount options for the Acorn Advanced Disc Filing System.
> -afs.txt
> - - info and examples for the distributed AFS (Andrew File System) fs.
> -affs.txt
> - - info and mount options for the Amiga Fast File System.
> -autofs-mount-control.txt
> - - info on device control operations for autofs module.
> -automount-support.txt
> - - information about filesystem automount support.
> -befs.txt
> - - information about the BeOS filesystem for Linux.
> -bfs.txt
> - - info for the SCO UnixWare Boot Filesystem (BFS).
> -btrfs.txt
> - - info for the BTRFS filesystem.
> -caching/
> - - directory containing filesystem cache documentation.
> -ceph.txt
> - - info for the Ceph Distributed File System.
> -cifs/
> - - directory containing CIFS filesystem documentation and example code.
> -coda.txt
> - - description of the CODA filesystem.
> -configfs/
> - - directory containing configfs documentation and example code.
> -cramfs.txt
> - - info on the cram filesystem for small storage (ROMs etc).
> -dax.txt
> - - info on avoiding the page cache for files stored on CPU-addressable
> - storage devices.
> -debugfs.txt
> - - info on the debugfs filesystem.
> -devpts.txt
> - - info on the devpts filesystem.
> -directory-locking
> - - info about the locking scheme used for directory operations.
> -dlmfs.txt
> - - info on the userspace interface to the OCFS2 DLM.
> -dnotify.txt
> - - info about directory notification in Linux.
> -dnotify_test.c
> - - example program for dnotify.
> -ecryptfs.txt
> - - docs on eCryptfs: stacked cryptographic filesystem for Linux.
> -efivarfs.txt
> - - info for the efivarfs filesystem.
> -exofs.txt
> - - info, usage, mount options, design about EXOFS.
> -ext2.txt
> - - info, mount options and specifications for the Ext2 filesystem.
> -ext3.txt
> - - info, mount options and specifications for the Ext3 filesystem.
> -ext4.txt
> - - info, mount options and specifications for the Ext4 filesystem.
> -f2fs.txt
> - - info and mount options for the F2FS filesystem.
> -fiemap.txt
> - - info on fiemap ioctl.
> -files.txt
> - - info on file management in the Linux kernel.
> -fuse.txt
> - - info on the Filesystem in User SpacE including mount options.
> -gfs2-glocks.txt
> - - info on the Global File System 2 - Glock internal locking rules.
> -gfs2-uevents.txt
> - - info on the Global File System 2 - uevents.
> -gfs2.txt
> - - info on the Global File System 2.
> -hfs.txt
> - - info on the Macintosh HFS Filesystem for Linux.
> -hfsplus.txt
> - - info on the Macintosh HFSPlus Filesystem for Linux.
> -hpfs.txt
> - - info and mount options for the OS/2 HPFS.
> -inotify.txt
> - - info on the powerful yet simple file change notification system.
> -isofs.txt
> - - info and mount options for the ISO 9660 (CDROM) filesystem.
> -jfs.txt
> - - info and mount options for the JFS filesystem.
> -locks.txt
> - - info on file locking implementations, flock() vs. fcntl(), etc.
> -mandatory-locking.txt
> - - info on the Linux implementation of Sys V mandatory file locking.
> -nfs/
> - - nfs-related documentation.
> -nilfs2.txt
> - - info and mount options for the NILFS2 filesystem.
> -ntfs.txt
> - - info and mount options for the NTFS filesystem (Windows NT).
> -ocfs2.txt
> - - info and mount options for the OCFS2 clustered filesystem.
> -omfs.txt
> - - info on the Optimized MPEG FileSystem.
> -path-lookup.txt
> - - info on path walking and name lookup locking.
> -pohmelfs/
> - - directory containing pohmelfs filesystem documentation.
> -porting
> - - various information on filesystem porting.
> -proc.txt
> - - info on Linux's /proc filesystem.
> -qnx6.txt
> - - info on the QNX6 filesystem.
> -quota.txt
> - - info on Quota subsystem.
> -ramfs-rootfs-initramfs.txt
> - - info on the 'in memory' filesystems ramfs, rootfs and initramfs.
> -relay.txt
> - - info on relay, for efficient streaming from kernel to user space.
> -romfs.txt
> - - description of the ROMFS filesystem.
> -seq_file.txt
> - - how to use the seq_file API.
> -sharedsubtree.txt
> - - a description of shared subtrees for namespaces.
> -spufs.txt
> - - info and mount options for the SPU filesystem used on Cell.
> -squashfs.txt
> - - info on the squashfs filesystem.
> -sysfs-pci.txt
> - - info on accessing PCI device resources through sysfs.
> -sysfs-tagging.txt
> - - info on sysfs tagging to avoid duplicates.
> -sysfs.txt
> - - info on sysfs, a ram-based filesystem for exporting kernel objects.
> -sysv-fs.txt
> - - info on the SystemV/V7/Xenix/Coherent filesystem.
> -tmpfs.txt
> - - info on tmpfs, a filesystem that holds all files in virtual memory.
> -ubifs.txt
> - - info on the Unsorted Block Images FileSystem.
> -udf.txt
> - - info and mount options for the UDF filesystem.
> -ufs.txt
> - - info on the ufs filesystem.
> -vfat.txt
> - - info on using the VFAT filesystem used in Windows NT and Windows 95.
> -vfs.txt
> - - overview of the Virtual File System.
> -xfs-delayed-logging-design.txt
> - - info on the XFS Delayed Logging Design.
> -xfs-self-describing-metadata.txt
> - - info on XFS Self Describing Metadata.
> -xfs.txt
> - - info and mount options for the XFS filesystem.
> diff --git a/Documentation/filesystems/nfs/00-INDEX b/Documentation/filesystems/nfs/00-INDEX
> deleted file mode 100644
> index 53f3b59..0000000
> --- a/Documentation/filesystems/nfs/00-INDEX
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -00-INDEX
> - - this file (nfs-related documentation).
> -Exporting
> - - explanation of how to make filesystems exportable.
> -fault_injection.txt
> - - information for using fault injection on the server
> -knfsd-stats.txt
> - - statistics which the NFS server makes available to user space.
> -nfs.txt
> - - nfs client, and DNS resolution for fs_locations.
> -nfs41-server.txt
> - - info on the Linux server implementation of NFSv4 minor version 1.
> -nfs-rdma.txt
> - - how to install and setup the Linux NFS/RDMA client and server software
> -nfsd-admin-interfaces.txt
> - - Administrative interfaces for nfsd.
> -nfsroot.txt
> - - short guide on setting up a diskless box with NFS root filesystem.
> -pnfs.txt
> - - short explanation of some of the internals of the pnfs client code
> -rpc-cache.txt
> - - introduction to the caching mechanisms in the sunrpc layer.
> -idmapper.txt
> - - information for configuring request-keys to be used by idmapper
> -rpc-server-gss.txt
> - - Information on GSS authentication support in the NFS Server
> diff --git a/Documentation/fmc/00-INDEX b/Documentation/fmc/00-INDEX
> deleted file mode 100644
> index 431c695..0000000
> --- a/Documentation/fmc/00-INDEX
> +++ /dev/null
> @@ -1,38 +0,0 @@
> -
> -Documentation in this directory comes from sections of the manual we
> -wrote for the externally-developed fmc-bus package. The complete
> -manual as of today (2013-02) is available in PDF format at
> -http://www.ohwr.org/projects/fmc-bus/files
> -
> -00-INDEX
> - - this file.
> -
> -FMC-and-SDB.txt
> - - What are FMC and SDB, basic concepts for this framework
> -
> -API.txt
> - - The functions that are exported by the bus driver
> -
> -parameters.txt
> - - The module parameters
> -
> -carrier.txt
> - - writing a carrier (a device)
> -
> -mezzanine.txt
> - - writing code for your mezzanine (a driver)
> -
> -identifiers.txt
> - - how identification and matching works
> -
> -fmc-fakedev.txt
> - - about drivers/fmc/fmc-fakedev.ko
> -
> -fmc-trivial.txt
> - - about drivers/fmc/fmc-trivial.ko
> -
> -fmc-write-eeprom.txt
> - - about drivers/fmc/fmc-write-eeprom.ko
> -
> -fmc-chardev.txt
> - - about drivers/fmc/fmc-chardev.ko
> diff --git a/Documentation/gpio/00-INDEX b/Documentation/gpio/00-INDEX
> deleted file mode 100644
> index 17e19a6..0000000
> --- a/Documentation/gpio/00-INDEX
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -00-INDEX
> - - This file
> -sysfs.txt
> - - Information about the GPIO sysfs interface
> diff --git a/Documentation/ide/00-INDEX b/Documentation/ide/00-INDEX
> deleted file mode 100644
> index 22f98ca..0000000
> --- a/Documentation/ide/00-INDEX
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -00-INDEX
> - - this file
> -ChangeLog.ide-cd.1994-2004
> - - ide-cd changelog
> -ChangeLog.ide-floppy.1996-2002
> - - ide-floppy changelog
> -ChangeLog.ide-tape.1995-2002
> - - ide-tape changelog
> -ide-tape.txt
> - - info on the IDE ATAPI streaming tape driver
> -ide.txt
> - - important info for users of ATA devices (IDE/EIDE disks and CD-ROMS).
> -warm-plug-howto.txt
> - - using sysfs to remove and add IDE devices.
> \ No newline at end of file
> diff --git a/Documentation/ioctl/00-INDEX b/Documentation/ioctl/00-INDEX
> deleted file mode 100644
> index c1a9257..0000000
> --- a/Documentation/ioctl/00-INDEX
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -00-INDEX
> - - this file
> -botching-up-ioctls.txt
> - - how to avoid botching up ioctls
> -cdrom.txt
> - - summary of CDROM ioctl calls
> -hdio.txt
> - - summary of HDIO_ ioctl calls
> -ioctl-decoding.txt
> - - how to decode the bits of an IOCTL code
> -ioctl-number.txt
> - - how to implement and register device/driver ioctl calls
> diff --git a/Documentation/isdn/00-INDEX b/Documentation/isdn/00-INDEX
> deleted file mode 100644
> index 2d1889b..0000000
> --- a/Documentation/isdn/00-INDEX
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -00-INDEX
> - - this file (info on ISDN implementation for Linux)
> -CREDITS
> - - list of the kind folks that brought you this stuff.
> -HiSax.cert
> - - information about the ITU approval certification of the HiSax driver.
> -INTERFACE
> - - description of isdn4linux Link Level and Hardware Level interfaces.
> -INTERFACE.fax
> - - description of the fax subinterface of isdn4linux.
> -INTERFACE.CAPI
> - - description of kernel CAPI Link Level to Hardware Level interface.
> -README
> - - general info on what you need and what to do for Linux ISDN.
> -README.FAQ
> - - general info for FAQ.
> -README.HiSax
> - - info on the HiSax driver which replaces the old teles.
> -README.audio
> - - info for running audio over ISDN.
> -README.avmb1
> - - info on driver for AVM-B1 ISDN card.
> -README.concap
> - - info on "CONCAP" encapsulation protocol interface used for X.25.
> -README.diversion
> - - info on module for isdn diversion services.
> -README.fax
> - - info for using Fax over ISDN.
> -README.gigaset
> - - info on the drivers for Siemens Gigaset ISDN adapters
> -README.hfc-pci
> - - info on hfc-pci based cards.
> -README.hysdn
> - - info on driver for Hypercope active HYSDN cards
> -README.mISDN
> - - info on the Modular ISDN subsystem (mISDN)
> -README.syncppp
> - - info on running Sync PPP over ISDN.
> -README.x25
> - - info for running X.25 over ISDN.
> -syncPPP.FAQ
> - - frequently asked questions about running PPP over ISDN.
> diff --git a/Documentation/kbuild/00-INDEX b/Documentation/kbuild/00-INDEX
> deleted file mode 100644
> index 8c5e6aa..0000000
> --- a/Documentation/kbuild/00-INDEX
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -00-INDEX
> - - this file: info on the kernel build process
> -headers_install.txt
> - - how to export Linux headers for use by userspace
> -kbuild.txt
> - - developer information on kbuild
> -kconfig.txt
> - - usage help for make *config
> -kconfig-language.txt
> - - specification of Config Language, the language in Kconfig files
> -makefiles.txt
> - - developer information for linux kernel makefiles
> -modules.txt
> - - how to build modules and to install them
> diff --git a/Documentation/laptops/00-INDEX b/Documentation/laptops/00-INDEX
> deleted file mode 100644
> index 86169dc..0000000
> --- a/Documentation/laptops/00-INDEX
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -00-INDEX
> - - This file
> -asus-laptop.txt
> - - information on the Asus Laptop Extras driver.
> -disk-shock-protection.txt
> - - information on hard disk shock protection.
> -laptop-mode.txt
> - - how to conserve battery power using laptop-mode.
> -sony-laptop.txt
> - - Sony Notebook Control Driver (SNC) Readme.
> -sonypi.txt
> - - info on Linux Sony Programmable I/O Device support.
> -thinkpad-acpi.txt
> - - information on the (IBM and Lenovo) ThinkPad ACPI Extras driver.
> -toshiba_haps.txt
> - - information on the Toshiba HDD Active Protection Sensor driver.
> diff --git a/Documentation/leds/00-INDEX b/Documentation/leds/00-INDEX
> deleted file mode 100644
> index ae626b2..0000000
> --- a/Documentation/leds/00-INDEX
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -00-INDEX
> - - This file
> -leds-blinkm.txt
> - - Driver for BlinkM LED-devices.
> -leds-class.txt
> - - documents LED handling under Linux.
> -leds-class-flash.txt
> - - documents flash LED handling under Linux.
> -leds-lm3556.txt
> - - notes on how to use the leds-lm3556 driver.
> -leds-lp3944.txt
> - - notes on how to use the leds-lp3944 driver.
> -leds-lp5521.txt
> - - notes on how to use the leds-lp5521 driver.
> -leds-lp5523.txt
> - - notes on how to use the leds-lp5523 driver.
> -leds-lp5562.txt
> - - notes on how to use the leds-lp5562 driver.
> -leds-lp55xx.txt
> - - description about lp55xx common driver.
> -leds-lm3556.txt
> - - notes on how to use the leds-lm3556 driver.
> -leds-mlxcpld.txt
> - - notes on how to use the leds-mlxcpld driver.
> -ledtrig-oneshot.txt
> - - One-shot LED trigger for both sporadic and dense events.
> -ledtrig-transient.txt
> - - LED Transient Trigger, one shot timer activation.
> -ledtrig-usbport.txt
> - - notes on how to use the drivers/usb/core/ledtrig-usbport.c trigger.
> -uleds.txt
> - - notes on how to use the uleds driver.
> diff --git a/Documentation/locking/00-INDEX b/Documentation/locking/00-INDEX
> deleted file mode 100644
> index c256c9b..0000000
> --- a/Documentation/locking/00-INDEX
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -00-INDEX
> - - this file.
> -lockdep-design.txt
> - - documentation on the runtime locking correctness validator.
> -lockstat.txt
> - - info on collecting statistics on locks (and contention).
> -mutex-design.txt
> - - info on the generic mutex subsystem.
> -rt-mutex-design.txt
> - - description of the RealTime mutex implementation design.
> -rt-mutex.txt
> - - desc. of RT-mutex subsystem with PI (Priority Inheritance) support.
> -spinlocks.txt
> - - info on using spinlocks to provide exclusive access in kernel.
> -ww-mutex-design.txt
> - - Intro to Mutex wait/would deadlock handling.s
> diff --git a/Documentation/m68k/00-INDEX b/Documentation/m68k/00-INDEX
> deleted file mode 100644
> index 2be8c6b..0000000
> --- a/Documentation/m68k/00-INDEX
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -00-INDEX
> - - this file
> -README.buddha
> - - Amiga Buddha and Catweasel IDE Driver
> -kernel-options.txt
> - - command line options for Linux/m68k
> -
> diff --git a/Documentation/mips/00-INDEX b/Documentation/mips/00-INDEX
> deleted file mode 100644
> index 8ae9cff..0000000
> --- a/Documentation/mips/00-INDEX
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -00-INDEX
> - - this file.
> -AU1xxx_IDE.README
> - - README for MIPS AU1XXX IDE driver.
> diff --git a/Documentation/mmc/00-INDEX b/Documentation/mmc/00-INDEX
> deleted file mode 100644
> index 4623bc0..0000000
> --- a/Documentation/mmc/00-INDEX
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -00-INDEX
> - - this file
> -mmc-dev-attrs.txt
> - - info on SD and MMC device attributes
> -mmc-dev-parts.txt
> - - info on SD and MMC device partitions
> -mmc-async-req.txt
> - - info on mmc asynchronous requests
> -mmc-tools.txt
> - - info on mmc-utils tools
> diff --git a/Documentation/netlabel/00-INDEX b/Documentation/netlabel/00-INDEX
> deleted file mode 100644
> index 837bf35..0000000
> --- a/Documentation/netlabel/00-INDEX
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -00-INDEX
> - - this file.
> -cipso_ipv4.txt
> - - documentation on the IPv4 CIPSO protocol engine.
> -draft-ietf-cipso-ipsecurity-01.txt
> - - IETF draft of the CIPSO protocol, dated 16 July 1992.
> -introduction.txt
> - - NetLabel introduction, READ THIS FIRST.
> -lsm_interface.txt
> - - documentation on the NetLabel kernel security module API.
> diff --git a/Documentation/netlabel/cipso_ipv4.txt b/Documentation/netlabel/cipso_ipv4.txt
> index 93dacb1..a607548 100644
> --- a/Documentation/netlabel/cipso_ipv4.txt
> +++ b/Documentation/netlabel/cipso_ipv4.txt
> @@ -6,11 +6,12 @@ May 17, 2006
>
> * Overview
>
> -The NetLabel CIPSO/IPv4 protocol engine is based on the IETF Commercial IP
> -Security Option (CIPSO) draft from July 16, 1992. A copy of this draft can be
> -found in this directory, consult '00-INDEX' for the filename. While the IETF
> -draft never made it to an RFC standard it has become a de-facto standard for
> -labeled networking and is used in many trusted operating systems.
> +The NetLabel CIPSO/IPv4 protocol engine is based on the IETF Commercial
> +IP Security Option (CIPSO) draft from July 16, 1992. A copy of this
> +draft can be found in this directory
> +(draft-ietf-cipso-ipsecurity-01.txt). While the IETF draft never made
> +it to an RFC standard it has become a de-facto standard for labeled
> +networking and is used in many trusted operating systems.
>
> * Outbound Packet Processing
>
> diff --git a/Documentation/netlabel/introduction.txt b/Documentation/netlabel/introduction.txt
> index 5ecd8d1..3caf77b 100644
> --- a/Documentation/netlabel/introduction.txt
> +++ b/Documentation/netlabel/introduction.txt
> @@ -22,7 +22,7 @@ refrain from calling the protocol engines directly, instead they should use
> the NetLabel kernel security module API described below.
>
> Detailed information about each NetLabel protocol engine can be found in this
> -directory, consult '00-INDEX' for filenames.
> +directory.
>
> * Communication Layer
>
> diff --git a/Documentation/networking/00-INDEX b/Documentation/networking/00-INDEX
> deleted file mode 100644
> index 02a323c..0000000
> --- a/Documentation/networking/00-INDEX
> +++ /dev/null
> @@ -1,234 +0,0 @@
> -00-INDEX
> - - this file
> -3c509.txt
> - - information on the 3Com Etherlink III Series Ethernet cards.
> -6pack.txt
> - - info on the 6pack protocol, an alternative to KISS for AX.25
> -LICENSE.qla3xxx
> - - GPLv2 for QLogic Linux Networking HBA Driver
> -LICENSE.qlge
> - - GPLv2 for QLogic Linux qlge NIC Driver
> -LICENSE.qlcnic
> - - GPLv2 for QLogic Linux qlcnic NIC Driver
> -PLIP.txt
> - - PLIP: The Parallel Line Internet Protocol device driver
> -README.ipw2100
> - - README for the Intel PRO/Wireless 2100 driver.
> -README.ipw2200
> - - README for the Intel PRO/Wireless 2915ABG and 2200BG driver.
> -README.sb1000
> - - info on General Instrument/NextLevel SURFboard1000 cable modem.
> -altera_tse.txt
> - - Altera Triple-Speed Ethernet controller.
> -arcnet-hardware.txt
> - - tons of info on ARCnet, hubs, jumper settings for ARCnet cards, etc.
> -arcnet.txt
> - - info on the using the ARCnet driver itself.
> -atm.txt
> - - info on where to get ATM programs and support for Linux.
> -ax25.txt
> - - info on using AX.25 and NET/ROM code for Linux
> -baycom.txt
> - - info on the driver for Baycom style amateur radio modems
> -bonding.txt
> - - Linux Ethernet Bonding Driver HOWTO: link aggregation in Linux.
> -bridge.txt
> - - where to get user space programs for ethernet bridging with Linux.
> -cdc_mbim.txt
> - - 3G/LTE USB modem (Mobile Broadband Interface Model)
> -checksum-offloads.txt
> - - Explanation of checksum offloads; LCO, RCO
> -cops.txt
> - - info on the COPS LocalTalk Linux driver
> -cs89x0.txt
> - - the Crystal LAN (CS8900/20-based) Ethernet ISA adapter driver
> -cxacru.txt
> - - Conexant AccessRunner USB ADSL Modem
> -cxacru-cf.py
> - - Conexant AccessRunner USB ADSL Modem configuration file parser
> -cxgb.txt
> - - Release Notes for the Chelsio N210 Linux device driver.
> -dccp.txt
> - - the Datagram Congestion Control Protocol (DCCP) (RFC 4340..42).
> -dctcp.txt
> - - DataCenter TCP congestion control
> -de4x5.txt
> - - the Digital EtherWORKS DE4?? and DE5?? PCI Ethernet driver
> -decnet.txt
> - - info on using the DECnet networking layer in Linux.
> -dl2k.txt
> - - README for D-Link DL2000-based Gigabit Ethernet Adapters (dl2k.ko).
> -dm9000.txt
> - - README for the Simtec DM9000 Network driver.
> -dmfe.txt
> - - info on the Davicom DM9102(A)/DM9132/DM9801 fast ethernet driver.
> -dns_resolver.txt
> - - The DNS resolver module allows kernel servies to make DNS queries.
> -driver.txt
> - - Softnet driver issues.
> -ena.txt
> - - info on Amazon's Elastic Network Adapter (ENA)
> -e100.txt
> - - info on Intel's EtherExpress PRO/100 line of 10/100 boards
> -e1000.txt
> - - info on Intel's E1000 line of gigabit ethernet boards
> -e1000e.txt
> - - README for the Intel Gigabit Ethernet Driver (e1000e).
> -eql.txt
> - - serial IP load balancing
> -fib_trie.txt
> - - Level Compressed Trie (LC-trie) notes: a structure for routing.
> -filter.txt
> - - Linux Socket Filtering
> -fore200e.txt
> - - FORE Systems PCA-200E/SBA-200E ATM NIC driver info.
> -framerelay.txt
> - - info on using Frame Relay/Data Link Connection Identifier (DLCI).
> -gen_stats.txt
> - - Generic networking statistics for netlink users.
> -generic-hdlc.txt
> - - The generic High Level Data Link Control (HDLC) layer.
> -generic_netlink.txt
> - - info on Generic Netlink
> -gianfar.txt
> - - Gianfar Ethernet Driver.
> -i40e.txt
> - - README for the Intel Ethernet Controller XL710 Driver (i40e).
> -i40evf.txt
> - - Short note on the Driver for the Intel(R) XL710 X710 Virtual Function
> -ieee802154.txt
> - - Linux IEEE 802.15.4 implementation, API and drivers
> -igb.txt
> - - README for the Intel Gigabit Ethernet Driver (igb).
> -igbvf.txt
> - - README for the Intel Gigabit Ethernet Driver (igbvf).
> -ip-sysctl.txt
> - - /proc/sys/net/ipv4/* variables
> -ip_dynaddr.txt
> - - IP dynamic address hack e.g. for auto-dialup links
> -ipddp.txt
> - - AppleTalk-IP Decapsulation and AppleTalk-IP Encapsulation
> -iphase.txt
> - - Interphase PCI ATM (i)Chip IA Linux driver info.
> -ipsec.txt
> - - Note on not compressing IPSec payload and resulting failed policy check.
> -ipv6.txt
> - - Options to the ipv6 kernel module.
> -ipvs-sysctl.txt
> - - Per-inode explanation of the /proc/sys/net/ipv4/vs interface.
> -irda.txt
> - - where to get IrDA (infrared) utilities and info for Linux.
> -ixgb.txt
> - - README for the Intel 10 Gigabit Ethernet Driver (ixgb).
> -ixgbe.txt
> - - README for the Intel 10 Gigabit Ethernet Driver (ixgbe).
> -ixgbevf.txt
> - - README for the Intel Virtual Function (VF) Driver (ixgbevf).
> -l2tp.txt
> - - User guide to the L2TP tunnel protocol.
> -lapb-module.txt
> - - programming information of the LAPB module.
> -ltpc.txt
> - - the Apple or Farallon LocalTalk PC card driver
> -mac80211-auth-assoc-deauth.txt
> - - authentication and association / deauth-disassoc with max80211
> -mac80211-injection.txt
> - - HOWTO use packet injection with mac80211
> -multiqueue.txt
> - - HOWTO for multiqueue network device support.
> -netconsole.txt
> - - The network console module netconsole.ko: configuration and notes.
> -netdev-features.txt
> - - Network interface features API description.
> -netdevices.txt
> - - info on network device driver functions exported to the kernel.
> -netif-msg.txt
> - - Design of the network interface message level setting (NETIF_MSG_*).
> -netlink_mmap.txt
> - - memory mapped I/O with netlink
> -nf_conntrack-sysctl.txt
> - - list of netfilter-sysctl knobs.
> -nfc.txt
> - - The Linux Near Field Communication (NFS) subsystem.
> -openvswitch.txt
> - - Open vSwitch developer documentation.
> -operstates.txt
> - - Overview of network interface operational states.
> -packet_mmap.txt
> - - User guide to memory mapped packet socket rings (PACKET_[RT]X_RING).
> -phonet.txt
> - - The Phonet packet protocol used in Nokia cellular modems.
> -phy.txt
> - - The PHY abstraction layer.
> -pktgen.txt
> - - User guide to the kernel packet generator (pktgen.ko).
> -policy-routing.txt
> - - IP policy-based routing
> -ppp_generic.txt
> - - Information about the generic PPP driver.
> -proc_net_tcp.txt
> - - Per inode overview of the /proc/net/tcp and /proc/net/tcp6 interfaces.
> -radiotap-headers.txt
> - - Background on radiotap headers.
> -ray_cs.txt
> - - Raylink Wireless LAN card driver info.
> -rds.txt
> - - Background on the reliable, ordered datagram delivery method RDS.
> -regulatory.txt
> - - Overview of the Linux wireless regulatory infrastructure.
> -rxrpc.txt
> - - Guide to the RxRPC protocol.
> -s2io.txt
> - - Release notes for Neterion Xframe I/II 10GbE driver.
> -scaling.txt
> - - Explanation of network scaling techniques: RSS, RPS, RFS, aRFS, XPS.
> -sctp.txt
> - - Notes on the Linux kernel implementation of the SCTP protocol.
> -secid.txt
> - - Explanation of the secid member in flow structures.
> -skfp.txt
> - - SysKonnect FDDI (SK-5xxx, Compaq Netelligent) driver info.
> -smc9.txt
> - - the driver for SMC's 9000 series of Ethernet cards
> -spider_net.txt
> - - README for the Spidernet Driver (as found in PS3 / Cell BE).
> -stmmac.txt
> - - README for the STMicro Synopsys Ethernet driver.
> -tc-actions-env-rules.txt
> - - rules for traffic control (tc) actions.
> -timestamping.txt
> - - overview of network packet timestamping variants.
> -tcp.txt
> - - short blurb on how TCP output takes place.
> -tcp-thin.txt
> - - kernel tuning options for low rate 'thin' TCP streams.
> -team.txt
> - - pointer to information for ethernet teaming devices.
> -tlan.txt
> - - ThunderLAN (Compaq Netelligent 10/100, Olicom OC-2xxx) driver info.
> -tproxy.txt
> - - Transparent proxy support user guide.
> -tuntap.txt
> - - TUN/TAP device driver, allowing user space Rx/Tx of packets.
> -udplite.txt
> - - UDP-Lite protocol (RFC 3828) introduction.
> -vortex.txt
> - - info on using 3Com Vortex (3c590, 3c592, 3c595, 3c597) Ethernet cards.
> -vxge.txt
> - - README for the Neterion X3100 PCIe Server Adapter.
> -vxlan.txt
> - - Virtual extensible LAN overview
> -x25.txt
> - - general info on X.25 development.
> -x25-iface.txt
> - - description of the X.25 Packet Layer to LAPB device interface.
> -xfrm_device.txt
> - - description of XFRM offload API
> -xfrm_proc.txt
> - - description of the statistics package for XFRM.
> -xfrm_sync.txt
> - - sync patches for XFRM enable migration of an SA between hosts.
> -xfrm_sysctl.txt
> - - description of the XFRM configuration options.
> -z8530drv.txt
> - - info about Linux driver for Z8530 based HDLC cards for AX.25
> diff --git a/Documentation/parisc/00-INDEX b/Documentation/parisc/00-INDEX
> deleted file mode 100644
> index cbd0609..0000000
> --- a/Documentation/parisc/00-INDEX
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -00-INDEX
> - - this file.
> -debugging
> - - some debugging hints for real-mode code
> -registers
> - - current/planned usage of registers
> diff --git a/Documentation/power/00-INDEX b/Documentation/power/00-INDEX
> deleted file mode 100644
> index 7f3c2de..0000000
> --- a/Documentation/power/00-INDEX
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -00-INDEX
> - - This file
> -apm-acpi.txt
> - - basic info about the APM and ACPI support.
> -basic-pm-debugging.txt
> - - Debugging suspend and resume
> -charger-manager.txt
> - - Battery charger management.
> -admin-guide/devices.rst
> - - How drivers interact with system-wide power management
> -drivers-testing.txt
> - - Testing suspend and resume support in device drivers
> -freezing-of-tasks.txt
> - - How processes and controlled during suspend
> -interface.txt
> - - Power management user interface in /sys/power
> -opp.txt
> - - Operating Performance Point library
> -pci.txt
> - - How the PCI Subsystem Does Power Management
> -pm_qos_interface.txt
> - - info on Linux PM Quality of Service interface
> -power_supply_class.txt
> - - Tells userspace about battery, UPS, AC or DC power supply properties
> -runtime_pm.txt
> - - Power management framework for I/O devices.
> -s2ram.txt
> - - How to get suspend to ram working (and debug it when it isn't)
> -states.txt
> - - System power management states
> -suspend-and-cpuhotplug.txt
> - - Explains the interaction between Suspend-to-RAM (S3) and CPU hotplug
> -swsusp-and-swap-files.txt
> - - Using swap files with software suspend (to disk)
> -swsusp-dmcrypt.txt
> - - How to use dm-crypt and software suspend (to disk) together
> -swsusp.txt
> - - Goals, implementation, and usage of software suspend (ACPI S3)
> -tricks.txt
> - - How to trick software suspend (to disk) into working when it isn't
> -userland-swsusp.txt
> - - Experimental implementation of software suspend in userspace
> -video.txt
> - - Video issues during resume from suspend
> diff --git a/Documentation/powerpc/00-INDEX b/Documentation/powerpc/00-INDEX
> deleted file mode 100644
> index 9dc845c..0000000
> --- a/Documentation/powerpc/00-INDEX
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -Index of files in Documentation/powerpc. If you think something about
> -Linux/PPC needs an entry here, needs correction or you've written one
> -please mail me.
> - Cort Dougan (cort@fsmlabs.com)
> -
> -00-INDEX
> - - this file
> -bootwrapper.txt
> - - Information on how the powerpc kernel is wrapped for boot on various
> - different platforms.
> -cpu_features.txt
> - - info on how we support a variety of CPUs with minimal compile-time
> - options.
> -cxl.txt
> - - Overview of the CXL driver.
> -eeh-pci-error-recovery.txt
> - - info on PCI Bus EEH Error Recovery
> -firmware-assisted-dump.txt
> - - Documentation on the firmware assisted dump mechanism "fadump".
> -hvcs.txt
> - - IBM "Hypervisor Virtual Console Server" Installation Guide
> -mpc52xx.txt
> - - Linux 2.6.x on MPC52xx family
> -pmu-ebb.txt
> - - Description of the API for using the PMU with Event Based Branches.
> -qe_firmware.txt
> - - describes the layout of firmware binaries for the Freescale QUICC
> - Engine and the code that parses and uploads the microcode therein.
> -ptrace.txt
> - - Information on the ptrace interfaces for hardware debug registers.
> -transactional_memory.txt
> - - Overview of the Power8 transactional memory support.
> -dscr.txt
> - - Overview DSCR (Data Stream Control Register) support.
> diff --git a/Documentation/s390/00-INDEX b/Documentation/s390/00-INDEX
> deleted file mode 100644
> index 317f037..0000000
> --- a/Documentation/s390/00-INDEX
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -00-INDEX
> - - this file.
> -3270.ChangeLog
> - - ChangeLog for the UTS Global 3270-support patch (outdated).
> -3270.txt
> - - how to use the IBM 3270 display system support.
> -cds.txt
> - - s390 common device support (common I/O layer).
> -CommonIO
> - - common I/O layer command line parameters, procfs and debugfs entries
> -config3270.sh
> - - example configuration for 3270 devices.
> -DASD
> - - information on the DASD disk device driver.
> -Debugging390.txt
> - - hints for debugging on s390 systems.
> -driver-model.txt
> - - information on s390 devices and the driver model.
> -monreader.txt
> - - information on accessing the z/VM monitor stream from Linux.
> -qeth.txt
> - - HiperSockets Bridge Port Support.
> -s390dbf.txt
> - - information on using the s390 debug feature.
> -vfio-ccw.txt
> - information on the vfio-ccw I/O subchannel driver.
> -zfcpdump.txt
> - - information on the s390 SCSI dump tool.
> diff --git a/Documentation/scheduler/00-INDEX b/Documentation/scheduler/00-INDEX
> deleted file mode 100644
> index eccf7ad..0000000
> --- a/Documentation/scheduler/00-INDEX
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -00-INDEX
> - - this file.
> -sched-arch.txt
> - - CPU Scheduler implementation hints for architecture specific code.
> -sched-bwc.txt
> - - CFS bandwidth control overview.
> -sched-design-CFS.txt
> - - goals, design and implementation of the Completely Fair Scheduler.
> -sched-domains.txt
> - - information on scheduling domains.
> -sched-nice-design.txt
> - - How and why the scheduler's nice levels are implemented.
> -sched-rt-group.txt
> - - real-time group scheduling.
> -sched-deadline.txt
> - - deadline scheduling.
> -sched-stats.txt
> - - information on schedstats (Linux Scheduler Statistics).
> diff --git a/Documentation/scsi/00-INDEX b/Documentation/scsi/00-INDEX
> deleted file mode 100644
> index bb4a76f..0000000
> --- a/Documentation/scsi/00-INDEX
> +++ /dev/null
> @@ -1,108 +0,0 @@
> -00-INDEX
> - - this file
> -53c700.txt
> - - info on driver for 53c700 based adapters
> -BusLogic.txt
> - - info on driver for adapters with BusLogic chips
> -ChangeLog.1992-1997
> - - Changes to scsi files, if not listed elsewhere
> -ChangeLog.arcmsr
> - - Changes to driver for ARECA's SATA RAID controller cards
> -ChangeLog.ips
> - - IBM ServeRAID driver Changelog
> -ChangeLog.lpfc
> - - Changes to lpfc driver
> -ChangeLog.megaraid
> - - Changes to LSI megaraid controller.
> -ChangeLog.megaraid_sas
> - - Changes to serial attached scsi version of LSI megaraid controller.
> -ChangeLog.ncr53c8xx
> - - Changes to ncr53c8xx driver
> -ChangeLog.sym53c8xx
> - - Changes to sym53c8xx driver
> -ChangeLog.sym53c8xx_2
> - - Changes to second generation of sym53c8xx driver
> -FlashPoint.txt
> - - info on driver for BusLogic FlashPoint adapters
> -LICENSE.FlashPoint
> - - Licence of the Flashpoint driver
> -LICENSE.qla2xxx
> - - License for QLogic Linux Fibre Channel HBA Driver firmware.
> -LICENSE.qla4xxx
> - - License for QLogic Linux iSCSI HBA Driver.
> -Mylex.txt
> - - info on driver for Mylex adapters
> -NinjaSCSI.txt
> - - info on WorkBiT NinjaSCSI-32/32Bi driver
> -aacraid.txt
> - - Driver supporting Adaptec RAID controllers
> -advansys.txt
> - - List of Advansys Host Adapters
> -aha152x.txt
> - - info on driver for Adaptec AHA152x based adapters
> -aic79xx.txt
> - - Adaptec Ultra320 SCSI host adapters
> -aic7xxx.txt
> - - info on driver for Adaptec controllers
> -arcmsr_spec.txt
> - - ARECA FIRMWARE SPEC (for IOP331 adapter)
> -bfa.txt
> - - Brocade FC/FCOE adapter driver.
> -bnx2fc.txt
> - - FCoE hardware offload for Broadcom network interfaces.
> -cxgb3i.txt
> - - Chelsio iSCSI Linux Driver
> -dc395x.txt
> - - README file for the dc395x SCSI driver
> -dpti.txt
> - - info on driver for DPT SmartRAID and Adaptec I2O RAID based adapters
> -dtc3x80.txt
> - - info on driver for DTC 2x80 based adapters
> -g_NCR5380.txt
> - - info on driver for NCR5380 and NCR53c400 based adapters
> -hpsa.txt
> - - HP Smart Array Controller SCSI driver.
> -hptiop.txt
> - - HIGHPOINT ROCKETRAID 3xxx RAID DRIVER
> -libsas.txt
> - - Serial Attached SCSI management layer.
> -link_power_management_policy.txt
> - - Link power management options.
> -lpfc.txt
> - - LPFC driver release notes
> -megaraid.txt
> - - Common Management Module, shared code handling ioctls for LSI drivers
> -ncr53c8xx.txt
> - - info on driver for NCR53c8xx based adapters
> -osd.txt
> - Object-Based Storage Device, command set introduction.
> -osst.txt
> - - info on driver for OnStream SC-x0 SCSI tape
> -ppa.txt
> - - info on driver for IOmega zip drive
> -qlogicfas.txt
> - - info on driver for QLogic FASxxx based adapters
> -scsi-changer.txt
> - - README for the SCSI media changer driver
> -scsi-generic.txt
> - - info on the sg driver for generic (non-disk/CD/tape) SCSI devices.
> -scsi-parameters.txt
> - - List of SCSI-parameters to pass to the kernel at module load-time.
> -scsi.txt
> - - short blurb on using SCSI support as a module.
> -scsi_mid_low_api.txt
> - - info on API between SCSI layer and low level drivers
> -scsi_eh.txt
> - - info on SCSI midlayer error handling infrastructure
> -scsi_fc_transport.txt
> - - SCSI Fiber Channel Tansport
> -st.txt
> - - info on scsi tape driver
> -sym53c500_cs.txt
> - - info on PCMCIA driver for Symbios Logic 53c500 based adapters
> -sym53c8xx_2.txt
> - - info on second generation driver for sym53c8xx based adapters
> -tmscsim.txt
> - - info on driver for AM53c974 based adapters
> -ufs.txt
> - - info on Universal Flash Storage(UFS) and UFS host controller driver.
> diff --git a/Documentation/serial/00-INDEX b/Documentation/serial/00-INDEX
> deleted file mode 100644
> index 8021a9f..0000000
> --- a/Documentation/serial/00-INDEX
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -00-INDEX
> - - this file.
> -README.cycladesZ
> - - info on Cyclades-Z firmware loading.
> -driver
> - - intro to the low level serial driver.
> -moxa-smartio
> - - file with info on installing/using Moxa multiport serial driver.
> -n_gsm.txt
> - - GSM 0710 tty multiplexer howto.
> -rocket.txt
> - - info on the Comtrol RocketPort multiport serial driver.
> -serial-rs485.txt
> - - info about RS485 structures and support in the kernel.
> -tty.txt
> - - guide to the locking policies of the tty layer.
> diff --git a/Documentation/spi/00-INDEX b/Documentation/spi/00-INDEX
> deleted file mode 100644
> index 8e4bb17..0000000
> --- a/Documentation/spi/00-INDEX
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -00-INDEX
> - - this file.
> -butterfly
> - - AVR Butterfly SPI driver overview and pin configuration.
> -ep93xx_spi
> - - Basic EP93xx SPI driver configuration.
> -pxa2xx
> - - PXA2xx SPI master controller build by spi_message fifo wq
> -spidev
> - - Intro to the userspace API for spi devices
> -spi-lm70llp
> - - Connecting an LM70-LLP sensor to the kernel via the SPI subsys.
> -spi-sc18is602
> - - NXP SC18IS602/603 I2C-bus to SPI bridge
> -spi-summary
> - - (Linux) SPI overview. If unsure about SPI or SPI in Linux, start here.
> diff --git a/Documentation/sysctl/00-INDEX b/Documentation/sysctl/00-INDEX
> deleted file mode 100644
> index 8cf5d49..0000000
> --- a/Documentation/sysctl/00-INDEX
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -00-INDEX
> - - this file.
> -README
> - - general information about /proc/sys/ sysctl files.
> -abi.txt
> - - documentation for /proc/sys/abi/*.
> -fs.txt
> - - documentation for /proc/sys/fs/*.
> -kernel.txt
> - - documentation for /proc/sys/kernel/*.
> -net.txt
> - - documentation for /proc/sys/net/*.
> -sunrpc.txt
> - - documentation for /proc/sys/sunrpc/*.
> -vm.txt
> - - documentation for /proc/sys/vm/*.
> diff --git a/Documentation/timers/00-INDEX b/Documentation/timers/00-INDEX
> deleted file mode 100644
> index 3be05fe..0000000
> --- a/Documentation/timers/00-INDEX
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -00-INDEX
> - - this file
> -highres.txt
> - - High resolution timers and dynamic ticks design notes
> -hpet.txt
> - - High Precision Event Timer Driver for Linux
> -hrtimers.txt
> - - subsystem for high-resolution kernel timers
> -NO_HZ.txt
> - - Summary of the different methods for the scheduler clock-interrupts management.
> -timekeeping.txt
> - - Clock sources, clock events, sched_clock() and delay timer notes
> -timers-howto.txt
> - - how to insert delays in the kernel the right (tm) way.
> -timer_stats.txt
> - - timer usage statistics
> diff --git a/Documentation/virtual/00-INDEX b/Documentation/virtual/00-INDEX
> deleted file mode 100644
> index af0d239..0000000
> --- a/Documentation/virtual/00-INDEX
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -Virtualization support in the Linux kernel.
> -
> -00-INDEX
> - - this file.
> -
> -paravirt_ops.txt
> - - Describes the Linux kernel pv_ops to support different hypervisors
> -kvm/
> - - Kernel Virtual Machine. See also http://linux-kvm.org
> -uml/
> - - User Mode Linux, builds/runs Linux kernel as a userspace program.
> diff --git a/Documentation/virtual/kvm/00-INDEX b/Documentation/virtual/kvm/00-INDEX
> deleted file mode 100644
> index 3492458..0000000
> --- a/Documentation/virtual/kvm/00-INDEX
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -00-INDEX
> - - this file.
> -amd-memory-encryption.rst
> - - notes on AMD Secure Encrypted Virtualization feature and SEV firmware
> - command description
> -api.txt
> - - KVM userspace API.
> -arm
> - - internal ABI between the kernel and HYP (for arm/arm64)
> -cpuid.txt
> - - KVM-specific cpuid leaves (x86).
> -devices/
> - - KVM_CAP_DEVICE_CTRL userspace API.
> -halt-polling.txt
> - - notes on halt-polling
> -hypercalls.txt
> - - KVM hypercalls.
> -locking.txt
> - - notes on KVM locks.
> -mmu.txt
> - - the x86 kvm shadow mmu.
> -msr.txt
> - - KVM-specific MSRs (x86).
> -nested-vmx.txt
> - - notes on nested virtualization for Intel x86 processors.
> -ppc-pv.txt
> - - the paravirtualization interface on PowerPC.
> -review-checklist.txt
> - - review checklist for KVM patches.
> -s390-diag.txt
> - - Diagnose hypercall description (for IBM S/390)
> -timekeeping.txt
> - - timekeeping virtualization for x86-based architectures.
> -vcpu-requests.rst
> - - internal VCPU request API
> diff --git a/Documentation/vm/00-INDEX b/Documentation/vm/00-INDEX
> deleted file mode 100644
> index f4a4f3e..0000000
> --- a/Documentation/vm/00-INDEX
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -00-INDEX
> - - this file.
> -active_mm.rst
> - - An explanation from Linus about tsk->active_mm vs tsk->mm.
> -balance.rst
> - - various information on memory balancing.
> -cleancache.rst
> - - Intro to cleancache and page-granularity victim cache.
> -frontswap.rst
> - - Outline frontswap, part of the transcendent memory frontend.
> -highmem.rst
> - - Outline of highmem and common issues.
> -hmm.rst
> - - Documentation of heterogeneous memory management
> -hugetlbfs_reserv.rst
> - - A brief overview of hugetlbfs reservation design/implementation.
> -hwpoison.rst
> - - explains what hwpoison is
> -ksm.rst
> - - how to use the Kernel Samepage Merging feature.
> -mmu_notifier.rst
> - - a note about clearing pte/pmd and mmu notifications
> -numa.rst
> - - information about NUMA specific code in the Linux vm.
> -overcommit-accounting.rst
> - - description of the Linux kernels overcommit handling modes.
> -page_frags.rst
> - - description of page fragments allocator
> -page_migration.rst
> - - description of page migration in NUMA systems.
> -page_owner.rst
> - - tracking about who allocated each page
> -remap_file_pages.rst
> - - a note about remap_file_pages() system call
> -slub.rst
> - - a short users guide for SLUB.
> -split_page_table_lock.rst
> - - Separate per-table lock to improve scalability of the old page_table_lock.
> -swap_numa.rst
> - - automatic binding of swap device to numa node
> -transhuge.rst
> - - Transparent Hugepage Support, alternative way of using hugepages.
> -unevictable-lru.rst
> - - Unevictable LRU infrastructure
> -z3fold.txt
> - - outline of z3fold allocator for storing compressed pages
> -zsmalloc.rst
> - - outline of zsmalloc allocator for storing compressed pages
> -zswap.rst
> - - Intro to compressed cache for swap pages
> diff --git a/Documentation/w1/00-INDEX b/Documentation/w1/00-INDEX
> deleted file mode 100644
> index cb49802..0000000
> --- a/Documentation/w1/00-INDEX
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -00-INDEX
> - - This file
> -slaves/
> - - Drivers that provide support for specific family codes.
> -masters/
> - - Individual chips providing 1-wire busses.
> -w1.generic
> - - The 1-wire (w1) bus
> -w1.netlink
> - - Userspace communication protocol over connector [1].
> diff --git a/Documentation/w1/masters/00-INDEX b/Documentation/w1/masters/00-INDEX
> deleted file mode 100644
> index 8330cf9..0000000
> --- a/Documentation/w1/masters/00-INDEX
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -00-INDEX
> - - This file
> -ds2482
> - - The Maxim/Dallas Semiconductor DS2482 provides 1-wire busses.
> -ds2490
> - - The Maxim/Dallas Semiconductor DS2490 builds USB <-> W1 bridges.
> -mxc-w1
> - - W1 master controller driver found on Freescale MX2/MX3 SoCs
> -omap-hdq
> - - HDQ/1-wire module of TI OMAP 2430/3430.
> -w1-gpio
> - - GPIO 1-wire bus master driver.
> diff --git a/Documentation/w1/slaves/00-INDEX b/Documentation/w1/slaves/00-INDEX
> deleted file mode 100644
> index 68946f8..0000000
> --- a/Documentation/w1/slaves/00-INDEX
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -00-INDEX
> - - This file
> -w1_therm
> - - The Maxim/Dallas Semiconductor ds18*20 temperature sensor.
> -w1_ds2413
> - - The Maxim/Dallas Semiconductor ds2413 dual channel addressable switch.
> -w1_ds2423
> - - The Maxim/Dallas Semiconductor ds2423 counter device.
> -w1_ds2438
> - - The Maxim/Dallas Semiconductor ds2438 smart battery monitor.
> -w1_ds28e04
> - - The Maxim/Dallas Semiconductor ds28e04 eeprom.
> -w1_ds28e17
> - - The Maxim/Dallas Semiconductor ds28e17 1-Wire-to-I2C Master Bridge.
> diff --git a/Documentation/x86/00-INDEX b/Documentation/x86/00-INDEX
> deleted file mode 100644
> index 3bb2ee3..0000000
> --- a/Documentation/x86/00-INDEX
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -00-INDEX
> - - this file
> -boot.txt
> - - List of boot protocol versions
> -earlyprintk.txt
> - - Using earlyprintk with a USB2 debug port key.
> -entry_64.txt
> - - Describe (some of the) kernel entry points for x86.
> -exception-tables.txt
> - - why and how Linux kernel uses exception tables on x86
> -microcode.txt
> - - How to load microcode from an initrd-CPIO archive early to fix CPU issues.
> -mtrr.txt
> - - how to use x86 Memory Type Range Registers to increase performance
> -pat.txt
> - - Page Attribute Table intro and API
> -usb-legacy-support.txt
> - - how to fix/avoid quirks when using emulated PS/2 mouse/keyboard.
> -zero-page.txt
> - - layout of the first page of memory.
> diff --git a/Documentation/x86/x86_64/00-INDEX b/Documentation/x86/x86_64/00-INDEX
> deleted file mode 100644
> index 92fc20a..0000000
> --- a/Documentation/x86/x86_64/00-INDEX
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -00-INDEX
> - - This file
> -boot-options.txt
> - - AMD64-specific boot options.
> -cpu-hotplug-spec
> - - Firmware support for CPU hotplug under Linux/x86-64
> -fake-numa-for-cpusets
> - - Using numa=fake and CPUSets for Resource Management
> -kernel-stacks
> - - Context-specific per-processor interrupt stacks.
> -machinecheck
> - - Configurable sysfs parameters for the x86-64 machine check code.
> -mm.txt
> - - Memory layout of x86-64 (4 level page tables, 46 bits physical).
> -uefi.txt
> - - Booting Linux via Unified Extensible Firmware Interface.
> diff --git a/README b/README
> index 2c927cc..669ac7c 100644
> --- a/README
> +++ b/README
> @@ -12,7 +12,6 @@ In order to build the documentation, use ``make htmldocs`` or
>
> There are various text files in the Documentation/ subdirectory,
> several of them using the Restructured Text markup notation.
> -See Documentation/00-INDEX for a list of what is contained in each file.
>
> Please read the Documentation/process/changes.rst file, as it contains the
> requirements for building and running the kernel, and information about
> diff --git a/scripts/check_00index.sh b/scripts/check_00index.sh
> deleted file mode 100755
> index aa47f592..0000000
> --- a/scripts/check_00index.sh
> +++ /dev/null
> @@ -1,67 +0,0 @@
> -#!/bin/bash
> -# SPDX-License-Identifier: GPL-2.0
> -
> -cd Documentation/
> -
> -# Check entries that should be removed
> -
> -obsolete=""
> -for i in $(tail -n +12 00-INDEX |grep -E '^[a-zA-Z0-9]+'); do
> - if [ ! -e $i ]; then
> - obsolete="$obsolete $i"
> - fi
> -done
> -
> -# Check directory entries that should be added
> -search=""
> -dir=""
> -for i in $(find . -maxdepth 1 -type d); do
> - if [ "$i" != "." ]; then
> - new=$(echo $i|perl -ne 's,./(.*),$1/,; print $_')
> - search="$search $new"
> - fi
> -done
> -
> -for i in $search; do
> - if [ "$(grep -P "^$i" 00-INDEX)" == "" ]; then
> - dir="$dir $i"
> - fi
> -done
> -
> -# Check file entries that should be added
> -search=""
> -file=""
> -for i in $(find . -maxdepth 1 -type f); do
> - if [ "$i" != "./.gitignore" ]; then
> - new=$(echo $i|perl -ne 's,./(.*),$1,; print $_')
> - search="$search $new"
> - fi
> -done
> -
> -for i in $search; do
> - if [ "$(grep -P "^$i\$" 00-INDEX)" == "" ]; then
> - file="$file $i"
> - fi
> -done
> -
> -# Output its findings
> -
> -echo -e "Documentation/00-INDEX check results:\n"
> -
> -if [ "$obsolete" != "" ]; then
> - echo -e "- Should remove those entries:\n\t$obsolete\n"
> -else
> - echo -e "- No obsolete entries\n"
> -fi
> -
> -if [ "$dir" != "" ]; then
> - echo -e "- Should document those directories:\n\t$dir\n"
> -else
> - echo -e "- No new directories to add\n"
> -fi
> -
> -if [ "$file" != "" ]; then
> - echo -e "- Should document those files:\n\t$file"
> -else
> - echo "- No new files to add"
> -fi
> --
> 2.7.4
>
--
Sincerely yours,
Mike.
^ permalink raw reply
* Re: [PATCH net-next v2 1/7] net: phy: mscc: factorize code for LEDs mode
From: Quentin Schulz @ 2018-09-04 17:56 UTC (permalink / raw)
To: David Miller
Cc: robh+dt, mark.rutland, andrew, f.fainelli, allan.nielsen, netdev,
devicetree, linux-kernel, thomas.petazzoni
In-Reply-To: <20180904.104827.447303663667237271.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
Hi David,
On Tue, Sep 04, 2018 at 10:48:27AM -0700, David Miller wrote:
> From: Quentin Schulz <quentin.schulz@bootlin.com>
> Date: Mon, 3 Sep 2018 10:48:47 +0200
>
> > LEDs modes are set the same way, except they are offset by 4 times the
> > index of the LED.
> >
> > Let's factorize all the code so that it's easier to add support for the
> > 4 LEDs of the VSC8584 PHY.
> >
> > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
>
> Entire series applied to net-next.
>
Thanks!
> Please provide a proper "0/N ..." cover letter next time.
>
Sure, will do.
Quentin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* Re: [PATCH v2 00/11] mscc: ocelot: add support for SerDes muxing configuration
From: Quentin Schulz @ 2018-09-04 18:00 UTC (permalink / raw)
To: Paul Burton
Cc: Alexandre Belloni, David Miller, andrew, ralf, jhogan, robh+dt,
mark.rutland, kishon, f.fainelli, allan.nielsen, linux-mips,
devicetree, linux-kernel, netdev, thomas.petazzoni
In-Reply-To: <20180904161028.nh5ejrtj22r5az5e@pburton-laptop>
[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]
Hi Paul,
On Tue, Sep 04, 2018 at 09:10:28AM -0700, Paul Burton wrote:
> Hi Alexandre, Quentin, all,
>
> On Tue, Sep 04, 2018 at 05:16:53PM +0200, Alexandre Belloni wrote:
> > On 03/09/2018 22:09:10-0700, David Miller wrote:
> > > From: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > > Date: Mon, 3 Sep 2018 15:45:22 +0200
> > >
> > > > On 03/09/2018 15:34:15+0200, Andrew Lunn wrote:
> > > >> > I suggest patches 1 and 8 go through MIPS tree, 2 to 5 and 11 go through
> > > >> > net while the others (6, 7, 9 and 10) go through the generic PHY subsystem.
> > > >>
> > > >> Hi Quentin
> > > >>
> > > >> Are you expecting merge conflicts? If not, it might be simpler to gets
> > > >> ACKs from each maintainer, and then merge it though one tree.
> > > >
> > > > There are some other DT changes for this cycle so those should probably
> > > > go through MIPS.
> > >
> > > No objection for this going through the MIPS tree, and from me:
> > >
> > > Acked-by: David S. Miller <davem@davemloft.net>
> >
> > What I meant was that 1/11 and 8/11 should go through MIPS because of
> > the potential conflicts. The other patches can go through net-next as
> > that will make more sense. Maybe Quentin can split the series in two,
> > one for MIPS and one for net if that makes it easier for you to apply.
>
> I'd be happy to take the .dts changes through the MIPS tree, though
> looking at them won't patch 1 break bisection?
>
> Since you remove the hsio reg entry it looks to me like
> mscc_ocelot_probe() will fail with -EINVAL (which comes from
> devm_ioremap_resource() with res=NULL) until patch 3.
>
That's correct.
> I'd feel more comfortable merging this piecemeal if it doesn't result in
> us breaking bisection for however long it takes for both the trees
> involved to be merged.
>
How do you want to proceed then?
Quentin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* [PATCH bpf-next] bpf/verifier: properly clear union members after a ctx read
From: Edward Cree @ 2018-09-04 14:19 UTC (permalink / raw)
To: daniel, ast; +Cc: netdev
In check_mem_access(), for the PTR_TO_CTX case, after check_ctx_access()
has supplied a reg_type, the other members of the register state are set
appropriately. Previously reg.range was set to 0, but as it is in a
union with reg.map_ptr, which is larger, upper bytes of the latter were
left in place. This then caused the memcmp() in regsafe() to fail,
preventing some branches from being pruned (and occasionally causing the
same program to take a varying number of processed insns on repeated
verifier runs).
Signed-off-by: Edward Cree <ecree@solarflare.com>
---
Possibly something might need adding to __mark_reg_unknown() as well to
clear map_ptr/range, I'm not sure (though doing so did not affect the
processed insn count on the cilium programs).
kernel/bpf/verifier.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index f4ff0c569e54..49e4ea66fdd3 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -1640,9 +1640,9 @@ static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regn
else
mark_reg_known_zero(env, regs,
value_regno);
- regs[value_regno].id = 0;
- regs[value_regno].off = 0;
- regs[value_regno].range = 0;
+ /* Clear id, off, and union(map_ptr, range) */
+ memset(regs + value_regno, 0,
+ offsetof(struct bpf_reg_state, var_off));
regs[value_regno].type = reg_type;
}
^ permalink raw reply related
* Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races
From: Jose Abreu @ 2018-09-04 14:34 UTC (permalink / raw)
To: Jerome Brunet, Jose Abreu, netdev
Cc: Martin Blumenstingl, David S. Miller, Joao Pinto,
Giuseppe Cavallaro, Alexandre Torgue
In-Reply-To: <9f08823c2329be25322dfc17cc229d1821174c4f.camel@baylibre.com>
Hi Jerome,
On 04-09-2018 13:27, Jerome Brunet wrote:
> On Tue, 2018-09-04 at 10:57 +0100, Jose Abreu wrote:
>> Hi Jerome,
>>
>> On 03-09-2018 17:22, Jerome Brunet wrote:
>>> Situation is even worse with this.
>>> I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt
>>> anymore. Looks like a the same kind of network breakdown we had previously
>>>
>> I was able to reproduce your problem and the attached fixup patch
>> fixed it up for me. Can you please try?
> I suppose this applies on top the initial patch, not the previous fixup
> (judging from the rejection) Could you details the baseline for each
> patch you send, its not easy to follow.
>
> BTW, there something weird (at least for me) with the patch you attach.
> git always refuse to apply them and even patch complains:
>
> git apply fixup2.patch
> error: patch failed: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1861
> error: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: patch does not apply
>
> patch -p1 < fixup2.patch
> (Stripping trailing CRs from patch; use --binary to disable.)
> patching file drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> Hunk #6 succeeded at 2252 (offset 1 line).
> patch unexpectedly ends in middle of line
> patch unexpectedly ends in middle of line
I just do "git diff <file> > out.patch". Maybe not the best thing
to do then.
>
> Anyway, with this second fixup, I'm back to square one:
> I can boot but iperf3 won't hold for long
>
>
> # iperf3 -c 10.1.2.124 -p 12345 -t 600
> Connecting to host 10.1.2.124, port 12345
> [ 4] local 10.1.4.59 port 38650 connected to 10.1.2.124 port 12345
> [ ID] Interval Transfer Bandwidth Retr Cwnd
> [ 4] 0.00-1.00 sec 80.8 MBytes 678 Mbits/sec 1 300 KBytes
> [ 4] 1.00-2.00 sec 81.1 MBytes 680 Mbits/sec 0 329 KBytes
> [ 4] 2.00-3.00 sec 80.7 MBytes 677 Mbits/sec 0 335 KBytes
> [ 4] 3.00-4.00 sec 81.7 MBytes 685 Mbits/sec 0 337 KBytes
> [ 4] 4.00-5.00 sec 81.0 MBytes 680 Mbits/sec 0 341 KBytes
> [ 4] 5.00-6.00 sec 81.0 MBytes 680 Mbits/sec 0 344 KBytes
> [ 4] 6.00-7.00 sec 80.7 MBytes 677 Mbits/sec 0 345 KBytes
> [ 4] 7.00-8.00 sec 81.5 MBytes 684 Mbits/sec 0 346 KBytes
> [ 4] 8.00-9.00 sec 81.2 MBytes 680 Mbits/sec 0 348 KBytes
> [ 4] 9.00-10.00 sec 5.59 MBytes 46.9 Mbits/sec 2 1.41 KBytes
> [ 4] 10.00-11.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes
> [ 4] 11.00-12.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes
> [ 4] 12.00-13.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes
> [ 4] 13.00-14.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes
Okay, so this is odd because I now have a similar setup as yours
and is working perfectly fine:
---
# dmesg | grep -i stmmac
stmmaceth f0008000.ethernet: PTP uses main clock
stmmaceth f0008000.ethernet: User ID: 0x10, Synopsys ID: 0x37
stmmaceth f0008000.ethernet: DWMAC1000
stmmaceth f0008000.ethernet: DMA HW capability register supported
stmmaceth f0008000.ethernet: RX Checksum Offload Engine supported
stmmaceth f0008000.ethernet: COE Type 2
stmmaceth f0008000.ethernet: TX Checksum insertion supported
stmmaceth f0008000.ethernet: Normal descriptors
stmmaceth f0008000.ethernet: Ring mode enabled
stmmaceth f0008000.ethernet: Enable RX Mitigation via HW Watchdog
Timer
libphy: stmmac: probed
stmmaceth f0008000.ethernet eth0: device MAC address
0e:67:f6:6c:59:c6
Micrel KSZ9031 Gigabit PHY stmmac-0:00: attached PHY driver
[Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:00, irq=POLL)
stmmaceth f0008000.ethernet eth0: No Safety Features support found
stmmaceth f0008000.ethernet eth0: PTP not supported by HW
stmmaceth f0008000.ethernet eth0: Link is Up - 1Gbps/Full - flow
control off
stmmaceth f0008000.ethernet eth0: Link is Down
stmmaceth f0008000.ethernet eth0: Link is Up - 1Gbps/Full - flow
control off
---
# iperf3 -c 192.168.0.3 -t 600
Connecting to host 192.168.0.3, port 5201
[ 4] local 192.168.0.1 port 46796 connected to 192.168.0.3 port 5201
[ ID] Interval Transfer Bandwidth Retr Cwnd
[ 4] 0.00-1.01 sec 101 MBytes 841 Mbits/sec 1 467
KBytes
[ 4] 1.01-2.00 sec 112 MBytes 945 Mbits/sec 0 475
KBytes
[ 4] 2.00-3.01 sec 114 MBytes 947 Mbits/sec 0 481
KBytes
[ 4] 3.01-4.00 sec 112 MBytes 945 Mbits/sec 0 486
KBytes
[ 4] 4.00-5.00 sec 113 MBytes 947 Mbits/sec 0 506
KBytes
[ 4] 5.00-6.01 sec 113 MBytes 947 Mbits/sec 0 520
KBytes
[ 4] 6.01-7.00 sec 112 MBytes 950 Mbits/sec 0 625
KBytes
[ 4] 7.00-8.01 sec 114 MBytes 948 Mbits/sec 0 625
KBytes
[ 4] 8.01-9.00 sec 112 MBytes 948 Mbits/sec 0 625
KBytes
[ 4] 9.00-10.00 sec 114 MBytes 955 Mbits/sec 0 998
KBytes
[ 4] 10.00-11.01 sec 114 MBytes 949 Mbits/sec 0 998
KBytes
[ 4] 11.01-12.00 sec 113 MBytes 949 Mbits/sec 0 998
KBytes
[ 4] 12.00-13.00 sec 114 MBytes 954 Mbits/sec 0 998
KBytes
[ 4] 13.00-14.00 sec 114 MBytes 950 Mbits/sec 0 998
KBytes
[ 4] 14.00-15.01 sec 114 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 15.01-16.00 sec 113 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 16.00-17.00 sec 114 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 17.00-18.01 sec 114 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 18.01-19.00 sec 113 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 19.00-20.00 sec 114 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 20.00-21.00 sec 112 MBytes 947 Mbits/sec 0 998
KBytes
[ And just keeps going on ]
---
Note that although the User ID is not the same (0x10 vs 0x11) the
callbacks and the sw flow is the same, there are no differences
regarding User ID in stmmac driver, only the Synopsys ID is used.
Maybe some feature is not enabled in your HW ?
Thanks and Best Regards,
Jose Miguel Abreu
>
>
>> Thanks and Best Regards,
>> Jose Miguel Abreu
>
^ permalink raw reply
* [PATCH net-next 0/3] nfp: improve the new rtsym helpers
From: Jakub Kicinski @ 2018-09-04 14:37 UTC (permalink / raw)
To: davem; +Cc: netdev, oss-drivers, Jakub Kicinski
Hi!
This set fixes a bug in ABS rtsym handling I added in net-next,
it expands the error checking and reporting on the rtsym accesses.
Jakub Kicinski (3):
nfp: fix readq on absolute RTsyms
nfp: prefix rtsym error messages with symbol name
nfp: validate rtsym accesses fall within the symbol
.../netronome/nfp/nfpcore/nfp_rtsym.c | 75 +++++++++++++++----
1 file changed, 60 insertions(+), 15 deletions(-)
--
2.17.1
^ permalink raw reply
* [PATCH net-next 1/3] nfp: fix readq on absolute RTsyms
From: Jakub Kicinski @ 2018-09-04 14:37 UTC (permalink / raw)
To: davem; +Cc: netdev, oss-drivers, Jakub Kicinski
In-Reply-To: <20180904143733.16362-1-jakub.kicinski@netronome.com>
Return the error and report value through the output param.
Fixes: 640917dd81b6 ("nfp: support access to absolute RTsyms")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Francois H. Theron <francois.theron@netronome.com>
---
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
index 108ce8c5e68e..4003ed76a49a 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
@@ -337,8 +337,10 @@ int __nfp_rtsym_readq(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
u64 addr;
int err;
- if (sym->type == NFP_RTSYM_TYPE_ABS)
- return sym->addr;
+ if (sym->type == NFP_RTSYM_TYPE_ABS) {
+ *value = sym->addr;
+ return 0;
+ }
err = nfp_rtsym_to_dest(cpp, sym, action, token, off, &cpp_id, &addr);
if (err)
--
2.17.1
^ permalink raw reply related
* [PATCH net-next 2/3] nfp: prefix rtsym error messages with symbol name
From: Jakub Kicinski @ 2018-09-04 14:37 UTC (permalink / raw)
To: davem; +Cc: netdev, oss-drivers, Jakub Kicinski
In-Reply-To: <20180904143733.16362-1-jakub.kicinski@netronome.com>
For ease of debug preface all error messages with the name
of the symbol which caused them. Use the same message format
for existing messages while at it.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Francois H. Theron <francois.theron@netronome.com>
---
.../netronome/nfp/nfpcore/nfp_rtsym.c | 21 ++++++++++---------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
index 4003ed76a49a..5e416e14e46a 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
@@ -237,10 +237,10 @@ u64 nfp_rtsym_size(const struct nfp_rtsym *sym)
{
switch (sym->type) {
case NFP_RTSYM_TYPE_NONE:
- pr_err("rtsym type NONE\n");
+ pr_err("rtsym '%s': type NONE\n", sym->name);
return 0;
default:
- pr_warn("Unknown rtsym type: %d\n", sym->type);
+ pr_warn("rtsym '%s': unknown type: %d\n", sym->name, sym->type);
/* fall through */
case NFP_RTSYM_TYPE_OBJECT:
case NFP_RTSYM_TYPE_FUNCTION:
@@ -255,7 +255,8 @@ nfp_rtsym_to_dest(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
u8 action, u8 token, u64 off, u32 *cpp_id, u64 *addr)
{
if (sym->type != NFP_RTSYM_TYPE_OBJECT) {
- nfp_err(cpp, "Direct access attempt to non-object rtsym\n");
+ nfp_err(cpp, "rtsym '%s': direct access to non-object rtsym\n",
+ sym->name);
return -EINVAL;
}
@@ -270,8 +271,8 @@ nfp_rtsym_to_dest(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
*cpp_id = NFP_CPP_ISLAND_ID(NFP_CPP_TARGET_MU, action, token,
sym->domain);
} else if (sym->target < 0) {
- nfp_err(cpp, "Unhandled RTsym target encoding: %d\n",
- sym->target);
+ nfp_err(cpp, "rtsym '%s': unhandled target encoding: %d\n",
+ sym->name, sym->target);
return -EINVAL;
} else {
*cpp_id = NFP_CPP_ISLAND_ID(sym->target, action, token,
@@ -451,7 +452,7 @@ u64 nfp_rtsym_read_le(struct nfp_rtsym_table *rtbl, const char *name,
break;
default:
nfp_err(rtbl->cpp,
- "rtsym '%s' unsupported or non-scalar size: %lld\n",
+ "rtsym '%s': unsupported or non-scalar size: %lld\n",
name, nfp_rtsym_size(sym));
err = -EINVAL;
break;
@@ -497,7 +498,7 @@ int nfp_rtsym_write_le(struct nfp_rtsym_table *rtbl, const char *name,
break;
default:
nfp_err(rtbl->cpp,
- "rtsym '%s' unsupported or non-scalar size: %lld\n",
+ "rtsym '%s': unsupported or non-scalar size: %lld\n",
name, nfp_rtsym_size(sym));
err = -EINVAL;
break;
@@ -523,18 +524,18 @@ nfp_rtsym_map(struct nfp_rtsym_table *rtbl, const char *name, const char *id,
err = nfp_rtsym_to_dest(rtbl->cpp, sym, NFP_CPP_ACTION_RW, 0, 0,
&cpp_id, &addr);
if (err) {
- nfp_err(rtbl->cpp, "Symbol %s mapping failed\n", name);
+ nfp_err(rtbl->cpp, "rtsym '%s': mapping failed\n", name);
return (u8 __iomem *)ERR_PTR(err);
}
if (sym->size < min_size) {
- nfp_err(rtbl->cpp, "Symbol %s too small\n", name);
+ nfp_err(rtbl->cpp, "rtsym '%s': too small\n", name);
return (u8 __iomem *)ERR_PTR(-EINVAL);
}
mem = nfp_cpp_map_area(rtbl->cpp, id, cpp_id, addr, sym->size, area);
if (IS_ERR(mem)) {
- nfp_err(rtbl->cpp, "Failed to map symbol %s: %ld\n",
+ nfp_err(rtbl->cpp, "rtysm '%s': failed to map: %ld\n",
name, PTR_ERR(mem));
return mem;
}
--
2.17.1
^ permalink raw reply related
* [PATCH net-next 3/3] nfp: validate rtsym accesses fall within the symbol
From: Jakub Kicinski @ 2018-09-04 14:37 UTC (permalink / raw)
To: davem; +Cc: netdev, oss-drivers, Jakub Kicinski
In-Reply-To: <20180904143733.16362-1-jakub.kicinski@netronome.com>
With the accesses to rtsyms now all going via special helpers
we can easily make sure the driver is not reading past the
end of the symbol.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Francois H. Theron <francois.theron@netronome.com>
---
.../netronome/nfp/nfpcore/nfp_rtsym.c | 48 +++++++++++++++++--
1 file changed, 45 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
index 5e416e14e46a..1ad0a015572e 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c
@@ -39,6 +39,8 @@
* Espen Skoglund <espen.skoglund@netronome.com>
* Francois H. Theron <francois.theron@netronome.com>
*/
+
+#include <asm/unaligned.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/slab.h>
@@ -285,15 +287,23 @@ nfp_rtsym_to_dest(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
int __nfp_rtsym_read(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
u8 action, u8 token, u64 off, void *buf, size_t len)
{
+ u64 sym_size = nfp_rtsym_size(sym);
u32 cpp_id;
u64 addr;
int err;
+ if (off > sym_size) {
+ nfp_err(cpp, "rtsym '%s': read out of bounds: off: %lld + len: %zd > size: %lld\n",
+ sym->name, off, len, sym_size);
+ return -ENXIO;
+ }
+ len = min_t(size_t, len, sym_size - off);
+
if (sym->type == NFP_RTSYM_TYPE_ABS) {
- __le64 tmp = cpu_to_le64(sym->addr);
+ u8 tmp[8];
- len = min(len, sizeof(tmp));
- memcpy(buf, &tmp, len);
+ put_unaligned_le64(sym->addr, tmp);
+ memcpy(buf, &tmp[off], len);
return len;
}
@@ -318,6 +328,12 @@ int __nfp_rtsym_readl(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
u64 addr;
int err;
+ if (off + 4 > nfp_rtsym_size(sym)) {
+ nfp_err(cpp, "rtsym '%s': readl out of bounds: off: %lld + 4 > size: %lld\n",
+ sym->name, off, nfp_rtsym_size(sym));
+ return -ENXIO;
+ }
+
err = nfp_rtsym_to_dest(cpp, sym, action, token, off, &cpp_id, &addr);
if (err)
return err;
@@ -338,6 +354,12 @@ int __nfp_rtsym_readq(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
u64 addr;
int err;
+ if (off + 8 > nfp_rtsym_size(sym)) {
+ nfp_err(cpp, "rtsym '%s': readq out of bounds: off: %lld + 8 > size: %lld\n",
+ sym->name, off, nfp_rtsym_size(sym));
+ return -ENXIO;
+ }
+
if (sym->type == NFP_RTSYM_TYPE_ABS) {
*value = sym->addr;
return 0;
@@ -359,10 +381,18 @@ int nfp_rtsym_readq(struct nfp_cpp *cpp, const struct nfp_rtsym *sym, u64 off,
int __nfp_rtsym_write(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
u8 action, u8 token, u64 off, void *buf, size_t len)
{
+ u64 sym_size = nfp_rtsym_size(sym);
u32 cpp_id;
u64 addr;
int err;
+ if (off > sym_size) {
+ nfp_err(cpp, "rtsym '%s': write out of bounds: off: %lld + len: %zd > size: %lld\n",
+ sym->name, off, len, sym_size);
+ return -ENXIO;
+ }
+ len = min_t(size_t, len, sym_size - off);
+
err = nfp_rtsym_to_dest(cpp, sym, action, token, off, &cpp_id, &addr);
if (err)
return err;
@@ -383,6 +413,12 @@ int __nfp_rtsym_writel(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
u64 addr;
int err;
+ if (off + 4 > nfp_rtsym_size(sym)) {
+ nfp_err(cpp, "rtsym '%s': writel out of bounds: off: %lld + 4 > size: %lld\n",
+ sym->name, off, nfp_rtsym_size(sym));
+ return -ENXIO;
+ }
+
err = nfp_rtsym_to_dest(cpp, sym, action, token, off, &cpp_id, &addr);
if (err)
return err;
@@ -403,6 +439,12 @@ int __nfp_rtsym_writeq(struct nfp_cpp *cpp, const struct nfp_rtsym *sym,
u64 addr;
int err;
+ if (off + 8 > nfp_rtsym_size(sym)) {
+ nfp_err(cpp, "rtsym '%s': writeq out of bounds: off: %lld + 8 > size: %lld\n",
+ sym->name, off, nfp_rtsym_size(sym));
+ return -ENXIO;
+ }
+
err = nfp_rtsym_to_dest(cpp, sym, action, token, off, &cpp_id, &addr);
if (err)
return err;
--
2.17.1
^ permalink raw reply related
* Re: [PATCH V2] net: qca_spi: Fix race condition in spi transfers
From: David Miller @ 2018-09-04 19:16 UTC (permalink / raw)
To: stefan.wahren; +Cc: netdev, linux-kernel
In-Reply-To: <1535978657-2880-1-git-send-email-stefan.wahren@i2se.com>
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Mon, 3 Sep 2018 14:44:17 +0200
> With performance optimization the spi transfer and messages from basic
> register operations like qcaspi_read_register moved into the private
> driver structure. But they weren't protected against mutual access
> (e.g. between driver kthread and ethtool). So dumping the QCA7000
> register via ethtool during network traffic could make spi_sync
> hang forever, because the completion in spi_message is overwritten.
>
> So revert the optimization completely.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/net/ethernet/qualcomm/qca_7k.c | 84 ++++++++++++------------
> drivers/net/ethernet/qualcomm/qca_spi.c | 110 +++++++++++++++++---------------
> drivers/net/ethernet/qualcomm/qca_spi.h | 5 --
> 3 files changed, 97 insertions(+), 102 deletions(-)
>
> Changes in V2:
> - explain race in commit log more in detail
Ok, I want one more change.
Please repost this with an appropriate Fixes: tag added.
Thank you.
^ permalink raw reply
* Re: [PATCH net-next] net: usbnet: mark expected switch fall-through
From: David Miller @ 2018-09-04 19:20 UTC (permalink / raw)
To: gustavo; +Cc: oneukum, netdev, linux-usb, linux-kernel
In-Reply-To: <20180903184845.GA8150@embeddedor.com>
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 3 Sep 2018 13:48:45 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1077614 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied, thank you.
^ permalink raw reply
* bnxt_en fails to initialize MAC address in Oracle cloud
From: Seth Forshee @ 2018-09-04 14:58 UTC (permalink / raw)
To: Michael Chan; +Cc: netdev
We got a bug report against Ubuntu about networking failing to come up
in the Oracle cloud:
https://bugs.launchpad.net/bugs/1790652
This is with a kernel based on 4.18.5, and it has also been seen with a
4.17-based kernel. I'm not currently aware of any working kernel
version. The driver seems to be getting an error response from the
firmware when trying to set the MAC address.
[ 2.437420] Broadcom NetXtreme-C/E driver bnxt_en v1.9.1
[ 2.449820] bnxt_en 0000:00:03.0 (unnamed net_device) (uninitialized): hwrm req_type 0xf seq id 0x5 error 0xffff
[ 2.455610] bnxt_en 0000:00:03.0 (unnamed net_device) (uninitialized): VF MAC address 00:00:17:02:05:d0 not approved by the PF
[ 2.461443] bnxt_en 0000:00:03.0: Unable to initialize mac address.
[ 2.483531] bnxt_en: probe of 0000:00:03.0 failed with error -99
Let me know if there's more information you need, and we'll try to get
it for you.
Thanks,
Seth
^ permalink raw reply
* [RFC bpf-next PATCH] samples/bpf: xdp1 add XDP hardware offload option
From: Jesper Dangaard Brouer @ 2018-09-04 14:59 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Nick Viljoen, oss-drivers, netdev, John W. Linville, jhsiao,
Jesper Dangaard Brouer, Quentin Monnet
Trying to use XDP hardware offloading via XDP_FLAGS_HW_MODE
and setting the ifindex in prog_load_attr.ifindex before
loading the BPF code via bpf_prog_load_xattr().
This unfortunately does not seem to work...
- Am I doing something wrong?
Notice, I also disable the map BPF_MAP_TYPE_PERCPU_ARRAY
to make sure it was not related to the map (not supporting
offloading).
Failed with:
# ./xdp1 -O $(</sys/class/net/enp130s0np1/ifindex)
libbpf: load bpf program failed: Invalid argument
libbpf: failed to load program 'xdp1'
libbpf: failed to load object './xdp1_kern.o'
Tested on kernel 4.18.0-2.el8.x86_64 with driver nfp
Ethernet controller: Netronome Systems, Inc. Device 4000
---
samples/bpf/xdp1_kern.c | 8 +++++---
samples/bpf/xdp1_user.c | 12 ++++++++++--
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/samples/bpf/xdp1_kern.c b/samples/bpf/xdp1_kern.c
index 219742106bfd..1b577b7dba1e 100644
--- a/samples/bpf/xdp1_kern.c
+++ b/samples/bpf/xdp1_kern.c
@@ -14,12 +14,14 @@
#include <linux/ipv6.h>
#include "bpf_helpers.h"
+/*
struct bpf_map_def SEC("maps") rxcnt = {
.type = BPF_MAP_TYPE_PERCPU_ARRAY,
.key_size = sizeof(u32),
.value_size = sizeof(long),
.max_entries = 256,
};
+*/
static int parse_ipv4(void *data, u64 nh_off, void *data_end)
{
@@ -83,9 +85,9 @@ int xdp_prog1(struct xdp_md *ctx)
else
ipproto = 0;
- value = bpf_map_lookup_elem(&rxcnt, &ipproto);
- if (value)
- *value += 1;
+// value = bpf_map_lookup_elem(&rxcnt, &ipproto);
+// if (value)
+// *value += 1;
return rc;
}
diff --git a/samples/bpf/xdp1_user.c b/samples/bpf/xdp1_user.c
index b02c531510ed..a362b5adfcf0 100644
--- a/samples/bpf/xdp1_user.c
+++ b/samples/bpf/xdp1_user.c
@@ -64,7 +64,8 @@ static void usage(const char *prog)
"usage: %s [OPTS] IFINDEX\n\n"
"OPTS:\n"
" -S use skb-mode\n"
- " -N enforce native mode\n",
+ " -N enforce native mode\n"
+ " -O offload mode\n",
prog);
}
@@ -74,7 +75,7 @@ int main(int argc, char **argv)
struct bpf_prog_load_attr prog_load_attr = {
.prog_type = BPF_PROG_TYPE_XDP,
};
- const char *optstr = "SN";
+ const char *optstr = "SNO";
int prog_fd, map_fd, opt;
struct bpf_object *obj;
struct bpf_map *map;
@@ -88,6 +89,9 @@ int main(int argc, char **argv)
case 'N':
xdp_flags |= XDP_FLAGS_DRV_MODE;
break;
+ case 'O':
+ xdp_flags |= XDP_FLAGS_HW_MODE;
+ break;
default:
usage(basename(argv[0]));
return 1;
@@ -109,6 +113,10 @@ int main(int argc, char **argv)
snprintf(filename, sizeof(filename), "%s_kern.o", argv[0]);
prog_load_attr.file = filename;
+ /* For HW offload provide ifindex when loading BPF code */
+ if (xdp_flags & XDP_FLAGS_HW_MODE) {
+ prog_load_attr.ifindex = ifindex;
+ }
if (bpf_prog_load_xattr(&prog_load_attr, &obj, &prog_fd))
return 1;
^ permalink raw reply related
* Re: [RFC bpf-next PATCH] samples/bpf: xdp1 add XDP hardware offload option
From: Jakub Kicinski @ 2018-09-04 15:09 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: Nick Viljoen, oss-drivers, netdev, John W. Linville, jhsiao,
Quentin Monnet
In-Reply-To: <153607315988.23449.13651086600809900701.stgit@firesoul>
On Tue, 04 Sep 2018 16:59:19 +0200, Jesper Dangaard Brouer wrote:
> Trying to use XDP hardware offloading via XDP_FLAGS_HW_MODE
> and setting the ifindex in prog_load_attr.ifindex before
> loading the BPF code via bpf_prog_load_xattr().
>
> This unfortunately does not seem to work...
> - Am I doing something wrong?
>
> Notice, I also disable the map BPF_MAP_TYPE_PERCPU_ARRAY
> to make sure it was not related to the map (not supporting
> offloading).
>
> Failed with:
> # ./xdp1 -O $(</sys/class/net/enp130s0np1/ifindex)
> libbpf: load bpf program failed: Invalid argument
> libbpf: failed to load program 'xdp1'
> libbpf: failed to load object './xdp1_kern.o'
>
> Tested on kernel 4.18.0-2.el8.x86_64 with driver nfp
> Ethernet controller: Netronome Systems, Inc. Device 4000
Are you running the BPF capable FW?
https://help.netronome.com/support/solutions/articles/36000050009-agilio-ebpf-2-0-6-extended-berkeley-packet-filter
^ permalink raw reply
* Re: [PATCH v6 3/4] gpiolib: Pass array info to get/set array functions
From: kbuild test robot @ 2018-09-04 15:27 UTC (permalink / raw)
To: Janusz Krzysztofik
Cc: kbuild-all, Linus Walleij, Andrew Lunn, Ulf Hansson, linux-doc,
linux-iio, Dominik Brodowski, Peter Rosin, netdev, linux-i2c,
Peter Meerwald-Stadler, devel, Florian Fainelli, Jonathan Corbet,
Janusz Krzysztofik, Kishon Vijay Abraham I, Geert Uytterhoeven,
linux-serial, Jiri Slaby, Michael Hennerich, linux-gpio,
Lars-Peter Clausen
In-Reply-To: <20180831225616.29221-4-jmkrzyszt@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4096 bytes --]
Hi Janusz,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on gpio/for-next]
[also build test ERROR on v4.19-rc2 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Janusz-Krzysztofik/gpiolib-speed-up-GPIO-array-processing/20180903-174241
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: arm-cns3420vb_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
All errors (new ones prefixed by >>):
drivers/mmc/core/pwrseq_simple.c: In function 'mmc_pwrseq_simple_set_gpios_value':
drivers/mmc/core/pwrseq_simple.c:49:13: error: passing argument 3 of 'gpiod_set_array_value_cansleep' from incompatible pointer type [-Werror=incompatible-pointer-types]
reset_gpios->info, value_bitmap);
^~~~~~~~~~~
In file included from drivers/mmc/core/pwrseq_simple.c:18:0:
include/linux/gpio/consumer.h:417:20: note: expected 'int *' but argument is of type 'struct gpio_array *'
static inline void gpiod_set_array_value_cansleep(unsigned int array_size,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mmc/core/pwrseq_simple.c:48:3: error: too many arguments to function 'gpiod_set_array_value_cansleep'
gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/mmc/core/pwrseq_simple.c:18:0:
include/linux/gpio/consumer.h:417:20: note: declared here
static inline void gpiod_set_array_value_cansleep(unsigned int array_size,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/2313edb413de154774fb6a3431f5f135f9c78180
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 2313edb413de154774fb6a3431f5f135f9c78180
vim +/gpiod_set_array_value_cansleep +48 drivers/mmc/core/pwrseq_simple.c
5b96fea73 Srinivas Kandagatla 2016-04-14 36
934f1f483 Javier Martinez Canillas 2015-01-29 37 static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq,
934f1f483 Javier Martinez Canillas 2015-01-29 38 int value)
934f1f483 Javier Martinez Canillas 2015-01-29 39 {
ce0372758 Javier Martinez Canillas 2015-09-21 40 struct gpio_descs *reset_gpios = pwrseq->reset_gpios;
64a67d476 Martin Fuzzey 2016-01-20 41
64a67d476 Martin Fuzzey 2016-01-20 42 if (!IS_ERR(reset_gpios)) {
486e66613 Tobin C. Harding 2018-03-26 43 int nvalues = reset_gpios->ndescs;
00db98568 Janusz Krzysztofik 2018-09-01 44 DECLARE_BITMAP(value_bitmap, nvalues);
934f1f483 Javier Martinez Canillas 2015-01-29 45
00db98568 Janusz Krzysztofik 2018-09-01 46 *value_bitmap = value;
486e66613 Tobin C. Harding 2018-03-26 47
00db98568 Janusz Krzysztofik 2018-09-01 @48 gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc,
2313edb41 Janusz Krzysztofik 2018-09-01 @49 reset_gpios->info, value_bitmap);
64a67d476 Martin Fuzzey 2016-01-20 50 }
934f1f483 Javier Martinez Canillas 2015-01-29 51 }
934f1f483 Javier Martinez Canillas 2015-01-29 52
:::::: The code at line 48 was first introduced by commit
:::::: 00db98568b73a7b04c5120e5b87934c7355cc015 gpiolib: Pass bitmaps, not integer arrays, to get/set array
:::::: TO: Janusz Krzysztofik <jmkrzyszt@gmail.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 9623 bytes --]
^ permalink raw reply
* [GIT] Networking
From: David Miller @ 2018-09-04 19:42 UTC (permalink / raw)
To: torvalds; +Cc: akpm, netdev, linux-kernel
1) Must perform TXQ teardown before unregistering interfaces in
mac80211, from Toke Høiland-Jørgensen.
2) Don't allow creating mac80211_hwsim with less than one channel,
from Johannes Berg.
3) Division by zero in cfg80211, fix from Johannes Berg.
4) Fix endian issue in tipc, from Haiqing Bai.
5) BPF sockmap use-after-free fixes from Daniel Borkmann.
6) Spectre-v1 in mac80211_hwsim, from Jinbum Park.
7) Missing rhashtable_walk_exit() in tipc, from Cong Wang.
8) Revert kvzalloc() conversion of AF_PACKET, it breaks mmap() when
kvzalloc() tries to use kmalloc() pages. From Eric Dumazet.
9) Fix deadlock in hv_netvsc, from Dexuan Cui.
10) Do not restart timewait timer on RST, from Florian Westphal.
11) Fix double lwstate refcount grab in ipv6, from Alexey Kodanev.
12) Unsolicit report count handling is off-by-one, fix from Hangbin
Liu.
13) Sleep-in-atomic in cadence driver, from Jia-Ju Bai.
14) Respect ttl-inherit in ip6 tunnel driver, from Hangbin Liu.
15) Use-after-free in act_ife, fix from Cong Wang.
16) Missing hold to meta module in act_ife, from Vlad Buslov.
Please pull, thanks a lot!
The following changes since commit 050cdc6c9501abcd64720b8cc3e7941efee9547d:
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2018-08-27 11:59:39 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
for you to fetch changes up to a33710bdb6b284f8f1e24f1119d167037b374ebb:
net: phy: sfp: Handle unimplemented hwmon limits and alarms (2018-09-04 12:22:41 -0700)
----------------------------------------------------------------
Alexei Starovoitov (1):
Merge branch 'bpf_msg_pull_data-fixes'
Alexey Kodanev (2):
vti6: remove !skb->ignore_df check from vti6_xmit()
ipv6: don't get lwtstate twice in ip6_rt_copy_init()
Andrew Lunn (1):
net: phy: sfp: Handle unimplemented hwmon limits and alarms
Anthony Wong (1):
r8169: add support for NCube 8168 network card
Arnd Bergmann (1):
rfkill-gpio: include linux/mod_devicetable.h
Arunk Khandavalli (1):
cfg80211: nl80211_update_ft_ies() to validate NL80211_ATTR_IE
Azat Khuzhin (1):
r8169: set RxConfig after tx/rx is enabled for RTL8169sb/8110sb devices
Baruch Siach (1):
net: mvpp2: initialize port of_node pointer
Chris Brandt (1):
sh_eth: Add R7S9210 support
Cong Wang (3):
tipc: fix a missing rhashtable_walk_exit()
tipc: switch to rhashtable iterator
act_ife: fix a potential use-after-free
Dan Carpenter (1):
cfg80211: fix a type issue in ieee80211_chandef_to_operating_class()
Danek Duvall (2):
mac80211: correct use of IEEE80211_VHT_CAP_RXSTBC_X
mac80211_hwsim: correct use of IEEE80211_VHT_CAP_RXSTBC_X
Daniel Borkmann (6):
bpf, sockmap: fix potential use after free in bpf_tcp_close
bpf, sockmap: fix psock refcount leak in bpf_tcp_recvmsg
bpf: fix several offset tests in bpf_msg_pull_data
bpf: fix msg->data/data_end after sg shift repair in bpf_msg_pull_data
bpf: fix shift upon scatterlist ring wrap-around in bpf_msg_pull_data
bpf: fix sg shift repair start offset in bpf_msg_pull_data
David Ahern (1):
net/ipv6: Only update MTU metric if it set
David S. Miller (10):
Merge branch 'net-sched-fixes'
Merge git://git.kernel.org/.../bpf/bpf
Merge branch 'hns-fixes'
Merge branch 'ipv6-fix-error-path-of-inet6_init'
Merge branch 'net_sched-reject-unknown-tcfa_action-values'
Merge branch 'igmp-fix-two-incorrect-unsolicit-report-count-issues'
Merge git://git.kernel.org/.../bpf/bpf
Merge branch 'sctp-two-fixes-for-spp_ipv6_flowlabel-and-spp_dscp-sockopts'
Merge branch 'bnxt_en-Bug-fixes'
Merge tag 'mac80211-for-davem-2018-09-03' of git://git.kernel.org/.../jberg/mac80211
Davide Caratti (1):
net/sched: act_pedit: fix dump of extended layered op
Dexuan Cui (1):
hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()
Dinh Nguyen (1):
net: stmmac: build the dwmac-socfpga platform driver for Stratix10
Doug Berger (1):
net: bcmgenet: use MAC link status for fixed phy
Dreyfuss, Haim (1):
mac80211: fix WMM TXOP calculation
Emmanuel Grumbach (4):
mac80211: don't update the PM state of a peer upon a multicast frame
mac80211: fix a race between restart and CSA flows
mac80211: don't Tx a deauth frame if the AP forbade Tx
mac80211: shorten the IBSS debug messages
Eric Dumazet (1):
Revert "packet: switch kvzalloc to allocate memory"
Florian Westphal (1):
tcp: do not restart timewait timer on rst reception
Gleb Fotengauer-Malinovskiy (1):
vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
Haim Dreyfuss (2):
nl80211: Fix nla_put_u8 to u16 for NL80211_WMMR_TXOP
nl80211: Pass center frequency in kHz instead of MHz
Haiqing Bai (1):
tipc: fix the big/little endian issue in tipc_dest
Hangbin Liu (3):
igmp: fix incorrect unsolicit report count when join group
igmp: fix incorrect unsolicit report count after link down and up
ip6_tunnel: respect ttl inherit for ip6tnl
Ilan Peer (1):
mac80211: Fix station bandwidth setting after channel switch
Ivan Mikhaylov (1):
net/ibm/emac: wrong emac_calc_base call was used by typo
Jakub Kicinski (1):
nfp: wait for posted reconfigs when disabling the device
Jerome Brunet (1):
Revert "net: stmmac: Do not keep rearming the coalesce timer in stmmac_xmit"
Jia-Ju Bai (1):
net: cadence: Fix a sleep-in-atomic-context bug in macb_halt_tx()
Jinbum Park (1):
mac80211_hwsim: Fix possible Spectre-v1 for hwsim_world_regdom_custom
Jiri Pirko (2):
net: sched: fix extack error message when chain is failed to be created
net: sched: return -ENOENT when trying to remove filter from non-existent chain
Johannes Berg (3):
mac80211_hwsim: require at least one channel
cfg80211: remove division by size of sizeof(struct ieee80211_wmm_rule)
mac80211: always account for A-MSDU header changes
John Fastabend (2):
bpf: sockmap, decrement copied count correctly in redirect error case
bpf: avoid misuse of psock when TCP_ULP_BPF collides with another ULP
Linus Walleij (1):
net: dsa: Drop GPIO includes
Lorenzo Bianconi (2):
mac80211: do not convert to A-MSDU if frag/subframe limited
mac80211: fix an off-by-one issue in A-MSDU max_subframe computation
Michael Chan (3):
bnxt_en: Fix firmware signaled resource change logic in open.
bnxt_en: Clean up unused functions.
bnxt_en: Do not adjust max_cp_rings by the ones used by RDMA.
Paolo Abeni (2):
net_sched: reject unknown tcfa_action values
tc-testing: add test-cases for numeric and invalid control action
Pavel Machek (1):
net/rds: RDS is not Radio Data System
Peng Li (2):
net: hns: add the code for cleaning pkt in chip
net: hns: add netif_carrier_off before change speed and duplex
Prashant Bhole (1):
tools/bpf: bpftool, add xskmap in map types
Sabrina Dubroca (5):
ipv6: fix cleanup ordering for ip6_mr failure
ipv6: fix cleanup ordering for pingv6 registration
net: rtnl: return early from rtnl_unregister_all when protocol isn't registered
selftests: pmtu: maximum MTU for vti4 is 2^16-1-20
selftests: pmtu: detect correct binary to ping ipv6 addresses
Sara Sharon (1):
mac80211: avoid kernel panic when building AMSDU from non-linear SKB
Stanislaw Gruszka (1):
cfg80211: make wmm_rule part of the reg_rule structure
Stefan Agner (1):
bpf: fix build error with clang
Tariq Toukan (1):
net/mlx5: Fix SQ offset in QPs with small RQ
Thomas Falcon (1):
ibmvnic: Include missing return code checks in reset function
Toke Høiland-Jørgensen (1):
mac80211: Run TXQ teardown code before de-registering interfaces
Tony Lindgren (2):
dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle
net: ethernet: cpsw-phy-sel: prefer phandle for phy sel
Tushar Dave (1):
bpf: Fix bpf_msg_pull_data()
Vinson Lee (1):
uapi: Fix linux/rds.h userspace compilation errors.
Vlad Buslov (2):
net: sched: null actions array pointer before releasing action
net: sched: action_ife: take reference to meta module
Xin Long (5):
sctp: hold transport before accessing its asoc in sctp_transport_get_next
sctp: remove useless start_fail from sctp_ht_iter in proc
erspan: set erspan_ver to 1 by default when adding an erspan dev
sctp: fix invalid reference to the index variable of the iterator
sctp: not traverse asoc trans list if non-ipv6 trans exists for ipv6_flowlabel
Yuan-Chi Pang (1):
mac80211: mesh: fix HWMP sequence numbering to follow standard
Zhenbo Gao (2):
tipc: correct spelling errors for struct tipc_bc_base's comment
tipc: correct spelling errors for tipc_topsrv_queue_evt() comments
Zhu Yanjun (1):
net/rds: Use rdma_read_gids to get connection SGID/DGID in IPv6
Documentation/devicetree/bindings/net/cpsw.txt | 6 ++++++
Documentation/devicetree/bindings/net/sh_eth.txt | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 22 +++++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 +--
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 7 ++++---
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 20 --------------------
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 1 -
drivers/net/ethernet/broadcom/genet/bcmgenet.h | 3 +++
drivers/net/ethernet/broadcom/genet/bcmmii.c | 10 ++++++++--
drivers/net/ethernet/cadence/macb_main.c | 2 +-
drivers/net/ethernet/hisilicon/hns/hnae.h | 2 ++
drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 36 ++++++++++++++++++++++++++++++++++++
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h | 8 ++++++++
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 29 +++++++++++++++++++++++++++++
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h | 3 +++
drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 23 +++++++++++++++++++++++
drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.h | 1 +
drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 23 +++++++++++++++++++++++
drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h | 1 +
drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 1 +
drivers/net/ethernet/hisilicon/hns/hns_enet.c | 21 ++++++++++++++++++---
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 2 ++
drivers/net/ethernet/ibm/emac/core.c | 6 +++---
drivers/net/ethernet/ibm/ibmvnic.c | 12 +++++++++---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 +
drivers/net/ethernet/mellanox/mlx5/core/wq.c | 5 +++--
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 48 +++++++++++++++++++++++++++++++++---------------
drivers/net/ethernet/realtek/r8169.c | 7 +++++--
drivers/net/ethernet/renesas/sh_eth.c | 36 ++++++++++++++++++++++++++++++++++++
drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +-
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 -
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +----
drivers/net/ethernet/ti/cpsw-phy-sel.c | 9 ++++++---
drivers/net/hyperv/netvsc_drv.c | 11 ++++++++++-
drivers/net/phy/sfp.c | 20 ++++++++++++++++----
drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 50 +++++---------------------------------------------
drivers/net/wireless/mac80211_hwsim.c | 12 +++++++++---
include/linux/pci_ids.h | 2 ++
include/net/cfg80211.h | 4 ++--
include/net/regulatory.h | 4 ++--
include/uapi/linux/rds.h | 1 +
include/uapi/linux/vhost.h | 2 +-
kernel/bpf/sockmap.c | 64 ++++++++++++++++++++++++++++++++++++----------------------------
net/core/filter.c | 59 ++++++++++++++++++++++++++++++++---------------------------
net/core/rtnetlink.c | 4 ++++
net/dsa/dsa.c | 2 --
net/ipv4/igmp.c | 11 ++++-------
net/ipv4/ip_gre.c | 3 +++
net/ipv4/tcp_minisocks.c | 3 ++-
net/ipv6/af_inet6.c | 10 +++++-----
net/ipv6/ip6_fib.c | 5 ++++-
net/ipv6/ip6_gre.c | 1 +
net/ipv6/ip6_tunnel.c | 10 +++++++++-
net/ipv6/ip6_vti.c | 2 +-
net/ipv6/route.c | 1 -
net/mac80211/ibss.c | 22 +++++++++++-----------
net/mac80211/main.c | 28 ++++++++++++++++++++++------
net/mac80211/mesh_hwmp.c | 4 ++++
net/mac80211/mlme.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
net/mac80211/rx.c | 1 +
net/mac80211/tx.c | 54 ++++++++++++++++++++++++++++++------------------------
net/mac80211/util.c | 11 +++++------
net/packet/af_packet.c | 44 +++++++++++++++++++++++++++++++-------------
net/packet/internal.h | 1 +
net/rds/Kconfig | 2 +-
net/rds/ib.c | 9 ++-------
net/rfkill/rfkill-gpio.c | 1 +
net/sched/act_api.c | 18 ++++++++++++------
net/sched/act_ife.c | 18 ++++++++++++++++--
net/sched/act_pedit.c | 18 +++++++++++++-----
net/sched/cls_api.c | 4 ++--
net/sctp/proc.c | 8 --------
net/sctp/socket.c | 56 ++++++++++++++++++++++++++++++++++----------------------
net/tipc/bcast.c | 4 ++--
net/tipc/diag.c | 2 ++
net/tipc/name_table.c | 10 ++++------
net/tipc/name_table.h | 9 ++-------
net/tipc/netlink.c | 2 ++
net/tipc/socket.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------
net/tipc/socket.h | 2 ++
net/tipc/topsrv.c | 4 ++--
net/wireless/nl80211.c | 15 ++++++++-------
net/wireless/reg.c | 91 +++++++++++++------------------------------------------------------------------------------
net/wireless/util.c | 2 +-
tools/bpf/bpftool/map.c | 1 +
tools/testing/selftests/net/pmtu.sh | 7 +++++--
tools/testing/selftests/tc-testing/tc-tests/actions/police.json | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
89 files changed, 941 insertions(+), 452 deletions(-)
^ permalink raw reply
* Re: [PATCH v7 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array
From: kbuild test robot @ 2018-09-04 15:29 UTC (permalink / raw)
To: Janusz Krzysztofik
Cc: kbuild-all, Linus Walleij, Jonathan Corbet, Miguel Ojeda Sandonis,
Peter Korsgaard, Peter Rosin, Ulf Hansson, Andrew Lunn,
Florian Fainelli, David S. Miller, Dominik Brodowski,
Greg Kroah-Hartman, Kishon Vijay Abraham I, Lars-Peter Clausen,
Michael Hennerich, Jonathan Cameron, Hartmut Knaack,
Peter Meerwald-Stadler, Jiri Slaby, Willy
In-Reply-To: <20180902120144.6855-2-jmkrzyszt@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 23765 bytes --]
Hi Janusz,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on gpio/for-next]
[also build test WARNING on v4.19-rc2 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Janusz-Krzysztofik/gpiolib-Pass-bitmaps-not-integer-arrays-to-get-set-array/20180903-172834
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
reproduce: make htmldocs
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
All warnings (new ones prefixed by >>):
WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org)
include/linux/srcu.h:175: warning: Function parameter or member 'p' not described in 'srcu_dereference_notrace'
include/linux/srcu.h:175: warning: Function parameter or member 'sp' not described in 'srcu_dereference_notrace'
include/linux/gfp.h:1: warning: no structured comments found
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev'
include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev'
include/net/mac80211.h:2328: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw'
include/net/mac80211.h:2328: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw'
include/net/mac80211.h:977: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info'
include/net/mac80211.h:977: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info'
net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info'
include/linux/mod_devicetable.h:763: warning: Function parameter or member 'driver_data' not described in 'typec_device_id'
kernel/sched/fair.c:3371: warning: Function parameter or member 'flags' not described in 'attach_entity_load_avg'
arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'i' description in 'arch_atomic_sub_and_test'
arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'v' description in 'arch_atomic_sub_and_test'
arch/x86/include/asm/atomic.h:96: warning: Excess function parameter 'v' description in 'arch_atomic_inc'
arch/x86/include/asm/atomic.h:109: warning: Excess function parameter 'v' description in 'arch_atomic_dec'
arch/x86/include/asm/atomic.h:124: warning: Excess function parameter 'v' description in 'arch_atomic_dec_and_test'
arch/x86/include/asm/atomic.h:138: warning: Excess function parameter 'v' description in 'arch_atomic_inc_and_test'
arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'i' description in 'arch_atomic_add_negative'
arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'v' description in 'arch_atomic_add_negative'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf'
include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array'
include/linux/gpio/driver.h:142: warning: Function parameter or member 'request_key' not described in 'gpio_irq_chip'
>> drivers/gpio/gpiolib.c:2936: warning: Function parameter or member 'value_bitmap' not described in 'gpiod_get_array_value'
drivers/gpio/gpiolib.c:2936: warning: Excess function parameter 'value_bitnap' description in 'gpiod_get_array_value'
include/linux/iio/hw-consumer.h:1: warning: no structured comments found
include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not described in 'key_entry'
drivers/pci/pci.c:218: warning: Excess function parameter 'p' description in 'pci_dev_str_match_path'
include/linux/regulator/driver.h:227: warning: Function parameter or member 'resume' not described in 'regulator_ops'
drivers/regulator/core.c:4479: warning: Excess function parameter 'state' description in 'regulator_suspend'
arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw0' not described in 'irb'
arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw1' not described in 'irb'
arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw2' not described in 'irb'
arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw3' not described in 'irb'
arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.eadm' not described in 'irb'
drivers/slimbus/stream.c:1: warning: no structured comments found
drivers/target/target_core_device.c:1: warning: no structured comments found
drivers/usb/dwc3/gadget.c:510: warning: Excess function parameter 'dwc' description in 'dwc3_gadget_start_config'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/bus.c:1: warning: no structured comments found
drivers/usb/typec/bus.c:268: warning: Function parameter or member 'mode' not described in 'typec_match_altmode'
drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode'
drivers/usb/typec/class.c:1: warning: no structured comments found
include/linux/w1.h:281: warning: Function parameter or member 'of_match_table' not described in 'w1_family'
fs/direct-io.c:257: warning: Excess function parameter 'offset' description in 'dio_complete'
fs/file_table.c:1: warning: no structured comments found
fs/libfs.c:477: warning: Excess function parameter 'available' description in 'simple_write_end'
fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode'
fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode'
fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode'
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:183: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_read_lock'
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:254: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_invalidate_range_start_gfx'
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:302: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_invalidate_range_start_hsa'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2986: warning: Excess function parameter 'dev' description in 'amdgpu_vm_get_task_info'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2987: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_get_task_info'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2987: warning: Excess function parameter 'dev' description in 'amdgpu_vm_get_task_info'
include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_pin' not described in 'drm_driver'
include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_unpin' not described in 'drm_driver'
include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_res_obj' not described in 'drm_driver'
include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_get_sg_table' not described in 'drm_driver'
include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_import_sg_table' not described in 'drm_driver'
include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_vmap' not described in 'drm_driver'
include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_vunmap' not described in 'drm_driver'
include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_mmap' not described in 'drm_driver'
include/drm/drm_panel.h:98: warning: Function parameter or member 'link' not described in 'drm_panel'
drivers/gpu/drm/i915/i915_vma.h:49: warning: cannot understand function prototype: 'struct i915_vma '
drivers/gpu/drm/i915/i915_vma.h:1: warning: no structured comments found
drivers/gpu/drm/i915/intel_guc_fwif.h:553: warning: cannot understand function prototype: 'struct guc_log_buffer_state '
drivers/gpu/drm/i915/i915_trace.h:1: warning: no structured comments found
include/linux/skbuff.h:860: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'list' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'skb_mstamp' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'head_frag' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'encapsulation' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'csum_valid' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'csum_level' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'offload_fwd_mark' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'offload_mr_fwd_mark' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff'
include/linux/skbuff.h:860: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff'
include/net/sock.h:238: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_portpair' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_cookie' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_listener' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_tw_dr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_rcv_wnd' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_tw_rcv_nxt' not described in 'sock_common'
include/net/sock.h:509: warning: Function parameter or member 'sk_backlog.rmem_alloc' not described in 'sock'
include/net/sock.h:509: warning: Function parameter or member 'sk_backlog.len' not described in 'sock'
include/net/sock.h:509: warning: Function parameter or member 'sk_backlog.head' not described in 'sock'
include/net/sock.h:509: warning: Function parameter or member 'sk_backlog.tail' not described in 'sock'
include/net/sock.h:509: warning: Function parameter or member 'sk_wq_raw' not described in 'sock'
include/net/sock.h:509: warning: Function parameter or member 'tcp_rtx_queue' not described in 'sock'
include/net/sock.h:509: warning: Function parameter or member 'sk_route_forced_caps' not described in 'sock'
include/net/sock.h:509: warning: Function parameter or member 'sk_txtime_report_errors' not described in 'sock'
include/net/sock.h:509: warning: Function parameter or member 'sk_validate_xmit_skb' not described in 'sock'
include/linux/netdevice.h:2018: warning: Function parameter or member 'adj_list.upper' not described in 'net_device'
include/linux/netdevice.h:2018: warning: Function parameter or member 'adj_list.lower' not described in 'net_device'
include/linux/netdevice.h:2018: warning: Function parameter or member 'gso_partial_features' not described in 'net_device'
include/linux/netdevice.h:2018: warning: Function parameter or member 'switchdev_ops' not described in 'net_device'
include/linux/netdevice.h:2018: warning: Function parameter or member 'l3mdev_ops' not described in 'net_device'
# https://github.com/0day-ci/linux/commit/916010a7343fd0931103acedebff6835ed3314f0
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 916010a7343fd0931103acedebff6835ed3314f0
vim +2936 drivers/gpio/gpiolib.c
eec1d566 Lukas Wunner 2017-10-12 2919
eec1d566 Lukas Wunner 2017-10-12 2920 /**
eec1d566 Lukas Wunner 2017-10-12 2921 * gpiod_get_array_value() - read values from an array of GPIOs
916010a7 Janusz Krzysztofik 2018-09-02 2922 * @array_size: number of elements in the descriptor array / value bitmap
eec1d566 Lukas Wunner 2017-10-12 2923 * @desc_array: array of GPIO descriptors whose values will be read
916010a7 Janusz Krzysztofik 2018-09-02 2924 * @value_bitnap: bitmap to store the read values
eec1d566 Lukas Wunner 2017-10-12 2925 *
eec1d566 Lukas Wunner 2017-10-12 2926 * Read the logical values of the GPIOs, i.e. taking their ACTIVE_LOW status
eec1d566 Lukas Wunner 2017-10-12 2927 * into account. Return 0 in case of success, else an error code.
eec1d566 Lukas Wunner 2017-10-12 2928 *
eec1d566 Lukas Wunner 2017-10-12 2929 * This function should be called from contexts where we cannot sleep,
eec1d566 Lukas Wunner 2017-10-12 2930 * and it will complain if the GPIO chip functions potentially sleep.
eec1d566 Lukas Wunner 2017-10-12 2931 */
eec1d566 Lukas Wunner 2017-10-12 2932 int gpiod_get_array_value(unsigned int array_size,
916010a7 Janusz Krzysztofik 2018-09-02 2933 struct gpio_desc **desc_array,
916010a7 Janusz Krzysztofik 2018-09-02 2934 unsigned long *value_bitmap)
eec1d566 Lukas Wunner 2017-10-12 2935 {
eec1d566 Lukas Wunner 2017-10-12 @2936 if (!desc_array)
eec1d566 Lukas Wunner 2017-10-12 2937 return -EINVAL;
eec1d566 Lukas Wunner 2017-10-12 2938 return gpiod_get_array_value_complex(false, false, array_size,
916010a7 Janusz Krzysztofik 2018-09-02 2939 desc_array, value_bitmap);
eec1d566 Lukas Wunner 2017-10-12 2940 }
eec1d566 Lukas Wunner 2017-10-12 2941 EXPORT_SYMBOL_GPL(gpiod_get_array_value);
eec1d566 Lukas Wunner 2017-10-12 2942
:::::: The code at line 2936 was first introduced by commit
:::::: eec1d566cdf94b57e8f5ba9fe60eea214929bcfc gpio: Introduce ->get_multiple callback
:::::: TO: Lukas Wunner <lukas@wunner.de>
:::::: CC: Linus Walleij <linus.walleij@linaro.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6587 bytes --]
^ permalink raw reply
* [RFC PATCH] xdp: xdp_do_redirect_slow() can be static
From: kbuild test robot @ 2018-09-04 15:39 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: kbuild-all, netdev, Daniel Borkmann, Alexei Starovoitov,
Jesper Dangaard Brouer
In-Reply-To: <153572917749.27338.853717648840898807.stgit@firesoul>
Fixes: 974efdb08a35 ("xdp: split code for map vs non-map redirect")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index 45ea00b..95454f3 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -3171,7 +3171,7 @@ static int __bpf_tx_xdp(struct net_device *dev,
}
/* non-static to avoid inline by compiler */
-int xdp_do_redirect_slow(struct net_device *dev, struct xdp_buff *xdp,
+static int xdp_do_redirect_slow(struct net_device *dev, struct xdp_buff *xdp,
struct bpf_prog *xdp_prog, struct bpf_redirect_info *ri)
{
struct net_device *fwd;
^ permalink raw reply related
* Re: [bpf-next PATCH 3/3] xdp: split code for map vs non-map redirect
From: kbuild test robot @ 2018-09-04 15:39 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: kbuild-all, netdev, Daniel Borkmann, Alexei Starovoitov,
Jesper Dangaard Brouer
In-Reply-To: <153572917749.27338.853717648840898807.stgit@firesoul>
Hi Jesper,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/XDP-micro-optimizations-for-redirect/20180903-121606
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
net/core/filter.c:116:48: sparse: expression using sizeof(void)
net/core/filter.c:116:48: sparse: expression using sizeof(void)
net/core/filter.c:210:32: sparse: cast to restricted __be16
net/core/filter.c:210:32: sparse: cast to restricted __be16
net/core/filter.c:210:32: sparse: cast to restricted __be16
net/core/filter.c:210:32: sparse: cast to restricted __be16
net/core/filter.c:210:32: sparse: cast to restricted __be16
net/core/filter.c:210:32: sparse: cast to restricted __be16
net/core/filter.c:210:32: sparse: cast to restricted __be16
net/core/filter.c:210:32: sparse: cast to restricted __be16
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:237:32: sparse: cast to restricted __be32
net/core/filter.c:410:33: sparse: subtraction of functions? Share your drugs
net/core/filter.c:413:33: sparse: subtraction of functions? Share your drugs
net/core/filter.c:416:33: sparse: subtraction of functions? Share your drugs
net/core/filter.c:419:33: sparse: subtraction of functions? Share your drugs
net/core/filter.c:422:33: sparse: subtraction of functions? Share your drugs
net/core/filter.c:495:27: sparse: subtraction of functions? Share your drugs
net/core/filter.c:498:27: sparse: subtraction of functions? Share your drugs
net/core/filter.c:501:27: sparse: subtraction of functions? Share your drugs
include/linux/slab.h:631:13: sparse: undefined identifier '__builtin_mul_overflow'
include/linux/slab.h:631:13: sparse: not a function <noident>
include/linux/filter.h:644:16: sparse: expression using sizeof(void)
include/linux/filter.h:644:16: sparse: expression using sizeof(void)
include/linux/filter.h:644:16: sparse: expression using sizeof(void)
include/linux/filter.h:644:16: sparse: expression using sizeof(void)
net/core/filter.c:1389:39: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sock_filter const *filter @@ got struct sockstruct sock_filter const *filter @@
net/core/filter.c:1389:39: expected struct sock_filter const *filter
net/core/filter.c:1389:39: got struct sock_filter [noderef] <asn:1>*filter
include/linux/filter.h:644:16: sparse: expression using sizeof(void)
net/core/filter.c:1467:39: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sock_filter const *filter @@ got struct sockstruct sock_filter const *filter @@
net/core/filter.c:1467:39: expected struct sock_filter const *filter
net/core/filter.c:1467:39: got struct sock_filter [noderef] <asn:1>*filter
include/linux/filter.h:644:16: sparse: expression using sizeof(void)
include/linux/filter.h:644:16: sparse: expression using sizeof(void)
include/linux/filter.h:644:16: sparse: expression using sizeof(void)
net/core/filter.c:1843:43: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __wsum [usertype] diff @@ got unsigned lonrestricted __wsum [usertype] diff @@
net/core/filter.c:1843:43: expected restricted __wsum [usertype] diff
net/core/filter.c:1843:43: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1846:36: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __be16 [usertype] old @@ got unsigned lonrestricted __be16 [usertype] old @@
net/core/filter.c:1846:36: expected restricted __be16 [usertype] old
net/core/filter.c:1846:36: got unsigned long long [unsigned] [usertype] from
net/core/filter.c:1846:42: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be16 [usertype] new @@ got unsigned lonrestricted __be16 [usertype] new @@
net/core/filter.c:1846:42: expected restricted __be16 [usertype] new
net/core/filter.c:1846:42: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1849:36: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __be32 [usertype] from @@ got unsigned lonrestricted __be32 [usertype] from @@
net/core/filter.c:1849:36: expected restricted __be32 [usertype] from
net/core/filter.c:1849:36: got unsigned long long [unsigned] [usertype] from
net/core/filter.c:1849:42: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be32 [usertype] to @@ got unsigned lonrestricted __be32 [usertype] to @@
net/core/filter.c:1849:42: expected restricted __be32 [usertype] to
net/core/filter.c:1849:42: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1894:59: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __wsum [usertype] diff @@ got unsigned lonrestricted __wsum [usertype] diff @@
net/core/filter.c:1894:59: expected restricted __wsum [usertype] diff
net/core/filter.c:1894:59: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1897:52: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be16 [usertype] from @@ got unsigned lonrestricted __be16 [usertype] from @@
net/core/filter.c:1897:52: expected restricted __be16 [usertype] from
net/core/filter.c:1897:52: got unsigned long long [unsigned] [usertype] from
net/core/filter.c:1897:58: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be16 [usertype] to @@ got unsigned lonrestricted __be16 [usertype] to @@
net/core/filter.c:1897:58: expected restricted __be16 [usertype] to
net/core/filter.c:1897:58: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1900:52: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be32 [usertype] from @@ got unsigned lonrestricted __be32 [usertype] from @@
net/core/filter.c:1900:52: expected restricted __be32 [usertype] from
net/core/filter.c:1900:52: got unsigned long long [unsigned] [usertype] from
net/core/filter.c:1900:58: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 [usertype] to @@ got unsigned lonrestricted __be32 [usertype] to @@
net/core/filter.c:1900:58: expected restricted __be32 [usertype] to
net/core/filter.c:1900:58: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1946:28: sparse: incorrect type in return expression (different base types) @@ expected unsigned long long @@ got nsigned long long @@
net/core/filter.c:1946:28: expected unsigned long long
net/core/filter.c:1946:28: got restricted __wsum
net/core/filter.c:1968:35: sparse: incorrect type in return expression (different base types) @@ expected unsigned long long @@ got restricted unsigned long long @@
net/core/filter.c:1968:35: expected unsigned long long
net/core/filter.c:1968:35: got restricted __wsum [usertype] csum
>> net/core/filter.c:3174:5: sparse: symbol 'xdp_do_redirect_slow' was not declared. Should it be static?
net/core/filter.c:3914:41: sparse: expression using sizeof(void)
net/core/filter.c:3918:41: sparse: expression using sizeof(void)
net/core/filter.c:3922:46: sparse: expression using sizeof(void)
net/core/filter.c:3922:46: sparse: expression using sizeof(void)
net/core/filter.c:3990:47: sparse: expression using sizeof(void)
net/core/filter.c:4213:17: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] spi @@ got unsigned int [unsigned] [usertype] spi @@
net/core/filter.c:4213:17: expected unsigned int [unsigned] [usertype] spi
net/core/filter.c:4213:17: got restricted __be32 const [usertype] spi
net/core/filter.c:4221:33: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] remote_ipv4 @@ got unsigned int [unsigned] [usertype] remote_ipv4 @@
net/core/filter.c:4221:33: expected unsigned int [unsigned] [usertype] remote_ipv4
net/core/filter.c:4221:33: got restricted __be32 const [usertype] a4
net/core/filter.c:5447:27: sparse: subtraction of functions? Share your drugs
net/core/filter.c:5450:27: sparse: subtraction of functions? Share your drugs
net/core/filter.c:5453:27: sparse: subtraction of functions? Share your drugs
include/linux/slab.h:631:13: sparse: call with no type!
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply
* Re: [PATCH RFC net-next 18/18] net/ipv4: Optimization for fib_info lookup
From: David Ahern @ 2018-09-04 15:27 UTC (permalink / raw)
To: Stephen Hemminger, dsahern; +Cc: netdev, roopa, sharpd, idosch, davem
In-Reply-To: <20180901134334.5fc199fb@xeon-e3>
On 9/1/18 2:43 PM, Stephen Hemminger wrote:
> On Fri, 31 Aug 2018 17:49:53 -0700
> dsahern@kernel.org wrote:
>
>> +static inline unsigned int fib_info_hashfn_cfg(const struct fib_config *cfg)
>> +{
>> + unsigned int mask = (fib_info_hash_size - 1);
>> + unsigned int val = 0;
>> +
>> + val ^= (cfg->fc_protocol << 8) | cfg->fc_scope;
>
> Why do assignment to 0 than do initial xor?
> Why not instead just do assignment in the first statement which would be clearer.
>
Side effect of copy-paste-adjust of the original. Will fix for the next
rfc (really need to not have 2 versions of the hashfn; need to think
through it).
^ permalink raw reply
* [PATCH net-next v2 0/9] rtnetlink: add IFA_TARGET_NETNSID for RTM_GETADDR
From: Christian Brauner @ 2018-09-04 19:53 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: davem, kuznet, yoshfuji, pombredanne, kstewart, gregkh, dsahern,
fw, ktkhai, lucien.xin, jakub.kicinski, jbenc, nicolas.dichtel,
Christian Brauner
Hey,
# v2 introduction:
This iteration should mainly addresses the suggestion to use
IFA_TARGET_NETNSID as the property name. Additionally, an an alias for
the already existing IFLA_IF_NETNSID property is added.
Note that two additional cleanup patches (8\9 and 9\9) were added to
address concerns raised that passing more than 6 arguments to a function
will cause additional variables to be pushed onto the stack instead of
being placed into registers. The way I addressed this is by introducing
two new struct inet{6}_fill_args that are used to pass common
information down to inet{6}_fill_if*() functions shortening all those
functions to three pointer arguments.
If this is something more people than Kirill find useful they can be
kept if not they can simply be dropped in later iterations of this
series or when merging.
Here is a short overview:
1. Rename from IFA_IF_NETNSID to IFA_TARGET_NETNSID.
2. Add IFLA_TARGET_NETNSID as an alias for IFA_IFLA_NETNSID and switch
all occurrences over to the new alias.
3. Add inet4_fill_args struct to avoid passing more than 6 arguments in
inet_fill_if*() functions.
4. Add inet6_fill_args struct to avoid passing more than 6 arguments in
inet_fill_if*() functions.
# v1 introduction:
The only functional change is the export of rtnl_get_net_ns_capable()
which is needed in case ipv6 is built as a module.
Note, I did not change the property name to IFA_TARGET_NSID as there was
no clear agreement what would be preferred. My personal preference is to
keep the IFA_IF_NETNSID name because it aligns naturally with the
IFLA_IF_NETNSID property for RTM_*LINK requests. Jiri seems to prefer
this name too.
However, if there is agreement that another property name makes more
sense I'm happy to send a v2 that changes this.
## Performance:
To test this patchset I performed 1 million getifaddrs() requests
against a network namespace containing 5 interfaces (lo, eth{0-4}). The
first test used a network namespace aware getifaddrs() implementation I
wrote and the second test used the traditional setns() + getifaddrs()
method. The results show that this patchsets allows userspace to cut
retrieval time in half:
1. netns_getifaddrs(): 82 microseconds
2. setns() + getifaddrs(): 162 microseconds
# v0 introduction:
A while back we introduced and enabled IFLA_IF_NETNSID in
RTM_{DEL,GET,NEW}LINK requests (cf. [1], [2], [3], [4], [5]). This has led
to signficant performance increases since it allows userspace to avoid
taking the hit of a setns(netns_fd, CLONE_NEWNET), then getting the
interfaces from the netns associated with the netns_fd. Especially when a
lot of network namespaces are in use, using setns() becomes increasingly
problematic when performance matters.
Usually, RTML_GETLINK requests are followed by RTM_GETADDR requests (cf.
getifaddrs() style functions and friends). But currently, RTM_GETADDR
requests do not support a similar property like IFLA_IF_NETNSID for
RTM_*LINK requests.
This is problematic since userspace can retrieve interfaces from another
network namespace by sending a IFLA_IF_NETNSID property along but
RTM_GETLINK request but is still forced to use the legacy setns() style of
retrieving interfaces in RTM_GETADDR requests.
The goal of this series is to make it possible to perform RTM_GETADDR
requests on different network namespaces. To this end a new IFA_IF_NETNSID
property for RTM_*ADDR requests is introduced. It can be used to send a
network namespace identifier along in RTM_*ADDR requests. The network
namespace identifier will be used to retrieve the target network namespace
in which the request is supposed to be fulfilled. This aligns the behavior
of RTM_*ADDR requests with the behavior of RTM_*LINK requests.
## Security:
- The caller must have assigned a valid network namespace identifier for
the target network namespace.
- The caller must have CAP_NET_ADMIN in the owning user namespace of the
target network namespace.
Thanks!
Christian
[1]: commit 7973bfd8758d ("rtnetlink: remove check for IFLA_IF_NETNSID")
[2]: commit 5bb8ed075428 ("rtnetlink: enable IFLA_IF_NETNSID for RTM_NEWLINK")
[3]: commit b61ad68a9fe8 ("rtnetlink: enable IFLA_IF_NETNSID for RTM_DELLINK")
[4]: commit c310bfcb6e1b ("rtnetlink: enable IFLA_IF_NETNSID for RTM_SETLINK")
[5]: commit 7c4f63ba8243 ("rtnetlink: enable IFLA_IF_NETNSID in do_setlink()")
Christian Brauner (9):
rtnetlink: add rtnl_get_net_ns_capable()
if_addr: add IFA_TARGET_NETNSID
ipv4: enable IFA_TARGET_NETNSID for RTM_GETADDR
ipv6: enable IFA_TARGET_NETNSID for RTM_GETADDR
rtnetlink: move type calculation out of loop
if_link: add IFLA_TARGET_NETNSID alias
rtnetlink: s/IFLA_IF_NETNSID/IFLA_TARGET_NETNSID/g
ipv4: add inet_fill_args
ipv6: add inet6_fill_args
include/net/rtnetlink.h | 1 +
include/uapi/linux/if_addr.h | 1 +
include/uapi/linux/if_link.h | 1 +
net/core/rtnetlink.c | 51 +++++++-----
net/ipv4/devinet.c | 62 +++++++++++---
net/ipv6/addrconf.c | 126 ++++++++++++++++++++++-------
tools/include/uapi/linux/if_link.h | 1 +
7 files changed, 180 insertions(+), 63 deletions(-)
--
2.17.1
^ permalink raw reply
* [PATCH net-next v2 1/9] rtnetlink: add rtnl_get_net_ns_capable()
From: Christian Brauner @ 2018-09-04 19:53 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: davem, kuznet, yoshfuji, pombredanne, kstewart, gregkh, dsahern,
fw, ktkhai, lucien.xin, jakub.kicinski, jbenc, nicolas.dichtel,
Christian Brauner
In-Reply-To: <20180904195355.4695-1-christian@brauner.io>
get_target_net() will be used in follow-up patches in ipv{4,6} codepaths to
retrieve network namespaces based on network namespace identifiers. So
remove the static declaration and export in the rtnetlink header. Also,
rename it to rtnl_get_net_ns_capable() to make it obvious what this
function is doing.
Export rtnl_get_net_ns_capable() so it can be used when ipv6 is built as
a module.
Signed-off-by: Christian Brauner <christian@brauner.io>
---
v1->v2:
- unchanged
v0->v1:
- export rtnl_get_net_ns_capable().
Kbuild reported a build failure when ipv6 is built as a module. This was
caused by rtnl_get_net_ns_capable() not being exported. Fix this by
exporting it.
---
include/net/rtnetlink.h | 1 +
net/core/rtnetlink.c | 17 +++++++++++++----
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h
index 0bbaa5488423..cf26e5aacac4 100644
--- a/include/net/rtnetlink.h
+++ b/include/net/rtnetlink.h
@@ -165,6 +165,7 @@ int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm);
int rtnl_nla_parse_ifla(struct nlattr **tb, const struct nlattr *head, int len,
struct netlink_ext_ack *exterr);
+struct net *rtnl_get_net_ns_capable(struct sock *sk, int netnsid);
#define MODULE_ALIAS_RTNL_LINK(kind) MODULE_ALIAS("rtnl-link-" kind)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 24431e578310..30645d9a9801 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1841,7 +1841,15 @@ static bool link_dump_filtered(struct net_device *dev,
return false;
}
-static struct net *get_target_net(struct sock *sk, int netnsid)
+/**
+ * rtnl_get_net_ns_capable - Get netns if sufficiently privileged.
+ * @sk: netlink socket
+ * @netnsid: network namespace identifier
+ *
+ * Returns the network namespace identified by netnsid on success or an error
+ * pointer on failure.
+ */
+struct net *rtnl_get_net_ns_capable(struct sock *sk, int netnsid)
{
struct net *net;
@@ -1858,6 +1866,7 @@ static struct net *get_target_net(struct sock *sk, int netnsid)
}
return net;
}
+EXPORT_SYMBOL_GPL(rtnl_get_net_ns_capable);
static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
{
@@ -1893,7 +1902,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
ifla_policy, NULL) >= 0) {
if (tb[IFLA_IF_NETNSID]) {
netnsid = nla_get_s32(tb[IFLA_IF_NETNSID]);
- tgt_net = get_target_net(skb->sk, netnsid);
+ tgt_net = rtnl_get_net_ns_capable(skb->sk, netnsid);
if (IS_ERR(tgt_net)) {
tgt_net = net;
netnsid = -1;
@@ -2761,7 +2770,7 @@ static int rtnl_dellink(struct sk_buff *skb, struct nlmsghdr *nlh,
if (tb[IFLA_IF_NETNSID]) {
netnsid = nla_get_s32(tb[IFLA_IF_NETNSID]);
- tgt_net = get_target_net(NETLINK_CB(skb).sk, netnsid);
+ tgt_net = rtnl_get_net_ns_capable(NETLINK_CB(skb).sk, netnsid);
if (IS_ERR(tgt_net))
return PTR_ERR(tgt_net);
}
@@ -3171,7 +3180,7 @@ static int rtnl_getlink(struct sk_buff *skb, struct nlmsghdr *nlh,
if (tb[IFLA_IF_NETNSID]) {
netnsid = nla_get_s32(tb[IFLA_IF_NETNSID]);
- tgt_net = get_target_net(NETLINK_CB(skb).sk, netnsid);
+ tgt_net = rtnl_get_net_ns_capable(NETLINK_CB(skb).sk, netnsid);
if (IS_ERR(tgt_net))
return PTR_ERR(tgt_net);
}
--
2.17.1
^ permalink raw reply related
* [PATCH net-next v2 4/9] ipv6: enable IFA_TARGET_NETNSID for RTM_GETADDR
From: Christian Brauner @ 2018-09-04 19:53 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: davem, kuznet, yoshfuji, pombredanne, kstewart, gregkh, dsahern,
fw, ktkhai, lucien.xin, jakub.kicinski, jbenc, nicolas.dichtel,
Christian Brauner
In-Reply-To: <20180904195355.4695-1-christian@brauner.io>
- Backwards Compatibility:
If userspace wants to determine whether ipv6 RTM_GETADDR requests
support the new IFA_TARGET_NETNSID property it should verify that the
reply includes the IFA_TARGET_NETNSID property. If it does not
userspace should assume that IFA_TARGET_NETNSID is not supported for
ipv6 RTM_GETADDR requests on this kernel.
- From what I gather from current userspace tools that make use of
RTM_GETADDR requests some of them pass down struct ifinfomsg when they
should actually pass down struct ifaddrmsg. To not break existing
tools that pass down the wrong struct we will do the same as for
RTM_GETLINK | NLM_F_DUMP requests and not error out when the
nlmsg_parse() fails.
- Security:
Callers must have CAP_NET_ADMIN in the owning user namespace of the
target network namespace.
Signed-off-by: Christian Brauner <christian@brauner.io>
---
v1->v2:
- rename from IFA_IF_NETNSID to IFA_TARGET_NETNSID
v0->v1:
- unchanged
---
net/ipv6/addrconf.c | 73 +++++++++++++++++++++++++++++++++++----------
1 file changed, 58 insertions(+), 15 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index d51a8c0b3372..ebfeb64ac67b 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -4491,6 +4491,7 @@ static const struct nla_policy ifa_ipv6_policy[IFA_MAX+1] = {
[IFA_CACHEINFO] = { .len = sizeof(struct ifa_cacheinfo) },
[IFA_FLAGS] = { .len = sizeof(u32) },
[IFA_RT_PRIORITY] = { .len = sizeof(u32) },
+ [IFA_TARGET_NETNSID] = { .type = NLA_S32 },
};
static int
@@ -4794,7 +4795,8 @@ static inline int inet6_ifaddr_msgsize(void)
}
static int inet6_fill_ifaddr(struct sk_buff *skb, struct inet6_ifaddr *ifa,
- u32 portid, u32 seq, int event, unsigned int flags)
+ u32 portid, u32 seq, int event, unsigned int flags,
+ int netnsid)
{
struct nlmsghdr *nlh;
u32 preferred, valid;
@@ -4806,6 +4808,9 @@ static int inet6_fill_ifaddr(struct sk_buff *skb, struct inet6_ifaddr *ifa,
put_ifaddrmsg(nlh, ifa->prefix_len, ifa->flags, rt_scope(ifa->scope),
ifa->idev->dev->ifindex);
+ if (netnsid >= 0 && nla_put_s32(skb, IFA_TARGET_NETNSID, netnsid))
+ goto error;
+
if (!((ifa->flags&IFA_F_PERMANENT) &&
(ifa->prefered_lft == INFINITY_LIFE_TIME))) {
preferred = ifa->prefered_lft;
@@ -4855,7 +4860,8 @@ static int inet6_fill_ifaddr(struct sk_buff *skb, struct inet6_ifaddr *ifa,
}
static int inet6_fill_ifmcaddr(struct sk_buff *skb, struct ifmcaddr6 *ifmca,
- u32 portid, u32 seq, int event, u16 flags)
+ u32 portid, u32 seq, int event, u16 flags,
+ int netnsid)
{
struct nlmsghdr *nlh;
u8 scope = RT_SCOPE_UNIVERSE;
@@ -4868,6 +4874,9 @@ static int inet6_fill_ifmcaddr(struct sk_buff *skb, struct ifmcaddr6 *ifmca,
if (!nlh)
return -EMSGSIZE;
+ if (netnsid >= 0 && nla_put_s32(skb, IFA_TARGET_NETNSID, netnsid))
+ return -EMSGSIZE;
+
put_ifaddrmsg(nlh, 128, IFA_F_PERMANENT, scope, ifindex);
if (nla_put_in6_addr(skb, IFA_MULTICAST, &ifmca->mca_addr) < 0 ||
put_cacheinfo(skb, ifmca->mca_cstamp, ifmca->mca_tstamp,
@@ -4881,7 +4890,8 @@ static int inet6_fill_ifmcaddr(struct sk_buff *skb, struct ifmcaddr6 *ifmca,
}
static int inet6_fill_ifacaddr(struct sk_buff *skb, struct ifacaddr6 *ifaca,
- u32 portid, u32 seq, int event, unsigned int flags)
+ u32 portid, u32 seq, int event,
+ unsigned int flags, int netnsid)
{
struct net_device *dev = fib6_info_nh_dev(ifaca->aca_rt);
int ifindex = dev ? dev->ifindex : 1;
@@ -4895,6 +4905,9 @@ static int inet6_fill_ifacaddr(struct sk_buff *skb, struct ifacaddr6 *ifaca,
if (!nlh)
return -EMSGSIZE;
+ if (netnsid >= 0 && nla_put_s32(skb, IFA_TARGET_NETNSID, netnsid))
+ return -EMSGSIZE;
+
put_ifaddrmsg(nlh, 128, IFA_F_PERMANENT, scope, ifindex);
if (nla_put_in6_addr(skb, IFA_ANYCAST, &ifaca->aca_addr) < 0 ||
put_cacheinfo(skb, ifaca->aca_cstamp, ifaca->aca_tstamp,
@@ -4916,7 +4929,7 @@ enum addr_type_t {
/* called with rcu_read_lock() */
static int in6_dump_addrs(struct inet6_dev *idev, struct sk_buff *skb,
struct netlink_callback *cb, enum addr_type_t type,
- int s_ip_idx, int *p_ip_idx)
+ int s_ip_idx, int *p_ip_idx, int netnsid)
{
struct ifmcaddr6 *ifmca;
struct ifacaddr6 *ifaca;
@@ -4936,7 +4949,7 @@ static int in6_dump_addrs(struct inet6_dev *idev, struct sk_buff *skb,
NETLINK_CB(cb->skb).portid,
cb->nlh->nlmsg_seq,
RTM_NEWADDR,
- NLM_F_MULTI);
+ NLM_F_MULTI, netnsid);
if (err < 0)
break;
nl_dump_check_consistent(cb, nlmsg_hdr(skb));
@@ -4953,7 +4966,7 @@ static int in6_dump_addrs(struct inet6_dev *idev, struct sk_buff *skb,
NETLINK_CB(cb->skb).portid,
cb->nlh->nlmsg_seq,
RTM_GETMULTICAST,
- NLM_F_MULTI);
+ NLM_F_MULTI, netnsid);
if (err < 0)
break;
}
@@ -4968,7 +4981,7 @@ static int in6_dump_addrs(struct inet6_dev *idev, struct sk_buff *skb,
NETLINK_CB(cb->skb).portid,
cb->nlh->nlmsg_seq,
RTM_GETANYCAST,
- NLM_F_MULTI);
+ NLM_F_MULTI, netnsid);
if (err < 0)
break;
}
@@ -4985,6 +4998,9 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb,
enum addr_type_t type)
{
struct net *net = sock_net(skb->sk);
+ struct nlattr *tb[IFA_MAX+1];
+ struct net *tgt_net = net;
+ int netnsid = -1;
int h, s_h;
int idx, ip_idx;
int s_idx, s_ip_idx;
@@ -4996,11 +5012,22 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb,
s_idx = idx = cb->args[1];
s_ip_idx = ip_idx = cb->args[2];
+ if (nlmsg_parse(cb->nlh, sizeof(struct ifaddrmsg), tb, IFA_MAX,
+ ifa_ipv6_policy, NULL) >= 0) {
+ if (tb[IFA_TARGET_NETNSID]) {
+ netnsid = nla_get_s32(tb[IFA_TARGET_NETNSID]);
+
+ tgt_net = rtnl_get_net_ns_capable(skb->sk, netnsid);
+ if (IS_ERR(tgt_net))
+ return PTR_ERR(tgt_net);
+ }
+ }
+
rcu_read_lock();
- cb->seq = atomic_read(&net->ipv6.dev_addr_genid) ^ net->dev_base_seq;
+ cb->seq = atomic_read(&tgt_net->ipv6.dev_addr_genid) ^ tgt_net->dev_base_seq;
for (h = s_h; h < NETDEV_HASHENTRIES; h++, s_idx = 0) {
idx = 0;
- head = &net->dev_index_head[h];
+ head = &tgt_net->dev_index_head[h];
hlist_for_each_entry_rcu(dev, head, index_hlist) {
if (idx < s_idx)
goto cont;
@@ -5012,7 +5039,7 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb,
goto cont;
if (in6_dump_addrs(idev, skb, cb, type,
- s_ip_idx, &ip_idx) < 0)
+ s_ip_idx, &ip_idx, netnsid) < 0)
goto done;
cont:
idx++;
@@ -5023,6 +5050,8 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb,
cb->args[0] = h;
cb->args[1] = idx;
cb->args[2] = ip_idx;
+ if (netnsid >= 0)
+ put_net(tgt_net);
return skb->len;
}
@@ -5053,12 +5082,14 @@ static int inet6_rtm_getaddr(struct sk_buff *in_skb, struct nlmsghdr *nlh,
struct netlink_ext_ack *extack)
{
struct net *net = sock_net(in_skb->sk);
+ struct net *tgt_net = net;
struct ifaddrmsg *ifm;
struct nlattr *tb[IFA_MAX+1];
struct in6_addr *addr = NULL, *peer;
struct net_device *dev = NULL;
struct inet6_ifaddr *ifa;
struct sk_buff *skb;
+ int netnsid = -1;
int err;
err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFA_MAX, ifa_ipv6_policy,
@@ -5066,15 +5097,24 @@ static int inet6_rtm_getaddr(struct sk_buff *in_skb, struct nlmsghdr *nlh,
if (err < 0)
return err;
+ if (tb[IFA_TARGET_NETNSID]) {
+ netnsid = nla_get_s32(tb[IFA_TARGET_NETNSID]);
+
+ tgt_net = rtnl_get_net_ns_capable(NETLINK_CB(in_skb).sk,
+ netnsid);
+ if (IS_ERR(tgt_net))
+ return PTR_ERR(tgt_net);
+ }
+
addr = extract_addr(tb[IFA_ADDRESS], tb[IFA_LOCAL], &peer);
if (!addr)
return -EINVAL;
ifm = nlmsg_data(nlh);
if (ifm->ifa_index)
- dev = dev_get_by_index(net, ifm->ifa_index);
+ dev = dev_get_by_index(tgt_net, ifm->ifa_index);
- ifa = ipv6_get_ifaddr(net, addr, dev, 1);
+ ifa = ipv6_get_ifaddr(tgt_net, addr, dev, 1);
if (!ifa) {
err = -EADDRNOTAVAIL;
goto errout;
@@ -5087,19 +5127,22 @@ static int inet6_rtm_getaddr(struct sk_buff *in_skb, struct nlmsghdr *nlh,
}
err = inet6_fill_ifaddr(skb, ifa, NETLINK_CB(in_skb).portid,
- nlh->nlmsg_seq, RTM_NEWADDR, 0);
+ nlh->nlmsg_seq, RTM_NEWADDR, 0, netnsid);
if (err < 0) {
/* -EMSGSIZE implies BUG in inet6_ifaddr_msgsize() */
WARN_ON(err == -EMSGSIZE);
kfree_skb(skb);
goto errout_ifa;
}
- err = rtnl_unicast(skb, net, NETLINK_CB(in_skb).portid);
+ err = rtnl_unicast(skb, tgt_net, NETLINK_CB(in_skb).portid);
errout_ifa:
in6_ifa_put(ifa);
errout:
if (dev)
dev_put(dev);
+ if (netnsid >= 0)
+ put_net(tgt_net);
+
return err;
}
@@ -5113,7 +5156,7 @@ static void inet6_ifa_notify(int event, struct inet6_ifaddr *ifa)
if (!skb)
goto errout;
- err = inet6_fill_ifaddr(skb, ifa, 0, 0, event, 0);
+ err = inet6_fill_ifaddr(skb, ifa, 0, 0, event, 0, -1);
if (err < 0) {
/* -EMSGSIZE implies BUG in inet6_ifaddr_msgsize() */
WARN_ON(err == -EMSGSIZE);
--
2.17.1
^ permalink raw reply related
* [PATCH net-next v2 6/9] if_link: add IFLA_TARGET_NETNSID alias
From: Christian Brauner @ 2018-09-04 19:53 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: davem, kuznet, yoshfuji, pombredanne, kstewart, gregkh, dsahern,
fw, ktkhai, lucien.xin, jakub.kicinski, jbenc, nicolas.dichtel,
Christian Brauner
In-Reply-To: <20180904195355.4695-1-christian@brauner.io>
This adds IFLA_TARGET_NETNSID as an alias for IFLA_IF_NETNSID for
RTM_*LINK requests.
The new name is clearer and also aligns with the newly introduced
IFA_TARGET_NETNSID propert for RTM_*ADDR requests.
Signed-off-by: Christian Brauner <christian@brauner.io>
Suggested-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Jiri Benc <jbenc@redhat.com>
---
v1->v2:
- patch added
v0->v1:
- patch not present
---
include/uapi/linux/if_link.h | 1 +
tools/include/uapi/linux/if_link.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index 43391e2d1153..29d49b989acd 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -161,6 +161,7 @@ enum {
IFLA_EVENT,
IFLA_NEW_NETNSID,
IFLA_IF_NETNSID,
+ IFLA_TARGET_NETNSID = IFLA_IF_NETNSID, /* new alias */
IFLA_CARRIER_UP_COUNT,
IFLA_CARRIER_DOWN_COUNT,
IFLA_NEW_IFINDEX,
diff --git a/tools/include/uapi/linux/if_link.h b/tools/include/uapi/linux/if_link.h
index cf01b6824244..1c73d63068b1 100644
--- a/tools/include/uapi/linux/if_link.h
+++ b/tools/include/uapi/linux/if_link.h
@@ -161,6 +161,7 @@ enum {
IFLA_EVENT,
IFLA_NEW_NETNSID,
IFLA_IF_NETNSID,
+ IFLA_TARGET_NETNSID = IFLA_IF_NETNSID, /* new alias */
IFLA_CARRIER_UP_COUNT,
IFLA_CARRIER_DOWN_COUNT,
IFLA_NEW_IFINDEX,
--
2.17.1
^ permalink raw reply related
* [PATCH net-next v2 8/9] ipv4: add inet_fill_args
From: Christian Brauner @ 2018-09-04 19:53 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: davem, kuznet, yoshfuji, pombredanne, kstewart, gregkh, dsahern,
fw, ktkhai, lucien.xin, jakub.kicinski, jbenc, nicolas.dichtel,
Christian Brauner
In-Reply-To: <20180904195355.4695-1-christian@brauner.io>
inet_fill_ifaddr() already took 6 arguments which meant the 7th argument
would need to be pushed onto the stack on x86.
Add a new struct inet_fill_args which holds common information passed
to inet_fill_ifaddr() and shortens the function to three pointer arguments.
Signed-off-by: Christian Brauner <christian@brauner.io>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>
---
v1->v2:
- patch added
v0->v1:
- patch not present
---
net/ipv4/devinet.c | 48 +++++++++++++++++++++++++++++++---------------
1 file changed, 33 insertions(+), 15 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 5cb849300b81..44d931a3cd50 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -103,6 +103,14 @@ static const struct nla_policy ifa_ipv4_policy[IFA_MAX+1] = {
[IFA_TARGET_NETNSID] = { .type = NLA_S32 },
};
+struct inet_fill_args {
+ u32 portid;
+ u32 seq;
+ int event;
+ unsigned int flags;
+ int netnsid;
+};
+
#define IN4_ADDR_HSIZE_SHIFT 8
#define IN4_ADDR_HSIZE (1U << IN4_ADDR_HSIZE_SHIFT)
@@ -1585,14 +1593,14 @@ static int put_cacheinfo(struct sk_buff *skb, unsigned long cstamp,
}
static int inet_fill_ifaddr(struct sk_buff *skb, struct in_ifaddr *ifa,
- u32 portid, u32 seq, int event, unsigned int flags,
- int netnsid)
+ struct inet_fill_args *args)
{
struct ifaddrmsg *ifm;
struct nlmsghdr *nlh;
u32 preferred, valid;
- nlh = nlmsg_put(skb, portid, seq, event, sizeof(*ifm), flags);
+ nlh = nlmsg_put(skb, args->portid, args->seq, args->event, sizeof(*ifm),
+ args->flags);
if (!nlh)
return -EMSGSIZE;
@@ -1603,7 +1611,8 @@ static int inet_fill_ifaddr(struct sk_buff *skb, struct in_ifaddr *ifa,
ifm->ifa_scope = ifa->ifa_scope;
ifm->ifa_index = ifa->ifa_dev->dev->ifindex;
- if (netnsid >= 0 && nla_put_s32(skb, IFA_TARGET_NETNSID, netnsid))
+ if (args->netnsid >= 0 &&
+ nla_put_s32(skb, IFA_TARGET_NETNSID, args->netnsid))
goto nla_put_failure;
if (!(ifm->ifa_flags & IFA_F_PERMANENT)) {
@@ -1652,10 +1661,16 @@ static int inet_fill_ifaddr(struct sk_buff *skb, struct in_ifaddr *ifa,
static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb)
{
+ struct inet_fill_args fillargs = {
+ .portid = NETLINK_CB(cb->skb).portid,
+ .seq = cb->nlh->nlmsg_seq,
+ .event = RTM_NEWADDR,
+ .flags = NLM_F_MULTI,
+ .netnsid = -1,
+ };
struct net *net = sock_net(skb->sk);
struct nlattr *tb[IFA_MAX+1];
struct net *tgt_net = net;
- int netnsid = -1;
int h, s_h;
int idx, s_idx;
int ip_idx, s_ip_idx;
@@ -1671,9 +1686,10 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb)
if (nlmsg_parse(cb->nlh, sizeof(struct ifaddrmsg), tb, IFA_MAX,
ifa_ipv4_policy, NULL) >= 0) {
if (tb[IFA_TARGET_NETNSID]) {
- netnsid = nla_get_s32(tb[IFA_TARGET_NETNSID]);
+ fillargs.netnsid = nla_get_s32(tb[IFA_TARGET_NETNSID]);
- tgt_net = rtnl_get_net_ns_capable(skb->sk, netnsid);
+ tgt_net = rtnl_get_net_ns_capable(skb->sk,
+ fillargs.netnsid);
if (IS_ERR(tgt_net))
return PTR_ERR(tgt_net);
}
@@ -1698,11 +1714,7 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb)
ifa = ifa->ifa_next, ip_idx++) {
if (ip_idx < s_ip_idx)
continue;
- if (inet_fill_ifaddr(skb, ifa,
- NETLINK_CB(cb->skb).portid,
- cb->nlh->nlmsg_seq,
- RTM_NEWADDR, NLM_F_MULTI,
- netnsid) < 0) {
+ if (inet_fill_ifaddr(skb, ifa, &fillargs) < 0) {
rcu_read_unlock();
goto done;
}
@@ -1718,7 +1730,7 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb)
cb->args[0] = h;
cb->args[1] = idx;
cb->args[2] = ip_idx;
- if (netnsid >= 0)
+ if (fillargs.netnsid >= 0)
put_net(tgt_net);
return skb->len;
@@ -1727,8 +1739,14 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb)
static void rtmsg_ifa(int event, struct in_ifaddr *ifa, struct nlmsghdr *nlh,
u32 portid)
{
+ struct inet_fill_args fillargs = {
+ .portid = portid,
+ .seq = nlh ? nlh->nlmsg_seq : 0,
+ .event = event,
+ .flags = 0,
+ .netnsid = -1,
+ };
struct sk_buff *skb;
- u32 seq = nlh ? nlh->nlmsg_seq : 0;
int err = -ENOBUFS;
struct net *net;
@@ -1737,7 +1755,7 @@ static void rtmsg_ifa(int event, struct in_ifaddr *ifa, struct nlmsghdr *nlh,
if (!skb)
goto errout;
- err = inet_fill_ifaddr(skb, ifa, portid, seq, event, 0, -1);
+ err = inet_fill_ifaddr(skb, ifa, &fillargs);
if (err < 0) {
/* -EMSGSIZE implies BUG in inet_nlmsg_size() */
WARN_ON(err == -EMSGSIZE);
--
2.17.1
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox