public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: nisse@lysator.liu.se (Niels Möller)
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: TCP_MAXSEG vs TCP/generic segmentation offload (tso/gso)
Date: Thu, 25 Nov 2010 16:09:49 +0100	[thread overview]
Message-ID: <nnaakxqw1u.fsf@stalhein.lysator.liu.se> (raw)
In-Reply-To: <1290695253.2858.336.camel@edumazet-laptop> (Eric Dumazet's message of "Thu, 25 Nov 2010 15:27:33 +0100")

Eric Dumazet <eric.dumazet@gmail.com> writes:

> So... there is no 'bug', unless you trust too much tcpdump output.

I really expected tcpdump -e to display the actual values in the link
layer header, including the correct frame size. It's more than a bit
confusing if that is not the case...

In the future, I will try to remember to always run tcpdump on a network
node which (i) is different from the sending one, and (ii) has GRO
disabled (and hence will discard packets if it has trouble processing
them all, rather than coalesce them).

What about the TCP_MAXSEG socket option, should that work? From a quick
look at driver source code, I could only see the handling of the
per-interface MTU, no per-socket segment size.

Thanks for the quick reply,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.

  reply	other threads:[~2010-11-25 15:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <nny68hqzzn.fsf@stalhein.lysator.liu.se>
2010-11-25 14:27 ` TCP_MAXSEG vs TCP/generic segmentation offload (tso/gso) Eric Dumazet
2010-11-25 15:09   ` Niels Möller [this message]
2010-11-25 15:18     ` Eric Dumazet
2010-11-25 16:25       ` Niels Möller
2010-11-25 16:44         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nnaakxqw1u.fsf@stalhein.lysator.liu.se \
    --to=nisse@lysator.liu.se \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox