From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Christopher Hall" Subject: Re: [RFC v5 5/6] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping Date: Wed, 06 Jan 2016 17:42:53 -0800 Message-ID: References: <1451911523-8534-1-git-send-email-christopher.s.hall@intel.com> <1451911523-8534-6-git-send-email-christopher.s.hall@intel.com> <20160105152731.GA24372@netboy> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Cc: tglx@linutronix.de, mingo@redhat.com, john.stultz@linaro.org, hpa@zytor.com, jeffrey.t.kirsher@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, kevin.b.stanton@intel.com To: "Richard Cochran" Return-path: In-Reply-To: <20160105152731.GA24372@netboy> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Richard, This all sounds fine. Thanks for the feedback. I'll roll this into the next patchset. Chris On Tue, 05 Jan 2016 07:27:32 -0800, Richard Cochran wrote: > On Mon, Jan 04, 2016 at 04:45:22AM -0800, Christopher S. Hall wrote: >> + case PTP_SYS_OFFSET_PRECISE: >> + if (!ptp->info->getsynctime) { >> + err = -EINVAL; > > -EOPNOTSUPP would be better here. > >> + precise_offset.sys_real.sec = >> + div_u64_rem(ktime_to_ns(xtstamp.sys_realtime), >> + NSEC_PER_SEC, &rem); >> + precise_offset.sys_real.nsec = rem; > > How about this instead: > > ts = ktime_to_timespec64(xtstamp.sys_realtime); > precise_offset.sys_real.sec = ts.tv_sec; > precise_offset.sys_real.nsec = ts.tv_nsec; > >> + precise_offset.sys_raw.sec = >> + div_u64_rem(ktime_to_ns(xtstamp.sys_monoraw), >> + NSEC_PER_SEC, &rem); >> + precise_offset.sys_raw.nsec = rem; >> + precise_offset.dev.sec = >> + div_u64_rem(ktime_to_ns(xtstamp.device), NSEC_PER_SEC, >> + &rem); >> + precise_offset.dev.nsec = rem; > > And for these as well. > > Thanks, > Richard