From mboxrd@z Thu Jan 1 00:00:00 1970 From: Changli Gao Subject: Re: [PATCH v4] net: batch skb dequeueing from softnet input_pkt_queue Date: Thu, 22 Apr 2010 14:30:33 +0800 Message-ID: References: <1271915513-2966-1-git-send-email-xiaosuo@gmail.com> <20100421231843.4c284991@nehalam> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "David S. Miller" , jamal , Tom Herbert , Eric Dumazet , netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mail-iw0-f178.google.com ([209.85.223.178]:46180 "EHLO mail-iw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561Ab0DVGay convert rfc822-to-8bit (ORCPT ); Thu, 22 Apr 2010 02:30:54 -0400 Received: by iwn8 with SMTP id 8so1684756iwn.16 for ; Wed, 21 Apr 2010 23:30:53 -0700 (PDT) In-Reply-To: <20100421231843.4c284991@nehalam> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Apr 22, 2010 at 2:18 PM, Stephen Hemminger wrote: > On Thu, 22 Apr 2010 13:51:53 +0800 > Changli Gao wrote: > >> + =C2=A0 =C2=A0 struct sk_buff =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*in= put_pkt_queue_head; >> + =C2=A0 =C2=A0 struct sk_buff =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0**i= nput_pkt_queue_tailp; >> + =C2=A0 =C2=A0 unsigned int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= input_pkt_queue_len; >> + =C2=A0 =C2=A0 unsigned int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= process_queue_len; > > Why is opencoding a skb queue a step forward? > Just keep using sk_queue routines, just not the locked variants. > I want to keep the critical section of rps_lock() as small as possible to reduce the potential lock contention, when RPS is used. --=20 Regards=EF=BC=8C Changli Gao(xiaosuo@gmail.com)