From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erwan Velu Subject: Re: [PATCH] e100: expose broadcast_disabled as a module option Date: Mon, 26 Apr 2010 16:45:54 +0200 Message-ID: References: <20100423135816.23f5861f@nehalam> <20100423150207.7969c9f6@nehalam> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Jeff Kirsher , netdev , David Miller , linux-kernel@vger.kernel.org, jesse.brandeburg@intel.com, bruce.w.allan@intel.com, alexander.h.duyck@intel.com, peter.p.waskiewicz.jr@intel.com, john.ronciak@intel.com To: Stephen Hemminger Return-path: Received: from mail-bw0-f219.google.com ([209.85.218.219]:53303 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521Ab0DZOp4 (ORCPT ); Mon, 26 Apr 2010 10:45:56 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: 2010/4/26 Erwan Velu : After some research, here come my status : > Does any one you could help me understanding what should be the good way to > 1- enabled/disabled IFF_BROADCAST for a given interface Looks like the current code isn't taking care of a possible changing of IFF_BROADCAST. I can find some code in net/core/dev.c to handle MULTICAST or PROMISC but nothing for BROADCAST. do I have to implement one ? > 2- populate this changes to the driver Looks like I need then to add a .ndo_change_rx_flags function to manage this changes. Does someone confirm this is the way to go ?