From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Chavey Subject: Re: [PATCH 1/1] add ethtool loopback support Date: Fri, 9 Apr 2010 11:09:48 -0700 Message-ID: References: <1270751373.5055.22.camel@achroite.uk.solarflarecom.com> <1270755356.5055.23.camel@achroite.uk.solarflarecom.com> <4BBE78E2.2000709@garzik.org> <4BBF5D72.8010603@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ben Hutchings , davem@davemloft.net, netdev@vger.kernel.org, therbert@google.com To: Jeff Garzik Return-path: Received: from smtp-out.google.com ([216.239.44.51]:6212 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359Ab0DISKN convert rfc822-to-8bit (ORCPT ); Fri, 9 Apr 2010 14:10:13 -0400 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out.google.com with ESMTP id o39IAAK5021887 for ; Fri, 9 Apr 2010 11:10:10 -0700 Received: from gwb1 (gwb1.prod.google.com [10.200.2.1]) by wpaz1.hot.corp.google.com with ESMTP id o39IA9rN011959 for ; Fri, 9 Apr 2010 11:10:09 -0700 Received: by gwb1 with SMTP id 1so133032gwb.3 for ; Fri, 09 Apr 2010 11:10:09 -0700 (PDT) In-Reply-To: <4BBF5D72.8010603@garzik.org> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Apr 9, 2010 at 10:01 AM, Jeff Garzik wrote: > On 04/09/2010 12:43 PM, Laurent Chavey wrote: >> >> isn't the existing ETHTOOL_TEST ioctl use for something like self te= st ? >> >> the intent of this patch is to enable a mode whereby one could run >> netperf / iperf and other application =A0and have the packets sent a= nd >> received by the driver. > > I said "ethtool flags interface", which is ETHTOOL_[GS]FLAGS. > > ethtool private flags interface would also work, ETHTOOL_[GS]PFLAGS. > > Both are interfaces enabling user setting/clearing of 32 on/off switc= hes > (bits). agree, no need to patch > > =A0 =A0 =A0 =A0Jeff > > > > >