From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] bridge: avoid ptype_all packet handling Date: 03 Mar 2007 03:14:29 +0100 Message-ID: References: <45E67B04.2060702@linux-foundation.org> <20070228.232224.74746939.davem@davemloft.net> <45E6802C.2090708@linux-foundation.org> <20070228.233034.74746721.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: shemminger@linux-foundation.org, greearb@candelatech.com, bridge@linux-foundation.org, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail.suse.de ([195.135.220.2]:57753 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992856AbXCCBO6 (ORCPT ); Fri, 2 Mar 2007 20:14:58 -0500 In-Reply-To: <20070228.233034.74746721.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Miller writes: > > And in fact that effectively makes the new socket option > pointless, since it doesn't buy us anything since we have > to support the old stuff fully anyways. I don't think it's pointless because it would still allow newer DHCP clients to have less impact on other packets when they are active. This can matter when you have a system with multiple interfaces where DHCP doesn't get a address on one. That's pretty common with many x86 server boards because they come with two NICs by default but must people only plug the cable into one. However the distro installers run DHCP on all. When this happens all packets are always forced through ptype_all chains before being rejected by AF_PACKETs device bind, which adds some overhead to them. -Andi