From: Andi Kleen <ak@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: chas@cmf.nrl.navy.mil, netdev@vger.kernel.org, kkeil@suse.de,
kai.germaschewski@gmx.de, isdn4linux@listserv.isdn4linux.de,
mac@melware.de, markus.lidel@shadowconnect.com,
samuel@sortiz.org, Neela.Kolli@engenio.com,
linux-scsi@vger.kernel.org, Greg KH <greg@kroah.com>,
thomas@winischhofer.net
Subject: Re: [PATCH] Introduce BROKEN_ON_64BIT facility
Date: 02 Oct 2006 11:51:45 +0200 [thread overview]
Message-ID: <p737izjhwpa.fsf@verdi.suse.de> (raw)
In-Reply-To: <20061002045512.GA8835@havoc.gtf.org>
Jeff Garzik <jeff@garzik.org> writes:
> Add a broken-on-64bit option, similar to the existing broken-on-smp
> config option. This is just the first pass, marking the obvious
> candidates.
When I had this problem in the past I just used && !64BIT.
How is this new option different?
> config ISDN_CAPI_CAPI20
> tristate "CAPI2.0 /dev/capi support"
> - depends on ISDN_CAPI
> + depends on ISDN_CAPI && BROKEN_ON_64BIT
> help
> This option will provide the CAPI 2.0 interface to userspace
> applications via /dev/capi20. Applications should use the
> @@ -44,7 +44,7 @@ config ISDN_CAPI_CAPIFS
>
> config ISDN_CAPI_CAPIDRV
> tristate "CAPI2.0 capidrv interface support"
> - depends on ISDN_CAPI && ISDN_I4L
> + depends on ISDN_CAPI && ISDN_I4L && BROKEN_ON_64BIT
As discussed earlier ISDN is actually ok.
> diff --git a/drivers/message/i2o/Kconfig b/drivers/message/i2o/Kconfig
> index 6443392..0e135ce 100644
> --- a/drivers/message/i2o/Kconfig
> +++ b/drivers/message/i2o/Kconfig
> @@ -56,7 +56,7 @@ config I2O_EXT_ADAPTEC_DMA64
>
> config I2O_CONFIG
> tristate "I2O Configuration support"
> - depends on I2O
> + depends on I2O && BROKEN_ON_64BIT
> ---help---
> Say Y for support of the configuration interface for the I2O adapters.
AFAIK I2O got fixed too. Do you have any evidence that it is really
broken on 64bit?
-Andi
next prev parent reply other threads:[~2006-10-02 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-02 4:55 [PATCH] Introduce BROKEN_ON_64BIT facility Jeff Garzik
2006-10-02 9:51 ` Andi Kleen [this message]
2006-10-02 9:54 ` Jeff Garzik
2006-10-02 14:19 ` Markus Lidel
2006-10-02 13:03 ` Alan Cox
2006-10-02 13:52 ` chas williams - CONTRACTOR
2006-10-02 15:12 ` Alan Cox
2006-10-02 15:18 ` Matthew Wilcox
2006-10-02 16:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p737izjhwpa.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=Neela.Kolli@engenio.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=greg@kroah.com \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=jeff@garzik.org \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mac@melware.de \
--cc=markus.lidel@shadowconnect.com \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).