From: Andi Kleen <andi@firstfloor.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/8] [TCP]: Uninline tcp_set_state
Date: Thu, 17 Jan 2008 13:41:21 +0100 [thread overview]
Message-ID: <p73myr4bp5a.fsf@bingen.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0801140858040.31652@kivilampi-30.cs.helsinki.fi> ("Ilpo Järvinen"'s message of "Mon\, 14 Jan 2008 09\:20\:26 +0200 \(EET\)")
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi> writes:
>
> Besides, it not always that obvious that gcc is able to determine "the
> constant state", considering e.g., the complexity in the cases with
> tcp_rcv_synsent_state_process, tcp_close_state, tcp_done. In such cases
> uninlining should be done and gcc is probably not able to mix both cases
> nicely for a single function?
I think it would be cleanest to completely unswitch the function
and split into tcp_set_closed() / tcp_set_established() / tcp_other_state()
called by the callers directly.
That would probably lose the state trace, but I never found
that useful for anything.
-Andi
next prev parent reply other threads:[~2008-01-17 12:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 9:40 [PATCH net-2.6.25 0/8] [NET]: More uninlining & related Ilpo Järvinen
2008-01-12 9:40 ` [PATCH 1/8] [TCP]: Uninline tcp_set_state Ilpo Järvinen
2008-01-12 9:40 ` [PATCH 2/8] [TCP]: Uninline tcp_is_cwnd_limited Ilpo Järvinen
2008-01-12 9:40 ` [PATCH 3/8] [XFRM] xfrm_policy: kill some bloat Ilpo Järvinen
2008-01-12 9:40 ` [PATCH 4/8] [IPV6] route: " Ilpo Järvinen
2008-01-12 9:40 ` [PATCH 5/8] [NETLINK] af_netlink: " Ilpo Järvinen
2008-01-12 9:40 ` [PATCH 6/8] [NETFILTER] xt_policy.c: " Ilpo Järvinen
2008-01-12 9:40 ` [PATCH 7/8] [PKTGEN]: Kill dead static inlines Ilpo Järvinen
2008-01-12 9:40 ` [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs Ilpo Järvinen
2008-01-12 12:17 ` Herbert Xu
2008-01-12 12:59 ` Ilpo Järvinen
2008-01-12 21:19 ` Herbert Xu
2008-01-13 4:24 ` David Miller
2008-01-14 7:43 ` Ilpo Järvinen
2008-01-14 7:51 ` David Miller
2008-01-14 8:33 ` Ilpo Järvinen
2008-01-14 8:54 ` David Miller
2008-01-13 4:22 ` David Miller
2008-01-12 21:03 ` [PATCH 1/8] [TCP]: Uninline tcp_set_state Stephen Hemminger
2008-01-12 21:27 ` Arnaldo Carvalho de Melo
2008-01-14 7:20 ` Ilpo Järvinen
2008-01-17 12:41 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-12 9:34 [PATCH net-2.6.25 0/8] [NET]: More uninlining & related Ilpo Järvinen
[not found] ` <12001304691978-git-send-email-ilpo.jarvinen@helsinki.fi>
2008-01-12 11:18 ` [PATCH 1/8] [TCP]: Uninline tcp_set_state David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73myr4bp5a.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).