netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
Cc: netdev@vger.kernel.org, jeff@garzik.org, support@neterion.com
Subject: Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation
Date: 23 Jan 2008 11:58:14 +0100	[thread overview]
Message-ID: <p73odbclsft.fsf@crumb.suse.de> (raw)
In-Reply-To: <Pine.GSO.4.10.10801221942530.24414-100000@guinness>

Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com> writes:

> Multiqueue netwrok device support implementation.
> - Added a loadable parameter "multiq" to enable/disable multiqueue support,
>   by default it is disabled.
> - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is
>   based on IP-TOS value, 0x0-0xF TOS values are mapped to 8 FIFOs.

Standard way to use that would be using skb->priority

But I'm surprised you bother with TOS for multi queues at all. TOS
isn't a too important mechanism.

I would have thought the primary use case would be per CPU TX completion
interrupts. With that the queue should be selected based on
the the current CPU.

-Andi

  parent reply	other threads:[~2008-01-23 10:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23  0:45 [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation Sreenivasa Honnur
2008-01-23  0:55 ` Jeff Garzik
2008-01-23 10:58 ` Andi Kleen [this message]
2008-01-23 20:48   ` Ramkrishna Vepa
2008-01-24  7:25     ` Andi Kleen
2008-01-24  7:30       ` David Miller
2008-01-25  3:19         ` Ramkrishna Vepa
2008-01-25  3:19       ` Ramkrishna Vepa
  -- strict thread matches above, loose matches on Subject: below --
2007-12-26 23:33 Sreenivasa Honnur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73odbclsft.fsf@crumb.suse.de \
    --to=andi@firstfloor.org \
    --cc=Sreenivasa.Honnur@neterion.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=support@neterion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).