netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Holger Hoffstaette" <holger@wizards.de>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: Reproducible data corruption with sendfile+vsftp - splice regression?
Date: Thu, 06 Dec 2007 10:28:09 +0100	[thread overview]
Message-ID: <pan.2007.12.06.09.28.08.913625@wizards.de> (raw)
In-Reply-To: 20071205225429.GA10186@electric-eye.fr.zoreil.com


On Wed, 05 Dec 2007 23:54:29 +0100, Francois Romieu wrote:

> Holger Hoffstaette <holger@wizards.de> : [...]
>> Should I file this in bugzilla?
> 
> Yes.

Thanks for responding - will do. I verified with 2.6.24-rc4 (same bug) and
have some new information about this.
Despite my previous posting the corruption is NOT triggered by NAPI. It
may be related, but even without NAPI but tso on again I got corruption,
now also on the gbit client (Thinkpad T60). When ftp'ing to ramdisk with
full speed (at a reasonable ~77 MB/sec) it "often" works, but intermediate
writes that cause the ftp to temporarily slow down reliably cause
corrupted files, so I guess tso gets confused when some kind of throttling
sets in during transfer. That is probably why I first noticed it on the
slow 100mbit client.
Maybe turning off sendfile or NAPI just lead to random success - so far it
really looks like tso on the r8169 is the common cause.

thank you
Holger



  parent reply	other threads:[~2007-12-06  9:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <pan.2007.11.29.23.42.52.661624@wizards.de>
2007-11-30  8:07 ` Reproducible data corruption with sendfile+vsftp - splice regression? Eric Dumazet
2007-11-30  9:20   ` Holger Hoffstaette
2007-11-30 10:39     ` Holger Hoffstaette
2007-11-30 18:26     ` Rick Jones
2007-12-02 16:00       ` Holger Hoffstaette
2007-12-02 20:49         ` Holger Hoffstaette
2007-12-05 22:54           ` Francois Romieu
2007-12-06  1:13             ` Francois Romieu
2007-12-06  9:41               ` Holger Hoffstaette
2007-12-06  9:28             ` Holger Hoffstaette [this message]
2007-12-06 18:44               ` Francois Romieu
2007-12-08 15:28                 ` Mark Lord
2007-12-13  2:19                 ` Holger Hoffstaette
2007-12-15 10:24                   ` Holger Hoffstaette
2007-12-15 13:43                 ` Holger Hoffstaette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2007.12.06.09.28.08.913625@wizards.de \
    --to=holger@wizards.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).