From: Stefan Roesch <shr@devkernel.io>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Facebook Kernel Team <kernel-team@fb.com>,
Jens Axboe <axboe@kernel.dk>,
Olivier Langlois <olivier@trillion01.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev Mailing List <netdev@vger.kernel.org>,
io-uring Mailing List <io-uring@vger.kernel.org>
Subject: Re: [RFC PATCH v1 3/3] liburing: add test programs for napi busy poll
Date: Mon, 07 Nov 2022 09:58:05 -0800 [thread overview]
Message-ID: <qvqwmt92abow.fsf@dev0134.prn3.facebook.com> (raw)
In-Reply-To: <e62ff9f6-0eea-be82-c357-1081a4d0d100@gnuweeb.org>
Ammar Faizi <ammarfaizi2@gnuweeb.org> writes:
> On 11/4/22 3:40 AM, Stefan Roesch wrote:
>> +void *encodeUserData(char type, int fd)
>> +{
>> + return (void *)((uint32_t)fd | ((__u64)type << 56));
>> +}
> This breaks 32-bit build.
>
> i686-linux-gnu-gcc -Werror -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -g -O3 -Wall -Wextra -Werror -Wno-unused-parameter -Wno-sign-compare -Wstringop-overflow=0 -Warray-bounds=0 -DLIBURING_BUILD_TEST -o napi-busy-poll-client.t napi-busy-poll-client.c helpers.o -L../src/ -luring -lpthread
> napi-busy-poll-client.c: In function ‘encodeUserData’:
> napi-busy-poll-client.c:119:16: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> 119 | return (void *)((uint32_t)fd | ((__u64)type << 56));
> | ^
> cc1: all warnings being treated as errors
>
Version 2 of the patch fixes the above problem.
prev parent reply other threads:[~2022-11-07 18:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 20:40 [RFC PATCH v1 0/3] liburing: add api for napi busy poll timeout Stefan Roesch
2022-11-03 20:40 ` [RFC PATCH v1 1/3] liburing: add api to set " Stefan Roesch
2022-11-03 21:55 ` Ammar Faizi
2022-11-07 17:54 ` Stefan Roesch
2022-11-03 22:09 ` Ammar Faizi
2022-11-07 17:56 ` Stefan Roesch
2022-11-03 20:40 ` [RFC PATCH v1 2/3] liburing: add documentation for new napi busy polling Stefan Roesch
2022-11-03 20:40 ` [RFC PATCH v1 3/3] liburing: add test programs for napi busy poll Stefan Roesch
2022-11-03 22:04 ` Ammar Faizi
2022-11-07 17:57 ` Stefan Roesch
2022-11-03 22:20 ` Ammar Faizi
2022-11-07 17:58 ` Stefan Roesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qvqwmt92abow.fsf@dev0134.prn3.facebook.com \
--to=shr@devkernel.io \
--cc=ammarfaizi2@gnuweeb.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier@trillion01.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).