Re: [RFC PATCH 0/2] ks8851: support for read/write MAC address from EEPROM

[Abraham Arce <abraham.arce.moreno@gmail.com>]

Hi,

> I needed to program a mac address to the companion eeprom of our ks8851, and
> wrote the following patches, which use debug-fs as interface.
>
> I then realized that this seemed not the usual way to access net controller
> eeproms (ethtool seems the more standard way).
>
> I am very interesed in getting your feedbacks on the following:
>  1) Does it make any sense to you to use this debug-fs interface to read/write
> the mac address (advantage: no need for user to know how ks8851 manages the
> eeprom / alignment / offset), and can it be upstreamed?
>  2) Must a more generic eeprom access be implemented through ethtool (or another
> interface?)? Is it the only choice or can it coexist with option 1)? (most of
> code would be common)
>  3) Any feedback regarding the code itself or anything else is very welcome!
>

Does anyone could guide us about the implementation done by Sebastien?

http://patchwork.ozlabs.org/patch/48880/
http://patchwork.ozlabs.org/patch/48881/

Best Regards
Abraham