From: David Dull <monderasdor@gmail.com>
To: longman@redhat.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
lvs-devel@vger.kernel.org, linux-sched@vger.kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
David Dull <monderasdor@gmail.com>
Subject: Re: [PATCH 1/2] sched/isolation: Make HK_TYPE_KTHREAD an alias of HK_TYPE_DOMAIN
Date: Tue, 24 Mar 2026 20:59:29 +0200 [thread overview]
Message-ID: <review-monkeos-20260324@monderasdor> (raw)
In-Reply-To: <20260324151827.2006656-2-longman@redhat.com>
I went through the series.
Patch 1 correctly updates HK_TYPE_KTHREAD to reflect the post-041ee6f3727a
behavior where kthreads follow HK_TYPE_DOMAIN. Keeping it mapped to
HK_TYPE_KERNEL_NOISE is no longer accurate, so the alias is the right fix.
Patch 2 properly introduces RCU protection for accessing the
HK_TYPE_KTHREAD/HK_TYPE_DOMAIN cpumask in IPVS. Since the mask can now
change at runtime, guarding against potential UAF is required. The
changes are minimal and the helper wrappers keep call sites clean.
Reviewed-by: David Dull <monderasdor@gmail.com>
next prev parent reply other threads:[~2026-03-24 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 15:18 [PATCH 0/2] ipvs: Fix incorrect use of HK_TYPE_KTHREAD housekeeping cpumask Waiman Long
2026-03-24 15:18 ` [PATCH 1/2] sched/isolation: Make HK_TYPE_KTHREAD an alias of HK_TYPE_DOMAIN Waiman Long
2026-03-24 18:59 ` David Dull [this message]
2026-03-24 15:18 ` [PATCH 2/2] ipvs: Guard access of HK_TYPE_KTHREAD cpumask with RCU Waiman Long
2026-03-26 8:32 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-monkeos-20260324@monderasdor \
--to=monderasdor@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sched@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox