netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Lunz <lunz@falooley.org>
To: netdev@oss.sgi.com
Subject: Re: [bonding] Add basic support for dynamic configuration of bond interfaces
Date: Mon, 12 Jan 2004 00:13:46 +0000 (UTC)	[thread overview]
Message-ID: <slrnc03pm8.3sp.lunz@orr.homenet> (raw)
In-Reply-To: 4001C72E.8030108@pobox.com

jgarzik@pobox.com said:
> The key question is what is the best interface for userland to configure 
> in-kernel information -that is unrelated to a specific interface-. 
> ethtool ioctl space doesn't apply, because that's a per-interface API.

ethtool is just as bad as brctl or any of the others. From (userland)
ethtool.c:

	static int doit(void)
	{
		struct ifreq ifr;
		int fd;

		/* Setup our control structures. */
		memset(&ifr, 0, sizeof(ifr));
		strcpy(ifr.ifr_name, devname);
		/* Open control socket. */
		fd = socket(AF_INET, SOCK_DGRAM, 0);
		if (fd < 0) {
			perror("Cannot get control socket");
			return 70;
		}

		/* now do ioctl() on fd, having nothing to do with
		 * AF_INET nor SOCK_DGRAM */

calling a spade a spade, and all that. I don't see how that's any better
than brctl. The per-interface only comes into it when you copy a dev
name into a struct ifreq, but that doesn't associate the fd with the
interface in any way. You could go ahead and issue another ioctl on the
same fd for a different interface. 

Jason

  parent reply	other threads:[~2004-01-12  0:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E6F7D288B394A64585E67497E5126BA601F991D1@hasmsx403.iil.intel.com>
2004-01-11 14:28 ` [bonding] Add basic support for dynamic configuration of bond interfaces Amir Noam
2004-01-11 18:30   ` jamal
2004-01-11 19:39   ` Jeff Garzik
2004-01-11 21:34     ` Ben Greear
2004-01-11 21:59       ` Jeff Garzik
2004-01-11 22:50         ` jamal
2004-01-11 22:51         ` Ben Greear
2004-01-12  0:13         ` Jason Lunz [this message]
2004-01-13  2:34           ` Jeff Garzik
2004-01-12 12:38         ` Andi Kleen
2004-01-12 13:51           ` jamal
2004-01-12 15:04             ` Andi Kleen
2004-01-13 12:28               ` jamal
2004-01-13 12:39                 ` Andi Kleen
     [not found] <E6F7D288B394A64585E67497E5126BA601F991D3@hasmsx403.iil.intel.com>
2004-01-14 15:00 ` Amir Noam
2004-01-08 16:19 Amir Noam
2004-01-11  1:34 ` Jeff Garzik
2004-01-12 17:23   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=slrnc03pm8.3sp.lunz@orr.homenet \
    --to=lunz@falooley.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).