From mboxrd@z Thu Jan 1 00:00:00 1970 From: "tip-bot for Paul E. McKenney" Subject: [tip:core/rcu] net/core/skmsg: Replace call_rcu_sched() with call_rcu() Date: Tue, 4 Dec 2018 14:53:25 -0800 Message-ID: Reply-To: john.fastabend@gmail.com, mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, paulmck@linux.ibm.com, daniel@iogearbox.net, netdev@vger.kernel.org, davem@davemloft.net Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: tglx@linutronix.de, john.fastabend@gmail.com, mingo@kernel.org, hpa@zytor.com, netdev@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, paulmck@linux.ibm.com To: linux-tip-commits@vger.kernel.org Return-path: Received: from terminus.zytor.com ([198.137.202.136]:59595 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbeLDWxw (ORCPT ); Tue, 4 Dec 2018 17:53:52 -0500 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: Commit-ID: 0245b80e284d4fdabbf50589180482dc4d2cf277 Gitweb: https://git.kernel.org/tip/0245b80e284d4fdabbf50589180482dc4d2cf277 Author: Paul E. McKenney AuthorDate: Wed, 7 Nov 2018 15:09:25 -0800 Committer: Paul E. McKenney CommitDate: Sat, 1 Dec 2018 12:38:50 -0800 net/core/skmsg: Replace call_rcu_sched() with call_rcu() Now that call_rcu()'s callback is not invoked until after all preempt-disable regions of code have completed (in addition to explicitly marked RCU read-side critical sections), call_rcu() can be used in place of call_rcu_sched(). This commit therefore makes that change. Signed-off-by: Paul E. McKenney Cc: John Fastabend Cc: Daniel Borkmann Cc: "David S. Miller" Cc: --- net/core/skmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skmsg.c b/net/core/skmsg.c index 56a99d0c9aa0..c92d6ccce610 100644 --- a/net/core/skmsg.c +++ b/net/core/skmsg.c @@ -580,7 +580,7 @@ void sk_psock_drop(struct sock *sk, struct sk_psock *psock) write_unlock_bh(&sk->sk_callback_lock); sk_psock_clear_state(psock, SK_PSOCK_TX_ENABLED); - call_rcu_sched(&psock->rcu, sk_psock_destroy); + call_rcu(&psock->rcu, sk_psock_destroy); } EXPORT_SYMBOL_GPL(sk_psock_drop);