From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Subject: Re: [PATCH] net/irda: sh_sir: Add SuperH IrDA driver
Date: Thu, 28 Jan 2010 16:33:03 +0900
Message-ID: <ur5pan0pc.wl%morimoto.kuninori@renesas.com>
References: <uiqam6emt.wl%morimoto.kuninori@renesas.com>
 <20100127220835.287e972d@nehalam>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Cc: netdev@vger.kernel.org, Samuel Ortiz <samuel@sortiz.org>,
	"David S. Miller" <davem@davemloft.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.renesas.com ([202.234.163.13]:59009 "EHLO
	mail03.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754605Ab0A1HdY (ORCPT
	<rfc822;netdev@vger.kernel.org>); Thu, 28 Jan 2010 02:33:24 -0500
In-reply-to: <20100127220835.287e972d@nehalam>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


Dear Stephen

Thank you for checking my code.

> > +struct sh_sir_self {
> > +	void __iomem		*membase;
> > +	unsigned int		 irq;
> > +	struct clk		*clk;
> > +
> > +	struct net_device	*ndev;
> > +
> > +	struct net_device_stats	stats;
> 
> The network device has stats in netdev->stats now
> so devices don't have to keep their own data structure.

Ohh. Thank you I understand.
I will fix it in v2

> Does the device support Fast IR mode?

Sorry. this chip is not advanced one.
it is SIR only

Best regards
--
Kuninori Morimoto