From: andrew hendry <andrew.hendry@gmail.com>
To: John Hughes <john@calva.com>
Cc: netdev@vger.kernel.org
Subject: Re: patch to improve x.25 throughput negotiation
Date: Tue, 6 Apr 2010 22:09:10 +1000 [thread overview]
Message-ID: <v2jd45a3acc1004060509u88f32fa1va0c374154806535b@mail.gmail.com> (raw)
In-Reply-To: <4BB8C2CA.6040102@Calva.COM>
I have reproduced a few ways.
1. X25_MASK_THROUGHPUT on the x25_subscript_struct, then call
SIOCX25SSUBSCRIP, then call SIOCX25FACILITIES without setting the
throughput field. Call connect.
2. No subscrip setting, call SIOCX25FACILITIES without setting the
throughput field. Call connect.
3. No subcrip, no facilities ioctl, call connect.
The patch removes the bad facility and makes the router accept the
call for the above cases.
I don't currently have a setup to test both direction throughput negotiation.
Tested-by: Andrew Hendry <andrew.hendry@gmail.com>
On Mon, Apr 5, 2010 at 2:48 AM, John Hughes <john@calva.com> wrote:
> The current X.25 code has some bugs in throughput negotiation:
>
> 1. It does negotiation in all cases, usually there is no need
> 2. It incorrectly attempts to negotiate the throughput class in one
> direction only. There are separate throughput classes for input
> and output and if either is negotiated both mist be negotiates.
>
> This is bug https://bugzilla.kernel.org/show_bug.cgi?id=15681
>
> This bug was first reported by Daniel Ferenci to the linux-x25 mailing list
> on 6/8/2004, but is still present.
>
>
next prev parent reply other threads:[~2010-04-06 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 16:48 patch to improve x.25 throughput negotiation John Hughes
2010-04-06 12:09 ` andrew hendry [this message]
2010-04-07 8:39 ` John Hughes
2010-04-08 4:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v2jd45a3acc1004060509u88f32fa1va0c374154806535b@mail.gmail.com \
--to=andrew.hendry@gmail.com \
--cc=john@calva.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).