From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 460A9C43381 for ; Tue, 19 Feb 2019 10:15:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B803217D7 for ; Tue, 19 Feb 2019 10:15:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="LOcoEHc4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbfBSKPg (ORCPT ); Tue, 19 Feb 2019 05:15:36 -0500 Received: from mail-eopbgr130041.outbound.protection.outlook.com ([40.107.13.41]:65114 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726385AbfBSKPg (ORCPT ); Tue, 19 Feb 2019 05:15:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tVFHXThqQDXgq03u5A2x6PsglawEUt9lxbMEphEKEWA=; b=LOcoEHc4osW0nlfMF5XP/QL2tdy5Cc9uDTm1tSgIMfLAvefA24Pp3teG6ugaAOBJ+TA1ECzpah17mMOefOmN3VqnFMc7+zr3yywUJNkTiMk6JfFAePUMU078SR7BDjMRkmA926+90rB4D3DtqUwE2DwjYA78TN8RGJxhu9XCsDw= Received: from VI1PR0502MB3647.eurprd05.prod.outlook.com (52.134.7.141) by VI1PR0502MB2894.eurprd05.prod.outlook.com (10.175.24.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.16; Tue, 19 Feb 2019 10:15:30 +0000 Received: from VI1PR0502MB3647.eurprd05.prod.outlook.com ([fe80::d058:d17:78fc:969a]) by VI1PR0502MB3647.eurprd05.prod.outlook.com ([fe80::d058:d17:78fc:969a%6]) with mapi id 15.20.1622.018; Tue, 19 Feb 2019 10:15:30 +0000 From: Vlad Buslov To: Cong Wang CC: Linux Kernel Network Developers , Jamal Hadi Salim , Jiri Pirko , David Miller Subject: Re: [PATCH net-next 12/12] net: sched: flower: set unlocked flag for flower proto ops Thread-Topic: [PATCH net-next 12/12] net: sched: flower: set unlocked flag for flower proto ops Thread-Index: AQHUxDmnanzBPn19/ECJA8YcLER+oqXl93WAgAD4JwA= Date: Tue, 19 Feb 2019 10:15:30 +0000 Message-ID: References: <20190214074712.17846-1-vladbu@mellanox.com> <20190214074712.17846-13-vladbu@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0113.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::29) To VI1PR0502MB3647.eurprd05.prod.outlook.com (2603:10a6:803:f::13) authentication-results: spf=none (sender IP is ) smtp.mailfrom=vladbu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 99504227-1a42-4444-e26e-08d696532d27 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0502MB2894; x-ms-traffictypediagnostic: VI1PR0502MB2894: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1;VI1PR0502MB2894;23:zRa4hGQnZE7mX8CG+UkVL7yNhK1D358l6uWel?= =?iso-8859-1?Q?2/kFmbGwP308m5/Ogu8tgu0qu6zEmWLwtNKlwSt4TIHCoIgHPrd2ePjrGM?= =?iso-8859-1?Q?i0cVZcZV4fFYn8YQxM7fwjXTbTE3/xUF3uuGuGYIMtuOxqizG7Z5vZQBQg?= =?iso-8859-1?Q?dS8YsgabjVuxrOF9jEtQItSHpBTAYPnrzw/8QKH5V8HZcv0Wp80fAhgr0G?= =?iso-8859-1?Q?7/q0cHVnfWuFjb1MEcLFtGT1ajvO0KsHsMVtKmKBP0hz/v3O76K9NNqXrE?= =?iso-8859-1?Q?uE/X42dnGiBLYMJidjTSZWt627Pl2MAbzcvaxyqRntbSYaDhB7pENyzH3I?= =?iso-8859-1?Q?xWydy4cLm3lFjqLSLXLUXM5FLki8rC+MQR6VvD+yARCamtsCUG3qaM6DmH?= =?iso-8859-1?Q?anhpJWmHrLBXzru7G3Sxjq0pz8kKGp2pDbpxKDxrCnTy1jzcH4A1yKVZgj?= =?iso-8859-1?Q?FV+Xmz4hwqiALzPP4vfIBUMWpQ/s9RBMlA0oTzkUetqNHOxONiD5hHvi1y?= =?iso-8859-1?Q?rTrTpvDPQsS1WUtiuSnlGlliUo8ql/me163PILr17WvuU4TiWT8LOtzyb1?= =?iso-8859-1?Q?pwcLW8RYRUtADl0zd2srjDb0A3CJGi2wSyqJmCKoBZ2C+JERC2kkCeaOVs?= =?iso-8859-1?Q?fEuqCqPUD5rkkuShpsuYU07s8tYLtPUIErtAQMOXPHtEy4h/t7hrGt9BSe?= =?iso-8859-1?Q?9PpXnKyYD9fLrZIDQvT+wMDpLCc0IEjMVcP33BDBf94NhtCW1r1tt7bss9?= =?iso-8859-1?Q?+ZYzP2KQe/oTT4b4GZ9xcy/pvsYQCWN30xpR7ppNbtGdewvY6qbRfXmaLP?= =?iso-8859-1?Q?HYPrut7/MFOl5Zauux6kYISWC0tIkebZEfdYfuBRf4A+E7dyoEFnAXjJ6Q?= =?iso-8859-1?Q?qgOu6FPnPGoiNMyQlDOEfQwX3Awfy/2jn+Q92/P/oUGWACiuWLkJUw+nBC?= =?iso-8859-1?Q?qc0vCIniM0YRfQUQloh/UwU9SIfmluGPDviImQATzeCxb1IQa+oknErZlT?= =?iso-8859-1?Q?wckMedX2qajmyv6cEKCQ34hHCf1YAojcq9cwzrC1conLdz/TeZ/A3rA2yx?= =?iso-8859-1?Q?W8chj6AbcIpHe0EzEno0EZwEENqjneRovxQ4NcRjBZXEbYRlBg+7P4//UW?= =?iso-8859-1?Q?lxkSoFmMG3ObayEbkkqkyeX4fGLjUSJ1TlF9Hv1RdydWhrKZvnS6H4NQlv?= =?iso-8859-1?Q?Ea2NXm3e6iiVLWmlo3DLptASAgIQO3nG3q/1df2n4xjw+EZW9MvHHlZj8w?= =?iso-8859-1?Q?Vj7wnxiqcSxeBOy55RdMZlKNltoN5jzlhb6XnRIhv6Zvx4mtVhSX4NRq/T?= =?iso-8859-1?Q?5ImisGb4oUVqURacQ8kQnswQS?= x-microsoft-antispam-prvs: x-forefront-prvs: 09538D3531 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(136003)(366004)(396003)(39860400002)(346002)(54534003)(199004)(189003)(102836004)(305945005)(2906002)(7736002)(53546011)(36756003)(8676002)(86362001)(6246003)(66066001)(6506007)(386003)(52116002)(256004)(5660300002)(26005)(14444005)(6512007)(97736004)(3846002)(6116002)(71200400001)(316002)(53936002)(68736007)(71190400001)(81156014)(6916009)(14454004)(4326008)(99286004)(54906003)(76176011)(81166006)(11346002)(6436002)(106356001)(478600001)(186003)(25786009)(8936002)(6486002)(446003)(2616005)(476003)(486006)(229853002)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0502MB2894;H:VI1PR0502MB3647.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WDDZjrzJMsk9z4DpTjtV2EHHfGCTfGCaGLolI9tsuScKy7fbmS46L/9lMywOv+uc5T7/PDQ4GVOTWGcI76+6zQmCuui1Cl4kPLfFAR092nE1JQubYca59JGZi4emuwa9AaZe0I9bY/wNSRTyztigiInTud/zv6cnmd2Jn1wdlA/EYxG7niFXf6NfOQ45fEXO1WeT5pI3+d/zm1L+Vh/zBSZLZUXI/4KZjUKric09Xvm4SP+VzkqIu8p+vVvZfjCCrYT+sc9gLl7hkhXTR5awQjaZrTGQVuM71wNJY3RCbNDGzRFl7DqL0NqsiXd/aW9ydQ8l6t+ljn915nZuwAupXAVWaFJH781534DpCjBP2bG3cQcSuXwbEdZqRwctYUehq2EmJy1mBH192Xs951F0jmhk549zFNkTvNwXIPuVkIQ= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99504227-1a42-4444-e26e-08d696532d27 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2019 10:15:29.6639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB2894 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon 18 Feb 2019 at 19:27, Cong Wang wrote: > On Wed, Feb 13, 2019 at 11:47 PM Vlad Buslov wrote: >> >> Set TCF_PROTO_OPS_DOIT_UNLOCKED for flower classifier to indicate that i= ts >> ops callbacks don't require caller to hold rtnl lock. > > So, if this means RTNL is gone for all cls_flower changes, why > do I still see rtnl_lock() in cls_flower.c after all your patches in > this set? It doesn't say that rtnl lock is gone, what it says is that caller doesn't have to obtain rtnl lock before calling flower ops callbacks. > > For instance: > > 366 static void fl_destroy_filter_work(struct work_struct *work) > 367 { > 368 struct cls_fl_filter *f =3D container_of(to_rcu_work(work), > 369 struct cls_fl_filter, rwork)= ; > 370 > 371 rtnl_lock(); > 372 __fl_destroy_filter(f); > 373 rtnl_unlock(); > 374 } This shouldn't be needed. Thanks for spotting it. > > and... > > 382 if (!rtnl_held) > 383 rtnl_lock(); > > ... > > 1436 if (!rtnl_held) > 1437 rtnl_lock(); Drivers assume rtnl lock, so flower obtains it before calling offloads API. > > > Please explain in your changelog, otherwise it is very confusing. Sorry for not making this stuff clear. I will expand cover letter with more details. > > Thanks.