* [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode
@ 2020-03-21 4:39 wenxu
2020-03-21 4:39 ` [PATCH net-next v3 1/2] net/mlx5e: refactor indr setup block wenxu
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: wenxu @ 2020-03-21 4:39 UTC (permalink / raw)
To: saeedm; +Cc: paulb, vladbu, netdev
From: wenxu <wenxu@ucloud.cn>
wenxu (2):
net/mlx5e: refactor indr setup block
net/mlx5e: add mlx5e_rep_indr_setup_ft_cb support
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 94 ++++++++++++++++++------
1 file changed, 73 insertions(+), 21 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH net-next v3 1/2] net/mlx5e: refactor indr setup block 2020-03-21 4:39 [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode wenxu @ 2020-03-21 4:39 ` wenxu 2020-03-23 13:44 ` Vlad Buslov 2020-03-21 4:39 ` [PATCH net-next v3 2/2] net/mlx5e: add mlx5e_rep_indr_setup_ft_cb support wenxu 2020-03-23 13:42 ` [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode Vlad Buslov 2 siblings, 1 reply; 5+ messages in thread From: wenxu @ 2020-03-21 4:39 UTC (permalink / raw) To: saeedm; +Cc: paulb, vladbu, netdev From: wenxu <wenxu@ucloud.cn> Refactor indr setup block for support ft indr setup in the next patch Signed-off-by: wenxu <wenxu@ucloud.cn> --- v3: no change drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 42 ++++++++++++------------ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index a33d151..057f5f9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -694,9 +694,9 @@ static void mlx5e_rep_indr_clean_block_privs(struct mlx5e_rep_priv *rpriv) static int mlx5e_rep_indr_offload(struct net_device *netdev, struct flow_cls_offload *flower, - struct mlx5e_rep_indr_block_priv *indr_priv) + struct mlx5e_rep_indr_block_priv *indr_priv, + unsigned long flags) { - unsigned long flags = MLX5_TC_FLAG(EGRESS) | MLX5_TC_FLAG(ESW_OFFLOAD); struct mlx5e_priv *priv = netdev_priv(indr_priv->rpriv->netdev); int err = 0; @@ -717,20 +717,22 @@ static void mlx5e_rep_indr_clean_block_privs(struct mlx5e_rep_priv *rpriv) return err; } -static int mlx5e_rep_indr_setup_block_cb(enum tc_setup_type type, - void *type_data, void *indr_priv) +static int mlx5e_rep_indr_setup_tc_cb(enum tc_setup_type type, + void *type_data, void *indr_priv) { + unsigned long flags = MLX5_TC_FLAG(EGRESS) | MLX5_TC_FLAG(ESW_OFFLOAD); struct mlx5e_rep_indr_block_priv *priv = indr_priv; switch (type) { case TC_SETUP_CLSFLOWER: - return mlx5e_rep_indr_offload(priv->netdev, type_data, priv); + return mlx5e_rep_indr_offload(priv->netdev, type_data, priv, + flags); default: return -EOPNOTSUPP; } } -static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) +static void mlx5e_rep_indr_block_unbind(void *cb_priv) { struct mlx5e_rep_indr_block_priv *indr_priv = cb_priv; @@ -741,9 +743,10 @@ static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) static LIST_HEAD(mlx5e_block_cb_list); static int -mlx5e_rep_indr_setup_tc_block(struct net_device *netdev, - struct mlx5e_rep_priv *rpriv, - struct flow_block_offload *f) +mlx5e_rep_indr_setup_block(struct net_device *netdev, + struct mlx5e_rep_priv *rpriv, + struct flow_block_offload *f, + flow_setup_cb_t *setup_cb) { struct mlx5e_rep_indr_block_priv *indr_priv; struct flow_block_cb *block_cb; @@ -769,9 +772,8 @@ static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) list_add(&indr_priv->list, &rpriv->uplink_priv.tc_indr_block_priv_list); - block_cb = flow_block_cb_alloc(mlx5e_rep_indr_setup_block_cb, - indr_priv, indr_priv, - mlx5e_rep_indr_tc_block_unbind); + block_cb = flow_block_cb_alloc(setup_cb, indr_priv, indr_priv, + mlx5e_rep_indr_block_unbind); if (IS_ERR(block_cb)) { list_del(&indr_priv->list); kfree(indr_priv); @@ -786,9 +788,7 @@ static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) if (!indr_priv) return -ENOENT; - block_cb = flow_block_cb_lookup(f->block, - mlx5e_rep_indr_setup_block_cb, - indr_priv); + block_cb = flow_block_cb_lookup(f->block, setup_cb, indr_priv); if (!block_cb) return -ENOENT; @@ -802,13 +802,13 @@ static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) } static -int mlx5e_rep_indr_setup_tc_cb(struct net_device *netdev, void *cb_priv, - enum tc_setup_type type, void *type_data) +int mlx5e_rep_indr_setup_cb(struct net_device *netdev, void *cb_priv, + enum tc_setup_type type, void *type_data) { switch (type) { case TC_SETUP_BLOCK: - return mlx5e_rep_indr_setup_tc_block(netdev, cb_priv, - type_data); + return mlx5e_rep_indr_setup_block(netdev, cb_priv, type_data, + mlx5e_rep_indr_setup_tc_cb); default: return -EOPNOTSUPP; } @@ -820,7 +820,7 @@ static int mlx5e_rep_indr_register_block(struct mlx5e_rep_priv *rpriv, int err; err = __flow_indr_block_cb_register(netdev, rpriv, - mlx5e_rep_indr_setup_tc_cb, + mlx5e_rep_indr_setup_cb, rpriv); if (err) { struct mlx5e_priv *priv = netdev_priv(rpriv->netdev); @@ -834,7 +834,7 @@ static int mlx5e_rep_indr_register_block(struct mlx5e_rep_priv *rpriv, static void mlx5e_rep_indr_unregister_block(struct mlx5e_rep_priv *rpriv, struct net_device *netdev) { - __flow_indr_block_cb_unregister(netdev, mlx5e_rep_indr_setup_tc_cb, + __flow_indr_block_cb_unregister(netdev, mlx5e_rep_indr_setup_cb, rpriv); } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v3 1/2] net/mlx5e: refactor indr setup block 2020-03-21 4:39 ` [PATCH net-next v3 1/2] net/mlx5e: refactor indr setup block wenxu @ 2020-03-23 13:44 ` Vlad Buslov 0 siblings, 0 replies; 5+ messages in thread From: Vlad Buslov @ 2020-03-23 13:44 UTC (permalink / raw) To: wenxu; +Cc: saeedm, paulb, vladbu, netdev On Sat 21 Mar 2020 at 06:39, wenxu@ucloud.cn wrote: > From: wenxu <wenxu@ucloud.cn> > > Refactor indr setup block for support ft indr setup in the > next patch Description of why this refactoring is needed and details of the change would be nice. > > Signed-off-by: wenxu <wenxu@ucloud.cn> > --- > v3: no change > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 42 ++++++++++++------------ > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > index a33d151..057f5f9 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > @@ -694,9 +694,9 @@ static void mlx5e_rep_indr_clean_block_privs(struct mlx5e_rep_priv *rpriv) > static int > mlx5e_rep_indr_offload(struct net_device *netdev, > struct flow_cls_offload *flower, > - struct mlx5e_rep_indr_block_priv *indr_priv) > + struct mlx5e_rep_indr_block_priv *indr_priv, > + unsigned long flags) > { > - unsigned long flags = MLX5_TC_FLAG(EGRESS) | MLX5_TC_FLAG(ESW_OFFLOAD); > struct mlx5e_priv *priv = netdev_priv(indr_priv->rpriv->netdev); > int err = 0; > > @@ -717,20 +717,22 @@ static void mlx5e_rep_indr_clean_block_privs(struct mlx5e_rep_priv *rpriv) > return err; > } > > -static int mlx5e_rep_indr_setup_block_cb(enum tc_setup_type type, > - void *type_data, void *indr_priv) > +static int mlx5e_rep_indr_setup_tc_cb(enum tc_setup_type type, > + void *type_data, void *indr_priv) > { > + unsigned long flags = MLX5_TC_FLAG(EGRESS) | MLX5_TC_FLAG(ESW_OFFLOAD); > struct mlx5e_rep_indr_block_priv *priv = indr_priv; > > switch (type) { > case TC_SETUP_CLSFLOWER: > - return mlx5e_rep_indr_offload(priv->netdev, type_data, priv); > + return mlx5e_rep_indr_offload(priv->netdev, type_data, priv, > + flags); > default: > return -EOPNOTSUPP; > } > } > > -static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) > +static void mlx5e_rep_indr_block_unbind(void *cb_priv) > { > struct mlx5e_rep_indr_block_priv *indr_priv = cb_priv; > > @@ -741,9 +743,10 @@ static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) > static LIST_HEAD(mlx5e_block_cb_list); > > static int > -mlx5e_rep_indr_setup_tc_block(struct net_device *netdev, > - struct mlx5e_rep_priv *rpriv, > - struct flow_block_offload *f) > +mlx5e_rep_indr_setup_block(struct net_device *netdev, > + struct mlx5e_rep_priv *rpriv, > + struct flow_block_offload *f, > + flow_setup_cb_t *setup_cb) > { > struct mlx5e_rep_indr_block_priv *indr_priv; > struct flow_block_cb *block_cb; > @@ -769,9 +772,8 @@ static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) > list_add(&indr_priv->list, > &rpriv->uplink_priv.tc_indr_block_priv_list); > > - block_cb = flow_block_cb_alloc(mlx5e_rep_indr_setup_block_cb, > - indr_priv, indr_priv, > - mlx5e_rep_indr_tc_block_unbind); > + block_cb = flow_block_cb_alloc(setup_cb, indr_priv, indr_priv, > + mlx5e_rep_indr_block_unbind); > if (IS_ERR(block_cb)) { > list_del(&indr_priv->list); > kfree(indr_priv); > @@ -786,9 +788,7 @@ static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) > if (!indr_priv) > return -ENOENT; > > - block_cb = flow_block_cb_lookup(f->block, > - mlx5e_rep_indr_setup_block_cb, > - indr_priv); > + block_cb = flow_block_cb_lookup(f->block, setup_cb, indr_priv); > if (!block_cb) > return -ENOENT; > > @@ -802,13 +802,13 @@ static void mlx5e_rep_indr_tc_block_unbind(void *cb_priv) > } > > static > -int mlx5e_rep_indr_setup_tc_cb(struct net_device *netdev, void *cb_priv, > - enum tc_setup_type type, void *type_data) > +int mlx5e_rep_indr_setup_cb(struct net_device *netdev, void *cb_priv, > + enum tc_setup_type type, void *type_data) > { > switch (type) { > case TC_SETUP_BLOCK: > - return mlx5e_rep_indr_setup_tc_block(netdev, cb_priv, > - type_data); > + return mlx5e_rep_indr_setup_block(netdev, cb_priv, type_data, > + mlx5e_rep_indr_setup_tc_cb); > default: > return -EOPNOTSUPP; > } > @@ -820,7 +820,7 @@ static int mlx5e_rep_indr_register_block(struct mlx5e_rep_priv *rpriv, > int err; > > err = __flow_indr_block_cb_register(netdev, rpriv, > - mlx5e_rep_indr_setup_tc_cb, > + mlx5e_rep_indr_setup_cb, > rpriv); > if (err) { > struct mlx5e_priv *priv = netdev_priv(rpriv->netdev); > @@ -834,7 +834,7 @@ static int mlx5e_rep_indr_register_block(struct mlx5e_rep_priv *rpriv, > static void mlx5e_rep_indr_unregister_block(struct mlx5e_rep_priv *rpriv, > struct net_device *netdev) > { > - __flow_indr_block_cb_unregister(netdev, mlx5e_rep_indr_setup_tc_cb, > + __flow_indr_block_cb_unregister(netdev, mlx5e_rep_indr_setup_cb, > rpriv); > } ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next v3 2/2] net/mlx5e: add mlx5e_rep_indr_setup_ft_cb support 2020-03-21 4:39 [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode wenxu 2020-03-21 4:39 ` [PATCH net-next v3 1/2] net/mlx5e: refactor indr setup block wenxu @ 2020-03-21 4:39 ` wenxu 2020-03-23 13:42 ` [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode Vlad Buslov 2 siblings, 0 replies; 5+ messages in thread From: wenxu @ 2020-03-21 4:39 UTC (permalink / raw) To: saeedm; +Cc: paulb, vladbu, netdev From: wenxu <wenxu@ucloud.cn> Add mlx5e_rep_indr_setup_ft_cb to support indr block setup in FT mode. Signed-off-by: wenxu <wenxu@ucloud.cn> --- v2: rebase to the master v3: fix reverse xmas tree style drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 52 ++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index 057f5f9..30c81c3 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -732,6 +732,55 @@ static int mlx5e_rep_indr_setup_tc_cb(enum tc_setup_type type, } } +static int mlx5e_rep_indr_setup_ft_cb(enum tc_setup_type type, + void *type_data, void *indr_priv) +{ + struct mlx5e_rep_indr_block_priv *priv = indr_priv; + struct flow_cls_offload *f = type_data; + struct flow_cls_offload tmp; + struct mlx5e_priv *mpriv; + struct mlx5_eswitch *esw; + unsigned long flags; + int err; + + mpriv = netdev_priv(priv->rpriv->netdev); + esw = mpriv->mdev->priv.eswitch; + + flags = MLX5_TC_FLAG(EGRESS) | + MLX5_TC_FLAG(ESW_OFFLOAD) | + MLX5_TC_FLAG(FT_OFFLOAD); + + switch (type) { + case TC_SETUP_CLSFLOWER: + memcpy(&tmp, f, sizeof(*f)); + + if (!mlx5_esw_chains_prios_supported(esw)) + return -EOPNOTSUPP; + + /* Re-use tc offload path by moving the ft flow to the + * reserved ft chain. + * + * FT offload can use prio range [0, INT_MAX], so we normalize + * it to range [1, mlx5_esw_chains_get_prio_range(esw)] + * as with tc, where prio 0 isn't supported. + * + * We only support chain 0 of FT offload. + */ + if (tmp.common.prio >= mlx5_esw_chains_get_prio_range(esw)) + return -EOPNOTSUPP; + if (tmp.common.chain_index != 0) + return -EOPNOTSUPP; + + tmp.common.chain_index = mlx5_esw_chains_get_ft_chain(esw); + tmp.common.prio++; + err = mlx5e_rep_indr_offload(priv->netdev, &tmp, priv, flags); + memcpy(&f->stats, &tmp.stats, sizeof(f->stats)); + return err; + default: + return -EOPNOTSUPP; + } +} + static void mlx5e_rep_indr_block_unbind(void *cb_priv) { struct mlx5e_rep_indr_block_priv *indr_priv = cb_priv; @@ -809,6 +858,9 @@ int mlx5e_rep_indr_setup_cb(struct net_device *netdev, void *cb_priv, case TC_SETUP_BLOCK: return mlx5e_rep_indr_setup_block(netdev, cb_priv, type_data, mlx5e_rep_indr_setup_tc_cb); + case TC_SETUP_FT: + return mlx5e_rep_indr_setup_block(netdev, cb_priv, type_data, + mlx5e_rep_indr_setup_ft_cb); default: return -EOPNOTSUPP; } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode 2020-03-21 4:39 [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode wenxu 2020-03-21 4:39 ` [PATCH net-next v3 1/2] net/mlx5e: refactor indr setup block wenxu 2020-03-21 4:39 ` [PATCH net-next v3 2/2] net/mlx5e: add mlx5e_rep_indr_setup_ft_cb support wenxu @ 2020-03-23 13:42 ` Vlad Buslov 2 siblings, 0 replies; 5+ messages in thread From: Vlad Buslov @ 2020-03-23 13:42 UTC (permalink / raw) To: wenxu; +Cc: saeedm, paulb, vladbu, netdev On Sat 21 Mar 2020 at 06:39, wenxu@ucloud.cn wrote: > From: wenxu <wenxu@ucloud.cn> Hi wenxu, Can you please provide some description for this functionality and example commands that can be used to test it? > > > wenxu (2): > net/mlx5e: refactor indr setup block > net/mlx5e: add mlx5e_rep_indr_setup_ft_cb support > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 94 ++++++++++++++++++------ > 1 file changed, 73 insertions(+), 21 deletions(-) ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-23 13:44 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-21 4:39 [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode wenxu 2020-03-21 4:39 ` [PATCH net-next v3 1/2] net/mlx5e: refactor indr setup block wenxu 2020-03-23 13:44 ` Vlad Buslov 2020-03-21 4:39 ` [PATCH net-next v3 2/2] net/mlx5e: add mlx5e_rep_indr_setup_ft_cb support wenxu 2020-03-23 13:42 ` [PATCH net-next v3 0/2] net/mlx5e: add indr block support in the FT mode Vlad Buslov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).