From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA5CBC43381 for ; Mon, 18 Feb 2019 12:26:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DC70218AD for ; Mon, 18 Feb 2019 12:26:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="Zi+CoDKv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730876AbfBRM0l (ORCPT ); Mon, 18 Feb 2019 07:26:41 -0500 Received: from mail-eopbgr10051.outbound.protection.outlook.com ([40.107.1.51]:37344 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728874AbfBRM0k (ORCPT ); Mon, 18 Feb 2019 07:26:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gTqT7FrdhGUi/xrZp2kq47rMkdwA/7JVb9Qlq8dGfE4=; b=Zi+CoDKvxJVf8yawjf3h+cFjdqBFWJo3AVzltK2qgKey9OXXPIxCtqkq3yPZeuz0dzby5r4ssCTlmbXfgZCC1xcaRqfM8i4l88j2IcUj77Jcv7W/OdmKOaW1HgDdiBtfrQ99mVa66+JltxUlqN8KHCXtgHRCmt+RC8haWILhuaE= Received: from HE1PR0502MB3641.eurprd05.prod.outlook.com (10.167.127.11) by HE1PR0502MB3020.eurprd05.prod.outlook.com (10.175.32.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.16; Mon, 18 Feb 2019 12:26:36 +0000 Received: from HE1PR0502MB3641.eurprd05.prod.outlook.com ([fe80::4041:bb68:2af3:eab8]) by HE1PR0502MB3641.eurprd05.prod.outlook.com ([fe80::4041:bb68:2af3:eab8%5]) with mapi id 15.20.1622.018; Mon, 18 Feb 2019 12:26:36 +0000 From: Vlad Buslov To: Dan Carpenter CC: Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH net-next] net: sched: potential NULL dereference in tcf_block_find() Thread-Topic: [PATCH net-next] net: sched: potential NULL dereference in tcf_block_find() Thread-Index: AQHUx2wT+H+jH5fRhk25JcWXbUrhnqXleuqA Date: Mon, 18 Feb 2019 12:26:35 +0000 Message-ID: References: <20190218092632.GB7712@kadam> In-Reply-To: <20190218092632.GB7712@kadam> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0423.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::27) To HE1PR0502MB3641.eurprd05.prod.outlook.com (2603:10a6:7:85::11) authentication-results: spf=none (sender IP is ) smtp.mailfrom=vladbu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 795aea50-c629-4724-632e-08d6959c52d9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:HE1PR0502MB3020; x-ms-traffictypediagnostic: HE1PR0502MB3020: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1;HE1PR0502MB3020;23:6Ky/bBbomq8Fu8T7PTGbGvRU/auD2C4GBIi8y?= =?iso-8859-1?Q?IcJsrEYiAOqRnzImdMF8FJqLe0OL0ctMo6fM+V3yK1yHXizJP6kJKQwZRg?= =?iso-8859-1?Q?U39Bh1tpkXo+YLBd7v9odTTyiFg/pVtp0KGFFd1HMLNIHIAgrlKCGtXGN3?= =?iso-8859-1?Q?gIQbFL4VMsBvlppI84T1PA+y0jtpJKQUQjO3kQ61w2eaqjVF29ZOZt78Dc?= =?iso-8859-1?Q?XNPCBJFsVfcyeiNgxijylvDvAdMVVhjoEf9TjA21ySPr8Ex9q/KAuFyau5?= =?iso-8859-1?Q?uLVb4G0G5Sy18vYKLBMxC5/r8OS8HQIsQsS/nCBoga1/5O5CM2BEKNvXeX?= =?iso-8859-1?Q?c1Jm8MPlI3NDPuLLh9CO1hnLNf9kmpSC7Ze+rJxpQg7AO3Fx2AyYoY/uKi?= =?iso-8859-1?Q?UlxkUXExnLZybHFMf7d+sOzJZnLQ1XKDzEf4T9MLQbfzKLVJalVp1VzbTu?= =?iso-8859-1?Q?RfsQYDaNP6gklAWyycIpnXcqVlZxgx09g+m8z9oHoSdupGjBDfpqmf5oy+?= =?iso-8859-1?Q?ppkKf6gowCtec00VWMCtMKfn5YLjfJgoL08UjYEScXS7ry0Emgtgw4NmWb?= =?iso-8859-1?Q?f0bnE077a2i0NQwCPLXU2oxihxfLwUun3OFS6kqzQlHF5qzN33HosPLBrN?= =?iso-8859-1?Q?Xq+RZvK4PRVk21qZSQoarpp/OmKox6x09wqZUEXRbkFFRq9dFdqmC2SMu9?= =?iso-8859-1?Q?bh2/mlnVRGjrMYqClWTCg7vp/4eCeH4bm1/p4T09CYSuh86c+Pio5H8KHL?= =?iso-8859-1?Q?eZNGmAmgst7qM3rPbPgYR0aavcOSNoilkrZ2XHOEICtBVKT3fwDPpk3oRg?= =?iso-8859-1?Q?7SwWlSIMfjFbJk3wODUc/35INq5GTvbfaizw0k6vnNAV+QFmTnWZguFllt?= =?iso-8859-1?Q?oMMklwhABDci9P52SXQUnMAIJ5GUm2WZ4truqsI3fVLWr8IGtfCwW7SNm+?= =?iso-8859-1?Q?RDNkYuU2waS4CTlnjCEgsqWD1ecoyGZgd0Volrh377btAfWYwyFOqUTfUA?= =?iso-8859-1?Q?DDyRa6Ow9fgfWYx7GiX6ygpGx4jIs9SGeNgMu8bBKSe3Kmz0ZJQ31RmVZE?= =?iso-8859-1?Q?fZmHlCr8t3XZh/F10DMcWGcGO1EopfLFKoNhHPnjSgDBydQFvxgz2MuDSL?= =?iso-8859-1?Q?kTZYBQ/voz/TAR+2zd4oX4iAvR2MZV2kH+e766qWpN5BK54Dntx/gNqeC1?= =?iso-8859-1?Q?hVLE/4i//msLqL/AYEYMNis1tAqyf1BGLYQYcvfJIueCmpd8F140NDCc/V?= =?iso-8859-1?Q?TkoX0sRlO/C6g7HWVWVf98NqNkbK9JDVKvig04Iqg=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09525C61DB x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(366004)(396003)(376002)(39860400002)(136003)(189003)(199004)(7736002)(81166006)(305945005)(36756003)(6506007)(386003)(8936002)(106356001)(8676002)(86362001)(105586002)(52116002)(6436002)(53936002)(6512007)(6116002)(3846002)(2906002)(6916009)(6486002)(81156014)(229853002)(68736007)(99286004)(97736004)(76176011)(316002)(11346002)(478600001)(54906003)(5660300002)(102836004)(4744005)(2616005)(71200400001)(71190400001)(4326008)(256004)(186003)(476003)(6246003)(26005)(14454004)(486006)(446003)(25786009)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0502MB3020;H:HE1PR0502MB3641.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: oWTyrzksASIYbdC7N+bxMWBDlP8qmEWYhJERJGgTqKWhz0tkQBAGm6OhecogNfcoIzaXhAvWkuaypUQrC7Nm2A0vhyXk0p3kSNk0PRVcuo9Bq2EVxOhPfyEpF4X9DJt6xPXZz9Am695JCXR759zWNJg7KfPhxmSVyVh+rXGMgXsaL4xc4fsioTYW3UHZtidR3nkSqeVVBYq3jRX1couOydAePg5p4Xi6oDrX2h2x2Yiw6Fgl3C2vrno3Rf8Mt7xBGyYsc8kvigCFGMJDFvSKxsGnH8ysZMlFO4Alyf8sbnDgCeMOVXQ8a9qf2pdUMIKTGlJQ9PuI3WjAHMci8uJDzXv7e6YcLf5sOo044daSJAvJ1DSdD9aJxy9u2faRg46HKJCs47DpHVu0RNghIxj1jsyH6hog+x1hLoiaDE8R86k= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 795aea50-c629-4724-632e-08d6959c52d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2019 12:26:34.7042 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3020 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon 18 Feb 2019 at 09:26, Dan Carpenter wrote= : > The error code isn't set on this path so it would result in returning > ERR_PTR(0) and a NULL dereference in the caller. > > Fixes: 18d3eefb17cf ("net: sched: refactor tcf_block_find() into standalo= ne functions") > Signed-off-by: Dan Carpenter Hi Dan, Thank you for finding and fixing this! Regards, Vlad