From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vlad Buslov <vladbu@mellanox.com>
Subject: Re: [PATCH net-next 02/17] net: sched: protect block state with
 spinlock
Date: Tue, 13 Nov 2018 13:28:00 +0000
Message-ID: <vbfh8gljeea.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
References: <1542009346-23780-1-git-send-email-vladbu@mellanox.com>
 <1542009346-23780-3-git-send-email-vladbu@mellanox.com>
 <20181112.092859.498970939054805019.davem@davemloft.net>
 <20181113110712.4462807a@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>
To: Stefano Brivio <sbrivio@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-eopbgr80075.outbound.protection.outlook.com ([40.107.8.75]:22144
        "EHLO EUR04-VI1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1732728AbeKMX0N (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 13 Nov 2018 18:26:13 -0500
In-Reply-To: <20181113110712.4462807a@redhat.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


On Tue 13 Nov 2018 at 10:07, Stefano Brivio <sbrivio@redhat.com> wrote:
> Vlad,
>
> On Mon, 12 Nov 2018 09:28:59 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Vlad Buslov <vladbu@mellanox.com>
>> Date: Mon, 12 Nov 2018 09:55:31 +0200
>>=20
>> > +#define ASSERT_BLOCK_LOCKED(block)					\
>> > +	WARN_ONCE(!spin_is_locked(&(block)->lock),		\
>> > +		  "BLOCK: assertion failed at %s (%d)\n", __FILE__,  __LINE__) =20
>>=20
>> spin_is_locked() is not usable for assertions.
>
> See also b86077207d0c ("igbvf: Replace spin_is_locked() with
> lockdep").

Stefano,

Thanks for the tip. I will check it out.

Vlad.