From: Vlad Buslov <vladbu@mellanox.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Yevgeny Kliteynik <kliteyn@mellanox.com>,
Yossef Efraim <yossefe@mellanox.com>,
Maor Gottlieb <maorg@mellanox.com>
Subject: tc filter insertion rate degradation
Date: Mon, 21 Jan 2019 11:24:44 +0000 [thread overview]
Message-ID: <vbfmunui7dm.fsf@mellanox.com> (raw)
Hi Eric,
I've been investigating significant tc filter insertion rate degradation
and it seems it is caused by your commit 001c96db0181 ("net: align
gnet_stats_basic_cpu struct"). With this commit insertion rate is
reduced from ~65k rules/sec to ~43k rules/sec when inserting 1m rules
from file in tc batch mode on my machine.
Tc perf profile indicates that pcpu allocator now consumes 2x CPU:
1) Before:
Samples: 63K of event 'cycles:ppp', Event count (approx.): 48796480071
Children Self Co Shared Object Symbol
+ 21.19% 3.38% tc [kernel.vmlinux] [k] pcpu_alloc
+ 3.45% 0.25% tc [kernel.vmlinux] [k] pcpu_alloc_area
2) After:
Samples1: 92K of event 'cycles:ppp', Event count (approx.): 71446806550
Children Self Co Shared Object Symbol
+ 44.67% 3.99% tc [kernel.vmlinux] [k] pcpu_alloc
+ 19.25% 0.22% tc [kernel.vmlinux] [k] pcpu_alloc_area
It seems that it takes much more work for pcpu allocator to perform
allocation with new stricter alignment requirements. Not sure if it is
expected behavior or not in this case.
Regards,
Vlad
next reply other threads:[~2019-01-21 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 11:24 Vlad Buslov [this message]
2019-01-22 17:33 ` tc filter insertion rate degradation Eric Dumazet
2019-01-22 21:18 ` Tejun Heo
2019-01-22 22:40 ` Eric Dumazet
2019-01-24 17:21 ` Dennis Zhou
2019-01-29 19:22 ` Vlad Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vbfmunui7dm.fsf@mellanox.com \
--to=vladbu@mellanox.com \
--cc=edumazet@google.com \
--cc=kliteyn@mellanox.com \
--cc=maorg@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yossefe@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).