From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vlad Buslov <vladbu@mellanox.com>
Subject: Re: [PATCH net-next v4 00/11] Modify action API for implementing lockless actions
Date: Thu, 31 May 2018 15:38:53 +0300
Message-ID: <vbfmuwgf19e.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
References: <1527753499-32124-1-git-send-email-vladbu@mellanox.com> <262fbd11-401e-90cf-4226-39b1604eb16d@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: netdev@vger.kernel.org, davem@davemloft.net,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, pablo@netfilter.org,
        kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org,
        daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org,
        marcelo.leitner@gmail.com, kliteyn@mellanox.com
To: Jamal Hadi Salim <jhs@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-he1eur01on0063.outbound.protection.outlook.com ([104.47.0.63]:48601
        "EHLO EUR01-HE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1754733AbeEaMjT (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 31 May 2018 08:39:19 -0400
In-reply-to: <262fbd11-401e-90cf-4226-39b1604eb16d@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


On Thu 31 May 2018 at 10:01, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> Hi Vlad,
>
> Can you try one simple test below with these patches?
>
> #create an action
> sudo $TC actions add action skbedit mark 1 pipe
> #
> sudo $TC qdisc del dev lo parent ffff:
> sudo $TC qdisc add dev lo ingress
> # bind action to filter....
> sudo $TC filter add dev lo parent ffff: protocol ip prio 1 \
> u32 match ip dst 127.0.0.1/32 flowid 1:1 action skbedit index 1
>
> #now delete that action multiple times while it is still bound
> sudo $TC actions del action skbedit index 1
> sudo $TC actions del action skbedit index 1
> sudo $TC actions del action skbedit index 1
>
> #check the refcount and bindcount
> sudo $TC -s actions ls action skbedit
>
> #delete the filter (which should remove the bindcnt)
>
> sudo $TC filter del dev lo parent ffff: protocol ip prio 1 \
> u32 match ip dst 127.0.0.1/32 flowid 1:1
>
> #check the refcount and bindcount
> sudo $TC -s actions ls action skbedit
>
> Current behavior: i believe the action is gone in this last step.
> Your patches may change behavior so that the action action is still
> around. I dont think this is a big deal, but just wanted to be sure
> it is not something more unexpected.
>
> cheers,
> jamal

Hi Jamal,

On current net-next I still have action with single reference after last
step:
~$ sudo $TC -s actions ls action skbedit                       
total acts 1                                                   
                                                               
        action order 0:  skbedit mark 1 pipe                   
         index 1 ref 2 bind 1 installed 47 sec used 47 sec     
        Action statistics:                                     
        Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
        backlog 0b 0p requeues 0                               
~$ sudo $TC filter del dev lo parent ffff: protocol ip prio 1 \
> u32 match ip dst 127.0.0.1/32 flowid 1:1                     
~$ sudo $TC -s actions ls action skbedit                       
total acts 1                                                   
                                                               
        action order 0:  skbedit mark 1 pipe                   
         index 1 ref 1 bind 0 installed 80 sec used 80 sec     
        Action statistics:                                     
        Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
        backlog 0b 0p requeues 0                               

Which branch are you testing on?

Regards,
Vlad