From: Vlad Buslov <vladbu@mellanox.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Vlad Buslov <vladbu@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"davem@davemloft.net" <davem@davemloft.net>,
Saeed Mahameed <saeedm@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
tanhuazhong <tanhuazhong@huawei.com>
Subject: Re: [PATCH net-next 2/2] net/mlx5e: Move local var definition into ifdef block
Date: Thu, 29 Aug 2019 16:13:56 +0000 [thread overview]
Message-ID: <vbfo908ne4k.fsf@mellanox.com> (raw)
In-Reply-To: <365fea71-4f35-188d-89e1-d8b97e3df141@cogentembedded.com>
On Thu 29 Aug 2019 at 12:29, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> Hello!
>
> On 28.08.2019 19:41, Vlad Buslov wrote:
>
>> New local variable "struct flow_block_offload *f" was added to
>> mlx5e_setup_tc() in recent rtnl lock removal patches. The variable is used
>> in code that is only compiled when CONFIG_MLX5_ESWITCH is enabled. This
>> results compilation warning about unused variable when CONFIG_MLX5_ESWITCH
>> is not set. Move the variable definition into eswitch-specific code block
>> from the begging of mlx5e_setup_tc() function.
>
> Beginning?
Yep. Thanks for spotting it!
>
>> Fixes: c9f14470d048 ("net: sched: add API for registering unlocked offload block callbacks")
>> Reported-by: tanhuazhong <tanhuazhong@huawei.com>
>> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
> [...]
>
> MBR, Sergei
prev parent reply other threads:[~2019-08-29 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 16:41 [PATCH net-next 0/2] Fixes for unlocked cls hardware offload API refactoring Vlad Buslov
2019-08-28 16:41 ` [PATCH net-next 1/2] net: sched: cls_matchall: cleanup flow_action before deallocating Vlad Buslov
2019-08-28 16:41 ` [PATCH net-next 2/2] net/mlx5e: Move local var definition into ifdef block Vlad Buslov
2019-08-29 9:29 ` Sergei Shtylyov
2019-08-29 16:13 ` Vlad Buslov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vbfo908ne4k.fsf@mellanox.com \
--to=vladbu@mellanox.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tanhuazhong@huawei.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).